08:03:16 <yasufum-o> #startmeeting tacker
08:03:16 <opendevmeet> Meeting started Tue May 17 08:03:16 2022 UTC and is due to finish in 60 minutes.  The chair is yasufum-o. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:03:16 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:03:16 <opendevmeet> The meeting name has been set to 'tacker'
08:05:25 <yasufum-o> We has a discussion for making some basic guidelines which function should be tested.
08:05:47 <yasufum-o> The first item is update for the discussion from caishuwen.
08:06:08 <yasufum-o> caishuwen: can you start from your topic?
08:06:51 <caishuwen_> OK.
08:07:01 <yasufum-o> #link https://etherpad.opendev.org/p/tacker-meeting
08:09:44 <caishuwen_> In the last meeting, we discussed topic about UT for v2. And hope that based on our UT list, we can summarize the common UT guideline.
08:10:40 <caishuwen_> So the method we are scheduled to test can be seen in the following link.
08:10:50 <caishuwen_> https://hackmd.io/LKR1Ix_AQQWXanXOp-J22Q
08:11:40 <caishuwen_> In this list, we summarize the general categories of these methods.
08:12:00 <caishuwen_> 1. Lifecycle related public methods
08:12:01 <caishuwen_> 2. Common methods in utils
08:12:01 <caishuwen_> 3. Error_handling related public methods
08:12:01 <caishuwen_> 4. Nfvo-related public methods
08:12:01 <caishuwen_> 5. Subcriptions related public methods
08:12:01 <caishuwen_> 6. Vnflcm_View related public methods
08:12:03 <caishuwen_> 7. DB related public methods
08:13:26 <caishuwen_> So, should we discuss the future guidelines of UT based on the above categories?
08:14:18 <caishuwen_> The above is my opinion, do you have any opinions?
08:15:36 <yasufum-o> I don't have any comment for the categories.
08:18:56 <yasufum-o> Any other comments?
08:19:36 <ueha> Is the priority of the above category basically high?
08:23:12 <yasufum-o> hello?
08:23:49 <yasufum-o> ueha: The answer might be yes.
08:25:40 <ueha> yasufum-o: Thanks. One more question, there are high priority and middle priority among 1 and 3, but by what criteria are they divided?
08:26:07 <yasufum-o> I'm also not still sure how the priority is decided.
08:28:03 <caishuwen_> This priority is only the priority that I plan to do this time, and has nothing to do with categories. If time permits, all of them will be done. If time does not allow, the content with higher priority will be done first.
08:29:13 <caishuwen_> Since the content in controller.py has been verified by FT, we do not plan to do it first this time.
08:31:25 <yasufum-o> I don't agree with you for the comment actually.
08:33:31 <yasufum-o> Even if a function has a dedicated FT,
08:34:08 <yasufum-o> we need to have UT if the function should be tested with several patterns.
08:35:40 <yasufum-o> For example, if the function can take several patterns of args, it should be tested with several cases.
08:35:59 <yasufum-o> FT does not cover such a situation.
08:36:05 <yasufum-o> What do you think?
08:37:16 <caishuwen_> yes. indeed every case needs to be tested.
08:37:21 <takahashi-tsc> Agree, UT priority discussion should be separated from FT implement.
08:40:40 <yasufum-o> caishuwen: Do you have any other idea for the priority?
08:40:59 <caishuwen_> It's just that at present, we don't have time to do UT of all methods, and we think that the methods in controller.py are unlikely to have errors, so the methods in it do not have a high priority for UT testing. For future development, UT must be covered in every case.
08:41:11 <caishuwen_> My point of view is that in the future development, the methods involving the above 7 categories should be tested for each case.
08:42:13 <yasufum-o> Yes, I understand the puropose of suggestion.
08:45:25 <yasufum-o> Umm...
08:45:51 <w-juso> sorry, I can't find controller.py, do you mean the controller directory?
08:46:21 <caishuwen__> The first three categories keep the whole system running, while 4-5 external NFVO and Subscription are used less frequently. But with 6, I'm not sure about its priority, because it seems that vnflcm_view is important to the user.
08:47:36 <caishuwen__> w-juso>sorry, I mean this file: tacker/tacker/sol_refactored/controller/vnflcm_v2.py
08:47:57 <w-juso> thank you
08:51:27 <yasufum-o> IMO, it seems difficult to introduce general guidelines for the priority if you have no idea other than the categories ...
08:53:56 <yasufum-o> I think it's OK to start to implememnt tests from the top of the list.
08:55:15 <yasufum-o> Any other comment?
08:55:54 <takahashi-tsc> Fully agree... I also think it seems difficult. Anyway, it's OK to start from the top.
08:56:27 <takahashi-tsc> But this categories and list is very useful for discussion. Thank you so much!
08:57:23 <yasufum-o> The most important thing for the topic is start to implement soon :)
08:57:46 <takahashi-tsc> +1
08:57:50 <ueha> +1, It may be difficult to make guidelines for future developers to create UTs..
08:57:56 <yasufum-o> caishuwen: Thanks for your proposal and future contributions for UT!
08:58:39 <yasufum-o> Thanks for the discussion.
08:58:49 <yasufum-o> So, go to the next topic.
08:59:13 <yasufum-o> #topic BP for DB migration tool
09:00:10 <yasufum-o> h-asahina: Can you share your topic shortly?
09:00:18 <h-asahina> sure
09:00:53 <h-asahina> basically this topic is to ma-ooyama:
09:01:44 <h-asahina> according to our previous discussion here, I submitted BP for DB migration for v1 API refactoring.
09:02:56 <h-asahina> as of now, it's just an announcement, but if you have any idea to progress this work now, I'd like to hear.
09:04:17 <yasufum-o> thanks
09:05:51 <ma-ooyama> Thanks.
09:07:07 <ma-ooyama> I don't have any idea now.
09:07:20 <ma-ooyama> We look foward to more information.
09:07:38 <h-asahina> so will I
09:08:27 <h-asahina> can I set you as the assignee of this BP?
09:08:53 <h-asahina> so that we can discuss on the BP
09:10:09 <ma-ooyama> my pleasure.
09:10:36 <h-asahina> good! thank you
09:10:57 <yasufum-o> BTW, do you have any idea for target release or milestone for now?
09:13:07 <ma-ooyama> We don't have now.
09:13:16 <ma-ooyama> We'll discuss it and share our opinion after that here.
09:13:45 <yasufum-o> OK
09:14:11 <yasufum-o> other comments?
09:14:49 <yasufum-o> good
09:15:09 <yasufum-o> All topics done for today.
09:16:51 <yasufum-o> So, close this meeting if no more comments or topics.
09:17:25 <yasufum-o> Thank you for joining, bye!
09:17:33 <ma-ooyama> bye
09:17:35 <ueha> thanks, bye
09:17:37 <manpreetk> bye
09:17:38 <yuta-kazato> bye!
09:17:40 <masaki-ueno> bye
09:17:40 <yu-kinjo> bye
09:17:41 <caishuwen__> bye!
09:17:42 <takahashi-tsc> bye
09:17:43 <h-asahina> bye
09:17:45 <Ramona-ho-xu> bye
09:17:48 <w-juso> bye
09:17:55 <yasufum-o> #endmeeting