08:02:59 <yasufum> #startmeeting tacker
08:02:59 <opendevmeet> Meeting started Tue Sep 13 08:02:59 2022 UTC and is due to finish in 60 minutes.  The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:02:59 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:02:59 <opendevmeet> The meeting name has been set to 'tacker'
08:03:34 <yasufum> #link https://etherpad.opendev.org/p/tacker-meeting
08:04:02 <yasufum> There are two items on the etherpad
08:04:27 <yasufum> from ma-ooyama for both.
08:04:55 <yasufum> So, can we start from the first item?
08:05:02 <ma-ooyama> Sure, first topic is about the review request for a db migration tool .
08:05:02 <yasufum> #topic review request for a db migration tool
08:05:34 <ma-ooyama> sorry for being late, but we would like you to review it.
08:05:53 <ma-ooyama> It is in WIP state now, but is going to be done today. we would be grateful if you check the tool.
08:07:02 <yasufum> Is there any reason why WIP is still remained?
08:08:10 <ma-ooyama> Some test patterns are left.
08:09:46 <yasufum> Do you mean some more tests will be added to current WIP patch?
08:11:33 <ma-ooyama> No. We are going to test some case in our environment. If some problems occurs, the patch may be fixed.
08:15:17 <yasufum> I'd like to know how many line of codes can be changed from the current patch.
08:15:36 <yasufum> in the next update
08:16:35 <ma-ooyama> Each UT works, so there will be not so many changes, I guess.
08:19:06 <yasufum> OK, I understand it's not clear for now.
08:19:28 <yasufum> Any other comment?
08:19:46 <ma-ooyama> Yes. Sorry for not being clear.
08:24:32 <yasufum> As you may know, it's just three days left for the end of R-3
08:24:35 <yasufum> #link https://releases.openstack.org/zed/schedule.html
08:25:48 <yasufum> The size of your patch is about 2500 lines, and it's more than I've expected actually...
08:27:44 <yasufum> It might not be able to complete possibly in this release
08:28:58 <ma-ooyama> I know... sorry for being late
08:29:16 <yasufum> Anyway, please update your patch asap, thanks.
08:29:49 <ma-ooyama> Sure. Thanks.
08:31:24 <yasufum> OK, move on to the next item.
08:31:46 <yasufum> #topic About stack_name compatibility
08:31:50 <ma-ooyama> sure, second topic is about  stack_name compatibility.
08:32:02 <ma-ooyama> While implementing a db migration tool, we found that lcm operataion for v2 instance migrated by the tool doesn't work, because the stack names are different between v1 api and v2 api
08:32:19 <ma-ooyama> In v2 api, the get_stack_name function in heat_utils.py returns stack name as "vnf-<vnf_id>".
08:32:29 <ma-ooyama> https://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/infra_drivers/openstack/heat_utils.py#L196
08:32:41 <ma-ooyama> But stack name used in v1 api is like "vnflcm_<vnf_id>" or "<vnf_name>_<vnf_id>".
08:32:51 <ma-ooyama> Refering to the heat document, stack name can't be renamed after it has been launched.
08:33:02 <ma-ooyama> https://docs.openstack.org/heat/latest/getting_started/create_a_stack.html#launching-a-stack
08:33:11 <ma-ooyama> Considering future api refactoring, we think the get_stack_name function should be fixed to be compatible with v1 api.
08:33:32 <ma-ooyama> I would like to know your opinion.
08:35:36 <yasufum> thanks
08:36:44 <yasufum> I'd like to confirm about your suggestion.
08:38:55 <yasufum> Do you want to change which of behavior of API if it's needed? Or any other way to keep the compatibility?
08:39:46 <yasufum> I'm not sure about your concern exactly.
08:42:25 <ma-ooyama> I proposed the get_stack_name function should search the correct name. Because the name of "vnf-<vnf_id>" doesn't match in v1 api.
08:43:29 <ma-ooyama> If the function get correct stack name, I think other process in v2 will work.
08:44:29 <hirofumi-noguchi> Is get_stack_name function in Tacker implementation?
08:44:53 <ma-ooyama> Yes.
08:44:54 <ma-ooyama> https://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/infra_drivers/openstack/heat_utils.py#L196
08:45:19 <hirofumi-noguchi> You mean some Tacker's functions regarding to get the vnf instance information needs to be modified.
08:45:26 <hirofumi-noguchi> Is my understanding correct?
08:46:03 <ma-ooyama> Yes.
08:46:16 <hirofumi-noguchi> Thanks, I got it.
08:47:36 <hirofumi-noguchi> I agree with your suggestion because as you mentioned, the stack-name cannot be changed by Heat specification.
08:48:26 <hirofumi-noguchi> Tacker has to handle difference between the v1 and v2 stack-name.
08:50:40 <hirofumi-noguchi> Now, I have no other idea. If someone have another ideas. please share.
08:53:24 <ma-ooyama> I think the function should be changed to search both v2 and v1 stack name patterns to heat, and return the hit name.
08:57:00 <yasufum> Thanks.
08:58:04 <yasufum> ma-ooyama: Could you make a request on our launchpad? We can continue to discussion how we fix the issue on that.
08:58:23 <ma-ooyama> Sure.
08:58:25 <yasufum> And a patch for the fix will be uploaded then hopefully.
08:59:02 <ueha> Just information, the following patch changes `stack_id` to be stored in VnfInstantiatedInfo.metadata.
08:59:06 <ueha> https://review.opendev.org/c/openstack/tacker/+/855444/12/tacker/sol_refactored/infra_drivers/openstack/heat_utils.py#204
09:00:02 <ueha> Similarly, if you have `stack_name` in it during db migration, I think you can use it. It's just an idea, so it may not go well..
09:01:22 <ueha> I hope it helps you. thanks.
09:01:27 <ma-ooyama> It looks useful. I'll confirm the patch later. Thanks!
09:01:34 <ueha> :)
09:04:26 <yasufum> OK
09:05:13 <yasufum> It seems enough for the topic.
09:05:30 <ma-ooyama> Yes, thanks.
09:06:29 <yasufum> So, let's close this meeting if there're no comments or topics.
09:07:15 <ueha> Regarding the releasenote coverage of topic last week, we (FJ) have posted all the releasenote patches for the ones that need releasenote.
09:07:36 <yasufum> Thanks.
09:07:55 <ueha> thanks for your reviewing too. :)
09:09:38 <yasufum> OK, thanks for joining, bye!
09:09:47 <ueha> Thanks, bye
09:09:50 <manpreetk> Bye
09:09:53 <ma-ooyama> thanks, bye
09:10:01 <yuta-kazato> bye
09:10:03 <masaki-ueno> bye
09:10:11 <hirofumi-noguchi> bye
09:10:14 <yasufum> #endmeeting