08:01:15 <yasufum> #startmeeting tacker
08:01:15 <opendevmeet> Meeting started Tue Feb  6 08:01:15 2024 UTC and is due to finish in 60 minutes.  The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:01:15 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:01:15 <opendevmeet> The meeting name has been set to 'tacker'
08:01:22 <yasufum> #link https://etherpad.opendev.org/p/tacker-meeting
08:01:51 <yasufum> So, let's start the meeting.
08:03:42 <yasufum> The first item is a bug report for a old topic.
08:03:45 <yasufum> #link https://bugs.launchpad.net/tacker/+bug/1629173
08:04:55 <aaina> Hi everyone..I am Aaina Lohia and I just started working for NEC
08:05:03 <yasufum> hi
08:05:04 <yasufum> welcome
08:05:19 <yasufum> It looks not so critical for me.
08:05:40 <yasufum> And Importance is "wishlist".
08:05:54 <aaina> I was working on this bug: https://bugs.launchpad.net/tacker/+bug/1629173 and I found it to be invalid. The message mentioned in the bug is displayed when we delete a vnf using Legacy API command which will be removed in the next release. I don't know if it has been discussed previously
08:06:42 <aaina> I can change the status to won't fix.. but I am unable to choose that option
08:07:07 <yasufum> It's too old actually, and I don't know about the status of the issue at least.
08:07:12 <renu> I would like to discuss topic "Regarding zuul job for compliance test in tacker from non-voting state to Voting"
08:07:46 <yasufum> renu: ok, sure
08:08:41 <renu> The discussion is for fix approach
08:08:49 <yasufum> ok
08:09:12 <aaina> I investigated this on the master branch anf found it invalid https://usercontent.irccloud-cdn.com/file/gxHaPQOG/image.png
08:10:43 <renu> We are working on zuul job for compliance test in tacker is in non-voting state. (https://bugs.launchpad.net/tacker/+bug/2021454)
08:11:17 <renu> During the analysis we observed multiple issues around the datatype mismatch in api response.
08:12:08 <yasufum> aaina: anyway, I can change the status to "won't fix".
08:12:39 <aaina> ok, thanks!
08:12:44 <renu> Current error is ‘operationParam’ is not type of object.
08:13:57 <yasufum> renu: OK, I'm on the your item.
08:14:00 <renu> As per current tacker implementation the operationParams is a string type however as per ETSI NFV-SOL003v020601p specification document (https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/003/02.06.01_60/gs_NFV-SOL003v020601p.pdf)it should be object type.
08:14:55 <renu> As per our analysis the tacker code needs to fix the operationParams data type from string to object type.
08:15:41 <renu> But the impact of such changes seems to be big. The impacted areas are out of API , changes in DB also (Table vnf_lcm_op_occs will be impacted as currently data type of operation_params is longtext.)
08:16:17 <renu> We would like to know community members suggestion and input for fix approach.
08:17:54 <yasufum> renu: thanks
08:18:15 <yasufum> Is there any comment for the fix?
08:21:05 <yasufum> renu: Could you tell me exactly where the error message is happened?
08:21:50 <renu> The error is coming while running the compliance test example: tacker.tests.compliance.sol003.test_vnflcm.IndividualVnfLcmOperationOccurenceTest.test_get_ind_vnf_lcm_op_occs
08:22:13 <renu> the error message is : <status status="FAIL" starttime="20230904 08:49:24.324" endtime="20230904 08:49:24.423" critical="yes">ValidationError: Validation error for schema VnfLcmOpOcc.schema.json: '{"flavourId": "simple", "extVirtualLinks": [{"id": "net0", "resourceId": "c4370d60-e1bf-4608-be5c-5fc5d31d9b3a", "extCps": [{"cpdId": "CP1", "cpConfig": [{"cpProtocolData": [{"layerProtocol": "IP_OVER_ETHERNET"}]}]}]}], "vimConnectionInfo"
08:22:41 <yasufum> Please wait a moment, I'm finding ...
08:23:47 <renu> In NFV-TST 010 “ ~/api-tests/SOL003/VNFLifecycleManagement-API/schemas/ VnfLcmOpOcc.schema.json” file, there is validation check that operationParams should be of object type  as per SOL specification.
08:24:06 <yasufum> It must be here.
08:24:08 <yasufum> #link https://github.com/openstack/tacker/blob/c738e956c62b64a42b1cbec120c31ff38d964cb1/tacker/tests/compliance/sol003/test_vnflcm.py#L226
08:30:11 <renu> https://opendev.org/openstack/tacker/src/branch/master/tacker/objects/vnf_lcm_op_occs.py#L235  --> code the  pperationParams is defined as string 'operation_params': fields.StringField(nullable=True),
08:30:16 <yasufum> I'm not still sure it's OK just convert the datatype.
08:30:41 <yasufum> But It might be work.
08:31:09 <yasufum> So, I'm not opposite for your proposal.
08:32:36 <renu> Also https://github.com/openstack/tacker/blob/c738e956c62b64a42b1cbec120c31ff38d964cb1/tacker/api/vnflcm/v1/controller.py#L304  line the operation_params is populated.
08:32:57 <yasufum> OK, thanks.
08:33:31 <renu> The compliance API validation code is --> https://forge.etsi.org/rep/nfv/api-tests/-/blob/2.8.1-fix-plu/SOL003/VNFLifecycleManagement-API/schemas/VnfLcmOpOcc.schema.json#L42
08:34:15 <yasufum> Anyway, please provide a bug report on lauhchpad, and add a link to the error the message on zuul if we can see it.
08:34:17 <yasufum> Thanks
08:34:53 <renu> ok
08:35:13 <yasufum> Is there any other comment on the proposal, guys?
08:35:20 <yasufum> Or we can go to the next topic?
08:35:22 <renu> Thanks
08:35:37 <yasufum> renu: you're welcome.
08:36:03 <yasufum> good
08:36:21 <yasufum> k-fukayan: could you share your item?
08:36:53 <fukaya> Yes
08:37:56 <fukaya> my topic is alert to new Patch Creation
08:38:11 <renu> We need to create a bug with detail bug report for this and link it with compliance "https://bugs.launchpad.net/tacker/+bug/1629173"
08:38:34 <renu> Just for confirmation, Is this correct understanding.
08:39:18 <yasufum> renu: perfect, thanks.
08:39:50 <renu> Thanks a lot for confirmation.
08:39:52 <yasufum> oops
08:40:12 <yasufum> just wait
08:40:39 <yasufum> Is it the same issue with 1629173?
08:43:09 <yasufum> I've simply asked to add a new bug report for the your issue.
08:43:36 <renu> ok
08:43:40 <yasufum> thanks
08:44:24 <yasufum> fukaya: sorry, please go on.
08:44:56 <fukaya> my topic is alert to new Patch Creation.
08:45:18 <fukaya> I upload new patch.
08:45:31 <fukaya> https://review.opendev.org/c/openstack/tacker/+/907170
08:45:54 <fukaya> this patch have many changes for directory and filename.
08:46:07 <fukaya> please be careful conflicts, if you create and upload new patch.
08:46:53 <fukaya> that's all my topic
08:47:29 <yasufum> fukaya: thanks
08:49:20 <yasufum> He and Itsuro have uploaded a terminate huge useless warning messages caused while running all tests for which we've been annoyed so much.
08:51:13 <ueha> Thank you for your notice. I was just deleting a lot of files in response to the Legacy API, so there's probably a lot of conflict ...
08:51:23 <ueha> Anyway, I will share the information to our team.
08:51:46 <yasufum> Sure, thanks kindly.
08:53:35 <yasufum> fukaya: and final one is just for asking review, right?
08:54:15 <fukaya> yes, please review this patch.
08:54:33 <fukaya> https://review.opendev.org/c/openstack/tacker/+/903726
08:55:01 <yasufum> OK, thanks.
08:55:50 <ueha> fukaya: Thanks, this is my posted patch.
08:56:30 <yasufum> Thank you all.
08:56:43 <ueha> takahashi-tsc: It's not a big patch, so please review it. thanks
08:57:19 <yasufum> So, let's wrap up the meeting if no other comments.
08:57:20 <takahashi-tsc> Sure, I will do it ASAP.
08:57:28 <takahashi-tsc> Sorry for the late
08:57:45 <ueha> no problem, thank you
08:59:30 <yasufum> thanks
08:59:46 <yasufum> See you next week, bye!
08:59:55 <ueha> thanks, bye
09:00:07 <yasufum> #endmeeting