17:00:35 #startmeeting training-guides 17:00:39 Meeting started Mon Sep 12 17:00:35 2016 UTC and is due to finish in 60 minutes. The chair is matjazp. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:00:39 hey all 17:00:40 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 17:00:43 The meeting name has been set to 'training_guides' 17:00:51 roll call 17:02:57 hi, matjazp ! 17:03:00 anyone here for the meeting? 17:03:18 hey ianychoi 17:03:33 #link Agenda at https://etherpad.openstack.org/p/training-guides-meeting-agenda 17:03:41 Hello 17:03:52 hey diablo_rojo_phon 17:04:16 Hello, diablo_rojo_phon ! 17:04:28 #topic Review of action items from the previous meeting 17:04:38 see meeting minutes at http://eavesdrop.openstack.org/meetings/training_guides/2016/training_guides.2016-09-05-17.00.html 17:05:39 aha, ianychoi has a patch for this in queue, if I'm not mistaken 17:06:03 so nothing to review here, we'll do patches later 17:06:17 #topic Upstream training 17:06:19 Yep, I have just seen your +1 review, thanks matjazp ! 17:06:36 #link https://etherpad.openstack.org/p/upstream-university-improvements 17:06:52 #info Upstream training virtual sprint September 12-13 and 16: https://wiki.openstack.org/wiki/VirtualSprints#Upstream_training_Sprint 17:07:12 Review queue: 17:07:20 DONE: Remove rejoin-stack.sh from the Devstack slides: https://review.openstack.org/#/c/366316/ 17:07:40 still need eyes on: 17:07:44 Improvements to the contribution process section: https://review.openstack.org/#/c/366255/ 17:07:46 Thank you! 17:08:03 #link Improvements to the contribution process section: https://review.openstack.org/#/c/366255/ 17:08:13 #link New introduction block: https://review.openstack.org/#/c/366893/ 17:08:26 #link Add #openstack-101 to meetbot channels: https://review.openstack.org/#/c/367005/ 17:09:01 did I miss something? 17:09:15 oh, right, gerrit workflow reorder 17:09:33 diablo_rojo_phon: I think the order is fine as is 17:09:49 diablo_rojo_phon: why do you think it should be different? 17:09:58 #link https://review.openstack.org/#/c/368889/ 17:11:19 It's different than the normal workflow. 17:11:26 Or mine anyway. 17:11:28 ianychoi: can you look at it and comment? Do you work differently? 17:12:00 diablo_rojo_phon: true, it could be different.. but as it is the same as http://docs.openstack.org/infra/manual/developers.html#development-workflow, I think we should leave it? what do you think? 17:12:10 I do work differently. Not sure why you'd ask people to review before pushing the patch. 17:12:28 not review, just setup 17:12:29 But if it's just me I can abandon it. 17:12:56 diablo_rojo_phon: no, lets just leave it and we can gather some more comments 17:13:15 Okay sounds good. 17:14:23 revamping module 19 is nearly finished, right? 17:14:27 IMO it doesn't matter 17:14:48 Executing "git review -s" just before "git commit" would be fine 17:15:42 It's in progress. I just need to add exercises. 17:16:14 ianychoi: yes it would. I see git review -s as a part of the git repo clone process.. so the inner loop is different (modify, add, commit, review) 17:16:41 diablo_rojo_phon: do you think you can add exercises in a separate patch? 17:17:27 does it make sense? 17:17:50 I'm telling this because I prefer smaller patches 17:18:20 Yeah it will be a separate patch. 17:18:24 diablo_rojo_phon, I would suggest in module 14 to add 1) run tox instead of unit tests 2) git review before "invite reviewers" 3) leaving a comment before exercise.. 17:18:26 but it can go in one if you prefer 17:18:51 ianychoi: don't forget to comment in gerrit ;) 17:19:06 matjazp, sure :) 17:19:35 diablo_rojo_phon, I can do it if you agree with me, of course 17:21:32 so the focus of current virtual sprint is still contribution and intro, right? 17:23:56 btw: we didn't use RST "code-block" for console commands in upstream training, but I think it is better that we switch to it. For larger code blocks we would need to fix font size 17:25:47 what do you think? 17:26:04 I agree with matjazp 17:27:41 ok, moving on 17:27:45 Hmm.. okay 17:28:18 #info we use ".. code-block:: console" for console commands in slides 17:28:58 I have another pain point to discuss 17:29:14 Trainees can loose track of the slide deck that the presenter is showing on screen (when using full screen view, URL is usually not visible) 17:29:23 We could additionally generate one slide deck with all the slides (in PDF format?), so trainees can just sync with slide numbers? 17:30:01 Hmm.. recently I am doing some research on using rst2pdf 17:30:24 ianychoi: yes, that was the trigger that reminded me of this issue 17:30:26 I am not currently sure whether PDF slides are fine with rst2pdf. 17:30:42 #link https://review.openstack.org/#/c/364477/ 17:31:07 I have proposed it as the next goal :) 17:31:21 I see 17:31:57 hmm, we could easily generate a single all-slides deck 17:32:37 or, as an alternative, presenter could deliberately leave URL bar visible 17:34:22 ok, for this sprint, we still concentrate on common items and code contribution 17:34:33 #link https://etherpad.openstack.org/p/upstream-uni-common-items 17:34:44 #link https://etherpad.openstack.org/p/upstream-uni-code-contribution 17:35:10 just mark what are you working on so that we dont duplicate effort 17:35:38 is there anything else that needs discuccing here? 17:36:13 discuccing=discussing 17:36:17 Sorry was in another meeting. I can make the Gerrit changes here shortly. 17:36:48 diablo_rojo_phon: np. you need anything else to discuss for upstream training? 17:37:05 diablo_rojo_phon, okay I see 17:39:00 move on to aob? 17:39:08 No I don't think so. If anyone had ideas they'd like to see for code contribution exercises let me know :) 17:39:18 Actually today and tomorrow are sprints day. 17:39:43 So I encourage us to use #openstack-sprint channel for today and tomorrow :) 17:40:51 ok 17:40:58 #topic any other business 17:41:13 anything left to discuss? 17:41:40 I have one for discussion: What would be a good name for openstack-dev/sandbox launchpad ? 17:42:12 lauchpad? you mean lounchpad project? 17:42:17 The name should be like https://launchpad.net/openstack-dev-sandbox ? 17:42:47 its ok 17:42:57 it should be as close to the repo name as possible 17:43:35 so +1 for this 17:43:45 Okay I see. Then I will try to make and correlate this launchpad with openstack-dev/sandbox repository :) 17:44:24 ok 17:45:18 anything else? or do we wrap it up? 17:45:42 For me, that's all 17:46:09 #action ianychoi create openstack-dev/sandbox launchpad project 17:46:27 diablo_rojo_phon: you? 17:47:00 #action ianychoi s/openstack-dev\/sandbox/openstack-dev/sandbox 17:47:08 #action ianychoi s/openstack-dev\/sandbox/openstack-dev-sandbox 17:47:55 ianychoi: you can use #undo, for last item 17:48:12 if you mistype it 17:48:25 matjazp, Aha.. I forgot it, thanks! 17:48:35 more action items for you :) 17:48:53 ok, let's wrap this 17:48:56 Oops....... kkk 17:49:05 yep thank you, matjazp and diablo_rojo_phon ! 17:49:12 thanks for attending 17:49:21 and thanks for contributing! 17:49:28 see you next week 17:49:37 bye ianychoi diablo_rojo_phon 17:49:50 #endmeeting