01:01:39 <joehuang> #startmeeting tricircle 01:01:40 <openstack> Meeting started Wed Jul 12 01:01:39 2017 UTC and is due to finish in 60 minutes. The chair is joehuang. Information about MeetBot at http://wiki.debian.org/MeetBot. 01:01:41 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 01:01:43 <openstack> The meeting name has been set to 'tricircle' 01:01:47 <joehuang> hello 01:01:52 <hejiawei> hi 01:01:54 <Yipei> hi 01:01:57 <joehuang> #topic rollcall 01:01:59 <zhiyuan> hi 01:02:02 <joehuang> #info joehuang 01:02:04 <dongfeng> hi 01:02:05 <zhiyuan> #info zhiyuan 01:02:07 <dongfeng> #info dongfeng 01:02:09 <hejiawei> #info hejiawei 01:02:39 <RonghUI> #info ronghui 01:02:45 <xuzhuang> #info xuzhuang 01:02:55 <joehuang> #topic feature implementation review 01:02:56 <yinxiulin> #info xiulin 01:03:05 <Yipei> #info Yipei 01:03:14 <joehuang> the pike-3 is approching 01:03:33 <joehuang> the date is july 28 01:03:53 <joehuang> let's have a short review for the ongoing development features 01:04:55 <dongfeng> for me, the pagination feature for routing is under review. 01:05:11 <joehuang> to dongfeng, yes, almost done 01:05:27 <xuzhuang> for job pagination, paginate_query has finished, and some test cases has added, now I need to modify the code after your review 01:05:28 <dongfeng> en, a question left there after your comment. 01:05:55 <zhiyuan> the spec for smoke test has been merged, hopefully the patches for single/multiple gateway topology test can be merged in Pike 01:07:18 <Yipei> for lbaas, already finish installing octavia in multiple pods, plan to test lbaas across instances of different subnets 01:07:21 <joehuang> @dongfeng, ok, so should we support sort filter in the api request 01:07:44 <dongfeng> to joe, for simplicity, sort by id is more simple 01:07:56 <Yipei> for importing external network, already begin coding 01:08:17 <joehuang> to zhiyuan, smoke test landing is very important to guarantee the code quality, so it'll be put with high priority 01:08:26 <yinxiulin> the sfc's update patch is under review 01:08:31 <joehuang> to Yipei, great progress 01:08:47 <joehuang> hope LBaaS can work soon for multi-pod 01:09:06 <Yipei> ok, got it. i will make it 01:09:27 <joehuang> how do you guys think about the pagination sort key? 01:09:52 <dongfeng> if we sort by a key, then this key will served as marker. 01:10:31 <joehuang> how about server pagination and port pagination? 01:10:45 <dongfeng> currently marker is hardcoded to id. 01:11:26 <dongfeng> what's the requirement for server pagination and port pagination? 01:12:07 <joehuang> I meant do you have an idea about the server pagination/port pagination to deal with sort 01:12:24 <zhiyuan> according to https://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html 01:12:42 <zhiyuan> the sort key is usually the ID of the item, but not require to 01:13:33 <zhiyuan> this page also talks about ID: https://developer.openstack.org/api-guide/compute/paginated_collections.html 01:14:18 <zhiyuan> "The ``marker`` parameter is the ID of the last item in the previous list. By default, the service sorts items by create time in descending order. When the service cannot identify a create time, it sorts items by ID.The ``marker`` parameter is the ID of the last item in the previous list. By default, the service sorts items by create time in descending order. When the service cannot identify a 01:14:24 <zhiyuan> create time, it sorts items by ID." 01:16:09 <joehuang> By default, the service sorts items by create time in descending order 01:16:34 <hejiawei> for qos, xiongqiu will update it tonight. 01:17:33 <joehuang> for routing table, because the id is bigint, so desceding is fine 01:17:45 <joehuang> from latest one to the oldest one 01:18:18 <joehuang> sorry, from the last one to the first one 01:18:20 <dongfeng> you mean like 4 3 2 1 ？ 01:18:56 <zhiyuan> yes, just change "asc" to "desc" 01:19:11 <joehuang> when you check, you often want to know the new added items 01:19:14 <dongfeng> so, filter won't contain sorts? 01:19:25 <joehuang> so descending is more reasonable 01:19:48 <dongfeng> ok, I will change sort direction. 01:21:52 <dongfeng> currently id representation can denote creation time 01:22:43 <joehuang> ok 01:23:31 <dongfeng> then I will hardcoded sort key to id. change its direction to desc. 01:24:01 <joehuang> for qos, the patch needs to fix the issue in gate/check test, for example pep8 01:24:45 <joehuang> and functional test 01:25:17 <joehuang> reviewers only do review if a patch passes all test 01:27:16 <joehuang> #topic open discussion 01:27:23 <joehuang> topic to discuss? 01:27:49 <dongfeng> no for me 01:28:01 <RonghUI> no for me 01:28:05 <Yipei> no 01:28:08 <zhiyuan> no 01:28:15 <xuzhuang> no for me 01:29:19 <joehuang> #info reviewers only do review if a patch passes all test 01:29:49 <joehuang> fine, let's end the meeting, and discuss in #openstack-tricicle if needed 01:29:56 <joehuang> #endmeeting