00:59:27 <zhiyuan> #startmeeting tricircle
00:59:28 <openstack> Meeting started Wed Apr 18 00:59:27 2018 UTC and is due to finish in 60 minutes.  The chair is zhiyuan. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:59:29 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
00:59:31 <openstack> The meeting name has been set to 'tricircle'
01:00:12 <zhiyuan> Yipei, have you done some tests on the routed network gateway solution we discussed last week?
01:01:25 <Yipei> not jet, i am working on it.
01:02:11 <Yipei> trying to create a blank port when adding gateway port when updating the router
01:03:04 <Yipei> then, i think i also need to test the floating ip creation
01:04:47 <zhiyuan> yeah, the default fip creation will allocate ip from the external subnet so we need to change
01:06:15 <Yipei> ok, got it, i will speed up, i can spend more time on the feature in the next two month
01:06:47 <Yipei> my personal business has come to an end recently
01:07:22 <zhiyuan> great!
01:11:41 <zhiyuan> song, what about the "local resource name" feature?
01:12:19 <song> hi,zhiyuan.for this pb use top_name plus top_id to set the name of bottom resource.do we just only need to check in the tricircle cli whether the top_id is equal to top_name and nothing more need to do.
01:17:38 <zhiyuan> currently for some resources like network and subnet, the name of local resource is the ID of central resource, we need to (1) use name+ID to set the local resource name (2) change the local resource query filter from "ID as name" to "name+ID as name"
01:18:47 <zhiyuan> https://github.com/openstack/tricircle/blob/master/tricircle/network/helper.py#L144
01:19:40 <zhiyuan> you can see in the function that we are listing resource with filter: key: name, value: ele_['id']
01:21:15 <song> oh, got it. thank you!do this change may have big effect in our test?
01:26:21 <zhiyuan> smoke test needs some changes, in the "check" task set, we query some local resources by their name as central resource ID: name: preparation@router@id
01:26:39 <zhiyuan> but not all the resources
01:27:55 <song> oh, that is good.
01:30:00 <zhiyuan> for unit tests, it will be fine if the helper "FakeClass" in tricircle/tests/unit/utils.py is used. the query filter is not hard-coded in the "FakeClass" so I think no effect after we change the name from "ID" to "name+ID"
01:33:40 <song> it is really a good news.we plan to finish the code this week and see how much effect to the smoke test.
01:38:11 <zhiyuan> oh, our task runner also need some changes. currently it doesn't support expression in yaml file, so you cannot define the filter in yaml like "name: router@id + router@name"
01:40:34 <song> so the task runner will need to add filer in yaml for this change.got it!
01:43:24 <zhiyuan> enable task runner to process expression so we can pass like "name: router@id+router@name" or "name: concat(router@id, router@name)" in yaml
01:46:27 <song> ok, that is no problem.we will use a general method not hard code with it.:)
01:47:15 <zhiyuan> fine :)
01:47:23 <zhiyuan> other topics?
01:48:20 <xuzhuang> no from me
01:48:21 <Yipei> no for me
01:48:29 <song> on for me
01:48:32 <zhiyuan> ok
01:48:33 <song> no for me
01:48:40 <zhiyuan> #endmeeting