08:16:14 #startmeeting tripleo 08:16:15 Meeting started Wed Nov 12 08:16:14 2014 UTC and is due to finish in 60 minutes. The chair is lxsli. Information about MeetBot at http://wiki.debian.org/MeetBot. 08:16:16 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 08:16:18 The meeting name has been set to 'tripleo' 08:16:33 #topic agenda 08:16:36 * bugs 08:16:38 * reviews 08:16:42 * open discussion 08:16:51 #topic bugs 08:16:57 thanks lxsli my head was about to explode 08:17:10 :) 08:17:35 #link https://bugs.launchpad.net/tripleo/ 08:17:35 #link https://bugs.launchpad.net/diskimage-builder/ 08:17:35 #link https://bugs.launchpad.net/os-refresh-config 08:17:35 #link https://bugs.launchpad.net/os-apply-config 08:17:35 #link https://bugs.launchpad.net/os-collect-config 08:17:38 #link https://bugs.launchpad.net/os-cloud-config 08:17:40 #link https://bugs.launchpad.net/tuskar 08:17:43 #link https://bugs.launchpad.net/python-tuskarclient 08:17:47 #bug 1188067 08:17:48 Launchpad bug 1188067 in tripleo "* listening services available on all addresses" [Critical,Triaged] https://launchpad.net/bugs/1188067 08:18:02 tchaypo? 08:18:02 wa-hey, that’s mine, isn’t it? 08:18:05 woah, the meeting is alive. sorry, I got distracted 08:18:42 so this bug reads more like a spec though 08:18:46 so I don’t seem to have notes on the bug 08:18:56 (i mean about what could be done to mitigate) 08:19:28 but my thinking is that a lot of mitigation has already been done with our support for two vips 08:19:29 (+combined with robert's comment about the creds) 08:20:03 which makes it easier to only listen on a non-public interface 08:20:52 So we're picking "be careful"? Option 2 08:21:03 this came to me because HP security people noticed that our undercloud had dnsmasq responding on the public interface, so it was being used as part of a dns amplification attack. It seems like we can continue the work we’ve already done to make dnsmasq only listen on selected interfaces 08:21:05 tchaypo: so ok you can use that to discriminate 08:22:28 once dnsmasq listens by default only on selected interfaces I don’t think we’ll have any known services that always listen on all interfaces 08:22:29 Remaining bugs are all owned + not by people present 08:22:41 so i think we can drop this bug back to high at that point 08:22:50 Sounds good - motion to move on? 08:22:54 +1 08:23:18 #topic reviews 08:23:26 Anything anyone wants to bring up? 08:23:39 tchaypo: don't quite follow the dnsmasq comment (listens on a specific bridge for the whatever subnet in a q-xxx namespace) - let's take discussion to the bug 08:24:06 I'd like some more +2 on https://review.openstack.org/#/c/133258/ 08:25:06 lxsli: will add it to my review list for today 08:25:34 marios_: sure, I’ll update it with some details about what we saw dnsmasq doing today 08:25:42 Thanks - moving on to long-standing reviews if no one else has anything? 08:25:45 tchaypo: thanks man 08:26:50 +1 move on 08:26:58 I propose we use the flat "Oldest reviews" from: 08:27:02 #link http://russellbryant.net/openstack-stats/tripleo-openreviews.html 08:27:25 lxsli: +1 08:27:26 The oldest is 222d old, it needs to be merged or abandoned 08:27:39 +1, I didn't know about that report. neat. 08:28:02 so in clueless round-robin style, I propose tchaypo, marios_, d0ugal and lxsli take in order: 08:28:06 lxsli: so actually 08:28:15 lxsli: it IS 222 day old but it was updated Nov 7 08:28:28 Yeah, that review is active really. 08:28:49 I can’t abandon anything 08:28:51 lxsli: so .next 08:29:05 but I can read it, make a decision, and ask someone else for action 08:29:10 tchaypo: really? weird 08:29:14 Likewise 08:29:20 lxsli: neither I or tchaypo are core 08:29:23 which at least saves people from having to read and decide 08:29:29 Oh how about that 08:29:50 I should know this... marios_ are you core? 08:30:03 he is :) 08:30:06 https://review.openstack.org/#/c/85130/ might be active but it looks like it could do with some help 08:30:11 lxsli: yeah i can abandon but this one doesn't warrant it 08:30:30 same goes for https://review.openstack.org/#/c/92204/ 08:30:40 I’ve looked at that in the past, I’d be happy to jump in and see what I can do to help get it across the line 08:30:47 190 days old, updated Nov 12 08:30:55 marios_: OK so can you take ownership and try to help it merge? 08:31:11 lxsli: heh, clint uploaded a version _today_ 08:31:17 i'm sure he won't mind :) 08:31:18 lol 08:31:26 gah 08:31:33 We need a different report 08:31:37 "it's ok, lxsli said" 08:31:44 lol 08:31:50 * marios_ grabs clint's keyboard 08:31:58 this is what happens when I try to lead things 08:32:18 What about "Longest waiting reviews (based on oldest rev without -1 or -2)" then? 08:32:23 Don't we want "Longest waiting reviews (based on latest revision): " 08:32:25 Yup! 08:32:33 this ^^ 08:32:39 those are different btw 08:32:42 d0ugal: you're doing it to me now with the typing thing 08:32:44 oh yeah 08:33:04 does the tripleo dashboard have a thingy we can use? 08:33:06 lxsli: "based on oldest rev" seems wrong? 08:33:20 i think that hashing this out makes this a worthwhile meeting.. 08:33:22 d0ugal: as in not as described? 08:33:24 lxsli: yeah, even if there are just comments there 08:33:26 tchaypo: +1 08:33:27 tchaypo: +1 08:33:42 lxsli: Yeah, it appears to be current revision but I'm a bit confused now :) 08:33:44 dashboard has 08:33:44 https://review.openstack.org/#/q/label:Verified%253E%253D1%252Cjenkins+NOT+owner:self+NOT+project:openstack/tripleo-specs+NOT+label:Code-Review%253C%253D2+age:5d+(project:openstack/tripleo-incubator+OR+project:openstack/tripleo-image-elements+OR+project:openstack/tripleo-heat-templates+OR+project:openstack/tripleo-specs+OR+project:openstack/os-apply-config+O 08:33:44 R+project:openstack/os-collect-config+OR+project:openstack/os-refresh-config+OR+project:openstack/os-cloud-config+OR+project:openstack/diskimage-builder+OR+project:openstack/dib-utils+OR+project:openstack-infra/tripleo-ci+OR+project:openstack/tuskar+OR+project:openstack/python-tuskarclient)+status:open+NOT+label:Workflow%253C%253D-1+NOT+label:Code-Review%253 08:33:44 C%253D-2,n,z - “5 days without feedback" 08:33:58 that’s a poor attempt at pasting 08:33:59 lxsli: i mean, if there are just comments there and it's been a while since revision, imo, that's the kind of candidate we can try and help for getting merged (ping author, address comments etc) 08:34:13 lxsli: so longest waiting since revision seems like a good one imo 08:34:44 OK lets use "based on latest revision" 08:35:04 I don’t think the dashboard has anything helpful, mostly because gerri orders things by newest-first and we want oldest-first 08:35:05 #info Assigning "Longest waiting reviews (based on latest revision)" 08:35:06 lxsli: BUT we can quickly also check the really old ones, let's not make it a rigit thing 08:35:35 Suggest we also don't assign out patches whose owner is already core? 08:35:37 lxsli: (rigid) like some of those in the other lists maybe need closing etc 08:35:46 They can chase us themselves 08:35:59 lxsli: unnecessary to explicate that imo but sure 08:36:19 ping the author would be my very first thing to do anyway, regardless 08:36:26 https://review.openstack.org/#/c/98336/ looks like it just needs a licence file/header 08:36:37 should be trivial for one of us to add that and update 08:36:50 tchaypo: i can take that, i'll ping derek later 08:36:59 #link https://review.openstack.org/#/c/103105/ 08:37:06 #link https://review.openstack.org/#/c/129157/ 08:37:13 #link https://review.openstack.org/#/c/106727/ 08:37:19 how do we add action items here? is it 'note' or 'info' ? 08:37:23 although on second reading, lxsli has a few other comments I think deserve followup - but again it should be simple for someone to make those changes 08:37:27 marios_: action 08:37:38 followed by name of the person it’s assigned to 08:37:54 #action marios to take ownership of https://review.openstack.org/#/c/98336/ - ping author see whatsup - followup 08:38:07 #action lxsli https://review.openstack.org/#/c/106727/ 08:38:23 https://review.openstack.org/#/c/129105/ looks like it was stalled waiting for ci to pass, which it now has 08:38:28 #action lxsli https://review.openstack.org/#/c/129157/ 08:38:36 they both look pretty easy, got +2 08:38:54 #action marios https://review.openstack.org/#/c/129105 08:39:05 marios_: can you take 103105? 08:39:13 ITS A TRAP 08:39:14 * marios_ looks 08:39:32 sure 08:39:38 #action https://review.openstack.org/#/c/103105 08:39:59 #action marios https://review.openstack.org/#/c/103105 08:40:06 #topic AOB 08:40:19 haha and thus it was the most productive meeting in tripleo ever, nice one lxsli 08:40:26 +1 08:40:29 Nothing from me, nice to meet most of you in Paris :) 08:40:46 lxsli: sorry i missed you. i was running around most days between neutron sessions 08:40:58 you should have checked more bars ;) 08:41:09 :) 08:41:28 #endmeeting