16:02:27 <pc_m> #startmeeting vpnaas
16:02:28 <openstack> Meeting started Tue Sep 29 16:02:27 2015 UTC and is due to finish in 60 minutes.  The chair is pc_m. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:02:29 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:02:32 <openstack> The meeting name has been set to 'vpnaas'
16:02:37 <pc_m> #topic Announcements
16:03:30 <pc_m> The endpoint groups code and CLI client need review/approval. Thanks for the reviews, we just need to wrap this up, so it stops churning due to rebases.
16:04:20 <pc_m> The Neutron client jobs that re-enable VPN tests have moved from experimental to check queue.
16:04:30 <pc_m> (non voting).
16:04:44 <pc_m> Once tested for a while, we can make these voting.
16:05:03 <pc_m> Any other important announcements?
16:05:32 <pc_m> If you have anything for the Summit, please post on the etherpad - https://etherpad.openstack.org/p/neutron-mitaka-designsummit
16:06:08 <pc_m> #topic Endpoint Groups
16:06:34 <pc_m> The reviews seem to be coming along. Not many more comments.
16:06:49 <pc_m> #link https://review.openstack.org/#/c/212692/ and #link https://review.openstack.org/#/c/219455/
16:07:20 <ajmiller> I just gave +2 on 212692
16:07:25 <pc_m> Hoping to get this in ASAP. Thanks for reviewing.
16:07:33 <pc_m> ajmiller: Thanks!
16:08:06 <pc_m> Will have to see if can get a second core. amotoki^^^
16:08:33 <ajmiller> Would be great if we could get that merged today.
16:08:38 <amotoki> pc_m: thanks for reminding :-)
16:08:47 <pc_m> amotoki: np
16:08:57 <pc_m> I'm trying not to nag too much :)
16:09:06 <pc_m> #topic Multiple Local Subnets
16:09:35 <pc_m> I spent a few days testing functionality and the validation logic. Looking pretty good.
16:10:16 <pc_m> I need to do some checks for deletion (e.g. deleting a endpoint group that is in use by a connection), and do the migration code, and then I can post for review.
16:10:42 <pc_m> It's pretty big (2K LOC). If needed, I can try to break it up for reviews.
16:11:08 <pc_m> I also need to do neutron client changes for the feature as well.
16:11:28 <pc_m> #topic VPN Functional Tests for Neutron Commits
16:12:00 <pc_m> I changed the jobs and there is a commit out to make them non-voting in the check queue. #link https://review.openstack.org/#/c/223049
16:12:15 <pc_m> Once that is approved, we can run it for a while and then make it voting.
16:12:34 <pc_m> Just need infra cores to review and approve.
16:12:51 <pc_m> #topic Devstack plugin for neutronclient
16:13:19 <pc_m> As mentioned in the announcements, it is non-voting right now, and I'll move to voting, once it has some run time on commits.
16:13:31 <pc_m> #topic Bugs and Reviews
16:13:50 <pc_m> #link https://goo.gl/XNtnLX for bugs
16:14:08 <pc_m> #link https://review.openstack.org/#/q/status:open+project:openstack/neutron-vpnaas,n,z for reviews
16:14:28 <pc_m> Any specific reviews or bugs that people need to discuss here?
16:14:50 <ajmiller> Nothing specific from me, been pretty much out of the loop for the past 2 weeks.
16:15:15 <pc_m> ajmiller: welcome back!
16:15:19 <ajmiller> I should be able to spend more time on VPN now.
16:15:22 <ajmiller> Thanks.
16:15:31 <pc_m> ajmiller: Super!
16:15:54 <ajmiller> I do know we are struggling with velocity, and anything we all can do to make reviews quicker and more efficient will go a long ways.
16:16:18 <pc_m> I've got several big commits so will need help on reviews from everyone.
16:16:24 <xgerman> yeah, I am a bit concerned with the velocity of the rally reviews
16:16:25 <pc_m> ajmiller: +1000
16:17:15 <pc_m> xgerman: Yeah, we all need to help each other out on reviews.
16:17:56 <xgerman> well, the back and forth has been a bit time consuming...
16:18:42 <pc_m> xgerman: Understood. I personally had a hard time reviewing it as separate commits.
16:19:01 * pc_m and getting bandwidth to focus on them
16:19:20 <xgerman> yeah, bandwidth is always tight ;-)
16:19:25 <amotoki> I noticed yesterday we don't have a gerrit dashbaord for neutron XaaS repos. I will push it for review.
16:19:35 <amotoki> though it doesn't solve the problem directly.
16:19:53 <pc_m> Did some comments this morning about whether the utils should be a base class or just standalone methods.
16:20:17 <pc_m> amotoki: thanks
16:21:54 <pc_m> Anything else on bugs/reviews?
16:22:07 <Aish> pc_m I shall make them a single commit if that will help. Looks like madhu_ak is only going to work on top my commits, once it is merged.
16:23:08 <pc_m> Aish: Would help me. Hard to bounce between two commits to review caller/callee.
16:23:33 <pc_m> Posted some comments on the util review just now, summarizing some of what we talked about this morning.
16:23:39 * xgerman wonders how big pc_m’s monitor is
16:23:40 <pc_m> Encourage others to review.
16:23:49 <Aish> ok, done!
16:23:58 <madhu_ak> +1 for single commit
16:24:35 <pc_m> xgerman: 15" on my laptop.
16:24:47 <xgerman> yeah, that would get tight with two reviews
16:25:05 <pc_m> #topic Open Discussion
16:25:15 <pc_m> Anyone have anything else to discuss?
16:26:13 <ajmiller> Nothing specific from me, must trying to get caught up.
16:26:38 <pc_m> ajmiller: Yeah, please do, before I push out the multiple local subnet commit :)
16:27:02 <ajmiller> Yes!  Am looking forward to that..
16:27:57 <pc_m> It actually enhances the tests a lot as well (as part of writing new UTs).
16:28:19 <pc_m> Improved both database and device driver config tests.
16:28:27 <ajmiller> cool
16:29:26 <pc_m> Thanks for joining in everyone!
16:29:32 <ajmiller> bye
16:29:34 <pc_m> #endmeeting