08:01:57 <licanwei> #startmeeting watcher
08:01:58 <openstack> Meeting started Wed Apr 10 08:01:57 2019 UTC and is due to finish in 60 minutes.  The chair is licanwei. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:01:59 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:02:01 <openstack> The meeting name has been set to 'watcher'
08:02:07 <licanwei> hi
08:02:54 <licanwei> Agenda for today: https://wiki.openstack.org/wiki/Watcher_Meeting_Agenda#04.2F10.2F2019
08:02:56 <sum12> hello
08:04:05 <licanwei> sum12: hi
08:04:20 <licanwei> #topic Announcements
08:04:54 <licanwei> Stein cycle release
08:05:31 <licanwei> Watcher release notes: https://docs.openstack.org/releasenotes/watcher/stein.html
08:05:59 <chenke> https://etherpad.openstack.org/p/train-watcher-plan
08:06:33 <licanwei> and all Watcher implemented specs:
08:06:53 <licanwei> http://specs.openstack.org/openstack/watcher-specs/specs/stein/index.html
08:08:22 <Dantalion> under stein approved but not implemented aren't we missing the nova schedule filters proposed by alexander?
08:09:22 <Dantalion> https://review.openstack.org/#/c/561640/
08:09:53 <licanwei> Dantalion: yes
08:10:12 <licanwei> but this bp is hard to continue
08:11:16 <Dantalion> I agree I think we should not consider implementing at this time
08:12:43 <Dantalion> But I am uncertain if we should completely omit it from the approved but not implemented list.
08:13:14 <licanwei> https://review.openstack.org/#/c/650861/
08:14:06 <chenke> Dantalion about this topic "Some strategies pass hostname as resource_id other pass the node uuid", i read related code
08:14:19 <licanwei> We want to implement these bps in Train cycle
08:15:13 <Dantalion> licanwei: Yes in addition I want to implement grafana proxy datasource during train cycle but do not have the spec yet.
08:15:57 <licanwei> Dantalion: don't worry, you can add spec at any time~
08:16:46 <licanwei> That just is a initial
08:16:53 <sum12> I am currently writing a spec for adding additional datasources
08:17:53 <licanwei> #topic specs
08:18:14 <sum12> Dantalion: we could easily alter it to include grafana as a datasource
08:18:14 <licanwei> sum12: where is your spec link?
08:19:00 <sum12> licanwei: I am waiting for the file base metric implementation to finish
08:19:14 <Dantalion> sum12: grafana is complicated because when file based datasource passes it needs additional changes to accomidate for that new spec.
08:19:28 <licanwei> sum12: OK, no problem~
08:20:10 <licanwei> [https://review.openstack.org/#/c/649235/
08:20:44 <sum12> Dantalion: yes I can understand why that is the case
08:21:08 <licanwei> This bp needs review
08:21:20 <chenke> Dantalion: the uuid and hostname have the same value
08:21:56 <licanwei> https://review.openstack.org/#/c/643312
08:22:15 <licanwei> I think this can be merged~
08:22:33 <Dantalion> I agree lgtm
08:23:23 <licanwei> #topic Review Action
08:23:58 <licanwei> #link https://review.openstack.org/#/c/645294/ needs review
08:24:37 <licanwei> #link https://review.openstack.org/#/c/647672 needs reviews
08:25:34 <licanwei> #link https://review.openstack.org/#/c/611275/
08:25:44 <licanwei> This is for python3.7 support
08:26:25 <licanwei> I think it's alse can be merged :)
08:27:25 <Dantalion> Yes very happy to see problems around python 3.7 resolved :)
08:28:01 <licanwei> #topic Open discussions
08:28:32 <licanwei> Now I think we need more active core reviewers
08:29:04 <licanwei> I want to nominate Dantalion and chenker to new core reviewers
08:29:13 <josecastroleon> :)
08:29:36 <sum12> \o/
08:29:57 <licanwei> They all contribute more recently
08:30:38 <Dantalion> I would like to be core reviewer and can stay core reviewer until the end of july :)
08:30:56 <josecastroleon> i can take over after that ;)
08:32:29 <chenke> I am happy to continue contributing to the watcher project, thanks.
08:32:33 <licanwei> josecastroleon: I wish :)
08:32:54 <josecastroleon> if anyone would like to know, we are both from CERN ;)
08:33:33 <licanwei> josecastroleon: haha, i know you
08:33:46 <sum12> home.cern ?
08:34:35 <josecastroleon> yep
08:35:08 <sum12> cool
08:35:09 <josecastroleon> quick question, is anyone going to the ptg?
08:35:47 <licanwei> josecastroleon: no me ~
08:36:52 <josecastroleon> :(
08:37:13 <josecastroleon> I am going, it was just to see if we can meet in person
08:37:21 <sum12> I will be there
08:37:30 <josecastroleon> nice
08:38:04 <licanwei> josecastroleon: We can meet at Shanghai China next summit :)
08:38:44 <josecastroleon> I'll try to go, not sure at the moment
08:39:09 <licanwei> Welcome to China !
08:40:26 <licanwei> I wish Watcher can help CERN
08:41:11 <licanwei> we still have many jobs need to to at Train cycle
08:41:21 <josecastroleon> That's the plan
08:41:26 <josecastroleon> like?
08:42:05 <licanwei> https://review.openstack.org/#/c/650861/
08:43:20 <josecastroleon> I see
08:43:29 <licanwei> and we need to improve unit and functional tests
08:43:45 <josecastroleon> I've got the same feedback from Dantalion
08:45:59 <Dantalion> Yes functional tests but I also think we should work on formal interfaces for the datasources for instance
08:46:27 <Dantalion> The values used by different strategies passed to the arguments of datasources seems to differ per strategy
08:47:26 <chenke> yes, now they are different
08:47:30 <licanwei> Yes , these all need to be improved
08:47:58 <Dantalion> I would like to propose creating a spec with a formal definition for the datasource parameters and expected values
08:49:03 <licanwei> Dantalion: you can create the spec
08:49:25 <Dantalion> Okaj, I will start writting the spec
08:50:08 <chenke> nice
08:50:22 <sum12> awesome
08:53:40 <licanwei> any questions?
08:54:09 <josecastroleon> no
08:54:15 <licanwei> I'll end the meeting if no question
08:54:21 <licanwei> ok
08:54:24 <Dantalion> no more questions from me
08:54:40 <licanwei> Thanks for attending
08:54:50 <sum12> it was nice talking to watcher team
08:54:59 <licanwei> I wish Watcher has a new start :)
08:55:07 <josecastroleon> thanks to have this meeting back
08:55:27 <Dantalion> Yes I agree I am glad to have talked to everyone lets keep it going
08:55:35 <licanwei> bye! everyone
08:55:39 <Dantalion> bye
08:56:04 <licanwei> see you all next meeting time
08:56:07 <chenke> bye
08:56:21 <licanwei> #endmeeting