08:00:24 <licanwei> #startmeeting watcher
08:00:25 <openstack> Meeting started Wed Aug 28 08:00:24 2019 UTC and is due to finish in 60 minutes.  The chair is licanwei. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:00:26 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:00:28 <openstack> The meeting name has been set to 'watcher'
08:00:37 <licanwei> Dantalion: hi
08:00:45 <chenke> hi
08:00:56 <chenke> Dantalion how are you
08:01:28 <Dantalion> Im fine im doing my thesis defense today so was still pretty busy last weeks
08:01:45 <chenke> ye. I understand.
08:01:47 <licanwei> #topic Review Action Items
08:02:26 <licanwei> https://review.opendev.org/#/c/678189/ add audit parameter to do_execute needs review
08:02:54 <licanwei> This is a part of bp node resource consolidation
08:04:31 <licanwei> https://review.opendev.org/#/c/677407/ Add releasenote about bp show-datamodel-api needs review
08:04:57 <licanwei> https://review.opendev.org/#/c/677658/ Add api-ref doc for data model api needs review
08:05:00 <chenke> +1 feels like the warmth of a big team.
08:05:10 <chenke> +1 add audit parameter to do_execute needs review
08:05:23 <licanwei> https://review.opendev.org/#/c/676884/ Implement watcher datamodel list in watcher-decision-engine needs review
08:05:37 <licanwei> https://review.opendev.org/#/c/677189/ Implement watcher datamodel list in watcher-api needs review
08:06:01 <licanwei> There are all about bp show-datamodel-api
08:06:13 <licanwei> I'll review again
08:06:26 <chenke> Thanks.
08:06:49 <chenke> I have test these code in my watcher environment.
08:07:08 <chenke> But maybe some code need to be modified.
08:07:30 <licanwei> #topic Watcher specs
08:07:37 <chenke> Hope canwei and Dantalion can help me review these code.
08:08:01 <licanwei> https://review.opendev.org/#/c/675871/ node resource consolidation spec needs review
08:08:23 <licanwei> https://review.opendev.org/#/c/677437/ Update show-datamodel-api spec needs review
08:08:46 <Dantalion> I will first go through datamodel list spec so I can fully understand purpose then I can look at the code that implements it
08:08:52 <licanwei> +1 for Update show-datamodel-api
08:09:12 <licanwei> Dantalion: thanks!
08:09:45 <licanwei> https://review.opendev.org/#/c/593282/ Add test 'node_modules' in gitignore needs review
08:09:48 <chenke> I will review resource consolidation spec this evening.
08:10:40 <chenke> Add test 'node_modules' in gitignore. The contributer didn't reply for us.
08:10:53 <chenke> I don't know why we need to add this item.
08:11:18 <Dantalion> Okaj, I think we should leave it unless he replies
08:11:29 <licanwei> agree
08:12:08 <licanwei> https://review.opendev.org/#/c/676883/ Implement watcher datamodel list in watcherclient needs review
08:12:28 <licanwei> https://review.opendev.org/#/c/677672/ Add datamodel doc in watcherclient needs review
08:12:48 <licanwei> They are all about bp show-datamodel-api
08:13:09 <licanwei> +1
08:13:25 <chenke> Thanks.
08:13:29 <Dantalion> I have some question about datamodel list api
08:13:46 <chenke> please let me know.
08:14:09 <Dantalion> Will it show current datamodel or can it be used to retrieve what the data model was for previous audits?
08:14:12 <Dantalion> or maybe both
08:15:07 <chenke> by default, it will show current datamodel
08:15:51 <chenke> it always show the laterst datamodel.
08:16:09 <Dantalion> but you can specify audit uuid to fetch information about previous audits right?
08:16:18 <chenke> no
08:16:40 <chenke> audit uuid just used for specific audit_scope
08:17:21 <chenke> then we can show the relate datamodel rather than the whole datamodel.
08:17:35 <chenke> But the data model result still the laterst.
08:17:59 <Dantalion> okaj but if the datamodel audit scope is different then current datamodel it will have to retrieve the data again right?
08:19:09 <licanwei> Dantalion: It always gets the newest data model, I think
08:19:32 <chenke> No
08:19:42 <chenke> I agree with canwei
08:20:07 <Dantalion> Okaj but if it always shows latest data model what is the purpose of audit parameter
08:20:23 <licanwei> If you specify the audit, then will retrieve the data model based audit scope
08:21:11 <licanwei> just return a part of all data model
08:21:46 <Dantalion> what if the current data model contains less data then with the audit scope because the current data model already had a scope?
08:21:50 <Dantalion> then it will be incomplete?
08:21:58 <licanwei> It's useful when debugging
08:23:10 <chenke> the datamodel in watcher is complete.
08:23:41 <licanwei> The current data model is a set of all audit, including all audit scope
08:23:50 <chenke> the api just used for user to list the datamodel by the cmd 'watcher datamodel list'
08:25:08 <Dantalion> So the data mpdel has been changed to be build using all audit scopes together?
08:25:13 <chenke> If user didn't want to list all datamodel, just want to list specific audit_scope datamodel. They can use cmd 'watcher datamodel list --audit audit_uuid' , the audit_scope can be got by the audit_uudi.
08:25:50 <licanwei> Dantalion: yes
08:27:14 <chenke> Default datamodel will merge all audit_scope.
08:27:30 <licanwei> Dantalion: https://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/collector/nova.py#L418
08:28:50 <chenke> Hi, Dantalion. I have to attend another meeting.
08:28:57 <licanwei> Dantalion: sorry! I have another meeting
08:29:13 <Dantalion> Okaj we will continue this some other time
08:29:24 <licanwei> Dantalion: If any question, please leave comments
08:29:26 <chenke> nice
08:29:46 <licanwei> Dantalion: thanks
08:29:46 <chenke> I will check the comment everyday.
08:30:02 <licanwei> I'll end this meeting
08:30:22 <licanwei> #endmeeting