08:00:14 <licanwei> #startmeeting Watcher
08:00:14 <openstack> Meeting started Wed Sep 11 08:00:14 2019 UTC and is due to finish in 60 minutes.  The chair is licanwei. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:00:15 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:00:17 <openstack> The meeting name has been set to 'watcher'
08:01:31 <licanwei> #topic Announcements
08:01:57 <licanwei> This week is Train-3 milestone
08:02:17 <chenke> yes
08:02:30 <licanwei> It's time to freeze features
08:02:33 <chenke> Some bp and codes need to be merged soon.
08:02:40 <Dantalion> When is feature freeze? together with Train-3?
08:03:09 <chenke> yes
08:03:33 <licanwei> Dantalion: yes, this week
08:04:00 <Dantalion> Okaj, lets work on finishing accepted specs for release I propose to do threadpool for T-1 / T-2 of next release
08:04:09 <licanwei> https://releases.openstack.org/train/schedule.html
08:04:15 <Dantalion> Since otherwise we do not have enough time
08:04:54 <chenke> Agree.
08:05:02 <chenke> First merge the spec
08:06:52 <licanwei> I plan to merge most of the commits this week
08:07:24 <chenke> I suggest taking the time to review the code today, because the day after tomorrow we will have a holiday due to the Mid-Autumn Festival
08:07:41 <licanwei> and threadpool may be postpone to next release
08:08:02 <Dantalion> I'll try to review code this week I have the friday off so I expect to do most reviewing then
08:08:17 <Dantalion> I agree postpone threadpool to Ussuri
08:08:23 <licanwei> Dantalion: thanks!
08:08:58 <licanwei> #topic Review
08:09:32 <licanwei> https://review.opendev.org/#/c/675871/ node resource consolidation spec needs review
08:09:51 <licanwei> https://review.opendev.org/#/c/679827/ General purpose threadpool for the decision engine needs review
08:10:25 <licanwei> I'll review it tomorrow
08:10:59 <licanwei> we can merge the spec if it's ok
08:11:28 <licanwei> https://review.opendev.org/#/c/677437/ Update show-datamodel-api spec needs review
08:12:08 <licanwei> https://review.opendev.org/#/c/679402/ node resource consolidation needs review
08:12:20 <Dantalion> I'll prioritize reviewing specs for friday since the node resource consolidation patches depend on it
08:13:17 <licanwei> https://review.opendev.org/#/c/677407/ Add releasenote about bp show-datamodel-api needs review
08:14:00 <Dantalion> +2
08:14:19 <licanwei> https://review.opendev.org/#/c/563477/ Watcher Planner Selector needs review
08:15:06 <chenke> I will review this tomorrow.
08:15:07 <licanwei> this is https://blueprints.launchpad.net/watcher/+spec/watcher-planner-selector
08:15:58 <chenke> 3years ago.
08:16:03 <chenke> this bp.
08:16:07 <Dantalion> Is there a spec? or was this before specs
08:16:42 <licanwei> It's code for this bp
08:17:05 <licanwei> used to select planner for strategy
08:18:29 <Dantalion> So planner is part of applier and determines how the actions in an action plan get applied / scheduled?
08:18:49 <licanwei> I find the default planner 'weight' can not work well for strategy 'node resource consolidation'
08:19:46 <licanwei> So I plan to merge this bp's code first
08:20:33 <licanwei> planner is not a part of applier, it's a part of decision engine
08:20:48 <licanwei> planner creates actions
08:21:37 <Dantalion> So the same strategy with different planners could result in different actions or different orders of actions?
08:23:06 <licanwei> diffrent planner can result different order of actions
08:23:47 <Dantalion> Okaj I understand that is good, currently strategies have a lot of responsibilities. Planner selector will help remove some responsibilities away from the strategies
08:24:23 <licanwei> but the same strategy has the same planner, different strategies can have diffrenet planners
08:25:10 <Dantalion> Okaj so the strategy picks which planner to use, but we could make it so a single strategy could support multiple planners maybe in the future
08:25:28 <Dantalion> But thats for later first planner selector, I will look at it friday
08:26:41 <licanwei> yes, you are right, strategy can select different planner
08:28:05 <licanwei> https://review.opendev.org/#/c/680288/ https://review.opendev.org/#/c/680288/ needs review
08:28:34 <chenke> +2
08:28:36 <licanwei> This depends on 'node resource cosolidation' codes
08:28:53 <chenke> I have reviewd this patch.
08:29:01 <licanwei> thanks
08:31:01 <licanwei> If no other questions I'll end the meeting
08:31:10 <Dantalion> I have no further questions
08:31:32 <chenke> no question.
08:31:45 <chenke> thanks all.
08:31:56 <Dantalion> Thanks and until next time
08:31:57 <licanwei> OK, thanks
08:32:10 <chenke> bye~
08:32:13 <licanwei> see you next time
08:32:31 <licanwei> #endmeeting