12:00:15 <dviroel> #startmeeting watcher
12:00:15 <opendevmeet> Meeting started Thu Jan 30 12:00:15 2025 UTC and is due to finish in 60 minutes.  The chair is dviroel. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00:15 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
12:00:15 <opendevmeet> The meeting name has been set to 'watcher'
12:00:31 <dviroel> hello all o/  who is around today?
12:00:42 <marios> hello o/
12:00:50 <jgilaber> hello o/
12:01:24 <rlandy> o/
12:01:27 * dviroel waits a minute
12:01:40 <amoralej> o/
12:01:59 <dviroel> ok, let's start with today's meeting agenda
12:02:06 <dviroel> #link https://etherpad.opendev.org/p/openstack-watcher-irc-meeting (Meeting agenda)
12:02:22 <dviroel> feel free to add your topics to our agenda
12:02:32 <dviroel> I already add some of them
12:02:48 <dviroel> and the first one
12:02:55 <dviroel> #topic DPL Reset + New DPL model for 2025.2
12:03:22 <dviroel> lets update what is happening wrt DPL vs PTL model for watcher
12:03:26 <chandankumar> o/
12:03:39 <dviroel> so in the end, the reset DPL model patch is merged
12:03:46 <dviroel> #link https://review.opendev.org/c/openstack/governance/+/939488 (Reset the DPL model for Watcher)
12:04:19 <dviroel> not all were able to vote -1 on this, since some folks can't continue as liasons
12:04:31 <dviroel> but sean-k-mooney proposed 2 new patches
12:04:32 <rlandy> do we need to vote on https://review.opendev.org/c/openstack/governance/+/940167?
12:04:50 <dviroel> #link https://review.opendev.org/c/openstack/governance/+/940167 (Adopt DPL model for watcher 2025.2)
12:05:14 <marios> i guess that is the followup patch from sean ... i haven't check it yet
12:05:29 <rlandy> I mean everyone mentioned as taking a role?
12:05:40 <dviroel> probably all liasons should vote there, iirc
12:05:44 <sean-k-mooney> o/
12:06:13 * marios just voted
12:06:17 <dviroel> and there is another patch, also from sean-k-mooney
12:06:24 <dviroel> #link https://review.opendev.org/c/openstack/governance/+/940168 (add watcher project update liaison)
12:06:25 <sean-k-mooney> am i dont know if its required to vote on them
12:06:42 <sean-k-mooney> but it does not hurt to confirm you agree to be the liason by doing so
12:07:11 <marios> does that mean you got some response from Ke Chen then sean-k-mooney ? I mean /940168/
12:07:17 <sean-k-mooney> the reason its 2 patches is we have not heard back form chenker
12:07:21 <marios> ah
12:07:43 <sean-k-mooney> so since we have not heard back i prepared the pacth and we just wont merge it until they reach out
12:07:50 <marios> ack
12:07:57 <sean-k-mooney> if we dont hear back by the ptg ill just abandon it
12:08:15 <dviroel> sean-k-mooney: does this mean that a project_update_onboarding liaison is not mandatory?
12:08:19 <sean-k-mooney> we can ad peopel at any time it just opting in to the leadership model that has a strict timelimit
12:08:27 <sean-k-mooney> dviroel: correct its not
12:08:35 <dviroel> ack
12:08:43 <sean-k-mooney> dviroel: we need infra, security and release as the minimium
12:08:47 <sean-k-mooney> tc is recommended
12:08:53 <sean-k-mooney> the other roles are all optional
12:09:22 <dviroel> sean-k-mooney: ack, thanks for the info
12:09:52 <dviroel> and the DPL model patch needs to merge before PTL elections starts?
12:10:54 * dviroel needs to read more governance docs
12:11:57 <dviroel> ok, so more info in
12:12:08 <dviroel> #link https://governance.openstack.org/tc/reference/distributed-project-leadership.html (Distributed Project Leadership)
12:12:23 <sean-k-mooney> at this point its up to the tc to review and merge
12:12:30 <sean-k-mooney> so we dont really need to do anything
12:12:46 <sean-k-mooney> gmann: ^ for context feel free to correct us if that is not the case
12:13:02 <sean-k-mooney> its porbaly a little early for gmann  but they will see that when they come online
12:13:06 <dviroel> "A project team needs to opt-in to the DPL model again, explicitly before the next cycle PTL election nominations start."
12:13:09 <sean-k-mooney> for now we can move on
12:13:13 <dviroel> sure sure
12:13:17 <dviroel> next topic
12:13:28 <dviroel> #topic Watcher core team expansion
12:13:46 <dviroel> for those that missed this thread, sean-k-mooney sent a email to the ML proposing a core expansion in watcher repos
12:14:05 <dviroel> #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/JLKUOVXGMEJJE6QA2LAVIA45ONKLS2KQ/#JLKUOVXGMEJJE6QA2LAVIA45ONKLS2KQ
12:14:49 <dviroel> sean-k-mooney wrote the reasons for the expansion and why these names were chosen to join the core team at this moment..
12:15:11 <dviroel> the tl;dr; is
12:15:26 <dviroel> add marios and dviroel to watcher-core and watcher-dashboard-core groups
12:15:40 <dviroel> add chandankumar and dviroel and remove kopecmartin from watcher-tempest-core group
12:16:02 <dviroel> did I missed something sean-k-mooney?
12:16:17 <dviroel> any questions or concerns on this proposal? or objections?
12:16:33 <marios> we've discussed this a bit over the last few weeks, including in this meeting (about needing to expand core)
12:16:52 <marios> just as one example my patch for the prometheus datasource had to sit for 2 weeks because we only have one core currently
12:17:06 <marios> there are many patches in the same situation
12:17:08 <rlandy> +1 moving forward
12:17:10 <marios> thanks for the proposal sean-k-mooney
12:17:18 <sean-k-mooney> no thats a good summary
12:17:40 <sean-k-mooney> i am on pto tomorrow so if there is no decent ill implement the changes later today
12:17:47 <amoralej> +1 go go ahead
12:17:57 <dviroel> marios: good call, the datasource had lots of non-core approvals for a long time, but we had to wait before sean-k-mooney could merge it
12:18:18 <marios> yeah i mean, to be clear we decided to do that intentionally
12:18:23 <marios> because we only have 1 active core
12:18:31 <marios> so we are force to merge with single +2
12:18:46 <marios> hence, the two week period is to allow for any reasonable comment or objections before mergint with single +2
12:19:55 <dviroel> alright, I also don't see any objections in the ML thread at this moment
12:20:39 <dviroel> #info sean-k-mooney will make the core team changes later today if there is no objections until there
12:20:40 <sean-k-mooney> ack then ill implemnet it later today
12:20:54 <sean-k-mooney> and ill reply to the mailing list once done
12:21:31 <dviroel> thanks sean-k-mooney
12:21:41 <dviroel> so moving to the next topic
12:21:59 <dviroel> #topic Reviews that need attention
12:22:18 <dviroel> I added this topic, just in case someone want to bring a request
12:22:35 <dviroel> but i don't see any :)
12:22:57 <chandankumar> dviroel: https://review.opendev.org/c/openstack/watcher/+/939702
12:23:36 <chandankumar> and https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136 needs reviews
12:23:36 <rlandy> will review that again
12:23:56 <chandankumar> thank you rlandy dviroel :-)
12:24:28 <dviroel> ack, thanks chandankumar - I will also finish my review on these
12:25:12 <rlandy> I think jgilaber also looked at those at one point
12:25:26 <marios> i have reviewed those again today lgtm
12:25:32 <dviroel> ++
12:25:54 <jgilaber> I reviewed the job one, will take another look later today
12:26:15 <marios> just minor comment on the choice for timeout but i don't think it needs an update
12:27:01 <dviroel> ok, we can move the discussion to the change itself
12:27:19 <dviroel> if we don't have any other, lets move to the next
12:27:49 <dviroel> ok, before going to the bug triage, which should take longer
12:28:09 <dviroel> #topic responded to https://openinfrafoundation.formstack.com/forms/ptg_april_2025_survey for watcher
12:28:27 <marios> o/ hey just fyi i responded to that for the ptg (it was sent to the mailnig list last week)
12:28:49 <rlandy> thank you marios
12:28:49 <marios> I don't know if anyone else also reponded (i think only one is needed ) but it shouldn't matter
12:29:26 <marios> just to signal out intentino to hold a ptg for watcher
12:29:31 <marios> our not out
12:30:10 <dviroel> marios: nice, thanks for that
12:30:22 <marios> i think we can move on dviroel it was mostly informational and in case anyone else missed it
12:30:49 <dviroel> #topic Bug Triage
12:31:37 <rlandy> malinga had that one but I don't see malinga on the channel atm
12:31:39 * dviroel is trying to find malinga's nick
12:32:07 <rlandy> it looks like there are a few proposed to look at - so perhaps we can start there
12:32:10 <marios> so we discussed this a bit in the bug triage meeting
12:32:25 <marios> the idea was to have this item in our agenda and try to triage a couple of bugs each week now that we are down to reasonable numbers
12:32:45 <marios> so lets go with the triage and malinga added a few in the agenda
12:32:50 <dviroel> ack
12:32:56 <dviroel> mtembo: o/
12:33:04 <dviroel> first one
12:33:09 <dviroel> #link https://bugs.launchpad.net/watcher/+bug/1873377
12:33:33 <rlandy> dviroel: this one is fix committed
12:33:38 <marios> this looks like fix committed
12:33:39 <marios> right
12:33:42 <dviroel> right
12:33:48 <marios> :)
12:33:54 <dviroel> next one
12:33:55 <rlandy> so can it move to fix released at this point?
12:34:06 <rlandy> so it comes off the list?
12:34:22 <rlandy> fix was committed in 2020
12:34:34 * dviroel read fix release instead - lol
12:34:38 <marios> +1 sounds good ... but i wonder... perhaps there were no releases ? is that possible .. i mean if no-one cut the release for the project?
12:34:50 <marios> sean-k-mooney: do you know? I haven't checked were there any releases since 2020?
12:35:08 <rlandy> it may just be the series thing?
12:35:26 <sean-k-mooney> sorrry reading back
12:35:28 <marios> like watcher in whatever state would have been released with therest of openstack so yeah must be
12:35:49 <amoralej> yes, there have been releases, at least since train
12:35:52 <amoralej> that i can see
12:35:54 <marios> i mean must be the missing series rlandy like release was made but this just didnt get updated , so i think +1 to making it fix released
12:36:02 <marios> thanks amoralej
12:36:15 <rlandy> ok - I'll change the status of the bug and we can move on
12:36:16 <sean-k-mooney> so i belive oslo serisistion ahs handling for decimel
12:36:33 <marios> question is if it should go fix release, it is already fix committed sean-k-mooney
12:36:34 <sean-k-mooney> but wsme may not
12:36:42 <sean-k-mooney> wsme is not widely used
12:36:42 <amoralej> this is what RDO has included in latest releases https://paste.centos.org/view/a139ca9a
12:37:04 <sean-k-mooney> fix commited is not used anymore
12:37:22 <sean-k-mooney> we always go direct to fix released
12:37:31 <sean-k-mooney> so yes it should be marked fix released once its merged
12:38:02 <dviroel> ok, thanks for updating it rlandy
12:38:40 <dviroel> #link https://bugs.launchpad.net/watcher/+bug/1846314
12:39:10 <sean-k-mooney> for context we stopped differenciating between fix commited vs released  about 6-7 years ago
12:39:20 <marios> this is about packaging
12:39:33 <sean-k-mooney> that is not a watcher bug so ya close invlaid it a packaging bug
12:39:37 <dviroel> yeah, this is not about watcher
12:39:39 <sean-k-mooney> this is the worng watcher compoient
12:39:43 <marios> so as commented on the bug already from licanwei
12:39:55 <sean-k-mooney> there is a sperate one for the ubuntu packaging
12:40:05 <sean-k-mooney> rocky is also EOL so this is not relevnet anymore
12:40:07 <marios> +1 this one is closed invalid
12:40:38 <sean-k-mooney> ubuntu 18.04 is alos eol as is 19.10
12:40:44 <rlandy> dviroel: want me to update the bugs in background so you can work here?
12:41:23 <dviroel> rlandy: sure, we need only one to actually change things :)  thanks
12:41:33 <rlandy> k
12:41:54 <dviroel> next is
12:42:09 <dviroel> #link https://bugs.launchpad.net/watcher/+bug/1847091 (Actions do not start executing)
12:42:15 <mtembo> Can i please do it to get used to it (updating)
12:42:48 <dviroel> this one is from 2019..
12:43:48 <sean-k-mooney> its python 2.7
12:43:54 <amoralej> what i can tell is that i didn't find that in my tests ...
12:44:12 <sean-k-mooney> was that still even supproted
12:44:37 <sean-k-mooney> oh again rocky on 18.04
12:45:42 <amoralej> I think it's safe to close
12:45:44 <sean-k-mooney> i would vote ot say invalid
12:45:49 <amoralej> +1
12:46:04 <sean-k-mooney> do we have obsolete as an option
12:46:34 <sean-k-mooney> no ok so invalid or wont fix
12:47:01 <sean-k-mooney> the release is EOL and it does not happen on master so it must have been fixed
12:47:05 <amoralej> yep, i miss obsolete
12:48:03 <marios> lets gooo
12:48:05 <dviroel> i would say that is won't fix, since is too old to reproduce
12:48:07 <marios> :)
12:48:53 <dviroel> #link https://bugs.launchpad.net/watcher/+bug/1843957 (incorrect project name for osloc_config)
12:48:55 <amoralej> "can't reproduce" would be a good state too :)
12:49:07 <marios> this one was a valid bug at some point but i think it is fix released
12:49:15 <marios> at least on master, as linked in the bug
12:49:23 <marios> so fix-released?
12:49:40 <amoralej> it was merged long ago and backported
12:49:58 <dviroel> correct
12:50:05 <dviroel> to rocky and stein
12:50:24 <sean-k-mooney> ya so we can mark it as fix released as marios suggets
12:50:37 <sean-k-mooney> by this https://github.com/openstack/watcher/commit/86af6ab8a20913fff972497b07e8ae592113b273
12:50:40 <dviroel> ++
12:50:54 <dviroel> next
12:50:58 <marios> nice to have all the context and links
12:51:14 <sean-k-mooney> git blame is awsome until you are trying to figure out who intoduced the bug and find out it was younger you
12:51:14 <dviroel> #link https://bugs.launchpad.net/watcher/+bug/1801295 (watcher tempest test failed)
12:51:25 <marios> sean-k-mooney: :)
12:51:41 <marios> dviroel: this one has comment about "
12:51:41 <marios> This issue was fixed in the openstack/watcher-tempest-plugin 1.1.0 release.
12:52:25 <sean-k-mooney> i just set it to fix released
12:52:27 <marios> so perhaps the status was just not updated
12:52:34 <mtembo> ++
12:53:03 <sean-k-mooney> watcher was not creating the serise in launchpad
12:53:09 <sean-k-mooney> so the bot was not auto updating them
12:53:13 <dviroel> ack
12:53:32 <sean-k-mooney> i have fixed that i think for the current supproted releases
12:53:52 <dviroel> next one is
12:53:53 <dviroel> #link https://bugs.launchpad.net/watcher/+bug/1785962 (TypeError: not all arguments converted during string formatting)
12:54:05 <marios> i think same as previous
12:54:11 <marios> This issue was fixed in the openstack/watcher 1.12.0 release.
12:54:28 <mtembo> not updated it seems
12:55:24 <dviroel> alright, so moving to tempest-plugin one
12:55:50 <dviroel> #link https://bugs.launchpad.net/watcher-tempest-plugin/+bug/2095416 (Audit Template Stuck in Pending State Prevents API Deletion, Causing Test Failur)
12:55:54 <sean-k-mooney> yep i agree
12:56:17 <mtembo> updating to fix-released
12:56:43 <sean-k-mooney> the next one looks valid to me so we shoudl set it to in progress
12:56:44 <dviroel> the tempest-plugin one was reported by mtembo
12:57:01 <sean-k-mooney> oh maybe not
12:57:09 <sean-k-mooney> the patch is to repoduce
12:57:18 <mtembo> yes
12:57:19 <amoralej> the actual error is being stuck in pending or not being able to delete it?
12:57:25 <mtembo> I created tests and they all passed
12:57:31 <mtembo> so it should be fixed
12:57:40 <mtembo> cross checked with Chandan
12:57:43 <sean-k-mooney> so this could have been related to eventlet and py 3.12
12:57:46 <chandankumar> amoralej: yes, that is the correct issue
12:57:59 <sean-k-mooney> before my orginal eventlet/3.12 fix that was the behavior
12:58:05 <amoralej> note that error when trying to delete a pending audit is expected
12:58:05 <sean-k-mooney> it woudl stay in pending indefintly
12:58:35 <amoralej> yeah ^ that's the real issue, i guess
12:58:48 <chandankumar> If we run the failing tempest tests seperately, then it passes. But if the tests as a whole then it comes sometimes
12:58:49 <sean-k-mooney> im pretty sure it was "fixed" by https://github.com/openstack/watcher/commit/f07694ba6c75315dac1407c3751645de35ed14f4
12:59:24 <sean-k-mooney> chandankumar: did you check the failing time to ensure its not because of a 40-9
12:59:44 <sean-k-mooney> https://bugs.launchpad.net/watcher-tempest-plugin/+bug/2090854 causes intermitent failures
13:00:39 <sean-k-mooney> i woudl suggest closing https://bugs.launchpad.net/watcher-tempest-plugin/+bug/2095416 for now
13:01:05 <sean-k-mooney> adn we can reopen if we see it reoccur
13:01:17 <sean-k-mooney> although hum
13:01:24 <marios> that is the first time we did this triage here but imo we should try and limit it next time so we can allow for any other topic and open floor
13:01:27 <chandankumar> sean-k-mooney: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4a1/938136/8/check/watcher-tempest-strategies/4a18ad4/testr_results.html
13:01:29 <sean-k-mooney> it was filed 9 days ago
13:01:34 <chandankumar> it was not 409 issue
13:01:39 * dviroel checks the clock
13:01:52 <chandankumar> Details: {'error_message': '{"faultcode": "Client", "faultstring": "Couldn\'t delete when state is \'PENDING\'.", "debuginfo": null}'}
13:02:02 <sean-k-mooney> ack ok lets leave this open for next week
13:02:11 <dviroel> i would say that we need to check if still happens, if yes, we should link/upload some logs to help on debug
13:02:20 <sean-k-mooney> marios: perhaps we shoudl do it after open disucsion not before
13:02:52 <marios> yeah maybe sean-k-mooney ... to be clear i am glad we did this it was useful but we should just be careful on time and not get carried away
13:03:29 <dviroel> we are out of time, lets wrap up for today
13:03:48 <dviroel> sorry for missing the open discussions topic today
13:04:01 <dviroel> thanks mtembo for bringing the bugs to triage
13:04:06 <dviroel> thank you all for participating
13:04:07 <mtembo> so what's the status update for
13:04:07 <mtembo> Audit Template Stuck in Pending State Prevents API Deletion, Causing Test Failure
13:04:08 <rlandy> will take note for next meeting
13:04:14 <marios> yeah i was going to say
13:04:14 <rlandy> thanks dviroel
13:04:15 <dviroel> #endmeeting