| airship-irc-bot | <chumkidas22> Hi @raliev Requesting a review on https://review.opendev.org/c/airship/airshipctl/+/781135 . Thanks | 06:12 |
|---|---|---|
| *** uzumaki has quit IRC | 08:43 | |
| airship-irc-bot | <niha.twinkle> Hi Team, could you please review this PS related to plan list -o yaml command https://review.opendev.org/c/airship/airshipctl/+/771286 (Need one more +2 and WF). Thanks in advance. | 12:47 |
| airship-irc-bot | <digambar.patil> @mattmceuen @ih616h - Already got +2 - https://review.opendev.org/c/airship/treasuremap/+/787406. If possible, can you guys approve - https://review.opendev.org/c/airship/treasuremap/+/787406 & merge as this is last small PS for story #86 | 14:11 |
| airship-irc-bot | <sirishagopigiri> Hi Team, Requesting some reviews and core-reviews for PSs related to documentation issue #280, #281 and `get-context` command issue #526 https://review.opendev.org/c/airship/airshipctl/+/786654 --- Fixes issue #526 and also helps in issue #280 https://review.opendev.org/c/airship/airshipctl/+/786629 --- go code changes related to #280 https://review.opendev.org/c/airship/airshipctl/+/784358 --- go code to generate | 14:15 |
| airship-irc-bot | documentation and generated documentation file related to #280 https://review.opendev.org/c/airship/airshipctl/+/786838 --- zuul gate check for documentation related to #280 https://review.opendev.org/c/airship/airshipctl/+/787669 --- help output documentation related to #281 Thank you in advance! | 14:15 |
| airship-irc-bot | <suresh.lakshmipathy> Hi Team, Please review - https://review.opendev.org/c/airship/hostconfig-operator/+/785945. This is about adding ethtool support for HCO. | 14:17 |
| airship-irc-bot | <mf4716> All configuration issues resolved, and things back up and running in CityCloud? How did the configs change? | 14:46 |
| airship-irc-bot | <dwalt> Hey all, there is a comment in the validate-site-docs script that I noticed: ``` # TODO: will need to loop through phases in order, eventually # e.g., load CRDs from initinfra first, so they're present when validating later phases``` It looks like we need this for Treasuremap since the phase in which ViNO is deployed precedes applying its CRs. I just wanted to check here first, are we working around this already for any | 15:39 |
| airship-irc-bot | other phases? | 15:39 |
| airship-irc-bot | <mf4192> Hi team, this PS to true up the treasuremap versions catalogue is ready for review: https://review.opendev.org/c/airship/treasuremap/+/786884 | 17:16 |
| *** openstackstatus has quit IRC | 18:31 | |
| airship-irc-bot | <mattmceuen> @digambar.patil @dwalt I WF'd the vino image replacement tag but added a note we need to think about as follow-on: This matches the string we have in the template now, but it will not match once the template gets updated -- vino master has "quay.io/airshipit/libvirt:latest-ubuntu_bionic" (note the tag). We should consider just making this a placeholder string in the template YAML (i.e. REPLACE_LIBVIRT_IMAGE or something), but we | 18:31 |
| airship-irc-bot | can follow on with that | 18:31 |
| *** openstackstatus has joined #airshipit | 18:32 | |
| *** ChanServ sets mode: +v openstackstatus | 18:32 | |
| airship-irc-bot | <kk6740> how urgent is that replacement? i have another solution, but it will take time to develop in next vino iterations? I embed pod template into vino spec and then create a daemonset set out of it | 18:35 |
| airship-irc-bot | <kk6740> similar like actual deployments and daemonsets works | 18:35 |
| airship-irc-bot | <kk6740> this way u will have a field for image instead of literal | 18:35 |
| airship-irc-bot | <ak3216> Hi team, I think airshipbot is closing out treasuremap issues in airshipctl. Take https://review.opendev.org/c/airship/treasuremap/+/787406/ as an example. The closed message went to https://github.com/airshipit/airshipctl/issues/123. I can open a bug, but in which project? Airshipctl. | 19:33 |
| airship-irc-bot | <dwalt> @mattmceuen Sounds good, that makes sense to me. @kk6740 I don't think it's urgent, but we've been encouraging adding replacement/catalogue entries for functions added to Treasuremap | 19:52 |
| airship-irc-bot | <dwalt> Makes downstream consumption a lot easier | 19:52 |
| airship-irc-bot | <mattmceuen> @kk6740 @dwalt yeah agree, your version sounds much better preferable Konstantine, but we could merge Digambar's change to match what we have now, and then update the source and the target at the same time once your change is in | 19:56 |
| airship-irc-bot | <kk6740> :+1: | 20:02 |
| airship-irc-bot | <james.gu> For the go-redfish experts on the team, there is an issue with how golang json encoder adds a new line at the end of the json string which causes a mis-mtach between the content-length and post body in the redfish api request sent to iLO (used in the linux foundation lab). the iLO redfish errors out waiting for last character that never comes and the remotedirect phase run fails. Details in | 21:59 |
| airship-irc-bot | https://github.com/airshipit/airshipctl/issues/535. I can easily add a trim call in client.go or api_default.go in the go-redfish, but are those source files auto-generated by the openapi? If yes, do you have suggestions where we can add the trim call or correct the content length? | 21:59 |
| airship-irc-bot | <kk6740> i think its autogenerated | 22:01 |
| airship-irc-bot | <kk6740> is it only HP specific? | 22:02 |
| airship-irc-bot | <kk6740> and runs fine in dell labs? | 22:02 |
| airship-irc-bot | <kk6740> is it one of these libs: redfishAPI “opendev.org/airship/go-redfish/api” redfishClient “opendev.org/airship/go-redfish/client” | 22:03 |
| airship-irc-bot | <kk6740> or in airshipctl itself? | 22:03 |
| airship-irc-bot | <james.gu> It is in the “opendev.org/airship/go-redfish/client”. | 22:03 |
| airship-irc-bot | <james.gu> Dell's iDrac redfish seems to be more tolerant with the newline and content-length mismatch so it works there. the issue is with iLO servers. | 22:04 |
| airship-irc-bot | <kk6740> i dont think we should trim | 22:05 |
| airship-irc-bot | <james.gu> haha, there is discussion in golang whether it should have the new line at the end: https://github.com/golang/go/issues/37083 | 22:06 |
| airship-irc-bot | <kk6740> i’ve read that discussion | 22:06 |
| airship-irc-bot | <kk6740> it seems like the go behavior is correct | 22:07 |
| airship-irc-bot | <james.gu> it is corrected as it is defined so | 22:07 |
| airship-irc-bot | <james.gu> it is correct as it is defined :slightly_smiling_face: | 22:07 |
| airship-irc-bot | <kk6740> how did u came to the conclustion that it was exactly trim problem? | 22:08 |
| airship-irc-bot | <kk6740> missing `"` ? | 22:09 |
| airship-irc-bot | <james.gu> a long story and a lot of debug statement :slightly_smiling_face:. | 22:09 |
| airship-irc-bot | <kk6740> sorry for stupid questions | 22:09 |
| airship-irc-bot | <james.gu> once I changed the content-length to match the actual json string, it works | 22:09 |
| airship-irc-bot | <james.gu> no it was a good question | 22:09 |
| airship-irc-bot | <kk6740> i dont think we should trim anything, it is strange that iLO fails to read it. I remember that there were some issues with Dell redfish as well. I think they fixed them in their redfish firmware (not sure) | 22:25 |
| airship-irc-bot | <kk6740> but i think that if dell works, sushy works and supermicro works | 22:26 |
| airship-irc-bot | <kk6740> the problem is on iLO side | 22:26 |
| airship-irc-bot | <kk6740> but maybe we can take a look at the openapi generation, maybe there is some way to specify how code is generated for specific fields (wild guess)? | 22:27 |
| airship-irc-bot | <james.gu> Yeah, I do agree that iLO side should handle it more intelligently comparing the content-length and actual posted request body (with or without white spaces at the end). I forwarded the but to an HPE engineer in the Anuket community hoping he can pass it along to the iLO team. | 22:34 |
| airship-irc-bot | <james.gu> I'll take a look at it at the openapi generation too. | 22:37 |
| airship-irc-bot | <kk6740> it is unfortunate, we can ofcourse try to change genrated API, but if we need to regenerate it some point, this would cause problems | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!