| *** thansen has quit IRC | 00:01 | |
| *** thansen has joined #airshipit | 00:01 | |
| airship-irc-bot | <thaulow> @rp2723 what timeline do you think we would talk about, release 2.1 or further down the road? | 01:18 |
|---|---|---|
| airship-irc-bot | <ratnopam.chakrabarti> Hi, can I please get core reviews on https://review.opendev.org/c/airship/treasuremap/+/786905? This is to address https://github.com/airshipit/treasuremap/issues/119. Thanks in advance. | 13:09 |
| airship-irc-bot | <sirishagopigiri> Hi Team, Requesting some reviews on the local storage PSs https://review.opendev.org/c/airship/charts/+/780846 https://review.opendev.org/c/airship/treasuremap/+/788289 Thank you in advance! | 13:31 |
| airship-irc-bot | <kk6740> Hi, Team. Please review when you have time https://review.opendev.org/c/airship/vino/+/788370 | 14:57 |
| airship-irc-bot | <sirajudeen.yasin> Hi Team, Requesting some review for this PS https://review.opendev.org/c/airship/airshipctl/+/787436 | 15:13 |
| airship-irc-bot | <sirishagopigiri> Hi Team, Requesting some reviews and core-reviews for PSs related to documentation issue #280, #281 and `get-context` command issue #526 https://review.opendev.org/c/airship/airshipctl/+/786654 --- Fixes issue #526 and also helps in issue #280 https://review.opendev.org/c/airship/airshipctl/+/786629 --- go code changes related to #280 https://review.opendev.org/c/airship/airshipctl/+/784358 --- go code to generate | 15:39 |
| airship-irc-bot | documentation and generated documentation file related to #280 https://review.opendev.org/c/airship/airshipctl/+/786838 --- zuul gate check for documentation related to #280 https://review.opendev.org/c/airship/airshipctl/+/787669 --- help output documentation related to #281 Thank you in advance! | 15:39 |
| airship-irc-bot | <ratnopam.chakrabarti> Hi, https://review.opendev.org/c/airship/airshipctl/+/785422 needs another +2. Can you please review? Thanks. | 17:16 |
| airship-irc-bot | <niha.twinkle> Hi Team, can I please get some reviews of this PS related to plan list -o yaml command https://review.opendev.org/c/airship/airshipctl/+/771286 (needs one more +2 and wf) . Thanks in advance. | 19:34 |
| airship-irc-bot | <mattmceuen> Hey @sean.eagan it looks like for replacement transformer (and probably others), the v2 tag is not being updated and is 22 days old. You set that up to be a moving tag, right? Did a follow-on tweak to get "latest" updating again (iirc) break it? | 20:44 |
| airship-irc-bot | <mattmceuen> Note: there's a problem with the :latest replacement transformer that @ao129q is looking at now, so we probably want to resolve that before updating the tag -- it slipped in since we were pinned to old :v2 I believe | 20:45 |
| airship-irc-bot | <sean.eagan> yeah, this is the trade off, if we were using `latest` we would have caught it quicker. if we want to update the v2 tag we need to make a new v2 release by pushing a new git tag e.g. `templater-v2.0.3` to the airshipctl repo | 20:48 |
| airship-irc-bot | <mattmceuen> ah, I see. So it's a moving branch, but the branch only moves when you push a tag. I'd been thinking it would have the same semantics as "latest" until we decided to make it "stick" to a commit, and then move forward with v3 | 20:50 |
| airship-irc-bot | <mattmceuen> I think we'll just need to talk through the dev/test/release cycle for those plugins - good design call topic? | 20:51 |
| airship-irc-bot | <mattmceuen> For sure we'll want to update the krm function pins more frequently than we do big releases, but "how frequently" I'm not sure what we need | 20:52 |
| airship-irc-bot | <sirajudeen.yasin> @mattmceuen, this PS is fix for the plugins latest version issue | 21:56 |
| airship-irc-bot | <sirajudeen.yasin> https://review.opendev.org/c/airship/airshipctl/+/787436 | 21:57 |
| airship-irc-bot | <kk6740> @sirajudeen.yasin @mattmceuen i see that every plugin that uses airshipctl as library downloads it from upstream, rather than use current state of the repository. so basically at any point KRM functions always lag behind airshipctl? | 22:09 |
| airship-irc-bot | <mattmceuen> Yeah, looks like you're right | 22:13 |
| airship-irc-bot | <kk6740> for example, I add this change : https://review.opendev.org/c/airship/airshipctl/+/788379/6 and try to use this change in the next patchset here: https://review.opendev.org/c/airship/airshipctl/+/787575/15 So i rebase it on top of it, but it doesn’t compile, because instead of taking local copy of airshipctl library and compiling it into the krm-function binary, compiler downloads it from upstream repository | 22:13 |
| airship-irc-bot | <kk6740> so in airship release we have 2 airshipctls :slightly_smiling_face: one that is used as binary and 2nd one that is used by krm-functions as library | 22:15 |
| airship-irc-bot | <lb4368> There is an open issue https://github.com/airshipit/airshipctl/issues/524 to address gating the krm functions. Needs some design discussion. I can add it to an agenda | 22:15 |
| airship-irc-bot | <mattmceuen> @lb4368 I think that would be a good idea, it's related to what I added to tomorrow's agenda anyway | 22:16 |
| airship-irc-bot | <lb4368> Will do | 22:19 |
| airship-irc-bot | <kk6740> since i got ur attention, can u review this please: https://review.opendev.org/c/airship/airshipctl/+/788379/6 basically a freebie :slightly_smiling_face: | 22:19 |
| airship-irc-bot | <kk6740> @mattmceuen thanks | 22:19 |
| airship-irc-bot | <mf4716> Need one more airshipctl core +2 and WF on one of @niha.twinkle’s PS: https://review.opendev.org/c/airship/airshipctl/+/771286 (please) | 22:44 |
| airship-irc-bot | <mf4716> ^^ thank you @mattmceuen and @kk6740 for your reviews & WF on the above 771286 | 23:36 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!