airship-irc-bot | <sirishagopigiri> Hi team, Requesting some reviews on the below PS https://review.opendev.org/c/airship/treasuremap/+/788289 (related to treasuremap issue #27) thank you in advance! | 13:36 |
---|---|---|
airship-irc-bot | <sirishagopigiri> Hi Team, requesting another +2 and WF +1 for PS related to #281 issue: https://review.opendev.org/c/airship/airshipctl/+/789775, thank you! | 13:37 |
airship-irc-bot | <sirishagopigiri> Hi Team, Requesting some reviews on the below PSs related to #280 https://review.opendev.org/c/airship/airshipctl/+/790020 https://review.opendev.org/c/airship/airshipctl/+/790023 https://review.opendev.org/c/airship/airshipctl/+/790026 https://review.opendev.org/c/airship/airshipctl/+/790033 https://review.opendev.org/c/airship/airshipctl/+/789250 https://review.opendev.org/c/airship/airshipctl/+/786838 Most | 13:51 |
airship-irc-bot | PSs are related to documentation, changing the description for the commands and adding examples. These changes are later used to generate the docs for the airshipit.org site using gocobra doc library. Thank you in advance! | 13:51 |
airship-irc-bot | <sidney.shiba> Hi core reviewers, I need another +2 for the following PS. Some other issues depends on these PS to be merged so I appreciate your time and assistance: • https://review.opendev.org/c/airship/treasuremap/+/788991 • https://review.opendev.org/c/airship/charts/+/785540 | 14:27 |
airship-irc-bot | <pg588x> review pls https://review.opendev.org/c/airship/airshipctl/+/791530 | 15:11 |
airship-irc-bot | <mattmceuen> @dwalt I don't see the v2 treasuremap branch in github or opendev -- I think @mf4192 already deleted it, right Matt? | 19:32 |
airship-irc-bot | <dwalt> Nice! that means the patches stick around :slightly_smiling_face: | 19:33 |
airship-irc-bot | <dwalt> I will proceed to abandon them | 19:33 |
airship-irc-bot | <mf4192> Yup, v2 was deleted | 19:33 |
airship-irc-bot | <mattmceuen> Thanks :slightly_smiling_face: | 19:33 |
airship-irc-bot | <kk6740> case closed :slightly_smiling_face: | 19:33 |
airship-irc-bot | <mf4192> Hi team, https://review.opendev.org/c/airship/airshipctl/+/778931 went into merge conflict after getting approved, so I had to rebase and lost reviews on it. Would appreciate re-reviews if anyone has time today. It just cleared CI / zuul checks | 19:39 |
airship-irc-bot | <mattmceuen> I'd appreciate another review of this trivial change to improve our airshipctl flux-helm kustomization structure: https://review.opendev.org/c/airship/airshipctl/+/790791 | 20:36 |
-openstackstatus- NOTICE: The Zuul service at zuul.opendev.org will be offline for a few minutes (starting now) in order for us to make some needed filesystem changes; if the outage lasts longer than anticipated we'll issue further notices | 21:31 | |
airship-irc-bot | <sidney.shiba> Hi Replacement transformer experts, how do I replace an item from a list? See example below, where I need to replace the value *-* "*dex.function.local*" by something like "*- dex.subcluster-a.lab.com*".: `spec:` `infrastructureTemplate:` `apiVersion: infrastructure.cluster.x-k8s.io/v1alpha4` `kind: Metal3MachineTemplate` `name: cluster-controlplane` `kubeadmConfigSpec:` `clusterConfiguration:` | 21:48 |
airship-irc-bot | `apiServer:` `certSANs:` `- dex.function.local` | 21:48 |
airship-irc-bot | <dwalt> @sidney.shiba I would recommend pattern substitution. Here is an example in the Helm operator, where the replacement rules replace the pattern `REPLACEMENT_HTTP_PROXY` in a Deployment | 21:52 |
airship-irc-bot | <dwalt> I think you could also just substitute the whole list if the value is already in list form. The jsonpaths also support indexing, but that can be risky unless you know all elements and the exact order | 21:56 |
airship-irc-bot | <sidney.shiba> I'll try the latter as I only need one element. | 22:09 |
airship-irc-bot | <sidney.shiba> Thanks for the help | 22:10 |
airship-irc-bot | <dwalt> no problem! | 22:11 |
airship-irc-bot | <sidney.shiba> it worked. Thanks again. | 22:13 |
*** uzumaki has joined #airshipit | 22:45 | |
*** uzumaki has quit IRC | 22:46 | |
*** uzumaki has joined #airshipit | 22:47 | |
*** uzumaki has quit IRC | 23:44 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!