| airship-irc-bot | <kk6740> @mattmceuen @dwalt @sreejith.punnapuzha can you help in understanding this patchset https://review.opendev.org/c/airship/treasuremap/+/791608 ? | 00:22 |
|---|---|---|
| airship-irc-bot | <kk6740> asking this because of the `plan run` , we are doing certain labeling in phase plan, and I was wondering if we should get rid of it as well | 00:23 |
| airship-irc-bot | <mattmceuen> The removed script bit was redundant with this: https://github.com/airshipit/airshipctl/blob/master/manifests/function/k8scontrol/controlplane.yaml#L33 | 00:29 |
| airship-irc-bot | <mattmceuen> in the plan run, what do you label? | 00:30 |
| airship-irc-bot | <kk6740> @mattmceuen https://review.opendev.org/c/airship/airshipctl/+/784958/23/manifests/function/phase-helpers/wait_label_node/kubectl_wait_label_node.sh check line 37 there | 00:31 |
| airship-irc-bot | <kk6740> `"node-role.kubernetes.io/worker="` | 00:31 |
| airship-irc-bot | <mattmceuen> gotcha | 00:32 |
| airship-irc-bot | <mattmceuen> I'm doing some quick grepping for the kubeadmConfigSpec that is being used in the controlplane object, but I don't think it is used by the machinedeployment unfortunately | 00:32 |
| airship-irc-bot | <mattmceuen> so you may only be able to use that particular trick for control plane labels | 00:33 |
| airship-irc-bot | <kk6740> ok, thanks! | 00:33 |
| airship-irc-bot | <kk6740> we’ll keep this hack for now | 00:33 |
| airship-irc-bot | <mattmceuen> :) | 00:33 |
| airship-irc-bot | <raliev> `node-role` isn't available for setup via `node-labels` in `kubeletExtraAgrs` | 00:33 |
| airship-irc-bot | <sreejith.punnapuzha> @kk6740 node-role is not an allowed label prefix. so we wont be apply it via kubeadmconfigtemplate | 00:34 |
| airship-irc-bot | <sreejith.punnapuzha> https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#noderestriction | 00:34 |
| airship-irc-bot | <kk6740> thank you, i know that. But i thought maybe you found a workaround | 00:34 |
| airship-irc-bot | <kk6740> we’ll keep the hack for now and maybe change it a bit later | 00:34 |
| airship-irc-bot | <kk6740> it is really a dirty hack | 00:35 |
| airship-irc-bot | <kk6740> so i was hoping we have some more stable solution | 00:35 |
| airship-irc-bot | <mattmceuen> ah, I see, the KubeadmConfigTemplate for the workers does have the same kubeletExtraArgs in a different place | 00:35 |
| *** uzumaki has joined #airshipit | 01:23 | |
| *** uzumaki has quit IRC | 04:45 | |
| *** uzumaki has joined #airshipit | 05:50 | |
| *** uzumaki has quit IRC | 06:01 | |
| airship-irc-bot | <ao129q> may I have reviews here please https://review.opendev.org/c/airship/airshipctl/+/791886 https://review.opendev.org/c/airship/airshipctl/+/791051 | 06:17 |
| airship-irc-bot | <vkozhukalov> @mattmceuen @raliev could you please take a look at https://review.opendev.org/c/airship/airshipctl/+/784567 | 08:39 |
| *** uzumaki has joined #airshipit | 12:52 | |
| airship-irc-bot | <sirishagopigiri> Hi Core reviews, Requesting some reviews on the below PSs: https://review.opendev.org/c/airship/treasuremap/+/788289 (related to treasuremap issue #27) https://review.opendev.org/c/airship/airshipctl/+/789775 (related to airshipctl #281 issue) https://review.opendev.org/c/airship/airshipctl/+/790020 (related to airshipctl #280 issue) Thank you in advance! | 12:57 |
| airship-irc-bot | <sirishagopigiri> Hi Team, Requesting some reviews on the below PSs related to #280 https://review.opendev.org/c/airship/airshipctl/+/790023 https://review.opendev.org/c/airship/airshipctl/+/790026 https://review.opendev.org/c/airship/airshipctl/+/790033 https://review.opendev.org/c/airship/airshipctl/+/789250 https://review.opendev.org/c/airship/airshipctl/+/786838 Thank you in advance! | 12:58 |
| *** gagehugo has quit IRC | 13:35 | |
| *** megheisler has quit IRC | 13:35 | |
| airship-irc-bot | <ma257n> Hi Team, Could you please provide review comments for vm-infra-bridge PS https://review.opendev.org/c/airship/treasuremap/+/787378 Thanks in advance | 13:37 |
| *** megheisler has joined #airshipit | 13:38 | |
| *** gagehugo has joined #airshipit | 13:38 | |
| *** openstack has joined #airshipit | 14:07 | |
| *** ChanServ sets mode: +o openstack | 14:07 | |
| *** uzumaki has quit IRC | 14:10 | |
| *** openstackstatus has joined #airshipit | 14:11 | |
| *** ChanServ sets mode: +v openstackstatus | 14:11 | |
| airship-irc-bot | <mf4716> Thanks @ma257n for securing a +1 on the much needed VM Infra Bridge PS - https://review.opendev.org/c/airship/treasuremap/+/787378. @dwalt, @kk6740, @sean.eagan, @mattmceuen, if you can please review for +2s and WF. | 14:43 |
| *** rezroo has joined #airshipit | 15:01 | |
| airship-irc-bot | <mattmceuen> @mf4716 @ma257n I gave it a +2 due to the urgency, but there are a couple of open problems/questions still which should probably be fixed in a follow-on patchset -- I left comments in the PS if you could please take a look @ma257n. Also FYI @mf4192 since this is related to your workers change. | 15:02 |
| airship-irc-bot | <sidney.shiba> In the past I used `airshipctl phase render iso-cloud-init-data` and searched for `isoImage` to retrieve `deployer` user's password for SSHing the ephemeral node. I tried today and it is not there anymore. What do I need to render to get this password? | 16:06 |
| *** sreejithp has joined #airshipit | 16:20 | |
| airship-irc-bot | <sidney.shiba> Hi team, I created a PS (https://review.opendev.org/c/airship/images/+/791990) that is ready for review. This PS bakes the dex helm charts supporting LDAP into the helm chart collator docker image. | 16:40 |
| airship-irc-bot | <kk6740> @sidney.shiba run `airshipctl phase render/run show-secret` | 16:46 |
| airship-irc-bot | <sidney.shiba> It didn't return anything. What am I missing? See below: `$ airshipctl phase render show-secret` `gpg: keybox '/tmp/pubring.kbx' created` `gpg: /tmp/trustdb.gpg: trustdb created` `gpg: key 3D16CEE4A27381B4: public key "SOPS Functional Tests Key 1 (https://github.com/mozilla/sops/) <secops@mozilla.com>" imported` `gpg: key 3D16CEE4A27381B4: secret key imported` `gpg: key D8720D957C3D3074: public key "SOPS Functional Tests Key 2 | 16:52 |
| airship-irc-bot | (https://github.com/mozilla/sops/) <secops@mozilla.com>" imported` `gpg: key D8720D957C3D3074: secret key imported` `gpg: key 3D16CEE4A27381B4: "SOPS Functional Tests Key 1 (https://github.com/mozilla/sops/) <secops@mozilla.com>" not changed` `gpg: key D8720D957C3D3074: "SOPS Functional Tests Key 2 (https://github.com/mozilla/sops/) <secops@mozilla.com>" not changed` `gpg: key 19F9B5DAEA91FF86: public key "SOPS Functional Tests Key 3 | 16:52 |
| airship-irc-bot | (https://github.com/mozilla/sops/) <secops@mozilla.com>" imported` `gpg: Total number processed: 5` `gpg: imported: 3` `gpg: unchanged: 2` `gpg: secret keys read: 2` `gpg: secret keys imported: 2` `document filtered by selector [Group="airshipit.org", Version="v1alpha1", Kind="Phase", Name="show-secret"] found no documents` | 16:52 |
| airship-irc-bot | <ao129q> may I have reviews on https://review.opendev.org/c/airship/airshipctl/+/791886 please | 18:46 |
| *** uzumaki has joined #airshipit | 22:44 | |
| airship-irc-bot | <sidney.shiba> Hi, still failing to configure the control plane node during the _*initinfra-networking-target*_ phase. The command _*airshipctl phase run initinfra-networking-target*_ timed out waiting for the _*cert manager*_ to be ready, therefore terminating the process and not reaching the deployment of *ironic* and *metal3-baremetal-operator* pods._Is this timeout duration configurable so it can be longer?_ _`error: timed out waiting for | 23:09 |
| airship-irc-bot | the condition on pods/cert-manager-c5f45c6b7-qb95q`_ | 23:09 |
| airship-irc-bot | <mf4192> Hi team, https://review.opendev.org/c/airship/airshipctl/+/778931 is ready for re-review. It’s passed CI, zuul, and zuul experimental pipeline, so if it doesn’t time out again, it should merge this time… | 23:20 |
| *** uzumaki has quit IRC | 23:32 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!