| *** openstack has joined #ara | 05:58 | |
| *** myoung|afk has joined #ara | 12:26 | |
| larsks | dmsimard: I don't think it makes sense to display a count of hosts on the dashboard, since there's no way to accurately count them. I think having that display on a playbook summary screen would make a lot of sense. | 12:55 |
|---|---|---|
| larsks | (# of hosts, # of tasks, maybe # of files involved?) | 12:55 |
| dmsimard | I'll put up a WIP to generate discussion today | 12:57 |
| *** myoung|afk has quit IRC | 13:29 | |
| *** myoung|afk has joined #ara | 13:32 | |
| *** myoung|afk is now known as myoung | 13:49 | |
| dmsimard | eh, pbr and it's magical things .. | 13:58 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: WIP: Interface facelift https://review.openstack.org/330576 | 14:03 |
| dmsimard | larsks: ^ you should have the new UI built in the integration tests when they're done | 14:03 |
| dmsimard | I stress that it's mostly just for discussion at this point | 14:04 |
| dmsimard | I have no idea what to do for the home page/dashboard | 14:06 |
| dmsimard | but you gave me the idea that four cards at the top of the dashboard could be a good fit at the top of the dashboard summary (hosts, plays, tasks, task results, duration) | 14:07 |
| *** dotplus_ is now known as dotplus | 14:13 | |
| dmsimard | larsks: http://logs.openstack.org/76/330576/1/check/gate-ara-integration-centos-7/0105f5f/logs/build/ | 14:31 |
| * larsks looks... | 14:32 | |
| larsks | Kill the hosts count! With fire! | 14:32 |
| dmsimard | it's a placeholder lol | 14:33 |
| dmsimard | it's to help brainstorming ! | 14:33 |
| larsks | I'm just not sure that anything but "number of playbooks" helps at the global level. E.g., I'm not sure "total number of tasks, ever" is a useful number. | 14:33 |
| dmsimard | yeah, I think I'm trying too hard to come up with a dashboard-ish home page | 14:34 |
| dmsimard | and there's really not a lot of dashboard-ish worthy things | 14:34 |
| larsks | You could, for the most recent N playbooks, display a summary count for hosts/tasks/etc? | 14:34 |
| larsks | And older playbooks would just be listed without that summary display... | 14:35 |
| larsks | Hmm, never mind. | 14:35 |
| larsks | I guess we list that information for everything anyway. | 14:35 |
| dmsimard | yeah | 14:35 |
| dmsimard | I'm working on the playbook page now, drawing from the dashboard-ish approach I think it'll be better, showing you soon. | 14:36 |
| larsks | Awesome. | 14:36 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: WIP: Interface facelift https://review.openstack.org/330576 | 15:09 |
| dmsimard | larsks: ^ has playbook page rework http://i.imgur.com/Zes2X4g.png | 15:10 |
| larsks | I like it. I am not sure I like the centered headings, though; I think it makes them hard to spot. | 15:11 |
| dmsimard | I'm not sure about the start and end timestamps. I removed that table since the duration was now in the dashboard cards | 15:11 |
| larsks | I think that makes sense. | 15:11 |
| larsks | We need a better ui for filtering by file, though. | 15:12 |
| dmsimard | one thing at a time | 15:12 |
| dmsimard | :P | 15:12 |
| dmsimard | By the headings you mean like "statistics" "tasks" and such ? | 15:12 |
| larsks | I think maybe we need some javascript and a popup menu of files, so the list can be filtered dynamically on the page... | 15:12 |
| larsks | Yeah, those headings. | 15:12 |
| larsks | I keep trying to scroll down on that image... | 15:13 |
| * larsks has a hard time with *pictures* of interfaces. | 15:13 | |
| dmsimard | larsks: I played a bit with tooltips ( https://www.patternfly.org/pattern-library/widgets/#tooltip ) and popovers ( https://www.patternfly.org/pattern-library/widgets/#popover ) yesterday, there's definitely something to do with that | 15:14 |
| dmsimard | those in-window popups, modals they're called, are actually easier than I thought, too. https://www.patternfly.org/pattern-library/widgets/#modal | 15:14 |
| larsks | Cool. | 15:14 |
| dmsimard | larsks: http://i.imgur.com/LLJ3Jm8.png better ? bold or no bold for the headers ? | 15:17 |
| larsks | I like that better. | 15:18 |
| larsks | Maybe the same thing for the playbook heading as well? It looks weird with that centered and everything else not... | 15:18 |
| larsks | I know you like you're centering :) | 15:18 |
| larsks | *your | 15:18 |
| larsks | fingers. | 15:19 |
| dmsimard | lol | 15:19 |
| dmsimard | yeah sure I don't mind | 15:19 |
| dmsimard | okay, I'll try and come up with the same feel for the other pages | 15:24 |
| *** openstackgerrit has quit IRC | 15:34 | |
| *** openstackgerrit has joined #ara | 15:34 | |
| *** myoung is now known as myoung|biab | 16:12 | |
| *** myoung|biab has quit IRC | 16:17 | |
| dmsimard | larsks: fyi as part of the interface lift I'm fixing a bug I found that was introduced when we added the file model | 16:54 |
| dmsimard | file in the tables was often blank, that's because instead of task.path, it is now file.task.path | 16:55 |
| dmsimard | almost ready to send another patchset in. | 16:56 |
| dmsimard | brb | 16:56 |
| dmsimard | larsks: I still don't know what to do with the home page though | 17:24 |
| dmsimard | why is this so hard? :p | 17:24 |
| larsks | Redirect to most recently playbook? :) | 17:24 |
| dmsimard | not a bad idea | 17:24 |
| dmsimard | I'll leave that out of scope for the current commit | 17:25 |
| dmsimard | and leave the home page as-is | 17:25 |
| larsks | Sounds fair. | 17:25 |
| dmsimard | i.e, scrap the dashboard and put back the explanations and stuff. | 17:25 |
| larsks | Maybe keep the list of playbooks? | 17:26 |
| dmsimard | I guess | 17:27 |
| dmsimard | larsks: could do something like this for files: https://www.patternfly.org/pattern-library/widgets/#treegrid-table | 17:33 |
| dmsimard | (out of scope of current commit, though) :P | 17:33 |
| larsks | Sure, yeah, that might be worth trying out. | 17:33 |
| *** myoung|biab has joined #ara | 17:53 | |
| *** myoung|biab is now known as myoung | 17:54 | |
| dmsimard | Oh. I have an interesting middle ground for the file list. You'll like it. | 18:05 |
| dmsimard | haha, oh shité | 18:08 |
| dmsimard | shit* | 18:08 |
| dmsimard | sorry | 18:08 |
| dmsimard | stupidly excited | 18:08 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: WIP: Interface facelift https://review.openstack.org/330576 | 18:10 |
| dmsimard | come on jenkins, build it BUILD IT! | 18:10 |
| dmsimard | larsks: IT'S ALIVE | 18:16 |
| dmsimard | before: http://logs.openstack.org/56/329256/2/gate/gate-ara-integration-centos-7/d099746/logs/build/ | 18:16 |
| * larsks runs and hides | 18:16 | |
| dmsimard | after: http://logs.openstack.org/76/330576/3/check/gate-ara-integration-centos-7/9b44719/logs/build/ | 18:16 |
| dmsimard | don't look at the dashboard, I didn't touch it | 18:16 |
| dmsimard | the rest is awesome though | 18:16 |
| dmsimard | surprise for you in the file list. | 18:16 |
| larsks | I am looking at http://logs.openstack.org/76/330576/3/check/gate-ara-integration-centos-7/9b44719/logs/build/playbook/0b4eb32b-6788-4460-9d04-9a7b0d318f93/index.html and the task list looks the same w/r/t files? Or are you referring to somewhere else? | 18:17 |
| dmsimard | http://logs.openstack.org/76/330576/3/check/gate-ara-integration-centos-7/9b44719/logs/build/playbook/62eab1b1-ee60-45bd-bb02-d1d826f5aca2/file/index.html | 18:17 |
| dmsimard | "view file" | 18:17 |
| larsks | Ah, on that page. | 18:17 |
| dmsimard | Doesn't work for the playbook tho. Not sure yet why, just noticed | 18:18 |
| larsks | I get a popup window with empty content :( | 18:18 |
| dmsimard | check the tasks, not the playbook file | 18:18 |
| dmsimard | playbook file looks buffy | 18:18 |
| dmsimard | buggy* | 18:18 |
| larsks | I don't think we want to display that in a popup. Or rather, maybe we do, but we want to make sure that we can easily generate urls to *particular lines*. | 18:18 |
| larsks | So that those can be emailed/posted in irc/etc. | 18:18 |
| dmsimard | yeah, this is just a transition implementation | 18:19 |
| dmsimard | because we have the content but no UI for it yet | 18:19 |
| larsks | I think it is better if "view file" goes to a separate page, rather than using a popup. | 18:19 |
| larsks | And we should include a link both to "pretty" content with line numbers as well as "raw" content. | 18:19 |
| larsks | (possibly by having a "raw" or "download" link on the view file page) | 18:19 |
| larsks | The playbook view looks nice! | 18:20 |
| dmsimard | larsks: you okay to settle with that file list view for the time being ? making the file UI is out of scope of this :( | 18:20 |
| dmsimard | I just added something that was better than a table with one column | 18:20 |
| larsks | I think either (a) drop the "view file" completely, or (b) at least have it go to a separate page instead of using a popup. | 18:21 |
| larsks | Nobody likes popups. | 18:21 |
| larsks | We don't have to do the line numbering et al right now. | 18:22 |
| dmsimard | yeah okay I'll drop it entirely from the review | 18:22 |
| dmsimard | I don't want to touch the view controllers at all for this patch | 18:22 |
| dmsimard | or the least possible | 18:22 |
| dmsimard | agalante: so, before: http://logs.openstack.org/56/329256/2/gate/gate-ara-integration-centos-7/d099746/logs/build/ and after: http://logs.openstack.org/76/330576/3/check/gate-ara-integration-centos-7/9b44719/logs/build/ | 18:23 |
| dmsimard | er, wrong channel | 18:23 |
| dmsimard | larsks: hm, the playbook doesn't have a content id | 18:27 |
| dmsimard | that's why it came out blank | 18:27 |
| dmsimard | http://paste.openstack.org/show/516713/ | 18:28 |
| larsks | Right. We only populate content from tasks. | 18:28 |
| dmsimard | would need to do it on playbook start I guess | 18:28 |
| dmsimard | I'll create an issue so I don't forget | 18:29 |
| dmsimard | which reminds me we need to migrate away from that .. | 18:29 |
| larsks | Away from....? Oh, the issues. Yeah. | 18:31 |
| larsks | So, I don't know that we need to collect content on playbook start. We get everything via log_task, including the list of files. | 18:31 |
| larsks | So if the "view file" link only appears on the "list of files" page, it shouldn't be an issue ever. | 18:31 |
| larsks | Oh wait, I see the bug. | 18:36 |
| openstackgerrit | Lars Kellogg-Stedman proposed openstack/ara: ensure we collect main playbook content https://review.openstack.org/330747 | 18:54 |
| larsks | Fix for #108 ^^^^ | 18:54 |
| dmsimard | lgtm | 19:00 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Interface improvements and revamp https://review.openstack.org/330576 | 19:21 |
| dmsimard | larsks: I'm really sorry about all thsoe font files | 19:23 |
| dmsimard | It's hard to tell which is used and which is not | 19:23 |
| dmsimard | I *guess* I could remove relatively safely the .eot and .svg | 19:24 |
| larsks | I wish those could be installable external dependencies instead of included in our project. | 19:24 |
| larsks | I don't know what the options are for that, though. | 19:25 |
| dmsimard | yeah it's installable through npm nodejs crap | 19:25 |
| larsks | Ugh, yeah, let's not make npm a requirement... :( | 19:25 |
| dmsimard | ^ removed the files we don't need for sure | 19:25 |
| dmsimard | er | 19:25 |
| dmsimard | openstackgerrit ? | 19:25 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Interface improvements and revamp https://review.openstack.org/330576 | 19:26 |
| dmsimard | brb | 19:26 |
| dmsimard | larsks: https://review.openstack.org/#/c/330576/ ready for review | 20:08 |
| *** openstackstatus has joined #ara | 20:17 | |
| *** ChanServ sets mode: +v openstackstatus | 20:17 | |
| larsks | Can we merge the fix for 108 and rebase? That will make my life easier testing things locally. | 20:26 |
| openstackgerrit | Lars Kellogg-Stedman proposed openstack/ara: Interface improvements and revamp https://review.openstack.org/330576 | 20:27 |
| larsks | I just rebased it. So no worries. | 20:27 |
| dmsimard | larsks: sure | 20:27 |
| openstackgerrit | Merged openstack/ara: ensure we collect main playbook content https://review.openstack.org/330747 | 20:44 |
| dmsimard | larsks: if you're mostly okay with that review, I'm going to start working on the next pieces (file ui, and what else did we mention6) | 20:58 |
| dmsimard | I guess we could move the file list inside the playbook summary page | 21:00 |
| dmsimard | and do away with the page with just the file list in it | 21:00 |
| dmsimard | this page: http://logs.openstack.org/76/330576/6/check/gate-ara-integration-ubuntu-trusty/6edcb0a/logs/build/playbook/8e6443c7-80bf-4e2b-83b7-19fcfcd4ca49/index.html | 21:01 |
| dmsimard | or make the file path/lineno clickable, perhaps | 21:01 |
| dmsimard | I think making the file path and lineno clickable makes sense. | 21:02 |
| larsks | dmsimard: I think we should remove the "file" column and use that widget you were pointing at earlier. | 21:13 |
| dmsimard | larsks: I guess I removed some files I should've kept, seeing a lot of those: http://paste.openstack.org/show/516727/ | 21:14 |
| dmsimard | larsks: which widget ? the tree-ish one ? | 21:14 |
| dmsimard | the file/lineno column is relevant to the tasks table though, I think, it tells you where's that task from | 21:15 |
| larsks | The treegrid-table widget. | 21:20 |
| larsks | You would keep the "line" column. | 21:20 |
| larsks | Or...hmm, we would still need to display the filename somewhere, but the widget is a little different than I had remembered. | 21:20 |
| dmsimard | let me see if I can come up with something convincing | 21:21 |
| larsks | It would be nice to display the file only once per file for the first task in the file, and have everything below that be collapsible. | 21:21 |
| larsks | And the "line" column would link to the appropriate file + line. | 21:21 |
| dmsimard | well there's that: http://i.imgur.com/xaHbSWK.png | 21:40 |
| dmsimard | Clickable lines, though, haven't found how. I'll leave that for another commit to at least get a minimal UI for that in | 21:48 |
| dmsimard | sometimes I'm stuck on the stupidest things | 22:05 |
| dmsimard | god damn I hate css and js | 22:05 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
