| dmsimard | just thought of something.. I'll try to squeeze ara into regular jobs now that they're zuul/ansible driven for fun | 00:45 |
|---|---|---|
| larsks | Stop centering things! :) | 00:49 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Implement file content UI https://review.openstack.org/330834 | 01:03 |
| dmsimard | lol bikeshedding! :P | 01:05 |
| dmsimard | tell me where I'll fix it | 01:05 |
| dmsimard | oh, you meant the file contents ? | 01:05 |
| larsks | Yeah :) | 01:05 |
| dmsimard | yeah ^ I'll fix that review, just thought of some more stuff anyway | 01:06 |
| larsks | I will take a closer look at things tomorrow. | 01:06 |
| dmsimard | sure | 01:07 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Interface improvements and revamp https://review.openstack.org/330576 | 01:34 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Implement file content UI https://review.openstack.org/330834 | 01:39 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Implement file content UI https://review.openstack.org/330834 | 01:41 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Can Zuul use ARA ? https://review.openstack.org/330847 | 02:01 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Can Zuul use ARA ? https://review.openstack.org/330847 | 02:09 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Can Zuul use ARA ? https://review.openstack.org/330847 | 02:24 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Test generate command from within playbook https://review.openstack.org/330866 | 03:26 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Test generate command from within playbook https://review.openstack.org/330866 | 03:33 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Give some level of freedom over the Ansible version https://review.openstack.org/330873 | 03:45 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Test generate command from within playbook https://review.openstack.org/330866 | 03:48 |
| dmsimard | larsks: fyi, for fun and giggles: https://review.openstack.org/#/c/330874/ | 03:57 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Give some level of freedom over the Ansible version https://review.openstack.org/330873 | 03:58 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Test generate command from within playbook https://review.openstack.org/330866 | 04:03 |
| *** jmccrory has quit IRC | 08:42 | |
| *** jmccrory has joined #ara | 08:43 | |
| *** openstackgerrit has quit IRC | 09:18 | |
| *** openstackgerrit has joined #ara | 09:18 | |
| *** openstackgerrit has quit IRC | 10:03 | |
| *** openstackgerrit has joined #ara | 10:03 | |
| *** myoung is now known as myoung|afk | 10:32 | |
| openstackgerrit | Merged openstack/ara: Give some level of freedom over the Ansible version https://review.openstack.org/330873 | 13:00 |
| *** myoung|afk is now known as myoung | 13:28 | |
| *** myoung is now known as myoung|biab | 15:09 | |
| *** myoung|biab is now known as myoung | 16:01 | |
| -openstackstatus- NOTICE: zuul was restarted for a software upgrade; events between 16:08 and 16:30 were missed, please recheck any changes uploaded during that time | 16:32 | |
| dmsimard | larsks: clickable summary stats: yes | 19:59 |
| dmsimard | <h2>'s are definitely much much smaller than a <h1><strong> | 19:59 |
| dmsimard | They were originally h2's and I moved them up to h1+strong | 20:00 |
| dmsimard | can you try doing a local html edit (inspect element) and see what you think ? | 20:00 |
| dmsimard | I have no strong opinion, I just thought it was a bit small | 20:00 |
| dmsimard | List of tasks in a file: good idea | 20:01 |
| dmsimard | I don't know why I'm replying here instead of in-review | 20:01 |
| dmsimard | T_T | 20:01 |
| dmsimard | tgif | 20:01 |
| dmsimard | larsks: what do you think about http://fontawesome.io/icon/file-code-o/ for the icon ? | 20:10 |
| larsks | Don't change heading levels to get different sizes! That's what css is for. Heading levels are semantic, not for display. | 20:12 |
| larsks | I looked some icons like that, but it was too much "html source" for me...I ws looking for a more generic "text" icon of some sort. Maybe http://fontawesome.io/icon/file-text/? | 20:13 |
| larsks | http://fontawesome.io/icon/file-text-o/ | 20:13 |
| larsks | dmsimard: ^^^ | 20:13 |
| dmsimard | sure | 20:14 |
| dmsimard | also, agreed about sizes | 20:14 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Interface improvements and revamp https://review.openstack.org/330576 | 20:27 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Implement file content UI https://review.openstack.org/330834 | 20:37 |
| dmsimard | larsks: thanks for the feedback <3 | 20:37 |
| larsks | Sure :) | 20:38 |
| dmsimard | larsks: The UI is in a decent state with those two reviews. What's the other pain points ? | 20:38 |
| dmsimard | I'd like to be able to cut a release soon. | 20:38 |
| dmsimard | We could probably clean up dead host code/templates and fix the tests relative to those | 20:39 |
| larsks | I think we need to support linking directly to specific lines for the file viewing to really be useful. I'd like to see that before the next release. | 20:39 |
| dmsimard | Tried to look for a lib that'd do it, didn't find anything. I didn't look very hard, though. | 20:40 |
| dmsimard | I thought about doing it "manually" but settled for that google lib | 20:41 |
| larsks | There's something funny about the ui that I just noticed: in the upper left, there is a "hamburger" widget, that usually means that clicking on it will result in a popup menu. But it doesn't seem to do anything. | 20:41 |
| larsks | s/popup/collapse-expand/ | 20:41 |
| dmsimard | larsks: it collapses the menu to a smaller form | 20:41 |
| dmsimard | at least here it does | 20:41 |
| dmsimard | it expands and collapses the menu, when collapsed only the icons show | 20:42 |
| larsks | I'm looking at the static ui @ http://logs.openstack.org/34/330834/3/check/gate-ara-integration-centos-7/0df690f/logs/build/playbook/ac2e5a6b-1778-4411-bb22-97b49af1dbb7/index.html and it does not. | 20:42 |
| dmsimard | hm, probably something broke | 20:42 |
| dmsimard | it used to work | 20:42 |
| dmsimard | checking | 20:42 |
| larsks | I think we need to get those stats at the top of the playbook page to be clickable. | 20:42 |
| dmsimard | yeah, me too | 20:43 |
| dmsimard | not just those | 20:43 |
| dmsimard | like, in the task you have the file at the top, the lineno, etc. | 20:43 |
| larsks | Right. | 20:43 |
| dmsimard | wanted to land that rework before putting more work into it, otherwise it'd never merge :p | 20:44 |
| dmsimard | wonder why the hamburger stopped working | 20:44 |
| dmsimard | odd | 20:44 |
| dmsimard | oh, I think I know. | 20:46 |
| dmsimard | yup | 20:46 |
| dmsimard | there's a javascript error because there's nothing in some pages to prettyprint | 20:46 |
| dmsimard | and that prevents the rest of the javascript stuff to load | 20:47 |
| dmsimard | I'll defer the prettyprint loading to just the code view page | 20:47 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Implement file content UI https://review.openstack.org/330834 | 20:48 |
| dmsimard | fixed ^ | 20:49 |
| dmsimard | good catch. | 20:51 |
| *** myoung is now known as myoung|afk | 21:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!