| opendevreview | Dawud proposed openstack/cloudkitty master: Remove set_state function and its references https://review.opendev.org/c/openstack/cloudkitty/+/927501 | 07:16 |
|---|---|---|
| opendevreview | Merged openstack/cloudkitty-dashboard master: Bump hacking https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/929950 | 10:23 |
| opendevreview | Merged openstack/python-cloudkittyclient master: Bump hacking https://review.opendev.org/c/openstack/python-cloudkittyclient/+/929922 | 10:34 |
| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
| opendevmeet | Meeting started Mon Oct 14 14:00:15 2024 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Hello guys! | 14:00 |
| rafaelweingartner | Roll count | 14:00 |
| priteau | o/ | 14:01 |
| priteau | Hello Rafael | 14:01 |
| mattcrees | Hello o/ | 14:01 |
| rafaelweingartner | hey guys! | 14:02 |
| rafaelweingartner | #topic vPTG meeting | 14:03 |
| rafaelweingartner | If you did not register yet, please do register at http://ptg.openinfra.dev/ | 14:03 |
| rafaelweingartner | The schedule is not open for us to select, yet, right? | 14:04 |
| priteau | It has been open for some time now | 14:04 |
| priteau | https://ptg.opendev.org/ptg.html | 14:04 |
| priteau | We can book time on #openinfra-events | 14:05 |
| rafaelweingartner | can we book monday? | 14:06 |
| priteau | Of course | 14:06 |
| rafaelweingartner | I booked three slots, just in case | 14:07 |
| priteau | Can we start from 1400 UTC? | 14:08 |
| rafaelweingartner | sure | 14:08 |
| rafaelweingartner | I will update then | 14:08 |
| rafaelweingartner | #cloudkitty unbook cactus-MonB1 | 14:08 |
| priteau | Thanks | 14:13 |
| rafaelweingartner | #topic Taget reviews | 14:16 |
| rafaelweingartner | #topic Python 3.12 unit test failures | 14:16 |
| rafaelweingartner | I guess we will need to update the tests, right? | 14:16 |
| rafaelweingartner | The issue is related with this patch: #link https://review.opendev.org/c/openstack/cloudkitty/+/915479 | 14:16 |
| priteau | For some reason the test failure that was random on Python 3.12 seems to be much more common now | 14:17 |
| opendevreview | James Page proposed openstack/cloudkitty master: Misc fixes for Python 3.12 compatibility https://review.opendev.org/c/openstack/cloudkitty/+/915479 | 14:17 |
| rafaelweingartner | yes, I am seeing it | 14:17 |
| rafaelweingartner | but, I guess we should not change the API, but rather the client, right? | 14:18 |
| rafaelweingartner | for instance, using round on the client side, and then we leave the api to return the complete result | 14:18 |
| priteau | Do we know if it is the result sent back by the API that changed in 3.12? | 14:21 |
| priteau | I would assume so, given it used to work with assertEqual | 14:21 |
| rafaelweingartner | It seems that the precision in Python has changed | 14:22 |
| rafaelweingartner | and not the API process itself | 14:22 |
| priteau | But rounding just at 3 digits is a big change | 14:22 |
| rafaelweingartner | exactly | 14:22 |
| rafaelweingartner | that is why I mean saying not to round in the API | 14:22 |
| rafaelweingartner | we can just fix the client | 14:22 |
| rafaelweingartner | by client here, I mean the test | 14:23 |
| priteau | Well, the unit test rather than the client? | 14:26 |
| rafaelweingartner | exactly | 14:26 |
| rafaelweingartner | the "thing" consuming the API | 14:26 |
| rafaelweingartner | which is the test, and it consumes the API unsing the cloudkitty client. However, the outptu is received form the CLI, and processed (validated) in the test code | 14:27 |
| priteau | Let's continue discussion on the patch itself once Zuul has finished checking | 14:29 |
| rafaelweingartner | That was my question there some months ago: https://review.opendev.org/c/openstack/cloudkitty/+/915479/comments/ea69b564_4189d0c2 | 14:31 |
| priteau | I know, but it looks like the author is inactivate | 14:32 |
| priteau | inactive | 14:32 |
| rafaelweingartner | yes =) | 14:32 |
| rafaelweingartner | but we can discuss there | 14:32 |
| rafaelweingartner | Moving on | 14:35 |
| rafaelweingartner | #topic Core reviewer team | 14:35 |
| rafaelweingartner | We sent the email to invite Matt | 14:36 |
| rafaelweingartner | I guess there is nothing against it | 14:36 |
| rafaelweingartner | so, I guess we will be adding him to the team | 14:36 |
| rafaelweingartner | priteau: do you know the process from this point? | 14:36 |
| priteau | On Gerrit, go to Browse > Groups, search for cloudkitty-core, click on Members | 14:37 |
| priteau | You will be able to add Matt there. | 14:37 |
| rafaelweingartner | done! | 14:39 |
| rafaelweingartner | matt can you test it? | 14:39 |
| mattcrees | Sweet, yes I can now see +2 powers in Gerrit :) | 14:39 |
| rafaelweingartner | =) | 14:40 |
| priteau | Should we remove Mariusz too? | 14:40 |
| rafaelweingartner | I do not know | 14:40 |
| rafaelweingartner | maybe wait some more mnths before removing him? | 14:40 |
| priteau | He said he would be inactive | 14:42 |
| rafaelweingartner | Ok | 14:42 |
| rafaelweingartner | I can remove him then | 14:42 |
| rafaelweingartner | done | 14:42 |
| rafaelweingartner | besides these topics. Do you guys have something els? | 14:45 |
| priteau | Just sharing that we should add topics to the PTG Etherpad: https://etherpad.opendev.org/p/oct2024-ptg-cloudkitty | 14:46 |
| rafaelweingartner | yes, I know | 14:47 |
| rafaelweingartner | I will try to review the previous one, and see what we want to do next | 14:47 |
| rafaelweingartner | your additions are welcome as well :) | 14:47 |
| priteau | Also there are some simple patches to review | 14:48 |
| priteau | https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/932265 | 14:48 |
| priteau | https://review.opendev.org/c/openstack/python-cloudkittyclient/+/931181 | 14:49 |
| rafaelweingartner | thanks! | 14:51 |
| priteau | https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/925736 | 14:52 |
| priteau | There will be more once we fix the py3.12 issues | 14:54 |
| rafaelweingartner | yes | 14:54 |
| opendevreview | Merged openstack/cloudkitty-dashboard master: tox: Drop envdir https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/932265 | 14:56 |
| rafaelweingartner | I guess that is all for today then | 14:57 |
| priteau | All good | 14:57 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 14:57 |
| mattcrees | Cheers | 14:57 |
| rafaelweingartner | #endmeeting | 14:57 |
| opendevmeet | Meeting ended Mon Oct 14 14:57:48 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:57 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-10-14-14.00.html | 14:57 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-10-14-14.00.txt | 14:57 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-10-14-14.00.log.html | 14:57 |
| opendevreview | Merged openstack/python-cloudkittyclient master: Replace distutils https://review.opendev.org/c/openstack/python-cloudkittyclient/+/931181 | 15:18 |
| opendevreview | Merged openstack/cloudkitty-tempest-plugin master: Remove stable/zed job https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/925736 | 15:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!