| *** VW has joined #craton | 00:41 | |
| *** VW has quit IRC | 00:46 | |
| *** Syed__ has quit IRC | 01:18 | |
| *** valw_ has quit IRC | 01:25 | |
| *** valw has joined #craton | 01:26 | |
| *** Mudpuppy has quit IRC | 02:36 | |
| *** Mudpuppy has joined #craton | 02:37 | |
| *** Mudpuppy has quit IRC | 02:41 | |
| *** valw has quit IRC | 04:57 | |
| *** ahsa518 has joined #craton | 05:04 | |
| *** Syed__ has joined #craton | 05:13 | |
| *** VW has joined #craton | 05:27 | |
| *** VW has quit IRC | 05:32 | |
| *** Mudpuppy has joined #craton | 07:09 | |
| *** Mudpuppy has quit IRC | 07:14 | |
| *** ahsa518 has quit IRC | 07:15 | |
| *** klindgren has joined #craton | 07:34 | |
| *** klindgren_ has quit IRC | 07:34 | |
| *** klindgren_ has joined #craton | 07:45 | |
| *** klindgren has quit IRC | 07:46 | |
| *** Syed__ has quit IRC | 08:07 | |
| sulo | o/ | 10:01 |
|---|---|---|
| *** VW has joined #craton | 10:27 | |
| *** VW has quit IRC | 10:32 | |
| sigmavirus | workflows code name "hot taters" | 13:46 |
| *** valw has joined #craton | 13:59 | |
| *** valw_ has joined #craton | 14:02 | |
| *** valw has quit IRC | 14:04 | |
| *** VW has joined #craton | 14:28 | |
| *** Syed__ has joined #craton | 15:14 | |
| *** VW_ has joined #craton | 15:19 | |
| *** VW_ has quit IRC | 15:20 | |
| *** VW_ has joined #craton | 15:20 | |
| *** VW_ has quit IRC | 15:20 | |
| *** VW_ has joined #craton | 15:21 | |
| *** VW has quit IRC | 15:21 | |
| *** Mudpuppy has joined #craton | 15:24 | |
| jimbaker | sigmavirus, don't forget about https://review.openstack.org/#/c/401438/ - just a small minor doc update and we can get that in | 15:26 |
| *** jovon has joined #craton | 15:32 | |
| *** Mudpuppy_ has joined #craton | 15:50 | |
| sigmavirus | sorry, been distracted with other things (HAProxy/TLS nonsense) | 15:50 |
| *** Mudpuppy has quit IRC | 15:53 | |
| *** VW has joined #craton | 15:59 | |
| *** VW has quit IRC | 15:59 | |
| *** VW__ has joined #craton | 15:59 | |
| *** VW_ has quit IRC | 16:02 | |
| *** valw_ is now known as valw | 16:50 | |
| *** Mudpuppy_ is now known as Mudpuppy | 16:50 | |
| jimbaker | jovon, palendae, sigmavirus, sulo, Syed__, tojuvone - craton client/ecosystem meeting in 2 minutes on vidyo | 16:58 |
| jimbaker | we also plan to discuss rbac, based on yesterday's irc meeting | 16:58 |
| palendae | Will listen in | 16:59 |
| palendae | https://review.openstack.org/#/q/project:openstack/openstack-ansible+topic:%5Einventory.*+status:open | 17:07 |
| palendae | https://etherpad.openstack.org/p/craton_osa is the etherpad I remember | 17:11 |
| sulo | ok i guess .. vidyo does not like me today | 17:32 |
| *** VW__ has quit IRC | 17:36 | |
| *** VW has joined #craton | 17:43 | |
| sigmavirus | sulo: no, it just likes your productivity today | 17:44 |
| sigmavirus | ;P | 17:44 |
| *** VW_ has joined #craton | 17:45 | |
| sulo | heh | 17:45 |
| jimbaker | http://docs.sqlalchemy.org/en/latest/orm/query.html#sqlalchemy.orm.query.Query.with_entities | 17:46 |
| *** VW has quit IRC | 17:47 | |
| jimbaker | sulo, right, you got to miss me drone on about rbac and secret storage | 18:02 |
| jimbaker | so certainly a productivity boost :) | 18:02 |
| sulo | :( those are my favourite topics | 18:04 |
| sulo | tojuvone: you should take https://bugs.launchpad.net/craton/+bug/1643356 from me | 18:13 |
| openstack | Launchpad bug 1643356 in craton "API: inconsistent network endpoint names" [Low,Confirmed] - Assigned to Sulochan Acharya (sulochan-acharya) | 18:13 |
| sulo | afk | 18:13 |
| *** VW_ has quit IRC | 18:23 | |
| *** VW has joined #craton | 18:32 | |
| *** VW has quit IRC | 20:44 | |
| *** jovon has quit IRC | 20:48 | |
| *** VW has joined #craton | 20:53 | |
| *** david-lyle has quit IRC | 20:55 | |
| *** VW has quit IRC | 20:59 | |
| *** VW has joined #craton | 21:01 | |
| Syed__ | Hi | 21:05 |
| Syed__ | i need some help with https://gist.github.com/ahsan518/16dabafe8677cf262eebd061066715d9 | 21:05 |
| Syed__ | so its a basic test case for net devices, but i am running into an error stating no such thing as hostname, where as i edited fake_resources.py already | 21:06 |
| Syed__ | jimbaker: sulo any thoughts would be appreciated | 21:06 |
| git-harry | Syed__: '/v1/netdevices?region_id=1' looks wrong if you're trying to get by ID. | 21:12 |
| Syed__ | so i tried using /v1/netdevices/1 it gave me this error : | 21:13 |
| Syed__ | https://www.irccloud.com/pastebin/DMZQOHsv/ | 21:13 |
| Syed__ | but i agree this should be simple /v1/netdevices/1 when i try to get that from region_id since the schema endpoints has already been updated | 21:14 |
| Syed__ | so basically it says craton.api.v1.resources.inventory.networks: ERROR: Error during NetDeviceById.get: 'NetDevice' object has no attribute 'resolved'\ | 21:14 |
| git-harry | Syed__: it looks like the fake object is missing a resolved attribute | 21:17 |
| git-harry | Syed__: https://github.com/openstack/craton/blob/master/craton/api/v1/resources/inventory/networks.py#L124 | 21:18 |
| jimbaker | yeah, that would do it. real objects derived from Device will have this attribute | 21:22 |
| jimbaker | Syed__, are the actions of you unit tests working the same against an actual running instance? or different as hypothesized here | 21:23 |
| Syed__ | i am totally lost by the last sentence :s i am sorry | 21:25 |
| jimbaker | Syed__, so one thing that's really important in unit testing - especially when mocks or other fake setups are involved - is to properly prepare the system under test such it is like a real system | 21:26 |
| jimbaker | to the extent being tested | 21:27 |
| Syed__ | hmm .. | 21:27 |
| Syed__ | but isn't the data being fetched is from fake_resources in this case | 21:27 |
| jimbaker | otherwise, the test can have no correlation whatsoever to what we think is being tested | 21:27 |
| Syed__ | so however the data is in fake resources, it goes and compare to that ? | 21:27 |
| jimbaker | Syed__, i think what git-harry is suggesting - and i have not confirmed, just asking further - is that it appears the fake resource may not be setup properly | 21:28 |
| Syed__ | hmm ... | 21:28 |
| jimbaker | one simple smoke test you can just try is to simply test the system from the rest api | 21:28 |
| Syed__ | let me look into it | 21:28 |
| jimbaker | as if you were running the same sequence of actions against it as the unit test | 21:28 |
| jimbaker | one would hope for being the same | 21:28 |
| jimbaker | however... not always the case! | 21:28 |
| jimbaker | so when i'm testing things... i try it out several different ways. in fact, that's how i develop, because i usually do my early code in the python console, then extract to a test script, then to actual classes with tests, ... | 21:30 |
| jimbaker | so at each step, i probably have a good idea of what is working, and why not. otherwise, it's easy to develop a component that actually does nothing that we expect it to do :) | 21:31 |
| jimbaker | anyway, there are several approaches. but the key thing is to treat tests as just one more part of what you're doing to verify things - each test only tells you a little bit. but collectively, if independent, you can build up confidence in the overall system | 21:32 |
| jimbaker | consider it some guiding philosophy :) | 21:32 |
| jimbaker | biab | 21:33 |
| *** VW has quit IRC | 21:43 | |
| *** VW has joined #craton | 21:46 | |
| *** jovon has joined #craton | 22:13 | |
| *** mdorman_ has quit IRC | 22:23 | |
| *** mdorman has joined #craton | 22:23 | |
| *** david-lyle has joined #craton | 22:24 | |
| *** VW_ has joined #craton | 22:28 | |
| *** VW has quit IRC | 22:32 | |
| *** VW_ has quit IRC | 22:32 | |
| *** david-lyle has quit IRC | 22:41 | |
| *** harlowja has quit IRC | 22:43 | |
| *** harlowja has joined #craton | 22:43 | |
| *** VW has joined #craton | 22:59 | |
| *** VW has quit IRC | 23:02 | |
| *** VW has joined #craton | 23:02 | |
| *** VW has quit IRC | 23:28 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!