Wednesday, 2016-12-07

« Tuesday, 2016-12-06 Index Thursday, 2016-12-08 »
*** Mudpuppy has quit IRC00:14
*** Mudpuppy has joined #craton00:16
*** jovon has quit IRC00:28
*** VW has joined #craton01:03
*** Mudpuppy has quit IRC01:07
*** Mudpuppy_ has joined #craton01:07
*** Syed__ has quit IRC01:27
*** david-lyle has joined #craton01:33
*** VW has quit IRC01:33
*** valw has quit IRC02:00
*** valw has joined #craton02:00
*** VW has joined #craton03:33
*** VW has quit IRC03:35
*** VW has joined #craton03:35
*** klindgren_ has quit IRC03:43
*** klindgren_ has joined #craton03:44
*** VW has quit IRC04:11
*** palendae has quit IRC05:14
*** b3rn-n00dl3s_ has joined #craton05:15
*** ChanServ sets mode: +o b3rn-n00dl3s_05:15
*** sballe_ has quit IRC05:15
tojuvonesulo: Yes, done05:15
*** b3rn-n00dl3s has quit IRC05:16
*** b3rn-n00dl3s_ is now known as b3rn-n00dl3s05:16
*** sballe_ has joined #craton05:22
*** VW has joined #craton06:11
*** VW has quit IRC06:16
*** Mudpuppy_ has quit IRC06:23
*** Mudpuppy has joined #craton06:23
*** Mudpuppy has quit IRC06:28
*** valw_ has joined #craton06:29
*** valw has quit IRC06:32
*** Mudpuppy has joined #craton06:54
*** Mudpuppy has quit IRC06:58
*** wirehead_ has quit IRC08:03
*** wirehead_ has joined #craton08:05
sulotojuvone: also for alembic we havent been adding new migration per change yet .. so you can simply change https://github.com/openstack/craton/blob/master/craton/db/sqlalchemy/alembic/versions/ffdc1a500db1_craton_inventory_init.py08:41
sulowe will be doing per change migration after the first release08:41
sulotojuvone: so for your change you can simply change the table names on that file should do the trick08:42
*** sorrison_laptop has joined #craton08:51
*** Mudpuppy has joined #craton08:55
*** Mudpuppy has quit IRC08:59
*** sorrison_laptop is now known as sorrison_09:00
git-harrysulo: https://github.com/openstack/craton/blob/master/craton/tests/functional/__init__.py#L40 prevents me from running the functional tests on my local repo - was this done intentionally? I'm going to submit a patch to change that unless there's another way to do it?09:30
*** odyssey4me_ is now known as odyssey4me09:30
sulogit-harry: roger, i think its probably useful to be able to do it against our own repos09:33
suloactually i never thought of this at all09:34
git-harrysulo: yup, and when it starts getting run against reviews it will need that as well. Okay, I'll make a review.09:34
sulogit-harry: thanks09:34
*** mancdaz has joined #craton09:37
sulogit-harry: also if you are looking to do some of the func tests  .. i have a bunch of issues in LP .. the ones i have claimed are already done (although not up for review)09:41
suloi was waiting for your endpoint change but since that is not chaing the url .. i might submit them later today09:42
git-harrysulo: I was adding a couple just to cover requests without a region_id, have you already done that?09:43
tojuvonesulo: Thanks. Then I should have working patch easily.09:43
sulogit-harry: yes, i have all the GET call for regions/cells/hosts09:43
suloeverything else is open09:44
git-harrysulo: okay, I stop doing that then :P09:44
sulotojuvone: np, wanted to save time for you there :)09:44
sulogit-harry: thx09:44
suloactually i should have change the lp bug status09:45
suloill do that now09:45
*** sorrison_ has quit IRC10:09
*** klindgren__ has joined #craton10:29
*** klindgren_ has quit IRC10:32
*** david-lyle_ has joined #craton10:35
*** david-lyle has quit IRC10:37
*** palendae has joined #craton10:47
*** palendae is now known as Guest9571910:47
*** turvey has quit IRC11:44
*** turvey has joined #craton11:51
*** Mudpuppy has joined #craton12:47
*** Mudpuppy has quit IRC12:48
*** Mudpuppy has joined #craton12:49
*** Mudpuppy has quit IRC12:53
*** VW has joined #craton13:12
*** VW has quit IRC13:16
*** valw_ has quit IRC14:33
*** Mudpuppy has joined #craton14:35
*** Mudpuppy has quit IRC14:36
*** Mudpuppy has joined #craton14:36
*** VW has joined #craton14:40
*** VW has quit IRC14:40
*** VW has joined #craton14:41
*** Syed__ has joined #craton15:07
*** valw has joined #craton15:32
Syed__sulo: are you around ?15:40
suloSyed__: yeah, whats up ?15:45
Syed__sulo: i actually am stuck in this .. Been trying to figure this out .. https://gist.github.com/ahsan518/16dabafe8677cf262eebd061066715d915:45
sulowhat am i looking at ?15:46
Syed__sulo: it gives me this error, saying NetDevice has no attribute resolved craton.api.v1.resources.inventory.networks: ERROR: Error during NetDeviceById.get: 'NetDevice' object has no attribute 'resolved'15:46
suloyeah it looks like it doesnt15:46
Syed__so i wrote a NetDevice test, to get the NetDeviceBy ID ..15:47
Syed__i edited the fake resources, in the gist i put fake resources15:47
Syed__and my test,15:47
Syed__so it should be simple enough15:47
*** valw has quit IRC15:48
Syed__self.assertEqual(resp.json["name"], fake_resources.NETDEVICE1.name)15:48
Syed__it gives key error name, whereas name is defined in fake_resources.py as well, and schema too .15:48
sulowhat does the actual json have ?15:49
suloSyed__: ^15:50
Syed__what do you mean ?15:50
suloresp.json15:50
*** jovon has joined #craton15:50
sulowhat does that look like ?15:50
*** valw has joined #craton15:52
Syed__sulo: {'message': 'Unknown Error', 'status': 500}15:52
sulowell there you go15:52
Syed__but isn't it defined in schema already15:54
*** valw has quit IRC15:54
Syed__https://github.com/openstack/craton/blob/master/craton/api/v1/schemas.py#L160815:54
sulonot sure i follow what you are asking15:56
suloyou are getting an error on that call15:56
sulo/v1/netdevices/115:57
sulois giving you an error15:57
jovonwhich direction are we planning to move with the naming convention of netdivices. will it become network_devices or net_devices?15:59
suloSyed__: also i dont see name there .. it shouldnt be there16:00
sulojovon: there is a pr up to fix that16:00
Syed__https://www.irccloud.com/pastebin/hK8hUpkK/16:00
*** Guest95719 is now known as palendae16:01
Syed__so in DefinitionNetDeviceID there is no name,, i see.16:01
suloso what you need to do is16:02
suloactaully before that16:02
sulowhen you do resp = fake_resource.SomeDevice16:03
sulowhat we are trying to do is make that someDevice look like a response back from the db16:03
sulosince you are stubing the dbapi16:03
suloso the object that is NetDevice needs to match the object that you would expect16:04
sulofrom the db16:04
sulothat resonse then is used by jsonconverter and gets filtered according to the schema16:04
suloright now .. you know its not the db part that is the problem sinceyou have stubbed it out16:04
suloso step 1. does your stub match what you'd expect on the real call16:05
sulothen what is getting though the filter16:05
sulois what you are compring against16:06
sulodoes that make sense ?16:06
Syed__perfect sense16:07
Syed__i am on it16:07
Syed__thank you sulo16:07
*** valw has joined #craton16:08
sulonp, ping back if you get stuck16:08
*** valw has quit IRC16:12
*** valw has joined #craton16:12
*** valw has quit IRC16:28
*** valw has joined #craton16:28
*** valw has quit IRC16:33
jimbakerSyed__, just to clarify on the problem you are facing - if you work with actual net devices, vs your fakes, does it work?16:49
jimbakerwant to follow up on my testing discussion with you from yesterday16:49
Syed__I got that solved yes. Now it works, thanks for checking up jimbaker16:50
jimbakerSyed__, cool16:51
*** Mudpuppy_ has joined #craton16:59
*** Mudpuppy_ has quit IRC16:59
*** Mudpuppy has quit IRC16:59
*** VW_ has joined #craton16:59
*** Mudpuppy has joined #craton16:59
*** VW has quit IRC17:02
*** valw has joined #craton17:04
*** klindgren has joined #craton17:05
*** klindgren__ has quit IRC17:08
jovonalthough it is not defined in DefinitionNetDevices, should "active" be a property of net devices?17:36
jovonim referring to modeling herehttp://craton.readthedocs.io/en/latest/cratoncli.html#craton-device-create which may be out dated17:38
jovonhttp://craton.readthedocs.io/en/latest/cratoncli.html#craton-device-create17:38
*** valw has quit IRC17:53
*** valw has joined #craton17:56
*** david-lyle_ is now known as david-lyle18:02
sulojovon: yes18:09
jovonThank you sulo18:10
*** VW_ has quit IRC18:13
*** VW has joined #craton18:14
*** VW_ has joined #craton18:17
*** VW has quit IRC18:19
*** VW_ has quit IRC18:21
*** valw has quit IRC18:49
*** valw has joined #craton18:52
*** VW has joined #craton19:09
*** VW has quit IRC19:09
*** VW has joined #craton19:09
*** VW has quit IRC19:09
*** VW has joined #craton19:10
sulohttps://review.openstack.org/#/c/355938/19:22
sulonot for merge but for early review and discussion19:23
*** valw has quit IRC19:45
*** valw has joined #craton19:50
*** VW_ has joined #craton19:53
*** VW has quit IRC19:56
*** VW_ has quit IRC19:57
*** VW has joined #craton19:59
*** VW has quit IRC20:00
*** VW_ has joined #craton20:00
*** valw has quit IRC20:00
*** VW_ has quit IRC20:02
*** VW has joined #craton20:02
*** valw has joined #craton20:08
*** valw has quit IRC20:16
*** VW has quit IRC20:21
*** VW has joined #craton20:22
*** valw has joined #craton20:29
*** valw has quit IRC20:34
Syed__sulo: you around ?20:37
*** harlowja has quit IRC20:41
*** valw has joined #craton20:57
*** valw has quit IRC21:01
*** VW has quit IRC21:20
*** valw has joined #craton21:24
*** valw has quit IRC21:28
*** valw has joined #craton21:28
*** harlowja has joined #craton21:41
*** valw has quit IRC21:55
*** valw has joined #craton22:08
*** jovon has quit IRC22:08
*** Mudpuppy has quit IRC22:12
*** valw has quit IRC22:12
*** Mudpuppy has joined #craton22:12
*** Mudpuppy has quit IRC22:13
Syed__https://review.openstack.org/#/c/408339/122:49
Syed__ready for reviews22:49
Syed__https://review.openstack.org/#/c/40833923:03
*** harlowja has quit IRC23:16
*** valw has joined #craton23:20
« Tuesday, 2016-12-06 Index Thursday, 2016-12-08 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!