| *** tomek_adamczewsk has quit IRC | 00:06 | |
| *** tomek_adamczewsk has joined #heat | 00:06 | |
| asalkeld | stevebaker, https://dl.dropboxusercontent.com/u/2663410/2013-12-17%2011.06.04.jpg | 00:07 |
|---|---|---|
| *** brint has quit IRC | 00:08 | |
| stevebaker | kangaroo? Koala> | 00:08 |
| stevebaker | ? | 00:08 |
| asalkeld | haha | 00:08 |
| asalkeld | no just beef | 00:08 |
| *** jcru has quit IRC | 00:10 | |
| sdake_ | angus have time for a phone call? | 00:12 |
| asalkeld | sure sdake | 00:13 |
| *** tomek_adamczewsk has quit IRC | 00:26 | |
| openstackgerrit | Tim Schnell proposed a change to openstack/heat: Adds Parameter Label to HOT spec and parameter schema https://review.openstack.org/62418 | 00:34 |
| *** dims has quit IRC | 00:37 | |
| *** faramir1 has joined #heat | 00:38 | |
| *** dims has joined #heat | 00:39 | |
| tims | stevebaker if you get a change to review ^^ | 00:44 |
| tims | would love some feedback on general implementation | 00:44 |
| tims | chance* | 00:44 |
| *** pvaneck has quit IRC | 00:45 | |
| stevebaker | tims: ok, will do | 00:46 |
| tims | thanks :) | 00:46 |
| stevebaker | tims: ah, I wanted to talk to you about that one. | 00:46 |
| tims | ok | 00:46 |
| *** dims has quit IRC | 00:47 | |
| stevebaker | I'm thinking that the parameter name is the right thing to display. Having an alternative label just hides a thing that has real meaning in the stack. From a UX point of view this seems like a step back. We don't have labels for resources and outputs - I think parameters might be in the same category | 00:48 |
| stevebaker | Its entirely up to the template author to choose param names which are easy_to_understand | 00:49 |
| tims | I viewed it as a step forward from running django expressions to try and humanize the variable name | 00:51 |
| tims | I would argue that we may want to move in the direction of adding labels to things that may be interpreted into HTML at the UI level | 00:54 |
| tims | I think there is a fair amount of precedence for it | 00:54 |
| *** nosnos has joined #heat | 00:54 | |
| tims | I can imagine reasons where you may want parameter names short but labels larger and more descriptive | 00:55 |
| tims | db_port vs database_port | 00:55 |
| stevebaker | do we auto-humanize? | 00:55 |
| tims | I was just looking it up | 00:55 |
| tims | Horizon does in general | 00:55 |
| stevebaker | just checking now | 00:56 |
| stevebaker | I remember trying it and it looked terrible | 00:56 |
| tims | we are manually humanizing labels that don't come from heat | 00:57 |
| tims | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/stacks/forms.py#L177 | 00:57 |
| tims | which would look inconsistent if we aren't humanizing | 00:57 |
| tims | yeah its not super great I agree | 00:57 |
| tims | hence adding labels to heat | 00:57 |
| tims | ok at a quick glance it looks like we are passing the keynames without doing much to them | 01:00 |
| stevebaker | My issue is that someone who launches the same stack via heatclient and horizon won't recognise the parameters, we are actually hiding information that they really need (ie, the parameter name) | 01:00 |
| tims | Yeah, I get that, but I'm hoping that that user is smart enough to read the template for the parameters | 01:01 |
| tims | as opposed to the user who has no clue | 01:01 |
| tims | about anything in Heat | 01:01 |
| tims | and is just filling out the form in the UI | 01:01 |
| stevebaker | heatclient is a UI too. the prettytable responses used to humanize the column names, but again that hid vital stack information so now it just outputs the raw attribute keys | 01:02 |
| tims | I would also say that perhaps the Heatclient is due for some upgrades when it comes to prompting for parameters | 01:02 |
| tims | its a UI for a different type of user perhaps | 01:02 |
| *** dims has joined #heat | 01:02 | |
| tims | we humanize the columns in the table for Horizon for example | 01:04 |
| *** nosnos has quit IRC | 01:06 | |
| stevebaker | I think we need to punt this to be discussed by some UX people. heatclient and horizon may or may not used by different personas but I'm not aware that those personas have been defined anywhere yet | 01:06 |
| *** nosnos has joined #heat | 01:06 | |
| tims | There is precedent in humanizing parameter names and keys in all of the other project implementations that I have looked at in Horizon | 01:06 |
| openstackgerrit | Richard Lee proposed a change to openstack/heat: Add way to group exceptions in DependencyTaskGroup https://review.openstack.org/62479 | 01:06 |
| openstackgerrit | Richard Lee proposed a change to openstack/heat: Refactor Instance#_check_active https://review.openstack.org/62478 | 01:06 |
| tims | cool | 01:06 |
| tims | I can start a thread on the UX askbot | 01:06 |
| tims | ? | 01:06 |
| tims | if you are ok discussing it there | 01:07 |
| openstackgerrit | Anderson Mesquita proposed a change to openstack/heat: Check resources are in expected states https://review.openstack.org/58641 | 01:07 |
| stevebaker | tims: but in this case the thing we're humanizing is something that is in the template, not some hard-coded label. I think this is the *one* good case for leaving some mildly technical name there, because they are doing something mildly technical | 01:08 |
| stevebaker | tims: sure, point me at the askbot | 01:08 |
| tims | http://ask-openstackux.rhcloud.com/questions/ | 01:09 |
| tims | I'll write something up and post there tomorrow, its gettting late in the day for me | 01:09 |
| stevebaker | Maybe something like this would be acceptable: | 01:09 |
| stevebaker | label (name) | 01:09 |
| tims | I could be convinced of that for implementation in Horizon | 01:10 |
| tims | It's not super pretty :P | 01:10 |
| stevebaker | and dare I suggest that labels should be localizable ;) | 01:11 |
| tims | that's a good point | 01:11 |
| tims | I think that having labels is also going to be an accessibility thing | 01:11 |
| stevebaker | surely the description and helptext help here, I'm all for that | 01:12 |
| tims | it's easier for JAWS to read "Database Port" than "db_port" | 01:12 |
| sdake_ | http://money.cnn.com/2013/12/16/investing/penny-stock-trader-millionaire/index.html?hpt=hp_t3 | 01:12 |
| tims | anyway, definitely worth continuing in the UX forum | 01:13 |
| stevebaker | yup | 01:13 |
| tims | haha, nice sdake_ | 01:13 |
| tims | I'll post the link here once I get something up | 01:14 |
| tims | have a good night | 01:14 |
| sdake_ | But he lost all of that over the course of a year and decided he needed to quit gambling. So he took a shot at investing. | 01:14 |
| sdake_ | and the difference is/ | 01:14 |
| sdake_ | ? | 01:14 |
| sdake_ | oh here is the difference: | 01:15 |
| sdake_ | "I think it's mainly for people who are gamblers," said Sykes, who taught himself all about trading. "But at casinos you play with low odds. With penny stocks, there are patterns that are very predictable." | 01:15 |
| sdake_ | that cat doubled up 9 times | 01:17 |
| *** andersonvom has quit IRC | 01:18 | |
| *** andersonvom has joined #heat | 01:18 | |
| *** andersonvom1 has joined #heat | 01:19 | |
| *** andersonvom has quit IRC | 01:19 | |
| *** rpothier_ has joined #heat | 01:20 | |
| *** randallburt has quit IRC | 01:20 | |
| *** andersonvom1 has quit IRC | 01:22 | |
| *** arbylee has quit IRC | 01:22 | |
| *** brint has joined #heat | 01:22 | |
| *** arbylee has joined #heat | 01:22 | |
| *** arbylee has quit IRC | 01:27 | |
| *** IlyaE has quit IRC | 01:29 | |
| *** swygue has joined #heat | 01:42 | |
| lifeless | ugh, I wish the heat locale files were not under heat/ | 01:49 |
| lifeless | makes grepping a PITA | 01:49 |
| *** shakayumi has joined #heat | 01:51 | |
| *** AndrewMichalik has quit IRC | 01:51 | |
| *** randallburt has joined #heat | 01:52 | |
| *** jergerber has quit IRC | 01:53 | |
| *** radix_ has quit IRC | 01:58 | |
| *** nati_ueno has quit IRC | 02:01 | |
| openstackgerrit | lifeless proposed a change to openstack/heat: Add support for rebuild --preserve-ephemeral. https://review.openstack.org/62520 | 02:07 |
| lifeless | SpamapS: read it and weep ^ | 02:07 |
| *** randallburt has quit IRC | 02:08 | |
| *** arbylee has joined #heat | 02:15 | |
| *** andersonvom has joined #heat | 02:15 | |
| *** erkules_ has joined #heat | 02:18 | |
| *** erkules has quit IRC | 02:21 | |
| *** yogesh has quit IRC | 02:23 | |
| *** nati_ueno has joined #heat | 02:30 | |
| *** liang has joined #heat | 02:30 | |
| *** faramir1 has quit IRC | 02:31 | |
| lifeless | stevebaker: ping - is the separate -P foo -P bar thing in a heatclient release ? | 02:32 |
| *** brint has quit IRC | 02:33 | |
| stevebaker | lifeless: yep, at least 2 releases I think | 02:36 |
| lifeless | cool, thanks | 02:37 |
| *** swygue has quit IRC | 02:38 | |
| *** swygue has joined #heat | 02:45 | |
| openstackgerrit | Anderson Mesquita proposed a change to openstack/heat: Check resources are in expected states https://review.openstack.org/58641 | 02:47 |
| *** vkozhukalov has joined #heat | 02:48 | |
| *** SushilKM has joined #heat | 02:48 | |
| *** slong has joined #heat | 02:48 | |
| *** ccs has quit IRC | 02:51 | |
| *** faramir1 has joined #heat | 02:51 | |
| lifeless | 2013-12-17 02:51:15.637 2202 INFO migrate.versioning.api [-] 30 -> 31... | 02:51 |
| lifeless | ERROR: (OperationalError) (1005, "Can't create table 'heat.stack_lock' (errno: 150)") '\nCREATE TABLE stack_lock (\n\tstack_id VARCHAR(36) NOT NULL, \n\tcreated_at DATETIME, \n\tupdated_at DATETIME, \n\tengine_id VARCHAR(36), \n\tPRIMARY KEY (stack_id), \n\tFOREIGN KEY(stack_id) REFERENCES stack (id)\n)ENGINE=InnoDB CHARSET=utf8\n\n' () | 02:51 |
| lifeless | would you like a bug for that? | 02:51 |
| *** SushilKM has quit IRC | 02:52 | |
| *** dims has quit IRC | 02:53 | |
| lifeless | stevebaker: ^ | 02:53 |
| *** dims has joined #heat | 02:53 | |
| *** rpothier__ has joined #heat | 02:53 | |
| lifeless | stevebaker: I'm guessing a stack lock patch implies you're not doing the distributed thing we sketched out > | 02:54 |
| lifeless | ? | 02:54 |
| asalkeld | lifeless, it assumes you are not using zookeeper | 02:55 |
| lifeless | we're not, but the distributed thing we talked about didn't use zookeeper either; it was lock-free | 02:55 |
| asalkeld | aaa, yeah that is a big chunck of work not yet started | 02:56 |
| lifeless | anyhow | 02:56 |
| lifeless | what should I do about this barfing migration ? | 02:56 |
| *** rpothier_ has quit IRC | 02:56 | |
| lifeless | we were on 28, now I'm on 30 but stuck :) | 02:56 |
| asalkeld | lifeless, I am looking ... | 02:57 |
| lifeless | asalkeld: I can file a bug if you like | 02:58 |
| asalkeld | ok | 02:58 |
| lifeless | (while you poke around) | 02:58 |
| lifeless | https://bugs.launchpad.net/heat/+bug/1261605 | 02:59 |
| uvirtbot | Launchpad bug 1261605 in heat "migration 30 -> 31 (031_stack_lock) fails" [Undecided,New] | 02:59 |
| asalkeld | we really need a migration test | 02:59 |
| *** aignatov has joined #heat | 03:00 | |
| *** giulivo has quit IRC | 03:00 | |
| lifeless | asalkeld: http://stackoverflow.com/questions/16227199/mysql-errno-150 | 03:01 |
| lifeless | If you're using the InnoDB engine, the ON DELETE SET DEFAULT is your problem. Here's an excerpt from the manual: | 03:01 |
| lifeless | While SET DEFAULT is allowed by the MySQL Server, it is rejected as invalid by InnoDB. CREATE TABLE and ALTER TABLE statements using this clause are not allowed for InnoDB tables. | 03:01 |
| lifeless | hmm, no, ignore that, doesn't obviously apply | 03:02 |
| *** SushilKM has joined #heat | 03:03 | |
| asalkeld | I don't see a set default in the migrate | 03:03 |
| lifeless | right, I was just injecting random stackoverflow content | 03:04 |
| lifeless | heat wasn't entirely in the thing | 03:04 |
| lifeless | s/heat/head/ | 03:04 |
| asalkeld | https://github.com/openstack/heat/blob/master/heat/db/sqlalchemy/migrate_repo/versions/030_remove_uuidutils.py#L22 | 03:04 |
| asalkeld | could it be that? | 03:04 |
| lifeless | wait, what - primary key and foreign key - methings the schema is too clever | 03:05 |
| *** nanjj has joined #heat | 03:05 | |
| lifeless | yeah different types would do it | 03:05 |
| asalkeld | so have stack_lock_id and stack_id | 03:06 |
| lifeless | dropping the stack_id does indeed fix it | 03:06 |
| lifeless | erm the FK | 03:06 |
| lifeless | does anything use the stack_lock table yet? | 03:06 |
| asalkeld | this was backed out before because of this:( | 03:07 |
| lifeless | I think the schema is being overly clever. | 03:07 |
| lifeless | KISS: if you relate to something else, match it's type exactly. | 03:07 |
| lifeless | If you are a separate table, you get your own ID. | 03:07 |
| lifeless | What you tell users about can be different. | 03:07 |
| lifeless | so stack.id should be an autoassigned int, for instance | 03:07 |
| lifeless | stack.uuid should be a uuid | 03:08 |
| lifeless | anyhoww | 03:08 |
| lifeless | what do we do ? | 03:08 |
| asalkeld | jasond`, should fix his patch | 03:09 |
| asalkeld | I could work up a wip patch to speed things up | 03:09 |
| lifeless | asalkeld: this is in trunk... | 03:10 |
| lifeless | asalkeld: which we deploy | 03:10 |
| asalkeld | ok, let me see if I can make a quick fix/ the alternative is another revert | 03:11 |
| lifeless | asalkeld: so, this came in Nov 12 - I'm not sure why noone else has noticed | 03:11 |
| lifeless | asalkeld: or maybe git is lying to me :) | 03:11 |
| lifeless | ah no, merge of an old patch | 03:11 |
| lifeless | so, I'll revert it out of the tree I have here, to get things unbroken | 03:12 |
| lifeless | let me know if you want /need me to try a fixed version | 03:12 |
| asalkeld | k | 03:12 |
| *** faramir1 has quit IRC | 03:16 | |
| lifeless | added the patches to revert (I think!) to the bug | 03:18 |
| *** nanjj has quit IRC | 03:22 | |
| *** nanjj has joined #heat | 03:22 | |
| *** rushiagr has joined #heat | 03:23 | |
| *** shakayumi has quit IRC | 03:24 | |
| *** faramir1 has joined #heat | 03:28 | |
| *** gokrokve has quit IRC | 03:31 | |
| *** AndrewMichalik has joined #heat | 03:31 | |
| *** gokrokve has joined #heat | 03:34 | |
| *** rcleere has joined #heat | 03:35 | |
| *** gokrokve has quit IRC | 03:37 | |
| *** gokrokve has joined #heat | 03:40 | |
| *** rongze has joined #heat | 03:40 | |
| *** slong has quit IRC | 03:44 | |
| openstackgerrit | Mitsuru Kanabuchi proposed a change to openstack/heat: Implements resource types NetworkGateway https://review.openstack.org/62287 | 03:48 |
| openstackgerrit | Angus Salkeld proposed a change to openstack/heat: Fix stack_lock migration https://review.openstack.org/62534 | 03:58 |
| *** gokrokve has quit IRC | 03:58 | |
| asalkeld | lifeless, ^ | 03:58 |
| asalkeld | not heavily tested, but seems to handle "heat-manage db_sync 3{0,1}" | 03:59 |
| asalkeld | and passes tests | 03:59 |
| *** gokrokve has joined #heat | 04:00 | |
| asalkeld | lifeless, the "unique=True" is doing what I guess jasond` wanted with the primary key | 04:02 |
| *** gokrokve has quit IRC | 04:04 | |
| *** gokrokve has joined #heat | 04:05 | |
| lifeless | asalkeld: on mysql ? | 04:05 |
| asalkeld | I have a devstack | 04:06 |
| asalkeld | mmm, fedora so that new thingy | 04:06 |
| asalkeld | the thing that was mysql | 04:06 |
| openstackgerrit | huangtianhua proposed a change to openstack/heat: Fix docstring on heat https://review.openstack.org/62536 | 04:07 |
| asalkeld | lifeless, mariadb | 04:07 |
| asalkeld | is that close enough | 04:07 |
| *** gokrokve_ has joined #heat | 04:08 | |
| *** gokrokve has quit IRC | 04:09 | |
| *** gokrokve_ has quit IRC | 04:09 | |
| *** gokrokve has joined #heat | 04:11 | |
| *** chandankumar has joined #heat | 04:16 | |
| *** swygue has quit IRC | 04:17 | |
| *** aignatov has quit IRC | 04:19 | |
| lifeless | asalkeld: I reckon | 04:30 |
| *** rongze has quit IRC | 04:33 | |
| *** gokrokve has quit IRC | 04:37 | |
| *** gokrokve has joined #heat | 04:37 | |
| *** SushilKM has quit IRC | 04:38 | |
| *** gokrokve has quit IRC | 04:41 | |
| *** arbylee has quit IRC | 04:43 | |
| *** SergeyLukjanov has joined #heat | 04:49 | |
| *** rongze has joined #heat | 04:55 | |
| *** rongze_ has joined #heat | 04:59 | |
| *** rongze has quit IRC | 05:00 | |
| *** rushiagr has quit IRC | 05:04 | |
| *** rongze_ has quit IRC | 05:04 | |
| *** ccs has joined #heat | 05:10 | |
| *** gokrokve has joined #heat | 05:20 | |
| *** guohliu has joined #heat | 05:23 | |
| *** spzala_ has quit IRC | 05:32 | |
| *** sgordon has quit IRC | 05:33 | |
| *** akuznetsov has quit IRC | 05:51 | |
| *** ccs has quit IRC | 05:52 | |
| *** sgordon has joined #heat | 05:52 | |
| *** nkhare has joined #heat | 05:53 | |
| *** ccs has joined #heat | 05:54 | |
| *** erkules_ has quit IRC | 05:56 | |
| *** gokrokve has quit IRC | 05:56 | |
| *** gokrokve has joined #heat | 05:56 | |
| *** rushiagr has joined #heat | 05:58 | |
| *** erkules_ has joined #heat | 05:59 | |
| *** SushilKM has joined #heat | 06:00 | |
| *** ccs has quit IRC | 06:00 | |
| *** gokrokve has quit IRC | 06:01 | |
| *** erkules_ is now known as erkules | 06:04 | |
| *** SushilKM__ has joined #heat | 06:04 | |
| *** SushilKM has quit IRC | 06:04 | |
| *** gondoi has quit IRC | 06:06 | |
| openstackgerrit | Jenkins proposed a change to openstack/heat: Imported Translations from Transifex https://review.openstack.org/62551 | 06:06 |
| *** gondoi has joined #heat | 06:09 | |
| *** gokrokve has joined #heat | 06:13 | |
| *** SushilKM__ has quit IRC | 06:14 | |
| *** SushilKM has joined #heat | 06:14 | |
| *** rongze has joined #heat | 06:15 | |
| *** sgordon has quit IRC | 06:17 | |
| *** nkhare has quit IRC | 06:26 | |
| *** nkhare has joined #heat | 06:27 | |
| *** nkhare has quit IRC | 06:27 | |
| *** nkhare has joined #heat | 06:27 | |
| *** gokrokve has quit IRC | 06:29 | |
| *** akuznetsov has joined #heat | 06:34 | |
| *** rushiagr has quit IRC | 06:36 | |
| *** sgordon has joined #heat | 06:36 | |
| *** SushilKM has quit IRC | 06:40 | |
| *** amritanshu_RnD has joined #heat | 06:41 | |
| *** andersonvom has quit IRC | 06:43 | |
| *** harlowja is now known as harlowja_away | 06:43 | |
| *** SushilKM has joined #heat | 06:43 | |
| *** rushiagr has joined #heat | 06:43 | |
| *** SergeyLukjanov has quit IRC | 06:45 | |
| *** vkozhukalov has quit IRC | 06:51 | |
| *** yogesh has joined #heat | 06:59 | |
| *** sgordon has quit IRC | 07:01 | |
| *** plomakin_ has quit IRC | 07:01 | |
| *** yogesh has quit IRC | 07:08 | |
| *** yogesh has joined #heat | 07:08 | |
| *** rushiagr has quit IRC | 07:11 | |
| *** rushiagr has joined #heat | 07:11 | |
| *** yogesh has quit IRC | 07:12 | |
| openstackgerrit | A change was merged to openstack/heat: Convert OSDBInstance to new Schema format https://review.openstack.org/61825 | 07:14 |
| openstackgerrit | A change was merged to openstack/python-heatclient: Supports bash_completion for heatclient https://review.openstack.org/62144 | 07:14 |
| *** yogesh has joined #heat | 07:21 | |
| shardy | morning | 07:22 |
| skraynev | morning | 07:22 |
| *** dmakogon_ has quit IRC | 07:23 | |
| *** dmakogon_ has joined #heat | 07:24 | |
| *** yogesh_ has joined #heat | 07:29 | |
| *** yogesh has quit IRC | 07:33 | |
| *** urulama has joined #heat | 07:33 | |
| *** gokrokve has joined #heat | 07:40 | |
| *** andersonvom has joined #heat | 07:43 | |
| *** lsmola_ has joined #heat | 07:44 | |
| *** gokrokve has quit IRC | 07:44 | |
| *** bgorski has joined #heat | 07:47 | |
| *** scollier has quit IRC | 07:50 | |
| *** andersonvom has quit IRC | 07:51 | |
| *** akuznetsov has quit IRC | 07:56 | |
| *** TonyBurn has joined #heat | 07:58 | |
| chmouel | hello | 07:59 |
| *** scollier has joined #heat | 08:01 | |
| *** alexheneveld has quit IRC | 08:03 | |
| openstackgerrit | A change was merged to openstack/heat: WaitCondition Count property is now updatable https://review.openstack.org/61218 | 08:06 |
| Alienyyg | morning guys | 08:09 |
| *** sergmelikyan has joined #heat | 08:21 | |
| *** pfreund has joined #heat | 08:25 | |
| *** vkozhukalov has joined #heat | 08:26 | |
| *** aignatov has joined #heat | 08:33 | |
| *** giulivo has joined #heat | 08:37 | |
| *** rushiagr has quit IRC | 08:38 | |
| *** rushiagr2 has joined #heat | 08:38 | |
| *** ifarkas has joined #heat | 08:40 | |
| *** rushiagr2 has quit IRC | 08:44 | |
| skraynev | shardy: If I have a some bug in havana release, that has fixed in master, may I do *backport*? | 08:46 |
| *** urulama has quit IRC | 08:47 | |
| shardy | skraynev: which bug? | 08:47 |
| skraynev | https://bugs.launchpad.net/heat/+bug/1247638 | 08:47 |
| uvirtbot | Launchpad bug 1247638 in heat "Heat Load Neutron Balancer not using reference" [Undecided,Fix released] | 08:47 |
| *** rushiagr2 has joined #heat | 08:49 | |
| shardy | skraynev: I've tagged the bug havana-backport potential, which will flag it as a candidate for the next stable release | 08:50 |
| shardy | skraynev: You can, if you wish, propose the backported fix yourself: | 08:50 |
| shardy | https://wiki.openstack.org/wiki/StableBranch#Proposing_Fixes | 08:50 |
| shardy | Normally we just tag bugs with havana-backport potential though, and pull all the backports together close to the release (the PTL normally does this) | 08:51 |
| shardy | havana-backport-potential even | 08:51 |
| *** asalkeld has quit IRC | 08:51 | |
| shardy | skraynev: Unfortunately you're a few hours too late for 2013.2.1 | 08:52 |
| skraynev | shardy: Yep unfortunately((( | 08:52 |
| *** asalkeld has joined #heat | 08:53 | |
| skraynev | shardy: Also If you have tagged it, I think, that will be better give this contribution to PTL, IMO. | 08:54 |
| openstackgerrit | Liang Chen proposed a change to openstack/heat: Enalbe parallel while deleting neutron resources https://review.openstack.org/62580 | 08:54 |
| *** urulama has joined #heat | 08:54 | |
| openstackgerrit | anusha rayani proposed a change to openstack/python-heatclient: Misc typos in celiometer client https://review.openstack.org/62582 | 08:57 |
| *** rushiagr2 is now known as rushiagr | 09:00 | |
| skraynev | shardy: Also I wanted ask about changing bug status: AFAIK if commit message include bug id reference - status will be changed automatically. is it right? anyway, if fix was merged and status are still Triaged, Who could change status (I mean correct way, not who has right) | 09:06 |
| skraynev | shardy: this bug : https://bugs.launchpad.net/heat/+bug/1255713 | 09:06 |
| uvirtbot | Launchpad bug 1255713 in heat "Calling heatclient from heat doesn't work in standalone mode" [Medium,Triaged] | 09:07 |
| *** nosnos has quit IRC | 09:07 | |
| *** nosnos has joined #heat | 09:07 | |
| *** derekh has joined #heat | 09:07 | |
| *** SergeyLukjanov has joined #heat | 09:08 | |
| *** SergeyLukjanov has quit IRC | 09:09 | |
| shardy | skraynev: The patch referenced in that bug is not the fix, but a related patch | 09:09 |
| *** SergeyLukjanov has joined #heat | 09:09 | |
| shardy | skraynev: So AFAICS the status is correct | 09:09 |
| skraynev | shardy: Oou. Sorry, it's my fault. I didn't know about it. | 09:11 |
| skraynev | shardy: thanks for the help. | 09:11 |
| *** akuznetsov has joined #heat | 09:13 | |
| *** tomek_adamczewsk has joined #heat | 09:14 | |
| *** vkozhukalov has quit IRC | 09:35 | |
| *** faramir1 has quit IRC | 09:46 | |
| *** andersonvom has joined #heat | 09:48 | |
| lifeless | asalkeld: stevebaker: want to know something super weird - the trunk migration works... if you have no data in the system | 09:49 |
| lifeless | 2013-12-17 09:38:42.519 3671 INFO migrate.versioning.api [-] 30 -> 31... | 09:49 |
| lifeless | 2013-12-17 09:38:42.611 3671 INFO migrate.versioning.api [-] done | 09:49 |
| lifeless | from a deployment | 09:49 |
| lifeless | so I think we need something similar to what nova has now, active tests on real db's | 09:49 |
| lifeless | SpamapS: ^ | 09:50 |
| *** vkozhukalov has joined #heat | 09:50 | |
| *** andersonvom has quit IRC | 09:52 | |
| *** nati_ueno has quit IRC | 09:53 | |
| *** nati_ueno has joined #heat | 09:55 | |
| *** SergeyLukjanov has quit IRC | 09:55 | |
| shardy | lifeless: +1 on migration testing, I hit a weird issue recently ref bug #1241826 | 09:56 |
| uvirtbot | Launchpad bug 1241826 in heat "bin/heat-manage db_sync doesn't create db" [Medium,Fix released] https://launchpad.net/bugs/1241826 | 09:56 |
| shardy | would be great to catch these problems in the gate | 09:57 |
| *** SergeyLukjanov has joined #heat | 09:57 | |
| shardy | zigo: Hi | 09:57 |
| therve | lifeless, It's unfortunate, as we reverted the patch previously because of the same reason afaiu :/ | 09:59 |
| skraynev | lifeless: Do you mean walk version db tests? | 09:59 |
| *** nanjj has quit IRC | 10:00 | |
| shardy | therve: gah. Just reading the backscroll :( | 10:02 |
| *** faramir1 has joined #heat | 10:04 | |
| lifeless | skraynev: I mean having real data to test against | 10:05 |
| lifeless | skraynev: since migrations can fail depending on the data they migrate | 10:05 |
| skraynev | lifeless: Gotcha, thanks | 10:07 |
| *** rushiagr has quit IRC | 10:13 | |
| *** rushiagr has joined #heat | 10:14 | |
| *** rcleere has quit IRC | 10:15 | |
| *** rcleere has joined #heat | 10:15 | |
| sergmelikyan | shardy, Hi! if you got a moment, could you take a look at this change? https://review.openstack.org/61074 | 10:18 |
| *** rushiagr has quit IRC | 10:25 | |
| *** rushiagr has joined #heat | 10:33 | |
| *** vaibhav has joined #heat | 10:33 | |
| *** tomek_adamczewsk has quit IRC | 10:34 | |
| *** aignatov has quit IRC | 10:34 | |
| *** tomek_adamczewsk has joined #heat | 10:35 | |
| *** rushiagr2 has joined #heat | 10:39 | |
| *** vkozhukalov has quit IRC | 10:40 | |
| *** rushiagr has quit IRC | 10:40 | |
| *** vkozhukalov has joined #heat | 10:52 | |
| *** yogesh_ has quit IRC | 11:01 | |
| *** blak111 has quit IRC | 11:01 | |
| *** blak111 has joined #heat | 11:01 | |
| *** SergeyLukjanov has quit IRC | 11:01 | |
| *** liang has quit IRC | 11:02 | |
| *** yogesh has joined #heat | 11:03 | |
| *** rushiagr2 has quit IRC | 11:05 | |
| *** rushiagr3 has joined #heat | 11:05 | |
| *** guohliu has quit IRC | 11:05 | |
| *** aignatov has joined #heat | 11:07 | |
| *** dmakogon_ is now known as denis_makogon | 11:09 | |
| *** nati_ueno has quit IRC | 11:10 | |
| *** nati_ueno has joined #heat | 11:11 | |
| *** nati_uen_ has joined #heat | 11:12 | |
| *** rushiagr3 is now known as rushiagr | 11:14 | |
| *** nati_ueno has quit IRC | 11:15 | |
| *** rongze has quit IRC | 11:19 | |
| *** Alienyyg has quit IRC | 11:25 | |
| *** SergeyLukjanov has joined #heat | 11:26 | |
| *** SergeyLukjanov has quit IRC | 11:34 | |
| *** SergeyLukjanov has joined #heat | 11:37 | |
| *** akuznetsov has quit IRC | 11:43 | |
| *** rongze has joined #heat | 11:44 | |
| *** rongze_ has joined #heat | 11:45 | |
| *** zaneb has quit IRC | 11:49 | |
| *** rongze has quit IRC | 11:49 | |
| *** nkhare has quit IRC | 11:51 | |
| *** chandankumar has quit IRC | 11:53 | |
| *** chandankumar has joined #heat | 11:53 | |
| *** zaneb has joined #heat | 12:02 | |
| *** rongze_ has quit IRC | 12:03 | |
| *** akuznetsov has joined #heat | 12:04 | |
| *** shakayumi has joined #heat | 12:06 | |
| *** aignatov has quit IRC | 12:07 | |
| *** rushiagr2 has joined #heat | 12:08 | |
| *** rushiagr has quit IRC | 12:09 | |
| *** rushiagr3 has joined #heat | 12:11 | |
| *** rushiagr2 has quit IRC | 12:13 | |
| *** akuznetsov has quit IRC | 12:15 | |
| *** akuznetsov has joined #heat | 12:15 | |
| openstackgerrit | anusha rayani proposed a change to openstack/python-heatclient: Misc typos in celiometer client https://review.openstack.org/62582 | 12:21 |
| *** akuznetsov has quit IRC | 12:25 | |
| *** faramir1 has quit IRC | 12:28 | |
| *** scollier has quit IRC | 12:29 | |
| *** scollier has joined #heat | 12:29 | |
| *** Alienyyg has joined #heat | 12:31 | |
| *** rongze has joined #heat | 12:34 | |
| *** vaibhav has quit IRC | 12:37 | |
| openstackgerrit | anusha rayani proposed a change to openstack/python-heatclient: Misc typos in Heat client https://review.openstack.org/62582 | 12:42 |
| *** rongze has quit IRC | 12:42 | |
| *** nosnos has quit IRC | 12:51 | |
| *** Alienyyg has quit IRC | 12:54 | |
| *** akuznetsov has joined #heat | 12:55 | |
| *** SergeyLukjanov has quit IRC | 12:56 | |
| *** SergeyLukjanov has joined #heat | 12:58 | |
| skraynev | shardy: I think, that many people simplify afraid to do commit without bug or bp. They may be think, that without any 'important' reference it will not be merged. | 13:06 |
| *** rushiagr3 has quit IRC | 13:06 | |
| *** nati_uen_ has quit IRC | 13:06 | |
| shardy | skraynev: Why do you think that is, have we communicated that message somewhere? | 13:07 |
| shardy | skraynev: IMO bugs should be about actual problems, not cosmetic cleanups or refactoring | 13:08 |
| skraynev | shardy: I mean review https://review.openstack.org/#/c/62582/ | 13:08 |
| shardy | skraynev: Yeah, where I'm saying a bug is not really needed, but it's not a big issue ;) | 13:09 |
| *** shakayumi has quit IRC | 13:10 | |
| *** shakayumi has joined #heat | 13:11 | |
| skraynev | shardy: yep) I agree with you. I only wanted give some explanation: why people do it ) | 13:12 |
| shardy | skraynev: I didn't really understand the explanation tbh | 13:13 |
| skraynev | skraynev: hah)) Let's try again: People create many simple bugs, because they think, that it's only way for getting approve on it change. that is all)) | 13:15 |
| *** shakayumi has quit IRC | 13:15 | |
| shardy | skraynev: Ok, cool - well FWIW I think people should raise bugs for actual problems, blueprints for features/enhancements, and just send the patch for trivial/cosmetic stuff :) | 13:16 |
| *** rpothier__ has quit IRC | 13:17 | |
| *** rongze has joined #heat | 13:18 | |
| skraynev | shardy: Yeap) Good approach ;) | 13:20 |
| *** urulama has quit IRC | 13:20 | |
| *** aignatov has joined #heat | 13:22 | |
| * skraynev Imagine how beginning developer make "difficult" decision: it is actual problem or trivial stuff? ))) To be or not to be? )))) heh)) | 13:23 | |
| *** rongze_ has joined #heat | 13:39 | |
| *** andersonvom has joined #heat | 13:41 | |
| *** TonyBurn has quit IRC | 13:43 | |
| *** rongze has quit IRC | 13:43 | |
| openstackgerrit | Bartosz Górski proposed a change to openstack/heat: Add an external gateway property to neutron router https://review.openstack.org/60118 | 13:44 |
| *** rongze_ has quit IRC | 13:48 | |
| *** rongze has joined #heat | 13:48 | |
| *** rongze_ has joined #heat | 13:49 | |
| openstackgerrit | Steven Hardy proposed a change to openstack/heat: Add initial support for instance_auth_method https://review.openstack.org/62439 | 13:53 |
| openstackgerrit | Steven Hardy proposed a change to openstack/heat: SignalResponder store access/secret in resource data https://review.openstack.org/62440 | 13:53 |
| openstackgerrit | Steven Hardy proposed a change to openstack/heat: heat_keystoneclient revise get_ec2_keypair https://review.openstack.org/62441 | 13:53 |
| *** rongze has quit IRC | 13:53 | |
| *** shakayumi has joined #heat | 13:54 | |
| *** andersonvom has quit IRC | 13:55 | |
| *** pfreund has quit IRC | 13:56 | |
| *** lsmola_ has quit IRC | 13:56 | |
| *** stannie has quit IRC | 13:58 | |
| *** lsmola_ has joined #heat | 14:10 | |
| *** pfreund has joined #heat | 14:11 | |
| openstackgerrit | A change was merged to openstack/python-heatclient: Misc typos in Heat client https://review.openstack.org/62582 | 14:12 |
| openstackgerrit | A change was merged to openstack/heat: Add OS::Neutron::RouterL3Agent for router.py https://review.openstack.org/61388 | 14:12 |
| *** rpothier__ has joined #heat | 14:12 | |
| *** aweiteka has joined #heat | 14:15 | |
| *** stannie has joined #heat | 14:18 | |
| openstackgerrit | Liang Chen proposed a change to openstack/heat: Enable parallel while deleting neutron resources https://review.openstack.org/62580 | 14:20 |
| *** radez_g0n3 is now known as radez | 14:26 | |
| *** denis_makogon has quit IRC | 14:29 | |
| *** shakayumi has quit IRC | 14:31 | |
| *** andersonvom has joined #heat | 14:32 | |
| *** aignatov has quit IRC | 14:33 | |
| *** vaibhav has joined #heat | 14:33 | |
| *** denis_makogon has joined #heat | 14:33 | |
| vaibhav | tims: hi | 14:34 |
| *** aignatov has joined #heat | 14:34 | |
| *** rpothier__ is now known as rpothier | 14:35 | |
| openstackgerrit | Pablo Andres Fuente proposed a change to openstack/heat: wsgi.Resource exception handling to not log errors https://review.openstack.org/62080 | 14:35 |
| *** vaibhav has quit IRC | 14:36 | |
| *** jcru has joined #heat | 14:38 | |
| *** rushiagr3 has joined #heat | 14:41 | |
| *** john-n-seattle1 has joined #heat | 14:44 | |
| *** topol has joined #heat | 14:50 | |
| sdake | morning | 14:50 |
| shardy | Hi sdake | 14:50 |
| sdake | hey shards | 14:51 |
| sdake | hey look ohloh is improved to include openstack | 14:52 |
| sdake | http://www.ohloh.net/accounts/stevendake?utm_campaign=update13&utm_medium=email&utm_source=optin | 14:52 |
| sdake | 7057 lifetime commits | 14:53 |
| sdake | I've been busy apparently | 14:53 |
| sdake | the last graph is trippy | 14:54 |
| sergmelikyan | Guys, which one is correct property name for instance in Nova terms? server_id or instance_id? | 14:56 |
| * sergmelikyan try to found some already existing usages | 14:56 | |
| openstackgerrit | Julia Varlamova proposed a change to openstack/heat: Filter resource types by support status https://review.openstack.org/55567 | 14:57 |
| therve | For nova, server_id | 14:57 |
| *** gokrokve has joined #heat | 14:58 | |
| shardy | You can't control that via the Server resource properties though, if that is the question? | 14:58 |
| sergmelikyan | shardy, I am working on https://blueprints.launchpad.net/heat/+spec/nova-networking-floatingip and apparantly need replacement term for AWS InstanceId property name | 14:59 |
| *** chandankumar has quit IRC | 14:59 | |
| *** Andrzej has joined #heat | 15:01 | |
| *** arbylee has joined #heat | 15:01 | |
| *** gokrokve has quit IRC | 15:01 | |
| *** gokrokve has joined #heat | 15:01 | |
| shardy | Ah, yeah server_id then | 15:02 |
| *** SushilKM has quit IRC | 15:02 | |
| *** vijendar has joined #heat | 15:03 | |
| sdake | steve hardy do you have an account on ohloh? | 15:03 |
| shardy | sdake: Yeah, it's shardy | 15:04 |
| *** denis_makogon has quit IRC | 15:05 | |
| *** denis_makogon has joined #heat | 15:05 | |
| openstackgerrit | Thomas Herve proposed a change to openstack/heat: Add new Ceilometer combination alarm resource https://review.openstack.org/62672 | 15:05 |
| sdake | https://www.ohloh.net/accounts/shardy | 15:05 |
| sdake | shardy didn't exist before Jan 2012 | 15:06 |
| shardy | yup, that's me ;) | 15:06 |
| sdake | crazy you weren't in dev all along | 15:06 |
| shardy | sdake: I was doing mostly proprietary stuff for many years, unfortunately ;) | 15:06 |
| sdake | ya hard to show up in an onlin etracking tool with that sort of work | 15:07 |
| sdake | i did some proprietary work right out of school | 15:07 |
| sdake | @ INTC | 15:08 |
| sdake | 3 years later, off to open source land | 15:08 |
| *** rushiagr3 is now known as rushiagr | 15:11 | |
| sdake | my bitcoin miner put 800$ USD in my checking account this morning | 15:12 |
| sdake | \o/ | 15:12 |
| *** swygue has joined #heat | 15:13 | |
| *** amritanshu_RnD has quit IRC | 15:15 | |
| *** tims has quit IRC | 15:16 | |
| jasond` | shardy: do you understand the problem that https://review.openstack.org/#/c/62534/ fixes? | 15:16 |
| shardy | jasond`: I believe so, but I've not tested the fix myself | 15:18 |
| jasond` | shardy: i don't understand it. why did the migration fail for lifeless? | 15:18 |
| jasond` | i can't reproduce it | 15:19 |
| shardy | jasond`: It's the same/similar issue to why we had to revert your previous patch, where setting the defaults doesn't work if you're using the InnoDB engine | 15:19 |
| shardy | jasond`: What DB are you using? | 15:20 |
| jasond` | mysql | 15:20 |
| openstackgerrit | Steven Dake proposed a change to openstack/heat-templates: OS::Metering::Alarm -> OS::Ceilometer::Alarm https://review.openstack.org/62677 | 15:20 |
| *** urulama has joined #heat | 15:21 | |
| sdake | so.. mariadb vs mysql | 15:21 |
| sdake | which has more unicorns | 15:21 |
| shardy | sdake: No, I think the issue is lifeless is using InnoDB not MyISAM on mysql | 15:22 |
| *** pfreund has quit IRC | 15:22 | |
| jasond` | shardy: i'm using innodb | 15:22 |
| sdake | what does fedora devstack use? | 15:22 |
| jasond` | i wonder if the mysql_ options in the migrate script work on mariadb | 15:23 |
| shardy | jasond`: hmm, in that case I'm not sure, hopefully lifeless and/or asalkeld can provide more info | 15:23 |
| jasond` | shardy: i'll ask asalkeld or lifeless when they get in. thanks | 15:24 |
| *** john-n-seattle1 has quit IRC | 15:24 | |
| shardy | jasond`: You've had a rough time with this patch huh, thanks for sticking with it! :) | 15:25 |
| *** urulama has quit IRC | 15:25 | |
| jasond` | thank YOU all for sticking with it :) | 15:25 |
| jasond` | i was just waiting for someone to fire me from multi-engine | 15:26 |
| *** spzala has joined #heat | 15:27 | |
| shardy | jasond`: I don't think anyone else wanted that particular hot-potato ;) | 15:27 |
| sdake | jasond you are stuck with it now :) | 15:28 |
| jasond` | :) | 15:28 |
| *** IlyaE has joined #heat | 15:29 | |
| sdake | do you need special permissions to set a relationship in a blueprint? | 15:39 |
| shardy | sdake: I don't think so, you just add a dependency | 15:39 |
| sdake | whats the button called? | 15:39 |
| sdake | (where is it) | 15:40 |
| shardy | "Add dependency", at the bottom, green "+" | 15:40 |
| sdake | thanks I'll look for that | 15:40 |
| sdake | shardy have you written any blueprints for heat so far? | 15:40 |
| shardy | sdake: quite a few, yes | 15:41 |
| *** brint has joined #heat | 15:41 | |
| sdake | cool - the blueprints or the code? | 15:41 |
| sdake | today I was going to try to link them all together | 15:41 |
| shardy | sdake: Well both, normally before I start working on a feature, I'll at least dump some minimal info in a BP then start hacking on a topic branch | 15:42 |
| shardy | I should probably do detailed wiki descriptions too really, considering I keep asking new contributiors for them ;) | 15:42 |
| sdake | detailed wiki seems overkill unless upstream requires it | 15:43 |
| sdake | ask forgiveness imo :) | 15:43 |
| *** jergerber has joined #heat | 15:45 | |
| *** alcabrera has joined #heat | 15:46 | |
| *** alcabrera has left #heat | 15:46 | |
| Andrzej | hi, i work in xlcloud and we use nested stacks for heat. but we are considering switching to providers and creating custom resource types. | 15:46 |
| Andrzej | does anyone know, is it possible to inject some information to resource template in different way than properties? | 15:46 |
| Andrzej | can it be done with use of environments? | 15:46 |
| Andrzej | we want to set some parameters of resource from environment, but not clutter stack template with properties | 15:47 |
| *** SergeyLukjanov has quit IRC | 15:48 | |
| Andrzej | I found some example of environment in documentation that I don't understand: https://wiki.openstack.org/wiki/Heat/Environments | 15:48 |
| sdake | how do I get a test coverage report in tox? | 15:49 |
| Andrzej | is it valid? i thought environment can only have fields 'parameters' and 'resource_registry' | 15:49 |
| openstackgerrit | Anderson Mesquita proposed a change to openstack/heat: Remove X-Auth-Url header from authtoken middleware https://review.openstack.org/60991 | 15:49 |
| *** vkozhukalov has quit IRC | 15:51 | |
| *** denis_makogon has quit IRC | 15:56 | |
| *** denis_makogon has joined #heat | 15:56 | |
| sdake | are the unit test results online somewhere? | 15:56 |
| sdake | with coverage reports? | 15:56 |
| therve | Well the results are posted by jenkins | 16:00 |
| therve | But I don't think we have coverage tracking | 16:01 |
| sdake | I am pretty sure I have added that alteast twice to the infra :) | 16:01 |
| *** radez is now known as radez_g0n3 | 16:02 | |
| therve | You should know where it is then :) | 16:02 |
| *** bnemec_ is now known as bnemec | 16:02 | |
| *** yogesh has quit IRC | 16:02 | |
| *** aignatov has quit IRC | 16:03 | |
| shardy | sdake: I normall do run_tests.sh -c | 16:04 |
| shardy | normally | 16:04 |
| shardy | Andrzej: If I'm understanding correctly, you can do what you want with the environment | 16:05 |
| shardy | Andrzej: You specify parameters in the provider templates, then you can specify values for the parameters in the environment file you pass when creating the stack | 16:06 |
| shardy | Andrzej: Here is a really simple worked example: | 16:06 |
| shardy | http://hardysteven.blogspot.co.uk/2013/10/heat-providersenvironments-101-ive.html | 16:06 |
| shardy | Andrzej: Probably the key thing to mention is that the provider resource properties get converted into parameters for the nested stack | 16:08 |
| shardy | e.g key_name in the blog example | 16:09 |
| Andrzej | shardy: thanks. in such I case I need to add property in resource for every parameter I want to use in nested stack, yes? | 16:11 |
| Andrzej | shardy: perfect for me would be, if I could leave properties section empty in resource, and use environment parameters in nested stack | 16:12 |
| Andrzej | shardy: stack template will be presented to the user and we hoped to hide some configuration parameters of nested stack | 16:13 |
| *** akuznetsov has quit IRC | 16:13 | |
| *** tims has joined #heat | 16:14 | |
| Andrzej | shardy: but if I understand correctly it is not possible, right? | 16:16 |
| *** randallburt has joined #heat | 16:18 | |
| sdake | https://blueprints.launchpad.net/tempest/+spec/tempest-heat-integration | 16:18 |
| sdake | run_tests.sh is giving me mock_open errors | 16:18 |
| sdake | there must be something non-standard about your enviornment shardy | 16:18 |
| sdake | but it runs with with_venv.sh | 16:19 |
| sdake | so I used that | 16:19 |
| shardy | sdake: s/non-standard/non-broken ;) | 16:19 |
| therve | Someone has any idea about http://logs.openstack.org/52/62252/1/gate/gate-heat-python27/74fd9de/console.html ? | 16:19 |
| shardy | sdake: I guess maybe you're missing some of the test-requirements? | 16:20 |
| openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Prevent tempest from failing upon ActionInProgress https://review.openstack.org/62703 | 16:20 |
| therve | Appearing on https://review.openstack.org/#/c/62252/ | 16:20 |
| shardy | Andrzej: I'm just checking | 16:20 |
| shardy | therve: There have been issues with MetadataRefreshTest on stable/grizzly for a long time | 16:21 |
| shardy | therve: I backported what I thought was the fix, but apparently not :( | 16:21 |
| *** SushilKM has joined #heat | 16:21 | |
| therve | Oh grizzly | 16:21 |
| therve | That may be why | 16:21 |
| shardy | I thought https://review.openstack.org/#/c/44029/ would fix it | 16:22 |
| shardy | evidently not | 16:23 |
| *** ifarkas has quit IRC | 16:25 | |
| *** SushilKM has quit IRC | 16:30 | |
| *** jamieh_ has joined #heat | 16:32 | |
| shardy | Andrzej: You're right, you currently can't specify nested stack parameters in the environment | 16:33 |
| shardy | Andrzej: It seems like something we may want to allow though, can you raise a bug and we'll take a look at fixing it? | 16:34 |
| *** alcabrera has joined #heat | 16:36 | |
| *** jamieh_ has quit IRC | 16:36 | |
| *** rcleere has quit IRC | 16:37 | |
| *** alcabrera has left #heat | 16:37 | |
| *** SushilKM has joined #heat | 16:38 | |
| *** sjmc has joined #heat | 16:47 | |
| *** john-n-seattle1 has joined #heat | 16:50 | |
| *** rongze_ has quit IRC | 16:53 | |
| *** rongze has joined #heat | 16:53 | |
| *** SergeyLukjanov has joined #heat | 16:54 | |
| *** john-n-seattle1 has quit IRC | 16:55 | |
| *** vijendar has quit IRC | 16:56 | |
| openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Prevent tempest from failing upon ActionInProgress https://review.openstack.org/62703 | 16:56 |
| *** vijendar has joined #heat | 16:56 | |
| *** tomek_adamczewsk has quit IRC | 16:58 | |
| *** rcleere has joined #heat | 16:59 | |
| *** john-n-seattle1 has joined #heat | 17:10 | |
| *** pablosan has joined #heat | 17:11 | |
| tims | stevebaker and anyone who would like to chime in on the parameter labels discussion | 17:13 |
| tims | I have posted the discussion on the UX askbot | 17:13 |
| tims | http://ask-openstackux.rhcloud.com/question/119/should-heat-pass-parameter-labels-to-horizon/ | 17:13 |
| *** AndrewMichalik has quit IRC | 17:14 | |
| *** pablosan has quit IRC | 17:15 | |
| *** john-n-seattle1 has left #heat | 17:16 | |
| *** pablosan has joined #heat | 17:18 | |
| therve | tims, Why isn't description good enough for this? | 17:19 |
| tims | therve you mean, we should use the description as the parameter label? | 17:20 |
| therve | tims, Yeah | 17:20 |
| therve | Most of the time it would be great, maybe a bit long sometimes | 17:20 |
| tims | the label should be 2 or 3 words | 17:21 |
| tims | we have to worry about spacing and positioning in html | 17:21 |
| tims | the description should be sentences | 17:21 |
| *** urulama has joined #heat | 17:22 | |
| jasond` | therve: the label would be in the html form next to an input box | 17:23 |
| therve | Maybe. They don't seem to be in practice | 17:23 |
| jasond` | so it would say "Database Name: ________" instead of "db_name: _______" | 17:23 |
| tims | correct thanks jasond` | 17:23 |
| therve | Okay | 17:23 |
| tims | If you look at the Horizon implementation currently the description lives in a box to the right of the form | 17:23 |
| therve | Adding a label feels weird, but maybe that's just me | 17:25 |
| tims | I was surprised by how many people had the same reaction, I would love to understand why it is weird | 17:26 |
| *** urulama has quit IRC | 17:26 | |
| tims | Horizon has some regex stuff that it does on some things to make variable names more human readable | 17:27 |
| tims | like replace underscore with space | 17:27 |
| tims | and capitalize beginnings of words | 17:27 |
| therve | tims, Template editing should be easier, not the other way around | 17:27 |
| therve | It's just something in the way | 17:28 |
| therve | I guess it was the same arguments with metadata | 17:28 |
| tims | but letting the template author be explicit about how the template will behave in the UI is valuable I think | 17:28 |
| tims | and it is optional | 17:28 |
| tims | if it isn't provided it will default to the keyname | 17:28 |
| tims | well metadata was the opposite argument actually | 17:29 |
| tims | metadata was let's just throw things in here and not worry about it | 17:29 |
| therve | Okay :) | 17:29 |
| tims | I am very much for easy template editing | 17:30 |
| therve | tims, What about standarzing a format in the description? | 17:30 |
| tims | I don't see how that is less complex | 17:30 |
| tims | and the current debate is more about what to display in Horizon than how to implement in the template | 17:30 |
| tims | so you are ok with displaying a human-readable label in horizon? | 17:31 |
| therve | IE description= label: explanatory tewt | 17:31 |
| therve | text | 17:31 |
| therve | It's backward compatible, it's fairly easy to do, and it makes templates look nice | 17:31 |
| *** randallburt has quit IRC | 17:31 | |
| tims | it isn't self-explanatory | 17:31 |
| therve | Well sure, there is not much point to be against that | 17:31 |
| jasond` | wouldn't an older version of heat just ignore the label? | 17:31 |
| tims | well that is the current debate :) | 17:31 |
| tims | yes | 17:31 |
| tims | jasond`: | 17:32 |
| tims | I even wrote the code | 17:32 |
| therve | Now the debate is where to put the information, AFAIU | 17:32 |
| therve | s/Now/No | 17:32 |
| tims | https://review.openstack.org/#/c/62418/2 | 17:32 |
| jasond` | so backward compatibility isn't a consideration | 17:33 |
| tims | it is | 17:33 |
| tims | if the label doesn't exist Heat will insert the parameter key into the label field | 17:33 |
| therve | tims, What happens when you pass a template with a label to an old Heat install? | 17:33 |
| jasond` | tims: why doesn't the UI handle that | 17:34 |
| tims | well currently Heat just ignores things in the template that it doesn't care about | 17:34 |
| tims | therve ^ | 17:34 |
| tims | so it would just store it as part of the template and ignore it | 17:34 |
| therve | Okay | 17:34 |
| therve | That's good I guess | 17:34 |
| tims | jasond`: the UI should handle what? | 17:34 |
| jasond` | tims: falling back on the param name if label isn't present | 17:35 |
| tims | it could | 17:35 |
| tims | based on my conversation with Zane though, Heat should start caring about compatibility issues | 17:36 |
| tims | instead of letting downstream services handle it | 17:36 |
| jasond` | i dunno, the UI is rendering the template into an HTML form. seems like that logic belongs in the UI | 17:37 |
| jasond` | anyway, that's another topic | 17:37 |
| tims | unless Heat wants to be opinionated about what should happen | 17:37 |
| tims | which from what I have gathered it does | 17:37 |
| tims | my original patch actually follows that train of thought jasond` | 17:39 |
| *** rongze has quit IRC | 17:39 | |
| *** rongze has joined #heat | 17:40 | |
| *** swygue has quit IRC | 17:43 | |
| *** vkozhukalov has joined #heat | 17:44 | |
| openstackgerrit | Kevin Benton proposed a change to openstack/heat: Adds extraroutes support to neutron routers https://review.openstack.org/41044 | 17:46 |
| larsks | Is the name of the stack being deployed available explicitly within the template via some function? | 17:48 |
| *** AndrewMichalik has joined #heat | 17:48 | |
| therve | larsks: Yes, AWS::StackName IIRC | 17:49 |
| openstackgerrit | Kevin Benton proposed a change to openstack/heat: Adds extraroutes support to neutron routers https://review.openstack.org/41044 | 17:50 |
| *** radix_ has joined #heat | 17:53 | |
| *** rongze has quit IRC | 17:53 | |
| *** rongze has joined #heat | 17:54 | |
| *** nati_ueno has joined #heat | 17:56 | |
| *** derekh has quit IRC | 17:58 | |
| *** randallburt has joined #heat | 18:01 | |
| *** sabeen has joined #heat | 18:02 | |
| *** nati_uen_ has joined #heat | 18:02 | |
| larsks | therve: Thanks, I'll look into that. | 18:02 |
| *** nati_uen_ has quit IRC | 18:04 | |
| *** nati_uen_ has joined #heat | 18:04 | |
| *** nati_uen_ has quit IRC | 18:05 | |
| *** nati_ueno has quit IRC | 18:05 | |
| *** nati_uen_ has joined #heat | 18:05 | |
| *** rongze has quit IRC | 18:18 | |
| *** harlowja_away is now known as harlowja | 18:22 | |
| *** yogesh has joined #heat | 18:25 | |
| openstackgerrit | Stephen Sugden proposed a change to openstack/heat: Add PortCheck resource https://review.openstack.org/62078 | 18:25 |
| *** blamar has quit IRC | 18:29 | |
| openstackgerrit | Vijendar Komalla proposed a change to openstack/heat: Implement adopt-stack https://review.openstack.org/62730 | 18:30 |
| *** vkozhukalov has quit IRC | 18:36 | |
| *** vkozhukalov has joined #heat | 18:37 | |
| *** ifarkas has joined #heat | 18:37 | |
| *** blamar has joined #heat | 18:39 | |
| openstackgerrit | Kevin Benton proposed a change to openstack/heat: Adds extraroutes support to neutron routers https://review.openstack.org/41044 | 18:40 |
| stevebaker | morning | 18:47 |
| *** pvaneck has joined #heat | 18:51 | |
| *** nati_ueno has joined #heat | 18:53 | |
| *** spzala has quit IRC | 18:56 | |
| *** nati_uen_ has quit IRC | 18:57 | |
| *** swygue has joined #heat | 18:58 | |
| *** SushilKM__ has joined #heat | 18:58 | |
| *** SushilKM has quit IRC | 18:58 | |
| *** rushiagr has quit IRC | 18:59 | |
| *** sabeen has quit IRC | 19:05 | |
| *** sabeen has joined #heat | 19:05 | |
| *** nati_ueno has quit IRC | 19:10 | |
| *** rongze has joined #heat | 19:13 | |
| *** nati_ueno has joined #heat | 19:13 | |
| *** rushiagr has joined #heat | 19:16 | |
| *** rongze has quit IRC | 19:18 | |
| *** gokrokve has quit IRC | 19:20 | |
| *** akuznetsov has joined #heat | 19:20 | |
| *** SnowDust has joined #heat | 19:22 | |
| *** akuznetsov has quit IRC | 19:22 | |
| *** urulama has joined #heat | 19:23 | |
| *** AndrewMichalik has quit IRC | 19:23 | |
| *** AndrewMichalik has joined #heat | 19:25 | |
| *** gamekiller77 has joined #heat | 19:25 | |
| gamekiller77 | Good day all i looking for a sample template i can play with to test my heat deployment any good links out there | 19:26 |
| SnowDust | anteaya still reading ur blog carefully .... "so all the teachers new me from the start." | 19:26 |
| *** urulama has quit IRC | 19:27 | |
| *** harlowja is now known as harlowja_away | 19:30 | |
| openstackgerrit | Zane Bitter proposed a change to openstack/heat: rackspace: Convert resources to new Schema format https://review.openstack.org/61834 | 19:31 |
| SnowDust | gamekiller77 : https://github.com/openstack/heat-templates | 19:32 |
| SnowDust | absorb as much u can ... | 19:32 |
| gamekiller77 | thanks SnowDust i just need to do a simple deployment to show it works to the bosses | 19:32 |
| SnowDust | deploy a santa .. :) | 19:33 |
| SnowDust | that works better in christmas time | 19:33 |
| gamekiller77 | yah right | 19:33 |
| gamekiller77 | i was hoping like a small mysql server or a simple URL test | 19:34 |
| *** rushiagr has quit IRC | 19:36 | |
| gamekiller77 | love errors | 19:37 |
| SnowDust | gamekiller77: u will find one .. for your need .. look at cfn/f17 folder | 19:38 |
| gamekiller77 | yah looking | 19:38 |
| SnowDust | gamekiller77: https://github.com/openstack/heat-templates/blob/master/cfn/F17/MySQL_Single_Instance.template | 19:40 |
| gamekiller77 | thanks man | 19:40 |
| gamekiller77 | i keep getting this | 19:40 |
| gamekiller77 | An unknown problem occurred validating the template. | 19:40 |
| SnowDust | oops .. | 19:40 |
| gamekiller77 | i doing direct input so going to try file next | 19:40 |
| SnowDust | heat <environment settings> template-validate --template-url <url> | 19:41 |
| SnowDust | heat <environment settings> template-validate --template-file <file path> | 19:41 |
| gamekiller77 | ok that last one you gave me took | 19:42 |
| gamekiller77 | hehe | 19:42 |
| gamekiller77 | thanks man | 19:42 |
| SnowDust | use .. heat --debug ( most essential switch to troubleshoot ) | 19:42 |
| gamekiller77 | yah i do that | 19:42 |
| gamekiller77 | first time testing Heat | 19:42 |
| gamekiller77 | just got my KVM nodes in line with volumes | 19:42 |
| SnowDust | no issues .. :-) | 19:42 |
| gamekiller77 | so time to test this | 19:42 |
| SnowDust | gr8 | 19:42 |
| stevebaker | therve: was it you who started working on something like this https://blueprints.launchpad.net/heat/+spec/parameter-nested-schema | 19:43 |
| therve | stevebaker, Nope | 19:43 |
| *** randallburt has quit IRC | 19:44 | |
| stevebaker | asalkeld: ^ do you recall? | 19:45 |
| gamekiller77 | SnowDust, i am bit of noob to heat but i need to have instances in place for them to work right with there name format they are listed in there template like F17 should be in place | 19:46 |
| SnowDust | nothing like that .. | 19:46 |
| gamekiller77 | ok it failed hmm | 19:47 |
| SnowDust | template = formatted file .. as per the template guide .. http://docs.openstack.org/developer/heat/template_guide/index.html | 19:47 |
| SnowDust | u can keep them in a github repo .. | 19:48 |
| SnowDust | clone them .. | 19:48 |
| SnowDust | and use them from the cloned repo path .. | 19:48 |
| openstackgerrit | Zane Bitter proposed a change to openstack/heat: Convert Server to new Schema format https://review.openstack.org/61786 | 19:48 |
| SnowDust | its as simple like that | 19:48 |
| SnowDust | u decide how ur repo gets organized | 19:48 |
| therve | stevebaker, I may have some time to take additional blueprint work, though, if that helps | 19:48 |
| *** randallburt has joined #heat | 19:49 | |
| stevebaker | therve: this one is autoscaling related https://blueprints.launchpad.net/heat/+spec/autoscaling-parameters | 19:49 |
| gamekiller77 | yah sorry just learning as i got to teach my automation guys how to use this after i done validating this setup | 19:49 |
| *** bgorski has quit IRC | 19:50 | |
| therve | stevebaker, Hum I agree with radix on that one. I'm not sure what's the use case of the blueprint | 19:51 |
| stevebaker | therve: maybe reduce the scope of that blueprint to use case #2 | 19:52 |
| *** randallburt has quit IRC | 19:52 | |
| *** IlyaE has quit IRC | 19:52 | |
| *** randallburt has joined #heat | 19:52 | |
| therve | Yeah. But it looks like it depends on a new autoscale resource | 19:52 |
| stevebaker | therve: and ignore scale-up for now | 19:52 |
| stevebaker | maybe I should kick that to i-3 and leave it unassigned | 19:53 |
| therve | +1 | 19:53 |
| *** pafuent has joined #heat | 19:53 | |
| therve | We should also get some feedback from the creator | 19:54 |
| SnowDust | anteaya : best of ur blog is the git one .. gr8 work ! | 19:54 |
| stevebaker | therve: have you been working on autoscaling? | 19:54 |
| therve | stevebaker, No | 19:55 |
| therve | Well, not recently | 19:55 |
| therve | It's unclear if there is an agreement on any sort of design for it... | 19:56 |
| stevebaker | oh, I thought there was agreement and it was all go | 19:57 |
| stevebaker | therve, radix, maybe we should discuss at the heat meeting tomorrow | 19:58 |
| *** SushilKM__ has quit IRC | 19:59 | |
| therve | stevebaker, I can't attend the meetings :/ | 19:59 |
| *** SushilKM__ has joined #heat | 19:59 | |
| therve | I was actually wondering if we could start alternating with 2 different times | 20:00 |
| therve | Ceilometer does that and it's pretty nice | 20:00 |
| *** ccs has joined #heat | 20:01 | |
| stevebaker | therve: yes, we need to discuss alternative meeting times | 20:02 |
| tims | hey stevebaker, I posted the link earlier but in case you missed the back scroll I want to make sure that I represented the discussion correctly | 20:02 |
| tims | http://ask-openstackux.rhcloud.com/question/119/should-heat-pass-parameter-labels-to-horizon/ | 20:02 |
| stevebaker | tims: I'm just forming a reply now | 20:02 |
| tims | ok thanks | 20:02 |
| *** ifarkas has quit IRC | 20:05 | |
| *** ccs has quit IRC | 20:05 | |
| *** radez_g0n3 is now known as radez | 20:07 | |
| openstackgerrit | Richard Lee proposed a change to openstack/heat: Add way to group exceptions in DependencyTaskGroup https://review.openstack.org/62479 | 20:09 |
| *** vkozhukalov has quit IRC | 20:11 | |
| zaneb | ugh | 20:12 |
| openstackgerrit | Anderson Mesquita proposed a change to openstack/heat: Check resources are in expected states https://review.openstack.org/58641 | 20:13 |
| zaneb | stevebaker: looks like we've managed to acquire two more badly-designed Neutron resources with magic hidden dependencies already since summit :( | 20:13 |
| *** harlowja_away is now known as harlowja | 20:14 | |
| *** sgordon has joined #heat | 20:16 | |
| *** gokrokve has joined #heat | 20:18 | |
| *** brint has quit IRC | 20:19 | |
| gamekiller77 | hey guys do i need to enable the AWS api s on my openstack setup to have heat work ? | 20:19 |
| *** denis_makogon has quit IRC | 20:19 | |
| randallburt | gamekiller77: nope, you can use the OpenStack "native" api | 20:19 |
| *** sjmc has quit IRC | 20:19 | |
| *** brint has joined #heat | 20:19 | |
| gamekiller77 | ok just checking | 20:19 |
| *** dmakogon_ has joined #heat | 20:19 | |
| *** mtaylor is now known as mordred | 20:20 | |
| gamekiller77 | i see a lot of AWS items in the template was just wondering | 20:21 |
| zaneb | gamekiller77: heat supports a lot of AWS-like resources, but both AWS and native resource types call the OpenStack-native APIs | 20:22 |
| SnowDust | zaneb +1 | 20:22 |
| zaneb | (in many cases they're basically the same code) | 20:22 |
| gamekiller77 | ok cool | 20:23 |
| gamekiller77 | just jumping in to this so trying to understand. I have a galara mysql i want to see if i can get in to orchestration with heat | 20:23 |
| gamekiller77 | and use ceilo to have it scale out as needed | 20:23 |
| *** IlyaE has joined #heat | 20:24 | |
| *** ccs has joined #heat | 20:27 | |
| *** ccs has quit IRC | 20:31 | |
| stevebaker | zaneb: the Route had to satisfy the use case where a tenant is only allowed one router, but a stack needs to add a custom route | 20:32 |
| stevebaker | zaneb: I'm not sure what the other "badly designed" resource you're referring to, maybe we *both* missed the reviews for that one ;) | 20:34 |
| zaneb | stevebaker: I'm looking at https://review.openstack.org/#/c/59626/8/heat/engine/resources/neutron/net.py and https://review.openstack.org/#/c/61388/3/heat/engine/resources/neutron/router.py | 20:34 |
| zaneb | is there another one as well? | 20:34 |
| zaneb | in both of those cases what should be just a property of the network/router has been elevated into a whole resource, with various hacks added to make things actually work right | 20:36 |
| stevebaker | zaneb: for Route that wouldn't have worked for the use case mentioned above. There is a particular neutron hardware plugin which has the restriction of only one (pre-existing) router per tenant | 20:39 |
| zaneb | I don't see the connection? | 20:40 |
| stevebaker | zaneb: the router needs to be passed in as a parameter, because it already exists and is a singleton for the tenant | 20:41 |
| SpamapS | stevebaker: retry-failed-update is pretty important actually.. I just haven't been able to find time to work on it. | 20:41 |
| SpamapS | stevebaker: (noticing tha tyou deprioritized it) | 20:41 |
| stevebaker | SpamapS: cool, assign it to yourself and I'll raise the priority again | 20:42 |
| SpamapS | stevebaker: IMO we shouldn't drop priority without documenting the justification in the whiteboard. | 20:42 |
| zaneb | stevebaker: if it's already set up then why isn't it assigned to an agent? (whatever that is) | 20:43 |
| stevebaker | SpamapS: I should have documented why. It was ttx's suggestion as a way of motivating assignees - it appears to have worked | 20:44 |
| SpamapS | stevebaker: haha | 20:44 |
| openstackgerrit | Pablo Andres Fuente proposed a change to openstack/heat: Deleting a stack with a deleted nested stack fails https://review.openstack.org/62752 | 20:44 |
| SpamapS | what will actually motivate me is having a CD cloud that I have to keep running over time. :) | 20:44 |
| SpamapS | which should be happening soon :) | 20:44 |
| stevebaker | zaneb: oooooooh. ignore everything I just said. I thought you were talking about this https://review.openstack.org/#/c/41044/ | 20:45 |
| *** rpothier has quit IRC | 20:46 | |
| zaneb | stevebaker: OH G*D | 20:47 |
| sdake_ | someone needs to invent a mailbox filter that the US postal service can work with | 20:49 |
| zaneb | stevebaker: that's just the wrong approach IMO. We should have a RouteTable resource, not individual Routes | 20:49 |
| sgran | there should be both | 20:51 |
| stevebaker | zaneb: but if there is only one router per tenant, different stacks would need to contribute routes. With a RouteTable there would be the complexity of merging tables. At least with a single Route you know what to add and remove, and you can raise an error if there is a duplicate | 20:51 |
| sgran | a RouteTable contains a bunch of Routes | 20:51 |
| zaneb | well, we shouldn't be using dependencies within a stack to avoid race conditions | 20:52 |
| zaneb | we should write code without race conditions | 20:52 |
| sdake_ | stevebaker what is your take on importing a salt server into the heat engine process address space | 20:52 |
| zaneb | because if you have routes in multiple stacks contributing multiple routes, there's no dependencies there | 20:53 |
| zaneb | so either fix the race conditions or don't do it, but don't just paper over the race conditions | 20:53 |
| stevebaker | I can't think of a complete solution which is heat-only. We could just say that we can't support adding routes to existing routers until neutron exposes an API for it | 20:56 |
| stevebaker | then add a routes list property | 20:57 |
| zaneb | the neutron API is horrible, and we should actually be pushing back on them and letting them know that we can't actually use it safely | 20:57 |
| zaneb | half the problem is that most of their core functionality is exposed as "extensions", so the API is completely balkanised | 20:58 |
| *** SushilKM__ has quit IRC | 20:58 | |
| stevebaker | i suppose that is partly a consequence of the heterogeneous networking hardware that it wraps | 20:59 |
| sdake_ | stevebaker as of today, my bitcoin miner has officially ROIed, and is making 350-450$/day - should have 3 more months until its obsolete ;) | 20:59 |
| stevebaker | sdake_: cool | 20:59 |
| zaneb | # depend on routes with greater addresses to order route installation | 21:00 |
| zaneb | wtf? ^ | 21:00 |
| sdake_ | of course it drops output 20% every 2 weeks :( | 21:00 |
| stevebaker | zaneb: add your comments to the review | 21:02 |
| zaneb | yeah, doing it now | 21:02 |
| stevebaker | zaneb: as for the agent stuff, I'd not looked at it until now. | 21:02 |
| *** andrew_plunk has joined #heat | 21:03 | |
| stevebaker | zaneb: they are admin-only - *possibly* that is justification for them being their own resources | 21:03 |
| zaneb | stevebaker: ok, would be great if you could take a look. I'll probably post to the ML about it | 21:03 |
| zaneb | tbh I can barely justify them existing at all if they are admin-only | 21:04 |
| stevebaker | admins setting up their long-lived networking infrastructure with heat seems reasonable | 21:05 |
| openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Don't provide default values to properties.get() https://review.openstack.org/62760 | 21:06 |
| *** topol has quit IRC | 21:06 | |
| *** dims has quit IRC | 21:08 | |
| *** pafuent has left #heat | 21:08 | |
| stevebaker | zaneb: fwiw I did point out to Kevin how much you would dislike that solution, but I couldn't think of anything better ;) | 21:08 |
| *** dims has joined #heat | 21:09 | |
| zaneb | stevebaker: better thing to do might be to fix the neutron api :) | 21:09 |
| stevebaker | yes, where race conditions belong! | 21:10 |
| *** sgordon has quit IRC | 21:16 | |
| *** nati_ueno has quit IRC | 21:20 | |
| *** urulama has joined #heat | 21:24 | |
| *** tomek_adamczewsk has joined #heat | 21:24 | |
| openstackgerrit | Randall Burt proposed a change to openstack/heat: Add nested resource references to resource group https://review.openstack.org/61614 | 21:24 |
| *** nati_ueno has joined #heat | 21:28 | |
| *** urulama has quit IRC | 21:28 | |
| *** sgordon has joined #heat | 21:29 | |
| *** AndrewMichalik has quit IRC | 21:30 | |
| *** 13WABKZ4U has joined #heat | 21:31 | |
| *** blomquisg has joined #heat | 21:36 | |
| *** 13WABKZ4U has quit IRC | 21:42 | |
| zaneb | stevebaker: there isn't even a race condition to deal with in the same stack, unless we have gone multi-threaded when I was not paying attention? | 21:43 |
| *** SushilKM has joined #heat | 21:43 | |
| zaneb | stevebaker: those dependencies are just meaningless noise | 21:45 |
| stevebaker | zaneb: wouldn't a stack with multiple route resources end up with concurrent router-fetch/update calls? | 21:48 |
| zaneb | stevebaker: nothing within a single stack or a tree of nested stacks is ever concurrent | 21:49 |
| zaneb | ever. | 21:49 |
| zaneb | if you started it in handle_create and finished in check_create_complete then yes, you could get a race | 21:49 |
| zaneb | but don't do that | 21:49 |
| stevebaker | so what happens when a router get triggers IO which causes eventlet to schedule something else? could the creation of another unrelated resource be started? | 21:50 |
| zaneb | yes, but only a resource in a different stack resulting from a different user request | 21:51 |
| zaneb | i.e. something outside of the local tree of nested stacks | 21:51 |
| stevebaker | ah, ok. that makes things simpler | 21:52 |
| zaneb | which is a problem, but not one that dependencies can solve | 21:52 |
| stevebaker | yes | 21:52 |
| stevebaker | could there be some reviews on this fix for gate race breakage? https://review.openstack.org/#/c/62703/ | 21:53 |
| *** tomek_adamczewsk has quit IRC | 21:54 | |
| *** tomek_adamczewsk has joined #heat | 21:55 | |
| lifeless | I'm going to come back to pointing at idempotent handlers | 21:55 |
| lifeless | let the race happen, clean up afterwards | 21:55 |
| *** SushilKM has quit IRC | 21:56 | |
| *** Seal has joined #heat | 21:57 | |
| zaneb | lifeless: so the issue is that we want to add a route to the route table, and the only way is to read the route table, add a route and then write the whole route table again | 21:57 |
| *** tomek_adamczewsk has quit IRC | 21:57 | |
| lifeless | for a router? | 21:57 |
| zaneb | yes | 21:57 |
| *** tomek_adamczewsk has joined #heat | 21:57 | |
| lifeless | ok, so two different stacks can race with each other | 21:57 |
| lifeless | plus end users. | 21:57 |
| stevebaker | correct | 21:57 |
| lifeless | its a broken API in neutron | 21:58 |
| stevebaker | for end users, that is the same for any resource | 21:58 |
| lifeless | any attempt to fix it in Heat is going to be incomplete. | 21:58 |
| zaneb | so a good way would be to return an ETag header with the route table, then PUT with the If-Match header set to the ETag value. Neutron should return 412 if the route table has changed | 21:59 |
| lifeless | are you asserting the presence of a specific route, or the content of the whole table - in the template? | 21:59 |
| stevebaker | a single route | 21:59 |
| lifeless | so, a user should be able to add a different route | 21:59 |
| lifeless | and not have it trashed | 21:59 |
| lifeless | -> can't solve in Heat. | 21:59 |
| zaneb | yes | 21:59 |
| zaneb | yes | 21:59 |
| stevebaker | unless it is concurrent | 21:59 |
| lifeless | quod erat demonstratum :) | 21:59 |
| lifeless | stevebaker: Neutron needs to allow a PATCH there to add a route rather than wholesale replacement | 22:00 |
| *** tomek_adamczewsk has quit IRC | 22:00 | |
| *** randallburt has quit IRC | 22:00 | |
| *** tomek_adamczewsk has joined #heat | 22:00 | |
| *** tims1 has joined #heat | 22:00 | |
| zaneb | lifeless: yes, or alternatively it could do what I wrote above (which requires no API changes at least) | 22:00 |
| stevebaker | so should we allow a route resource in the meantime? | 22:00 |
| *** SnowDust has quit IRC | 22:00 | |
| lifeless | zaneb: sure, that would be safer (if everything doing edits used I-M) | 22:01 |
| *** nati_uen_ has joined #heat | 22:01 | |
| *** andrew_plunk has quit IRC | 22:01 | |
| zaneb | stevebaker: IMO no. We should either fix the API or model the broken API, but not model a working API that is actually broken | 22:01 |
| *** tims has quit IRC | 22:02 | |
| *** tomek_adamczewsk has quit IRC | 22:02 | |
| *** tomek_adamczewsk has joined #heat | 22:02 | |
| stevebaker | zaneb: so you're suggesting optimistic concurrency on router updates? | 22:02 |
| *** nati_uen_ has quit IRC | 22:03 | |
| zaneb | stevebaker: did you see my comment on https://review.openstack.org/#/c/41044/ ? | 22:03 |
| *** nati_ueno has quit IRC | 22:03 | |
| *** nati_uen_ has joined #heat | 22:03 | |
| *** Seal has quit IRC | 22:03 | |
| stevebaker | zaneb: read it | 22:05 |
| zaneb | did that answer the question? | 22:05 |
| zaneb | I would describe the ETag/If-Match solution as optimistic concurrency. I think what lifeless described would be better. But if what we're being told about the Neutron API is accurate, then it is broken and needs to be fixed. | 22:07 |
| *** aignatov has joined #heat | 22:08 | |
| andersonvom | shardy: | 22:08 |
| andersonvom | oh well.. I might as well now. shardy, are you around? =P | 22:08 |
| shardy | andersonvom: yes | 22:09 |
| andersonvom | shardy: just wanted to make sure that we can rebase/fixup the management API for review again, given the last IRC meeting. that's the way we're going, right? | 22:10 |
| *** rpothier has joined #heat | 22:10 | |
| *** aweiteka has quit IRC | 22:11 | |
| shardy | andersonvom: Yes, but we need to get the ReST API enforced via policy.json first | 22:12 |
| shardy | which I have started, but currently I'm trying to get the instance-users stuff moved on before returning to the request scoping work | 22:12 |
| *** rpothier_ has joined #heat | 22:12 | |
| openstackgerrit | Stephen Sugden proposed a change to openstack/heat: Add PortCheck resource https://review.openstack.org/62078 | 22:14 |
| *** rpothier has quit IRC | 22:15 | |
| andersonvom | shardy: humm, my impression of the plan was that there was going to be another endpoint enforced by policy.json. is this correct? or how does this relate to enforcing the rest of the API? | 22:17 |
| *** andrew_plunk has joined #heat | 22:17 | |
| asalkeld | morning | 22:17 |
| stevebaker | morning | 22:17 |
| *** sgordon has quit IRC | 22:18 | |
| andersonvom | morning/afternoon/night | 22:18 |
| *** tomek_adamczewsk has quit IRC | 22:21 | |
| openstackgerrit | Steve Baker proposed a change to openstack/heat: Service authorize stack user from provided stack https://review.openstack.org/58875 | 22:29 |
| openstackgerrit | Steve Baker proposed a change to openstack/heat: OS::Nova::Server support for software config https://review.openstack.org/58880 | 22:29 |
| openstackgerrit | Steve Baker proposed a change to openstack/heat: REST API for software config/deployment https://review.openstack.org/58878 | 22:29 |
| openstackgerrit | Steve Baker proposed a change to openstack/heat: Resource types for software config/deployment https://review.openstack.org/58879 | 22:29 |
| openstackgerrit | Steve Baker proposed a change to openstack/heat: Database model for software config/deployment https://review.openstack.org/58876 | 22:29 |
| openstackgerrit | Steve Baker proposed a change to openstack/heat: RPC service for software config/deployment https://review.openstack.org/58877 | 22:29 |
| openstackgerrit | Steve Baker proposed a change to openstack/heat: Allow choice in how SignalResponder user id is stored. https://review.openstack.org/61902 | 22:29 |
| stevebaker | just a rebase | 22:29 |
| *** SergeyLukjanov has quit IRC | 22:46 | |
| *** aignatov has quit IRC | 22:49 | |
| shardy | andersonvom: Sorry my network just dropped for a while | 22:51 |
| shardy | andersonvom: So no new endpoint, we need to add policy enforcement to the existing ReST API | 22:52 |
| shardy | andersonvom: Then we can define a policy rule which is allows you to defeat the default tenant scoping, and access either different data via existing actions, or potentially some super-admin-only actions | 22:53 |
| shardy | basically the next step from https://review.openstack.org/#/c/58866/3/etc/heat/policy.json | 22:53 |
| shardy | But the issue is we currently have no policy enforcement at all in the ReST API | 22:54 |
| shardy | (we do for the cloudformation and cloudwatch compatible ones) | 22:54 |
| shardy | andersonvom: ideally, this would all coincide with a revised v2 API, which doesn't contain the tenant in the path, then it would make more sense when you do a request which gives non-tenant-scoped data back | 22:55 |
| stevebaker | shardy: should I rejig my SignalResponder change to always store user_id, access_id in resource data? | 22:56 |
| shardy | stevebaker: I posted a patch which does that yesterday | 22:56 |
| shardy | stevebaker: are we overlapping? :) | 22:56 |
| stevebaker | ooh, where? | 22:56 |
| shardy | https://review.openstack.org/#/c/62440/ | 22:56 |
| shardy | I need to rebase and remove https://review.openstack.org/#/c/62439/ from the chain, because ayoung has suggested an alternative approach which I'm in the process of writing up in a wiki page | 22:57 |
| stevebaker | ah, I'm suggesting storing user_id in resource data instead of resource_id | 22:58 |
| shardy | stevebaker: Ah, yeah I remember now, that wfm also if you need it for the software-config stuff | 23:00 |
| shardy | however | 23:00 |
| shardy | take a look at (2) here: | 23:00 |
| shardy | https://wiki.openstack.org/wiki/Heat/Blueprints/InstanceUsers | 23:00 |
| shardy | ayoung has suggested something a little different, which may solve our credentials issue in a novel way | 23:00 |
| *** dims has quit IRC | 23:01 | |
| shardy | essentially, we could create a separate heat domain in keystone, where we create a separate user for each credential we need (potentially one for every instance and signal responder) | 23:01 |
| shardy | then just use username/password and auth_token to connect to the API | 23:01 |
| *** harlowja is now known as harlowja_away | 23:02 | |
| shardy | we can retain the policy restrictions related to heat_stack_user to limit the API surface accessible, and manage the lifecycle of each user on a per resource basis | 23:02 |
| shardy | for example, we could disable the user after a waitcondition handle completes | 23:02 |
| shardy | I'm still mulling it over, but it could possibly allow us to dump a lot of trusts/oauth/ec2tokens complexity | 23:03 |
| shardy | s/dump/avoid needing | 23:03 |
| *** pablosan has quit IRC | 23:04 | |
| *** harlowja_away is now known as harlowja | 23:05 | |
| *** lsmola_ has quit IRC | 23:06 | |
| stevebaker | shardy: interesting. does that mean that the instances would need to make keystone requests for tokens? | 23:08 |
| openstackgerrit | A change was merged to openstack/heat: Prevent tempest from failing upon ActionInProgress https://review.openstack.org/62703 | 23:08 |
| shardy | stevebaker: Possibly, I was thinking they could just use python-heatclient | 23:09 |
| shardy | heat stack-signal --data "finished!" | 23:09 |
| shardy | stevebaker: And we can still support the existing mode for ec2-keypairs via heat-cfntools | 23:10 |
| stevebaker | yep, that might be worth persuing | 23:11 |
| shardy | but maybe port that to also work with normal auth and the ReST API | 23:11 |
| shardy | only the ec2-keypair will be owned by the new heat-domain-resource user, not the current user-created user | 23:11 |
| shardy | if you see what I mean ;) | 23:11 |
| shardy | I was thinking OS::Nova::Server could grow a "deploy_credentials" property, which pokes the username and randomly generated password into nova metadata | 23:12 |
| *** vijendar has quit IRC | 23:12 | |
| *** vijendar has joined #heat | 23:13 | |
| stevebaker | we could integrate that with the software config stuff | 23:14 |
| stevebaker | shardy: I could describe my option 5 in that wiki if you like | 23:15 |
| *** dims has joined #heat | 23:16 | |
| shardy | stevebaker: Sure, go for it - I've asked ayoung to take a look and update the x509 section too | 23:16 |
| *** swygue has quit IRC | 23:16 | |
| shardy | stevebaker: I've been chasing my tail a bit on this, so will be good to get all the ideas down then we can get a concrete plan | 23:16 |
| shardy | stevebaker: I started implementing (1), but the more time I spend on it, the more wrong it seemed | 23:17 |
| *** scroiset_ has quit IRC | 23:18 | |
| stevebaker | 1) looks like a real rabbit hole | 23:18 |
| sdake | shardy up late ! | 23:18 |
| shardy | stevebaker: well I've actually nearly finished implementing it, but it doesn't solve one of the main problems, which is the ec2tokens thing | 23:19 |
| shardy | stevebaker: Also the usage of trusts is kinda hairy and I might lose sleep worrying about bugs ;D | 23:19 |
| shardy | sdake: Yeah.. | 23:19 |
| *** vijendar has quit IRC | 23:20 | |
| *** sgordon has joined #heat | 23:21 | |
| *** yogesh has quit IRC | 23:22 | |
| *** scroiset has joined #heat | 23:24 | |
| *** urulama has joined #heat | 23:24 | |
| shardy | stevebaker: ayoung is going to add his stuff, then if you add yours too, I'll review in the morning and start a ML thread if needed so we can agree the plan | 23:25 |
| shardy | now, I should get some sleep ;) | 23:25 |
| shardy | night all | 23:25 |
| asalkeld | night shardy | 23:26 |
| *** shardy is now known as shardy_afk | 23:26 | |
| sdake | later shardy_afk | 23:27 |
| *** gokrokve has quit IRC | 23:28 | |
| *** urulama has quit IRC | 23:29 | |
| *** asalkeld has quit IRC | 23:29 | |
| *** asalkeld has joined #heat | 23:30 | |
| openstackgerrit | Anderson Mesquita proposed a change to openstack/heat: Check resources are in expected states https://review.openstack.org/58641 | 23:30 |
| *** IlyaE has quit IRC | 23:33 | |
| *** tims1 has quit IRC | 23:38 | |
| *** agileclipse has joined #heat | 23:38 | |
| lifeless | stevebaker: / asalkeld: btw - https://review.openstack.org/#/c/62520/ - if you have any feedback, that would be awesome | 23:38 |
| grncdr | I am writing tests for this: https://review.openstack.org/#/c/62078/ and I have a question about how to best deal with writing a test that needs to time out | 23:38 |
| lifeless | I don't cut much heat code... | 23:38 |
| asalkeld | lifeless, I'll check it out | 23:39 |
| grncdr | right now I'm stepping a heat.engine.scheduler.TaskRunner in my resources check_create_complete method, but I don't know how to tell if that will step a hundred times a second or one... | 23:39 |
| grncdr | I'm modelling my unit test off of the ones for WaitCondition | 23:40 |
| asalkeld | grncdr, we fake the sleep | 23:40 |
| stevebaker | lifeless: looking | 23:41 |
| grncdr | asalkeld: yeah I'm seeing there's a stub_wallclock method? | 23:41 |
| asalkeld | https://github.com/openstack/heat/blob/master/heat/tests/common.py#L42 | 23:42 |
| grncdr | hm, I see test_timeout now... | 23:42 |
| stevebaker | lifeless: is there some novaclient quirk wrt preserve_ephemeral=None vs False vs not specified at all? | 23:42 |
| asalkeld | also by default we disable the sleep in tests | 23:42 |
| *** andrew_plunk has quit IRC | 23:42 | |
| grncdr | I need a bigger screen. Trying to hack on OpenStack stuff on an 11" MBA is… tricky | 23:42 |
| asalkeld | lol grncdr that sounds tricky | 23:43 |
| grncdr | especially because I don't think I can even run a dev stack locally | 23:43 |
| lifeless | stevebaker: no; I just don't want to have to bump novaclient in your requirements.txt | 23:43 |
| lifeless | stevebaker: which hard depending on a new parameter would cause | 23:43 |
| stevebaker | right, so method signature has changed | 23:43 |
| lifeless | stevebaker: having to bump requirements.text would mean having to wait for a release of nova-client | 23:44 |
| grncdr | asalkeld: should I be doing something like this in my tests? https://github.com/openstack/heat/blob/master/heat/tests/test_waitcondition.py#L223 | 23:44 |
| stevebaker | lifeless: lgtm | 23:45 |
| asalkeld | grncdr, yeah | 23:45 |
| lifeless | phew, cool - thanks | 23:45 |
| asalkeld | lifeless, I'll wait for jenkins to +1 | 23:47 |
| stevebaker | lifeless: btw, I tried to trigger the migration issue with data, but it worked. Did you perchance have any stack_lock records at the time? | 23:47 |
| *** rcleere has quit IRC | 23:47 | |
| asalkeld | stevebaker, lifeless I am busy making a migration test | 23:47 |
| lifeless | stevebaker: it's a new table ... | 23:47 |
| lifeless | stevebaker: so I'm confused by your question | 23:48 |
| stevebaker | yeah, duh | 23:48 |
| * stevebaker eats words | 23:48 | |
| lifeless | I can get you a dump of our DB | 23:48 |
| lifeless | would need to sanitise it somehow | 23:48 |
| asalkeld | lifeless, yeah | 23:48 |
| asalkeld | I am right now trying to figure out waht data to put in the test | 23:49 |
| stevebaker | lifeless: what version of m(ariadb|ysql) are you running? | 23:49 |
| lifeless | ii mysql-server-core-5 5.5.32-0ubuntu | 23:49 |
| lifeless | ii mysql-server-5.5 5.5.32-0ubuntu | 23:49 |
| lifeless | presumably the contents of the FK related table is sufficient | 23:50 |
| lifeless | asalkeld: http://paste.ubuntu.com/6591689/ | 23:51 |
| lifeless | mysql heat -e 'select id from stack;' | pastebinit | 23:51 |
| asalkeld | ta | 23:51 |
| lifeless | asalkeld: and yeah, run InnoDB | 23:52 |
| lifeless | anyone running ISAM should be shot. | 23:52 |
| stevebaker | innodb is the default | 23:54 |
| *** sabeen has quit IRC | 23:55 | |
| *** faramir1 has joined #heat | 23:58 | |
| lifeless | I saw someone asking about ISAM w.r.t. this was all | 23:58 |
| *** arbylee has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
