*** arbylee has joined #heat | 00:02 | |
stevebaker | heat delete config1 | 00:06 |
---|---|---|
stevebaker | ERROR: Stack config1 already has an action (CREATE) in progress. | 00:06 |
stevebaker | that shouldn't be happening | 00:06 |
*** agileclipse has left #heat | 00:09 | |
*** spzala has joined #heat | 00:10 | |
stevebaker | https://bugs.launchpad.net/heat/+bug/1262012 | 00:11 |
uvirtbot | Launchpad bug 1262012 in heat "Cannot delete an IN_PROGRESS stack" [High,Triaged] | 00:12 |
*** jcru has quit IRC | 00:13 | |
*** cody-somerville has joined #heat | 00:14 | |
*** cody-somerville has quit IRC | 00:14 | |
*** cody-somerville has joined #heat | 00:14 | |
*** rongze has joined #heat | 00:16 | |
*** rongze has quit IRC | 00:21 | |
*** arbylee has quit IRC | 00:22 | |
*** andersonvom has quit IRC | 00:22 | |
*** arbylee has joined #heat | 00:22 | |
*** andersonvom has joined #heat | 00:22 | |
*** andersonvom has quit IRC | 00:27 | |
*** arbylee has quit IRC | 00:27 | |
*** pvaneck has quit IRC | 00:32 | |
*** jergerber has quit IRC | 00:45 | |
*** brint has quit IRC | 00:50 | |
*** yogesh has joined #heat | 01:02 | |
*** blamar has quit IRC | 01:03 | |
*** arbylee has joined #heat | 01:16 | |
spzala | stevebaker: Hi. Thanks for the email on software config progress with awesome detail. I am testing/reviewing it. | 01:16 |
*** andrewmi- has joined #heat | 01:16 | |
*** gamekiller77 has quit IRC | 01:18 | |
*** spzala has quit IRC | 01:20 | |
*** andersonvom has joined #heat | 01:20 | |
*** urulama has joined #heat | 01:25 | |
*** blamar has joined #heat | 01:26 | |
*** nosnos has joined #heat | 01:26 | |
*** urulama has quit IRC | 01:30 | |
*** spzala has joined #heat | 01:38 | |
*** sdake has quit IRC | 01:42 | |
*** sdake has joined #heat | 01:42 | |
*** sdake has quit IRC | 01:43 | |
*** sdake has joined #heat | 01:43 | |
*** yogesh has quit IRC | 01:43 | |
*** AndrewMichalik has joined #heat | 01:45 | |
*** cody-somerville has quit IRC | 01:48 | |
*** agileclipse has joined #heat | 01:50 | |
*** jomara has quit IRC | 02:00 | |
*** jomara has joined #heat | 02:00 | |
*** guohliu has joined #heat | 02:03 | |
*** AndrewMichalik has quit IRC | 02:07 | |
sdake_ | hardwiring internet is so much fun in a brick house | 02:08 |
sdake_ | thank god for hammer drills | 02:08 |
openstackgerrit | Angus Salkeld proposed a change to openstack/heat: Add migration test framework https://review.openstack.org/62796 | 02:10 |
asalkeld | lifeless, I can't get this data to fail ^ | 02:10 |
lifeless | asalkeld: word | 02:11 |
*** arbylee has quit IRC | 02:11 | |
asalkeld | https://review.openstack.org/#/c/62796/1/heat/tests/db/test_migrations.py | 02:11 |
asalkeld | this is testing sqlite and mysql | 02:11 |
lifeless | mysql> CREATE TABLE stack_lock ( stack_id VARCHAR(36) NOT NULL, created_at DATETIME, updated_at DATETIME, engine_id VARCHAR(36), PRIMARY KEY (stack_id), FOREIGN KEY(stack_id) REFERENCES stack (id) )ENGINE=InnoDB CHARSET=utf8; | 02:11 |
lifeless | ERROR 1005 (HY000): Can't create table 'heat.stack_lock' (errno: 150) | 02:11 |
*** gokrokve has joined #heat | 02:12 | |
asalkeld | can you have a quick look at my test? | 02:12 |
lifeless | seems plausible | 02:13 |
asalkeld | really irritating that the test doen't fail | 02:14 |
lifeless | http://paste.openstack.org/show/55244/ | 02:14 |
lifeless | current schema | 02:14 |
*** rongze has joined #heat | 02:14 | |
zaneb | lifeless: errno 150 means a problem with foreign keys... | 02:17 |
zaneb | lifeless: http://stackoverflow.com/a/18180299 <- how to get the real error message | 02:18 |
zaneb | ooh | 02:19 |
zaneb | http://www.eliacom.com/mysql-gui-wp-errno-150.php | 02:19 |
lifeless | https://bugs.launchpad.net/heat/+bug/1261605 - last comment | 02:20 |
uvirtbot | Launchpad bug 1261605 in heat "migration 30 -> 31 (031_stack_lock) fails" [Critical,In progress] | 02:20 |
*** blomquisg has quit IRC | 02:22 | |
stevebaker | spzala: good to hear | 02:38 |
spzala | stevebaker: :-) sure. | 02:38 |
*** erkules_ has joined #heat | 02:41 | |
*** erkules has quit IRC | 02:44 | |
*** yogesh has joined #heat | 02:54 | |
*** vkozhukalov has joined #heat | 02:54 | |
*** yogesh has quit IRC | 02:58 | |
*** bobzhang_ has joined #heat | 03:00 | |
*** rongze has quit IRC | 03:02 | |
*** nati_uen_ has quit IRC | 03:04 | |
*** swygue has joined #heat | 03:07 | |
*** rongze has joined #heat | 03:10 | |
*** blak111 has quit IRC | 03:25 | |
*** urulama has joined #heat | 03:26 | |
*** urulama has quit IRC | 03:31 | |
*** giulivo has quit IRC | 03:33 | |
*** slong has joined #heat | 03:34 | |
asalkeld | lifeless, http://paste.openstack.org/show/55253/ | 03:41 |
asalkeld | that ^ works for me | 03:41 |
*** bobzhang_ has quit IRC | 03:45 | |
*** ccs has joined #heat | 03:47 | |
*** harlowja is now known as harlowja_away | 03:51 | |
*** IlyaE has joined #heat | 03:55 | |
*** IlyaE has quit IRC | 03:57 | |
*** dguerri has quit IRC | 03:59 | |
*** rcleere has joined #heat | 04:00 | |
*** IlyaE has joined #heat | 04:00 | |
*** IlyaE has quit IRC | 04:02 | |
*** liang has joined #heat | 04:03 | |
*** dguerri has joined #heat | 04:05 | |
*** bobzhang_ has joined #heat | 04:12 | |
*** chandankumar has joined #heat | 04:15 | |
*** bobzhang_ has quit IRC | 04:22 | |
*** slong has quit IRC | 04:24 | |
spzala | stevebaker: need some help. Can you please take a look at the link when you get a chance? - http://fpaste.org/62725/13873406/ | 04:24 |
*** slong has joined #heat | 04:24 | |
*** ccs has quit IRC | 04:24 | |
*** ccs has joined #heat | 04:29 | |
*** topol has joined #heat | 04:29 | |
SpamapS | stevebaker: BTW in the tripleo CD cloud we've started doing stack-update instead of delete/create .. so now if the stack create or update fails.. no retry == manual intervention == annoyed SpamapS | 04:29 |
SpamapS | stevebaker: so that should motivate me to solve the retry problem soonish :) | 04:29 |
*** ccs has quit IRC | 04:31 | |
*** ccs has joined #heat | 04:32 | |
*** radez is now known as radez_g0n3 | 04:34 | |
stevebaker | spzala: are you running neutron or nova networking? | 04:36 |
stevebaker | SpamapS: yeah, update would be super useful were it not for that | 04:36 |
*** guohliu has quit IRC | 04:36 | |
spzala | stevebaker: it's nova | 04:37 |
stevebaker | spzala: that template has a neutron security group | 04:38 |
SpamapS | stevebaker: pretty straight forward.. just have to replace failed resources. | 04:38 |
spzala | stevebaker: ahh, I see | 04:39 |
*** akuznetsov has joined #heat | 04:40 | |
spzala | stevebaker: Thanks!! I will try it with neutron. | 04:43 |
stevebaker | spzala: or just switch the template to use the ec2 security group | 04:44 |
spzala | stevebaker: Cool. That's definitely better | 04:46 |
*** rongze has quit IRC | 04:59 | |
openstackgerrit | Stephen Sugden proposed a change to openstack/heat: Add PortCheck resource https://review.openstack.org/62078 | 05:06 |
*** rushiagr has joined #heat | 05:11 | |
*** nkhare has joined #heat | 05:12 | |
*** yogesh has joined #heat | 05:16 | |
*** xuan has joined #heat | 05:21 | |
*** SergeyLukjanov has joined #heat | 05:24 | |
*** guohliu has joined #heat | 05:26 | |
*** spzala has quit IRC | 05:27 | |
*** urulama has joined #heat | 05:27 | |
*** rongze has joined #heat | 05:30 | |
*** sdake_ has quit IRC | 05:31 | |
*** urulama has quit IRC | 05:32 | |
*** rongze has quit IRC | 05:35 | |
sergmelikyan | Does someone here used pydev debugger with heat? | 05:41 |
*** rcleere has quit IRC | 05:44 | |
*** slong has quit IRC | 05:50 | |
*** nati_ueno has joined #heat | 05:51 | |
*** slong has joined #heat | 05:54 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 05:56 | |
*** _SergeyLukjanov has quit IRC | 05:56 | |
*** gokrokve has quit IRC | 05:57 | |
*** gokrokve has joined #heat | 05:58 | |
*** rushiagr has quit IRC | 05:58 | |
*** gokrokve_ has joined #heat | 05:58 | |
stevebaker | sergmelikyan: only for unit tests | 06:01 |
openstackgerrit | Stephen Sugden proposed a change to openstack/heat: Add PortCheck resource https://review.openstack.org/62078 | 06:01 |
* sergmelikyan usually using PyCharm IDE for developing on python, that use pydev debugger for debugging | 06:02 | |
*** gokrokve_ has quit IRC | 06:02 | |
*** gokrokve has quit IRC | 06:02 | |
sergmelikyan | stevebaker, I have some issues with viewing frames - could not extract current scope variables | 06:03 |
*** xuan is now known as xuan-afk | 06:04 | |
openstackgerrit | Jenkins proposed a change to openstack/heat: Imported Translations from Transifex https://review.openstack.org/62551 | 06:06 |
stevebaker | sergmelikyan: I'm not sure, it just works for me | 06:06 |
sergmelikyan | I had simple setup with running pycharm on local machine and clean devstack on vm. | 06:06 |
sergmelikyan | When trying to create simple stack, I stack with AuthenticationFailed error | 06:07 |
sergmelikyan | https://github.com/openstack/heat/blob/master/heat/engine/clients.py#L122 | 06:07 |
sergmelikyan | This line while executed no matter what uses 2.0 client for authentication | 06:07 |
*** rongze has joined #heat | 06:08 | |
sergmelikyan | http://paste.openstack.org/show/55267/ - traceback | 06:08 |
*** nkhare has quit IRC | 06:11 | |
*** SergeyLukjanov has joined #heat | 06:12 | |
*** radix_ has quit IRC | 06:13 | |
*** vkozhukalov has quit IRC | 06:15 | |
*** vkozhukalov has joined #heat | 06:15 | |
lifeless | asalkeld: by works-for-you do you mean makes-the-test-fail? | 06:17 |
asalkeld | no, just to clean up you db dump | 06:17 |
asalkeld | it's wipes the parameters | 06:17 |
lifeless | oh right | 06:18 |
lifeless | ah we have stuff in event - access keys etc | 06:19 |
*** sgordon has quit IRC | 06:19 | |
asalkeld | it's easy to add to that script | 06:19 |
asalkeld | you could just drop the event table | 06:20 |
lifeless | + secret_access_keys in resources | 06:20 |
asalkeld | I don't need it | 06:20 |
lifeless | ok, just the stack table? | 06:20 |
asalkeld | stack and template and creds | 06:20 |
asalkeld | stack + foriegn keyed tables | 06:20 |
lifeless | do you mean raw_template? | 06:21 |
*** radix_ has joined #heat | 06:21 | |
asalkeld | yip | 06:21 |
asalkeld | you could kill the actual template | 06:21 |
asalkeld | I just want valid references | 06:21 |
openstackgerrit | Angus Salkeld proposed a change to openstack/heat: Add migration test framework https://review.openstack.org/62796 | 06:24 |
asalkeld | lifeless, this ^test now takes a sql dump | 06:24 |
asalkeld | so you can see if it is reproducable by moving your sql dump to: heat/tests/db/pre_031_data.sql | 06:25 |
*** topol has quit IRC | 06:26 | |
*** xuan-afk is now known as xuan | 06:26 | |
lifeless | asalkeld: I think I've sanitised, sec while I pull it down | 06:28 |
lifeless | asalkeld: what gpg key do you want it crypted to? | 06:28 |
asalkeld | can you get at my github public key? | 06:29 |
lifeless | please wait while subkeys.pgp.net goes slow | 06:30 |
asalkeld | lifeless, emailed you my pub key | 06:32 |
*** gokrokve has joined #heat | 06:33 | |
*** nkhare has joined #heat | 06:33 | |
*** fsargent has left #heat | 06:33 | |
*** gokrokve_ has joined #heat | 06:35 | |
lifeless | asalkeld: lol, thats ssh | 06:36 |
lifeless | asalkeld: t | 06:37 |
lifeless | (1) Angus Salkeld <asalkeld@redhat.com> | 06:37 |
lifeless | 2048 bit RSA key CA8CF34A, created: 2010-03-15 | 06:37 |
lifeless | asalkeld: you ? | 06:37 |
asalkeld | doh | 06:37 |
asalkeld | yeah, that's me | 06:37 |
*** gokrokve has quit IRC | 06:38 | |
asalkeld | you can see I use gpg all day - not | 06:38 |
*** gokrokve_ has quit IRC | 06:40 | |
*** rwsu_ has quit IRC | 06:41 | |
*** Seal has joined #heat | 06:43 | |
*** andersonvom has quit IRC | 06:46 | |
*** Seal has quit IRC | 06:47 | |
lifeless | asalkeld: well, lets see if you can decrypt it ;> | 06:48 |
asalkeld | trying to see if I can even find the private key :( | 06:48 |
asalkeld | ga | 06:48 |
SpamapS | lifeless: converge is expensive | 06:49 |
*** amritanshu_RnD has joined #heat | 06:49 | |
lifeless | what makes it expensive? | 06:49 |
SpamapS | lifeless: big stack.. you're going to bombard all of the resources with status updates from their respective API's. | 06:49 |
SpamapS | That's the thinking anyway. | 06:50 |
SpamapS | Update is "I know I want to make this change" | 06:50 |
lifeless | SpamapS: async examination of reality | 06:50 |
lifeless | SpamapS: did you see the etherpad about how I'd be inclined to tackle it? | 06:51 |
SpamapS | Yes | 06:51 |
lifeless | cool | 06:51 |
SpamapS | And I championed that cause last week. | 06:51 |
lifeless | \o/ | 06:51 |
SpamapS | Rejected.. "Background threads are bad" | 06:51 |
SpamapS | "Users can ask for it if they want it." | 06:51 |
*** vkozhukalov has quit IRC | 06:52 | |
lifeless | wtf | 06:52 |
lifeless | heats entire operation is a background thread | 06:52 |
lifeless | that argument makes no sense to me | 06:52 |
SpamapS | lifeless: AFAICT, what will happen is users will have a cron job which pokes Heat to update its' view of reality because we don't want to have such cron jobs in heat-engine. | 06:52 |
lifeless | that seems disasterous | 06:52 |
*** IlyaE has joined #heat | 06:53 | |
asalkeld | bbl, picking kids up | 06:53 |
lifeless | I predict large clouds adding a feature to delay such requests | 06:53 |
SpamapS | lifeless: I don't think it is disasterous, but I do think we could just let Heat do it without the user having to ask. | 06:53 |
lifeless | on thebasis that everyone cronning them at 5m intervals leads to thundering herd problems | 06:54 |
SpamapS | lifeless: You can't ask for two at one time on a single stack.. | 06:54 |
SpamapS | lifeless: anyway, update is not going to turn into converge without a proposal. I think it is fine the way it is. You are more than welcome to present evidence to the contrary. | 06:54 |
lifeless | what evidence would be sufficient? | 06:55 |
*** dims has quit IRC | 06:55 | |
SpamapS | Dunno. I really think they are two wildly different things with valid use cases. | 06:55 |
lifeless | ok, so we can circle back to it | 06:57 |
lifeless | what i really care about is that we're now going to have to write code | 06:57 |
lifeless | to query glance | 06:57 |
lifeless | to figure out the image id for the image we name | 06:57 |
lifeless | can we put that in the template at least? | 06:57 |
lifeless | so that we'll get 'converge' on 'update' ? | 06:57 |
SpamapS | I totally think that we should have a way for Heat to subscribe to notifications and/or poll at its own pace for status of background resources. But think that resolving reality with the stack is different than resolving the difference between two templates. | 06:57 |
lifeless | SpamapS: I beg to differ, but now is not the time for that discussion. | 06:58 |
*** Tross has quit IRC | 06:58 | |
lifeless | SpamapS: I think you will come around to my opinion when you finish making robust rolling upgrades a reality ;) | 06:58 |
lifeless | SpamapS: and are tired of writing bash loops that go while failed hit it again; fi | 06:58 |
SpamapS | lifeless: we should add Glance resources to Heat that allow querying the ID associated with a name. That would work. | 06:59 |
*** rushiagr has joined #heat | 07:00 | |
lifeless | is that a heat bug, or a tripleo-heat-template bug? | 07:00 |
SpamapS | both | 07:00 |
SpamapS | Heat should be able to orchestrate the glance API, and t-h-t should take advantage of that. | 07:00 |
lifeless | how easy is it? | 07:01 |
SpamapS | lifeless: quite. I'm already through the boilerplate ;) | 07:01 |
lifeless | cool, thanks | 07:01 |
sergmelikyan | Desperately need some help :( Stack: http://paste.openstack.org/show/55269 Traceback: http://paste.openstack.org/show/55268 | 07:02 |
sergmelikyan | DevStack + local Heat | 07:03 |
sergmelikyan | Heat.conf: http://paste.openstack.org/show/55270 | 07:03 |
*** akuznetsov has quit IRC | 07:08 | |
*** rushiagr2 has joined #heat | 07:11 | |
*** rushiagr3 has joined #heat | 07:13 | |
*** rushiagr has quit IRC | 07:13 | |
*** SergeyLukjanov has quit IRC | 07:14 | |
*** Tross has joined #heat | 07:16 | |
openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Avoid using python build-in class property https://review.openstack.org/62814 | 07:17 |
*** rushiagr2 has quit IRC | 07:17 | |
skraynev | morning | 07:17 |
openstackgerrit | A change was merged to openstack/heat: Don't pass swift headers as None https://review.openstack.org/62199 | 07:19 |
sergmelikyan | May be something is misconfigured? | 07:25 |
*** urulama has joined #heat | 07:28 | |
*** yogesh has quit IRC | 07:29 | |
*** yogesh has joined #heat | 07:30 | |
*** urulama has quit IRC | 07:32 | |
*** gokrokve has joined #heat | 07:36 | |
sergmelikyan | Found my issue... https://answers.launchpad.net/heat/+question/238879 | 07:37 |
*** ccs has quit IRC | 07:37 | |
*** urulama has joined #heat | 07:37 | |
sergmelikyan | Adding auth_uri solved problem | 07:37 |
*** aignatov has joined #heat | 07:38 | |
*** ccs has joined #heat | 07:38 | |
*** gokrokve has quit IRC | 07:40 | |
*** erkules_ is now known as erkules | 07:42 | |
*** dims_ has joined #heat | 07:43 | |
*** bgorski has joined #heat | 07:48 | |
*** swygue has quit IRC | 07:50 | |
openstackgerrit | A change was merged to openstack/heat: Add support for rebuild --preserve-ephemeral. https://review.openstack.org/62520 | 07:54 |
*** erkules has quit IRC | 07:58 | |
*** yogesh has quit IRC | 07:59 | |
*** yogesh has joined #heat | 08:02 | |
asalkeld | lifeless, I have totally lost that private key, is there any reason to encrypt it, given that we have removed the passwords? | 08:03 |
*** IlyaE has quit IRC | 08:04 | |
*** rushiagr3 has quit IRC | 08:13 | |
*** rushiagr3 has joined #heat | 08:18 | |
*** Seal has joined #heat | 08:20 | |
*** Seal has quit IRC | 08:22 | |
*** SushilKM has joined #heat | 08:22 | |
*** shardy_afk is now known as shardy | 08:24 | |
shardy | morning | 08:24 |
*** rushiagr3 has quit IRC | 08:26 | |
*** rushiagr has joined #heat | 08:26 | |
*** yogesh has quit IRC | 08:27 | |
*** yogesh has joined #heat | 08:27 | |
bgorski | morning | 08:30 |
*** vkozhukalov has joined #heat | 08:31 | |
*** SergeyLukjanov has joined #heat | 08:32 | |
*** yogesh has quit IRC | 08:36 | |
*** yogesh has joined #heat | 08:36 | |
*** gokrokve has joined #heat | 08:36 | |
*** yogesh has quit IRC | 08:38 | |
*** yogesh has joined #heat | 08:38 | |
*** ifarkas has joined #heat | 08:39 | |
*** gokrokve has quit IRC | 08:41 | |
openstackgerrit | Bartosz Górski proposed a change to openstack/heat: Add an external gateway property to neutron router https://review.openstack.org/60118 | 08:43 |
*** akuznetsov has joined #heat | 08:44 | |
openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Remove unused variable td https://review.openstack.org/62827 | 08:48 |
*** swygue has joined #heat | 08:51 | |
openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Removed unused variables https://review.openstack.org/62827 | 08:59 |
*** ccs has quit IRC | 09:10 | |
*** urulama has quit IRC | 09:10 | |
*** guohliu has quit IRC | 09:10 | |
*** asalkeld has quit IRC | 09:10 | |
*** rpothier_ has quit IRC | 09:10 | |
*** jomara has quit IRC | 09:10 | |
*** dmakogon_ has quit IRC | 09:10 | |
*** stannie has quit IRC | 09:10 | |
*** Andrzej has quit IRC | 09:11 | |
*** openstackgerrit has quit IRC | 09:11 | |
*** radix has quit IRC | 09:11 | |
*** yogesh has quit IRC | 09:11 | |
*** vkozhukalov has quit IRC | 09:11 | |
*** bgorski has quit IRC | 09:11 | |
*** sdake has quit IRC | 09:11 | |
*** scollier has quit IRC | 09:11 | |
*** pscheie__ has quit IRC | 09:11 | |
*** zigo has quit IRC | 09:11 | |
*** Adri2000 has quit IRC | 09:11 | |
*** larsks|phone_ has quit IRC | 09:11 | |
*** john-n-seattle has quit IRC | 09:11 | |
*** nati_ueno has quit IRC | 09:11 | |
*** xuan has quit IRC | 09:11 | |
*** blamar has quit IRC | 09:11 | |
*** dims_ has quit IRC | 09:11 | |
*** Tross has quit IRC | 09:11 | |
*** jpeeler has quit IRC | 09:11 | |
*** pleia2 has quit IRC | 09:11 | |
*** al-maisan has quit IRC | 09:11 | |
*** SpamapS has quit IRC | 09:11 | |
*** hub_cap has quit IRC | 09:11 | |
*** lazzurs has quit IRC | 09:11 | |
*** metabro_ has quit IRC | 09:11 | |
*** chmouel has quit IRC | 09:11 | |
*** Daviey has quit IRC | 09:11 | |
*** stevebaker has quit IRC | 09:11 | |
*** nosnos has quit IRC | 09:11 | |
*** faramir1 has quit IRC | 09:11 | |
*** scroiset has quit IRC | 09:11 | |
*** pasquier-s has quit IRC | 09:11 | |
*** shadower has quit IRC | 09:11 | |
*** obondarev has quit IRC | 09:11 | |
*** harlowja_away has quit IRC | 09:11 | |
*** lifeless has quit IRC | 09:11 | |
*** rushiagr has quit IRC | 09:11 | |
*** nkhare has quit IRC | 09:11 | |
*** shardy has quit IRC | 09:11 | |
*** sirushti has quit IRC | 09:11 | |
*** skraynev has quit IRC | 09:11 | |
*** isviridov has quit IRC | 09:11 | |
*** gondoi has quit IRC | 09:11 | |
*** chandankumar has quit IRC | 09:11 | |
*** dguerri has quit IRC | 09:11 | |
*** TonyBurn1 has quit IRC | 09:11 | |
*** jasond` has quit IRC | 09:11 | |
*** grncdr has quit IRC | 09:11 | |
*** john-n-s| has quit IRC | 09:11 | |
*** swygue has quit IRC | 09:11 | |
*** akuznetsov has quit IRC | 09:11 | |
*** SergeyLukjanov has quit IRC | 09:11 | |
*** aignatov has quit IRC | 09:11 | |
*** amritanshu_RnD has quit IRC | 09:11 | |
*** rongze has quit IRC | 09:11 | |
*** liang has quit IRC | 09:11 | |
*** larsks has quit IRC | 09:11 | |
*** sgran has quit IRC | 09:11 | |
*** leseb has quit IRC | 09:11 | |
*** uvirtbot has quit IRC | 09:11 | |
*** DandyPandy has quit IRC | 09:11 | |
*** radez_g0n3 has quit IRC | 09:11 | |
*** agileclipse has quit IRC | 09:11 | |
*** mordred has quit IRC | 09:11 | |
*** lekha has quit IRC | 09:11 | |
*** PhilK has quit IRC | 09:11 | |
*** kebray has quit IRC | 09:11 | |
*** sileht has quit IRC | 09:11 | |
*** wirehead_ has quit IRC | 09:11 | |
*** DaveJ_ has quit IRC | 09:11 | |
*** EmilienM has quit IRC | 09:11 | |
*** russellb has quit IRC | 09:11 | |
*** christophk has quit IRC | 09:11 | |
*** clarkb has quit IRC | 09:11 | |
*** Ng has quit IRC | 09:11 | |
*** mikal has quit IRC | 09:11 | |
*** ogelbukh has quit IRC | 09:11 | |
*** jhurlbert has quit IRC | 09:11 | |
*** samkottler has quit IRC | 09:11 | |
*** nijaba has quit IRC | 09:11 | |
*** ifarkas has quit IRC | 09:11 | |
*** SushilKM has quit IRC | 09:11 | |
*** radix_ has quit IRC | 09:11 | |
*** slong has quit IRC | 09:11 | |
*** zaneb has quit IRC | 09:11 | |
*** bnemec has quit IRC | 09:11 | |
*** ChanServ has quit IRC | 09:11 | |
*** sergmelikyan has quit IRC | 09:11 | |
*** andrewmi- has quit IRC | 09:11 | |
*** therve has quit IRC | 09:11 | |
*** erkules has joined #heat | 09:12 | |
*** swygue has joined #heat | 09:12 | |
*** akuznetsov has joined #heat | 09:12 | |
*** ifarkas has joined #heat | 09:12 | |
*** yogesh has joined #heat | 09:12 | |
*** SergeyLukjanov has joined #heat | 09:12 | |
*** vkozhukalov has joined #heat | 09:12 | |
*** rushiagr has joined #heat | 09:12 | |
*** SushilKM has joined #heat | 09:12 | |
*** bgorski has joined #heat | 09:12 | |
*** dims_ has joined #heat | 09:12 | |
*** ccs has joined #heat | 09:12 | |
*** aignatov has joined #heat | 09:12 | |
*** urulama has joined #heat | 09:12 | |
*** Tross has joined #heat | 09:12 | |
*** amritanshu_RnD has joined #heat | 09:12 | |
*** nkhare has joined #heat | 09:12 | |
*** radix_ has joined #heat | 09:12 | |
*** rongze has joined #heat | 09:12 | |
*** slong has joined #heat | 09:12 | |
*** nati_ueno has joined #heat | 09:12 | |
*** guohliu has joined #heat | 09:12 | |
*** xuan has joined #heat | 09:12 | |
*** chandankumar has joined #heat | 09:12 | |
*** dguerri has joined #heat | 09:12 | |
*** liang has joined #heat | 09:12 | |
*** jomara has joined #heat | 09:12 | |
*** agileclipse has joined #heat | 09:12 | |
*** sdake has joined #heat | 09:12 | |
*** nosnos has joined #heat | 09:12 | |
*** blamar has joined #heat | 09:12 | |
*** andrewmi- has joined #heat | 09:12 | |
*** faramir1 has joined #heat | 09:12 | |
*** asalkeld has joined #heat | 09:12 | |
*** scroiset has joined #heat | 09:12 | |
*** rpothier_ has joined #heat | 09:12 | |
*** dmakogon_ has joined #heat | 09:12 | |
*** Andrzej has joined #heat | 09:12 | |
*** stannie has joined #heat | 09:12 | |
*** scollier has joined #heat | 09:12 | |
*** zaneb has joined #heat | 09:12 | |
*** sergmelikyan has joined #heat | 09:12 | |
*** gondoi has joined #heat | 09:12 | |
*** openstackgerrit has joined #heat | 09:12 | |
*** bnemec has joined #heat | 09:12 | |
*** shardy has joined #heat | 09:12 | |
*** mordred has joined #heat | 09:12 | |
*** lazzurs has joined #heat | 09:12 | |
*** radix has joined #heat | 09:12 | |
*** stevebaker has joined #heat | 09:12 | |
*** hub_cap has joined #heat | 09:12 | |
*** SpamapS has joined #heat | 09:12 | |
*** al-maisan has joined #heat | 09:12 | |
*** pleia2 has joined #heat | 09:12 | |
*** jpeeler has joined #heat | 09:12 | |
*** pscheie__ has joined #heat | 09:12 | |
*** zigo has joined #heat | 09:12 | |
*** Adri2000 has joined #heat | 09:12 | |
*** larsks|phone_ has joined #heat | 09:12 | |
*** john-n-seattle has joined #heat | 09:12 | |
*** chmouel has joined #heat | 09:12 | |
*** metabro_ has joined #heat | 09:12 | |
*** Daviey has joined #heat | 09:12 | |
*** pasquier-s has joined #heat | 09:12 | |
*** TonyBurn1 has joined #heat | 09:12 | |
*** sirushti has joined #heat | 09:12 | |
*** skraynev has joined #heat | 09:12 | |
*** ogelbukh has joined #heat | 09:12 | |
*** shadower has joined #heat | 09:12 | |
*** obondarev has joined #heat | 09:12 | |
*** harlowja_away has joined #heat | 09:12 | |
*** lifeless has joined #heat | 09:12 | |
*** jhurlbert has joined #heat | 09:12 | |
*** jasond` has joined #heat | 09:12 | |
*** grncdr has joined #heat | 09:12 | |
*** john-n-s| has joined #heat | 09:12 | |
*** clarkb has joined #heat | 09:12 | |
*** lekha has joined #heat | 09:12 | |
*** PhilK has joined #heat | 09:12 | |
*** kebray has joined #heat | 09:12 | |
*** isviridov has joined #heat | 09:12 | |
*** larsks has joined #heat | 09:12 | |
*** sileht has joined #heat | 09:12 | |
*** samkottler has joined #heat | 09:12 | |
*** wirehead_ has joined #heat | 09:12 | |
*** therve has joined #heat | 09:12 | |
*** DaveJ_ has joined #heat | 09:12 | |
*** sgran has joined #heat | 09:12 | |
*** Ng has joined #heat | 09:12 | |
*** leseb has joined #heat | 09:12 | |
*** uvirtbot has joined #heat | 09:12 | |
*** EmilienM has joined #heat | 09:12 | |
*** russellb has joined #heat | 09:12 | |
*** DandyPandy has joined #heat | 09:12 | |
*** radez_g0n3 has joined #heat | 09:12 | |
*** mikal has joined #heat | 09:12 | |
*** christophk has joined #heat | 09:12 | |
*** nijaba has joined #heat | 09:12 | |
*** ChanServ has joined #heat | 09:12 | |
*** hobana.freenode.net sets mode: +o ChanServ | 09:12 | |
*** ccs has quit IRC | 09:16 | |
*** urulama has quit IRC | 09:16 | |
*** guohliu has quit IRC | 09:16 | |
*** asalkeld has quit IRC | 09:16 | |
*** rpothier_ has quit IRC | 09:16 | |
*** jomara has quit IRC | 09:16 | |
*** dmakogon_ has quit IRC | 09:16 | |
*** stannie has quit IRC | 09:16 | |
*** Andrzej has quit IRC | 09:16 | |
*** openstackgerrit has quit IRC | 09:16 | |
*** radix has quit IRC | 09:16 | |
*** yogesh has quit IRC | 09:16 | |
*** vkozhukalov has quit IRC | 09:16 | |
*** bgorski has quit IRC | 09:16 | |
*** sdake has quit IRC | 09:16 | |
*** scollier has quit IRC | 09:16 | |
*** pscheie__ has quit IRC | 09:16 | |
*** zigo has quit IRC | 09:16 | |
*** Adri2000 has quit IRC | 09:16 | |
*** larsks|phone_ has quit IRC | 09:16 | |
*** john-n-seattle has quit IRC | 09:16 | |
*** nati_ueno has quit IRC | 09:16 | |
*** xuan has quit IRC | 09:16 | |
*** blamar has quit IRC | 09:16 | |
*** dims_ has quit IRC | 09:16 | |
*** Tross has quit IRC | 09:16 | |
*** jpeeler has quit IRC | 09:16 | |
*** pleia2 has quit IRC | 09:16 | |
*** al-maisan has quit IRC | 09:16 | |
*** SpamapS has quit IRC | 09:16 | |
*** hub_cap has quit IRC | 09:16 | |
*** lazzurs has quit IRC | 09:16 | |
*** metabro_ has quit IRC | 09:16 | |
*** chmouel has quit IRC | 09:16 | |
*** Daviey has quit IRC | 09:16 | |
*** stevebaker has quit IRC | 09:16 | |
*** erkules has quit IRC | 09:16 | |
*** nosnos has quit IRC | 09:16 | |
*** faramir1 has quit IRC | 09:16 | |
*** scroiset has quit IRC | 09:16 | |
*** pasquier-s has quit IRC | 09:16 | |
*** shadower has quit IRC | 09:16 | |
*** obondarev has quit IRC | 09:16 | |
*** harlowja_away has quit IRC | 09:16 | |
*** lifeless has quit IRC | 09:16 | |
*** rushiagr has quit IRC | 09:16 | |
*** nkhare has quit IRC | 09:16 | |
*** shardy has quit IRC | 09:16 | |
*** sirushti has quit IRC | 09:16 | |
*** skraynev has quit IRC | 09:16 | |
*** isviridov has quit IRC | 09:16 | |
*** gondoi has quit IRC | 09:16 | |
*** chandankumar has quit IRC | 09:16 | |
*** dguerri has quit IRC | 09:16 | |
*** TonyBurn1 has quit IRC | 09:16 | |
*** jasond` has quit IRC | 09:16 | |
*** grncdr has quit IRC | 09:16 | |
*** john-n-s| has quit IRC | 09:16 | |
*** swygue has quit IRC | 09:16 | |
*** akuznetsov has quit IRC | 09:16 | |
*** SergeyLukjanov has quit IRC | 09:16 | |
*** aignatov has quit IRC | 09:16 | |
*** amritanshu_RnD has quit IRC | 09:16 | |
*** rongze has quit IRC | 09:16 | |
*** liang has quit IRC | 09:16 | |
*** larsks has quit IRC | 09:16 | |
*** sgran has quit IRC | 09:16 | |
*** leseb has quit IRC | 09:16 | |
*** uvirtbot has quit IRC | 09:16 | |
*** DandyPandy has quit IRC | 09:16 | |
*** radez_g0n3 has quit IRC | 09:16 | |
*** agileclipse has quit IRC | 09:16 | |
*** mordred has quit IRC | 09:16 | |
*** lekha has quit IRC | 09:16 | |
*** PhilK has quit IRC | 09:16 | |
*** kebray has quit IRC | 09:16 | |
*** sileht has quit IRC | 09:16 | |
*** wirehead_ has quit IRC | 09:16 | |
*** DaveJ_ has quit IRC | 09:16 | |
*** EmilienM has quit IRC | 09:16 | |
*** russellb has quit IRC | 09:16 | |
*** christophk has quit IRC | 09:16 | |
*** clarkb has quit IRC | 09:16 | |
*** Ng has quit IRC | 09:16 | |
*** mikal has quit IRC | 09:16 | |
*** ogelbukh has quit IRC | 09:16 | |
*** jhurlbert has quit IRC | 09:16 | |
*** samkottler has quit IRC | 09:16 | |
*** nijaba has quit IRC | 09:16 | |
*** ifarkas has quit IRC | 09:16 | |
*** SushilKM has quit IRC | 09:16 | |
*** radix_ has quit IRC | 09:16 | |
*** slong has quit IRC | 09:16 | |
*** zaneb has quit IRC | 09:16 | |
*** bnemec has quit IRC | 09:16 | |
*** ChanServ has quit IRC | 09:17 | |
*** sergmelikyan has quit IRC | 09:17 | |
*** andrewmi- has quit IRC | 09:17 | |
*** therve has quit IRC | 09:17 | |
*** derekh has joined #heat | 09:22 | |
*** erkules has joined #heat | 09:22 | |
*** swygue has joined #heat | 09:22 | |
*** akuznetsov has joined #heat | 09:22 | |
*** ifarkas has joined #heat | 09:22 | |
*** yogesh has joined #heat | 09:22 | |
*** SergeyLukjanov has joined #heat | 09:22 | |
*** vkozhukalov has joined #heat | 09:22 | |
*** rushiagr has joined #heat | 09:22 | |
*** SushilKM has joined #heat | 09:22 | |
*** bgorski has joined #heat | 09:22 | |
*** dims_ has joined #heat | 09:22 | |
*** ccs has joined #heat | 09:22 | |
*** aignatov has joined #heat | 09:22 | |
*** urulama has joined #heat | 09:22 | |
*** Tross has joined #heat | 09:22 | |
*** amritanshu_RnD has joined #heat | 09:22 | |
*** nkhare has joined #heat | 09:22 | |
*** radix_ has joined #heat | 09:22 | |
*** rongze has joined #heat | 09:22 | |
*** slong has joined #heat | 09:22 | |
*** nati_ueno has joined #heat | 09:22 | |
*** guohliu has joined #heat | 09:22 | |
*** xuan has joined #heat | 09:22 | |
*** chandankumar has joined #heat | 09:22 | |
*** dguerri has joined #heat | 09:22 | |
*** liang has joined #heat | 09:22 | |
*** jomara has joined #heat | 09:22 | |
*** agileclipse has joined #heat | 09:22 | |
*** sdake has joined #heat | 09:22 | |
*** nosnos has joined #heat | 09:22 | |
*** blamar has joined #heat | 09:22 | |
*** andrewmi- has joined #heat | 09:22 | |
*** faramir1 has joined #heat | 09:22 | |
*** asalkeld has joined #heat | 09:22 | |
*** scroiset has joined #heat | 09:22 | |
*** rpothier_ has joined #heat | 09:22 | |
*** dmakogon_ has joined #heat | 09:22 | |
*** Andrzej has joined #heat | 09:22 | |
*** stannie has joined #heat | 09:22 | |
*** scollier has joined #heat | 09:22 | |
*** zaneb has joined #heat | 09:22 | |
*** sergmelikyan has joined #heat | 09:22 | |
*** gondoi has joined #heat | 09:22 | |
*** openstackgerrit has joined #heat | 09:22 | |
*** bnemec has joined #heat | 09:22 | |
*** shardy has joined #heat | 09:22 | |
*** mordred has joined #heat | 09:22 | |
*** lazzurs has joined #heat | 09:22 | |
*** radix has joined #heat | 09:22 | |
*** stevebaker has joined #heat | 09:22 | |
*** hub_cap has joined #heat | 09:22 | |
*** SpamapS has joined #heat | 09:22 | |
*** al-maisan has joined #heat | 09:22 | |
*** pleia2 has joined #heat | 09:22 | |
*** jpeeler has joined #heat | 09:22 | |
*** pscheie__ has joined #heat | 09:22 | |
*** zigo has joined #heat | 09:22 | |
*** Adri2000 has joined #heat | 09:22 | |
*** larsks|phone_ has joined #heat | 09:22 | |
*** john-n-seattle has joined #heat | 09:22 | |
*** chmouel has joined #heat | 09:22 | |
*** metabro_ has joined #heat | 09:22 | |
*** Daviey has joined #heat | 09:22 | |
*** pasquier-s has joined #heat | 09:22 | |
*** TonyBurn1 has joined #heat | 09:22 | |
*** sirushti has joined #heat | 09:22 | |
*** skraynev has joined #heat | 09:22 | |
*** ogelbukh has joined #heat | 09:22 | |
*** shadower has joined #heat | 09:22 | |
*** obondarev has joined #heat | 09:22 | |
*** harlowja_away has joined #heat | 09:22 | |
*** lifeless has joined #heat | 09:22 | |
*** jhurlbert has joined #heat | 09:22 | |
*** jasond` has joined #heat | 09:22 | |
*** grncdr has joined #heat | 09:22 | |
*** john-n-s| has joined #heat | 09:22 | |
*** clarkb has joined #heat | 09:22 | |
*** lekha has joined #heat | 09:22 | |
*** PhilK has joined #heat | 09:22 | |
*** kebray has joined #heat | 09:22 | |
*** isviridov has joined #heat | 09:22 | |
*** larsks has joined #heat | 09:22 | |
*** sileht has joined #heat | 09:22 | |
*** samkottler has joined #heat | 09:22 | |
*** wirehead_ has joined #heat | 09:22 | |
*** therve has joined #heat | 09:22 | |
*** DaveJ_ has joined #heat | 09:22 | |
*** sgran has joined #heat | 09:22 | |
*** Ng has joined #heat | 09:22 | |
*** leseb has joined #heat | 09:22 | |
*** uvirtbot has joined #heat | 09:22 | |
*** EmilienM has joined #heat | 09:22 | |
*** russellb has joined #heat | 09:22 | |
*** DandyPandy has joined #heat | 09:22 | |
*** radez_g0n3 has joined #heat | 09:22 | |
*** mikal has joined #heat | 09:22 | |
*** christophk has joined #heat | 09:22 | |
*** nijaba has joined #heat | 09:22 | |
*** ChanServ has joined #heat | 09:22 | |
*** hobana.freenode.net sets mode: +o ChanServ | 09:22 | |
*** Alienyyg has joined #heat | 09:24 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/python-heatclient: Updates .gitignore https://review.openstack.org/62174 | 09:31 |
*** lsmola_ has joined #heat | 09:32 | |
*** tomek_adamczewsk has joined #heat | 09:33 | |
*** nanjj has joined #heat | 09:36 | |
*** akuznetsov has quit IRC | 09:42 | |
*** nkhare is now known as nkhare_afk | 09:42 | |
shardy | therve: https://wiki.openstack.org/wiki/Heat/Blueprints/InstanceUsers | 09:43 |
shardy | therve: I thought stevebaker and ayoung were going to add some more ideas, but it doesn't look like they have | 09:44 |
shardy | therve: comments/feedback etc appreciated :) | 09:45 |
*** fandikurnia01 has joined #heat | 09:45 | |
*** pfreund has joined #heat | 09:51 | |
openstackgerrit | Simon Pasquier proposed a change to openstack/heat: Simplify update_with_template() method https://review.openstack.org/62832 | 09:56 |
therve | shardy, Thanks, will do | 10:06 |
*** agileclipse has quit IRC | 10:12 | |
*** rongze has quit IRC | 10:14 | |
*** yogesh has quit IRC | 10:15 | |
*** nanjj has quit IRC | 10:16 | |
*** akuznetsov has joined #heat | 10:17 | |
*** akuznetsov has quit IRC | 10:23 | |
*** liang has quit IRC | 10:31 | |
*** ccs has quit IRC | 10:34 | |
*** nati_ueno has quit IRC | 10:34 | |
sergmelikyan | https://review.openstack.org/61074 - 5 +1 and 1 +2, can someone look at this one more time? | 10:34 |
*** gokrokve has joined #heat | 10:38 | |
*** dmakogon_ is now known as denis_makogon | 10:40 | |
*** gokrokve has quit IRC | 10:43 | |
*** aignatov has quit IRC | 10:44 | |
openstackgerrit | Pavlo Shchelokovskyy proposed a change to openstack/heat: Fix comparison with singletons https://review.openstack.org/61447 | 10:44 |
openstackgerrit | Swann Croiset proposed a change to openstack/heat: Add autoscaling notifications https://review.openstack.org/62087 | 10:50 |
*** aignatov has joined #heat | 10:59 | |
*** fandikurnia01 has quit IRC | 11:02 | |
*** nati_ueno has joined #heat | 11:13 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 11:13 | |
*** _SergeyLukjanov has quit IRC | 11:14 | |
*** swygue has quit IRC | 11:16 | |
*** SnowDust has joined #heat | 11:17 | |
SnowDust | hello guys .. how to add multiple resources in DependsOn ? | 11:18 |
SnowDust | anyone ? | 11:18 |
SnowDust | no help from heat forum :D all sleeping i guess | 11:20 |
*** akuznetsov has joined #heat | 11:22 | |
shardy | SnowDust: You can pass a list | 11:22 |
shardy | https://review.openstack.org/#/c/51507/ | 11:22 |
SnowDust | thanks .. shardy ! | 11:22 |
*** rongze has joined #heat | 11:24 | |
*** che-arne has joined #heat | 11:25 | |
*** yogesh has joined #heat | 11:26 | |
openstackgerrit | A change was merged to openstack/heat: Fix comparison with singletons https://review.openstack.org/61447 | 11:26 |
*** agileclipse has joined #heat | 11:30 | |
*** yogesh has quit IRC | 11:30 | |
*** faramir1 has quit IRC | 11:32 | |
openstackgerrit | Serg Melikyan proposed a change to openstack/heat: Implements Nova FloatingIP resources https://review.openstack.org/62836 | 11:32 |
*** SnowDust has quit IRC | 11:34 | |
* sergmelikyan accidentally published draft change as "ready for review". Tests are terrible :( | 11:35 | |
* sergmelikyan will appreciate any help with tests | 11:36 | |
*** guohliu has quit IRC | 11:36 | |
shardy | sergmelikyan: Just mark it work in progress in the gerrit ui | 11:37 |
shardy | then we can all see it and may have review feedback | 11:37 |
sergmelikyan | shardy, thx, done | 11:37 |
shardy | draft reviews you have to explicitly add reviewers for them to see it IIRC | 11:37 |
*** gokrokve has joined #heat | 11:39 | |
openstackgerrit | Pavlo Shchelokovskyy proposed a change to openstack/heat: Fix comparison with singletons https://review.openstack.org/62852 | 11:39 |
sergmelikyan | I had marked all patchsets as published and changed status to Work in Progress, as you suggested | 11:40 |
*** gokrokve has quit IRC | 11:43 | |
*** zbitter has joined #heat | 11:46 | |
*** zaneb has quit IRC | 11:48 | |
*** nkhare_afk is now known as nkhare | 11:50 | |
*** nosnos has quit IRC | 11:53 | |
*** plomakin has joined #heat | 11:53 | |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: SignalResponder, set resource_id in the correct place https://review.openstack.org/62862 | 12:16 |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: Correct create_trust_context docstring https://review.openstack.org/62436 | 12:24 |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: Add sanity check to ensure user_id can be trusted https://review.openstack.org/62437 | 12:24 |
*** pshchelo has joined #heat | 12:25 | |
openstackgerrit | Serg Melikyan proposed a change to openstack/heat: Implements Nova FloatingIP resources https://review.openstack.org/62836 | 12:29 |
*** gokrokve has joined #heat | 12:39 | |
*** giulivo has joined #heat | 12:41 | |
*** gokrokve has quit IRC | 12:44 | |
*** rushiagr2 has joined #heat | 12:45 | |
*** rpothier_ has quit IRC | 12:47 | |
*** rpothier_ has joined #heat | 12:47 | |
*** scollier has quit IRC | 12:48 | |
*** scollier has joined #heat | 12:49 | |
*** rushiagr has quit IRC | 12:49 | |
*** rushiagr2 has quit IRC | 12:51 | |
*** rushiagr2 has joined #heat | 12:52 | |
*** rushiagr2 is now known as rushiagr_away | 12:55 | |
*** giulivo has quit IRC | 12:57 | |
*** aignatov has quit IRC | 12:57 | |
*** rushiagr_away is now known as rushiagr2 | 13:00 | |
*** rushiagr2 is now known as rushiagr | 13:01 | |
*** rushiagr2 has joined #heat | 13:02 | |
*** tomek_adamczewsk has quit IRC | 13:02 | |
*** fandikurnia01 has joined #heat | 13:04 | |
*** rushiagr has quit IRC | 13:06 | |
*** fandikurnia01 has quit IRC | 13:07 | |
*** tomek_adamczewsk has joined #heat | 13:07 | |
*** fandikurnia01 has joined #heat | 13:08 | |
*** rongze has quit IRC | 13:19 | |
*** agileclipse has quit IRC | 13:21 | |
*** rongze has joined #heat | 13:21 | |
openstackgerrit | Pablo Andres Fuente proposed a change to openstack/heat: Deleting a stack with a deleted nested stack fails https://review.openstack.org/62752 | 13:25 |
*** rpothier_ has quit IRC | 13:26 | |
*** agileclipse has joined #heat | 13:30 | |
*** pafuent has joined #heat | 13:32 | |
*** nkhare has quit IRC | 13:33 | |
*** aweiteka has joined #heat | 13:34 | |
*** agileclipse has quit IRC | 13:40 | |
*** gokrokve has joined #heat | 13:40 | |
*** agileclipse has joined #heat | 13:42 | |
*** gokrokve has quit IRC | 13:45 | |
*** rushiagr2 has quit IRC | 13:45 | |
*** SergeyLukjanov has joined #heat | 13:51 | |
*** che-arne has quit IRC | 13:53 | |
*** che-arne has joined #heat | 13:53 | |
*** AndrewMichalik has joined #heat | 13:56 | |
*** blomquisg has joined #heat | 14:04 | |
*** radez_g0n3 is now known as radez | 14:04 | |
*** giulivo has joined #heat | 14:05 | |
*** nati_ueno has quit IRC | 14:10 | |
*** plomakin has quit IRC | 14:12 | |
*** urulama has quit IRC | 14:14 | |
*** rpothier_ has joined #heat | 14:15 | |
sdake | morning | 14:18 |
pshchelo | hi, can someone take a look at heat/engine/resource.py, line 421? what is the purpose of this except branch? it seems to me it is never executed, or I am missing something? | 14:22 |
*** andersonvom has joined #heat | 14:23 | |
therve | pshchelo, You're missing BaseException | 14:24 |
shardy | pshchelo: It's related to some older eventlet code which incorrectly in herited GreenletExit from BaseException | 14:27 |
shardy | And also, I think the scheduler code relies on GeneratorExit which is also derived from BaseException | 14:27 |
therve | SystemExit too | 14:29 |
shardy | Yeah, I guess there are a few corner cases we need to catch there | 14:29 |
pshchelo | therve: aha, thanks. | 14:29 |
pshchelo | shardy: no, according to docs starting from py2.6 GeneratorExit is a subclass of BAseException, SystemExit the same from py2.5 | 14:30 |
*** pfreund has quit IRC | 14:31 | |
shardy | pshchelo: I thought that was what I just said | 14:31 |
pshchelo | oops, misunderstood you | 14:31 |
pshchelo | thanks for the hint! | 14:34 |
*** rushiagr2 has joined #heat | 14:35 | |
shardy | pshchelo: I actually had it wrong, Greenlet previously inherited from Exception, but it needed to inherit from BaseException, which is what we catch there | 14:35 |
shardy | bug #1096150 has more details | 14:36 |
uvirtbot | Launchpad bug 1096150 in heat "Deleting RDS stack while DBInstance create in progress fails" [High,Fix released] https://launchpad.net/bugs/1096150 | 14:36 |
*** rushiagr2 has quit IRC | 14:40 | |
*** rushiagr2 has joined #heat | 14:41 | |
*** gokrokve has joined #heat | 14:41 | |
*** dims_ has quit IRC | 14:44 | |
*** pfreund has joined #heat | 14:45 | |
*** gokrokve has quit IRC | 14:46 | |
*** dims_ has joined #heat | 14:48 | |
*** SushilKM has quit IRC | 14:49 | |
openstackgerrit | A change was merged to openstack/heat: Convert Instance to new Schema format https://review.openstack.org/61780 | 14:51 |
*** akuznetsov has quit IRC | 14:53 | |
shardy | jasond`: Around? | 14:55 |
jasond` | shardy: hey | 14:56 |
shardy | jasond`: Hi, I think we're still breaking the gate with bug #1261433, or something similar :( | 14:57 |
uvirtbot | Launchpad bug 1261433 in heat "heat-tempest-xx already has an action (DELETE) in progress" [High,Fix committed] https://launchpad.net/bugs/1261433 | 14:57 |
shardy | See https://review.openstack.org/#/c/62436/ | 14:57 |
jasond` | ugh, okay | 14:58 |
jasond` | not sure why it says there were ERRORs in the logs http://logs.openstack.org/36/62436/2/gate/gate-tempest-dsvm-postgres-full/c3efd61/logs/screen-h-eng.txt.gz | 14:59 |
*** vijendar has joined #heat | 15:00 | |
shardy | Yeah, I only see "WARNING heat.engine.stack_lock [-] Lock was already released on stack None" | 15:00 |
*** jcru has joined #heat | 15:00 | |
jasond` | ah http://logs.openstack.org/36/62436/2/gate/gate-tempest-dsvm-postgres-full/c3efd61/logs/screen-h-api.txt.gz | 15:01 |
shardy | ouch | 15:01 |
shardy | So we're not mapping the new exception correctly in the APIs | 15:02 |
*** sabeen has joined #heat | 15:03 | |
jasond` | i guess not. will do some research and submit another patch | 15:04 |
jasond` | thanks | 15:04 |
jasond` | shardy: BTW, regarding your comment on https://review.openstack.org/#/c/62760/1 | 15:04 |
*** giulivo has quit IRC | 15:05 | |
shardy | jasond`: yup | 15:06 |
jasond` | as i understand it, there's a get() default that's applicable when the key doesn't exist and there's the actual property default that's applicable when the property isn't provided by the user. that patch just removes the get() default because the key always exists | 15:06 |
jasond` | if the key doesn't exist, someone made a typo in the resource | 15:06 |
*** SergeyLukjanov has quit IRC | 15:06 | |
shardy | jasond`: Hmm, I see, yeah maybe you're right | 15:09 |
*** gokrokve has joined #heat | 15:09 | |
jasond` | shardy: yeah, it's confusing. that's why i thought it was important enough to submit a patch | 15:10 |
*** rongze has quit IRC | 15:10 | |
jasond` | there should be no functional difference introduced by it | 15:10 |
shardy | jasond`: It is confusing, I agree. Hopefully zbitter can confirm the expected behavior of the new Schema getitem and add some feedback to the review | 15:11 |
*** topol has joined #heat | 15:13 | |
jasond` | okay, i will wait for his comments | 15:13 |
therve | jasond`, Presumably, the code is incorrect then (before and after) | 15:13 |
*** IlyaE has joined #heat | 15:14 | |
jasond` | therve: yeah, but this change wasn't to fix those bugs | 15:14 |
therve | Ok, fair enough | 15:14 |
*** rcleere has joined #heat | 15:14 | |
therve | I really don't like the fact that Properties is a mapping, because of things like that | 15:15 |
*** IlyaE has quit IRC | 15:15 | |
jasond` | shardy: i'll put a better description in the commit message to make it clearer | 15:15 |
*** tomek_adamczewsk has quit IRC | 15:15 | |
shardy | jasond`: Odd, we're mapping ActionInProgress in FaultWrapper | 15:17 |
shardy | jasond`: I guess the issue is tempest is trying to delete the stack twice? | 15:17 |
jasond` | shardy: correct | 15:17 |
jasond` | shardy: but it only does that when it feels like it :) | 15:18 |
shardy | We should fix the tests, to either not do that, or tolerate in progress as a response | 15:18 |
jasond` | i agree | 15:20 |
*** tomek_adamczewsk has joined #heat | 15:21 | |
*** giulivo has joined #heat | 15:21 | |
jasond` | shardy: i think it's happening here https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/stacks/test_stacks.py#L69-L71 | 15:23 |
shardy | jasond`: Why are we deleting twice tho? | 15:25 |
jasond` | not sure | 15:25 |
shardy | https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/base.py#L86 | 15:26 |
shardy | but that looks like it should tolerate the client exception | 15:27 |
jasond` | if it's happening there, it's already trying to tolerate the exception. it's the ERROR message that's causing it to fail | 15:27 |
*** amritanshu_RnD has quit IRC | 15:27 | |
jasond` | i need to try to match up timestamps again to see where exactly it's happening | 15:28 |
shardy | With debugging enabled the common/wsgi.py creates that error for known HeatExceptions | 15:31 |
shardy | Which is probably wrong, if faultwrap can map them | 15:31 |
*** sdake_ has joined #heat | 15:33 | |
jasond` | shardy: are you saying ActionInProgress shouldn't be mapped in FaultWrapper? | 15:33 |
shardy | jasond`: I'm saying it should, and it looks like it is, but we shouldn't log a stacktrace in the API when it happens | 15:34 |
jasond` | oh ok | 15:34 |
jasond` | shardy: it's happening for RequestLimitExceeded too (further up) | 15:36 |
shardy | This faultwrap stuff has caused so many problems, I don't understand why it has to be so complex | 15:37 |
*** SergeyLukjanov has joined #heat | 15:37 | |
shardy | https://review.openstack.org/#/c/49155/ | 15:37 |
shardy | That's where the logging was added, so maybe zbitter has some ideas on how to handle this | 15:38 |
*** brint has joined #heat | 15:38 | |
zbitter | uh oh | 15:38 |
*** zbitter is now known as zaneb | 15:38 | |
shardy | basically we want errors which happen in the engine to log the stacktrace there, and errors which happen in the API to log their stacktrace in the API log | 15:38 |
shardy | and faultwrapper should map the responses without exposing the user to the stacktrace | 15:38 |
shardy | zaneb: Hey, sorry, the dreaded faultwrapper has bitten us again :( | 15:39 |
shardy | http://logs.openstack.org/36/62436/2/gate/gate-tempest-dsvm-postgres-full/c3efd61/logs/screen-h-api.txt.gz | 15:39 |
shardy | tempest sees the ERROR and fails the test, but we're just logging a known exception which is mapped to an appropriate response AFAICS | 15:40 |
*** vkozhukalov has quit IRC | 15:40 | |
*** rongze has joined #heat | 15:40 | |
*** sabeen has quit IRC | 15:42 | |
*** sabeen has joined #heat | 15:42 | |
*** tims has joined #heat | 15:42 | |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: Correct assertEqual rsrc.state argument ordering https://review.openstack.org/62918 | 15:43 |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: autoscaling test correct self.assertEqual ordering https://review.openstack.org/62919 | 15:43 |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: SignalResponder, set resource_id in the correct place https://review.openstack.org/62862 | 15:43 |
pafuent | jasond`: shardy: Maybe this could help. This review solve some of the errors in h-api https://review.openstack.org/#/c/62080/ | 15:44 |
*** sabeen1 has joined #heat | 15:45 | |
*** sabeen has quit IRC | 15:45 | |
shardy | pafuent: Interesting, thanks | 15:48 |
shardy | pafuent: tbh, I'm not sure adding a new exception base class is the answer | 15:48 |
shardy | e.g what makes StackNotFound an HeatClientException but not StackExists? | 15:49 |
jasond` | pafuent: would the user see HTTPExceptionDisguise if debug mode is on? | 15:50 |
andersonvom | hey folks, quick question regarding instance statuses: is it the case that if an instance is not ACTIVE, nor in one of the _deferred_states, then we should necessarily consider that an "error" state and blow up? | 15:50 |
*** arbylee has joined #heat | 15:51 | |
shardy | andersonvom: Yes, that is the way we use server.status in the instance resource | 15:51 |
pafuent | jasond`: The HTTPExceptionDisguise is needed in order to the exception reach the FaultWrapper | 15:52 |
pafuent | shardy: I only change the exceptions that were related to bug, because I'm new here and I'm not sure which exceptions are candidates for the class that I added. | 15:53 |
shardy | pafuent: That is exactly the problem IMO, expecting everyone to know which class to inherit from will just get us in even more of a mess IMO | 15:54 |
shardy | pafuent: Thanks for the patch tho, it's a good start to the discussion :) | 15:54 |
pafuent | shardy: :) | 15:55 |
*** arbylee1 has joined #heat | 15:55 | |
*** rongze has quit IRC | 15:55 | |
*** arbylee has quit IRC | 15:56 | |
andersonvom | shardy: so, yeah, if you look at Instance#_check_active, that's the current implementation, but I'm wondering if this is the case only because we're trying to attach the volume there as well. Meaning, the exception raising would be a part of volume attaching? Or is it really that any other state is necessarily an error? | 15:56 |
zaneb | pafuent: "I'm not sure which exceptions are candidates for the class that I added" <- all of them, that's why an extra superclass is not the way to go | 15:56 |
*** IlyaE has joined #heat | 15:58 | |
openstackgerrit | Vijendar Komalla proposed a change to openstack/heat: Add _() to rackspace resource strings https://review.openstack.org/62922 | 15:59 |
pafuent | zaneb: NoServiceEndpoint should not log an error? | 15:59 |
*** nkhare has joined #heat | 15:59 | |
zaneb | shardy: so the answer is probably that we shouldn't log the stack trace for a HeatException... maybe just an info log or something for those ones? | 15:59 |
shardy | andersonvom: well if Nova gives us a state we don't understand, how can we parse it and make any decision about it's error-ness? | 15:59 |
shardy | zaneb: I guess, if any HeatException comes from the engine, we just don't log it, as it should already be logged in the engine? | 16:00 |
*** rushiagr2 is now known as rushiagr | 16:00 | |
shardy | Or do we also derive exceptions from there in the API code.. | 16:00 |
shardy | I'm fine with just s/ERROR/WARNING if it's easiest | 16:01 |
shardy | it's a debug message afterall | 16:01 |
*** brint_ has joined #heat | 16:02 | |
*** john-n-seattle1 has joined #heat | 16:02 | |
*** tims has quit IRC | 16:03 | |
*** andrew_plunk has joined #heat | 16:03 | |
*** brint has quit IRC | 16:04 | |
*** john-n-seattle1 has quit IRC | 16:05 | |
pafuent | shardy: So is better to log all HeatExceptions as warning instead of classifying them? | 16:08 |
jasond` | shardy: it seems like test_stack_list_responds and test_stack_crud_no_resources are both trying to delete the same stack at the same time http://paste.openstack.org/show/55328/ | 16:09 |
zaneb | so... when I wrote that logging code... I'm pretty sure I tested that it only logged exceptions generated in the API, and not ones from the engine | 16:09 |
zaneb | I remember it vividly, because it's not like me to actually test something ;) | 16:10 |
*** blamar has quit IRC | 16:10 | |
*** SushilKM__ has joined #heat | 16:10 | |
zaneb | so it seems like maybe the wrapping that jasond` added on that particular exception is causing it to get logged there, when exceptions from the engine normally wouldn't? | 16:10 |
jasond` | zaneb: this was from before i added the client_exceptions decorator http://logs.openstack.org/17/61717/4/check/check-tempest-dsvm-postgres-full/3b776c3/logs/screen-h-api.txt.gz | 16:12 |
jasond` | (the engine exception/traceback still got logged in the api log) | 16:12 |
zaneb | ugh, it's actually being logged *twice* as well | 16:13 |
shardy | jasond`: So the tests should create stacks with unique names then.. | 16:13 |
jasond` | shardy: yes, that would fix it | 16:14 |
openstackgerrit | Vijendar Komalla proposed a change to openstack/python-heatclient: python-heatclient stack-abandon support https://review.openstack.org/62925 | 16:14 |
shardy | jasond`: Are you happy to raise a tempest bug and send them a patch? | 16:14 |
zaneb | shardy, jasond`: surely it goes without saying they should do that anyway??? | 16:14 |
*** tomek_adamczewsk has quit IRC | 16:15 | |
shardy | zaneb: Absolutely, I'm suprised we don't | 16:15 |
shardy | heat-tempest-1268516181 already has an action (DELETE) in progress. | 16:15 |
shardy | That looks like a unique suffix, so possibly the crud test is trying to delete the stack created in the setUpClass or something? | 16:16 |
jasond` | shardy: sure | 16:16 |
jasond` | shardy: i don't understand how test_stack_list_responds is deleting a stack | 16:18 |
*** zaneb has quit IRC | 16:19 | |
jasond` | shardy: ah, this is probably run after each test https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/base.py#L117 | 16:21 |
*** jasond` is now known as jasond | 16:21 | |
shardy | I thought tearDownClass would only happen once per test-class, not for every test case like tearDown() | 16:22 |
*** brint_ has quit IRC | 16:23 | |
shardy | https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/base.py#L82 | 16:23 |
jasond | shardy: maybe it's running after test_stack_list_responds and trying to delete the same stack that test_stack_crud_no_resources is deleting explicitly | 16:24 |
*** zaneb has joined #heat | 16:24 | |
shardy | I think the issue is there, where test_stack_crud_no_resources uses the create_stack classmethod to create the stack | 16:24 |
shardy | so it gets appended to the list of stacks to cleanup on test teardown, only it's already been deleted | 16:25 |
andersonvom | shardy: sorry, network problems here. Thanks! | 16:25 |
jasond | shardy: yeah, so we could either remove that append or remove the delete https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/stacks/test_stacks.py#L69-L71 | 16:25 |
*** brint has joined #heat | 16:26 | |
shardy | Or get the crud test to pop the stack off the list when it's deleted it | 16:26 |
shardy | so then it's still deleted if that test fails before delete happens | 16:26 |
zaneb | shardy: ++ | 16:27 |
jasond | shardy: sounds good. i'll submit a bugfix for that | 16:27 |
* shardy realizes usage of pop, stack, and list are confusing above.. ;) | 16:27 | |
*** SushilKM__ has quit IRC | 16:27 | |
shardy | jasond: thanks! | 16:27 |
openstackgerrit | Richard Lee proposed a change to openstack/heat: Add way to group exceptions in DependencyTaskGroup https://review.openstack.org/62479 | 16:30 |
openstackgerrit | Richard Lee proposed a change to openstack/heat: Refactor Instance#_check_active https://review.openstack.org/62478 | 16:30 |
openstackgerrit | Anderson Mesquita proposed a change to openstack/heat: Check resources are in expected states https://review.openstack.org/58641 | 16:31 |
*** SushilKM__ has joined #heat | 16:35 | |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: SignalResponder, set resource_id in the correct place https://review.openstack.org/62862 | 16:37 |
*** sdake has quit IRC | 16:41 | |
*** sdake has joined #heat | 16:41 | |
openstackgerrit | Clint "SpamapS" Byrum proposed a change to openstack/heat: Retry failed actions on update https://review.openstack.org/62936 | 16:48 |
*** AndrewMichalik has quit IRC | 16:49 | |
openstackgerrit | Anderson Mesquita proposed a change to openstack/heat: Check resources are in expected states https://review.openstack.org/58641 | 16:51 |
*** topol has quit IRC | 16:51 | |
*** IlyaE has quit IRC | 16:52 | |
*** rongze has joined #heat | 16:55 | |
*** brint has quit IRC | 16:56 | |
*** nkhare has quit IRC | 16:57 | |
*** brint has joined #heat | 16:58 | |
*** pfreund has quit IRC | 16:59 | |
*** ifarkas has quit IRC | 16:59 | |
*** rushiagr has quit IRC | 17:02 | |
*** AndrewMichalik has joined #heat | 17:03 | |
*** Andrzej has quit IRC | 17:04 | |
*** pshchelo has quit IRC | 17:06 | |
*** rwsu has joined #heat | 17:08 | |
*** rushiagr has joined #heat | 17:16 | |
*** pvaneck has joined #heat | 17:18 | |
*** blamar has joined #heat | 17:18 | |
*** SushilKM__ has quit IRC | 17:20 | |
*** hub_cap has left #heat | 17:20 | |
*** SushilKM has joined #heat | 17:20 | |
*** topol has joined #heat | 17:34 | |
*** vkozhukalov has joined #heat | 17:34 | |
openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Don't provide default values to properties.get() https://review.openstack.org/62760 | 17:37 |
*** yogesh has joined #heat | 17:42 | |
*** chandankumar has quit IRC | 17:45 | |
*** pafuent has quit IRC | 17:56 | |
*** brint has quit IRC | 17:56 | |
*** giulivo has quit IRC | 17:56 | |
*** scollier has quit IRC | 17:56 | |
*** derekh has quit IRC | 17:56 | |
*** asalkeld has quit IRC | 17:56 | |
*** jomara has quit IRC | 17:56 | |
*** denis_makogon has quit IRC | 17:56 | |
*** stannie has quit IRC | 17:56 | |
*** openstackgerrit has quit IRC | 17:56 | |
*** radix has quit IRC | 17:56 | |
*** yogesh has quit IRC | 17:56 | |
*** zaneb has quit IRC | 17:56 | |
*** sdake_ has quit IRC | 17:56 | |
*** bgorski has quit IRC | 17:56 | |
*** pscheie__ has quit IRC | 17:56 | |
*** zigo has quit IRC | 17:56 | |
*** Adri2000 has quit IRC | 17:56 | |
*** larsks|phone_ has quit IRC | 17:56 | |
*** john-n-seattle has quit IRC | 17:56 | |
*** vkozhukalov has quit IRC | 17:56 | |
*** blomquisg has quit IRC | 17:56 | |
*** lsmola_ has quit IRC | 17:56 | |
*** xuan has quit IRC | 17:56 | |
*** Tross has quit IRC | 17:56 | |
*** jpeeler has quit IRC | 17:56 | |
*** pleia2 has quit IRC | 17:56 | |
*** al-maisan has quit IRC | 17:56 | |
*** SpamapS has quit IRC | 17:56 | |
*** lazzurs has quit IRC | 17:56 | |
*** SergeyLukjanov has quit IRC | 17:56 | |
*** andersonvom has quit IRC | 17:56 | |
*** metabro_ has quit IRC | 17:56 | |
*** chmouel has quit IRC | 17:56 | |
*** Daviey has quit IRC | 17:56 | |
*** stevebaker has quit IRC | 17:56 | |
*** Alienyyg has quit IRC | 17:56 | |
*** erkules has quit IRC | 17:56 | |
*** scroiset has quit IRC | 17:57 | |
*** pasquier-s has quit IRC | 17:57 | |
*** shadower has quit IRC | 17:57 | |
*** obondarev has quit IRC | 17:57 | |
*** harlowja_away has quit IRC | 17:57 | |
*** lifeless has quit IRC | 17:57 | |
*** gokrokve has quit IRC | 17:57 | |
*** fandikurnia01 has quit IRC | 17:57 | |
*** shardy has quit IRC | 17:57 | |
*** sirushti has quit IRC | 17:57 | |
*** skraynev has quit IRC | 17:57 | |
*** isviridov has quit IRC | 17:57 | |
*** rongze has quit IRC | 17:57 | |
*** arbylee1 has quit IRC | 17:57 | |
*** vijendar has quit IRC | 17:57 | |
*** dims_ has quit IRC | 17:57 | |
*** rpothier_ has quit IRC | 17:57 | |
*** che-arne has quit IRC | 17:57 | |
*** agileclipse has quit IRC | 17:57 | |
*** gondoi has quit IRC | 17:57 | |
*** dguerri has quit IRC | 17:57 | |
*** TonyBurn1 has quit IRC | 17:57 | |
*** jasond has quit IRC | 17:57 | |
*** grncdr has quit IRC | 17:57 | |
*** john-n-s| has quit IRC | 17:57 | |
*** rwsu has quit IRC | 17:57 | |
*** sdake has quit IRC | 17:57 | |
*** rcleere has quit IRC | 17:57 | |
*** jcru has quit IRC | 17:57 | |
*** aweiteka has quit IRC | 17:57 | |
*** larsks has quit IRC | 17:57 | |
*** sgran has quit IRC | 17:57 | |
*** leseb has quit IRC | 17:57 | |
*** uvirtbot has quit IRC | 17:57 | |
*** DandyPandy has quit IRC | 17:57 | |
*** radez has quit IRC | 17:57 | |
*** rushiagr has quit IRC | 17:57 | |
*** AndrewMichalik has quit IRC | 17:57 | |
*** sabeen1 has quit IRC | 17:57 | |
*** mordred has quit IRC | 17:57 | |
*** lekha has quit IRC | 17:57 | |
*** PhilK has quit IRC | 17:57 | |
*** kebray has quit IRC | 17:57 | |
*** sileht has quit IRC | 17:57 | |
*** wirehead_ has quit IRC | 17:57 | |
*** DaveJ_ has quit IRC | 17:57 | |
*** EmilienM has quit IRC | 17:57 | |
*** russellb has quit IRC | 17:57 | |
*** christophk has quit IRC | 17:57 | |
*** clarkb has quit IRC | 17:57 | |
*** Ng has quit IRC | 17:57 | |
*** mikal has quit IRC | 17:57 | |
*** ogelbukh has quit IRC | 17:57 | |
*** jhurlbert has quit IRC | 17:57 | |
*** samkottler has quit IRC | 17:57 | |
*** nijaba has quit IRC | 17:57 | |
*** SushilKM has quit IRC | 17:57 | |
*** andrew_plunk has quit IRC | 17:57 | |
*** radix_ has quit IRC | 17:57 | |
*** slong has quit IRC | 17:57 | |
*** bnemec has quit IRC | 17:57 | |
*** ChanServ has quit IRC | 17:57 | |
*** topol has quit IRC | 17:57 | |
*** blamar has quit IRC | 17:57 | |
*** pvaneck has quit IRC | 17:57 | |
*** sergmelikyan has quit IRC | 17:57 | |
*** andrewmi- has quit IRC | 17:57 | |
*** therve has quit IRC | 17:57 | |
*** openstack has joined #heat | 18:02 | |
*** openstack has joined #heat | 18:06 | |
zaneb | and is quite often _never read again_ | 18:06 |
shardy | SpamapS: personally I spend way more time grepping code than commit messages | 18:07 |
*** swygue has joined #heat | 18:07 | |
zaneb | yeah, I would much sooner -1 for user-facing stuff like docs. those should actually be fixed | 18:08 |
SpamapS | shardy: your implication that one who does carefully check the commit message does not carefully check the code is flippant and a lesser man than I might take that personally. | 18:08 |
SpamapS | zaneb: when the commit message is read.. it is often in a critical regression-hunting situation. The other time is when new contributors are trying to answer the question of why something is the way it is. | 18:09 |
zaneb | SpamapS: I don't think you were the target of that comment, but I do think you're setting an example for the people who are the target of that comment, and I'm not talking about your thorough code reviews (which would be an excellent example to follow) | 18:09 |
*** harlowja_away is now known as harlowja | 18:09 | |
zaneb | (shardy's comment, that is) | 18:10 |
shardy | SpamapS: Well it was not meant to be personal, I was trying to say that we should foster a culture of critcical technical review over cosmetic proof-reading | 18:10 |
shardy | I've already been shot-down on the ML for suggsting that we have a lot of the latter, so probably I should just shut up and get back to coding | 18:10 |
*** mestery has joined #heat | 18:13 | |
*** funzo has joined #heat | 18:13 | |
*** sgordon` has joined #heat | 18:13 | |
zaneb | look, nobody here is more pedantic than I am | 18:13 |
*** SushilKM has quit IRC | 18:13 | |
SpamapS | shardy: aye, me too. Again, I do value your and Zane's positions very much, even if I do not share the position. | 18:14 |
zaneb | but having lived in a country where I speak the language like a retarded 3-year-old... | 18:14 |
zaneb | I appreciate not having everybody on my case about it, and I am more than happy to extend the same courtesy to others - especially non-native speakers - when their meaning is clear | 18:14 |
SpamapS | zaneb: I think we should be extremely sensitive to that definitely. That was discussed on openstack-dev a while back and it was agreed that it is appropriate but do be clear and correct thigns explicitly, don't just say "this is wrong". | 18:17 |
openstackgerrit | Lars Kellogg-Stedman proposed a change to openstack/python-heatclient: add output-list and output-show https://review.openstack.org/60591 | 18:17 |
openstackgerrit | A change was merged to openstack/heat: Add an external gateway property to neutron router https://review.openstack.org/60118 | 18:19 |
* SpamapS starts testing update/retry | 18:19 | |
*** nati_ueno has joined #heat | 18:22 | |
*** arbylee1 has quit IRC | 18:22 | |
*** rushiagr has quit IRC | 18:25 | |
*** spzala has joined #heat | 18:28 | |
*** Tross has left #heat | 18:36 | |
lifeless | As a retarded three year old in training, I want correction :) | 18:43 |
*** blamar has quit IRC | 18:43 | |
zaneb | lifeless: right :) I'm not saying don't correct, I'm saying there's a time to stall the work pipeline over it and a time when that's not warranted | 18:45 |
*** ccs has joined #heat | 18:46 | |
lifeless | one of the things I think causes this to be a source of agnst is long (day+ review turnarounds) | 18:46 |
shardy | lifeless: In comparison to other projects *cough*keystone*cough* our review turnaround is postively super-sonic ;) | 18:47 |
shardy | wow my typing is really bad today, must be all this talk of trivial typos ;) | 18:48 |
zaneb | lifeless: I think that's true | 18:49 |
shardy | lifeless: I agree we can and should do better tho | 18:49 |
*** pafuent has left #heat | 18:49 | |
*** pafuent has joined #heat | 18:49 | |
lifeless | shardy: I meant no critique :) | 18:50 |
sdake | our reviews are the fastest of many openstack projects, however, where we fail is when some reviews take some time, they fall to the end of the gerrit list, and review fatigue sets in - with no clearing of the backlog | 18:50 |
sdake | one solution to that is to start at the *last* review once in awhile :) | 18:50 |
zaneb | I have 167 unread emails in my Gerrit mailbox right now | 18:50 |
lifeless | Ihttp://russellbryant.net/openstack-stats/heat-openreviews.html | 18:50 |
lifeless | 3rd quartile wait time: 2 days, 8 hours, 25 minutes | 18:50 |
*** SushilKM has joined #heat | 18:50 | |
zaneb | every time someone posts another patchset, that's 3 more | 18:51 |
*** Tross has joined #heat | 18:51 | |
*** Tross has quit IRC | 18:51 | |
zaneb | multiply that by the number of people on the review... | 18:51 |
lifeless | -> 25% of the current open reviews have been waiting > 2d8h without getting a negative feedback | 18:51 |
*** Tross has joined #heat | 18:51 | |
zaneb | new patchsets are expensive; they are a proxy for reviewer attention. that's one reason I try to conserve them | 18:51 |
shardy | lifeless: which is way better than almost any other openstack project, except tripleo | 18:52 |
*** bgorski has quit IRC | 18:52 | |
zaneb | lifeless: we used to be *much* better but things have just exploded since the last summit | 18:52 |
shardy | you guys are reviewing machines! | 18:52 |
shardy | http://russellbryant.net/openstack-stats/tripleo-openreviews.html | 18:52 |
zaneb | in terms of numbers of contributions | 18:53 |
lifeless | zaneb: a good problem to have | 18:53 |
zaneb | lifeless: indeed :) and I think we are close to having trained up some more core reviewers | 18:53 |
lifeless | shardy: well, we got together as a team, and I've been thrilled with the results | 18:53 |
shardy | lifeless: Hopefully we will be able to expand -core to cope with the number of patches, but it takes time as you know | 18:53 |
lifeless | the latency on increasing -core bandwidth is a necessary evil I think | 18:54 |
shardy | yeah | 18:54 |
jasond | shardy: can you look at this? https://review.openstack.org/#/c/62938/ | 18:54 |
shardy | jasond: my preference would be to break out the class create_stack, so it cab be used without updating the stacks list | 18:57 |
zaneb | shardy: https://review.openstack.org/#/c/60607/ <- WTF? | 18:57 |
shardy | then register additional cleanup for that test to remove it | 18:57 |
shardy | jasond: it will be a bit more work, but better in the long run, IMO | 18:57 |
stevebaker | morning | 18:58 |
shardy | zaneb: lol, that looks really wrong | 18:58 |
shardy | hey stevebaker | 18:58 |
zaneb | stevebaker: what's the though behind having a tenant_id property for a router? | 18:59 |
zaneb | thought | 18:59 |
shardy | Can users create routers in tenants other than that they have a token scoped to? | 19:00 |
zaneb | doubt it | 19:00 |
shardy | I suspect not, unless neutron is more broken than I thought | 19:00 |
stevebaker | I think it is an admin-only property | 19:00 |
zaneb | I suspect that what we're looking at here is a whole other use case that we're in the process of implementing in a very ad-hoc way | 19:00 |
zaneb | maybe we need to step back here | 19:00 |
zaneb | it seems to me that the use case is something other than a cloud, it's basically a Neutron-only deployment and the people managing it are all operator-administrators | 19:01 |
zaneb | stevebaker: how am I doing? | 19:01 |
*** pablosan has joined #heat | 19:03 | |
zaneb | (NetDHCPAgent and RouterL3Agent also fall in this category) | 19:04 |
jasond | shardy: hm, not sure i follow. | 19:04 |
jasond | stevebaker: FYI https://review.openstack.org/#/c/62938/ | 19:04 |
shardy | jasond: Just about to stop for some food before the meeting, I'll add some comments later | 19:05 |
stevebaker | zaneb: I'm not sure, they probably need to elaborate on their use cases | 19:05 |
jasond | shardy: okay, thanks | 19:05 |
shardy | jasond: If what you have is acceptable to the tempest folks, we can go with it and I'll post a followup with the refactoring | 19:06 |
jasond | shardy: sounds good | 19:06 |
stevebaker | zaneb: for example, tripleo could use heat to set up neutron (but currently don't plan to) https://github.com/openstack/tripleo-incubator/blob/master/scripts/setup-neutron | 19:08 |
*** jergerber has joined #heat | 19:08 | |
SpamapS | zaneb: TripleO can use this. | 19:09 |
zaneb | ok, that makes sense. my question is should we be coming up with a way to expose this only to administrators | 19:09 |
SpamapS | zaneb: it would replace this https://git.openstack.org/cgit/openstack/tripleo-incubator/tree/scripts/setup-neutron | 19:09 |
stevebaker | zaneb: I think if we just document admin properties as such. Any attempt to use by non-admin will raise a neutron error | 19:10 |
zaneb | new rule: no new properties without descriptions | 19:11 |
*** swygue has quit IRC | 19:12 | |
SpamapS | zaneb: +1 | 19:12 |
stevebaker | or schema conversions | 19:13 |
*** swygue has joined #heat | 19:14 | |
openstackgerrit | Pablo Andres Fuente proposed a change to openstack/heat: wsgi.Resource exception handling to not log errors https://review.openstack.org/62080 | 19:15 |
zaneb | stevebaker: all schema conversions should be in the review queue already | 19:19 |
*** arbylee has joined #heat | 19:20 | |
stevebaker | zaneb: maybe we should use judicious use of -2 on some other changes to give the schema changes a chance of landing | 19:21 |
zaneb | stevebaker: it's probably quicker to go review all the ones that already have one +2 ;) | 19:22 |
*** pscheie__ has quit IRC | 19:23 | |
stevebaker | yup | 19:23 |
*** pscheie has joined #heat | 19:24 | |
jasond | stevebaker: i entered this a couple of days ago https://blueprints.launchpad.net/heat/+spec/stop-delete-stack should i close it in favor of https://bugs.launchpad.net/heat/+bug/1262012 ? | 19:27 |
uvirtbot | Launchpad bug 1262012 in heat "Cannot delete an IN_PROGRESS stack" [High,Triaged] | 19:27 |
stevebaker | jasond: its a regression, so lets use the bug | 19:28 |
jasond | ok | 19:28 |
jasond | um, how do I delete the BP? | 19:30 |
*** IlyaE has joined #heat | 19:32 | |
*** gokrokve has quit IRC | 19:34 | |
*** gokrokve has joined #heat | 19:35 | |
*** yogesh has quit IRC | 19:35 | |
*** yogesh has joined #heat | 19:38 | |
*** gokrokve has quit IRC | 19:39 | |
stevebaker | jasond: mark it as superceded or obsolete, and remove the milestone | 19:40 |
jasond | stevebaker: done, thanks | 19:40 |
*** bgorski has joined #heat | 19:48 | |
*** pshchelo has joined #heat | 19:55 | |
stevebaker | meeting time all | 20:00 |
*** yogesh_ has joined #heat | 20:01 | |
*** yogesh_ has quit IRC | 20:03 | |
*** yogesh_ has joined #heat | 20:03 | |
*** yogesh has quit IRC | 20:05 | |
openstackgerrit | Chmouel Boudjnah proposed a change to openstack/python-heatclient: Show better error when json fail to parse template https://review.openstack.org/62311 | 20:07 |
*** akuznetsov has joined #heat | 20:08 | |
openstackgerrit | Chmouel Boudjnah proposed a change to openstack/python-heatclient: Show better error when json fail to parse template https://review.openstack.org/62311 | 20:10 |
*** AndrewMi_ has quit IRC | 20:13 | |
*** derekh has joined #heat | 20:13 | |
*** sgordon has joined #heat | 20:16 | |
*** sgordon has quit IRC | 20:16 | |
*** sgordon has joined #heat | 20:16 | |
*** akuznetsov has quit IRC | 20:19 | |
openstackgerrit | Clint "SpamapS" Byrum proposed a change to openstack/heat: Retry failed actions on update https://review.openstack.org/62936 | 20:22 |
SushilKM | while writing the heat template, can we accomodate any conditions, that some part of template runs for some condition only like for example volume provisioning | 20:22 |
*** vkozhukalov has quit IRC | 20:28 | |
openstackgerrit | A change was merged to openstack/heat: Fix misused assertTrue in unit tests https://review.openstack.org/61816 | 20:30 |
*** yogesh_ has quit IRC | 20:34 | |
*** yogesh has joined #heat | 20:35 | |
*** sdake_ is now known as sdake2 | 20:38 | |
*** gokrokve has joined #heat | 20:38 | |
*** yogesh has quit IRC | 20:39 | |
*** yogesh has joined #heat | 20:40 | |
*** arbylee has quit IRC | 20:43 | |
*** derekh has quit IRC | 20:45 | |
*** SnowDust has joined #heat | 20:50 | |
*** pafuent has quit IRC | 20:52 | |
openstackgerrit | Pablo Andres Fuente proposed a change to openstack/heat: Added tenant_id property to OS::Neutron::Router https://review.openstack.org/60607 | 20:54 |
*** pafuent has joined #heat | 20:55 | |
shardy | SushilKM: No, you have to conditionally generate the template, e.g in a wrapper script | 21:01 |
shardy | SushilKM: Heat doesn't support conditionals or loops etc in the template DSL | 21:01 |
SpamapS | SushilKM: what condition do you want exactly? | 21:04 |
*** yogesh has quit IRC | 21:08 | |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: Fix SignalResponder signature response when deleted https://review.openstack.org/62987 | 21:09 |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: Add test coverage for SignalResponder delete https://review.openstack.org/62988 | 21:09 |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: SignalResponder store access/secret in resource data https://review.openstack.org/62440 | 21:09 |
openstackgerrit | Steven Hardy proposed a change to openstack/heat: heat_keystoneclient revise get_ec2_keypair https://review.openstack.org/62441 | 21:10 |
*** yogesh has joined #heat | 21:10 | |
*** SergeyLukjanov has quit IRC | 21:12 | |
*** Tross has quit IRC | 21:19 | |
*** arbylee has joined #heat | 21:20 | |
grncdr | so sorry for the amount of spam I generated with this changeset, I think it's ready for more review now: https://review.openstack.org/#/c/62078/ | 21:29 |
grncdr | there's a −1 from Liang but I don't know if I agree with it ;) | 21:29 |
*** bgorski has quit IRC | 21:30 | |
*** pshchelo is now known as pshchelo_ | 21:31 | |
*** pshchelo_ is now known as pas-ha | 21:32 | |
zaneb | grncdr: yeah, he's right, we don't want to be creating threads | 21:33 |
*** swygue has quit IRC | 21:33 | |
grncdr | oh? | 21:34 |
grncdr | sorry I'm not sure if you mean OS-level threads or eventlet coro's | 21:34 |
grncdr | if greenpool is creating an OS-level thread that definitely wasn't my intention | 21:34 |
*** denis_makogon has quit IRC | 21:34 | |
grncdr | if creating eventlet threads/coro's is undesirable, then I guess I need to find a way to lower timeouts for the serialized connect calls? | 21:35 |
*** dmakogon_ has joined #heat | 21:35 | |
zaneb | sorry, I tend to use the term thread and greenlet interchangeably | 21:35 |
sdake | zaneb heresy ;) | 21:36 |
zaneb | grncdr: so, first thing to note is that we already have a defined workflow for polling a bunch of things: https://github.com/openstack/heat/blob/master/heat/engine/scheduler.py#L330 | 21:36 |
zaneb | sdake: eventlet's claims of thread safety are so worthless that they might as well be threads | 21:37 |
sdake | lol | 21:37 |
zaneb | grncdr: that doesn't solve the problem of really long timeouts... best fix there is probably to go with a shorter timeout | 21:38 |
*** spzala has quit IRC | 21:39 | |
*** swygue has joined #heat | 21:41 | |
*** Tross has joined #heat | 21:42 | |
*** pas-ha has quit IRC | 21:44 | |
*** pafuent has left #heat | 21:44 | |
*** pshchelo has joined #heat | 21:45 | |
SpamapS | So I don't really understand the hesitance to use greenlets for that. | 21:46 |
SpamapS | heat.engine.scheduler will basically do the same though, right? | 21:47 |
asalkeld | SpamapS, scheduler uses co-routines not greenlet | 21:50 |
*** pshchelo has quit IRC | 21:52 | |
openstackgerrit | A change was merged to openstack/heat: rackspace: Convert Scaling resources to new Schema format https://review.openstack.org/61827 | 21:53 |
SpamapS | asalkeld: right so they would not do parallel I/O even | 21:53 |
asalkeld | well making greenlet thread in a resource is a problem as it blocks from the scheduler's point of view | 21:54 |
*** pshchelo has joined #heat | 21:54 | |
asalkeld | so no more resouce concurrency | 21:54 |
SpamapS | ahh battling concurrency models | 21:54 |
asalkeld | yip | 21:55 |
zaneb | SpamapS: this would be the first place where we ever use greenlets in a resource | 21:55 |
zaneb | we wrote that scheduler crap specifically so we would not ever have to do this | 21:55 |
SpamapS | zaneb: roger that | 21:55 |
openstackgerrit | A change was merged to openstack/heat: Correct create_trust_context docstring https://review.openstack.org/62436 | 21:55 |
SpamapS | so then the right thing to do is to setup a non blocking connect and use that instead of eventlet.connect ? | 21:55 |
openstackgerrit | A change was merged to openstack/heat: Add sanity check to ensure user_id can be trusted https://review.openstack.org/62437 | 21:56 |
zaneb | I don't think there is such thing as a non-blocking connect, is there? | 21:56 |
zaneb | we would have to set a small-ish timeout | 21:56 |
zaneb | and make sure we only do one per yield | 21:56 |
SpamapS | zaneb: yes all python I/O can be non-blocking | 21:57 |
*** radez is now known as radez_g0n3 | 21:57 | |
zaneb | luckily the PollingTaskGroup can handle the latter easily | 21:57 |
SpamapS | shorter timeout will waste more of the engine's time | 21:57 |
SpamapS | I'm still in the "I know this is weird and new but I think it makes sense" camp. :-P | 22:00 |
*** pshchelo has quit IRC | 22:00 | |
SpamapS | Lots of things "block" during their create / check methods. | 22:01 |
*** jomara has quit IRC | 22:02 | |
SpamapS | grncdr: one thing though... is it really all that necessary to optimize this? | 22:02 |
SpamapS | grncdr: like can't you just block on any one of them for as long as it takes? | 22:03 |
*** jomara has joined #heat | 22:03 | |
SpamapS | if they were a logical OR ... parallel would make more sense.. but they are an AND | 22:03 |
openstackgerrit | Chmouel Boudjnah proposed a change to openstack/python-heatclient: Show better error when json fail to parse template https://review.openstack.org/62311 | 22:04 |
*** sgordon has quit IRC | 22:05 | |
zaneb | SpamapS: yep, and PollingTaskGroup does exactly that | 22:06 |
*** topol has quit IRC | 22:08 | |
SpamapS | zaneb: yeah, that seems much more sane. I don't even think the timeout needs lowering. | 22:10 |
*** IlyaE has quit IRC | 22:14 | |
zaneb | SpamapS, grncdr: I added a comment to that effect | 22:15 |
grncdr | sorry I had/have some ongoing interrupts at the moment :( will read the comments and fix/reply on gerrit | 22:17 |
sdake | matahari flashbacks on openstack-dev ml | 22:17 |
zaneb | orly? | 22:17 |
sdake | some cat debating c++ vs python | 22:17 |
sdake | because of footprint | 22:17 |
sdake | imo should have wrote his agent in c ;-) | 22:18 |
*** aweiteka has quit IRC | 22:18 | |
sdake | if it hurts, dont do it | 22:18 |
sdake | so far I've seen 5, count em 5, unified management agent programs derailed in my career | 22:19 |
sdake | pretty sure this unified agent in openstack will be #6 ;-) | 22:19 |
zaneb | sdake: which thread are we talking about? | 22:19 |
sdake | my thoughts on the unified guest agent | 22:20 |
zaneb | ah | 22:20 |
sdake | the long and arduous one which you have probably tuned out by now ;) | 22:20 |
zaneb | I never even got started on it | 22:20 |
zaneb | still have 94 unread emails just in [heat] :( | 22:20 |
sdake | probably bring back some PTSD - recommend avoiding ;) | 22:20 |
zaneb | lol | 22:21 |
*** pablosan has quit IRC | 22:21 | |
zaneb | I escaped fairly cleanly in the end ;) | 22:21 |
sdake | yes, yes you did ;) | 22:21 |
zaneb | I notice the matahariproject.org domain has been taken over by spammers | 22:22 |
openstackgerrit | Zane Bitter proposed a change to openstack/heat: Convert Neutron resources to new Schema format https://review.openstack.org/61823 | 22:23 |
sdake | heat-api.org up for renewal | 22:23 |
sdake | probably going to let it lapse | 22:23 |
sdake | be some good popcorn material see what the domain squatters do with it | 22:23 |
*** pablosan has joined #heat | 22:24 | |
stevebaker | shardy: https://wiki.openstack.org/wiki/Heat/Blueprints/InstanceUsers#5._Resource-scoped_virtual_keypairs <- you may want to add some Cons ;) | 22:24 |
openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Allow an in-progress stack to be deleted https://review.openstack.org/63002 | 22:29 |
zaneb | sdake: he disagrees with having a single standard for RPC? that's... weird | 22:33 |
*** Tross has quit IRC | 22:34 | |
wirehead_ | I know what I, were I to be a domain squatter, would do with it. | 22:36 |
*** swygue has quit IRC | 22:37 | |
zaneb | wirehead_: do tell :) | 22:38 |
wirehead_ | http://xkcd.com/624/ | 22:39 |
zaneb | well played | 22:40 |
* wirehead_ bows | 22:40 | |
stevebaker | I think I'll suggest every second heat meeting favours Asia over Europe http://www.timeanddate.com/worldclock/converted.html?iso=20140116T14&p1=2095&p2=0&p3=179&p4=137&p5=47&p6=33 | 22:41 |
stevebaker | 0100 UTC | 22:41 |
*** sgordon has joined #heat | 22:43 | |
*** sgordon has quit IRC | 22:43 | |
*** sgordon has joined #heat | 22:43 | |
zaneb | ugh 8pm :( | 22:44 |
stevebaker | yeah, i know | 22:44 |
stevebaker | zaneb: if you had a choice of slightly earlier or slightly later which would you prefer? | 22:45 |
zaneb | earlier | 22:45 |
stevebaker | 7pm? | 22:46 |
zaneb | would be better | 22:46 |
stevebaker | 8am might be a bit early for china office commuters | 22:46 |
zaneb | but probably more important that folks like liang can join | 22:46 |
*** vijendar has quit IRC | 22:47 | |
grncdr | ok, so I am getting rid of the greenlet pool and just doing the checks one after another, is using eventlet.connect still ok? or should I be using asyncore? | 22:49 |
grncdr | I was under the impression that using eventlet.connect would make my resource yield control | 22:49 |
grncdr | which I think it does, but maybe not to the right "level" | 22:49 |
grncdr | e.g. do I need to use something different to cooperate with heat.engine.scheduler | 22:50 |
SpamapS | sdake: the fact that you've seen so many agent unification efforts derailed is a nice piece of data actually. | 22:50 |
*** blomquisg has quit IRC | 22:50 | |
*** rpothier_ has quit IRC | 22:50 | |
zaneb | grncdr: how long is the timeout on connect? | 22:50 |
*** SnowDust has quit IRC | 22:50 | |
grncdr | I believe it's OS specific? | 22:51 |
grncdr | default is something like 60 seconds on most systems though | 22:51 |
grncdr | I could also go with the stdlib socket module | 22:52 |
grncdr | and set the timeout manually | 22:52 |
grncdr | as far as I can tell that would block the whole process though | 22:52 |
*** rongze has joined #heat | 22:53 | |
grncdr | eventlet.connect has no way to set timeouts, so I could create my own timeout and catch it, but that adds a lot of complication | 22:54 |
grncdr | s/complication/complexity/ | 22:55 |
zaneb | grncdr: make_connection() allows you to set the timeout, no? | 22:55 |
grncdr | I don't know make_connection... | 22:56 |
SpamapS | grncdr: eventlet has already monkeypatched the low level socket stuff, so may as well use eventlet.connect(). | 22:56 |
grncdr | you mean socket.socket.create_connection? | 22:56 |
*** dims_ has quit IRC | 22:57 | |
zaneb | er, yes | 22:57 |
grncdr | SpamapS: that's what I was thinking, but I wanted to get feedback here before spamming everybody with another review notification ;) | 22:59 |
*** rongze has quit IRC | 22:59 | |
grncdr | that being said, if (stdlib) socket is already monkey-patched | 22:59 |
grncdr | then maybe socket.create_connection makes more sense | 22:59 |
SpamapS | grncdr: the timeout stuff.. I'm also suspicious that you even need that. | 23:00 |
grncdr | SpamapS: honestly, *I* don't | 23:00 |
grncdr | I only need one port per resource | 23:00 |
SpamapS | the stack has a timeout.. it will give up eventually... :) | 23:00 |
grncdr | right, I was worried about causing the stack to give up incorrectly though | 23:01 |
grncdr | if you have say a 5min timeout on the resource, and 60s timeout on each connect... | 23:02 |
grncdr | hm, you know what, I think I just rubberducked myself out of the idea | 23:02 |
SpamapS | :) | 23:02 |
*** SnowDust has joined #heat | 23:03 | |
openstackgerrit | Stephen Sugden proposed a change to openstack/heat: Add PortCheck resource https://review.openstack.org/62078 | 23:03 |
*** blomquisg has joined #heat | 23:04 | |
zaneb | grncdr: did you intend to push that? it looks the same | 23:05 |
grncdr | huh? it looks different to me... | 23:05 |
*** Tross has joined #heat | 23:05 | |
grncdr | how do I diff against the previous patchset again? | 23:05 |
zaneb | ok, technically it's different | 23:06 |
zaneb | but it's still checking every port on every loop | 23:06 |
*** AndrewMichalik has joined #heat | 23:06 | |
zaneb | (go to Patch Sets up the top when you're looking at a diff) | 23:07 |
grncdr | ah there, found it | 23:07 |
grncdr | zaneb: yes it is? I obviously missed some feedback there | 23:07 |
grncdr | also it's only checking ports that haven't successfully connected | 23:07 |
* grncdr is re-reading previous review comment | 23:08 | |
zaneb | grncdr: the feedback you missed was to use the PollingTaskGroup | 23:08 |
zaneb | which implements the same algorithm, except better (yields as soon as one fails) | 23:09 |
*** SushilKM has quit IRC | 23:09 | |
grncdr | I see | 23:10 |
zaneb | reuse ftw | 23:10 |
*** dims_ has joined #heat | 23:13 | |
SpamapS | embrace the scheduler :) | 23:14 |
SpamapS | until we go to taskflow | 23:14 |
SpamapS | at which point... eschew the scheduler ;) | 23:14 |
zaneb | why can't I buy a Nokia 108 in the US? | 23:16 |
zaneb | it's only available in tinpot countries, like... France | 23:16 |
zaneb | :( | 23:16 |
grncdr | gah, I'm getting more confused now… do I run this PollingTaskGroup (using it's __call__) or do I yield it from my handle_create and assume that the engine knows what to do with it? | 23:19 |
grncdr | s/yield/return/ | 23:19 |
zaneb | grncdr: PollingTaskGroup is a task, so you pass it to TaskRunner the same as you were doing with self._wait | 23:20 |
* grncdr slaps forehead | 23:20 | |
*** andrew_plunk has quit IRC | 23:23 | |
openstackgerrit | Stephen Sugden proposed a change to openstack/heat: Add PortCheck resource https://review.openstack.org/62078 | 23:23 |
grncdr | crap, ignore that | 23:24 |
openstackgerrit | Stephen Sugden proposed a change to openstack/heat: Add PortCheck resource https://review.openstack.org/62078 | 23:25 |
*** Tross has quit IRC | 23:39 | |
*** rcleere has quit IRC | 23:46 | |
*** jergerber has quit IRC | 23:49 | |
*** gokrokve has quit IRC | 23:51 | |
*** jcru has quit IRC | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!