Thursday, 2015-03-19

*** alexpilotti has quit IRC00:01
*** jrist has joined #heat00:02
*** alexpilotti has joined #heat00:02
*** alexpilotti has quit IRC00:03
*** sdake_ has joined #heat00:04
*** alexpilotti has joined #heat00:04
*** alexpilotti has quit IRC00:06
*** sdake has quit IRC00:08
*** jamielennox is now known as jamielennox|away00:09
*** liusheng has quit IRC00:10
*** liusheng has joined #heat00:10
*** dims__ is now known as dims00:13
*** sdake has joined #heat00:13
*** achanda has quit IRC00:15
*** sdake_ has quit IRC00:17
*** jamielennox|away is now known as jamielennox00:23
*** __TheDodd__ has quit IRC00:32
*** Tango|2 has quit IRC00:35
openstackgerritMerged openstack/heat-templates: Update example template for 'docker-compose' hook  https://review.openstack.org/16504400:43
*** cdent has quit IRC00:48
openstackgerritSteve Baker proposed openstack/heat: Func tests use fedora-heat-test-image  https://review.openstack.org/16328700:50
openstackgerritSteve Baker proposed openstack/heat: WIP Enable software config integration test  https://review.openstack.org/16528700:50
openstackgerritSteve Baker proposed openstack/heat: iniset heat_integrationtests.conf  https://review.openstack.org/16528600:50
asalkeldrandall's keystone v2 patch broke my standalone:(00:57
stevebakerasalkeld: I run standalone with v3 now01:11
stevebakerasalkeld: this just landed https://review.openstack.org/#/c/141910/01:11
asalkeldstevebaker: ok - how you do that?01:11
asalkeldstevebaker: so - just update my devstack?01:12
stevebakerI'm seeing if I can do all my work with a devstack heat standalone pointing at a juno rdo cloud01:12
stevebakeryep01:12
asalkeldno special setup?01:12
asalkeldawesome!01:12
asalkeldnice work01:12
stevebakerseems to work01:12
asalkeldstevebaker: yip i have a mini desktop that is my "stable"  devstack01:12
asalkeldand laptop as heat devstack01:13
asalkeldworks really well01:13
stevebakerright, sounds very similar01:13
stevebakerI have mini dell running packstack01:13
asalkeldnice, I have one of these: http://shopap.lenovo.com/au/en/desktops/thinkcentre/tinys/01:14
asalkeldsame size as my router :-O01:14
*** achanda has joined #heat01:15
stevebakernifty01:16
*** LiJiansheng has joined #heat01:19
*** achanda has quit IRC01:21
openstackgerritMerged openstack/heat: Fix config drive not created when boot from volume  https://review.openstack.org/15345401:26
*** dgonzalez has quit IRC01:26
huangtianhuamorning all:)01:27
*** smc7 has joined #heat01:28
*** dgonzalez has joined #heat01:30
asalkeldhi huangtianhua01:32
*** smc7 has quit IRC01:33
*** aweiteka has joined #heat01:41
*** Marga_ has quit IRC01:43
*** spzala has quit IRC01:46
*** Kennan has joined #heat01:48
Kennan:sdake there?01:50
sdakekennan shoot01:50
Kennancould you tell me if heat autoscale used ceilometer alram or not?01:51
*** liuh has joined #heat01:51
Kennan:sdake I am not sure if ceilometer is the only choice for heat autoscale or not01:52
sdakei think so, but shardy or asalkeld would be your go to guy there01:53
sdakei haven't worked on heat for over a year01:53
asalkeldKennan: it can01:54
asalkeldKennan: more correctly, yes you should use it01:54
Kennan:asalkeld so heat used ceilometer alarm to trigger autoscale ?01:55
asalkeldyes01:55
asalkeldhttp://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Ceilometer::Alarm01:55
Kennanok. if without ceilometer alarm is it possible to trigger heat autoscale ?01:55
asalkeldKennan: sure, you just need to trigger the webhook01:56
asalkeldhttps://github.com/openstack/heat-templates/blob/master/hot/asg_of_stacks.yaml#L8301:57
*** Qiming has joined #heat01:57
asalkeldthat will give you the url's to post to - to scale up and down01:57
Kennan:asalkeld what do you think the better choice for heat autoscale ?01:58
Kennanwith ceilometer or not ?01:58
asalkeldKennan: well ceilometer gives us alarming functionality01:58
asalkeldyou could use what you want to do that01:58
asalkeldbut we test with ceilometer01:58
asalkeldso the scaling alarm/policy and group all work together01:59
asalkeldwe should really integrate with monasca at some point01:59
Kennanok. asalkeld: so heat receieve ceilometer alarm event and then trigger related autoscale, is it the right logic ?01:59
asalkeldyes01:59
asalkeldall ceilometer does is say "in alarm state, POST to configured webhook"02:00
asalkeldheat gets the webhook and actions the scaling02:00
Kennan:asalkeld  so when you talked about Monasca02:00
asalkeldso monasca has alarms too02:01
asalkeldand we should have alarm heat resources02:01
asalkeldto offer similar functionality02:01
Kennanwhat's the differnet with ceilometer and monasca, I think ceilometer did monitoring function02:01
Kennan?02:01
asalkeldas far as heat is concerned nothing02:01
Kennanlike instances images, cpus02:01
*** Yanyanhu has joined #heat02:02
asalkeldbut there is a lot of differences02:02
asalkeldthe period of evalution02:02
asalkeldand scaling concerns02:02
KennanOK. so you used monasca for another autoscale cases compared with ceilometer02:02
Kennanrigjht ?02:02
asalkeldi have never used monasca02:02
asalkeldbut am suggestion that we *should* integrate with it02:03
Kennanok. Thanks for info02:03
KennanGood to know that02:03
asalkeldno problem02:03
Qimingasalkeld, previously, team had some discussions about 'heatr'02:10
asalkeldQiming: what's that?02:10
Qiminga repo for heat templates?02:11
asalkeldo, that's right02:11
Qimingseveral months ago02:11
asalkeldyeah, just needs people to do it02:11
QimingI was wondering if we should provide such interfaces on Heat, instead of relying on other projects?02:11
asalkeldQiming: i would have thought glance is the place02:12
Qimingwe are saving all artifacts related to templates in db already02:12
asalkeldor a dedicated website02:12
Qimingthose are all options02:12
QimingI agree02:12
asalkeldQiming: you want global site? or something in horizon?02:12
Qimingno, I was just thinking about providing a repo of templates within Heat02:13
asalkeldmmm, not a big fan of that02:13
asalkeldi'd rather heat understands glance02:14
*** harlowja_ is now known as harlowja_away02:14
asalkeldand get_file can look in glance too02:14
asalkeldbut i understand that the artifact thingy is struggling to get in02:14
Qimingbut so far no progress on artifact storage in glance yet ..02:15
asalkeldhttps://review.openstack.org/#/q/status:open+project:openstack/glance+branch:master+topic:bp/artifact-repository,n,z02:15
asalkeldstill in review02:15
asalkeldpatch set 10402:15
Qimingokay, that is some real progress, cool02:16
Qimingthough still in review02:16
asalkeldcan't see it going in for k02:16
asalkeldmust be some real apathy from glance devs02:17
Qimingright, a pity is it02:17
asalkeldQiming: i think projects should be focused, heat is not really a file store02:17
Qiming... the artifact plugins loader -- 101 patchset? wow ...02:18
Qimingasalkeld, I understand that02:18
asalkeldthe other issue is how to share02:18
asalkelddo we want upstream templates (more formal version of heat-templates)02:19
QimingI was just thinking if that would be a convenience for template composition02:19
asalkeldok, like a std lib02:19
asalkeldkinda02:19
asalkeldi think glance is the way to go for that02:20
Qimingright, I didn't mean a repo02:20
openstackgerritMerged openstack/heat: Move test_notifications to functional  https://review.openstack.org/15257302:20
openstackgerritMerged openstack/heat: Docker plugin add restart policies and capability properties  https://review.openstack.org/16327702:20
*** reed has quit IRC02:20
asalkeldjust really disapointed with the progress02:20
*** erkules_ has joined #heat02:20
openstackgerritMerged openstack/heat: Fixes StackWatchService to use objects in place of db  https://review.openstack.org/16534902:20
Qimingagreed, if glance has it, we don't reinvent them02:20
Qiminganyway, 101 patchsets was .. a long march02:21
*** erkules has quit IRC02:23
asalkeldyeah, happy we don't block like that02:24
*** achanda has joined #heat02:27
*** dims has quit IRC02:28
*** aweiteka has quit IRC02:29
asalkeldwow found in embarrassing bug in the engine listener code02:30
*** randallburt has joined #heat02:45
*** randallburt has quit IRC02:45
*** randallburt has joined #heat02:46
*** strictlyb has quit IRC02:55
*** Yanyan has joined #heat02:56
asalkeldwho added the "heat-manage service list" ?02:57
*** Yanyanhu has quit IRC03:00
*** spzala has joined #heat03:01
*** coolsvap|afk is now known as coolsvap03:04
*** GonZo2K has quit IRC03:07
*** spzala has quit IRC03:11
*** vijayagurug has joined #heat03:15
*** Marga_ has joined #heat03:21
*** Marga_ has quit IRC03:21
*** Marga_ has joined #heat03:22
*** sdake_ has joined #heat03:22
openstackgerritRandall Burt proposed openstack/heat: Ignore migrating environments for deleted stacks  https://review.openstack.org/16485603:23
*** sdake has quit IRC03:26
*** Yanyanhu has joined #heat03:26
*** Yanyan has quit IRC03:29
*** coolsvap is now known as coolsvap|afk03:32
Kennan:asalkeld there?03:36
asalkeldyip03:36
KennanI followed heat developer guide and enable osprofiler03:36
Kennanubuntu@test-alarm:~$ heat --profile SECRET_KEY stack-list +----+------------+--------------+---------------+ | id | stack_name | stack_status | creation_time | +----+------------+--------------+---------------+ +----+------------+--------------+---------------+ Trace ID: 8a410e34-550f-4ac0-aabc-175c2e0a9384 To display trace use next command: osprofiler trace show --html 8a410e34-550f-4ac0-aabc-175c2e0a938403:36
KennanBut I used command following03:37
KennanI found03:37
Kennanubuntu@test-alarm:~$ osprofiler trace show --html 8a410e34-550f-4ac0-aabc-175c2e0a9384 Trace with UUID 8a410e34-550f-4ac0-aabc-175c2e0a9384 not found. There are 2 possible reasons:   1) You are using not admin credentials  2) You specified wrong trace id03:37
Kennan:asalkeld do you know the issue ?03:37
elynnMorning03:37
asalkeldKennan: i haven't tried for ages03:37
asalkeldboris-42: ^03:37
asalkeldKennan: try on #openstack-rally03:38
Kennanok. thanks03:39
asalkeldsorry it's been a couple of months since i tried03:39
*** coolsvap|afk is now known as coolsvap03:39
asalkeldmy head a bit out of ti03:39
*** achanda has quit IRC03:42
*** greghaynes has quit IRC03:43
*** achanda has joined #heat03:44
zanebw00t03:46
zanebtests are passing03:46
*** kebray has joined #heat03:48
*** kebray has quit IRC03:48
elynnHi I have a question, how to get nested stack resource attribute?03:53
elynn{get_attr: [neststack, resource.randstr, value]}03:54
elynnseems not work03:54
elynnoutput value is still null03:54
asalkeldelynn: check your template version03:54
asalkeldtry making it as new as possible03:54
*** sdake has joined #heat03:55
elynnI'm using 2013-05-2303:55
elynnIf I using a juno version03:55
asalkeldelynn: it's new'ish03:55
elynnis there any possible to get nested stack resource attribute?03:56
elynnor get nested stack outputs.03:56
asalkeldhttps://github.com/openstack/heat/commit/dacc3cc35fb48f7df1380323a9a800e510e048cc03:56
*** Yanyan has joined #heat03:57
elynnI follow this link http://docs.openstack.org/developer/heat/template_guide/composition.html but it doesn't work.03:57
asalkeldelynn: the "old" way it just to use outputs in the nested stack03:57
elynnso i can use a template like {get_attr: [neststack, outputs, key1]} to get outputs?03:58
*** sdake_ has quit IRC03:59
asalkeldelynn: {get_attr: [neststack, key1]}03:59
asalkeldthe output is converted to an attribute03:59
elynnCool, will have a try.04:00
*** Yanyanhu has quit IRC04:01
elynnIn master branch, I upgrade heat_template_version from 2013-05-23 to 2014-10-16, and get resource attributes worked.04:01
*** cmyster has quit IRC04:01
*** Yanyanhu has joined #heat04:01
asalkeldnice04:01
*** Yanyan has quit IRC04:02
*** cmyster has joined #heat04:02
*** vijayagurug has left #heat04:04
*** sdake has quit IRC04:04
*** achanda has quit IRC04:05
*** jamielennox is now known as jamielennox|away04:06
*** Yanyan has joined #heat04:09
cmystermorning04:13
cmysterstevebaker: still around ?04:13
*** Yanyanhu has quit IRC04:13
*** kebray has joined #heat04:14
openstackgerritZane Bitter proposed openstack/heat: Add a functional test for hooks/breakpoints  https://review.openstack.org/16465204:17
openstackgerritZane Bitter proposed openstack/heat: Add breakpoint support  https://review.openstack.org/14612304:17
openstackgerritZane Bitter proposed openstack/heat: Store Resources before they are created  https://review.openstack.org/16568604:17
*** Marga_ has quit IRC04:18
zanebstevebaker, asalkeld: could y'all keep an eye on those ^ and see if the tests pass?04:18
asalkeldok04:18
cmystermorning zaneb04:18
zanebIch gehe ins Bett04:18
cmysterand nn04:18
*** dims has joined #heat04:19
zanebcmyster: you're right, it is morning :(04:25
cmysterheh04:25
cmystertough night I see04:25
zanebyeah04:26
zanebbut I think the hooks/breakpoints patch is going to work now04:26
cmysterdon't worry zaneb, its always darkest before the dawn...04:26
*** Yanyanhu has joined #heat04:26
zanebso \o/04:26
cmysterindeed04:26
*** erkules_ is now known as erkules04:26
*** erkules has joined #heat04:26
cmysterI need to add more and more tests... damn this 24h...04:26
cmysterzaneb: could you please look at a link for a minute ?04:27
*** dims has quit IRC04:27
zanebsure04:27
cmystersec04:27
zanebugh, 7 hours 45 minutes until next meeting :/04:28
*** Yanyan has quit IRC04:28
asalkeldhar04:29
asalkeldslave to the meeting04:29
zanebg'night y'all \o04:34
cmysternn04:34
*** achanda has joined #heat04:37
*** sdake has joined #heat04:38
*** achanda has quit IRC04:41
*** Raj1 has joined #heat04:45
asalkeldbrb, picking kids up04:45
*** Raj1 has quit IRC04:46
*** Marga_ has joined #heat04:47
*** harlowja_at_home has joined #heat04:47
*** smc7 has joined #heat05:06
*** achanda has joined #heat05:08
*** smc7 has quit IRC05:11
*** sdake has quit IRC05:12
*** Raj1 has joined #heat05:15
*** Yanyan has joined #heat05:16
*** Yanyanhu has quit IRC05:20
*** liusheng has quit IRC05:26
*** liusheng has joined #heat05:26
*** rakesh_hs has joined #heat05:34
*** greghaynes has joined #heat05:39
*** Yanyanhu has joined #heat05:39
*** harlowja_at_home has quit IRC05:40
*** coolsvap is now known as coolsvap|afk05:41
*** Yanyan has quit IRC05:42
*** coolsvap|afk is now known as coolsvap05:48
*** KanagarajM has joined #heat05:57
openstackgerritOpenStack Proposal Bot proposed openstack/heat: Imported Translations from Transifex  https://review.openstack.org/16570106:02
*** sarob has quit IRC06:05
*** liuh_ has joined #heat06:07
*** Tango has joined #heat06:09
*** liuh has quit IRC06:10
*** liuh has joined #heat06:11
*** dims has joined #heat06:13
*** liuh_ has quit IRC06:14
*** Yanyan has joined #heat06:15
*** Yanyanhu has quit IRC06:18
*** dims has quit IRC06:19
*** Tango has quit IRC06:21
*** Yanyanhu has joined #heat06:23
*** Yanyan has quit IRC06:26
*** achanda has quit IRC06:28
*** Yanyan has joined #heat06:31
*** Yanyanhu has quit IRC06:35
*** kebray has quit IRC06:38
*** ishant has joined #heat06:43
*** Qiming has quit IRC06:47
*** achanda has joined #heat06:52
*** jcoufal has joined #heat06:53
*** smc7 has joined #heat06:55
*** jtomasek has joined #heat06:57
*** liuh_ has joined #heat06:59
*** achanda has quit IRC07:00
openstackgerritAngus Salkeld proposed openstack/heat: Set num_engine_workers=2 for gate functional tests  https://review.openstack.org/16539607:00
openstackgerritAngus Salkeld proposed openstack/heat: Fix the topic and sever that the listener client uses  https://review.openstack.org/16571207:00
openstackgerritAngus Salkeld proposed openstack/heat: Don't assume that there is one service per host  https://review.openstack.org/16571307:00
*** smc7 has quit IRC07:00
*** liuh has quit IRC07:01
*** achanda has joined #heat07:04
*** ifarkas has joined #heat07:05
*** sarob has joined #heat07:05
*** Marga_ has quit IRC07:09
*** sarob has quit IRC07:11
skraynevmorning guys07:16
asalkeldhi skraynev07:19
skraynevhi asalkeld07:19
shadowermorning07:23
*** ParsectiX has joined #heat07:23
*** Yanyan has quit IRC07:24
*** Qiming has joined #heat07:28
*** randallburt has quit IRC07:28
skraynevshadower: yeah, sunny morning :)07:29
shadowerskraynev: omg, right?07:29
skraynevshadower: yes:) spring comes to Russia.07:30
asalkeldautumn here and 36 degrees, waiting for it to finally cool down07:30
shadowerwow, that's really hot07:31
shadowerwe only get that in the summer07:32
*** jtomasek has quit IRC07:36
*** achanda has quit IRC07:37
*** jprovazn has joined #heat07:44
*** chlong has quit IRC07:47
*** nkhare has joined #heat07:48
*** pitr-ch has joined #heat07:49
*** Raj1 has quit IRC07:51
*** Qiming_ has joined #heat08:03
*** inc0 has joined #heat08:03
*** dims has joined #heat08:04
*** Qiming has quit IRC08:06
*** dims has quit IRC08:10
asalkeldskraynev: https://review.openstack.org/#/c/165686/08:12
asalkeldthat also *really* needs reviews ..08:12
skraynevasalkeld: ok. got it.08:12
asalkeldshadower: you need to hunt down cores to review that stuff08:14
shadowerah okay08:15
* shadower didn't want to bother people08:16
asalkeldtoday is the last day to get it in08:16
asalkeld(unless we get a FFE)08:16
asalkeldshadower: do lots of bothering08:16
asalkeldshadower: i'll get on it in a couple of mins - just fixin suppper for the kids08:17
shadowerok thanks08:17
*** jtomasek has joined #heat08:33
*** jistr has joined #heat08:37
*** Qiming_ is now known as Qiming08:41
*** Yanyan has joined #heat08:41
*** BManojlovic has joined #heat08:45
*** Yanyanhu has joined #heat08:49
*** Yanyan has quit IRC08:51
shardy_zmorning all08:55
*** shardy_z is now known as shardy08:55
shardyshadower: hooray, I see zaneb came up with another INIT_COMPLETE patch :)08:59
* shardy reviews08:59
*** inc0_ has joined #heat09:00
*** inc0 has quit IRC09:01
*** dulek has joined #heat09:03
*** randallburt has joined #heat09:03
*** dulek has quit IRC09:04
shadowershardy: yeah, and this one seems to be working :-)09:04
shadowerI think the breakpoint test failure is transient but the two functional ones are not -- looking at them now09:04
*** dulek has joined #heat09:04
shardyshadower: ah, OK I just rechecked against the timeout09:05
*** Yanyan has joined #heat09:10
*** sorantis has joined #heat09:11
*** kairat_kushaev has quit IRC09:14
asalkeldshardy: can you approve this https://review.openstack.org/#/c/161306/09:14
asalkeldshardy: i have a FFE on breakpoints btw09:14
shardyasalkeld: looking09:14
*** Yanyanhu has quit IRC09:15
shardyasalkeld: great, thanks - if we can fix the functional tests it may land today anyway :)09:15
asalkeld(don't stress, just do it well)09:15
shardyasalkeld: ack09:15
*** rdo has quit IRC09:16
*** dulek has quit IRC09:16
*** inc0_ has quit IRC09:16
shadowershardy: any idea why this is failing? http://logs.openstack.org/52/164652/4/check/check-heat-dsvm-functional-mysql/b94230a/console.html#_2015-03-19_05_31_00_25609:17
shadowerrelated code: https://review.openstack.org/#/c/164652/4/heat_integrationtests/functional/test_hooks.py (line 218)09:17
shadowerapparently the json for the "nested" resource we get back has "rel" = "self" instead of "rel" = "nested"09:18
shadowerso the assertion fails09:18
shadowerbut it is a nested stack, is it not?09:18
shardyshadower: it should have rel self and rel nested, if it's a nested stack09:19
shardyshadower: let me finish a couple of reviews then I'll pull it locally and reproduce09:19
shadowerthanks09:19
shardyit does look like it's failing to find the nested stack, but I'm not sure why atm09:19
*** kairat_kushaev has joined #heat09:19
shadowerI'll keep looking09:19
*** dims has joined #heat09:22
*** logan2 has quit IRC09:22
shardyskraynev: what are your thoughts re the comments in https://review.openstack.org/#/c/161306/6 ?09:22
*** logan2 has joined #heat09:22
asalkeldshadower: ttx what's to cut k3 at the latest at 21utc09:23
asalkeldshardy: ..09:23
shardyIMO the set rework isn't worth blocking for, but is it worth fixing the misleading docstrings then we can quickly approve?09:23
shardyfollowup patch is also fine09:23
*** inc0 has joined #heat09:24
shardyasalkeld: I'm fine with approving it now, I just thought if skraynev has 5 mins, we could fix the most obvious issues and not forget about them09:24
skraynevshardy: Oh I forgot to give answer. IMO, it's not major cases09:24
asalkeldskraynev: the doc strings are a bit messed up09:24
asalkeldshardy: and i are here, we can approve fast09:24
skraynevSure will fix it!09:24
shardyyeah that's all I really care about, a couple of docstrings are obviously wrong09:24
shardyif we don't do it now, we'll forget and it will confuse folks later09:25
skraynevsure guys give me a couple minutes to fix it :)09:25
asalkeldskraynev: just ping me, i am watching tv09:25
skraynevasalkeld: :) sure09:25
asalkeldshardy: fun things happen when we turn engine_workers > 109:26
asalkeldhttps://review.openstack.org/#/c/165712/09:26
shardyasalkeld: Hmm, yeah I saw your bug09:26
*** dims has quit IRC09:26
asalkeldseems like  it needs to be tests09:26
shardyI was testing TripleO with multiple workers last week and I didn't see any issues09:26
shardyyeah, historically it's not been well tested09:27
asalkeldthat's cancelling an action09:27
shardydo we know if the gate VMs have more than one core?09:27
asalkeldshardy: honestly not sure09:27
asalkeldi am not sure if it will actually make it faster09:27
asalkeldbut seems to test more09:27
shardyI'm assuming we'll only see performance benefits with more than one vCPU, although my local testing has been inconclusive so far09:28
*** pas-ha has joined #heat09:28
asalkeldyeah, tho' normally the 1 cpu is stuck at 100%09:28
asalkeldmulti workers you have 3 at 50-60%09:28
shardyYeah, probably we need to scale out over more real hardware to see significant benefits09:29
*** dulek has joined #heat09:29
Qiminghttp://eavesdrop.openstack.org/irclogs/%23heat/%23heat.2015-03-19.log09:32
pas-hamorning all09:34
*** derekh has joined #heat09:37
shardyshadower: hey, I noticed a minor error in the docs for https://review.openstack.org/#/c/146123/09:37
shardyotherwise it looks good to me now09:38
*** liusheng has quit IRC09:41
*** Yanyanhu has joined #heat09:41
shadowershardy: thanks, I'll fix that now09:42
*** liusheng has joined #heat09:42
shadowershardy: in the meantime, setting "expected_status" to CREATE_COMPLETE seems to fix the assert_resource_is_a_nested_stack issue09:43
* shadower is baffled09:43
shadowerare we hitting some sort of a race?09:43
shadowere.g. the nested stack has not been created yet when we try to look at it09:43
shardyshadower: well that does make sense, we can't get the nested ID until the stack create is finished09:44
*** Yanyan has quit IRC09:44
shardyshadower: FWIW I'd like to add recursive listing of events, which will make this easier09:44
shadoweryea09:44
* shardy pulls the patch and tries to reproduce09:44
*** dims has joined #heat09:45
shardyshadower: Oh, I added one more nit re the commit message, if you're reworking those docs anyway09:47
shadowershardy: I just hit git review but on a machine which doesn't have my gerrit info :-)09:49
shardyshadower: you're right, the self.stack_create returns before CREATE_COMPLETE< so the nested_identifier = self.assert_resource_is_a_stack needs to wait for the resource status09:50
*** Trozz has quit IRC09:50
shardyshadower: probably we need a call to _wait_for_resource_status before that line09:51
* shardy tests09:51
shadowershardy: yea but this seems to show that the breakpoint isn't being set in the nested stack, right?09:52
openstackgerritTomas Sedovic proposed openstack/heat: Add breakpoint support  https://review.openstack.org/14612309:52
shadowershardy: that should have the doc & commit fixes ^09:53
*** Trozz has joined #heat09:53
shardyshadower: Hmm, aren't we just trying to get the nested ID of something before it's started being created?09:53
shardyI'm trying making _wait_for_resource_status wait on "nested" to go CREATE_IN_PROGRESS before trying to get the nested ID09:54
shardymaybe even that is racy, given that we set the id after the state change09:55
shardybut we can't wait for CREATE_COMPLETE due to the hook09:55
*** Trozz is now known as Trozz_09:55
*** Trozz_ is now known as Trozz09:55
shardymaybe we need to poll for the nested id09:55
shadowershardy: right. But it does seem to succeed09:55
shadower(waiting for CREATE_COMPLETE)09:55
shadowerwhich means something is wrong09:55
*** tspatzier has joined #heat09:55
shardywell the hook will stop it (the parent "nested") during create_in_progress won't it?09:56
shardythen we need to poll for the nested ID, and inspect the events for the nested stack09:56
shardyyou're right though, it still doesn't work for me09:56
shadowershardy: it is supposed to. But apparently it's not being set on nested stacks for whatever reason09:56
shadoweror something09:56
shadowershardy: when I just changed CREATE_IN_PROGRESS to CREATE_COMPLETE in the "stack_create" call, it succeede09:57
shadowerwhich it shouldn't have09:57
shardyHmm, I've only teted this with provider resources, not type: foo.yaml09:57
*** sorantis has quit IRC09:57
shadowerI've tested it that way09:58
shadowerbut not recently09:58
shadowercould be we've broken something in the last few patches09:58
shardyyeah, possibly, I've not re-tested with tripleo for a couple of days09:58
shardyOh well, lets figure out what broke ;)09:59
*** inc0 has quit IRC09:59
openstackgerritSergey Kraynev proposed openstack/heat: Add way to collect map of needed attributes  https://review.openstack.org/16130610:00
*** sorantis has joined #heat10:01
skraynevshardy, asalkeld: new patchset uploaded. wait a Jenkins :)10:02
*** dulek has quit IRC10:05
*** dulek has joined #heat10:06
shadowershardy: yeah so hooks on nested resources don't appear to be set anymore10:08
*** Yanyan has joined #heat10:09
asalkeldskraynev: looking10:09
skraynevasalkeld: suggestions about correct doc are appreciated10:10
*** dulek_ has joined #heat10:10
asalkeldstill says "return a dictionary"10:11
asalkeldhttps://review.openstack.org/#/c/161306/7/heat/engine/function.py10:11
asalkeldskraynev: returns a list?10:11
*** dulek has quit IRC10:11
*** shaohe_robot has joined #heat10:11
*** alex_xu has quit IRC10:12
skraynevright10:12
skraynevasalkeld: yes10:12
*** shaohe_feng has quit IRC10:12
asalkeldare you going to do another quick patch?10:12
skraynevasalkeld: yes, I can (if it necessary )10:13
*** Yanyanhu has quit IRC10:13
skraynev*is's necessary10:13
asalkeldsure may as well make those correct10:13
skraynev*it's10:13
asalkeldeasy10:13
asalkeldbrb10:13
*** alex_xu has joined #heat10:14
*** Yanyanhu has joined #heat10:14
*** Yanyan has quit IRC10:14
*** Yanyanhu has quit IRC10:18
*** vijayagurug has joined #heat10:21
openstackgerritPeter Razumovsky proposed openstack/heat-specs: Improvements in deprecation process  https://review.openstack.org/15323510:27
*** inc0 has joined #heat10:30
*** sorantis has quit IRC10:32
*** tspatzier has quit IRC10:32
*** smc7 has joined #heat10:32
*** GonZo2K has joined #heat10:34
openstackgerritSergey Kraynev proposed openstack/heat: Add way to collect map of needed attributes  https://review.openstack.org/16130610:36
skraynevasalkeld: done.10:36
asalkeldthanks10:37
*** smc7 has quit IRC10:37
shadowershardy: so apparently, the resource_registry gets whittled down as it's being passed to nested stacks, but then when we check if a resource has a hook, its parent stack has the full registry again10:38
asalkeldskraynev: +2'd10:38
shadowermaybe the env changes are not being persisted?10:39
shadowershardy: do you think zane's patch may have caused that?10:39
skraynevasalkeld: thx for the pointing on missed place10:39
asalkeldnp10:39
*** coolsvap is now known as coolsvap|afk10:41
*** liuh_ has quit IRC10:42
*** tspatzier has joined #heat10:43
*** tspatzier has quit IRC10:55
shardyshadower: hmm, it looks like we're not storing the whittled down version from remove_resources_except10:56
shardybecause matches_hook in the nested template sees the parent resource registry10:56
shadowershardy: that's what I said10:56
shardye.g {u'nested': {u'foo_step2': {u'hooks': u'pre-create'}}}10:56
shadower(or at least that's what I meant)10:56
shadoweryeah so I got to the same conclusion10:57
shardyshadower: Yeah, I guess I'm just confirming I see the same thing ;)10:57
shadowershardy: any ideas why it might be? It used to work before...10:57
shadoweryeah, sorry :-)10:57
shardynot sure yet, trying to figure it out10:57
* shardy may need more coffee10:57
openstackgerritMerged openstack/heat: Store Resources before they are created  https://review.openstack.org/16568610:58
* shadower just brewed a nice cup of earl grey10:58
shardyshadower: Ooh, we're not storing the stack after the call to environment.get_child_environment11:01
shardywhich was fine before, but now the create/update happens via RPC, it won't work11:02
shardyHmm, although we're passing child_env via the RPC call...11:02
*** jaypipes has joined #heat11:04
*** nkhare has quit IRC11:05
openstackgerritPeter Razumovsky proposed openstack/heat-specs: Improvements in deprecation process  https://review.openstack.org/15323511:08
*** prazumovsky has joined #heat11:10
*** GonZo2K has quit IRC11:19
shardyshadower: I think we're forgetting to pass child_resource_name into environment.get_child_environment in StackResource.create_with_template11:21
shardyhttps://review.openstack.org/#/c/146123/22/heat/engine/environment.py11:22
shardyso we never hit the if child_resource_name on create, so the remove_resources_except is never called11:22
*** GonZo2K has joined #heat11:27
shadoweroh11:29
shadowershardy: I'll try it out, then11:29
shardyshadower: I needed to make some changes to the tests too, just re-testing then I can push what I have if you like?11:30
shadowershardy: that would be great11:31
shardyRan 6 tests in 90.847s OK11:31
shardy\o/11:31
shardyOk, let me remove all my debug logging :)11:31
*** nkhare has joined #heat11:32
*** coolsvap|afk is now known as coolsvap11:36
*** GonZo2K has quit IRC11:42
asalkeldany last review requests before i head to bed?11:43
shardyasalkeld: I'm about to push a new breakpoint patch, but given the FFE I guess that can wait11:45
asalkeldshardy: if it get's in that's fine too11:45
*** sorantis has joined #heat11:47
*** DaveJ__ has joined #heat11:48
openstackgerritPeter Razumovsky proposed openstack/heat: Add OS::Mistral::Workflow for Mistral workflows  https://review.openstack.org/14764511:49
*** prazumovsky has quit IRC11:50
*** nkhare has quit IRC11:51
*** dulek_ has quit IRC11:51
openstackgerritSteven Hardy proposed openstack/heat: Add a functional test for hooks/breakpoints  https://review.openstack.org/16465211:52
openstackgerritSteven Hardy proposed openstack/heat: Add breakpoint support  https://review.openstack.org/14612311:52
shardyshadower: ^^11:52
asalkeldshardy: watching TV some brittish guys doing "extreme ironing" :-O11:54
shardyasalkeld: doesn't everyone do that? :D11:55
asalkeldyes, ironing clothes on cliffs11:55
asalkeldmad11:55
shardyheh, sounds it11:55
cmystershardy: breakpoint tests seems fine, I need to try it myself though11:57
*** cdent has joined #heat11:59
* cmyster wonders if this patch will land...12:01
*** noakoffman has joined #heat12:04
shadowershardy: thanks! Looking at it12:06
shadowershardy: by the way, regarding the heatclient interface, I was thinking we keep breakpoints as they are now and then add a more generic hook functionality12:09
shadowerboth are useful depending on what you want to do imho12:09
shardyshadower: Hmm, ok, I'd assumed we'd align the terminology with the environment12:10
*** noakoffman has quit IRC12:10
*** blinky_ghost has joined #heat12:11
shardyFor me personally, just passing an additional environment file is probably good enough tbh12:11
shadowershardy: yeah, I was thinking more about the clearing command12:11
shadowerftr, I do want a proper hook-based interface. But they're conceptually different from breakpoints12:12
shardyyeah, I'd assumed we'd want hook-clear --pre-create mystack myresource12:12
openstackgerritKanagaraj Manickam proposed openstack/heat: Versioned-object StackLock  https://review.openstack.org/16536312:12
shardyor something, to avoid always sending a signal for every hook12:12
shadowershardy: hm, okay, thad't work12:12
*** noakoffman has joined #heat12:12
shardyshadower: Yeah, I guess I'm just questioning exposing the *breakpoint stuff at all in the client, given that it's now inconsistent with the resource registry interface12:13
shadowerhm, that's true, too12:13
shardyhaving two names for the same thing is invariably confusing ;)12:13
shardyI don't feel that strongly about it though, lets see what other folks think12:13
shardyat least the client isn't constrained by FF, so we can just press ahead with the heat part for now12:14
*** chlong has joined #heat12:14
shadowershardy: I'll look more into the client once the server stuff is done. Slowly coming over to your side on naming :-)12:15
*** noakoffman has quit IRC12:16
*** noakoffman has joined #heat12:16
*** sasuke_at_hp has joined #heat12:19
*** vijayagurug has left #heat12:21
*** KanagarajM has quit IRC12:21
*** sasuke_at_hp has quit IRC12:21
*** noakoffman has quit IRC12:22
*** noakoffman has joined #heat12:23
*** noakoffman has quit IRC12:24
*** sdake has joined #heat12:24
*** sdake_ has joined #heat12:25
*** Marga_ has joined #heat12:26
*** chlong has quit IRC12:26
*** lkarm has joined #heat12:26
*** blomquisg has quit IRC12:27
asalkeldshardy: can you keep an eye on this: https://review.openstack.org/#/c/161306/12:29
*** sdake has quit IRC12:29
asalkeldand approve when it passes tests?12:29
asalkeldit's the last blueprint for k312:30
asalkeldalso mark the bp as done please12:30
*** rdo has joined #heat12:30
* asalkeld heads to bed - night all12:30
*** asalkeld has quit IRC12:30
*** aweiteka has joined #heat12:31
*** htruta has quit IRC12:31
*** htruta has joined #heat12:32
*** noakoffman has joined #heat12:36
*** serg_melikyan has joined #heat12:37
*** noakoffman has quit IRC12:40
*** noakoffman has joined #heat12:41
*** achanda has joined #heat12:42
*** chlong has joined #heat12:43
*** dulek has joined #heat12:44
*** achanda has quit IRC12:47
*** blinky_ghost has left #heat12:48
shadowershardy: the patch survived everything I threw at it including nested stacks, wildcard hook on all ResourceGroup members and on a specifig member, too12:53
shadowershardy: so the patch has now been authored by four people, what's the protocol here? (assuming the tests pass)12:54
openstackgerritRakesh H S proposed openstack/heat: Convergence prepare traversal  https://review.openstack.org/15944412:54
*** noakoffman has quit IRC12:54
*** sasuke_at_hp has joined #heat12:58
*** noakoffman has joined #heat12:58
*** ParsectiX has quit IRC12:59
*** noakoffman has quit IRC13:00
*** noakoffman has joined #heat13:01
*** dims has quit IRC13:01
*** sdake_ has quit IRC13:01
*** dims has joined #heat13:02
*** noakoffman has quit IRC13:03
*** noakoffman has joined #heat13:03
*** noakoffman has quit IRC13:04
pas-hashadower, just add them all as Co-Authored-By: Name <email> to the commit message13:05
pas-hathat will be counted as commit by e.g. Stackalytics13:06
*** noakoffman has joined #heat13:06
pas-hahttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references last paragraph13:07
*** jistr has quit IRC13:08
*** noakoffman has quit IRC13:08
*** jistr has joined #heat13:09
*** tspatzier has joined #heat13:09
*** sdake has joined #heat13:09
shadowerpas-ha: I was thinking more about the reviews13:09
shadowerthose same people are pretty much the ones who would +2/A it...13:09
pas-haoh, I see it..13:10
*** noakoffman has joined #heat13:10
shardyshadower: FWIW I wasn't expecting any Co-Authored by attribution, my changes were pretty minor13:11
*** ParsectiX has joined #heat13:12
shardynormally if I collaborate on a patch and make significant changes, I'd add one myself, but it didn't seem justified in this case13:12
*** sdake_ has joined #heat13:12
shardyI'll review now we have something confirmed as working :)13:12
shadowerright, okay13:12
shadower:-)13:12
*** kaufer has joined #heat13:13
*** ParsectiX has quit IRC13:14
*** ParsectiX has joined #heat13:15
*** sdake has quit IRC13:16
*** sasuke_at_hp has quit IRC13:18
*** Qiming has quit IRC13:19
*** pm90_ has joined #heat13:19
*** Qiming has joined #heat13:19
*** pm90_ has quit IRC13:19
*** tspatzier has quit IRC13:19
*** pm90_ has joined #heat13:20
*** chlong has quit IRC13:21
*** tspatzier has joined #heat13:23
*** sdake has joined #heat13:25
*** pm90__ has joined #heat13:26
*** sasuke_at_hp has joined #heat13:27
*** sasuke_at_hp has quit IRC13:27
*** sasuke_at_hp has joined #heat13:28
*** sdake_ has quit IRC13:28
*** pm90_ has quit IRC13:29
zanebshardy, shadower: just finished reading scrollback. so we think we're in good shape?13:33
*** Marga_ has quit IRC13:35
shardyzaneb: I believe so, local functional tests pass, waiting for gate to confirm13:36
zaneb\o/13:37
shardyzaneb: thanks for your help getting the init_complete part sorted13:37
shadowerzaneb: yep!13:37
zanebnp, thanks for figuring out where all the subtleties were13:37
zanebthat was a big help13:37
shardyheh, I think I just reached the point where I'd looked at it for too long, glad we have it sorted now :)13:38
zaneblol, yeah, been there13:40
*** blomquisg has joined #heat13:40
*** ttx has joined #heat13:40
ttxohai, priority review on https://review.openstack.org/#/c/161306/, since it's blocking k313:40
zanebttx: IMHO we should not block for that13:41
ttxzaneb: asalkeld told me to, though13:42
zanebit's a building block for L, at the moment it's just dead code that is not called anywhere except for in unit tests13:42
zanebso I'm 100% comfortable landing it during feature freeze13:42
zanebor any other type of freeze13:42
ttxzaneb: noted :) I'll wait a bit more and cut without it if needed13:43
zanebkk13:43
*** sarob has joined #heat13:43
*** jprovazn has quit IRC13:43
zaneb(I will try to review it soon though)13:43
skraynevbtw, shardy: could you look at https://review.openstack.org/#/c/161306/13:43
skraynevmentioned above :) I have fixed docs13:44
skraynevor may be it's not necessary due to zaneb initiative :)13:44
*** ishant has quit IRC13:47
shardyttx: I'll review that now, as I already reviewed it a few hours ago13:47
*** sarob has quit IRC13:48
ttxcol, thx13:49
*** ParsectiX has quit IRC13:50
*** rakesh_hs has quit IRC13:51
*** inc0 has quit IRC13:56
*** serg_melikyan has quit IRC13:59
*** spzala has joined #heat13:59
*** InblEric has joined #heat14:00
*** ParsectiX has joined #heat14:01
*** smc7 has joined #heat14:07
*** radez_g0n3 is now known as radez14:09
*** serg_melikyan has joined #heat14:09
*** tspatzier has quit IRC14:12
*** randallburt has quit IRC14:14
*** dhellmann has quit IRC14:19
*** dhellmann has joined #heat14:19
openstackgerritMerged openstack/heat: Fixes SoftwareConfigService to use Resource object  https://review.openstack.org/16534214:20
*** KarolynChambers has left #heat14:21
*** vijendar has joined #heat14:26
*** jprovazn has joined #heat14:27
*** jcoufal_ has joined #heat14:29
*** sdake_ has joined #heat14:32
*** sdake_ has quit IRC14:32
*** jcoufal has quit IRC14:32
*** rpothier has joined #heat14:32
*** sdake__ has joined #heat14:33
*** sdake has quit IRC14:34
*** achanda has joined #heat14:35
*** tspatzier has joined #heat14:39
zanebshardy: I just reviewed skraynev's patch... IMO it's not worth rushing it to get in before FF, but I guess we can always just fix it later14:42
* zaneb shrugs14:42
*** tspatzier has quit IRC14:42
openstackgerritSergey Kraynev proposed openstack/heat: Fix missed docstring  https://review.openstack.org/16585514:42
*** spzala has quit IRC14:43
*** achanda has quit IRC14:43
skraynevzaneb, shardy: sorry for the missed place ^14:43
*** sarob has joined #heat14:44
skraynevzaneb: heh. now I am confused: should I fix all your comment in current patch or do another one?14:46
zanebskraynev: I'm not sure if anyone other than shardy can stop the current one from merging at this point14:48
*** InblEric1 has joined #heat14:48
skraynevA may try...14:48
zanebso I'd say start working on a separate patch, and if we end up not merging the current patch set you can squash them using git rebase -i14:48
skraynevzaneb: yeah. sure14:49
*** kebray has joined #heat14:49
*** sarob has quit IRC14:49
*** timbyr_ has joined #heat14:49
*** timbyr_ has quit IRC14:49
*** sasuke_at_hp has quit IRC14:50
*** InblEric has quit IRC14:50
*** jdob has quit IRC14:51
*** pm90__ has quit IRC14:51
*** jdob has joined #heat14:53
*** sarob has joined #heat14:56
*** kebray has quit IRC15:00
*** Raj2 has joined #heat15:01
*** jdob has quit IRC15:02
*** Raj2 has quit IRC15:03
*** Raj2 has joined #heat15:03
*** Drago has joined #heat15:05
*** Drago has quit IRC15:06
*** Drago has joined #heat15:06
*** ParsectiX has quit IRC15:07
*** sdake has joined #heat15:07
*** alexheneveld has joined #heat15:09
*** sasuke_at_hp has joined #heat15:09
openstackgerritSergey Kraynev proposed openstack/heat: Add functional test for AWS loadbalancer  https://review.openstack.org/15319215:10
*** spzala has joined #heat15:11
*** Marga_ has joined #heat15:11
*** sdake__ has quit IRC15:11
*** kebray has joined #heat15:14
*** serg_melikyan has quit IRC15:14
shadowershardy, zaneb: both patches failed with check-heat-dsvm-functional-mysql timing out again :-(15:16
zaneb:(15:16
shadowerit does look like https://bugs.launchpad.net/heat/+bug/1433555 to me15:16
openstackLaunchpad bug 1433555 in heat "functional tests are taking too long and cause false failures" [High,In progress] - Assigned to Angus Salkeld (asalkeld)15:16
shadowerbut maybe not?15:16
shadowerI didn't notice anything interesting in the logs15:16
shadowerwould you guys check if something jumps out at you?15:17
*** Qiming_ has joined #heat15:18
zanebshadower: I wasn't aware of that bug, but it does look very similar15:18
zanebcan we just increase the timeout?15:18
*** sasuke_at_hp has quit IRC15:20
shardyshadower: Yeah, I took a look at the logs, for some reason all the *group tests are taking forever on replacement updates15:20
shardywe're not using actual nova resources in them are we?15:20
* shardy checks15:20
*** Qiming has quit IRC15:21
*** sasuke_at_hp has joined #heat15:22
*** pm90_ has joined #heat15:27
*** sorantis has quit IRC15:28
*** LiJiansheng has quit IRC15:28
shardyLooks like we're overriding it with a provider resource, but the test still takes a really long time, even running locally on bare-metal15:30
*** sdake_ has joined #heat15:30
*** Qiming_ has quit IRC15:31
*** sdcf has joined #heat15:31
*** sorantis has joined #heat15:32
zanebshardy: logs show that tests were continuing to pass even 2 minutes before the timeout hit15:33
*** sdake has quit IRC15:34
zanebif the tests are just slow we should increase the timeout and try to improve them later imo15:34
zaneb(of course if there are tests that never complete then we have to fix that, but I'd guess that is not the case here)15:34
zanebtest_update_nochange_resource_needs_update [1049.335623s]15:36
openstackgerritSergey Kraynev proposed openstack/heat: Use outputs section for getting ip addresses  https://review.openstack.org/16588215:36
zanebouch15:36
zanebAutoScalingSignalTest.test_signal_with_policy_update [832.644550s]15:36
zaneball of AutoscalingGroupUpdatePolicyTest15:37
*** reed has joined #heat15:37
*** sasuke_at_hp has quit IRC15:37
zanebtest_instance_group_update_no_replace [698.874717s]15:37
zanebtest_instance_group_update_replace_huge_min_in_service [508.550756s]15:38
*** Tango has joined #heat15:38
zanebthose appear to be the worst offenders15:38
*** serg_melikyan has joined #heat15:39
shardyzaneb: Yeah, increasing the timeout seems a reasonable stopgap until we work out how to make things run faster15:42
pas-haI am rewriting neutron lb test to use cirros images, may be will become faster15:43
zanebhmm, I wonder if https://review.openstack.org/#/c/116336/ is slowing them down15:43
*** serg_melikyan has quit IRC15:44
zanebsuspicious that the bug asalkeld reported was from a test on that patch15:44
*** KanagarajM has joined #heat15:46
*** Trozz has quit IRC15:46
shardyHmm, it would indeed be interesting to see before/after numbers15:46
*** Trozz has joined #heat15:47
shadowerso I suppose we should just recheck in the meantime? (for the hook patches)15:47
shardyAlthough that enables better scalability, there's obviously some additional overhead in the single-node single-cpu case15:47
shardyI wouldn't have thought it was *that* much though..15:47
shardyshadower: +115:47
openstackgerritKanagaraj Manickam proposed openstack/heat: Versioned-object StackLock  https://review.openstack.org/16536315:53
cmysterzaneb: welcome back,16:02
zaneb:)16:02
cmysterzaneb: I'm confused do we have a meeting today ?16:02
cmyster\or, now ?16:03
zanebwe did but it was cancelled16:03
cmyster@ home so the calendar items are usless16:05
*** Raj2 has quit IRC16:05
*** Raj1 has joined #heat16:05
cmysterbbl16:06
*** jcoufal_ has quit IRC16:08
*** Raj2 has joined #heat16:08
*** Raj2 has quit IRC16:09
*** Raj1 has quit IRC16:09
*** Raj2 has joined #heat16:09
*** sorantis has quit IRC16:10
*** vijendar has quit IRC16:13
*** vijendar has joined #heat16:14
*** vijendar has quit IRC16:14
*** InblEric has joined #heat16:15
*** vijendar has joined #heat16:15
*** InblEric1 has quit IRC16:17
*** vijendar has quit IRC16:17
*** ttx has left #heat16:21
*** vijendar has joined #heat16:22
*** InblEric1 has joined #heat16:23
*** elynn_ has joined #heat16:23
*** Marga_ has quit IRC16:23
*** radez is now known as radez_g0n316:25
*** InblEric has quit IRC16:26
*** Raj2 has quit IRC16:26
*** pitr-ch has quit IRC16:30
*** sarob has quit IRC16:34
*** ifarkas has quit IRC16:35
*** BManojlovic has quit IRC16:44
Tangoshadower: Hi Tomas16:47
*** kaufer has quit IRC16:49
shadowerTango: hey Ton :-)16:49
*** ttx has joined #heat16:49
*** kaufer has joined #heat16:49
*** hdd has joined #heat16:49
ttxzaneb: that patch I was waiting on failed testing, so I think I'll tag without it. You said it's not critical anyway16:49
TangoI am trying out the hook patch (sorry I fell out of the loop for awhile). Is the resource_status_reason supposed to show something when a resource is paused?16:50
shadowerTango: yeah16:50
shadowerwell16:50
shadowerno, I don't think so16:50
shadowersorry16:50
Tangoshadower: it's showing blank16:51
shadowerit used to, but now the code changed not to change the resource status at all16:51
shadowerTango: it emits an event, but it doesn't change the status at any point16:51
Tangoshadower: ah I see, so I should look at the event list16:51
shadowerTango: check out _break_if_required in resource.py16:51
shadowerya16:51
shadowerTango: I'm thinking we want to have a programatic way of detecting breakpoints, but that can be a followup16:52
shadowerright now I'm just trying to get this merged ;-)16:52
Tangoshadower: yep, agree16:52
Tangoshadower: So with this, we can start to write a simple gdb-like debugger16:54
shadoweryeah16:54
Tangoshadower: The actual interfact to heat can change, but the user interface can stay the same16:54
shadoweryep, that's the plan :-)16:54
shadowerso the tripleo check succeeds an hour before the normal tests do. And they still may time out16:56
shadowersuper scary ^16:56
shadowerI was thinking "so how about we increase the timeout to something crazy like 2 hours". Then I realised that was already the case16:58
*** Raj1 has joined #heat16:58
*** Raj2 has joined #heat16:59
Tangoshadower: So typically a debugger will keep track of the breakpoints it sets, so if we can query the event list and somehow figure out which breakpoints are hit, then it should be sufficient16:59
*** Raj2 has quit IRC16:59
*** Raj1 has quit IRC16:59
*** Raj1 has joined #heat16:59
shadowerTango: yeah, but I'd like something better then checking the event string.16:59
shadowerplus it's kind of hard because we don't have a recursive event list now16:59
shadowerso you have to check all nested stacks17:00
Tangoshadower: OK, that would certainly help17:00
*** derekh has quit IRC17:02
*** jistr has quit IRC17:07
*** harlowja_away is now known as harlowja_17:09
*** Marga_ has joined #heat17:13
*** Marga_ has quit IRC17:17
ttxtagging heat kilo-317:18
*** dulek has quit IRC17:18
*** pitr-ch has joined #heat17:24
ttxheat kilo-3 tagged: https://launchpad.net/heat/+milestone/kilo-317:26
*** achanda has joined #heat17:28
*** achanda has quit IRC17:28
*** achanda has joined #heat17:28
ryansbshadower: not sure adding a status is the way to go for that17:33
ryansbI kind of prefer it to just be an event and use the existing statuses we have17:33
*** Raj1 has quit IRC17:33
*** coolsvap is now known as coolsvap|afk17:33
*** packet has joined #heat17:35
shadowerryansb: yeah, I didn't mean to say that adding a status is the way to go17:35
shadowerbut it'd be better to make this data more readily available17:35
shadowere.g. right now, if you want to check whether your stack is waiting on a breakpoint, you have to list events of the entire nested stack tree17:36
shadowerand parse a string that's potentialy translated and/or subject to change17:36
ryansbtrue17:37
*** pm90_ has quit IRC17:43
*** pm90_ has joined #heat17:44
*** Marga_ has joined #heat17:44
*** rakesh_hs has joined #heat17:45
zanebttx: ack, thanks17:47
*** Marga__ has joined #heat17:47
*** sdcf has quit IRC17:48
*** Marga_ has quit IRC17:48
zanebso it looks like a high proportion of patches are going to be timing out on the functional test jobs, judging by the fact that https://review.openstack.org/161306 also failed17:48
zanebwhich makes me suspect even more strongly that the RPC nested stacks thing is the cause17:49
*** Raj1 has joined #heat17:52
*** Raj2 has joined #heat17:52
*** smc7 has quit IRC17:56
*** Raj1 has quit IRC17:56
*** alexheneveld has quit IRC17:57
*** Raj2 has quit IRC17:57
*** Raj1 has joined #heat17:58
*** kaufer1 has joined #heat17:58
*** kaufer has quit IRC17:59
*** reed has quit IRC17:59
*** boris-42 has quit IRC18:02
openstackgerritPavlo Shchelokovskyy proposed openstack/heat: Use CirrOS image in Neutron Loadbalancer test  https://review.openstack.org/16594418:03
*** GonZo2K has joined #heat18:09
*** GonZo2K has quit IRC18:09
*** GonZo2K has joined #heat18:09
*** sdake_ has quit IRC18:09
*** elynn_ has quit IRC18:10
pas-haguys, how should I regenerate heat_integrationtest.conf.sample?18:10
*** sdake has joined #heat18:11
*** coolsvap|afk has quit IRC18:11
*** Marga__ has quit IRC18:11
*** Marga_ has joined #heat18:12
*** Marga_ has quit IRC18:12
*** fd has joined #heat18:12
*** Marga_ has joined #heat18:13
pas-hanm, problem solved18:13
*** KanagarajM has quit IRC18:14
*** Marga_ has quit IRC18:14
*** Marga_ has joined #heat18:15
*** KanagarajM has joined #heat18:15
*** rakesh_hs has quit IRC18:19
*** cdent has quit IRC18:19
*** Drago1 has joined #heat18:21
*** Drago1 has quit IRC18:22
*** Drago1 has joined #heat18:22
*** Drago has quit IRC18:23
*** Drago1 has quit IRC18:24
openstackgerritPavlo Shchelokovskyy proposed openstack/heat: Use CirrOS image in Neutron Loadbalancer test  https://review.openstack.org/16594418:26
*** reed has joined #heat18:29
*** spzala has quit IRC18:30
openstackgerritPavlo Shchelokovskyy proposed openstack/heat: Update integrations tests config sample  https://review.openstack.org/16595818:32
*** blomquisg has quit IRC18:33
*** fd has quit IRC18:34
*** pm90__ has joined #heat18:38
*** blomquisg has joined #heat18:40
*** Drago has joined #heat18:41
*** pm90_ has quit IRC18:41
*** hdd has quit IRC18:42
*** Marga_ has quit IRC18:42
*** jprovazn has quit IRC18:43
*** kebray has quit IRC18:44
*** Marga_ has joined #heat18:45
*** JK__ has joined #heat18:46
*** smc7 has joined #heat18:46
*** pm90__ has quit IRC18:48
*** pm90_ has joined #heat18:49
*** spzala has joined #heat18:52
*** radez_g0n3 is now known as radez18:52
*** randallburt has joined #heat19:05
*** randallburt has quit IRC19:06
*** randallburt has joined #heat19:06
*** Marga_ has quit IRC19:06
*** JK__ has quit IRC19:08
*** dsneddon is now known as dsneddon_lunch19:09
*** elynn_ has joined #heat19:10
*** elynn_ has quit IRC19:16
pas-hag'night all19:16
*** pas-ha has quit IRC19:17
*** ttx has left #heat19:22
*** Marga_ has joined #heat19:24
*** Marga_ has quit IRC19:25
*** hdd has joined #heat19:26
*** kaufer1 has quit IRC19:30
*** kaufer has joined #heat19:30
stevebakermorning19:39
stevebakerzaneb: I'm suspecting regression on the RPC patch too https://bugs.launchpad.net/heat/+bug/1433555/comments/319:40
openstackLaunchpad bug 1433555 in heat "functional tests are taking too long and cause false failures" [Critical,In progress] - Assigned to Angus Salkeld (asalkeld)19:40
zanebstevebaker: on a call atm19:40
stevebakerkk19:40
*** dsneddon_lunch is now known as dsneddon19:43
*** KanagarajM has quit IRC19:44
*** sdake_ has joined #heat19:48
*** metral is now known as metral_zzz19:50
*** sdake has quit IRC19:51
*** sasuke_at_hp has joined #heat19:51
*** sdake has joined #heat19:53
*** sdake_ has quit IRC19:55
*** Marga_ has joined #heat19:55
*** sasuke_at_hp has quit IRC19:56
zanebstevebaker: back19:58
zaneboh great, Heisenbugs19:59
zanebthat's all we need19:59
zanebhmm, apparently we also have the typical pre-release problem with slow nodes as well: https://bugs.launchpad.net/openstack-ci/+bug/131106620:06
openstackLaunchpad bug 1311066 in OpenStack-Gate "Some nodes allocated in node pool are very very slow" [High,Confirmed]20:06
*** shardy has quit IRC20:07
*** Marga_ has quit IRC20:08
*** kebray has joined #heat20:11
*** elynn_ has joined #heat20:13
*** elynn_ has quit IRC20:19
stevebakerug, I really need a recursive heat event-list20:26
*** dims has quit IRC20:34
*** Marga_ has joined #heat20:38
*** randallburt1 has joined #heat20:41
*** randallburt has quit IRC20:42
*** radez is now known as radez_g0n320:43
*** randallburt1 has quit IRC20:47
*** jaypipes has quit IRC20:50
*** Marga_ has quit IRC20:52
*** Marga_ has joined #heat20:52
*** sasuke_at_hp has joined #heat20:53
*** Marga_ has quit IRC20:54
*** dulek has joined #heat20:54
*** Marga_ has joined #heat20:54
*** sasuke_at_hp has quit IRC20:58
*** dulek has quit IRC20:59
*** blomquisg has quit IRC21:01
shadowerzaneb, stevebaker: all tests on https://review.openstack.org/#/c/146123/ and https://review.openstack.org/#/c/164652/ have passed \o/21:05
shadowercan I get a +A?21:05
zaneb\o/ !!!21:05
stevebakerapproved21:06
shadowerthanks!21:07
*** pitr-ch has quit IRC21:07
*** InblEric1 has quit IRC21:14
*** Marga_ has quit IRC21:14
*** InblEric1 has joined #heat21:15
*** Marga_ has joined #heat21:15
stevebakerCould you please look at this? http://paste.openstack.org/show/193688/21:15
*** elynn_ has joined #heat21:16
stevebakerweird delay after 07:37Z. All resources are UPDATE_COMPLETE in 6 seconds, but JobServerGroup doesn't go to UPDATE_COMPLETE until 09:16Z21:17
*** radez_g0n3 is now known as radez21:17
*** elynn_ has quit IRC21:21
*** aweiteka has quit IRC21:22
*** achanda has quit IRC21:28
Tangoshadower: Buy you a beer at Vancouver :)21:29
shadower:-)21:30
shadowerwouldn't have done it without shardy and zaneb's help21:30
Tangoah then beer for everyone :)21:34
*** asalkeld has joined #heat21:34
asalkeldmorning21:34
shadowerevening :-)21:34
*** achanda has joined #heat21:37
*** InblEric1 has quit IRC21:37
*** alexpilotti has joined #heat21:39
*** dims has joined #heat21:39
*** alexheneveld has joined #heat21:41
asalkeldshadower: did you get your patch in?21:41
asalkeldlooks like no21:42
asalkeldok, coffee time21:43
shadowerasalkeld: they're approved, waiting for the gate jobs now21:45
asalkeldok21:45
*** Drago1 has joined #heat21:49
*** Drago has quit IRC21:49
*** Drago1 has quit IRC21:49
Tangoasalkeld: Hi Angus21:49
asalkeldhi Tango21:49
*** blues-man has joined #heat21:49
asalkeldi am just organising breakfast in-n-out21:50
Tangoasalkeld: when you have a chance, can you take another look at https://review.openstack.org/#/c/154618/  ?21:50
*** rpothier has quit IRC21:51
asalkeldok21:52
*** achanda has quit IRC21:53
Tangoasalkeld: Thanks!21:54
*** kaufer has quit IRC21:56
*** hdd has quit IRC21:59
*** achanda has joined #heat22:01
*** lkarm has left #heat22:05
*** dsneddon is now known as dsneddon_afk22:07
*** jamielennox|away is now known as jamielennox22:09
stevebakerasalkeld: you could be right about refresh() not working, but I wonder if it is our object refresh() which is the issue rather than oslo22:11
asalkeldyeah, might be22:11
asalkeldstevebaker: also looking at that refresh, it returns the object but doesn't refresh the local object22:13
asalkeldso if I obj.refresh(), then use obj, it will be the same obj22:14
asalkeldweird22:14
stevebakerright, so it needs to be obj = obj.refresh()22:14
*** packet has quit IRC22:15
stevebakerhmm, maybe not. I haven't really looked into this versioned object stuff yet22:16
*** elynn_ has joined #heat22:17
*** dims has quit IRC22:19
*** Marga_ has quit IRC22:21
*** Marga_ has joined #heat22:21
*** elynn_ has quit IRC22:21
*** Raj1 has quit IRC22:23
asalkeldbrb, school run22:27
stevebakeri may have a fix when you're back22:29
*** Raj1 has joined #heat22:29
*** boris-42 has joined #heat22:36
*** sasuke_at_hp has joined #heat22:41
openstackgerritSteve Baker proposed openstack/heat: Call db refresh in Stack object refresh  https://review.openstack.org/16603022:42
stevebakerfix for critical bug ^22:42
stevebaker(well, an attempt at a fix, works for my sample size)22:43
*** radez is now known as radez_g0n322:44
*** Raj1 has quit IRC22:45
*** sasuke_at_hp has quit IRC22:46
*** smc7 has quit IRC22:46
*** Raj1 has joined #heat22:46
asalkeldooo well done stevebaker22:48
asalkeldlet's watch the times22:48
*** vijendar has quit IRC22:49
*** Raj2 has joined #heat22:50
*** Raj1 has quit IRC22:51
*** pm90_ has quit IRC22:53
asalkeldstevebaker: did you see zaneb zabana query22:53
asalkeldthey did seem to start with oslo reviews22:54
openstackgerritMerged openstack/heat: Add breakpoint support  https://review.openstack.org/14612322:54
asalkeldstevebaker: resource also has a refresh22:58
openstackgerritAngus Salkeld proposed openstack/heat: Correct confusing "cls" argument on non-static method  https://review.openstack.org/16603623:10
*** Raj2 has quit IRC23:10
*** Raj1 has joined #heat23:11
*** blues-man has quit IRC23:16
asalkeldhttps://etherpad.openstack.org/p/heat-timeout-bug23:17
*** elynn_ has joined #heat23:18
*** elynn_ has quit IRC23:22
*** chlong has joined #heat23:27
*** pm90_ has joined #heat23:31
*** pm90_ has quit IRC23:31
*** pm90_ has joined #heat23:31
ramishrastevebaker: Hi!.. thanks for the feedback on https://review.openstack.org/#/c/164572/4, I've reduced on the image size to 400+MB.  I'll upload the uploaded patch.23:32
ramishrastevebaker: could not test it yesterday as I had to rebuild my setup.23:33
*** Marga_ has quit IRC23:36
*** Marga_ has joined #heat23:36
*** Drago has joined #heat23:39
*** Drago has quit IRC23:40
*** Drago has joined #heat23:41
*** tochi has joined #heat23:42
*** Drago has quit IRC23:42
*** Drago has joined #heat23:42
*** kebray has quit IRC23:43
*** dsneddon_afk is now known as dsneddon23:45
*** radez_g0n3 is now known as radez23:45
*** Raj1 has quit IRC23:46
*** derekh has joined #heat23:50
*** derekh has quit IRC23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!