| kata-irc-bot | <samuel.ortiz> Folks, any idea why we’re not adding a GNU build-id note with our 2.2 binaries? Only the Go one is left… | 09:42 |
|---|---|---|
| kata-irc-bot | <fidencio> Hmm. Is it something that changed between 2.1 and 2.2 cycles? | 10:10 |
| kata-irc-bot | <fidencio> No, no idea, just trying to have a window to think of possible changes ... | 10:11 |
| kata-irc-bot | <samuel.ortiz> I don’t see anything special…but when building our 2.2 RPMs, we can no longer build the debuginfo one because the binary is missing the gnu build-id note. | 10:16 |
| kata-irc-bot | <samuel.ortiz> But when switching back to the 2.1.1 tag, my containerd-shim-kata-v2 does have a bunch of ELF notes that the 2.2.0 generated binary does not have. | 10:20 |
| kata-irc-bot | <samuel.ortiz> Including a .note.gnu.build-id one… | 10:21 |
| kata-irc-bot | <fidencio> I think I know how this happened. | 10:35 |
| kata-irc-bot | <fidencio> I *think* this may be a regression introduced as part of #2155 | 10:36 |
| kata-irc-bot | <fidencio> Wait, wait, wait ... "when building our 2.2 RPMs" | 10:37 |
| kata-irc-bot | <fidencio> That may be a bug on your spec file. @samuel.ortiz | 10:37 |
| kata-irc-bot | <fidencio> Take a look at https://src.fedoraproject.org/rpms/kata-containers/blob/rawhide/f/kata-containers.spec#_11 and see if you're using something similar there | 10:38 |
| kata-irc-bot | <samuel.ortiz> @fidencio When I manually build (`make containerd-shim-v2`), I see the same difference between 2.1.1 (it *has* a gnu build-d) and 2.2.0 (It does not have one) | 10:39 |
| kata-irc-bot | <fidencio> Hmm. That's interesting. | 10:39 |
| kata-irc-bot | <samuel.ortiz> @fidencio Looking at your spec file: Can you build a 2.2.0 RPM with with_debug? | 10:40 |
| kata-irc-bot | <samuel.ortiz> find-debug-info.sh is where ours fail. | 10:40 |
| kata-irc-bot | <fidencio> It's been a long time I don't check that, let me give it a try :slightly_smiling_face: | 10:41 |
| kata-irc-bot | <fidencio> bingo! ```*** ERROR: No build ID note found in /home/fidencio/rpmbuild/BUILDROOT/kata-containers-2.2.0-1.fc34.x86_64/usr/libexec/kata-containers/kata-netmon``` | 10:45 |
| kata-irc-bot | <samuel.ortiz> Somehow I’m relieved :slightly_smiling_face: | 10:45 |
| kata-irc-bot | <samuel.ortiz> But concerned at the same time… | 10:45 |
| kata-irc-bot | <samuel.ortiz> @fidencio all 2.2.0 binaries no longer have the gnu build-id note. | 10:45 |
| kata-irc-bot | <fidencio> yeah, debugging that *right now* | 10:46 |
| kata-irc-bot | <fidencio> Regression happened between 2.2.0-alpha0 and 2.2.0-alpha1 | 10:49 |
| kata-irc-bot | <fidencio> Now let's hope `git blame` doesn't become `git shame` :slightly_smiling_face: | 10:50 |
| kata-irc-bot | <samuel.ortiz> :slightly_smiling_face: Are you bisecting this? Or should I? | 10:56 |
| kata-irc-bot | <fidencio> I am :slightly_smiling_face: | 10:56 |
| kata-irc-bot | <fidencio> #2040 is the faulty PR | 10:59 |
| kata-irc-bot | <fidencio> 32c9ae1388385f10c75d9a76809f1d419e82b020 is the commit, I think (can't build) | 11:01 |
| kata-irc-bot | <fidencio> 15d37d582327771058406b89546a0678a71a0a19 is the first buildable commit without the build-id notes | 11:03 |
| kata-irc-bot | <samuel.ortiz> So much for fully bisectable trees.. | 11:06 |
| kata-irc-bot | <samuel.ortiz> Thanks @fidencio, that’s what I got through bisecting as well. | 11:07 |
| kata-irc-bot | <samuel.ortiz> This PR brings ldflags changes through the containerd revendoring. | 11:13 |
| kata-irc-bot | <fidencio> Yep! | 11:13 |
| kata-irc-bot | <samuel.ortiz> I wonder how can they propagate into our build… | 11:14 |
| kata-irc-bot | <samuel.ortiz> @fidencio Lunch break for me, I’ll get back to debugging that after lunch. | 11:16 |
| kata-irc-bot | <fidencio> Ack, let me know if you need any help | 11:16 |
| kata-irc-bot | <christophe> Ah, I got this abuse email too. But if you read it completely, you'll find ```Leaseweb Global B.V. is based in and processes abuse notifications in accordance with the statutory requirements of . For further information, please visit www.leaseweb.com/abuse. This web page also describes LeaseWeb's requirements for abuse notifications. To guarantee proper resolution of your notification, please ensure that it complies with these | 13:34 |
| kata-irc-bot | requirements. Sincerely, Leaseweb Global B.V.``` So my guess is that this is someone who subscribed to the list with some kind of aggressive spam filter. | 13:34 |
| kata-irc-bot | <thierry> Sure enough, abuse@de.leaseweb.com was subscribed -- I unsubbed them. | 13:54 |
| kata-irc-bot | <fidencio> Thanks! | 14:24 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!