fungi | ahh, cool | 00:00 |
---|---|---|
*** tosky has quit IRC | 00:20 | |
openstackgerrit | Merged opendev/system-config master: Add an OpenDev theme into our Gerrit image https://review.opendev.org/c/opendev/system-config/+/765422 | 00:39 |
*** brinzhang has joined #opendev | 00:54 | |
ianw | i can restart with that, probably as good a quiet time as any | 00:54 |
fungi | thanks! | 01:46 |
ianw | ok, promote worked, i'll restart it | 01:57 |
ianw | #status log restarted gerrit with themeing from #765422 | 02:00 |
openstackstatus | ianw: finished logging | 02:00 |
*** d34dh0r53 has joined #opendev | 03:59 | |
*** whoami-rajat__ has joined #opendev | 04:44 | |
*** raukadah is now known as chandankumar | 05:17 | |
*** chandankumar is now known as chkumar|ruck | 06:09 | |
*** chkumar|ruck is now known as chkumar|rover | 06:14 | |
*** marios has joined #opendev | 06:25 | |
*** marios is now known as marios|rover | 06:32 | |
*** chkumar|rover is now known as chkumar|ruck | 06:35 | |
*** fnordahl has quit IRC | 06:58 | |
openstackgerrit | Merged openstack/project-config master: Add 'Abandon' permission for retired repo ACL https://review.opendev.org/c/openstack/project-config/+/765583 | 07:34 |
*** sboyron_ has joined #opendev | 07:54 | |
*** fressi has joined #opendev | 08:21 | |
*** andrewbonney has joined #opendev | 08:28 | |
avass | ooh opendevs gerrit is looking nice | 08:30 |
*** fdegir has quit IRC | 08:34 | |
*** fressi has quit IRC | 08:34 | |
*** fdegir has joined #opendev | 08:34 | |
*** lpetrut has joined #opendev | 08:44 | |
*** rpittau|afk is now known as rpittau | 08:46 | |
*** hashar has joined #opendev | 09:02 | |
noonedeadpunk | Hey everyone! Any how-to about the way of reviving a repo? Or it should be just revert steps of the retirement process? | 09:25 |
*** DSpider has joined #opendev | 09:27 | |
*** dtantsur|afk is now known as dtantsur | 10:07 | |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Deprecate openstack-ansible-galera_client role https://review.opendev.org/c/openstack/project-config/+/765777 | 10:28 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Remove noop jobs for galera_client deprecation https://review.opendev.org/c/openstack/project-config/+/765783 | 10:56 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Deprecate openstack-ansible-galera_client role https://review.opendev.org/c/openstack/project-config/+/765777 | 11:02 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Remove noop jobs for galera_client deprecation https://review.opendev.org/c/openstack/project-config/+/765783 | 11:02 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Deprecate openstack-ansible-galera_client role https://review.opendev.org/c/openstack/project-config/+/765777 | 11:04 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Deprecate openstack-ansible-galera_client role https://review.opendev.org/c/openstack/project-config/+/765777 | 11:09 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Remove noop jobs for galera_client deprecation https://review.opendev.org/c/openstack/project-config/+/765783 | 11:11 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Remove noop jobs for galera_client deprecation https://review.opendev.org/c/openstack/project-config/+/765783 | 11:11 |
openstackgerrit | Martin Kopec proposed openstack/project-config master: Move ansible-role-refstack-client from x/ to osf/ https://review.opendev.org/c/openstack/project-config/+/765787 | 11:18 |
*** tosky has joined #opendev | 11:22 | |
*** frickler has joined #opendev | 12:01 | |
*** fressi has joined #opendev | 12:04 | |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Revive os_monasca https://review.opendev.org/c/openstack/project-config/+/765799 | 12:30 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Revive os_monasca https://review.opendev.org/c/openstack/project-config/+/765799 | 12:33 |
*** hashar has quit IRC | 12:40 | |
*** hashar has joined #opendev | 12:40 | |
*** priteau has quit IRC | 12:40 | |
*** fressi has quit IRC | 12:41 | |
*** hashar has quit IRC | 12:42 | |
openstackgerrit | Balazs Gibizer proposed opendev/elastic-recheck master: Add query for bug 1907084 https://review.opendev.org/c/opendev/elastic-recheck/+/765801 | 12:45 |
openstack | bug 1907084 in tempest "test_attach_scsi_disk_with_config_drive intermittently fails at detaching volume" [Undecided,New] https://launchpad.net/bugs/1907084 | 12:45 |
*** hashar has joined #opendev | 13:05 | |
*** fressi has joined #opendev | 13:06 | |
fungi | noonedeadpunk: you got it, revert the retirement changes in reverse order, so start by undoing the acl change (but this first step may also require assistance from a gerrit admin if the acl sets it to read-only state as that can't be undone through our normal automation) | 13:07 |
noonedeadpunk | fungi: so this is not going to work? https://review.opendev.org/c/openstack/project-config/+/765799/2/gerrit/projects.yaml | 13:11 |
fungi | noonedeadpunk: i think it should work, because the retired project was using https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/retired.config which doesn't set the repo entirely read-only | 13:14 |
noonedeadpunk | fungi: so https://review.opendev.org/c/openstack/project-config/+/765799/2/gerrit/projects.yaml won't do the trick? | 13:15 |
fungi | noonedeadpunk: like i said, i believe what you have there will work as you expect, yes | 13:15 |
noonedeadpunk | except I need to make that in 2 different patches I guess. | 13:16 |
noonedeadpunk | ok, thanks) | 13:16 |
fungi | if it had been using https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/opendev/retired.config instead of openstack/retired.config then there would be a problem undoing it | 13:16 |
fungi | but since the existing retirement acl for openstack repos doesn't set project.state="read only" any longer, we can rely on our automation to apply changes like the one you proposed | 13:17 |
noonedeadpunk | oh, ok, now got it | 13:18 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Revive os_monasca https://review.opendev.org/c/openstack/project-config/+/765799 | 13:19 |
openstackgerrit | Dmitriy Rabotyagov proposed openstack/project-config master: Re-add os_monasca roles to zuul https://review.opendev.org/c/openstack/project-config/+/765806 | 13:21 |
*** priteau has joined #opendev | 13:27 | |
*** ysandeep is now known as ysandeep|afk | 13:42 | |
*** owalsh has quit IRC | 14:19 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Enable installing nimble siblings https://review.opendev.org/c/zuul/zuul-jobs/+/765672 | 14:24 |
*** ysandeep|afk is now known as ysandeep | 14:33 | |
*** owalsh has joined #opendev | 14:42 | |
*** owalsh has quit IRC | 14:47 | |
*** owalsh has joined #opendev | 14:58 | |
*** lpetrut has quit IRC | 15:03 | |
*** chrome0 has quit IRC | 15:36 | |
*** mlavalle has joined #opendev | 15:39 | |
*** chrome0 has joined #opendev | 15:40 | |
openstackgerrit | Sorin Sbârnea proposed openstack/project-config master: Enable tripleo core members to change WIP flag https://review.opendev.org/c/openstack/project-config/+/765821 | 15:41 |
*** ysandeep is now known as ysandeep|away | 15:42 | |
openstackgerrit | Sorin Sbârnea proposed openstack/project-config master: Enable tripleo core members to change WIP flag https://review.opendev.org/c/openstack/project-config/+/765821 | 15:42 |
openstackgerrit | Sorin Sbârnea proposed openstack/project-config master: Enable tripleo core members to change WIP flag https://review.opendev.org/c/openstack/project-config/+/765821 | 15:59 |
fungi | zbr: ^ any idea yet whether than will be able to prevent changes from merging like workflow -1 does, or whether we'll need to alter our zuul pipeline definitions? | 16:01 |
clarkb | fungi: I think zuul asks for emrgeability status from gerrit, if that includes things like proper WIP and not the approval category I imagine it will work fine | 16:03 |
zbr | fungi: afaik, gerrit will not allow submit on such changes, but I think it cannot prevent a push if client does that. | 16:03 |
clarkb | but we can double check with zuul | 16:03 |
zbr | but IMHO, we should prevent gerrit running "gate" on any WIP change, to save resources anyway. | 16:03 |
clarkb | zbr: yes that is the bit I'm talking about. I think zuul may already do the right thing there but we should double check | 16:05 |
fungi | that was my expectation as well. if gerrit claims not having wip set is a requirement to be able to merge, then zuul should already know not to enqueue into the gate pipeline, i just didn't know whether anyone's tested it yet | 16:06 |
zbr | lets test with something that already has a 2x +2 | 16:06 |
zbr | clarkb: fungi: lets test with https://review.opendev.org/c/zuul/zuul/+/765564 ? | 16:07 |
zbr | if it looks ok to you, i can make it WIP, you add the missing bits and we see if it ends up being queued, merged or not. | 16:08 |
clarkb | in meetings now but can take a look in a bit | 16:09 |
fungi | i should have a break from meetings at 18:00 utc and can look closer then | 16:11 |
*** sboyron_ is now known as sboyron | 16:12 | |
*** hashar has quit IRC | 16:53 | |
*** rpittau is now known as rpittau|afk | 16:58 | |
openstackgerrit | Matt McEuen proposed openstack/project-config master: New Project Request: airship/vino https://review.opendev.org/c/openstack/project-config/+/763889 | 17:03 |
openstackgerrit | Matt McEuen proposed openstack/project-config master: New Project Request: airship/sip https://review.opendev.org/c/openstack/project-config/+/763888 | 17:03 |
*** slaweq has quit IRC | 17:05 | |
*** marios|rover is now known as marios|out | 17:05 | |
*** slaweq has joined #opendev | 17:06 | |
*** marios|out has quit IRC | 17:09 | |
*** sboyron has quit IRC | 17:32 | |
*** sboyron has joined #opendev | 17:33 | |
*** andrewbonney has quit IRC | 18:17 | |
*** hamalq has joined #opendev | 18:19 | |
*** hamalq_ has joined #opendev | 18:21 | |
*** hamalq has quit IRC | 18:25 | |
*** dtantsur is now known as dtantsur|afk | 18:28 | |
eharney | hi, my gerrit dashboard says i have a draft comment on https://review.opendev.org/c/openstack/cinder/+/297608 | 18:29 |
eharney | but i can't find one, and the "DELETE ALL" button doesn't seem to clear this | 18:29 |
eharney | any ideas? | 18:29 |
clarkb | eharney: look at old patchsets | 18:29 |
clarkb | I ran into that too where it was an older patchset and I had to switch context to it in order to see the draft text next to a file | 18:30 |
*** fressi has quit IRC | 18:30 | |
eharney | clarkb: humm, i don't see one on any of the 4 patchsets | 18:40 |
clarkb | unfortunately I don't think other users can see your draft comments so is hard to check from my seat. But you went to https://review.opendev.org/c/openstack/cinder/+/297608/1 then /2 and /3 and /4 and checked each of the files and commit messages? | 18:42 |
eharney | clarkb: yes... but, then i made a new draft comment, saved it, and deleted that, and now it doesn't show on my dashboard any more | 18:45 |
eharney | strange, but, works for me | 18:45 |
clarkb | huh interesting. I wonder too if maybe it had cached that state and what you did forced it to uncache the old state | 18:46 |
eharney | maybe so | 18:46 |
eharney | thanks! | 18:46 |
*** hashar has joined #opendev | 19:25 | |
spotz | Hey any known problems with tox? | 19:54 |
jrosser | spotz: new release of virtualenv today which contains pip with the new resolver might cause trouble? | 19:57 |
spotz | jrosser: From yesterday Could not import extension sphinxcontrib.mermaid (exception: No module named 'six') | 19:57 |
jrosser | ah so not my thing then :) | 19:58 |
spotz | heheh, mine either so asking here:) | 19:58 |
spotz | Still getting used to the new look of gerrit | 19:58 |
clarkb | spotz: that sounds more like a dependency issue than a tox issue | 19:59 |
fungi | which project's docs are you trying to build? | 19:59 |
spotz | clarkb: So internal to the repo? tripleo-docs | 19:59 |
clarkb | looking quickly at that package it doesn't seem to explicitly depend on six but does import it | 20:00 |
clarkb | so ya I think they have an implicit dep there and you may need to list six yourself | 20:00 |
spotz | clarkb: Ok thanks | 20:01 |
openstackgerrit | Clark Boylan proposed opendev/system-config master: Put jgit pack settings in jgit.config https://review.opendev.org/c/opendev/system-config/+/765867 | 20:14 |
openstackgerrit | Clark Boylan proposed opendev/system-config master: Set core.packedGitUseStrongRefs in gerrit configs https://review.opendev.org/c/opendev/system-config/+/765868 | 20:14 |
openstackgerrit | Clark Boylan proposed opendev/system-config master: Bump gerrit's git protocol version to v2 https://review.opendev.org/c/opendev/system-config/+/765869 | 20:14 |
clarkb | fungi: ^ something like that stack maybe for next tuning steps? I figure we continue to do them one at a time and obvserve? | 20:15 |
*** elod is now known as elod_pto | 20:16 | |
clarkb | for that last one I think the client also needs to be smarter so not sure how big of an impact it will have. | 20:22 |
ianw | what is the deal with WIP status v "workflow -1" ? | 20:40 |
clarkb | ianw: WIP status is built in to gerrit now. If you click on the menu in the top right of a chagne you can set a change to wip | 20:40 |
clarkb | workflow -1 was our hack to make a WIP status work without it being built in | 20:40 |
clarkb | we can likely remove workflow -1 if WIP status meets all the needs | 20:40 |
ianw | yeah, i guess i mean are we going to re-evaluate -1 | 20:40 |
clarkb | I think we should | 20:41 |
clarkb | the built in makes it a bit more clear visually what is going on | 20:41 |
clarkb | but we should also make sure that zuul is happy with it (what zbr and fungi were discussing earlier today) and that there aren't other gotchas to consider first | 20:41 |
ianw | yep sure. maybe a meeting topic we should follow up on? | 20:43 |
clarkb | wfm | 20:43 |
fungi | yeah, just needs to be tested i think. if some project is willing to "test it in production" with a change to their acl i'm not opposed | 20:43 |
fungi | but we need to be clear that for now our recommended/supported solution is to use workflow -1 votes to indicate a work in progress/not yet ready for review, until it's been clearly shown we can deprecate that | 20:44 |
ianw | ++. dib might be a good one to fiddle on | 20:48 |
fungi | i think zbr has already proposed similar for tripleo in 765821 | 20:52 |
*** elod_pto has quit IRC | 21:13 | |
*** hashar has quit IRC | 21:15 | |
gmann | fungi clarkb: these two are project removal patch, do I need to add it in meeting agenda in project rename section or they can merge anytime now? https://review.opendev.org/c/openstack/project-config/+/764535 https://review.opendev.org/c/openstack/project-config/+/764536 | 21:21 |
fungi | gmann: they can merge any time | 21:22 |
gmann | fungi: ok, thanks. please review. | 21:23 |
fungi | i'll try to take a look after i'm done making dinner | 21:37 |
*** brinzhang_ has joined #opendev | 21:45 | |
*** brinzhang has quit IRC | 21:48 | |
*** sshnaidm has quit IRC | 21:49 | |
*** slaweq has quit IRC | 21:58 | |
*** sboyron has quit IRC | 22:01 | |
*** mordred has quit IRC | 22:02 | |
*** odyssey4me has quit IRC | 22:02 | |
*** johnsom has quit IRC | 22:02 | |
*** jhesketh has quit IRC | 22:06 | |
*** jhesketh has joined #opendev | 22:08 | |
*** sshnaidm has joined #opendev | 22:08 | |
*** DSpider has quit IRC | 22:12 | |
*** fdegir has quit IRC | 22:14 | |
*** fdegir has joined #opendev | 22:14 | |
*** bolg has quit IRC | 22:30 | |
*** johnsom has joined #opendev | 22:30 | |
*** odyssey4me has joined #opendev | 22:30 | |
*** mordred has joined #opendev | 22:30 | |
*** dviroel has quit IRC | 22:55 | |
*** auristor has quit IRC | 22:57 | |
*** stevebaker has quit IRC | 23:38 | |
*** auristor has joined #opendev | 23:45 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!