openstackgerrit | Clark Boylan proposed opendev/system-config master: Cleanup puppet things from zuul where we don't puppet anymore https://review.opendev.org/c/opendev/system-config/+/792709 | 00:03 |
---|---|---|
openstackgerrit | Clark Boylan proposed opendev/system-config master: Remove system-config-legacy-logstash-filters job https://review.opendev.org/c/opendev/system-config/+/792247 | 00:03 |
*** DSpider has quit IRC | 02:35 | |
*** _dvd is now known as dvd | 03:15 | |
*** dvd is now known as _dvd | 03:16 | |
*** elod has quit IRC | 06:11 | |
*** elod has joined #opendev | 06:13 | |
*** ykarel|away has joined #opendev | 06:13 | |
*** ykarel|away has quit IRC | 06:13 | |
*** ykarel|away has joined #opendev | 06:14 | |
*** ricolin has quit IRC | 06:50 | |
*** ykarel|away has quit IRC | 08:10 | |
*** dtantsur has joined #opendev | 08:23 | |
*** jpenag has joined #opendev | 08:29 | |
*** CeeMac has quit IRC | 08:30 | |
*** parallax has quit IRC | 08:30 | |
*** jrosser has quit IRC | 08:30 | |
*** paladox has quit IRC | 08:30 | |
*** jpena|off has quit IRC | 08:30 | |
*** dtantsur|afk has quit IRC | 08:30 | |
*** StevenK has quit IRC | 08:30 | |
*** JayF has quit IRC | 08:30 | |
*** CeeMac has joined #opendev | 08:31 | |
*** parallax has joined #opendev | 08:31 | |
*** paladox has joined #opendev | 08:31 | |
*** jrosser has joined #opendev | 08:31 | |
*** StevenK has joined #opendev | 08:31 | |
*** JayF has joined #opendev | 08:31 | |
*** gtema has quit IRC | 08:34 | |
*** dirk has quit IRC | 08:35 | |
*** reed has quit IRC | 08:39 | |
*** mordred has quit IRC | 08:39 | |
*** gtema has joined #opendev | 08:47 | |
*** dirk has joined #opendev | 08:49 | |
*** mordred has joined #opendev | 09:35 | |
*** reed has joined #opendev | 09:40 | |
*** DSpider has joined #opendev | 10:34 | |
*** tosky has joined #opendev | 11:05 | |
*** ykarel|away has joined #opendev | 11:33 | |
*** slaweq has joined #opendev | 11:35 | |
*** slaweq has quit IRC | 12:20 | |
*** ykarel|away has quit IRC | 12:24 | |
*** ykarel|away has joined #opendev | 12:25 | |
corvus | fungi, clarkb: apparently normal users in gerrit can remove reviewers from changes, which also removes their votes? https://review.opendev.org/c/zuul/zuul/+/792715/ | 13:39 |
fungi | corvus: aha, more specifically the "change owner" at least seems to be able to (so not exactly "normal users"). i wonder if this is an implicit change owner permission we have to block | 13:44 |
corvus | (though when i replied to the change, my vote automatically re-appeared; i manually removed it again) | 13:44 |
corvus | fungi: yes, correct, sorry | 13:44 |
corvus | my first irc transmission after waking up :) | 13:44 |
fungi | thanks for spotting that, i'll try to take a look at the acl docs in a bit once i get a break from the gardening chores | 13:45 |
corvus | i'm very curious what the user's reasoning is (i've asked) | 13:48 |
corvus | it's also interesting that they did not remove zuul (which had a -2) as a reviewer | 13:51 |
corvus | perhaps that's what they were trying to do, but could not because of the -2, and removed us in an attempt to understand why removing zuul wasn't working | 13:52 |
*** tosky has quit IRC | 14:08 | |
*** ykarel|away has quit IRC | 14:50 | |
*** slaweq has joined #opendev | 15:05 | |
*** slaweq has quit IRC | 15:13 | |
*** timburke has quit IRC | 16:09 | |
*** dmsimard has quit IRC | 16:38 | |
fungi | corvus: sorry, ended up spending longer outside than i anticipated but the todo list grew while i was there... anyway, looks like it's because the votes were positive, and i get the impression from the docs we can't change that, at least not in 3.2: "Change owners can always remove reviewers who have given a zero or positive score (even without having the Remove Reviewer access right assigned)." | 17:26 |
fungi | https://review.opendev.org/Documentation/access-control.html#category_remove_reviewer | 17:26 |
fungi | so the good news is that if someone pushes a change and you -1 it, they can't delete that (in theory anyway) | 17:27 |
fungi | worth taking up with upstream gerrit if a new access control to restrict change owners from removing zero or positive votes is desirable, i guess | 17:29 |
*** tosky has joined #opendev | 19:25 | |
*** sshnaidm|pto is now known as sshnaidm | 20:48 | |
*** dmsimard has joined #opendev | 20:50 | |
*** tosky has quit IRC | 23:13 | |
*** DSpider has quit IRC | 23:45 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!