*** elodilles_pto is now known as elodilles | 09:06 | |
*** d34dh0r5- is now known as d34dh0r53 | 14:59 | |
ildikov | Hi All, I have a quick question that I couldn't find the answer for. On the Gerrit dashboard there's a 'Status' column that reports number of missing items. What do those displayed numbers mean? If there's documentation about it somewhere, I'm happy to just read through that, if someone could share a pointer to it. | 15:19 |
---|---|---|
fungi | ildikov: that seems to be the number of unmet "submit requirements" | 15:21 |
fungi | if you expand one of those changes and look at the list votes under the submit requirements heading in the top-left corner, hovering over ones that aren't satisfied will show "Status UNSATISFIED" in the tooltip pop-up | 15:22 |
fungi | also in the changes list, hovering over the "N missing" message in the status column should list which submit requirements are satisfied (green checkmark) or unsatisfied (grey Ø) in the resulting pop-up tooltip | 15:23 |
fungi | seems a red X also counts as unsatisfied there | 15:24 |
fungi | (you'll get that with verified/code-review -2 or workflow -1 votes) | 15:25 |
ildikov | fungi: ah, ok, that makes sense | 15:29 |
ildikov | I came to a similar conclusion, but the visuals weren't fully confirming | 15:29 |
ildikov | I assume for 'Verified', when it has a '+1' and it's marked unsatisfied that means that it's missing a '+2' there? | 15:31 |
fungi | correct. gerrit won't let the change merge until it has verified +2, which zuul will add when gating pipeline builds succeed | 15:31 |
fungi | it's a little misleading with our workflow, because gerrit's submit requirements are all about what's required before a user can click the "submit" button to cause the change to be immediately merged to the branch, but we don't let normal users click (or even see) the "submit" button, we delegate that responsibility to the zuul user | 15:33 |
ildikov | ok, cool, thank you for the clarification! | 15:39 |
fungi | any time! | 15:49 |
opendevreview | Steve Baker proposed openstack/diskimage-builder master: Add san support to growvols https://review.opendev.org/c/openstack/diskimage-builder/+/903265 | 21:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!