| opendevreview | Matthew Thode proposed openstack/diskimage-builder master: gentoo: don't uninstall packages that aren't installed https://review.opendev.org/c/openstack/diskimage-builder/+/904236 | 00:07 |
|---|---|---|
| opendevreview | Matthew Thode proposed openstack/diskimage-builder master: gentoo: don't uninstall packages that aren't installed https://review.opendev.org/c/openstack/diskimage-builder/+/904236 | 00:08 |
| opendevreview | Steve Baker proposed openstack/diskimage-builder master: Add san support to growvols https://review.opendev.org/c/openstack/diskimage-builder/+/903265 | 00:39 |
| opendevreview | Matthew Thode proposed openstack/diskimage-builder master: gentoo: don't uninstall packages that aren't installed https://review.opendev.org/c/openstack/diskimage-builder/+/904236 | 01:25 |
| opendevreview | Matthew Thode proposed openstack/diskimage-builder master: DNM: gentoo: don't uninstall packages that aren't installed https://review.opendev.org/c/openstack/diskimage-builder/+/904236 | 03:51 |
| opendevreview | Matthew Thode proposed openstack/diskimage-builder master: DNM: gentoo: don't uninstall packages that aren't installed https://review.opendev.org/c/openstack/diskimage-builder/+/904236 | 03:56 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Fix configuration for tox v4 https://review.opendev.org/c/opendev/engagement/+/904286 | 14:12 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Handle HTTP responses in raw form https://review.opendev.org/c/opendev/engagement/+/904287 | 14:12 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Only paginate queries by integer values https://review.opendev.org/c/opendev/engagement/+/904288 | 14:12 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Loop over all namespaces for committers/reviewers https://review.opendev.org/c/opendev/engagement/+/904289 | 14:12 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Loop over all namespaces for committers/reviewers https://review.opendev.org/c/opendev/engagement/+/904289 | 14:35 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Loop over all namespaces for committers/reviewers https://review.opendev.org/c/opendev/engagement/+/904289 | 15:01 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Fix configuration for tox v4 https://review.opendev.org/c/opendev/engagement/+/904286 | 15:22 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Handle HTTP responses in raw form https://review.opendev.org/c/opendev/engagement/+/904287 | 15:22 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Only paginate queries by integer values https://review.opendev.org/c/opendev/engagement/+/904288 | 15:22 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Loop over all namespaces for committers/reviewers https://review.opendev.org/c/opendev/engagement/+/904289 | 15:22 |
| opendevreview | Merged opendev/engagement master: Fix configuration for tox v4 https://review.opendev.org/c/opendev/engagement/+/904286 | 15:41 |
| opendevreview | Merged opendev/engagement master: Handle HTTP responses in raw form https://review.opendev.org/c/opendev/engagement/+/904287 | 15:43 |
| opendevreview | Merged opendev/engagement master: Only paginate queries by integer values https://review.opendev.org/c/opendev/engagement/+/904288 | 15:44 |
| fungi | i'm disappearing for a bit to find lunch, should be back before 19z | 17:39 |
| clarkb | I apparently failed to do a proper squash of the gitea change yesterday when I was updating things arg | 17:48 |
| clarkb | I guess that goes to show my brain isn't fully working yet. I'll get that sorted out today and re recycle the held node | 17:49 |
| clarkb | (I tend to make edits at the very end of my stacks and then "squash" back into the appropriate stack location. Problem is I didn't remove the newly generated changeid so I got a new change) | 17:51 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Update gitea to 1.21.3 https://review.opendev.org/c/opendev/system-config/+/897679 | 18:29 |
| opendevreview | Clark Boylan proposed opendev/system-config master: DNM intentional gitea failure to hold a node https://review.opendev.org/c/opendev/system-config/+/848181 | 18:29 |
| clarkb | ok that should sort out my screw up with the gitea stack | 18:30 |
| opendevreview | Merged opendev/engagement master: Loop over all namespaces for committers/reviewers https://review.opendev.org/c/opendev/engagement/+/904289 | 19:10 |
| frickler | fungi: question on https://review.opendev.org/c/opendev/engagement/+/904287 | 19:12 |
| fungi | aha, good catch. i'll fix that, though i haven't really tried response recording/replay since the very early days of working on that project. i thought it was going to be a good idea to record api responses and then replay them for rapid testing, but it turned out to be tricky to instrument | 19:17 |
| fungi | it probably needs something like pickle to actually record the raw response from requests.get() now | 19:19 |
| fungi | or a stand-in class that has its own text attribute and store it there | 19:20 |
| opendevreview | Jeremy Stanley proposed opendev/engagement master: Record raw responses https://review.opendev.org/c/opendev/engagement/+/904298 | 19:21 |
| opendevreview | Matthew Thode proposed openstack/diskimage-builder master: DNM: gentoo: don't uninstall packages that aren't installed https://review.opendev.org/c/openstack/diskimage-builder/+/904236 | 19:26 |
| prometheanfire | could I get a second look at this bash? from what I can see it should be right but isn't, "if searched for package is 'not' not installed (is installed)..." | 21:27 |
| prometheanfire | https://review.opendev.org/c/openstack/diskimage-builder/+/904236/9/diskimage_builder/elements/gentoo/bin/install-packages#135 | 21:27 |
| prometheanfire | we can see that the package shows as not installed but the check doesn't seem to catch it | 21:28 |
| prometheanfire | https://zuul.opendev.org/t/openstack/build/f77e67ef70914afc836ce5179d5678b3/log/nodepool/builds/test-image-d5786af040e64927b55d5cd1cc796093.log#2714 | 21:28 |
| Clark[m] | https://158.69.67.24:3081/opendev/system-config is the new held node for the fixed up gitea stack | 21:30 |
| Clark[m] | prometheanfire: does the ! Need to be part of a test command? | 21:40 |
| prometheanfire | Clark[m]: `emerge --search "^${PKG}$" | grep -q 'Not Installed'` returns 0 if package is not installed | 21:43 |
| prometheanfire | if ! success (package not installed) == if package not installed | 21:44 |
| prometheanfire | bah | 21:45 |
| prometheanfire | if ! success (package not installed) == if package not not installed == if package installed | 21:45 |
| prometheanfire | if package installed add to the filtered uninstall list | 21:45 |
| prometheanfire | that should be the logic | 21:46 |
| prometheanfire | could be simplified down to `$(emerge --search "^${PKG}$" | grep -q 'Not Installed') || CLEANED_PKGS+=("${PKG}")` | 21:47 |
| prometheanfire | this returns 'not uninstalling cloud-init' PKG=cloud-init; ! $(emerge --search "^${PKG}$" | grep -q 'Not Installed') && echo "uninstalling $PKG" || echo "not uninstalling $PKG" | 21:47 |
| prometheanfire | locally, cloud-init is not installed | 21:48 |
| Clark[m] | Ya I was just asking if syntactically you need the ! Inside [ because sh vs bash or something | 21:50 |
| prometheanfire | I've tried it with and without the subshell, I don't think [ is actually required but worth trying | 21:51 |
| Clark[m] | My read of the job log was that the negation wasn't happening as expected causing it to try and remove a package that is already not installed so wondered if something with the negation was at fault | 21:51 |
| prometheanfire | ya, could be, I'll add [], it does look like it needs to be inside the brackets | 21:52 |
| opendevreview | Matthew Thode proposed openstack/diskimage-builder master: DNM: gentoo: don't uninstall packages that aren't installed https://review.opendev.org/c/openstack/diskimage-builder/+/904236 | 21:58 |
| NeilHanlon | dumb question, maybe ... can I Depends-On a change in a different project & different branch? Or, is this just not necessary | 23:11 |
| Clark[m] | NeilHanlon: you can depends on changes on different branches. This can be useful for testing upgrade path updates for example | 23:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!