| -@gerrit:opendev.org- Michal Nasiadka proposed: [opendev/system-config] 987453: Remove zp02.opendev.org https://review.opendev.org/c/opendev/system-config/+/987453 | 07:49 | |
| -@gerrit:opendev.org- Michal Nasiadka proposed: [opendev/system-config] 987453: Remove zp02.opendev.org https://review.opendev.org/c/opendev/system-config/+/987453 | 08:26 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [opendev/zuul-providers] 984867: Delete cache at end of build https://review.opendev.org/c/opendev/zuul-providers/+/984867 | 09:00 | |
| @mnasiadka:matrix.org | If anybody has time for reviews today - https://review.opendev.org/c/openstack/project-config/+/987176 (adding vexxhost/magnum-cluster-api to untrusted projects, so that magnum core can run CI with that driver) | 12:40 |
|---|---|---|
| @clarkb:matrix.org | mnasiadka: both the github repo add to zuul and zp02 removal lgtm. Maybe Jens Harbott has a few minutes to double check and possibly approve them? | 14:51 |
| -@gerrit:opendev.org- Clark Boylan proposed: [opendev/zuul-providers] 987531: Add Ubuntu Resolute to our labels, nodesets, and providers https://review.opendev.org/c/opendev/zuul-providers/+/987531 | 15:15 | |
| -@gerrit:opendev.org- Monty Taylor https://matrix.to/#/@mordred:inaugust.com proposed: [openstack/project-config] 987373: Add gerrit and zuul plugin repos for hermes-agent https://review.opendev.org/c/openstack/project-config/+/987373 | 15:30 | |
| @mordred:waterwanders.com | If people really enjoyed mnasiadka 's project-config patch and wanted more where that came from ^^ :) | 15:31 |
| @clarkb:matrix.org | Very early gerrit 3.13 upgrade notes are going in https://etherpad.opendev.org/p/gerrit-upgrade-3.13 The upgrade process itself looks straightforward. I think the biggest thing for this upgrade is ensuring we handle the removal of robot comments, the change to http passwords to auth tokens (should be backward compatible in this release so that isn't an urgent cut over), and checking the answer for luca's question in https://gerrit-review.googlesource.com/c/gerrit/+/480342 | 15:36 |
| @mordred:waterwanders.com | Clark: were we using robot comments? | 16:06 |
| @mordred:waterwanders.com | also - have we done anything with checks api yet? (ilke, did it achieve usefulness?) | 16:07 |
| @clarkb:matrix.org | mordred: yes zuul currently uses them to post inline comments from job results. Things like linter results or even the zuul config error messages I think | 16:07 |
| @clarkb:matrix.org | when talking to 3.13 and newer zuul will simply post those comments as normal comments as robot comments have been deleted. We (opendev) are not doing anything with checks | 16:07 |
| @clarkb:matrix.org | upstream gerrit's zuul does integrate with checks to some degree as the zuul results are reported through that | 16:07 |
| @mordred:waterwanders.com | nod. so the answer for opendev is to just use normal comments and not robot comments | 16:08 |
| @mordred:waterwanders.com | wow. https://gerrit.googlesource.com/plugins/checks "Gerrit Code Review Checks Plugin (DEPRECATED)" - that's not unclear at all | 16:09 |
| @clarkb:matrix.org | but zuul only does gerrit version detection on startup so part of our gerrit 3.13 upgrade process will include restarting zuul services so they detect the new gerrit version | 16:10 |
| @clarkb:matrix.org | and yes the status of the checks plugin stuff is very confusing | 16:10 |
| @clarkb:matrix.org | aiui its basically a way to integrate reporting of CI results now and not a way to trigger jobs? | 16:10 |
| @mordred:waterwanders.com | yeah - cause the original backend checks api plugin had something to do with new specific storage of results in notesdb | 16:12 |
| @mordred:waterwanders.com | and then _also_ ways to visualize those results | 16:12 |
| @clarkb:matrix.org | I am predicting that our smaller backup server will need pruning starting tomorrowish | 17:08 |
| @clarkb:matrix.org | I'm trying to figure out this new Gerrit Flows stuff without digging in the source and am failing. Has anyone else run into documentation or used it on some other Gerrit? | 18:06 |
| @clarkb:matrix.org | My impression is that it probably doesn't help us too much given that zuul is effectively able to fill in that use case | 18:06 |
| @clarkb:matrix.org | but maybe we want to integrate zuul with gerrit flows as a flow provider or something? Too early to say without a better understanding of what it is | 18:07 |
| @mordred:waterwanders.com | Clark: I'm not seeing anything about it that feels particularly compelling here. The examples given are all things like "assign reviewers once CI is +1" - and there's a bunch of things referencing prior things people did in bugtracker its integrations. neither of those are things opendev is super in the business of. | 18:29 |
| @mordred:waterwanders.com | there also doesn't seem to be an actual implementation - it's a new plugin surface. so - zuul _could_ integrate as a flows plugin provider, but I'm struggling to see how it would make anything better | 18:32 |
| @clarkb:matrix.org | ya I think if we did use it zuul would be the system driving it | 18:35 |
| @clarkb:matrix.org | since it already talks to gerrit, but I agree I'm not sure where in our workflows it might make sense. Its also disabled by default in 3.13 so this is mostly be trying to understand more than anything else | 18:35 |
| @clarkb:matrix.org | I also sent a message to discord asking about the http password to token migration and whether it makes sense to do when upgrading to 3.13 or if 3.13 will still allow you to create old style passwords in the external id tables | 18:36 |
| @clarkb:matrix.org | I want to avoid doing multiple db migrations if that is the case we'll delay until they drop the old system | 18:36 |
| @mordred:waterwanders.com | I certainly hope there is overlap between tokens and passwords | 18:42 |
| @clarkb:matrix.org | ok sounds like if we don't explicitly migrate things then new tokens will go in the new db location. Old tokens will remain as is. Then eventually when they remove support for old tokens we either need to migrate or people will have to generate new tokens after the upgrade | 20:22 |
| @clarkb:matrix.org | I think for our purposes ignoring that as we go to 3.13 is fine. Anyone can refresh their tokens that wants to on 3.13. We should do that for zuul as an example | 20:22 |
| @clarkb:matrix.org | then when Gerrit drops support for the legacy system we can run the tool at that point or just force people to regenerate new tokens after the upgrade (maybe include a warning to do that ahead of the upgrade if they want) | 20:22 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!