| @abelur:matrix.org | Thank you, I'll go through the review and get back. | 00:02 |
|---|---|---|
| -@gerrit:opendev.org- Anil Shashikumar Belur proposed: | 05:24 | |
| - [opendev/system-config] 995756: Add meeting engine integration to matrix-eavesdrop https://review.opendev.org/c/opendev/system-config/+/995756 | ||
| - [opendev/system-config] 995757: Wire meeting support into the matrix-eavesdrop bot https://review.opendev.org/c/opendev/system-config/+/995757 | ||
| - [opendev/system-config] 995758: Deploy matrix-eavesdrop meeting support https://review.opendev.org/c/opendev/system-config/+/995758 | ||
| - [opendev/system-config] 995759: Add a functional test for matrix-eavesdrop meetings https://review.opendev.org/c/opendev/system-config/+/995759 | ||
| -@gerrit:opendev.org- Dr. Jens Harbott proposed: [openstack/project-config] 995781: Fix config errors for zuul-base-jobs https://review.opendev.org/c/openstack/project-config/+/995781 | 07:47 | |
| @harbott.osism.tech:regio.chat | corvus: ^^ maybe we can completely delete the repo from the openstack tenant? or am I missing something? | 07:50 |
| @jim:acmegating.com | Jens Harbott: yeah if we're not going to use it or exercise it for config errors, we probably can | 13:45 |
| -@gerrit:opendev.org- yatin proposed: [zuul/zuul-jobs] 995826: [DNM] use custom port for geneve tunnel https://review.opendev.org/c/zuul/zuul-jobs/+/995826 | 13:57 | |
| @mordred:waterwanders.com | Clark, corvus, Jens Harbott if you have a sec, I'd love a go/no-go on https://review.opendev.org/c/opendev/base-jobs/+/994146 I was the only consumer of the existing name. I've removed that consumer so the job name is clear to move. But I'd like to use that job, either in its old name or new one. | 15:13 |
| @clarkb:matrix.org | mordred: I guess the default container command was podman previously since we aren't changing the playbooks or roles? | 15:15 |
| @mordred:waterwanders.com | yeah. I was a little surprised by that myself | 15:16 |
| @clarkb:matrix.org | seems fine to me. I'll let corvus weigh in though as he designed a lot of this stuff | 15:17 |
| @mordred:waterwanders.com | but - figured better to document | 15:18 |
| @mordred:waterwanders.com | ``` | 15:18 |
| commit 30b02a86dc60a2f818bb3eea08088f10f3d20461 | ||
| Author: James E. Blair <jim@acmegating.com> | ||
| Date: Thu Mar 23 12:55:33 2023 -0700 | ||
| Fix container-image pre playbook container_command default | ||
| This variable can be undefined, so use the documented default. | ||
| Change-Id: Ied1f79a5ec0ca769301ed2ecd38e67f1f511aa50 | ||
| diff --git a/playbooks/container-image/pre.yaml b/playbooks/container-image/pre.yaml | ||
| index 90873a4..67d96b3 100644 | ||
| --- a/playbooks/container-image/pre.yaml | ||
| +++ b/playbooks/container-image/pre.yaml | ||
| @@ -1,11 +1,11 @@ | ||
| - hosts: all | ||
| tasks: | ||
| - name: Ensure docker is installed | ||
| - when: "container_command == 'docker'" | ||
| + when: "container_command | default('podman') == 'docker'" | ||
| include_role: | ||
| name: ensure-docker | ||
| - name: Ensure podman is installed | ||
| - when: "container_command != 'docker'" | ||
| + when: "container_command | default('podman') != 'docker'" | ||
| include_role: | ||
| name: ensure-podman | ||
| - name: Pull from intermediate registry | ||
| ``` | ||
| fwiw - that's where the default came from | ||
| @jim:acmegating.com | mordred: lgtm you around for a bit? if so i can +w | 15:31 |
| -@gerrit:opendev.org- Monty Taylor https://matrix.to/#/@mordred:inaugust.com proposed: | 15:32 | |
| - [zuul/zuul-jobs] 995739: Add podman variant of the registry-buildset-registry job https://review.opendev.org/c/zuul/zuul-jobs/+/995739 | ||
| - [zuul/zuul-jobs] 994297: Add nftables to rootless podman packages https://review.opendev.org/c/zuul/zuul-jobs/+/994297 | ||
| - [zuul/zuul-jobs] 995585: Align podman packages on resolute and forward https://review.opendev.org/c/zuul/zuul-jobs/+/995585 | ||
| - [zuul/zuul-jobs] 995740: Add resolute versions of registry jobs https://review.opendev.org/c/zuul/zuul-jobs/+/995740 | ||
| @mordred:waterwanders.com | yup! | 15:32 |
| @mordred:waterwanders.com | I'm excited - it'll let me delete a role and playbook I've got cargo-culted into like 8 different repos now that I finally undertand what's going on :) | 15:35 |
| -@gerrit:opendev.org- Zuul merged on behalf of Monty Taylor https://matrix.to/#/@mordred:inaugust.com: [opendev/base-jobs] 994146: Rename opendev-buildset-registry-consumer to opendev-use-container-image https://review.opendev.org/c/opendev/base-jobs/+/994146 | 15:51 | |
| @mordred:waterwanders.com | \o/ | 16:00 |
| @mordred:waterwanders.com | I'm going to push up a consumer patch or two | 16:01 |
| @mordred:waterwanders.com | https://review.opendev.org/c/wandertracks/wandertracks/+/995843 will exercise that ^^ | 16:03 |
| -@gerrit:opendev.org- Monty Taylor https://matrix.to/#/@mordred:inaugust.com proposed: | 16:11 | |
| - [zuul/zuul-jobs] 995739: Add podman variant of the registry-buildset-registry job https://review.opendev.org/c/zuul/zuul-jobs/+/995739 | ||
| - [zuul/zuul-jobs] 994297: Add nftables to rootless podman packages https://review.opendev.org/c/zuul/zuul-jobs/+/994297 | ||
| - [zuul/zuul-jobs] 995585: Align podman packages on resolute and forward https://review.opendev.org/c/zuul/zuul-jobs/+/995585 | ||
| - [zuul/zuul-jobs] 995740: Add resolute versions of registry jobs https://review.opendev.org/c/zuul/zuul-jobs/+/995740 | ||
| @mordred:waterwanders.com | corvus: hah. you might appreciate the review comment on https://review.opendev.org/c/wandertracks/wandertracks/+/995843 :) | 16:13 |
| -@gerrit:opendev.org- Monty Taylor https://matrix.to/#/@mordred:inaugust.com proposed: | 17:46 | |
| - [zuul/zuul-jobs] 995739: Add podman variant of the registry-buildset-registry job https://review.opendev.org/c/zuul/zuul-jobs/+/995739 | ||
| - [zuul/zuul-jobs] 994297: Add ntftables and aardvark-dns to rootless podman packages https://review.opendev.org/c/zuul/zuul-jobs/+/994297 | ||
| - [zuul/zuul-jobs] 995585: Align podman packages on resolute and forward https://review.opendev.org/c/zuul/zuul-jobs/+/995585 | ||
| - [zuul/zuul-jobs] 995740: Add resolute versions of registry jobs https://review.opendev.org/c/zuul/zuul-jobs/+/995740 | ||
| -@gerrit:opendev.org- Monty Taylor https://matrix.to/#/@mordred:inaugust.com proposed: | 18:56 | |
| - [zuul/zuul-jobs] 995740: Add resolute versions of registry jobs https://review.opendev.org/c/zuul/zuul-jobs/+/995740 | ||
| - [zuul/zuul-jobs] 995880: Add test jobs to test podman sockets https://review.opendev.org/c/zuul/zuul-jobs/+/995880 | ||
| @mordred:waterwanders.com | Clark, corvus the "use opendev-use-container-image" patch found a deficiency in ensure-podman. And I'm also chasing the incomplete testing of the podman socket install. So - sorry for the flood of patches, but yay for testing? | 19:05 |
| -@gerrit:opendev.org- Douglas Viroel proposed: [openstack/project-config] 995886: Add Review-Priority label to watcher projects https://review.opendev.org/c/openstack/project-config/+/995886 | 20:10 | |
| -@gerrit:opendev.org- Monty Taylor https://matrix.to/#/@mordred:inaugust.com proposed: | 21:06 | |
| - [zuul/zuul-jobs] 995880: Add test jobs to test podman sockets https://review.opendev.org/c/zuul/zuul-jobs/+/995880 | ||
| - [zuul/zuul-jobs] 995740: Add resolute versions of registry jobs https://review.opendev.org/c/zuul/zuul-jobs/+/995740 | ||
| -@gerrit:opendev.org- Monty Taylor https://matrix.to/#/@mordred:inaugust.com proposed: | 22:29 | |
| - [zuul/zuul-jobs] 995880: Add test jobs to test podman sockets https://review.opendev.org/c/zuul/zuul-jobs/+/995880 | ||
| - [zuul/zuul-jobs] 995740: Add resolute versions of registry jobs https://review.opendev.org/c/zuul/zuul-jobs/+/995740 | ||
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!