| *** holser has joined #openstack-ansible-sig | 00:06 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-ansible-sig | 04:35 | |
| *** tremble has quit IRC | 06:28 | |
| *** gtema has joined #openstack-ansible-sig | 06:36 | |
| *** tremble has joined #openstack-ansible-sig | 07:12 | |
| *** iurygregory has joined #openstack-ansible-sig | 07:21 | |
| *** dtantsur|afk is now known as dtantsur | 07:26 | |
| *** spatel has joined #openstack-ansible-sig | 08:43 | |
| *** spatel has quit IRC | 08:48 | |
| *** gtema has quit IRC | 10:51 | |
| *** gtema has joined #openstack-ansible-sig | 11:21 | |
| *** gtema has joined #openstack-ansible-sig | 11:22 | |
| *** trident has quit IRC | 11:31 | |
| *** gtema has quit IRC | 11:36 | |
| *** gtema has joined #openstack-ansible-sig | 12:13 | |
| *** Guest34946 has joined #openstack-ansible-sig | 12:47 | |
| *** Guest34946 is now known as redrobot | 12:50 | |
| *** trident has joined #openstack-ansible-sig | 13:02 | |
| *** gtema has quit IRC | 13:14 | |
| *** gtema has joined #openstack-ansible-sig | 13:15 | |
| dtantsur | folks, could I get some reviews please? https://review.opendev.org/#/c/746883/ | 13:20 |
|---|---|---|
| gtema | yupp, you can | 13:20 |
| gtema | license in https://review.opendev.org/#/c/746883/2/plugins/module_utils/ironic.py is funny | 13:22 |
| dtantsur | it's a copy-paste, I think | 13:23 |
| gtema | oh, right. its same as in openstack utils | 13:23 |
| gtema | oki then | 13:23 |
| gtema | those ansible collections and zuul jobs for them - nightmare | 13:24 |
| gtema | P.S. - catch your review | 13:24 |
| dtantsur | thx! | 13:25 |
| *** gtema has quit IRC | 14:05 | |
| *** gtema has joined #openstack-ansible-sig | 14:10 | |
| sshnaidm | dtantsur, I wonder if we can include it in current Openstack class? | 14:54 |
| sshnaidm | it's processing two parameters actually | 14:54 |
| sshnaidm | I'm curios if need another class for it | 14:55 |
| dtantsur | sshnaidm: probably? I didn't have enough time to carefully figure out the difference | 14:57 |
| sshnaidm | if we'll have more different settings for Ironic modules, I'm fine | 14:57 |
| sshnaidm | dtantsur, I mean maybe _update_ironic_auth can be part of OpenstackModule class? or not | 14:58 |
| dtantsur | I don't know how different OpenstackModule is from what the ironic modules are doing right now | 14:59 |
| sshnaidm | dtantsur, I use it here: https://review.opendev.org/#/c/743533/9/plugins/modules/baremetal_node_info.py | 15:05 |
| sshnaidm | dtantsur, I'll look if we can do it together.. | 15:05 |
| sshnaidm | dtantsur, btw, why do we need to remove api specific stuff from the output? https://review.opendev.org/#/c/743533/9/plugins/modules/baremetal_node_info.py | 15:18 |
| sshnaidm | dtantsur, is there any security concern> | 15:18 |
| sshnaidm | ? | 15:18 |
| dtantsur | sshnaidm: no, only usability | 15:19 |
| dtantsur | URLs are of little use for ansible consumers | 15:19 |
| sshnaidm | dtantsur, so people may just ignore it? | 15:19 |
| sshnaidm | not sure if need to add specific logic for cleaning this | 15:20 |
| dtantsur | they may, although I'm afraid openstacksdk will remove them anyway, producing a potentially breaking change | 15:20 |
| sshnaidm | breaking change? | 15:20 |
| sshnaidm | you mean if someone will use it and will loose after an openstacksdk change? | 15:21 |
| dtantsur | yep | 15:24 |
| *** owalsh has quit IRC | 15:36 | |
| *** tremble has quit IRC | 15:44 | |
| *** owalsh has joined #openstack-ansible-sig | 15:45 | |
| *** owalsh has quit IRC | 15:45 | |
| *** sshnaidm is now known as sshnaidm|afk | 15:59 | |
| *** tremble has joined #openstack-ansible-sig | 16:12 | |
| *** dtantsur is now known as dtantsur|afk | 16:19 | |
| *** owalsh has joined #openstack-ansible-sig | 16:23 | |
| *** gtema has quit IRC | 18:57 | |
| *** gtema has joined #openstack-ansible-sig | 20:58 | |
| *** gtema has quit IRC | 21:04 | |
| *** spatel has joined #openstack-ansible-sig | 23:56 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!