*** elo has quit IRC | 00:36 | |
*** elo has joined #openstack-ansible | 00:37 | |
cloudnull | mhayden: you can start the process with https://github.com/cloudnull/os-ansible-deployment/blob/master-rhel/scripts/bootstrap-ansible.sh to support multi OS then it can be the absolute first thing run . | 00:44 |
---|---|---|
cloudnull | seems sensible to replace script-y parts with ansible play | 00:45 |
cloudnull | *plays | 00:45 |
cloudnull | arbrandes: currently we only support unauthenticated libvirt but i'd be great to change that. | 00:49 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement neutron venv support https://review.openstack.org/230726 | 01:23 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement cinder venv support https://review.openstack.org/225463 | 01:25 |
*** alextricity-mobi has quit IRC | 01:38 | |
*** dcreno has quit IRC | 01:54 | |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement neutron venv support https://review.openstack.org/230726 | 02:24 |
*** elo has quit IRC | 02:45 | |
*** jhesketh has quit IRC | 02:48 | |
*** jhesketh has joined #openstack-ansible | 02:50 | |
*** elo has joined #openstack-ansible | 03:13 | |
*** elo has quit IRC | 04:14 | |
*** elo has joined #openstack-ansible | 04:17 | |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement neutron venv support https://review.openstack.org/230726 | 04:21 |
*** smallbig has quit IRC | 04:32 | |
*** shausy has joined #openstack-ansible | 05:34 | |
*** javeriak has joined #openstack-ansible | 05:41 | |
*** javeriak has quit IRC | 06:03 | |
*** javeriak has joined #openstack-ansible | 06:03 | |
*** sdake has joined #openstack-ansible | 06:06 | |
*** sdake has quit IRC | 06:10 | |
*** sdake has joined #openstack-ansible | 06:10 | |
*** sdake has quit IRC | 06:27 | |
*** sdake has joined #openstack-ansible | 06:30 | |
*** sdake has quit IRC | 06:31 | |
*** javeriak has quit IRC | 06:42 | |
*** elo has quit IRC | 06:54 | |
*** elo has joined #openstack-ansible | 06:58 | |
*** javeriak has joined #openstack-ansible | 06:59 | |
*** javeriak has quit IRC | 07:06 | |
*** javeriak has joined #openstack-ansible | 07:06 | |
*** mancdaz has joined #openstack-ansible | 07:24 | |
*** Guest60551 has quit IRC | 07:26 | |
*** grumpycat has joined #openstack-ansible | 07:27 | |
*** grumpycat is now known as Guest92657 | 07:27 | |
evrardjp | good morning everyone | 07:49 |
*** gparaskevas has joined #openstack-ansible | 07:51 | |
*** vdo has joined #openstack-ansible | 08:15 | |
*** mgoddard has joined #openstack-ansible | 08:34 | |
*** misc_ is now known as misc | 08:39 | |
*** javeriak has quit IRC | 08:55 | |
*** markvoelker has joined #openstack-ansible | 09:05 | |
*** markvoelker_ has joined #openstack-ansible | 09:06 | |
*** jmccrory has quit IRC | 09:07 | |
*** jmccrory has joined #openstack-ansible | 09:08 | |
*** markvoelker has quit IRC | 09:09 | |
*** markvoelker_ has quit IRC | 09:20 | |
mattt | odyssey4me: any reason why the commit message here doesn't incidate it's a backport? https://review.openstack.org/#/c/227963/ | 09:33 |
odyssey4me | mattt you mean why is it not a cherry pick? | 09:33 |
mattt | odyssey4me: yeah cherry-pick | 09:33 |
odyssey4me | the primary reason would be to say that it wasn't a cherry pick - and if it was it'd have to be two and edited anyway | 09:34 |
mattt | why maintain the same change-id from master/kilo then? | 09:34 |
odyssey4me | simply to make it easier to track them together | 09:35 |
mattt | k | 09:35 |
odyssey4me | they all solve the same problem, but not in the same way due to upstream differences | 09:36 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Fix bashate violations https://review.openstack.org/230520 | 10:03 |
odyssey4me | mattt can you take a peek through a docs change for me please: https://review.openstack.org/230368 | 10:08 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Move contributing and AIO documentation into dev-docs https://review.openstack.org/230423 | 10:09 |
mattt | odyssey4me: trying to get through some of the older reviews, is this urgent? | 10:09 |
odyssey4me | fair enough, keep going :) | 10:09 |
mattt | odyssey4me: i'll have a look at it in a bit! | 10:10 |
openstackgerrit | Merged openstack/openstack-ansible: Install irqbalance on hosts https://review.openstack.org/227942 | 10:18 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Move contributing and AIO documentation into dev-docs https://review.openstack.org/230423 | 10:23 |
*** shausy has quit IRC | 10:27 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Set affinity to 1 for OpenStack-CI gate checks https://review.openstack.org/221957 | 10:27 |
*** shausy has joined #openstack-ansible | 10:27 | |
openstackgerrit | Merged openstack/openstack-ansible: Add ebtables to neutron agent configuration https://review.openstack.org/227963 | 10:32 |
odyssey4me | mattt just thinking about affinities and clustering - considering how we implement the rabbit cluster, does it make sense to bother with more than one rabbitmq instance for the gate check? | 10:32 |
odyssey4me | afaik we implement a multimaster cluster and the services consuming it all get given the list of rabbitmq servers | 10:33 |
odyssey4me | I think three galera nodes adds some value, but 3 x rabbitmq seems a waste | 10:33 |
mattt | odyssey4me: i guess it's more to test the actual set up of the cluster itself, more so than how openstack interfaces with it | 10:36 |
odyssey4me | mattt yeah, but then we need to think about what we're actually about here - is our focus to setup a galera or rabbit cluster, is is our focus to deploy openstack | 10:37 |
mattt | odyssey4me: https://review.openstack.org/#/c/228558/ ... the bashate/pep8 errors here seem to be setup issues (tox.MissingDependency, InvocationError), were those all resolved? | 10:37 |
odyssey4me | I would like to test the cluster more thoroughly, but our playbooks do nothing to actually test it right now. The galera cluster is more thorough in that regard - the rabbit servers are simply started and added. I don't see much value in running the rabbit bits in the current gate test. | 10:38 |
odyssey4me | mattt bashate violations patch: https://review.openstack.org/230520 | 10:38 |
odyssey4me | matt tox.ini fox: https://review.openstack.org/230319 | 10:39 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Fix incorrect tox.ini config https://review.openstack.org/230935 | 10:39 |
mancdaz | odyssey4me would something like this not need a blueprint/spec normally? https://review.openstack.org/#/c/230716/ | 10:39 |
mattt | odyssey4me: ok cool, let me +2 it and let it all get tested again | 10:40 |
openstackgerrit | Jimmy McCrory proposed openstack/openstack-ansible: Install spice-html5 from source https://review.openstack.org/226462 | 10:40 |
*** Burgosz has joined #openstack-ansible | 10:41 | |
mattt | odyssey4me: perhaps there is less need to cluster rabbitmq | 10:42 |
mattt | odyssey4me: fully agree about us needing to focus on testing openstack, but since these core components aren't being tested elsewhere right now and are foundational to the openstack bits it seems like we have no option but to test them now | 10:43 |
odyssey4me | mattt I haven't checked https://review.openstack.org/230716 out thoroughly, but it is nice in that the repo build process is handled entirely in-house instead of via yaprt... I think that a discussion around what needs to happen on a repo server is something we need and perhaps this should form part of that work. This in isolation is a nice improvement though. | 10:43 |
mattt | odyssey4me: assuming that comment was for mancdaz? | 10:44 |
odyssey4me | mattt yeah, I agree - but I'd rather have us prioritise openstack testing above infra testing until we split the gate out... right now the resource starvation is causing far too much unreliability in the gate checks | 10:44 |
mancdaz | odyssey4me sure, just feels significant enough a change to need at least a bug assigned, if not a blueprint | 10:44 |
odyssey4me | mattt ah, you're right :p | 10:44 |
odyssey4me | mancdaz ^^ | 10:45 |
mancdaz | odyssey4me ^^ | 10:45 |
odyssey4me | mancdaz at this stage I think that cloudnull put it up for review to get a discussion going, so I'd suggest commenting in the review | 10:45 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Set affinity to 1 for OpenStack-CI gate checks https://review.openstack.org/221957 | 11:16 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Remove unused libvirt-bin file https://review.openstack.org/228371 | 11:16 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Set affinity to 1 for OpenStack-CI gate checks https://review.openstack.org/221957 | 11:19 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Update all SHA's (except Horizon) to Liberty RC1 https://review.openstack.org/228385 | 11:21 |
odyssey4me | mancdaz if this is applicable to kilo, please backport: https://review.openstack.org/209404 | 11:28 |
openstackgerrit | Merged openstack/openstack-ansible: Updates ansible role requirements script name https://review.openstack.org/229540 | 11:30 |
mancdaz | odyssey4me I was still waiting for feedback as to why we're doing it (in email thread) so had it in WIP, and cloudnull rewrote this patch which has now merged | 11:31 |
mancdaz | I'm still not 100% on the need for it | 11:31 |
odyssey4me | mancdaz I suppose the alternative question is whether having it does any harm? | 11:32 |
mancdaz | odyssey4me that was more the thing, yeah | 11:32 |
mancdaz | probably not, but...without really understanding the need for it | 11:32 |
odyssey4me | well, we can leave it in master/Liberty and hopefully you'll get your answer at some point | 11:33 |
*** javeriak has joined #openstack-ansible | 11:33 | |
odyssey4me | for now it'll be tested and commented on by a broader mix | 11:33 |
mancdaz | (for anyone reading along, I do completely understand the need for it in a normal master-slave replication scenario) | 11:33 |
mancdaz | odyssey4me sounds good | 11:33 |
*** jhesketh has quit IRC | 11:43 | |
*** Burgosz has quit IRC | 11:46 | |
*** jhesketh has joined #openstack-ansible | 11:48 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Move contributing and AIO documentation into dev-docs https://review.openstack.org/230423 | 11:49 |
mhayden | happy monday | 12:08 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Move contributing and AIO documentation into dev-docs https://review.openstack.org/230423 | 12:10 |
odyssey4me | o/ mhayden | 12:23 |
evrardjp | hi everyone | 12:24 |
odyssey4me | o/ evrardjp | 12:24 |
*** woodard has joined #openstack-ansible | 12:25 | |
mhayden | would anyone have a moment to give this one a final nudge? just need a +2 https://review.openstack.org/#/c/228591/ | 12:28 |
evrardjp | could someone help me with some ansible stuff? | 12:30 |
evrardjp | I have this: http://paste.openstack.org/show/475303/ | 12:30 |
mhayden | evrardjp: that looks fancy | 12:31 |
evrardjp | wait for the rest ;) | 12:31 |
evrardjp | I'd like to generate a config like this: http://paste.openstack.org/show/475305/ | 12:32 |
evrardjp | but with my template, I end up with: | 12:32 |
evrardjp | http://paste.openstack.org/show/475307/ | 12:33 |
mhayden | well that's interesting | 12:34 |
evrardjp | so on the 307 you see that the host_name from the 303 is well generated, but | 12:34 |
mhayden | looks like you're looping over a string rather than a list/dict | 12:34 |
evrardjp | it's like I have new lines flushed | 12:34 |
evrardjp | yeah | 12:34 |
evrardjp | not sure about the vocabulary, but something like the 305 means that I should loop over a list right | 12:35 |
mhayden | do you have a paste with a little more context? it's hard to tell with only seeing a line or two | 12:35 |
evrardjp | and a list can be written with [item1,item2,...] right? | 12:35 |
mhayden | i don't see a comma in your list | 12:36 |
evrardjp | on 303? | 12:36 |
evrardjp | or on 307? | 12:36 |
mhayden | evrardjp: which paste has the lines | 12:36 |
evrardjp | 307 is cutted, but it has "[ " "," and "]" | 12:36 |
mhayden | i think i missed one of the pastes :) | 12:36 |
evrardjp | you don't have the template, that's maybe something of your interest, but it's really an ansible stuff | 12:37 |
evrardjp | I have given 3 pastes, right now | 12:37 |
evrardjp | http://paste.openstack.org/show/475303/ | 12:37 |
evrardjp | is what I'm working on | 12:38 |
evrardjp | oh wait, I have an idea | 12:38 |
evrardjp | ok found it | 12:39 |
evrardjp | on the paste 303 | 12:39 |
openstackgerrit | Merged openstack/openstack-ansible: Remove containers from /etc/hosts during teardown https://review.openstack.org/215357 | 12:39 |
evrardjp | I have "[ something ]" | 12:39 |
evrardjp | instead of having [ "something"] | 12:39 |
evrardjp | but I have a subsidary question | 12:41 |
evrardjp | this: http://paste.openstack.org/show/475305/ | 12:41 |
*** tlian has joined #openstack-ansible | 12:44 | |
evrardjp | servers is I guess a "list" of items. each item being a dict? is this the correct vocabulary? | 12:46 |
*** agireud has quit IRC | 12:47 | |
mhayden | evrardjp: yeah, in YAML terms, it looks like you have a list of dicts there | 12:47 |
evrardjp | written differently, I have [ {}, {} ] right? | 12:48 |
mhayden | yessir | 12:48 |
evrardjp | ok, then it should work, I'll further check why it doesn't here | 12:49 |
*** javeriak has quit IRC | 12:49 | |
mhayden | i usually forget to use "with_dict:" instead of "with_items:" | 12:52 |
*** dcreno has joined #openstack-ansible | 12:54 | |
evrardjp | mhayden: I know the feeling ;) | 12:55 |
evrardjp | here it's just ... different | 12:55 |
evrardjp | this is the template in question | 12:55 |
evrardjp | https://github.com/evrardjp/ansible-haproxy/blob/master/templates/service.j2 | 12:55 |
evrardjp | just FYI | 12:55 |
mhayden | and which line there is the problematic one? | 12:56 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Limit the number of Ansible forks used to 10 https://review.openstack.org/229786 | 12:58 |
mhayden | odyssey4me: ^^ aww well that's no fun | 12:59 |
evrardjp | shouldn't we stop playing with the number of forks, and let the deployer decide? | 13:01 |
odyssey4me | evrardjp read the review ;) | 13:02 |
evrardjp | if needed for gate checks, maybe sed on the ansible.cfg file | 13:02 |
evrardjp | my bad, reacting directly isn't good ;) | 13:02 |
odyssey4me | currently the number of forks is set to #CPU's when using run-playbooks.sh only - that patch caps it at 10 for the reasons given and adds a doc entry telling deployers how they can use a different value when executing playbooks | 13:03 |
evrardjp | I moved to paramiko for openstack-ansible deployment | 13:03 |
evrardjp | it was far more reliable for me, don't know why | 13:04 |
evrardjp | it's good to cap at 10 | 13:04 |
odyssey4me | yup | 13:04 |
odyssey4me | run-playbooks is only designed for dev/test environments and gating | 13:04 |
odyssey4me | I'm busy adding another doc entry to say so | 13:05 |
*** javeriak has joined #openstack-ansible | 13:05 | |
javeriak | guys, any idea when we might be upgrading the jinja version? | 13:08 |
odyssey4me | javeriak I would expect that it would be whenever Ansible does so | 13:09 |
odyssey4me | currently we only have a lower cap: https://github.com/openstack/openstack-ansible/blob/master/requirements.txt#L2 | 13:09 |
javeriak | oh so its whatever version comes with the ansible source we install | 13:10 |
javeriak | and when do we upgrade ansible? i know v2 isnt out yet | 13:10 |
odyssey4me | javeriak sort-of - the requirement is determined by yaprt in the repo container which I think does the lowest version that complies with the overall requirements | 13:11 |
odyssey4me | so if any other package we use has other requirements, they'll influence what goes into the repo | 13:11 |
javeriak | ive basically hit alot of walls trying to get my logic to work, and all the features i require are in newer versions of ansible & jinja | 13:11 |
javeriak | ah okay | 13:11 |
odyssey4me | we're already using the latest available stable version: https://github.com/openstack/openstack-ansible/blob/master/scripts/bootstrap-ansible.sh#L23 | 13:12 |
evrardjp | mhayden: https://github.com/evrardjp/ansible-haproxy/blob/master/templates/service.j2#L108 | 13:13 |
odyssey4me | The resolved jinja version right now appears to be 2.8 | 13:13 |
javeriak | yep i know, sadly that doesnt include support for looping on include | 13:13 |
odyssey4me | javeriak so what do you need to support it? | 13:14 |
evrardjp | mhayden: I'd like to define a list of servers (so something like ["",""]) | 13:14 |
evrardjp | each server being a dict | 13:14 |
evrardjp | (so I guess something like [ {}, {}] ) | 13:14 |
evrardjp | each of them having name and ip for example | 13:15 |
mhayden | wowzers | 13:15 |
mhayden | i haven't done anything quite like that before | 13:15 |
javeriak | i could get stuff to work with jinja2.8 (my setup downloaded 2.7) | 13:15 |
evrardjp | so [ { 'name' : 'tada' , 'ip': '127.0.0.1' }, {...} ] | 13:16 |
evrardjp | but when I try that, ansible complaints | 13:16 |
odyssey4me | javeriak hmm, that's interesting - is this a build from master, or from the kilo branch? | 13:17 |
javeriak | odyssey4me master | 13:20 |
odyssey4me | javeriak yeah, it seems that OpenStack also uses jinja but it's minimum is also 2.6 | 13:22 |
*** brice has joined #openstack-ansible | 13:23 | |
odyssey4me | javeriak the trouble is that while we can implement a higher jinja version for master right now, backporting it into the stable branches may not be accepted so easily | 13:23 |
evrardjp | to be complete, [ { 'name': 'tada', 'ip': '127.0.0.1'}, { 'name': 'abc', 'ip': '127.0.0.1'}] works if I put it like that in a variable, but not if I use loops etc | 13:24 |
odyssey4me | are you sure there's not another way you can achieve the same goal? | 13:24 |
*** rromans is now known as rromans_pto | 13:24 | |
openstackgerrit | Miguel Alejandro Cantu proposed openstack/openstack-ansible: Removes /opt/*openstack*/ pattern from teardown. https://review.openstack.org/228558 | 13:25 |
*** scarlisle has joined #openstack-ansible | 13:26 | |
javeriak | odyssey4me alright makes sense, yes I'll just have to use sub-optimal logic for now, which will be duplicating some variables because they're needed directly and as part of a dict, sorry for the delay in pushing my changed for my BPs | 13:26 |
odyssey4me | javeriak yeah, we'll be able to do some pretty nifty optimising once Ansible 2 releases. For now we're doing a lot of sub-optimal stuff. :/ | 13:27 |
odyssey4me | javeriak will you be making it to the summit in Tokyo? | 13:28 |
javeriak | odyssey4me yep i'm gonna wait for v2 anxiously too now :), nope I wont be making it to the summit unfortunately | 13:31 |
evrardjp | yeah, ansible2 will bring huge improvements | 13:32 |
evrardjp | combine variables! | 13:32 |
*** jasondotstar|afk is now known as jasondotstar | 13:32 | |
evrardjp | package management os agnostic! | 13:32 |
javeriak | evrardjp yea :) | 13:34 |
*** mgoddard has quit IRC | 13:35 | |
openstackgerrit | Merged openstack/openstack-ansible: Remove unused libvirt-bin file https://review.openstack.org/228371 | 13:39 |
*** Mudpuppy has joined #openstack-ansible | 13:47 | |
*** mgoddard has joined #openstack-ansible | 13:49 | |
*** KLevenstein has joined #openstack-ansible | 13:51 | |
*** javeriak has quit IRC | 13:52 | |
*** javeriak has joined #openstack-ansible | 13:55 | |
*** openstackstatus has joined #openstack-ansible | 13:56 | |
*** ChanServ sets mode: +v openstackstatus | 13:56 | |
*** jmckind has joined #openstack-ansible | 13:58 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Various Documentation Updates https://review.openstack.org/230423 | 13:58 |
cloudnull | morning | 14:01 |
evrardjp | good morning cloudnull | 14:03 |
*** spotz_zzz is now known as spotz | 14:03 | |
openstackgerrit | Merged openstack/openstack-ansible: Initial security documentation https://review.openstack.org/228591 | 14:04 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Limit the number of Ansible forks used to 10 https://review.openstack.org/229786 | 14:05 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Removed unused variables from os_heat role https://review.openstack.org/230458 | 14:06 |
* mhayden tips his hat to cloudnull for the deuce | 14:08 | |
cloudnull | o/ : ) | 14:08 |
*** shausy has quit IRC | 14:09 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:09 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Update Keystone to Liberty RC1 https://review.openstack.org/226917 | 14:14 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Update Cinder to Liberty RC1 https://review.openstack.org/227205 | 14:14 |
*** mgoddard_ has joined #openstack-ansible | 14:29 | |
*** mgoddard has quit IRC | 14:32 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Update all SHA's (except Horizon) to Liberty branch SHA's https://review.openstack.org/228385 | 14:38 |
*** alextricity has joined #openstack-ansible | 14:39 | |
*** phalmos has joined #openstack-ansible | 14:44 | |
*** gparaskevas has quit IRC | 14:51 | |
odyssey4me | mattt can you please cast your eye on https://review.openstack.org/230935 and https://review.openstack.org/230520 | 14:54 |
mattt | odyssey4me: yep | 14:56 |
*** dcreno has left #openstack-ansible | 14:59 | |
*** javeriak has quit IRC | 15:02 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Add developer docs entry for using tox https://review.openstack.org/231041 | 15:10 |
*** shausy has joined #openstack-ansible | 15:13 | |
*** javeriak has joined #openstack-ansible | 15:13 | |
*** mgoddard_ has quit IRC | 15:14 | |
*** mgoddard has joined #openstack-ansible | 15:15 | |
*** alejandrito has joined #openstack-ansible | 15:23 | |
openstackgerrit | Merged openstack/openstack-ansible: Add maas external check for neutron metadata proxy https://review.openstack.org/230631 | 15:26 |
openstackgerrit | Merged openstack/openstack-ansible: Add install guide docs regarding config overrides https://review.openstack.org/230368 | 15:26 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Removes /opt/*openstack*/ pattern from teardown. https://review.openstack.org/228558 | 15:27 |
arbrandes | cloudnull: thanks for the reply, earlier. :) | 15:44 |
cloudnull | anytime | 15:44 |
arbrandes | Another question: I'm upgrading from 11.2.2 to 11.2.3. Is a repo-install.yml run + a setup-openstack.yml run enough? | 15:45 |
cloudnull | repo-build.yml + setup-openstack.yml | 15:45 |
arbrandes | cloudnull: awesome, thanks! | 15:45 |
*** mgoddard_ has joined #openstack-ansible | 15:45 | |
cloudnull | or repo-clone.yml for kilo | 15:45 |
arbrandes | cloudnull: yeah, I figured. We're actually repo-cloning, for now. | 15:46 |
cloudnull | that'll do it | 15:46 |
arbrandes | We were after the ARP spoofing protection for linuxbridge | 15:48 |
arbrandes | Nice that it just made it in for 11.2.3. :) | 15:48 |
*** mgoddard has quit IRC | 15:48 | |
odyssey4me | cloudnull what's the best way for an outdated clone to fetch all the new tags before checking out to the new tag? | 15:49 |
cloudnull | git fetch --all | 15:50 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Add novnc console support https://review.openstack.org/228197 | 15:50 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Install spice-html5 from source https://review.openstack.org/226462 | 15:51 |
cloudnull | mattt: can you give https://review.openstack.org/#/c/228197/8 a review. its the dependent patch for jmccrory 's update to the spice console change. | 15:52 |
cloudnull | when you get a chance that i s | 15:52 |
arbrandes | Cool, I was going to report https://review.openstack.org/#/c/228197/7..8/playbooks/roles/os_nova/defaults/main.yml,unified, but glad to see it's already fixed. :) | 15:54 |
cloudnull | arbrandes: did you give the novnc bits a go ? if so, did it work for you ? | 15:55 |
cloudnull | besides the service restart that is :) | 15:55 |
arbrandes | cloudnull: aside from that issue, there's just one other thing. I'm digging up where exactly, just a sec. | 15:55 |
*** jmckind has quit IRC | 15:55 | |
*** alejandrito has quit IRC | 15:55 | |
mattt | cloudnull: oh derp, this is dependent isn't it ... i'll give that one a thorough test asap (which will most likely be tomorrow morning :( ) | 15:55 |
*** jmckind has joined #openstack-ansible | 15:56 | |
cloudnull | no worries. thanks btw | 15:56 |
cloudnull | if you have an env with the spice patch, you'll also have the novnc bits too. | 15:56 |
cloudnull | when you give it a go, you'll have to change "nova_console_type=novnc" which should do all of the needful for you. | 15:57 |
mattt | cloudnull: sweet, i do have an AIO which i used for the other patch so i'll leave this online for tomorrow | 15:58 |
cloudnull | ALL: the venv bits are just about done (still fiddeling with neutron) if anyone would like to give them a go it'd be much appreciated. https://review.openstack.org/#/q/status:open+project:openstack/openstack-ansible+branch:master+topic:bp/enable-venv-support-within-the-roles,n,z | 15:58 |
mattt | anyway, afk for the moment | 15:58 |
cloudnull | have a good one mattt | 15:58 |
mattt | cloudnull: later man! | 15:59 |
*** shausy has quit IRC | 15:59 | |
*** mgoddard has joined #openstack-ansible | 16:00 | |
*** mgoddard_ has quit IRC | 16:00 | |
*** galstrom_zzz is now known as galstrom | 16:01 | |
arbrandes | cloudnull: see comment here, https://review.openstack.org/#/c/228197/8/playbooks/roles/os_nova/defaults/main.yml,unified | 16:02 |
arbrandes | I worded the comment wrongly, though. I meant to say, "the host the compute service is running on" | 16:03 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement neutron venv support https://review.openstack.org/230726 | 16:06 |
cloudnull | arbrandes: looking now | 16:06 |
odyssey4me | cloudnull how would someone scope the upgrade of the os-nova-install playbook to just, say, the compute nodes - or a particular node? | 16:06 |
odyssey4me | (I'm documenting the minor upgrade process) | 16:06 |
cloudnull | odyssey4me: openstack-ansible os-nova-install.yml --limit nova_compute --skip-tags 'nova-key' | 16:13 |
cloudnull | you'd want to skip the tag nova-key if you we're only upgrading a subset of nodes | 16:13 |
odyssey4me | ah, because it doesn't gather the facts from the appropriate node? | 16:14 |
cloudnull | if you were upgrading and adding nodes: openstack-ansible os-nova-install.yml --limit nova_compute | 16:14 |
cloudnull | odyssey4me: yes | 16:14 |
odyssey4me | ok, and if it was a single node, would it be '--limit <nodename>' ? | 16:14 |
cloudnull | yes | 16:14 |
cloudnull | odyssey4me: openstack-ansible os-nova-install.yml --limit <node-name> --skip-tags 'nova-key' | 16:15 |
cloudnull | ^ single node upgrade | 16:15 |
cloudnull | the key tasks rekeys all nodes in an environment which is great for security but wont work unless all nodes are part of the run. | 16:16 |
*** alejandrito has joined #openstack-ansible | 16:16 | |
*** vdo has quit IRC | 16:19 | |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Add novnc console support https://review.openstack.org/228197 | 16:19 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Install spice-html5 from source https://review.openstack.org/226462 | 16:20 |
cloudnull | arbrandes: updated based on your comments about setting the compute address for the proxy client | 16:20 |
arbrandes | cloudnull: awesome! | 16:22 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Add minor upgrade documentation to the install guide https://review.openstack.org/231078 | 16:23 |
odyssey4me | cloudnull ^ please check it | 16:24 |
odyssey4me | arbrandes if you can check it too it'd be great :) | 16:24 |
* cloudnull checking | 16:24 | |
arbrandes | The minor upgrade doc change? Sure! | 16:24 |
*** skamithi has joined #openstack-ansible | 16:26 | |
arbrandes | LGTM. It'll come in handy, thanks! | 16:27 |
*** skamithi has left #openstack-ansible | 16:27 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Add minor upgrade documentation to the install guide https://review.openstack.org/231078 | 16:29 |
odyssey4me | ^ some minor tweaks cloudnull arbrandes | 16:29 |
cloudnull | odyssey4me: i added a comment on patchset 1 | 16:29 |
arbrandes | odyssey4me: still looks good :) | 16:30 |
openstackgerrit | Merged openstack/openstack-ansible: Fix bashate violations https://review.openstack.org/230520 | 16:30 |
openstackgerrit | Merged openstack/openstack-ansible: Fix incorrect tox.ini config https://review.openstack.org/230935 | 16:30 |
cloudnull | +1 looks good and will be super useful | 16:30 |
*** galstrom is now known as galstrom_zzz | 16:31 | |
*** alejandrito has quit IRC | 16:37 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Add minor upgrade documentation to the install guide https://review.openstack.org/231078 | 16:38 |
*** alop has joined #openstack-ansible | 16:38 | |
odyssey4me | cloudnull updated based on your feedback, thanks :) | 16:39 |
cloudnull | +2 | 16:40 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Remove unused libvirt-bin file https://review.openstack.org/231084 | 16:41 |
odyssey4me | mhayden please backport https://review.openstack.org/228907 to the kilo branch | 16:45 |
* mhayden does the thing | 16:46 | |
openstackgerrit | Major Hayden proposed openstack/openstack-ansible: Add confirmation to teardown.sh https://review.openstack.org/231086 | 16:46 |
*** cloudtrainme has joined #openstack-ansible | 16:47 | |
*** javeriak has quit IRC | 16:47 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Fix bashate violations https://review.openstack.org/231090 | 16:52 |
palendae | cloudnull: For https://bugs.launchpad.net/openstack-ansible/+bug/1497681, were you envisioning the pre task to basically do what's in https://review.openstack.org/#/c/224137/24/scripts/upgrade-utilities/playbooks/cinder-adjustments.yml ? | 17:00 |
openstack | Launchpad bug 1497681 in openstack-ansible "cinder udev entry has empty whitespace" [Medium,Confirmed] - Assigned to Nolan Brubaker (nolan-brubaker) | 17:00 |
openstackgerrit | Merged openstack/openstack-ansible: Removed unused variables from os_heat role https://review.openstack.org/230458 | 17:00 |
cloudnull | palendae: yup | 17:00 |
palendae | Ok | 17:01 |
cloudnull | itll fix the udev whitespace issue without causing a container restart | 17:01 |
palendae | Ah, ok. Was going to ask why we don't change the variable template, but that's a good reason | 17:01 |
cloudnull | yea it cant hurt leaving juno as is. | 17:02 |
cloudnull | and with that task it corrects the issue when upgrading | 17:02 |
*** javeriak has joined #openstack-ansible | 17:03 | |
palendae | Ok. So basically, the line's fine in isolation, but having the pre task clean up will ensure that we're not carrying 2 of the same rule and confusing lxc | 17:04 |
palendae | I was just removing the extra spacey line, but I'll modify my current work to put the 'right' one ine. | 17:04 |
palendae | one in... | 17:04 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Updated the neutron l3HA tool to use v3 https://review.openstack.org/229053 | 17:07 |
*** subscope has joined #openstack-ansible | 17:09 | |
arbrandes | A general container host question. I see /openstack is used for logs and databases. It looks like if I want to partition this host's file system, mounting /openstack from a separate LV is a good idea. Does this sound right to you guys? | 17:09 |
cloudnull | arbrandes: yes | 17:09 |
cloudnull | thats what we do in prodd | 17:09 |
cloudnull | *prod | 17:09 |
arbrandes | cloudnull: excellent, thanks for the confirmation. :) | 17:09 |
cloudnull | palendae: palendae: yes the https://review.openstack.org/#/c/224137/24/scripts/upgrade-utilities/playbooks/cinder-adjustments.yml,cm should remove the line and replace it such that theres no duplication causing the cinder-volume in container upgrade failure. | 17:10 |
cloudnull | sorry for the double name :) | 17:10 |
cloudnull | obviously if its moved to the host its not a problem all together. | 17:11 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Various Documentation Updates https://review.openstack.org/230423 | 17:16 |
cloudnull | odyssey4me: https://review.openstack.org/229053 <- adds v2 + v3 support | 17:16 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Updated the neutron l3HA tool to use v3 https://review.openstack.org/229053 | 17:17 |
cloudnull | ^ that one for real this time :) | 17:17 |
odyssey4me | cloudnull ah, that looks good :) | 17:18 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Updates the lint check to ignore templates https://review.openstack.org/231101 | 17:22 |
*** javeriak_ has joined #openstack-ansible | 17:23 | |
*** javeriak has quit IRC | 17:25 | |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement ceilometer venv support https://review.openstack.org/229212 | 17:25 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement heat venv support https://review.openstack.org/229225 | 17:25 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement glance venv support https://review.openstack.org/229221 | 17:26 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement horizon venv support https://review.openstack.org/229226 | 17:27 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement keystone venv support https://review.openstack.org/229513 | 17:28 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement nova venv support https://review.openstack.org/230727 | 17:29 |
*** openstackgerrit has quit IRC | 17:31 | |
*** openstackgerrit has joined #openstack-ansible | 17:31 | |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Updates the lint check to ignore templates https://review.openstack.org/231101 | 17:33 |
*** alejandrito has joined #openstack-ansible | 17:34 | |
*** javeriak has joined #openstack-ansible | 17:34 | |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Updates the lint check to ignore templates https://review.openstack.org/231101 | 17:34 |
cloudnull | openstackgerrit: ^ updated to support tox too | 17:34 |
*** javeriak_ has quit IRC | 17:34 | |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement neutron venv support https://review.openstack.org/230726 | 17:37 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement cinder venv support https://review.openstack.org/225463 | 17:38 |
*** alejandrito has quit IRC | 17:38 | |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement swift venv support https://review.openstack.org/230733 | 17:39 |
cloudnull | sorry s/ openstackgerrit/ odyssey4me / | 17:40 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement nova venv support https://review.openstack.org/230727 | 17:42 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement keystone venv support https://review.openstack.org/229513 | 17:42 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement horizon venv support https://review.openstack.org/229226 | 17:42 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement glance venv support https://review.openstack.org/229221 | 17:43 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement heat venv support https://review.openstack.org/229225 | 17:43 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Implement ceilometer venv support https://review.openstack.org/229212 | 17:43 |
cloudnull | sorry for all the spam ... | 17:43 |
cloudnull | but im done rebasing for a bit :) | 17:43 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Updates the lint check to ignore templates https://review.openstack.org/231117 | 17:48 |
*** jmckind is now known as jmckind_ | 17:52 | |
odyssey4me | mhayden and https://github.com/openstack/openstack-ansible-security is born :) | 18:01 |
*** openstackgerrit has quit IRC | 18:01 | |
*** openstackgerrit has joined #openstack-ansible | 18:02 | |
*** alop has quit IRC | 18:02 | |
*** alop has joined #openstack-ansible | 18:04 | |
cloudnull | mhayden: typie typie make the role :) | 18:06 |
openstackgerrit | Merged openstack/openstack-ansible: Removes /opt/*openstack*/ pattern from teardown. https://review.openstack.org/228558 | 18:29 |
*** elo1 has joined #openstack-ansible | 18:57 | |
*** elo has quit IRC | 18:59 | |
mhayden | odyssey4me: well would you look at that | 19:06 |
mhayden | odyssey4me / cloudnull: so since we have something here -> https://github.com/rackerlabs/openstack-ansible-security , what is the best way to begin getting that upstreamed? | 19:07 |
mhayden | should i do it in chunks? | 19:07 |
openstackgerrit | Ian Cordasco proposed openstack/openstack-ansible: Limit the number of Ansible forks used to 10 https://review.openstack.org/229786 | 19:07 |
mhayden | all together? | 19:07 |
cloudnull | for the initial pull , i'd do it in one big chunk , but that call is up to odyssey4me | 19:09 |
palendae | Personally I'd do it in a big pull if you already have work | 19:09 |
palendae | Not sure if it's useful to re-do the commit history just to move repos | 19:10 |
palendae | My 2c, but like cloudnull said Jesse has the final word | 19:10 |
odyssey4me | mhayden yeah, one big commit - otherwise we have to review multiple bits | 19:11 |
*** jmckind_ is now known as jmckind | 19:18 | |
mhayden | okay | 19:20 |
openstackgerrit | Ian Cordasco proposed openstack/openstack-ansible: Add developer docs entry for using tox https://review.openstack.org/231041 | 19:21 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Fix bashate violations https://review.openstack.org/231090 | 19:22 |
rackertom | odyssey4me: Hello sir, I'm looking at https://review.openstack.org/#/c/229786/ | 19:26 |
odyssey4me | rackertom yep | 19:26 |
rackertom | I don't understand the purpose, I think | 19:26 |
odyssey4me | the purpose of the patch? | 19:26 |
odyssey4me | or of the forks parameter? | 19:26 |
rackertom | The change references an sshd limit, but the patch is happening on the client side | 19:26 |
rackertom | The patch changing the cap on the forks parameter | 19:26 |
odyssey4me | rackertom yes, it mentions the default sshd limit - which is what we're catering for on the lcient side | 19:27 |
odyssey4me | *client | 19:27 |
rackertom | So is this only for AIO then? | 19:27 |
odyssey4me | we do not wish to screw with a deployer's sshd configuration | 19:27 |
rackertom | Correct. I would not suggest that. | 19:28 |
odyssey4me | nope, this is general - if a deployer chooses to change their host sshd config then they have the docs info on how to use a higher number of forks | 19:28 |
odyssey4me | right now the capability is there, but no-one knows about it | 19:28 |
rackertom | I'm simply suggesting we may want to make this HOST_COUNT*10, which for AIO is 1 and for other deployments is a sensible default number | 19:28 |
odyssey4me | this is not what the testing has come up with | 19:29 |
palendae | fwiw https://github.com/rcbops/rpc-openstack/blob/master/scripts/deploy.sh#L15, but I think our internal QE people set it to 10 all the time | 19:29 |
odyssey4me | all testing has suggested using no more than 10 unless sshd config is changed | 19:29 |
odyssey4me | it's not the amount of hosts because if you set forks=20 then ansible will try to use 20 connections to a host if it needs it | 19:29 |
rackertom | But again, sshd is for the ssh server side, and we're the client. | 19:29 |
palendae | rackertom: Well, it seems to be specifically 'delegate_to' tasks | 19:30 |
*** sdake has joined #openstack-ansible | 19:30 | |
rackertom | By hosts I mean metal boxes | 19:30 |
bgmccollum | rackertom: i did lots of testing of this -- https://bugs.launchpad.net/openstack-ansible/+bug/1479812/comments/10 | 19:30 |
openstack | Launchpad bug 1479812 in openstack-ansible trunk "ssh connection failures during deployments" [Low,In progress] - Assigned to Jesse Pretorius (jesse-pretorius) | 19:30 |
odyssey4me | yes, so we're limiting to 10 all the time and informing people that they can do more if they want to | 19:30 |
palendae | Which get hairy | 19:30 |
palendae | Yeah,was going to reference bgmccollum's bug report | 19:30 |
palendae | https://bugs.launchpad.net/openstack-ansible/+bug/1479812/comments/5 | 19:31 |
palendae | ^ that specifically refers to how delegate_to interacts with ansible's forks and sshd | 19:31 |
bgmccollum | oh yeah...that too | 19:31 |
rackertom | So the problem is actually the frequency, not the count | 19:32 |
rackertom | And again, it's frequency over the count of hosts. Combined with a sensible max cap of 10*hosts | 19:34 |
scarlisle | cloudnull qq about patch set 24 | 19:38 |
cloudnull | yes? | 19:39 |
scarlisle | why'd you remove the tags from juno-container-cleanup.sh. Just wondering | 19:39 |
bgmccollum | rackertom: if you have 5 hosts, and using 10*5 as you suggest would allow 50 forks. if your infra1 has lets say 25 containers, there is the possibility that infra1 will have 25 simultaneous connections to manage those containers via delegate_to, and go over the maxstartups lower limit. ansible doesn't evenly divide up the fork between hosts... | 19:39 |
openstackgerrit | Merged openstack/openstack-ansible: Add confirmation to teardown.sh https://review.openstack.org/231086 | 19:40 |
cloudnull | scarlisle: it was failing to build when libs were missing. | 19:40 |
scarlisle | ahh | 19:40 |
cloudnull | i have a tester running for 5 upgrades ever 3 or so hours and it was all failing on that part. | 19:40 |
scarlisle | ok, gotcha. Lab is almost back at 10.1.15 (playbooks are running ungodly slow today) so I might be able to start reviewing that patch set today | 19:41 |
cloudnull | without the tags there it succeeded. | 19:41 |
cloudnull | nice | 19:42 |
cloudnull | let me know ill be around all day | 19:42 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Removed unused variables from os_heat role https://review.openstack.org/231147 | 19:42 |
scarlisle | cool | 19:42 |
odyssey4me | anyone care to do a quick backport of https://review.openstack.org/228558 ? | 19:43 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Add install guide docs regarding config overrides https://review.openstack.org/231148 | 19:43 |
odyssey4me | mhayden is https://review.openstack.org/228591 applicable to kilo? if so, backport please | 19:44 |
* mhayden ganders | 19:44 | |
odyssey4me | sigmavirus24 backport of https://review.openstack.org/215357 to kilo please | 19:44 |
*** brice has quit IRC | 19:44 | |
openstackgerrit | Ian Cordasco proposed openstack/openstack-ansible: Remove containers from /etc/hosts during teardown https://review.openstack.org/231149 | 19:45 |
sigmavirus24 | ^ odyssey4me | 19:45 |
odyssey4me | cloudnull backport of https://review.openstack.org/229540 to kilo please | 19:45 |
odyssey4me | thanks sigmavirus24 :) | 19:45 |
mhayden | odyssey4me: it does apply, especially with the SSL backports from last week | 19:45 |
mhayden | i'll cherry pickerrrr | 19:45 |
openstackgerrit | Major Hayden proposed openstack/openstack-ansible: Initial security documentation https://review.openstack.org/231151 | 19:45 |
openstackgerrit | Kevin Carter proposed openstack/openstack-ansible: Updates ansible role requirements script name https://review.openstack.org/231153 | 19:48 |
cloudnull | odyssey4me: done | 19:48 |
openstackgerrit | Nolan Brubaker proposed openstack/openstack-ansible: Ensure cinder container udev line isn't duplicated https://review.openstack.org/231154 | 19:49 |
*** sdake has quit IRC | 19:59 | |
mhayden | odyssey4me: for the openstack-ansible-security review, should all of the commits so far be rebased down? | 20:02 |
odyssey4me | mhayden you need to squash them all into one commit | 20:04 |
odyssey4me | otherwise there'll be a ton of reviews in the queue | 20:04 |
sigmavirus24 | odyssey4me: looking at your docs patch, you have all those Home links in the docs, why? They render not so great: http://docs-draft.openstack.org/23/230423/7/check/gate-openstack-ansible-docs/e9c7441//doc/build/html/install-guide/index.html (for example) | 20:06 |
odyssey4me | sigmavirus24 I agree, but those are existing links that I just cleaned up a little and made the dev docs work the same way. | 20:07 |
odyssey4me | There are a few things I'm not fond of in the current docs. | 20:08 |
sigmavirus24 | Ah okay | 20:08 |
odyssey4me | But it'll take time and more focused patches to fix. That patch is just a general fix for lots of horribleness. :p | 20:08 |
sigmavirus24 | misread the diffs | 20:09 |
odyssey4me | an example - why a whole page for this? http://docs.openstack.org/developer/openstack-ansible/install-guide/install-foundation-run.html | 20:09 |
odyssey4me | we could consolidate and simplify a lot, and I'll do those in focused patches to make discussion easier | 20:09 |
sigmavirus24 | not sure consolidation is necessary in all cases but making things better wouldn't hurt | 20:10 |
openstackgerrit | Merged openstack/openstack-ansible: Various Documentation Updates https://review.openstack.org/230423 | 20:10 |
odyssey4me | agreed - I just think that 3 lines on one page is silly - too much clickey clickey :p | 20:12 |
*** markvoelker has joined #openstack-ansible | 20:12 | |
*** tlian2 has joined #openstack-ansible | 20:21 | |
*** tlian has quit IRC | 20:24 | |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Add minor upgrade documentation to the install guide https://review.openstack.org/231078 | 20:26 |
*** jmckind is now known as jmckind_ | 20:27 | |
*** CheKoLyN has joined #openstack-ansible | 20:30 | |
*** agireud has joined #openstack-ansible | 20:31 | |
openstackgerrit | Major Hayden proposed openstack/openstack-ansible-security: Initial import of openstack-ansible-security role https://review.openstack.org/231165 | 20:32 |
* mhayden gulps | 20:32 | |
odyssey4me | mhayden can you please backport https://review.openstack.org/223742 ? | 20:33 |
odyssey4me | (to kilo) | 20:33 |
openstackgerrit | Major Hayden proposed openstack/openstack-ansible: Add AIO build docs https://review.openstack.org/231167 | 20:33 |
mhayden | odyssey4me: woot | 20:33 |
openstackgerrit | Major Hayden proposed openstack/openstack-ansible-security: Initial import of openstack-ansible-security role https://review.openstack.org/231165 | 20:36 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Add install guide docs regarding config overrides https://review.openstack.org/231148 | 20:37 |
*** jmckind_ is now known as jmckind | 20:37 | |
mhayden | odyssey4me: so the review is in, but it's kinda large | 20:37 |
odyssey4me | mhayden that's fine - we can let it through as it's a seeding review | 20:38 |
odyssey4me | cloudnull ^ | 20:38 |
mhayden | thanks odyssey4me | 20:39 |
cloudnull | yes? | 20:39 |
odyssey4me | mhayden you need to figure out what gating you'd like to have there - maybe a docs check? and an ansible syntax/lint check? | 20:39 |
mhayden | cloudnull: dropped a tiny review in there for you | 20:39 |
mhayden | odyssey4me: absolutely -- is there an example from openstack-ansible i could follow? | 20:40 |
mhayden | https://github.com/openstack/openstack-ansible/blob/master/scripts/gate-check-lint.sh ? | 20:40 |
* cloudnull looking | 20:41 | |
odyssey4me | mhayden nope - lemme clue you in | 20:42 |
odyssey4me | mhayden first, https://github.com/openstack/openstack-ansible/blob/master/tox.ini | 20:42 |
openstackgerrit | Miguel Alejandro Cantu proposed openstack/openstack-ansible: Removes /opt/*openstack*/ pattern from teardown. https://review.openstack.org/231173 | 20:43 |
odyssey4me | that'll enable you to test locally - see https://review.openstack.org/231041 for how to execute tox for each purpose | 20:44 |
mhayden | odyssey4me: nice, thanks | 20:45 |
*** persia has quit IRC | 20:53 | |
*** persia has joined #openstack-ansible | 20:54 | |
*** persia has quit IRC | 20:54 | |
*** persia has joined #openstack-ansible | 20:54 | |
openstackgerrit | Major Hayden proposed openstack/openstack-ansible-security: Initial import of openstack-ansible-security role https://review.openstack.org/231165 | 20:54 |
mhayden | odyssey4me: first try ^^ | 20:54 |
mhayden | should i add a toxenv to run ansible-lint | 20:54 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Fix broken link in documentation https://review.openstack.org/231182 | 21:00 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Update documentation for rename in cidr_networks https://review.openstack.org/231183 | 21:00 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Fixing broken networking link https://review.openstack.org/231184 | 21:00 |
odyssey4me | mhayden once you have pep8/bashate we'll try and use the standard -infra gate check instead of the one we currently use | 21:01 |
mhayden | sounds good -- pep8 works fine right now but i have no python in this repo ;) | 21:02 |
*** woodard_ has joined #openstack-ansible | 21:02 | |
mhayden | other than setup.py | 21:02 |
mhayden | and no bash | 21:02 |
*** woodard has quit IRC | 21:05 | |
openstackgerrit | Javeria Khan proposed openstack/openstack-ansible: Modularizing Neutron playbooks for master https://review.openstack.org/231187 | 21:05 |
*** woodard_ has quit IRC | 21:06 | |
openstackgerrit | Javeria Khan proposed openstack/openstack-ansible: Modularizing Neutron playbooks for master https://review.openstack.org/231187 | 21:08 |
mhayden | odyssey4me: i'm headed out but will probably be online later to add things if needed | 21:09 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Adding docs for configuring horizon https://review.openstack.org/231190 | 21:09 |
javeriak | odyssey4me, sorry for the late convergence on the bp commit, was just butting my head over different ansible/jinja limitations atm, would really appreciate some early reviews, everyones pushing for quick PG+RAX kilo support :) https://review.openstack.org/231187 | 21:13 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Adding docs for configuring horizon https://review.openstack.org/231193 | 21:15 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Various Documentation Updates https://review.openstack.org/231194 | 21:19 |
*** phalmos has quit IRC | 21:24 | |
openstackgerrit | Miguel Alejandro Cantu proposed openstack/openstack-ansible: Add OpenID Connect RP Apache Module[WIP] https://review.openstack.org/226617 | 21:29 |
openstackgerrit | Jesse Pretorius proposed openstack/openstack-ansible: Various Documentation Updates https://review.openstack.org/231194 | 21:30 |
*** Mudpuppy has quit IRC | 21:32 | |
openstackgerrit | Miguel Alejandro Cantu proposed openstack/openstack-ansible: Add OpenID Connect RP Apache Module[WIP] https://review.openstack.org/226617 | 21:32 |
openstackgerrit | Miguel Alejandro Cantu proposed openstack/openstack-ansible: Add OpenID Connect RP Apache Module https://review.openstack.org/226617 | 21:33 |
*** subscope has quit IRC | 21:33 | |
*** harlowja has quit IRC | 21:59 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:06 | |
*** openstackgerrit has quit IRC | 22:16 | |
*** openstackgerrit has joined #openstack-ansible | 22:16 | |
*** spotz is now known as spotz_zzz | 22:34 | |
openstackgerrit | Javeria Khan proposed openstack/openstack-ansible: Adding PLUMgrid plugin option to neutron setup https://review.openstack.org/231214 | 22:40 |
*** jmckind has quit IRC | 22:43 | |
*** javeriak has quit IRC | 22:44 | |
openstackgerrit | Miguel Alejandro Cantu proposed openstack/openstack-ansible: Add OpenID Connect RP Apache Module https://review.openstack.org/226617 | 22:48 |
*** harlowja has joined #openstack-ansible | 22:48 | |
*** cloudtrainme has quit IRC | 22:54 | |
*** CheKoLyN has quit IRC | 23:10 | |
openstackgerrit | Merged openstack/openstack-ansible: Removes /opt/*openstack*/ pattern from teardown. https://review.openstack.org/231173 | 23:25 |
*** pradk has quit IRC | 23:30 | |
*** KLevenstein has quit IRC | 23:33 | |
*** Mudpuppy has joined #openstack-ansible | 23:44 | |
*** scarlisle has quit IRC | 23:46 | |
*** galstrom_zzz is now known as galstrom | 23:50 | |
*** mgoddard_ has joined #openstack-ansible | 23:51 | |
*** mgoddard has quit IRC | 23:52 | |
*** mgoddard__ has joined #openstack-ansible | 23:52 | |
*** mgoddard_ has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!