Wednesday, 2021-10-20

opendevreviewSatish Patel proposed openstack/openstack-ansible-os_neutron master: DPDK required libdpdk-dev package to bind port  https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/81469002:59
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_barbican stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/81433703:11
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_blazar stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_blazar/+/81433903:12
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_barbican stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/81433703:13
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_barbican stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/81433703:14
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_blazar stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_blazar/+/81433903:14
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_congress stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_congress/+/81434003:15
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_designate stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/81434103:15
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_heat stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_heat/+/81434203:16
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_ironic stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/81434303:16
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_magnum stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/81434403:17
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_masakari stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_masakari/+/81434503:17
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_mistral stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_mistral/+/81434603:17
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_octavia stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_octavia/+/81434703:19
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_rally stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_rally/+/81434803:19
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_sahara stable/stein: Remove debian-stable jobs  https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/81434903:20
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_swift stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_swift/+/81435003:20
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_tacker stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_tacker/+/81435103:20
opendevreviewIan Wienand proposed openstack/openstack-ansible-os_trove stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/81433803:21
ianw^ that has put everything back the way i found it and *only* removes the debian-stable job, as discussed prior.  i didn't want to pollute things (further) with more changes03:22
opendevreviewMerged openstack/openstack-ansible-os_trove stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/81433803:26
opendevreviewMerged openstack/openstack-ansible-os_tacker stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_tacker/+/81435103:27
opendevreviewMerged openstack/openstack-ansible-os_swift stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_swift/+/81435003:28
opendevreviewMerged openstack/openstack-ansible-os_sahara stable/stein: Remove debian-stable jobs  https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/81434903:30
opendevreviewMerged openstack/openstack-ansible-os_rally stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_rally/+/81434803:31
opendevreviewMerged openstack/openstack-ansible-os_octavia stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_octavia/+/81434703:32
opendevreviewMerged openstack/openstack-ansible-os_mistral stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_mistral/+/81434603:32
opendevreviewMerged openstack/openstack-ansible-os_masakari stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_masakari/+/81434503:34
opendevreviewMerged openstack/openstack-ansible-os_magnum stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/81434403:34
opendevreviewMerged openstack/openstack-ansible-os_ironic stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/81434303:35
opendevreviewMerged openstack/openstack-ansible-os_heat stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_heat/+/81434203:36
opendevreviewMerged openstack/openstack-ansible-os_designate stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/81434103:36
opendevreviewMerged openstack/openstack-ansible-os_congress stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_congress/+/81434003:37
opendevreviewMerged openstack/openstack-ansible-os_blazar stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_blazar/+/81433903:38
opendevreviewMerged openstack/openstack-ansible-os_barbican stable/stein: Remove debian-stable job  https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/81433703:39
opendevreviewJonathan Rosser proposed openstack/openstack-ansible stable/stein: Fetch upper constraints file with curl rather than allow pip to download it  https://review.opendev.org/c/openstack/openstack-ansible/+/81456007:46
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible stable/stein: Remove tempest plugins CI overrides  https://review.opendev.org/c/openstack/openstack-ansible/+/81455808:04
opendevreviewJonathan Rosser proposed openstack/openstack-ansible stable/stein: Fetch upper constraints file with curl rather than allow pip to download it  https://review.opendev.org/c/openstack/openstack-ansible/+/81456008:19
opendevreviewJonathan Rosser proposed openstack/openstack-ansible stable/stein: Fetch upper constraints file with curl rather than allow pip to download it  https://review.opendev.org/c/openstack/openstack-ansible/+/81456009:43
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible stable/stein: Remove tempest plugins CI overrides  https://review.opendev.org/c/openstack/openstack-ansible/+/81455811:21
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_tempest stable/stein: Fix tempest plugin versions  https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/81453511:26
opendevreviewDmitriy Rabotyagov proposed openstack/ansible-hardening master: Explicitly create clamav socket directory  https://review.opendev.org/c/openstack/ansible-hardening/+/81474812:27
opendevreviewSoniya Murlidhar Vyas proposed openstack/openstack-ansible-os_tempest master: [WIP] Need to add netstat logging in the background  https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/81399013:22
opendevreviewJonathan Rosser proposed openstack/ansible-role-python_venv_build stable/stein: Workaround distro provided pip having old CA certs on centos-7  https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/81455913:22
opendevreviewJonathan Rosser proposed openstack/ansible-role-python_venv_build stable/stein: Set centos-7 jobs to non voting  https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/81477513:22
opendevreviewJonathan Rosser proposed openstack/ansible-role-python_venv_build stable/stein: Revert "Set centos-7 jobs to non voting"  https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/81477613:22
opendevreviewMerged openstack/openstack-ansible-os_tempest master: Added var file for EL9  https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/81452613:44
spateljamesdenton may need your review - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/81469013:51
jamesdentonhah yep, i had something similar in mind13:57
spatel+1 cool let promote this 14:05
jrosseris it really that -dev package it needs?14:06
jrosserthat has a ton of dependancies and it could easily  be one of those which is actually required14:07
spateljrosser this is how ubuntu packaging decided 14:07
jrosserthats kind of not what i meant14:07
spatelthat package has lots of libs which required by dpdk 14:07
spatelhttps://paste.opendev.org/show/810103/14:09
spatelif you see it has some .so file which contain driver information for dpdk. Ex: /usr/lib/x86_64-linux-gnu/dpdk/pmds-20.0/librte_pmd_ixgbe.so14:10
spatelif i remove this package i am not able to bind dpdk port but if i re-install it works, that is why i cut this patch. 14:11
jrosserok fine, thats kind of handy info to be in the commit message so that we understand this in the future14:15
jrosserparticularly as it looks like a wierd pacakge to need14:15
jrosserlets just make a comment on the patch and not update anything14:15
spatellet me update comment directly from portal 14:21
*** andrewbonney_ is now known as andrewbonney14:26
opendevreviewSatish Patel proposed openstack/openstack-ansible-os_neutron master: DPDK required libdpdk-dev package to bind port  https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/81469014:26
noonedeadpunkPTG time! :)15:01
mgariepywhat's the link ! :D15:01
noonedeadpunkhttps://www.openstack.org/ptg/rooms/havana15:02
noonedeadpunkjrosser_: I guess you're not around now?15:03
mgariepyspatel, jamesdenton ? joining ?15:06
spateli am here15:06
spatelcoming15:06
jamesdentoni will but am on a 1000-1030 call15:09
jrosser_I can join shortly, I’m a meeting here too15:09
opendevreviewJames Gibson proposed openstack/openstack-ansible master: Fix error in dynamic-address-fact task when no tunnel interface  https://review.opendev.org/c/openstack/openstack-ansible/+/81480416:08
opendevreviewJonathan Rosser proposed openstack/ansible-role-python_venv_build stable/stein: Revert "Set centos-7 jobs to non voting"  https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/81477616:45
opendevreviewMerged openstack/openstack-ansible-os_neutron master: DPDK required libdpdk-dev package to bind port  https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/81469019:01
spateljamesdenton around?19:03
jamesdentonaye19:03
spatelcan you explain this code - https://opendev.org/openstack/openstack-ansible-os_neutron/src/branch/master/tasks/providers/setup_ovs_dpdk.yml#L11519:04
spateli am trying to work with dpdk bonding and having problem to adjust ansible variables. let me show you what i want19:05
spateltell me what is wrong here - https://paste.opendev.org/show/810119/19:05
jamesdentonyes - it is intended to connect a user-defined interface (i.e. eth1) to a user-defined bridge (i.e. br-ex)19:06
spatelhttps://docs.ansible.com/ansible/latest/collections/openvswitch/openvswitch/openvswitch_bond_module.html19:06
spateli am using your code as example to setup for bonding19:07
jamesdentonhttps://paste.opendev.org/show/810120/19:07
spatelok19:08
jamesdentonwhat error are you getting19:08
spateli came up with this idea to configure bonding  - https://paste.opendev.org/show/810119/19:08
spateli think loop_var is problem 19:08
spatelif you see this example - https://docs.ansible.com/ansible/latest/collections/openvswitch/openvswitch/openvswitch_bond_module.html19:09
spatelhow do i pass set: parameter - https://paste.opendev.org/show/810121/19:09
spatelhow do i prepare list variables and pass to set: 19:10
jamesdentonshow me ovs_dpdk_pci_addresses19:10
spatelovs_dpdk_pci_addresses:19:11
spatel  - 0000:3b:00.119:11
spatel  - 0000:af:00.119:11
jamesdentonand can you show me the error you're getting?19:11
spatelin user_variables file19:11
spatelhttps://paste.opendev.org/show/810122/19:11
spatelif you see ovs output bonding isn't properly setup19:11
spatelInterface "0000:3b:00.1" is working but second interface didn't properly passed to ansible set: via loop19:12
spateli believe my loop or with_items are not correct.. 19:13
spatelwith_items run line by line on list 19:14
spateli believe that won't work with that play, set: need list value 19:15
jamesdentonso maybe construct the set in a prior task>19:17
jamesdentonbut the error you;re getting seems to indicate "0000:af:00.1" doesn't exist?19:20
jamesdentonor maybe not bound to dpdk?19:20
spatelif i use hardcore values in set: then it works like following19:21
spatelThis is working - https://paste.opendev.org/show/810123/19:21
spatelhope it helps to understand what i am trying to do 19:22
jamesdentongotcha19:22
spateli want set: parameter take value from variable and use as a list 19:22
spateli tried with_list: option but that doesn't work19:22
spatelmy ansible knowledge is limited :)19:23
jamesdentonmaybe this19:23
jamesdentonhttps://paste.opendev.org/show/810124/19:26
jamesdentonno guarantees19:26
spatellets see.. hold on19:27
spatelrunning play19:27
spatelerror - https://paste.opendev.org/show/810125/19:29
spatellet me run same command on bash and see 19:30
spatellook like we have extra ( - ) 19:31
spatellet me change and see19:31
jamesdentonmight try this: https://paste.opendev.org/show/810126/19:33
spatelk19:34
spateltrying that19:34
spatelerror - https://paste.opendev.org/show/810127/19:35
spatelsorry my bad19:36
spatelsomething is wrong in double quote 19:37
spatelit doesn't like it19:37
jamesdentonoh i think i had an extra quote at the end19:37
jamesdentonremove the one after the endfor19:37
spatelgot it 19:37
spatelre-running19:37
spatelsame error look like - https://paste.opendev.org/show/810128/19:38
spatelvery odd everything looks good 19:39
spatelset: [{% for dpdk_pci_addresses in ovs_dpdk_pci_addresses %} "interface {{ dpdk_pci_addresses }} type=dpdk options:dpdk-devargs={{ dpdk_pci_addresses }}" {% if not loop.last %},{% endif %}{% endfor %}]19:39
spatelcan you pass multiple option in set: without ( , ) ?19:39
jamesdentonno, it would need to be a comma separated list19:40
spateli can see comma in your command19:40
spatellet me try some other combination 19:41
jamesdentontry enclosing everything in single quotes19:45
jamesdentonset: '[...]'19:46
spatelok19:46
spateli did this and it works19:47
spatelset: "{% for dpdk_pci_addresses in ovs_dpdk_pci_addresses %} interface {{ dpdk_pci_addresses }} type=dpdk options:dpdk-devargs={{ dpdk_pci_addresses }} {% if not loop.last %},{% endif %}{% endfor %}"19:48
spatelremoved  [..]19:48
spatelin this method only 2 port can bond.. what if someone has 4 port.. its stupid but just thinking 19:49
spateloh wait.. i believe that should work 19:49
spatelsorry my bad19:49
spatelI am planning to push this change to OSA so if someone say dpdk_bond=True then this code will run otherwise not 19:50
jamesdentonshould be anywhere from 1-X19:51
jamesdentonthe comma will be omitted on the last entry in the list of PCI addresses19:51
spatelyes.. 19:51
spatelthis logic is perfect 19:52
jamesdentonso removing the brackets worked, eh? cool.19:52
jamesdentoni added single quotes and kept the brackets and it worked in debug19:52
jamesdentongotta run. nice job19:52
spatelThank for the help :)19:52
opendevreviewSatish Patel proposed openstack/openstack-ansible-os_neutron master: Add support of dpdk bonding  https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/81482520:12
spateljamesdenton take a look at this patch and feel free comment or suggest - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/81482520:13
opendevreviewSatish Patel proposed openstack/openstack-ansible-os_neutron master: Add support of dpdk bonding  https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/81482520:17

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!