opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: DPDK required libdpdk-dev package to bind port https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/814690 | 02:59 |
---|---|---|
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_barbican stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/814337 | 03:11 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_blazar stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_blazar/+/814339 | 03:12 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_barbican stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/814337 | 03:13 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_barbican stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/814337 | 03:14 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_blazar stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_blazar/+/814339 | 03:14 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_congress stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_congress/+/814340 | 03:15 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_designate stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/814341 | 03:15 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_heat stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_heat/+/814342 | 03:16 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_ironic stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/814343 | 03:16 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_magnum stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/814344 | 03:17 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_masakari stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_masakari/+/814345 | 03:17 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_mistral stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_mistral/+/814346 | 03:17 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_octavia stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_octavia/+/814347 | 03:19 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_rally stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_rally/+/814348 | 03:19 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_sahara stable/stein: Remove debian-stable jobs https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/814349 | 03:20 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_swift stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_swift/+/814350 | 03:20 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_tacker stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_tacker/+/814351 | 03:20 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_trove stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/814338 | 03:21 |
ianw | ^ that has put everything back the way i found it and *only* removes the debian-stable job, as discussed prior. i didn't want to pollute things (further) with more changes | 03:22 |
opendevreview | Merged openstack/openstack-ansible-os_trove stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/814338 | 03:26 |
opendevreview | Merged openstack/openstack-ansible-os_tacker stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_tacker/+/814351 | 03:27 |
opendevreview | Merged openstack/openstack-ansible-os_swift stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_swift/+/814350 | 03:28 |
opendevreview | Merged openstack/openstack-ansible-os_sahara stable/stein: Remove debian-stable jobs https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/814349 | 03:30 |
opendevreview | Merged openstack/openstack-ansible-os_rally stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_rally/+/814348 | 03:31 |
opendevreview | Merged openstack/openstack-ansible-os_octavia stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_octavia/+/814347 | 03:32 |
opendevreview | Merged openstack/openstack-ansible-os_mistral stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_mistral/+/814346 | 03:32 |
opendevreview | Merged openstack/openstack-ansible-os_masakari stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_masakari/+/814345 | 03:34 |
opendevreview | Merged openstack/openstack-ansible-os_magnum stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/814344 | 03:34 |
opendevreview | Merged openstack/openstack-ansible-os_ironic stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/814343 | 03:35 |
opendevreview | Merged openstack/openstack-ansible-os_heat stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_heat/+/814342 | 03:36 |
opendevreview | Merged openstack/openstack-ansible-os_designate stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/814341 | 03:36 |
opendevreview | Merged openstack/openstack-ansible-os_congress stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_congress/+/814340 | 03:37 |
opendevreview | Merged openstack/openstack-ansible-os_blazar stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_blazar/+/814339 | 03:38 |
opendevreview | Merged openstack/openstack-ansible-os_barbican stable/stein: Remove debian-stable job https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/814337 | 03:39 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/stein: Fetch upper constraints file with curl rather than allow pip to download it https://review.opendev.org/c/openstack/openstack-ansible/+/814560 | 07:46 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible stable/stein: Remove tempest plugins CI overrides https://review.opendev.org/c/openstack/openstack-ansible/+/814558 | 08:04 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/stein: Fetch upper constraints file with curl rather than allow pip to download it https://review.opendev.org/c/openstack/openstack-ansible/+/814560 | 08:19 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/stein: Fetch upper constraints file with curl rather than allow pip to download it https://review.opendev.org/c/openstack/openstack-ansible/+/814560 | 09:43 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible stable/stein: Remove tempest plugins CI overrides https://review.opendev.org/c/openstack/openstack-ansible/+/814558 | 11:21 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_tempest stable/stein: Fix tempest plugin versions https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/814535 | 11:26 |
opendevreview | Dmitriy Rabotyagov proposed openstack/ansible-hardening master: Explicitly create clamav socket directory https://review.opendev.org/c/openstack/ansible-hardening/+/814748 | 12:27 |
opendevreview | Soniya Murlidhar Vyas proposed openstack/openstack-ansible-os_tempest master: [WIP] Need to add netstat logging in the background https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/813990 | 13:22 |
opendevreview | Jonathan Rosser proposed openstack/ansible-role-python_venv_build stable/stein: Workaround distro provided pip having old CA certs on centos-7 https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/814559 | 13:22 |
opendevreview | Jonathan Rosser proposed openstack/ansible-role-python_venv_build stable/stein: Set centos-7 jobs to non voting https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/814775 | 13:22 |
opendevreview | Jonathan Rosser proposed openstack/ansible-role-python_venv_build stable/stein: Revert "Set centos-7 jobs to non voting" https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/814776 | 13:22 |
opendevreview | Merged openstack/openstack-ansible-os_tempest master: Added var file for EL9 https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/814526 | 13:44 |
spatel | jamesdenton may need your review - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/814690 | 13:51 |
jamesdenton | hah yep, i had something similar in mind | 13:57 |
spatel | +1 cool let promote this | 14:05 |
jrosser | is it really that -dev package it needs? | 14:06 |
jrosser | that has a ton of dependancies and it could easily be one of those which is actually required | 14:07 |
spatel | jrosser this is how ubuntu packaging decided | 14:07 |
jrosser | thats kind of not what i meant | 14:07 |
spatel | that package has lots of libs which required by dpdk | 14:07 |
spatel | https://paste.opendev.org/show/810103/ | 14:09 |
spatel | if you see it has some .so file which contain driver information for dpdk. Ex: /usr/lib/x86_64-linux-gnu/dpdk/pmds-20.0/librte_pmd_ixgbe.so | 14:10 |
spatel | if i remove this package i am not able to bind dpdk port but if i re-install it works, that is why i cut this patch. | 14:11 |
jrosser | ok fine, thats kind of handy info to be in the commit message so that we understand this in the future | 14:15 |
jrosser | particularly as it looks like a wierd pacakge to need | 14:15 |
jrosser | lets just make a comment on the patch and not update anything | 14:15 |
spatel | let me update comment directly from portal | 14:21 |
*** andrewbonney_ is now known as andrewbonney | 14:26 | |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: DPDK required libdpdk-dev package to bind port https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/814690 | 14:26 |
noonedeadpunk | PTG time! :) | 15:01 |
mgariepy | what's the link ! :D | 15:01 |
noonedeadpunk | https://www.openstack.org/ptg/rooms/havana | 15:02 |
noonedeadpunk | jrosser_: I guess you're not around now? | 15:03 |
mgariepy | spatel, jamesdenton ? joining ? | 15:06 |
spatel | i am here | 15:06 |
spatel | coming | 15:06 |
jamesdenton | i will but am on a 1000-1030 call | 15:09 |
jrosser_ | I can join shortly, I’m a meeting here too | 15:09 |
opendevreview | James Gibson proposed openstack/openstack-ansible master: Fix error in dynamic-address-fact task when no tunnel interface https://review.opendev.org/c/openstack/openstack-ansible/+/814804 | 16:08 |
opendevreview | Jonathan Rosser proposed openstack/ansible-role-python_venv_build stable/stein: Revert "Set centos-7 jobs to non voting" https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/814776 | 16:45 |
opendevreview | Merged openstack/openstack-ansible-os_neutron master: DPDK required libdpdk-dev package to bind port https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/814690 | 19:01 |
spatel | jamesdenton around? | 19:03 |
jamesdenton | aye | 19:03 |
spatel | can you explain this code - https://opendev.org/openstack/openstack-ansible-os_neutron/src/branch/master/tasks/providers/setup_ovs_dpdk.yml#L115 | 19:04 |
spatel | i am trying to work with dpdk bonding and having problem to adjust ansible variables. let me show you what i want | 19:05 |
spatel | tell me what is wrong here - https://paste.opendev.org/show/810119/ | 19:05 |
jamesdenton | yes - it is intended to connect a user-defined interface (i.e. eth1) to a user-defined bridge (i.e. br-ex) | 19:06 |
spatel | https://docs.ansible.com/ansible/latest/collections/openvswitch/openvswitch/openvswitch_bond_module.html | 19:06 |
spatel | i am using your code as example to setup for bonding | 19:07 |
jamesdenton | https://paste.opendev.org/show/810120/ | 19:07 |
spatel | ok | 19:08 |
jamesdenton | what error are you getting | 19:08 |
spatel | i came up with this idea to configure bonding - https://paste.opendev.org/show/810119/ | 19:08 |
spatel | i think loop_var is problem | 19:08 |
spatel | if you see this example - https://docs.ansible.com/ansible/latest/collections/openvswitch/openvswitch/openvswitch_bond_module.html | 19:09 |
spatel | how do i pass set: parameter - https://paste.opendev.org/show/810121/ | 19:09 |
spatel | how do i prepare list variables and pass to set: | 19:10 |
jamesdenton | show me ovs_dpdk_pci_addresses | 19:10 |
spatel | ovs_dpdk_pci_addresses: | 19:11 |
spatel | - 0000:3b:00.1 | 19:11 |
spatel | - 0000:af:00.1 | 19:11 |
jamesdenton | and can you show me the error you're getting? | 19:11 |
spatel | in user_variables file | 19:11 |
spatel | https://paste.opendev.org/show/810122/ | 19:11 |
spatel | if you see ovs output bonding isn't properly setup | 19:11 |
spatel | Interface "0000:3b:00.1" is working but second interface didn't properly passed to ansible set: via loop | 19:12 |
spatel | i believe my loop or with_items are not correct.. | 19:13 |
spatel | with_items run line by line on list | 19:14 |
spatel | i believe that won't work with that play, set: need list value | 19:15 |
jamesdenton | so maybe construct the set in a prior task> | 19:17 |
jamesdenton | but the error you;re getting seems to indicate "0000:af:00.1" doesn't exist? | 19:20 |
jamesdenton | or maybe not bound to dpdk? | 19:20 |
spatel | if i use hardcore values in set: then it works like following | 19:21 |
spatel | This is working - https://paste.opendev.org/show/810123/ | 19:21 |
spatel | hope it helps to understand what i am trying to do | 19:22 |
jamesdenton | gotcha | 19:22 |
spatel | i want set: parameter take value from variable and use as a list | 19:22 |
spatel | i tried with_list: option but that doesn't work | 19:22 |
spatel | my ansible knowledge is limited :) | 19:23 |
jamesdenton | maybe this | 19:23 |
jamesdenton | https://paste.opendev.org/show/810124/ | 19:26 |
jamesdenton | no guarantees | 19:26 |
spatel | lets see.. hold on | 19:27 |
spatel | running play | 19:27 |
spatel | error - https://paste.opendev.org/show/810125/ | 19:29 |
spatel | let me run same command on bash and see | 19:30 |
spatel | look like we have extra ( - ) | 19:31 |
spatel | let me change and see | 19:31 |
jamesdenton | might try this: https://paste.opendev.org/show/810126/ | 19:33 |
spatel | k | 19:34 |
spatel | trying that | 19:34 |
spatel | error - https://paste.opendev.org/show/810127/ | 19:35 |
spatel | sorry my bad | 19:36 |
spatel | something is wrong in double quote | 19:37 |
spatel | it doesn't like it | 19:37 |
jamesdenton | oh i think i had an extra quote at the end | 19:37 |
jamesdenton | remove the one after the endfor | 19:37 |
spatel | got it | 19:37 |
spatel | re-running | 19:37 |
spatel | same error look like - https://paste.opendev.org/show/810128/ | 19:38 |
spatel | very odd everything looks good | 19:39 |
spatel | set: [{% for dpdk_pci_addresses in ovs_dpdk_pci_addresses %} "interface {{ dpdk_pci_addresses }} type=dpdk options:dpdk-devargs={{ dpdk_pci_addresses }}" {% if not loop.last %},{% endif %}{% endfor %}] | 19:39 |
spatel | can you pass multiple option in set: without ( , ) ? | 19:39 |
jamesdenton | no, it would need to be a comma separated list | 19:40 |
spatel | i can see comma in your command | 19:40 |
spatel | let me try some other combination | 19:41 |
jamesdenton | try enclosing everything in single quotes | 19:45 |
jamesdenton | set: '[...]' | 19:46 |
spatel | ok | 19:46 |
spatel | i did this and it works | 19:47 |
spatel | set: "{% for dpdk_pci_addresses in ovs_dpdk_pci_addresses %} interface {{ dpdk_pci_addresses }} type=dpdk options:dpdk-devargs={{ dpdk_pci_addresses }} {% if not loop.last %},{% endif %}{% endfor %}" | 19:48 |
spatel | removed [..] | 19:48 |
spatel | in this method only 2 port can bond.. what if someone has 4 port.. its stupid but just thinking | 19:49 |
spatel | oh wait.. i believe that should work | 19:49 |
spatel | sorry my bad | 19:49 |
spatel | I am planning to push this change to OSA so if someone say dpdk_bond=True then this code will run otherwise not | 19:50 |
jamesdenton | should be anywhere from 1-X | 19:51 |
jamesdenton | the comma will be omitted on the last entry in the list of PCI addresses | 19:51 |
spatel | yes.. | 19:51 |
spatel | this logic is perfect | 19:52 |
jamesdenton | so removing the brackets worked, eh? cool. | 19:52 |
jamesdenton | i added single quotes and kept the brackets and it worked in debug | 19:52 |
jamesdenton | gotta run. nice job | 19:52 |
spatel | Thank for the help :) | 19:52 |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: Add support of dpdk bonding https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/814825 | 20:12 |
spatel | jamesdenton take a look at this patch and feel free comment or suggest - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/814825 | 20:13 |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: Add support of dpdk bonding https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/814825 | 20:17 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!