| opendevreview | Merged openstack/openstack-ansible-plugins master: Update for CONTRIBUTING.rst file https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/971783 | 12:22 |
|---|---|---|
| opendevreview | Merged openstack/openstack-ansible master: docs: Update configuration documentation https://review.opendev.org/c/openstack/openstack-ansible/+/969466 | 12:24 |
| opendevreview | Ivan Anfimov proposed openstack/openstack-ansible-os_magnum stable/2025.2: Do not remove policy.yaml file https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/974824 | 13:17 |
| opendevreview | Merged openstack/ansible-role-pki master: Add hashi_vault backend https://review.opendev.org/c/openstack/ansible-role-pki/+/948881 | 13:42 |
| jrosser | damiandabrowski: i don't know if you have any view about the order we should merge the rest of the hashi vault patches? | 14:34 |
| noonedeadpunk | I have a comment to all of them kinda | 14:35 |
| noonedeadpunk | but I left it here: https://review.opendev.org/c/openstack/openstack-ansible-os_cinder/+/949427 | 14:35 |
| jrosser | and i wonder does this cover everything? https://review.opendev.org/q/topic:%22osa_hashi_vault%22+status:open | 14:35 |
| damiandabrowski | we need to patch all service roles now. when it's done, we need to merge patches in integrated repo | 14:36 |
| noonedeadpunk | we can pretend this issue does not exist, as we still need to cover 2.19 issues regardless | 14:36 |
| noonedeadpunk | but I'd rather not merge smth which is known not to work | 14:36 |
| damiandabrowski | https://review.opendev.org/q/topic:%22osa_hashi_vault%22+status:open does not cover everything(yet) but it covers all services from our default tests scenario | 14:36 |
| damiandabrowski | noonedeadpunk: thanks for a comment, I'll fix it | 14:37 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Update Ansible Core to 2.19 https://review.opendev.org/c/openstack/openstack-ansible/+/971756 | 14:40 |
| noonedeadpunk | talking about the devil.... | 14:40 |
| jrosser | hmm i wonder how we will know what even needs doing | 14:46 |
| noonedeadpunk | well... Ideally ansible-lint should be catching *some* things | 14:48 |
| noonedeadpunk | but things like that driving me nuts: https://review.opendev.org/c/openstack/ansible-role-pki/+/971772/1/vars/main.yml | 14:50 |
| noonedeadpunk | btw - maybe you have any better idea how to do that?> | 14:50 |
| jrosser | oh my thats nasty | 14:57 |
| noonedeadpunk | especially give we have that pattern in many places... | 14:59 |
| noonedeadpunk | nah, ansible-lint doesn't not seem to be bothered by issues much :( | 15:06 |
| jrosser | for that case i would say that the equivalent python was maybe a one liner | 15:06 |
| jrosser | and as we use it everywhere a custom filter would not be a terrible choice | 15:07 |
| jrosser | becasue its pretty much unreadable as it stands | 15:07 |
| noonedeadpunk | yeah, it probably does make sense to have it indeed... | 15:07 |
| noonedeadpunk | smth like `reject_if_exists` | 15:08 |
| jrosser | maybe you found it already but this discusses the exact case https://www.0xf8.org/2021/03/filtering-with-ansibles-selectattr-rejectattr-when-the-tested-attribute-can-be-absent/ | 15:08 |
| jrosser | hah and ends with "At some point you should of course consider writing a dedicated test in Python" | 15:09 |
| noonedeadpunk | nice... | 15:10 |
| noonedeadpunk | yeah | 15:10 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-openstack_hosts master: Make role compatible with ansible-core>=2.19 https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/975033 | 15:17 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ansible-role-pki master: Ensure condition exists before rejectattr https://review.opendev.org/c/openstack/ansible-role-pki/+/971772 | 15:27 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-haproxy_server master: Ensure defaults are proper booleans https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/975035 | 15:33 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ansible-role-systemd_service master: Ensure systemd_overrides_only exists before rejectattr https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/971771 | 15:52 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ansible-role-python_venv_build master: Ensure multiline jinja ends with variable https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/975044 | 16:29 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Update Ansible Core to 2.19 https://review.opendev.org/c/openstack/openstack-ansible/+/971756 | 16:32 |
| noonedeadpunk | hopefully now it passes up to setup-openstack... | 16:33 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ansible-role-python_venv_build master: Ensure multiline jinja ends with variable https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/975044 | 16:49 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_keystone master: Don't attempt to loop over undefined variables https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/975052 | 17:10 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Update Ansible Core to 2.19 https://review.opendev.org/c/openstack/openstack-ansible/+/971756 | 17:10 |
| noonedeadpunk | and now answering the question - I have really no idea how to ensure that we have everything covered.... | 17:11 |
| opendevreview | Merged openstack/openstack-ansible-os_glance stable/2025.2: Update configuration for cinder_catalog_info https://review.opendev.org/c/openstack/openstack-ansible-os_glance/+/974716 | 17:36 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_cinder master: Ensure implicit boolean conversion https://review.opendev.org/c/openstack/openstack-ansible-os_cinder/+/975054 | 17:39 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Update Ansible Core to 2.19 https://review.opendev.org/c/openstack/openstack-ansible/+/971756 | 17:39 |
| jrosser | noonedeadpunk: https://paste.opendev.org/show/bBZQ57Afxe7ZOmPubd9U/ | 17:47 |
| jrosser | ^ tested this on a list of dicts that may/may not have `condition` defined | 17:50 |
| noonedeadpunk | that somehow looks too simple :D | 17:51 |
| noonedeadpunk | Ithink would be nice to be able to pass the key to get as an argument, but yeah... | 17:52 |
| noonedeadpunk | I think we should do smth like that | 17:52 |
| jrosser | yeah its way nicer than the jinja | 17:59 |
| noonedeadpunk | it was reasonable enough before, but that's indeed over the edge even for me.... | 17:59 |
| noonedeadpunk | can you come up with the patch for the filter? I can update my patches to use/depend on it then | 18:00 |
| noonedeadpunk | (I mislead about naming as reject/rejectattr are likely different ones, or just different by another argument) | 18:01 |
| opendevreview | Merged openstack/openstack-ansible-os_keystone stable/2025.1: Fix shibboleth installation for EL https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/974633 | 18:04 |
| opendevreview | Merged openstack/openstack-ansible-os_keystone stable/2025.2: Fix shibboleth installation for EL https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/974632 | 22:06 |
| opendevreview | Merged openstack/openstack-ansible-os_glance stable/2025.1: Update configuration for cinder_catalog_info https://review.opendev.org/c/openstack/openstack-ansible-os_glance/+/974718 | 23:10 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!