| jrosser | noonedeadpunk: yes i can make a patch for the filter | 08:02 |
|---|---|---|
| jrosser | and ideas on the name? (hardest problem in computing of course) | 08:02 |
| jrosser | *any | 08:02 |
| noonedeadpunk[e] | It is indeed... | 08:03 |
| jrosser | i cant totally think of something that describes the optional-ness of the condition | 08:03 |
| jrosser | its sort of `reject_when(input, 'condition', 'false)` | 08:04 |
| jrosser | i.e reject when condition is defined and condition is false | 08:04 |
| noonedeadpunk[e] | rejectattr_if_defined? | 08:04 |
| noonedeadpunk[e] | Too long kinda | 08:04 |
| noonedeadpunk[e] | Eventually it will be openstack.osa.<name> | 08:05 |
| noonedeadpunk[e] | So we can have it as just openstack.osa.rejectattr | 08:05 |
| jrosser | yeah and its not at all a drop in replacement for rejectattr | 08:05 |
| noonedeadpunk[e] | Isn't it? | 08:06 |
| noonedeadpunk[e] | What if we filter input and pass it to the rejectattr? | 08:07 |
| noonedeadpunk[e] | But dunno | 08:07 |
| jrosser | rejectattr lets you define the test yourself | 08:07 |
| jrosser | but here we say "bool evaulate this key" | 08:07 |
| noonedeadpunk[e] | True | 08:08 |
| jrosser | well maybe `reject_key` | 08:09 |
| jrosser | but still somehow awkward | 08:10 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-plugins master: Add reject_when filter https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/975123 | 09:12 |
| jrosser | noonedeadpunk: did we write a howto guide for running molecule locally? | 10:14 |
| jrosser | oh i remember its via tox isnt it | 10:17 |
| noonedeadpunk | yeah, it's tox -e molecule | 10:22 |
| noonedeadpunk | we actually need to update our contributor docs wrt this | 10:22 |
| jrosser | yeah its kind of unclear how to start from zero in a new vm | 10:22 |
| jrosser | (just trying to make some test for this new filterO) | 10:23 |
| noonedeadpunk | I'd guess `git clone; apt install python3-tox; tox -e molecule`? | 10:35 |
| jrosser | thats it | 10:35 |
| jrosser | though i've just been tripped up by the first attempt at running it being extremely slow (it has to get all the depenencies once, and doesnt tell you what its doing without -v) | 10:35 |
| jrosser | oh and of course docker install | 10:36 |
| noonedeadpunk | I wonder if we can improve that dependency management somehow... | 10:38 |
| noonedeadpunk | without returning wrapper script to run tox like we had | 10:38 |
| jrosser | is this what bindep is for? | 10:39 |
| noonedeadpunk | actually, yes | 10:39 |
| noonedeadpunk | then we just need to run bindep in tox | 10:39 |
| noonedeadpunk | or well | 10:39 |
| noonedeadpunk | so it's run by zuul | 10:39 |
| noonedeadpunk | but not when you execute manually... | 10:40 |
| jrosser | right | 10:40 |
| noonedeadpunk | and then docker is a separate thing in zuul... | 10:41 |
| noonedeadpunk | I wonder why we stopped using `deprecated` filter... That sounds like an amazing idea? | 10:47 |
| noonedeadpunk | so.... | 11:12 |
| noonedeadpunk | I have come up with some alternative.... | 11:14 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-plugins master: Implement custom rejectatr filter https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/975141 | 11:18 |
| noonedeadpunk | jrosser: this should be a drop-in replacement for rejectattr, which brings old functionality ^ | 11:19 |
| noonedeadpunk | I actually don't know what would be preference... | 11:21 |
| noonedeadpunk | but this way it's possible to just s/rejectattr/openstack.osa.rejectattr/ | 11:21 |
| jrosser | oh cool | 11:43 |
| jrosser | well maybe thats more obvious as its more familiar | 11:44 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-plugins master: Use Display for deprecated filter https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/975146 | 12:38 |
| noonedeadpunk | we really should consider using `| deprecated` going forward - how this cool thing was lost... | 12:40 |
| noonedeadpunk | it would be also sooo easy to search for | 12:40 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-plugins master: Implement custom rejectatr filter https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/975141 | 13:26 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-plugins master: Use Display for deprecated filter https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/975146 | 15:59 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ansible-role-pki master: Use internal rejectattr implementation https://review.opendev.org/c/openstack/ansible-role-pki/+/971772 | 16:43 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ansible-role-systemd_service master: Ensure systemd_overrides_only exists before rejectattr https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/971771 | 16:46 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-plugins master: Pre-Evaluate nova_console_proxy_types https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/975185 | 17:40 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Update Ansible Core to 2.19 https://review.opendev.org/c/openstack/openstack-ansible/+/971756 | 17:49 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Update Ansible Core to 2.19 https://review.opendev.org/c/openstack/openstack-ansible/+/971756 | 17:58 |
| noonedeadpunk | it's so annoying... | 17:58 |
| noonedeadpunk | I really wonder how we can cover everyting... except just grepping for `when:` and then verifying all occurances... | 17:59 |
| noonedeadpunk | as even what is bool is not guaranteed to be bool, because if it's passed with --extra-vars in console - it can be broken | 17:59 |
| noonedeadpunk | as -e always passed as a string... | 18:00 |
| noonedeadpunk | it makes things cleaner as a resulkt I guess.... but how to reach that state... | 18:01 |
| opendevreview | Dmitriy Chubinidze proposed openstack/openstack-ansible master: Force skyline-console yarn build https://review.opendev.org/c/openstack/openstack-ansible/+/975217 | 20:08 |
| opendevreview | Dmitriy Chubinidze proposed openstack/openstack-ansible master: Force skyline-console yarn build https://review.opendev.org/c/openstack/openstack-ansible/+/975217 | 20:11 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!