Wednesday, 2015-09-23

kzaitsev_mbkfox1111: sure, will do =)01:34
*** kzaitsev_mb has quit IRC01:38
*** kebray has joined #openstack-app-catalog01:56
*** kzaitsev_mb has joined #openstack-app-catalog02:35
*** kzaitsev_mb has quit IRC02:39
*** kzaitsev_mb has joined #openstack-app-catalog03:36
*** kebray has quit IRC03:49
*** kzaitsev_mb has quit IRC04:05
docaedokfox1111: am alive, was on the move all day today, will test 226578 tomorrow morning.04:51
docaedoAlso should have SSL sorted probably tomorrow04:52
docaedoand have been playing with flask, RAML and Ramses, looks like getting the first pass of the API stuff up and running won't be terribly difficult04:53
docaedoWas encouraged yesterday to take a look at how the OpenStack marketplace has integrated openstack ID stuff (so more homework for me :) )04:54
*** docaedo has quit IRC06:37
*** docaedo has joined #openstack-app-catalog06:43
*** kzaitsev_mb has joined #openstack-app-catalog07:47
*** kzaitsev_mb has quit IRC07:51
*** kzaitsev_mb has joined #openstack-app-catalog08:31
*** kzaitsev_mb has quit IRC09:10
*** kzaitsev_mb has joined #openstack-app-catalog10:30
*** kzaitsev_mb has quit IRC12:39
kfox1111docaedo: awesome. thanks.13:13
*** kzaitsev_mb has joined #openstack-app-catalog13:35
docaedokfox1111: np, also will put in request for common elements repo today14:42
*** kebray has joined #openstack-app-catalog15:26
kfox1111docaedo: awesome. thanks.15:30
*** kebray has quit IRC15:30
kfox1111yeah, if we could reuse openstack id's that would be awesome.15:31
kfox1111looks like the horizon heat env patch made it through.15:32
kfox1111so we can do those features when we get a chance.15:32
*** kebray has joined #openstack-app-catalog15:45
*** kebray has quit IRC15:46
*** kebray has joined #openstack-app-catalog15:50
*** kebray has quit IRC16:11
*** kebray has joined #openstack-app-catalog16:12
*** kebray has quit IRC16:35
*** kebray has joined #openstack-app-catalog16:40
*** kzaitsev_mb has quit IRC17:13
kfox1111docaedo: ok, so... I'm thinking that I want to add a new schema field at the root of an asset. asset_version. If it doesn't exist, its assumed to be 1. If greater then 1, then that specific asset will be marked as unsupported in horizon.17:33
kfox1111so, say we don't support heat environments... (we don't at present).17:34
kfox1111if we released our horizon plugin as it was today, then if we added a heat asset that required an environment to function properly, the asset would be broken in horizon.17:34
kfox1111by saying asset_version: 2, then that heat resource would work on plugins that knew that schema, and exclude those that don't.17:35
kfox1111we wouldn't need a whole new api version then each time we want to add a feature that required something of the plugin.17:36
kfox1111what do you think?17:36
* docaedo ponders17:46
kfox1111kind of a schema version per asset, rather hten on the whole asset file itself.17:47
kfox1111fields that are added that arn't required will just kind of work. things that are added that are required to work, but horizon may not support in a given version bump the version so horizon plugin knows its not supported.17:48
docaedoI would say it couldn't hurt to add that, and it would definitely be helpful for the case you state17:49
kfox1111k. let me code something up real quick for review.17:50
openstackgerritKevin Fox proposed openstack/app-catalog-ui: Handle an asset service schema version
kfox1111k. I think that will do what we want. it will allow any asset to have a service.version to specify the supported schema version for that particular asset.18:26
docaedonice, I'll take a look in the next few hours18:27
kfox1111if its anything other then 1, then the horizon plugin marks it as unsupported.18:27
kfox1111did you get a chance to look at the code cleanup review?18:28
docaedono not yet but I will - stepping out for a minute, but will do that as soon as I get back18:38
kfox1111k. thanks.18:41
kfox1111I want to try and land basic heat environment support for 1.0 which shouldn't take long, and I'd like to add some minimum supported engine feature, but that may be too complicated...18:43
*** kebray has quit IRC18:52
*** kebray has joined #openstack-app-catalog19:46
*** kzaitsev_mb has joined #openstack-app-catalog20:09
*** kzaitsev_mb has quit IRC20:18
*** kzaitsev_mb has joined #openstack-app-catalog20:23
*** kzaitsev_mb has quit IRC20:30
*** kzaitsev_mb has joined #openstack-app-catalog20:32
kfox1111really stuck on rdo doing things with my package submission request. :_(20:44
docaedoI am not sure I have any help to offer on that front unfortunately20:59
docaedoBut SSL stuff is in progress at least:
kfox1111nice. thanks.21:10
docaedoRequest for additional repo:
docaedoI'll respond to your comments when I'm back from a late lunch, but the empty string sections were copied from the gerrit example (so might be OK that it's failing gate)21:18
docaedoand same goes for port 80 vs 443 - in my local test environment, it sets up both of them and listens on both of them. I'm not sure about the port line though, maybe I can specify both (but TBH the other examples I saw showed only one port, but web sites listening on both)21:19
docaedooh man 0 for 2, second commit failed gate too!21:20
kfox1111did you start with a fresh test server? for the port 80 vs 443 thing? (Not sure how that workflow works. never done it)21:22
docaedodamn confusing alphabet :/ Additional repo request should pass gate now.21:23
docaedokfox1111: did not start with a fresh server, will verify that shortly21:24
kfox1111I'm guessing it will work until its fresh, then it might break.21:24
*** kzaitsev_mb has quit IRC21:30
*** kebray has quit IRC21:34
*** kzaitsev_mb has joined #openstack-app-catalog21:34
kzaitsev_mbI have a commit ready, that adds elint checks to app-catalog-ui, but... my mac has updated xcode and npm install now fails with ugly errors =) I guess I'm about to recompile some stuff21:35
kzaitsev_mbI've also noticed, that we don't have any tests in app catalog-ui =) doesn't look good. might dive in that sometime in the future. anyway I wanted to dive into tox magic a bit more21:37
kfox1111awesome, sucks about the errors, and awesome. :)21:40
kfox1111docaedo: have any of the frameworks you've looked at do js compression and scss?21:56
openstackgerritKirill Zaitsev proposed openstack/app-catalog-ui: Add eslint checking machinery
kfox1111kzaitsev_ws: commented in the review.22:02
kzaitsev_mbsure =)22:04
kzaitsev_mbNot really sure if that would ever break anything, since it's unlikely anyone would install app-catalog npm package and app-catalog-ui npm package in the same env =)) but nice to be consistent there =)22:05
openstackgerritKirill Zaitsev proposed openstack/app-catalog-ui: Add eslint checking machinery
kfox1111sure. :)22:06
kfox1111docaedo: kind of wondering if we should just use django for the root of the apps site so that we can share all the compress/xstatic stuff with horizon. might make things easier? we could still use flask for /api, and django would just be handing out the static files it generated?22:12
kzaitsev_mbok, since you've +A'ed it I can continue with infra commit22:13
kzaitsev_mbor we can 1st fix the issues, to make the job voting outright22:13
kzaitsev_mbI think I like the 2d idea — fix the issues, since there's only 1 file and like 30 something errors22:14
kfox1111all the issues I ran into were fixme's that were things I want to fix at some point, but aren't like a 10 minute thing. nothing broken exactly, just less then ideal.22:15
kfox1111so if we can ignore the fixme's I think we're really close.22:15
kzaitsev_mbthose would be warnings — should be ok now22:15
kzaitsev_mbeslint would print them, but would exit with 0 code if there are no erros22:16
*** openstackgerrit has quit IRC22:16
*** openstackgerrit has joined #openstack-app-catalog22:16
kfox1111yeah. at least on version of eslint I'm running, they are all warnings now.22:21
kfox1111I was using horizon's eslint config though.22:22
kzaitsev_mbI see some camelcase and for-in errors. should be rather trivial to change22:22
kfox1111I thought I fixed all of those...22:23
kfox1111are you running from the the eslint fix all errors review?22:23
kfox1111I'm waiting for someone with a working murano-dashboard/engine to verify it doesn't break anything.22:24
kfox1111it seemes to be happy on my box but I did touch an aweful lot of code, which could break something unexpectedly.22:24
kzaitsev_mbIt just struck me, that I didn't update my dahsboard after project rename22:25
kfox1111doh. :)22:25
kfox1111do you have murano-dashboard and the ui plugin installed still?22:27
kfox1111could you give that review a try?22:28
kzaitsev_mbyou mean 226578 — to check against murano dashboard?22:28
kzaitsev_mbsure. just only need to re-enable the plugin22:29
kzaitsev_mboh damn. I need to reconfigure my vpn first =(22:32
kzaitsev_mbsecurity guys enabled 2-factor auth recently )22:32
kzaitsev_mband I'm used to using remote cloud =)22:33
kfox1111ah. fun. yeah, I've got a securid around my neck...22:33
*** kebray has joined #openstack-app-catalog22:38
kzaitsev_mbhm. it's stuck in checking for murano packages. the status I mean22:46
kzaitsev_mband works on master just fine22:47
kfox1111do you have a fairly new murano-dashboard?22:48
kfox1111is this in the history:
kzaitsev_mbsure, it would say Unsupported, if there were no api22:52
kzaitsev_mbas far as I remember22:52
kfox1111I would think...22:54
kfox1111if you hit f12 and refresh, do you see an error code back from the murano packages call?22:55
kfox1111or not see that call at all?22:55
kzaitsev_mbI think I do not see the call at all. (checking browser logs)22:56
kfox1111On my box, I see the rest call/response, I can click install on the artifact, and it pops up the murano wizard with the correct package name.22:58
kfox1111are you getting that far?22:58
kfox1111if I try and load it, I get: Can't find Package name from repository.22:59
kfox1111though I'm running a pretty old murano at this point.23:00
kzaitsev_mbhuh =) that's strange =)23:00
kzaitsev_mbwith master everything works fine, when I rebase on linted commit I get23:01
kfox1111hmm.... If I remember correctly, murano had an updated enable file to make rest work. did you install that?23:01
kfox1111murano-dashboard I mean.23:01
kzaitsev_mbsure, Like I said — with master I'm able to download asset and install it normally23:02
kfox1111yeah... seems like the rest call. interesting.23:02
kzaitsev_mbwait, do you use master horizon?23:04
kfox1111they've done a huge amount of refactoring in liberty to get angular working more smoothly.23:04
kfox1111so has_murano will only be set if something's defining
kfox1111if has_murano's defined, then it calls getPackages on that module... which does the rest call..23:07
kfox1111I'm not sure why you would ever see the checking without seeing a murano package call.23:08
kzaitsev_mbI think I've found the error23:08
kfox1111cool. whatcha thinking?23:08
docaedoregarding app catalog SSL - I wiped everything and ran puppet apply, works great :) also verified a few other sites that only note port 443 also listen on 80 (because whats in the template matters the most)23:08
kfox1111odd. ok.23:09
kzaitsev_mb take a look23:09
kfox1111I wonder what that code does then.23:09
kfox1111kzaitsev_mb: around where? :)23:10
kzaitsev_mbangular.forEach(definitions, function(definition)23:10
kzaitsev_mb268 line =)23:10
kzaitsev_mbsry for not pointing23:10
kfox1111nm. I see your comment.23:10
kzaitsev_mbeslint doesn't catch all after all =(23:11
kfox1111it wanted me to pull d out, before I fixed the for in errors, then didn't complain when it was orphaned....23:14
kzaitsev_mbstrange. I thought the default configuration would complain about orphaned variables. or maybe I'm already used to openstack-eslint-conf23:15
kfox1111yeah. good catch. let me fix that error...23:16
openstackgerritKevin Fox proposed openstack/app-catalog-ui: Fix all lint errors
kfox1111have a look at that one.23:17
kfox1111ah... I think I didn't hit that because I don't have any packages defined at the moment.23:18
kfox1111we're going to have to write angular tests at some point too...23:19
kzaitsev_mbor maybe I'm thinging about shellcheck...23:20
kzaitsev_mbyep, seems to work now23:21
kfox1111awesome. thanks. :)23:23
docaedoI'm running devstack with murano and the patch from 226578 (and will share the script I have that gives you devstack with murano and app-catalog-ui in one sec)23:25
*** kebray has quit IRC23:25
kfox1111docaedo: cool. thanks.23:27
docaedoThis is pretty handy, gets you devstack, neutron, murano, app-catalog-ui in a single-nic VM -
kfox1111nice. :)23:27
docaedo(I should put that up on github somewhere really, since I have to tweak it now and then when something changes in devstack)23:27
kfox1111ok... ok... now, stick the contents of that pastebin into a heat template, and contribute it to the app catalog please. :)23:28
docaedohahaha, not a half bad idea :D23:28
kfox1111self hosting! :)23:28
docaedoah see, already noticed my paste has a mistake :(  Should have FLOATING_RANGE="$NET.0/24" near the bottom. Still works as-is but technically it's not correct23:31
kfox1111still testing?23:36
docaedooh I think you might have pushed an update after I kicked it off, let me see which ref I used23:38
docaedoyep, but this one should come up faster since most everything is cached. So running that again...23:40
kfox1111yay/nay? :)23:51
docaedojust tried it, works great!23:51
kfox1111awesome. thanks. :)23:51
docaedoOK for me to +2?23:51
kfox1111yes please.23:52
docaedoer, +2 and workflow I mean23:52
docaedoI'm on it, nice work23:52
kfox1111still a long way to go, but starting to clean up a bit.23:52
openstackgerritMerged openstack/app-catalog-ui: Fix all lint errors
kfox1111arg... how strange gerrit doesn't rebase automatically for trivial things...23:54
kfox1111oh well. here comes the rebase dance... :)23:54
kfox1111at least that is a button press in that case...23:55
openstackgerritKevin Fox proposed openstack/app-catalog-ui: Use protocol used for horizon to get assets
openstackgerritMerged openstack/app-catalog-ui: Use protocol used for horizon to get assets
openstackgerritKevin Fox proposed openstack/app-catalog-ui: Add missing images
openstackgerritMerged openstack/app-catalog-ui: Add missing images
kfox1111ok. that gets us most of the way caught up.23:58
kfox1111docaedo: how about:
docaedokfox1111: happen to be re-running devstack right this instant to validate that23:59

Generated by 2.14.0 by Marius Gedminas - find it at!