| kfox1111 | cool. thanks. :) | 00:00 |
|---|---|---|
| kfox1111 | hmm... its not rebased yet, so it doesn't have the murano package fix in it though. | 00:00 |
| docaedo | no prob, thanks for all the work on this | 00:00 |
| kfox1111 | let me rebase kzaitsev_mb's linter in, then I'll rebase the versioning thing on top, so we only have that one outstanding patch. | 00:02 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog-ui: Add eslint checking machinery https://review.openstack.org/227026 | 00:02 |
| kfox1111 | maybe I"ll just rebase the other... the linter's not quite working. | 00:04 |
| kzaitsev_mb | huh? | 00:05 |
| kfox1111 | http://pastebin.com/2P5y8Fup | 00:06 |
| kzaitsev_mb | oh, you're trying to set up a nice chain of commits I guess with inimum conflicts? | 00:06 |
| kfox1111 | probably need some more requirements... | 00:06 |
| kfox1111 | yeah, to minimize rebasing. | 00:06 |
| kfox1111 | but now we are down to two outstanding reviews. almost there. | 00:06 |
| kzaitsev_mb | wow | 00:06 |
| kfox1111 | alot was backlogged on that linting thing. | 00:07 |
| kfox1111 | and I'm REALLY glad I waited. :) | 00:07 |
| kfox1111 | I figured I couldn't change that many lines of code and not break something. :) | 00:07 |
| kzaitsev_mb | looks strange. tox behaves just fine for me. | 00:07 |
| kfox1111 | I'm guessing its because I have pbr 0.10.0 on my system. | 00:07 |
| kzaitsev_mb | maybe we have different versions of tox and there should now be some default params | 00:08 |
| kzaitsev_mb | overridden | 00:08 |
| kzaitsev_mb | well. yep, obviously it complains about pbr =) | 00:08 |
| kzaitsev_mb | I've lookd like 3 or 4 times into pbr and still do not quite get what it does... | 00:09 |
| kfox1111 | maybe a pbr>=1.3 in test-requirements? | 00:09 |
| kfox1111 | we probably should have a requirements.txt as well, and maybe include both in testenv:eslint deps? | 00:09 |
| kfox1111 | and then have pbr in just requirements.txt? | 00:10 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog-ui: Handle an asset service schema version https://review.openstack.org/226920 | 00:10 |
| kfox1111 | docaedo: ok, try that one. should be rebased on top of the murano fix. | 00:11 |
| docaedo | kfox1111: on it momentarily (patch 2 right?) | 00:12 |
| kfox1111 | yeah. thanks. | 00:12 |
| docaedo | np - running now | 00:12 |
| kfox1111 | to really test it, you need to run a local app-catalog, and tweak the asset file to flag an asset as service.version = 2 | 00:14 |
| kfox1111 | gota head out in a few. | 00:18 |
| kfox1111 | odd... pbr>=1.3 is already installed in the horizon venv, so it shouldn't be complaining about it. | 00:19 |
| kfox1111 | does look like its an older version of tox maybe. | 00:20 |
| kfox1111 | I pip installed tox in the venv and it started working I think. | 00:20 |
| kfox1111 | yeah... its pulling node now. | 00:21 |
| kfox1111 | docaedo: one thing I'm not sure about is if we should use semver for the version number of the asset schema, or not... | 00:22 |
| docaedo | I am not sure either, have been thinking a lot about versions and stuff | 00:23 |
| docaedo | and have been working on a response to Serg/Murano regarding versions as well | 00:24 |
| kfox1111 | kzaitsev_mb: as a follow on patch to the linter, perhaps we should copy a bit more of horizon's run_tests to ensure tox is new enough to run? I don't think we can update tox from within tox. :/ | 00:24 |
| kfox1111 | there's several things to version, and this is just one of them. its one of the easiest. | 00:24 |
| kfox1111 | its kind of a versioning of the features the horizon website supports. | 00:24 |
| kfox1111 | as aposed to either the version of the service engine, or the version of the asset. :/ | 00:25 |
| kfox1111 | I think we can fairly easily solve the first, ala the patch. the second I hope we can finish in the next week perhaps or solve good enough, and the last will take a while... | 00:26 |
| kfox1111 | kzaitsev_mb: I'm getting a failure on "npm install" | 00:27 |
| kfox1111 | is there an eslint missing? | 00:27 |
| docaedo | I think versions around what horizon supports should just be part of the release shouldn't it? i.e. app-catalog-ui targets horizon-liberty | 00:27 |
| kzaitsev_mb | what does it say? | 00:27 |
| kzaitsev_mb | I'm getting warnings about versions | 00:28 |
| kfox1111 | ERROR: InvocationError: '/home/kfox2/svn/app-catalog-ui/.tox/eslint/bin/npm install' | 00:28 |
| kzaitsev_mb | but still it installs correctly for me | 00:28 |
| kfox1111 | docaedo: Kind of... lets go through an example.... | 00:28 |
| kfox1111 | say we add a feature to the app catalog. the ability for heat resources to have an included environment file. | 00:28 |
| kzaitsev_mb | kfox1111: does the same thing happen if you try it in app-catalog or horizon? | 00:29 |
| kfox1111 | the current horizon plugin has no idea that property exists, so will happily ignore it. | 00:29 |
| kfox1111 | if the heat resource depends on that environment being there, the app catalog entry is broken on that version of the horizon plugin. | 00:29 |
| kfox1111 | so if you go into the asset, and flag it's kind of a schema version 2 thing, the horizon pluin can say, I only support version 1 schema asssets, and exlude just that one asset, leaving all the rest to continue to work. | 00:30 |
| kfox1111 | it can still even present the asset to the user, though disabled, so they know to contact their friendly local cloud admin to nudge them to upgrade their app-catalog plugin. :) | 00:31 |
| docaedo | kfox1111: I follow mostly, but suspect it's going to get complicated quick | 00:31 |
| kfox1111 | it just means, if we keep adding required features to heat, murano, or glance, we have to keep bumping the version. I'm hoping that wont happen very often. | 00:32 |
| kfox1111 | its been pretty stable for a while. | 00:32 |
| docaedo | true | 00:32 |
| kfox1111 | though the heat env things the thing that kind of proved we may want to in the future. | 00:32 |
| kfox1111 | I think the asset versioning thing's going to be harder. | 00:33 |
| kfox1111 | the service-engine versioning things kind of iffy too... | 00:33 |
| docaedo | one thing I want to be really careful about with the catalog is keeping it from being closely tied to other projects - like Murano, the murano devs should not have to worry too much about app-catalog other than including a way to specify a particular version of an asset | 00:33 |
| kfox1111 | say you are running a heat from kilo, and a horizon from liberty. | 00:33 |
| kfox1111 | the app catalog ui plugin needs to know that. and thats not currently introspectable. | 00:33 |
| docaedo | to me that's an edge case that shouldn't require a ton of support or effort | 00:34 |
| kfox1111 | Best I can think of right now is to assume service engine versions match horizon's release, and allow the user to override in horizon's config. | 00:34 |
| kzaitsev_mb | is that even a thing? Wouldn't everything explode? =) I mean kilo/liberty interaction? =) | 00:34 |
| docaedo | eventually that will be sort of supported for the upgrade all services use-case, but even today, it's not really supported by anyone | 00:34 |
| kfox1111 | agreed on how closely we tie. | 00:34 |
| kfox1111 | kzaitsev_mb: No, I run hybrid clouds all the time. openstack's great at it. | 00:35 |
| docaedo | I think it's best to plan that service engine version matches horizons release, and just assume the whole environment is Kilo, or Liberty, etc | 00:35 |
| kfox1111 | horizon's usually the first thing I upgrade, since it gets a lot of new, visiable features, with very minimal change. | 00:35 |
| docaedo | OK hybrid cloud is one thing... yeah and I can see how you could end up with competing versions of things but still want to address them from the catalog | 00:35 |
| kfox1111 | yeah. I think the assets need something like a minimum supported service engine version, | 00:36 |
| kfox1111 | and then the ui filters out any that are newer then itself, or the user specified service-engine version. | 00:36 |
| kfox1111 | the thing I'm a little iffy on there is versions... | 00:37 |
| kfox1111 | I'm thinking it probably should be 'kilo', 'liberty', etc. | 00:37 |
| docaedo | that makes sense to me | 00:37 |
| kfox1111 | if it is, then we have to hardcode them so we know what they are. thats probably ok. but what happens when we add service resource types that are not in the regular release cycle? | 00:38 |
| kfox1111 | like... use number releases? | 00:38 |
| kfox1111 | I guess maybe we deal with that when we add support for those to the horizon plugin when we hit one. | 00:38 |
| kfox1111 | say, solum language packs. I don't know if they support cycle names or version numbers, but if its the latter, when we add horizon support, we need to figure out how to do version numbers if they use it. | 00:39 |
| kfox1111 | though version numbers may be easier to handle then release names anyway... | 00:39 |
| kfox1111 | like I said, I think that one's probably roughly solvable in the next week, so we can ensure mitaka+ resources never try and get loaded into a app-catalog-ui 1.0 loaded into a liberty cloud. | 00:40 |
| kfox1111 | the rest of the details we can deal with later. | 00:40 |
| docaedo | yep, that one is relatively easy | 00:40 |
| kfox1111 | that just leaves the multiple asset version thing for mitaka. | 00:40 |
| kfox1111 | and that one's going to be interesting. :) | 00:40 |
| kfox1111 | well, I gota head out. | 00:41 |
| kfox1111 | thanks for the reviews/discussion. | 00:41 |
| docaedo | well I'm going to probably argue for keeping it simple - but we can chat tomorrow | 00:41 |
| kfox1111 | simple's good. :) | 00:41 |
| kfox1111 | as simple as possible, but no simpler. ;) | 00:41 |
| docaedo | hah yes exactly - out get gone man, have a good night! | 00:41 |
| kfox1111 | you too dude. later. | 00:42 |
| *** kfox1111 is now known as kfox1111_away | 00:42 | |
| *** kzaitsev_mb has quit IRC | 00:43 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 01:09 | |
| *** kzaitsev_mb has quit IRC | 01:14 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 01:40 | |
| *** kzaitsev_mb has quit IRC | 02:16 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 03:37 | |
| *** kzaitsev_mb has quit IRC | 04:05 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 07:46 | |
| *** kzaitsev_mb has quit IRC | 07:51 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 09:15 | |
| *** kzaitsev_mb has quit IRC | 09:48 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 11:09 | |
| *** kzaitsev_mb has quit IRC | 12:15 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 12:25 | |
| *** jolsen has joined #openstack-app-catalog | 12:56 | |
| *** jolsen has quit IRC | 12:56 | |
| *** jolsen has joined #openstack-app-catalog | 12:56 | |
| *** kzaitsev_mb has quit IRC | 13:09 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 13:11 | |
| *** j_king has quit IRC | 14:12 | |
| *** kebray has joined #openstack-app-catalog | 14:43 | |
| *** kebray has quit IRC | 14:43 | |
| *** kebray has joined #openstack-app-catalog | 14:47 | |
| *** kfox1111_away is now known as kfox1111 | 15:26 | |
| kfox1111 | docaedo: I'm kind of thinking we should try and use django for just the root of apps.openstack.org. We don't write any code in python, but use django-compressor and django-pyscss for free to generate optimized javascript/scss with very little effort. can also then share that bit of code with horizon. | 16:08 |
| kfox1111 | we'd still do flask for /api | 16:08 |
| kfox1111 | whatcha think? | 16:08 |
| kzaitsev_mb | don't like the idea of having 2 webservers, but using flask might be indeed a bit hard if we try to limit ourselves with global requirements. | 16:11 |
| kfox1111 | not two webservers. two wsgi apps. | 16:11 |
| kzaitsev_mb | yep, that's what I meant | 16:11 |
| docaedo | I think that's bringing along way too much just to serve static stuff with optimization. I'm all for optimizing things but even if we were actually seeing a ton of traffic, I don't think it would be worth it | 16:11 |
| kfox1111 | I'm thnking more from the developer optimazation time thing. | 16:12 |
| kfox1111 | I think I can get xstatic workign with it quicker then manually figuring out how to get it to work... | 16:12 |
| docaedo | is this for the sake of sharing static/common elements between UI/horizon and the web site? | 16:14 |
| kfox1111 | partially, yeah. | 16:14 |
| kfox1111 | and for things like the angular js source, etc. | 16:15 |
| kfox1111 | I don't want to link to external angular.js, | 16:15 |
| kfox1111 | nor do I want to include a raw angular.js in the repo itself. | 16:15 |
| kfox1111 | the best option is to pull it from xstatic like horizon's doing. | 16:15 |
| kfox1111 | we add an XStatic-Angular>=1.3.7 in requirements.txt, and it gets pulled in. | 16:16 |
| kfox1111 | will run into that as we add more useful angular stuff. | 16:16 |
| kfox1111 | like mangic search. | 16:16 |
| kfox1111 | XStatic-Magic-Search>=0.2.5.1 # Apache 2.0 License | 16:17 |
| kfox1111 | see horizon's requirements.txt. they have a bunchof XStatic stuff that was useful to them, that I think we may want too. | 16:17 |
| kfox1111 | oh. smart table too. | 16:17 |
| kfox1111 | I'm sure we could probably use xstatic without django. Just thinking it may be easier though. I'd have to prototype to know for sure. | 16:18 |
| docaedo | I follow the logic | 16:19 |
| docaedo | gotta run for a few minutes to be sure I am back in time for the meeting | 16:19 |
| kfox1111 | but if we can do it with like 10 lines of django, and we get it all + compression, then that sounds like a quick solution to the issue. | 16:24 |
| kfox1111 | k. | 16:25 |
| *** docaedo has quit IRC | 16:28 | |
| *** docaedo has joined #openstack-app-catalog | 16:34 | |
| docaedo | whoah, meeting time already! | 17:00 |
| kfox1111 | I'll try tox -e eslint on horizon and see what happens. | 17:32 |
| kfox1111 | of cource, its redownloading/rebuilding node. :/ | 17:34 |
| *** kebray has quit IRC | 17:34 | |
| kzaitsev_mb | npmenv, yep | 17:34 |
| kfox1111 | I'm not sure why it does that so often... | 17:35 |
| kfox1111 | docaedo: I think if you make a heat template that nests this: https://github.com/EMSL-MSC/heat-templates/blob/master/cfn/lib/SimpleServer.yaml | 17:38 |
| kfox1111 | you only have to specify ExtraUserData of curl your shell script and run it? :) | 17:38 |
| kfox1111 | or git checkout and run it. | 17:38 |
| kfox1111 | kzaitsev_mb: the tox thing works in horizon. | 17:39 |
| kfox1111 | something's different. | 17:39 |
| kzaitsev_mb | strange indeed | 17:39 |
| docaedo | kfox1111: thanks, I'll give that a try. except need to 'fix' that template so it doesn't use centos :) | 17:39 |
| kfox1111 | kzaitsev_mb: I'm literally sharing python virutalenv, so I'm not sure just how much is different. | 17:40 |
| kfox1111 | docaedo: its just a default. | 17:40 |
| docaedo | kfox1111: haha yep, I just have consistently not great experiences going down that road ;) | 17:41 |
| kzaitsev_mb | well infra job would not use tox, but I guess it's worth to do some debugging. | 17:41 |
| kzaitsev_mb | can you pls share the error once more? | 17:41 |
| kfox1111 | k. | 17:41 |
| kfox1111 | kzaitsev_mb: http://pastebin.com/gHK7MdTw I included the horizon one at the bottom too for comparison. | 17:43 |
| kzaitsev_mb | MakeReferenceError — I had that | 17:46 |
| kfox1111 | wait... its trying to make a .tox venv? | 17:47 |
| kzaitsev_mb | but I thought it was due to XCode update, so I reinstalled the npm, removed tox and after that all went fine.. | 17:47 |
| kzaitsev_mb | kfox1111: yep, it creates .tox/eslint | 17:48 |
| kzaitsev_mb | I believe infra job doesn't do that | 17:48 |
| kzaitsev_mb | it just runs npm lint, which is defined in the package.json | 17:49 |
| kfox1111 | I'm guessing its a dep that's too old on my system. | 17:49 |
| kzaitsev_mb | so tox here is more of a convenience thing | 17:49 |
| kzaitsev_mb | that might be the case, indeed. | 17:49 |
| kfox1111 | so theres probably a missing test-requirements.txt entry? | 17:50 |
| kzaitsev_mb | I'd recommend removing .tox/ before trying that too | 17:50 |
| kzaitsev_mb | missing requirement? | 17:50 |
| kzaitsev_mb | you mean tox itself? | 17:50 |
| kfox1111 | no, something that its pulling from system rather then trying to install a newer version of. | 17:51 |
| kfox1111 | k. rebuilding node again.... :/ | 17:51 |
| kzaitsev_mb | hm, not sure. thought 'nodeenv' should be enough | 17:51 |
| kfox1111 | like tox. my tox is 1.4.2 unless I install a new one in a venv. | 17:51 |
| kfox1111 | and 1.4.2 is too old to run the tox -e eslint. | 17:52 |
| kzaitsev_mb | horizon does not have tox in test-requirements, I guess | 17:52 |
| kfox1111 | thats why I've been using horzion's with_venv.sh script. | 17:52 |
| kfox1111 | to just reuse their venv which has a newer tox in it. | 17:52 |
| kfox1111 | the problem with tox in particular, | 17:52 |
| kfox1111 | you cant have tox pull a newer verson of tox. :/ | 17:52 |
| kzaitsev_mb | tox is not in global-requirements | 17:53 |
| kfox1111 | so for horizon, I have to tools/with_venv.py pip install tox | 17:53 |
| kfox1111 | tools/with-venv.py tox -e eslint | 17:53 |
| kzaitsev_mb | so it's up to the system to provide tox I guess | 17:53 |
| kfox1111 | then it has a newenough tox to do the rest. | 17:53 |
| kfox1111 | thats working with horizon. | 17:54 |
| kfox1111 | it also runs tox stuff ok in app-catalog I think. | 17:54 |
| kfox1111 | its some other requirement I think thats too old. | 17:54 |
| *** kebray has joined #openstack-app-catalog | 17:56 | |
| kfox1111 | ok. django hello world with one page was pretty easy. | 17:57 |
| kfox1111 | just gota try it with xstatic now to see how that works. | 17:57 |
| kfox1111 | kzaitsev_mb: removing .tox fixed it. | 17:57 |
| kfox1111 | 0 errors, 29 warnings. | 17:58 |
| kfox1111 | we testing a different set then horizon? Its a different set of errors. | 17:58 |
| kfox1111 | oh. nm.... | 17:58 |
| kfox1111 | I'm in the wrong directory.... | 17:58 |
| kfox1111 | doing too much at once... | 17:58 |
| kfox1111 | app-catalog != ap-catalog-ui | 17:59 |
| kfox1111 | I'll pull .tox from there and try again. | 17:59 |
| *** kzaitsev_mb has quit IRC | 18:01 | |
| kfox1111 | and building node again.... | 18:01 |
| *** jolsen has quit IRC | 18:43 | |
| *** jmolsen has joined #openstack-app-catalog | 18:48 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 19:08 | |
| *** kebray has quit IRC | 19:12 | |
| *** kebray has joined #openstack-app-catalog | 19:29 | |
| *** kebray has quit IRC | 19:31 | |
| *** kebray has joined #openstack-app-catalog | 19:32 | |
| *** kebray has quit IRC | 19:35 | |
| kfox1111 | kzaitsev_mb: k. the tox ran again, same error. | 19:40 |
| kfox1111 | so its something to do with the app-catalog-ui repo, and not app-catalog or horizon | 19:40 |
| *** kebray has joined #openstack-app-catalog | 19:57 | |
| *** kzaitsev_mb has quit IRC | 21:08 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 21:13 | |
| *** kebray has quit IRC | 21:41 | |
| *** kebray has joined #openstack-app-catalog | 22:17 | |
| *** kebray has quit IRC | 22:17 | |
| *** kebray has joined #openstack-app-catalog | 22:24 | |
| *** kzaitsev_mb has quit IRC | 22:50 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 22:58 | |
| *** kzaitsev_mb has quit IRC | 23:47 | |
| kfox1111 | nice... got staticfiles and compressor working. :) | 23:51 |
| kfox1111 | and xstatic. | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!