kfox1111 | back finally. :/ | 01:20 |
---|---|---|
kfox1111 | I'll have to review it tomorrow. :/ | 01:20 |
kfox1111 | plz help me remember to do so. | 01:20 |
docaedo | np, I'll remind you every hour on the hour | 02:35 |
docaedo | won't take you but a moment, due to the awesomeness (as a result of most of it being written by you of course!) | 02:36 |
*** vecdid has joined #openstack-app-catalog | 05:27 | |
*** vecdid has left #openstack-app-catalog | 05:27 | |
*** lifeless has joined #openstack-app-catalog | 05:32 | |
lifeless | hihi | 05:32 |
lifeless | docaedo: I promised to do a review of your app catalog review guidelines with an eye on the concerns I raised at the summit | 05:34 |
lifeless | docaedo: I've puled the code and read the wiki page https://wiki.openstack.org/wiki/App-Catalog but I can't see any actual catalog review guidelines | 05:35 |
lifeless | docaedo: I've got some naive questions as a result; would like to grab some interactive time to bootstrap to usefulness - tomorrows my weekend, but are you around early next week ? | 05:36 |
docaedo | lifeless: I'm around early next week and would be happy to set up some time, you're in NZ right? | 15:26 |
docaedo | lifeless: (and if so, hopefully fast asleep right now!) | 15:26 |
*** rhagarty_ has quit IRC | 15:40 | |
*** rhagarty_ has joined #openstack-app-catalog | 15:40 | |
*** DarthVigil has joined #openstack-app-catalog | 16:08 | |
*** kebray has joined #openstack-app-catalog | 16:14 | |
*** kebray has quit IRC | 16:31 | |
*** kebray has joined #openstack-app-catalog | 16:34 | |
lifeless | docaedo: yes and yes | 17:05 |
docaedo | lifeless: well please enjoy your weekend :) I LOVE NZ. We spent our honeymoon on the south island and speak of returning all the time | 17:26 |
docaedo | kfox1111: ping reminder for reviewing the reviews :) | 17:28 |
kfox1111 | thx... almost at a point I can stop and do it. | 17:31 |
kfox1111 | every couple of years they make us take "Ladder Safety Training" again... | 17:31 |
docaedo | :) that sounds fun | 17:33 |
kfox1111 | yeah. thats one way of putting it. :) | 17:33 |
docaedo | Maybe I'll climb a ladder and walk around on the roof today in the spirit of support! | 17:37 |
* kfox1111 chuckles | 17:37 | |
docaedo | (odds are good I will not do this safely, so it will only be partial support) | 17:37 |
kfox1111 | don't come crying to me when your not properly trained. ;) | 17:38 |
kfox1111 | damn.... this is the first year the traning didn't work without flash+audio. :/ | 17:41 |
*** DarthVigil has quit IRC | 18:22 | |
kfox1111 | docaedo: pythonserver looks ready to me. | 19:45 |
docaedo | woot!! | 19:45 |
kfox1111 | go ahead and workflow it when your ready. | 19:46 |
kfox1111 | I think the infra patch just needs the static apache alias. | 19:47 |
docaedo | static alias to change where static stuff is built/kept? Or something else? As far as I can tell it works as-is right now. | 19:49 |
openstackgerrit | Merged openstack/app-catalog: Python Server https://review.openstack.org/227856 | 19:49 |
kfox1111 | it does work as is, but for static files, the call goes in through apache, through wsgi, to python, then to the file system. | 19:50 |
kfox1111 | since its always static, if we setup an alias, it would go through apache, then right to the filesystem. | 19:50 |
kfox1111 | would cut out a lot of processor time. | 19:50 |
docaedo | ah - right yes, please add a comment thusly and I'll make it so | 19:50 |
kfox1111 | I commented on the last review. | 19:51 |
kfox1111 | though not to that level of detail. | 19:51 |
kfox1111 | still want me to? | 19:51 |
docaedo | oh right you did! | 19:52 |
docaedo | no need, I'll add it | 19:53 |
kfox1111 | k. thx. | 19:53 |
docaedo | DONE! https://review.openstack.org/#/c/245315/ | 20:03 |
kfox1111 | +1 | 20:05 |
docaedo | Looks like python stuff we merged landed on production server without breaking it - http://puppetboard.openstack.org/report/apps.openstack.org/5b66846b7241841079819f806dbeb7b03769280d | 20:14 |
kfox1111 | cool. :) | 20:17 |
*** openstack has joined #openstack-app-catalog | 21:06 | |
docaedo | a few tiny tweaks and one regression, but it's about to merge! | 21:41 |
kfox1111 | nice. :) | 21:56 |
docaedo | That manifest should hit at 2:03 if I'm not mistaken (though I'm not sure what the refresh cycle is on puppet master so maybe it's longer than that?) WIll be watching puppetboard though and keeping my fingers crossed we didn't miss anything | 21:59 |
kfox1111 | kk. :) | 22:00 |
kfox1111 | is it switched over? | 23:11 |
docaedo | It switched over and was a lovely 404 for a bit :( | 23:12 |
docaedo | the pip install was not triggered because the repo hadn't changed. jeblair jumped on and manually ran it, but that triggered a discussion | 23:12 |
docaedo | realized that running things that change files in the repo directory has potential to break later (you might have already pointed that out), so | 23:13 |
docaedo | threw this together to address it, which seemed to have worked: https://review.openstack.org/#/c/248276/ | 23:13 |
docaedo | (well, didn't break anything locally, and survived the scrutiny of an infra core at least!) | 23:14 |
kfox1111 | ah... yeah. I forgot about that case. | 23:20 |
docaedo | and now I realize | 23:21 |
docaedo | because I changed where /static/ loads from | 23:21 |
docaedo | the assets.yaml file will still be there | 23:21 |
docaedo | ah but never mind | 23:21 |
docaedo | because that is now served from python wsgi | 23:22 |
docaedo | so we're good! | 23:22 |
docaedo | (maybe?) | 23:22 |
kfox1111 | we're good there. | 23:25 |
kfox1111 | everyone should be reading it through /api. | 23:26 |
kfox1111 | if anyone's using it from /static still, their "not doing it right" | 23:26 |
kfox1111 | thats why we have an /api :) | 23:29 |
kfox1111 | ok. I think the new keystone cluster's pretty much done. :) | 23:32 |
kfox1111 | I was able to recover it out of a full power outage simulation. | 23:32 |
docaedo | awesome! | 23:34 |
kfox1111 | next up, new production region. :) | 23:36 |
docaedo | have fun! | 23:41 |
kfox1111 | so, in theory we should be able to remove the static index.html now? | 23:41 |
docaedo | yep | 23:42 |
docaedo | I have not looked closely at the other python patches you have out there, are they still valid and worth a closer look? | 23:42 |
kfox1111 | there's one that I need to rebase that just pulls out the javascript yaml lib, causing it to access /api directly. | 23:43 |
docaedo | oh nice, I'll look at that and test locally too | 23:43 |
kfox1111 | the other one, is the big, start merging in app-catalog-ui stuff. | 23:43 |
kfox1111 | it probably just needs a rebase. | 23:43 |
docaedo | (but probably not until tomorrow or next week) | 23:43 |
kfox1111 | k. | 23:43 |
kfox1111 | the big one's probably mergable in its current state too. it pulls the stuff into /testicons.html so its isolated. | 23:44 |
docaedo | actually maybe soon, going to relocate to the library with the kids, and they have good wifi - so maybe will poke, test, review | 23:44 |
kfox1111 | k. :) | 23:44 |
kfox1111 | the site's for sure running the templated index.html | 23:45 |
kfox1111 | I can see the <script type="text/javascript" src="/static/CACHE/js/68027a219247.js"></script> line in it. | 23:45 |
kfox1111 | so yeah, the other index can go now. | 23:46 |
docaedo | woot! | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!