Wednesday, 2014-08-06

« Tuesday, 2014-08-05 Index Thursday, 2014-08-07 »
rm_workwoodster: ah, it might be this: https://bugs.launchpad.net/barbican/+bug/132648100:01
rm_workpretty sure it's that00:01
rm_workyep00:02
rm_workcool00:02
rm_workno longer my problem ;P00:02
woodsterha, thanks00:02
rm_workand this is why you search before you put in new bugs :P00:02
rm_work(ideally this is why you search before you go bug other devs, but that's a trial for another day)00:03
rm_workAccept header with application/json is like, my default for everything00:03
*** rm_mobile has quit IRC00:14
*** bdpayne has quit IRC00:17
*** ayoung has joined #openstack-barbican00:22
*** SheenaG1 has joined #openstack-barbican00:36
openstackgerritA change was merged to openstack/barbican: Eager load KEKDatum record when EncryptedDatum is retrieved  https://review.openstack.org/11160100:44
*** gyee has quit IRC01:12
*** lisaclark1 has joined #openstack-barbican01:20
*** SheenaG1 has quit IRC01:21
*** alee_ has joined #openstack-barbican01:36
*** alee_ has quit IRC01:42
*** alee_ has joined #openstack-barbican01:54
*** woodster has quit IRC02:25
*** bdpayne has joined #openstack-barbican02:32
*** bdpayne has quit IRC02:35
*** crc32 has quit IRC02:41
*** bubbva has quit IRC02:41
*** bubbva has joined #openstack-barbican02:41
*** bdpayne has joined #openstack-barbican02:49
*** bdpayne has quit IRC02:51
*** lisaclark1 has quit IRC03:11
*** ayoung has quit IRC03:34
*** alee has quit IRC04:03
*** alee has joined #openstack-barbican04:15
*** jaosorior has joined #openstack-barbican04:53
*** juantwo has quit IRC05:04
*** alee has quit IRC07:23
*** dstufft has quit IRC09:08
*** dstufft has joined #openstack-barbican09:09
*** jamielennox has quit IRC10:34
*** jamielennox has joined #openstack-barbican10:35
*** jamielennox is now known as jamielennox|away10:57
*** juantwo has joined #openstack-barbican12:22
*** alee has joined #openstack-barbican12:26
*** juantwo has quit IRC12:28
*** juantwo has joined #openstack-barbican12:28
*** rellerreller has joined #openstack-barbican12:32
*** SheenaG1 has joined #openstack-barbican13:13
*** SheenaG11 has joined #openstack-barbican13:16
*** SheenaG1 has quit IRC13:18
*** ayoung has joined #openstack-barbican13:31
*** akoneru_ has joined #openstack-barbican13:39
*** lisaclark1 has joined #openstack-barbican13:40
*** lisaclark2 has joined #openstack-barbican13:40
*** lisaclark1 has quit IRC13:40
*** lisaclark1 has joined #openstack-barbican13:52
*** lisaclark2 has quit IRC13:53
rellerrellerOK, dumb question time, how does a CR git a checkmark in workflow and get merged?13:55
rellerrellerI noticed CR 107111 has two checkmarks and CR 107112 has three checkmarks. Would that mean they are approved and merged? I thought that would happen automatically.13:56
*** lisaclark1 has quit IRC14:03
rm_workIn gerrit it's up to the project to define how many checks things need14:05
rm_workI don't know exactly how barbican has it set up, but I think they require a lot of +2s :P14:05
*** paul_glass has joined #openstack-barbican14:05
*** lisaclark1 has joined #openstack-barbican14:06
rm_workoh, but all of those are in the Code Review section14:06
rm_workyeah, so there's two buttons -- Review, and Workflow14:06
rm_workit could have 20 "Review" +2s (checkmarks) but until someone hits the Workflow button and gives it a +2 there, it won't merge14:06
rm_workrellerreller: ^^14:07
rellerrellerInteresting14:08
*** SheenaG11 has quit IRC14:15
*** lisaclark1 has quit IRC14:15
*** lisaclark1 has joined #openstack-barbican14:15
*** lisaclark1 has quit IRC14:24
*** lisaclark1 has joined #openstack-barbican14:30
*** lisaclark1 has quit IRC14:30
*** lisaclark1 has joined #openstack-barbican14:31
*** lisaclark1 has quit IRC14:37
*** lisaclark1 has joined #openstack-barbican14:38
*** SheenaG1 has joined #openstack-barbican14:39
*** lisaclark2 has joined #openstack-barbican14:41
*** lisaclark1 has quit IRC14:42
*** SheenaG11 has joined #openstack-barbican14:43
*** SheenaG1 has quit IRC14:44
*** mdorman has joined #openstack-barbican14:45
*** lisaclark2 has quit IRC14:47
*** lisaclark1 has joined #openstack-barbican14:47
*** lisaclark1 has quit IRC14:48
*** Kevin_Bishop has joined #openstack-barbican14:56
openstackgerritJuan Antonio Osorio Robles proposed a change to openstack/python-barbicanclient: Introduce cliff for cli framework  https://review.openstack.org/10758714:59
*** SheenaG11 has quit IRC15:00
jvrbanacrm_work, looking at your CR right now15:09
jvrbanacrm_work, was this rebased after the tenant id was removed from the uri?15:10
openstackgerritJuan Antonio Osorio Robles proposed a change to openstack/python-barbicanclient: Introduce cliff for cli framework  https://review.openstack.org/10758715:12
*** rellerreller has quit IRC15:15
rm_workjvrbanac: no15:15
rm_workjvrbanac: that hasn't merged yet15:15
rm_workright!?15:16
rm_workRIGHT!?15:16
rm_workmy morning started out quite decently so far, please don't ruin it for me >_<15:16
jvrbanacrm_work, lol ahh my bad. I thought it has merged the other day.15:17
rm_workheh15:17
rm_worknp, be back in a bit15:17
*** woodster_ has joined #openstack-barbican15:19
jaosoriorwoodster_, chellygel: regarding the CR 10719015:26
jaosoriorThe comment in certificate_manager is not very relevant to me, so I could do without it. But I would really like to skip to be used instead of skipTest15:27
*** rellerreller has joined #openstack-barbican15:29
*** SheenaG1 has joined #openstack-barbican15:29
chellygeljaosorior, i wouldn't mind changing it, but it would be out of format with the dogtag tests as well15:35
woodster_jaosorior: Is the isinstance dict check a good option for you?15:35
chellygelis that something we should do in this CR?15:35
openstackgerritA change was merged to openstack/barbican-specs: Spec for removing tenant-id from api resource uri  https://review.openstack.org/10038615:37
jaosoriorchellygel: well, fixing the dogtag stuff in this CR wouldn't make sense. I would prefer to see the skip instead of the skipTest in this CR, and another CR (by whomever) could fix the rest of the tests15:37
jaosoriorI could submit it when I get home in some hours15:38
jaosoriorwoodster_: I asked because if that function is only being called in one place, and we know for sure that it will get a dict. Then why check it?15:39
woodster_jaosorior: it was more uncertainty on what sqlalchemy does when the meta key/values are pulled on a new order record. If guaranteed to be non None, then that check can be removed. I'm leery of differences I see between db flavors...15:41
jaosoriorThen maybe checking for a dict actually makes sense15:48
*** lecalcot has joined #openstack-barbican15:53
*** gyee has joined #openstack-barbican15:54
woodster_jaosorior: Would the suggested change be ok with you then?15:54
*** gyee has quit IRC15:54
jaosoriorI guess the change you suggested should be alright15:57
*** paul_glass has quit IRC16:00
*** gyee has joined #openstack-barbican16:01
*** Kevin_Bishop has quit IRC16:04
jaosoriorchellygel: so, are you OK with adding the skip instead of the skipTests to your CR?16:05
chellygelyep. will do!16:08
*** atiwari has joined #openstack-barbican16:09
chellygelatiwari, woodster_ was wanting to know what you were planning on doing with the work in progress CR you have.16:10
chellygelfor orders16:11
atiwarichellygel, woodster_ I have splinted the work in two16:11
atiwarias per woodster_ comment16:11
atiwariwoodster_, can we review https://review.openstack.org/#/c/111412/ first16:12
atiwariwoodster_, are you around?16:12
chellygelhe *just* stepped away and will be back shortly16:13
atiwariok16:17
atiwarichellygel, can we re-trigger the jenkins build for https://review.openstack.org/#/c/111412/?16:23
*** Kevin_Bishop has joined #openstack-barbican16:27
chellygelatiwari, go ahead, why ask me? o__o16:27
openstackgerritChelsea Winfree proposed a change to openstack/barbican: Add Certificate Interface & Symantec Plugin  https://review.openstack.org/10719016:34
atiwarichellygel, I think I don't have privilege to re-trigger. I will check with woodster_16:36
*** paul_glass has joined #openstack-barbican16:38
*** paul_glass has quit IRC16:38
*** bdpayne has joined #openstack-barbican16:39
*** Kevin_Bishop has quit IRC16:44
*** SheenaG1 has quit IRC16:53
*** rm_mobile has joined #openstack-barbican16:53
*** akoneru_ is now known as akoneru_lunch16:57
*** lecalcot has quit IRC17:11
jaosorioratiwari: anyone can retrigger17:12
*** rm_mobile has quit IRC17:13
woodster_Atiwari: away from office but will check in the next 1/2 hour or so17:14
*** SheenaG1 has joined #openstack-barbican17:15
atiwarijaosorior, how?17:16
*** paul_glass has joined #openstack-barbican17:17
*** paul_glass has quit IRC17:17
jaosorioratiwari: https://wiki.openstack.org/wiki/GerritJenkinsGit17:18
*** paul_glass has joined #openstack-barbican17:18
atiwarijaosorior, thanks17:19
*** paul_glass1 has joined #openstack-barbican17:21
*** paul_glass has quit IRC17:21
*** SheenaG1 has quit IRC17:31
*** paul_glass1 has quit IRC17:32
*** akoneru_lunch is now known as akoneru17:34
*** Kevin_Bishop has joined #openstack-barbican17:39
jaosoriorjvrbanac: thanks for reviewing my CR. Regarding your comment. Even though I agree with your comment regarding renaming URI, I think it should be part of another CR and we should discuss it in some meeting17:47
*** Kevin_Bishop has quit IRC17:56
woodster_arvind: CR https://review.openstack.org/#/c/87405 is blocking other work from happening on the certificates side, so I'd like to get that one landed as soon as possible18:03
woodster_arvind: taking a look at https://review.openstack.org/#/c/111412 now....18:04
jaosoriorchellygel: by the way, since you are doing the symantec plugin and it appears to be included in the CR, is the import_ok really needed?18:06
woodster_jaosorior: since symantec is optional (similar to Dogtag), we needs a means to side step non-symantec deployments18:11
chellygelit was a suggestion from kaitlin-farr to do import protection and it also helps with kevin_bishop's change coming in after mine18:11
chellygeljaosorior, ^18:11
jaosorioruok18:12
jaosoriormakes sense18:12
openstackgerritJuan Antonio Osorio Robles proposed a change to openstack/barbican: Replace skipTest in favor of decorator  https://review.openstack.org/11237218:13
aleejvrbanac, redrobot - can I get a +2/ +1 workflow for https://review.openstack.org/#/c/107111/ ?18:14
openstackgerritJuan Antonio Osorio Robles proposed a change to openstack/barbican: Replace skipTest in favor of decorator  https://review.openstack.org/11237218:14
jaosoriorchellygel: sorry if I suggested using a skip method earlier, could you switch to using the decorator? such as in CR 112372, that I just uploaded?18:15
*** paul_glass has joined #openstack-barbican18:17
jvrbanacjaosorior, agree on my comment18:18
jaosoriorhuh?18:19
chellygelok i will switch it to that jaosorior. thanks for the example18:20
*** paul_glass1 has joined #openstack-barbican18:21
chellygelthanks hockeynut for catching the error stuff, i'm fixing that and will resubmit shortly!18:21
*** ayoung has quit IRC18:24
*** paul_glass has quit IRC18:25
*** atiwari has quit IRC18:31
jvrbanacalee, done18:31
*** Kevin_Bishop has joined #openstack-barbican18:36
aleejvrbanac, thanks!18:39
openstackgerritKaitlin Farr proposed a change to openstack/barbican: Adds KMIPSecretStore and unit tests  https://review.openstack.org/10158218:44
aleehey -- just a reminder to all to vote for Barbican talks at the summit.  voting ends today.18:47
woodster_alee: thanks!18:48
hockeynutvote early, vote often!18:48
woodster_alee: just added some comments to Chelsea's CR18:48
aleewoodster_, looking18:48
openstackgerritKaitlin Farr proposed a change to openstack/barbican: Adds KMIPSecretStore and unit tests  https://review.openstack.org/10158218:48
aleewoodster_, chellygel  - we can remove the plugin_name change till we actually need it.18:51
aleewoodster_, its a pretty small loop - but I'll wait till a use case presents itself.18:51
woodster_alee: I'd prefer that if you're ok with it18:55
aleewoodster_, yeah - thats fine with me.18:56
chellygelthanks alee :)19:05
openstackgerritA change was merged to openstack/barbican: Code to pass through transport_key_id when storing secret  https://review.openstack.org/10711119:05
*** Kevin_Bishop has quit IRC19:07
openstackgerritJuan Antonio Osorio Robles proposed a change to openstack/barbican: Replace skipTest in favor of decorator  https://review.openstack.org/11237219:09
jaosoriorI submitted my CR again since CR 107111 also contained some "if not import_ok", so I rebased on to master19:09
*** crc32 has joined #openstack-barbican19:13
*** rellerreller has quit IRC19:15
*** Kevin_Bishop has joined #openstack-barbican19:25
openstackgerritArvind Tiwari proposed a change to openstack/barbican: autodoc import error for plugin.rst  https://review.openstack.org/11239019:27
*** atiwari has joined #openstack-barbican19:30
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in  https://review.openstack.org/11141219:31
*** ayoung has joined #openstack-barbican19:31
woodster_atiwari: I added comments to https://review.openstack.org/#/c/111412/219:32
atiwariwoodster_, sure I am looking in to it19:32
atiwarithanks19:32
*** woodster_ is now known as woodster19:33
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in  https://review.openstack.org/11141220:10
atiwariwoodster, I have fixed most of your comments, one of them I did not get clearly. Please take a look20:12
rm_workredrobot: woot20:19
* rm_work watches dsvm test fail and require 5 rechecks20:19
openstackgerritChelsea Winfree proposed a change to openstack/barbican: Add Certificate Interface & Symantec Plugin  https://review.openstack.org/10719020:20
openstackgerritChelsea Winfree proposed a change to openstack/barbican: Add Certificate Interface & Symantec Plugin  https://review.openstack.org/10719020:21
chellygelhad to rebase >_>20:21
*** bubbva has quit IRC20:24
chellygelactually, im going to have to rebase when rm_work's stuff merges -- so i will resubmit then also20:26
rm_work:P20:27
chellygeljaosorior, youdabes20:28
jaosoriorYoudabes?20:28
jaosoriorWhatse?20:29
redrobotyou da bees knees?20:29
chellygelyou-da-best = youdabes20:29
jaosoriorYay :D20:33
jaosoriorHahaha bees knees, dafuq20:33
woodsterchellygel: rm_work's CR is a force to be reckoned with, like the honey badger?20:34
*** bdpayne has quit IRC20:34
chellygelwoodster, lol20:34
chellygelim scared to wait for it20:34
chellygelmight have to recheck no bug 100x before it gets in20:34
rm_workwooo first failure is out of the way20:34
rm_workrechecking20:34
woodsterzuul is creaking under the weight of it20:34
rm_work1 down 4 to go20:34
rm_work(on average)20:34
*** bdpayne has joined #openstack-barbican20:35
chellygelKevin_Bishop, we are one step closer -- i dont think the new changes should impact too much on your end though20:35
woodsterrm_workd: is this behavior in all of our futures once this lands? Did I really +2 ??? :)20:35
rm_work17 minutes to spin up the VM, 3 seconds to run the tests, 43 seconds to spin down the VM20:35
rm_workawesome testing20:35
woodsterrm_work: ....times 5 (on average)20:36
rm_workyep20:36
rm_workit's AWESOME20:36
rm_work… also plus Zuul queue times20:36
jaosoriorrm_work which cr is it?20:39
rm_workhttps://review.openstack.org/#/c/107845/20:39
aleewoodster, can you ack and give workflow to https://review.openstack.org/112372 so it can merge in?20:40
jaosoriorIs it the one were you had the doubt about the duplicate exception? What was the problem then?20:40
rm_workwell right now I think the problem is not related to my code at all20:41
jaosoriorWhat's the exception?20:41
rm_workIt's something to do with the test environment / VM20:41
rm_workSocket error20:41
jaosoriorWhaaaa20:41
*** bdpayne_ has joined #openstack-barbican20:41
rm_workerror: [Errno 104] Connection reset by peer20:41
rm_workin socket.py20:41
rm_workon a random test20:42
jaosoriorThat sounds pretty wrong...20:42
rm_workit's pretty lame20:42
jaosoriorIndeed Mr.20:42
*** bubbva has joined #openstack-barbican20:42
*** bdpayne has quit IRC20:43
rm_workso according to this20:43
rm_workhttp://logs.openstack.org/45/107845/19/gate/gate-barbican-devstack-dsvm/3711c5b/logs/screen-barbican.txt.gz20:43
rm_workit's related to a Duplicate entry error20:43
rm_workbut I'm catching that20:43
rm_workand it happens on a random test (and has happened on tests that aren't mine)20:43
rm_worknot to mention, it shouldn't be happening in that test to begin with20:44
jaosoriorWell, would it perhaps be a concurrency issue?20:44
rm_workand I can run the tests 50 times on my own devstack box and it never has a problem20:44
jaosoriorSince it runs tests concurrently, that it would be trying to create entries with the same id at the same time or something20:45
redrobotrm_work jaosorior I wasn't going to approve this b/c of the integrity errors, but on runs that do pass dsvm the integrity errors are there as well20:46
*** bdpayne_ has quit IRC20:47
*** akoneru has quit IRC20:47
jaosoriorShould those integrity errors be reported as a bug then?20:47
redrobotnot really... they're being caught & logged, so they're expected?20:48
redrobotthe log that rm_work linked above is from a passing dsvm run20:48
jaosoriorAre they expected?20:48
redrobotyes, b/c posting is idempotent20:48
*** bdpayne has joined #openstack-barbican20:48
jaosoriorSounds to me like we're ignoring potential bugs20:48
jaosoriorAnyway, sleep time, have a good one people! :)20:50
rm_workredrobot: actually the one I JUST linked is from a failed run, but20:50
redrobotsee you jaosorior20:50
rm_workbut yeah20:50
rm_workhttp://logs.openstack.org/45/107845/19/check/gate-barbican-devstack-dsvm/84c5794/logs/screen-barbican.txt.gz20:50
rm_workthis is from a passing one20:51
rm_worksame issue20:51
rm_workbut no test fail20:51
rm_workbecause I'm capturing the dupe20:51
rm_workit's part of one of the tests to do a dupe-id :P20:51
rm_workwell, not ID, but violate a unique constraint and see what happens (and make sure what happens is the right thing)20:51
rm_workthough I really don't know why it shows up in those logs because the exception is never raised20:52
rm_workit's caught and ignored20:52
rm_workwoot, two down20:54
*** paul_glass1 has quit IRC21:01
*** juantwo has quit IRC21:01
*** alee is now known as alee_afk21:05
*** Kevin_Bishop has quit IRC21:12
rm_workone more failure down21:12
rm_worklet's go for 3rd time's the charm?21:12
chellygelthats so weird. cant be right :S21:13
rm_workfor the life of me i cannot reproduce it on any system i have access to21:13
rm_workif anyone else can, I'll buy them lunch21:14
chellygel:(21:25
*** bdpayne has quit IRC21:26
chellygellooks like it failed already :(21:29
openstackgerritChelsea Winfree proposed a change to openstack/barbican: Add Certificate Interface & Symantec Plugin  https://review.openstack.org/10719021:31
chellygelremoved unused exception21:31
*** bdpayne has joined #openstack-barbican21:32
*** Kevin_Bishop has joined #openstack-barbican21:33
openstackgerritKevin Bishop proposed a change to openstack/barbican: First attempt at adding the symantecssl library  https://review.openstack.org/11014421:48
openstackgerritKevin Bishop proposed a change to openstack/barbican: First attempt at adding the symantecssl library  https://review.openstack.org/11014421:51
*** bdpayne has quit IRC22:01
*** bdpayne has joined #openstack-barbican22:02
*** Kevin_Bishop has quit IRC22:05
*** jamielennox|away is now known as jamielennox22:42
*** juantwo has joined #openstack-barbican22:44
*** juantwo has quit IRC22:44
openstackgerritAdam Harwell proposed a change to openstack/barbican: Add support to Barbican for consumer registration  https://review.openstack.org/10784522:45
*** juantwo has joined #openstack-barbican22:45
*** bdpayne has quit IRC22:46
*** jaosorior has quit IRC22:52
openstackgerritAdam Harwell proposed a change to openstack/barbican: Add support to Barbican for consumer registration  https://review.openstack.org/10784523:05
woodsteraitwari: I added comments to https://review.openstack.org/#/c/8740523:17
*** mdorman has quit IRC23:18
*** bdpayne has joined #openstack-barbican23:25
openstackgerritJohn Wood proposed a change to openstack/barbican: Replace hard-coded setup version setting  https://review.openstack.org/10958023:38
*** atiwari has quit IRC23:45
rm_workHA! can finally replicate these connection errors, due in part to something chellygel said earlier23:50
rm_workwoodster: and yeah, I am very afraid that the barbican API does not handle concurrency well, though probably just due to Pecan's return handling23:50
rm_workdef owe her a lunch23:51
« Tuesday, 2014-08-05 Index Thursday, 2014-08-07 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!