*** nkinder has joined #openstack-barbican | 00:03 | |
*** bdpayne has quit IRC | 00:37 | |
*** SheenaG1 has joined #openstack-barbican | 00:49 | |
*** SheenaG1 has left #openstack-barbican | 00:50 | |
*** bdpayne has joined #openstack-barbican | 00:50 | |
*** akoneru has quit IRC | 00:51 | |
*** gchardon has joined #openstack-barbican | 01:01 | |
*** gchardon has quit IRC | 01:28 | |
*** rm_you has quit IRC | 01:41 | |
*** rm_you has joined #openstack-barbican | 01:48 | |
*** bdpayne has quit IRC | 01:54 | |
*** crc32 has quit IRC | 01:55 | |
*** woodster_ has quit IRC | 02:05 | |
*** juantwo has joined #openstack-barbican | 03:02 | |
*** juantwo has quit IRC | 03:02 | |
*** juantwo has joined #openstack-barbican | 03:03 | |
openstackgerrit | Arun Kant proposed a change to openstack/barbican: Adding keystone notification listener support https://review.openstack.org/110817 | 03:12 |
---|---|---|
*** ayoung has quit IRC | 03:50 | |
*** rm_you| has joined #openstack-barbican | 05:02 | |
*** rm_you has quit IRC | 05:04 | |
*** rm_you|wtf has joined #openstack-barbican | 05:10 | |
*** rm_you| has quit IRC | 05:13 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/barbican: Imported Translations from Transifex https://review.openstack.org/112764 | 06:10 |
openstackgerrit | Juan Antonio Osorio Robles proposed a change to openstack/barbican: Refactor secret_store for consistency https://review.openstack.org/113531 | 07:17 |
*** jaosorior has joined #openstack-barbican | 07:18 | |
*** gerchardon has quit IRC | 08:54 | |
*** gyee has quit IRC | 10:00 | |
*** gyee has joined #openstack-barbican | 10:07 | |
*** gyee has quit IRC | 10:23 | |
*** gyee has joined #openstack-barbican | 10:30 | |
*** juantwo has quit IRC | 11:28 | |
*** jamielennox is now known as jamielennox|away | 12:02 | |
*** juantwo has joined #openstack-barbican | 12:12 | |
*** juantwo has quit IRC | 12:13 | |
*** juantwo has joined #openstack-barbican | 12:14 | |
*** nkinder has quit IRC | 13:11 | |
*** woodster_ has joined #openstack-barbican | 13:12 | |
openstackgerrit | Arun Kant proposed a change to openstack/barbican: Adding keystone notification listener support https://review.openstack.org/110817 | 13:21 |
jaosorior | Hey, if any core dev has time to review the cliff framework patch: https://review.openstack.org/#/c/107587/ it would be cool to keep that going :) or maybe even merged :D | 13:26 |
*** ayoung has joined #openstack-barbican | 13:32 | |
*** paul_glass has joined #openstack-barbican | 13:42 | |
*** paul_glass1 has joined #openstack-barbican | 13:45 | |
*** paul_glass has quit IRC | 13:49 | |
*** paul_glass1 is now known as paul_glass | 13:53 | |
*** nkinder has joined #openstack-barbican | 13:55 | |
*** akoneru has joined #openstack-barbican | 13:59 | |
jvrbanac | alee, redrobot, reaperhulk, woodster_, rellerreller ^^ | 14:11 |
redrobot | jvrbanac jaosorior it's on my to-do list. Unfortunately I'm not familiar with Cliff, so I have to spin up on that before I can review | 14:12 |
*** paul_glass1 has joined #openstack-barbican | 14:15 | |
*** openstackgerrit has quit IRC | 14:16 | |
*** openstackgerrit has joined #openstack-barbican | 14:18 | |
*** paul_glass has quit IRC | 14:18 | |
*** juantwo has quit IRC | 14:28 | |
*** juantwo has joined #openstack-barbican | 14:29 | |
*** juantwo has quit IRC | 14:30 | |
*** juantwo has joined #openstack-barbican | 14:30 | |
hyakuhei | Morning all. | 14:35 |
*** SheenaG1 has joined #openstack-barbican | 15:12 | |
*** paul_glass1 is now known as paul_glass | 15:15 | |
paul_glass | redrobot | 15:15 |
jvrbanac | hyakuhei, morning | 15:16 |
redrobot | hyakuhei good morning! | 15:16 |
redrobot | paul_glass sup? | 15:16 |
*** jaosorior has quit IRC | 15:32 | |
*** atiwari has joined #openstack-barbican | 15:43 | |
woodster_ | atiwari: Would you be able to address comments in this CR this week perhaps?: https://review.openstack.org/#/c/87405 | 15:46 |
*** juantwo has quit IRC | 15:55 | |
openstackgerrit | Venkat Sundaram proposed a change to openstack/python-barbicanclient: remove tenant-id from uri https://review.openstack.org/112149 | 16:01 |
*** gyee_ has joined #openstack-barbican | 16:02 | |
*** juantwo has joined #openstack-barbican | 16:06 | |
*** juantwo_ has joined #openstack-barbican | 16:07 | |
*** juantwo has quit IRC | 16:10 | |
*** SheenaG1 has quit IRC | 16:12 | |
rm_work | redrobot: you get a chance to look at blueprinting the client changes? | 16:18 |
alee | woodster_, ping | 16:24 |
woodster_ | alee: hello | 16:25 |
alee | woodster_, hey! so any further thoughts on the certificates interface? | 16:25 |
alee | woodster_, should we try and define an interface or leave it as plugin specific meta-data | 16:26 |
woodster_ | alee: had a discussion a SME on certificates over here, and it seems that the differences between the cert plugins and the types of certs generated would make it hard make a generic meta key/value block that covers all situations, and then let plugins decide if they support it or not. It seems more practical to define up front I want issuer xyz (Dogtag, | 16:27 |
woodster_ | Symatec, etc.) and them provide key/value info appropriate for that vendor. | 16:27 |
alee | woodster_, SME? | 16:28 |
woodster_ | atiwari: are you there? Curious about CR https://review.openstack.org/#/c/87405 | 16:28 |
woodster_ | alee: subject matter expert...so, our team that handles customer certs over here | 16:29 |
alee | woodster_, I tend to agree. it would take awhile to design something generic enough - whereas you could much more easily get to even complicated certs quickly with just a pass through .. | 16:29 |
*** rm_work has quit IRC | 16:29 | |
woodster_ | heading off to a meeting for 30 min, back after that... | 16:30 |
woodster_ | alee: agreed | 16:30 |
alee | woodster_, ok - lets chat after that | 16:30 |
*** rm_work has joined #openstack-barbican | 16:30 | |
alee | and maybe figure out how we can expose which cert plugins are available. | 16:30 |
*** paul_glass has quit IRC | 16:34 | |
*** rm_work has quit IRC | 16:34 | |
*** paul_glass has joined #openstack-barbican | 16:34 | |
*** rm_work has joined #openstack-barbican | 16:35 | |
*** SheenaG1 has joined #openstack-barbican | 16:35 | |
*** rm_work has quit IRC | 16:35 | |
*** rm_work has joined #openstack-barbican | 16:35 | |
*** paul_glass1 has joined #openstack-barbican | 16:36 | |
*** paul_glass has quit IRC | 16:39 | |
*** atiwari has quit IRC | 16:40 | |
*** rm_work has quit IRC | 16:41 | |
*** rm_work has joined #openstack-barbican | 16:42 | |
*** rm_work has quit IRC | 16:42 | |
*** rm_work has joined #openstack-barbican | 16:42 | |
*** paul_glass1 has quit IRC | 16:46 | |
*** rm_work has quit IRC | 16:47 | |
*** rm_work has joined #openstack-barbican | 16:47 | |
*** juantwo_ has quit IRC | 16:51 | |
*** rm_work has quit IRC | 16:52 | |
*** rm_work has joined #openstack-barbican | 16:53 | |
*** rm_work has quit IRC | 16:53 | |
*** rm_work has joined #openstack-barbican | 16:53 | |
*** gyee_ has quit IRC | 16:53 | |
*** juantwo has joined #openstack-barbican | 16:55 | |
*** juantwo_ has joined #openstack-barbican | 16:56 | |
*** juantwo__ has joined #openstack-barbican | 16:56 | |
*** juantwo__ has quit IRC | 16:57 | |
*** juantwo__ has joined #openstack-barbican | 16:57 | |
*** rm_work has quit IRC | 16:58 | |
*** rm_work has joined #openstack-barbican | 16:58 | |
*** rm_work has quit IRC | 16:58 | |
*** rm_work has joined #openstack-barbican | 16:58 | |
*** juantwo_ has quit IRC | 17:00 | |
*** juantwo has quit IRC | 17:00 | |
*** akoneru is now known as akoneru_lunch | 17:02 | |
*** rm_work has quit IRC | 17:03 | |
*** rm_work has joined #openstack-barbican | 17:04 | |
*** rm_work has quit IRC | 17:04 | |
*** rm_work has joined #openstack-barbican | 17:04 | |
*** rm_work has quit IRC | 17:08 | |
*** rm_work has joined #openstack-barbican | 17:10 | |
woodster_ | alee: back for a little before heading out for errands. Yes, we would need a facility for seeing what cert plugins are supported | 17:14 |
woodster_ | alee: maybe a GET orders variation? | 17:15 |
*** rm_work has quit IRC | 17:15 | |
alee | woodster_, perhaps. we're in the process of adding a feature to dogtag that would allow an admin to define multiple lightweight sub-ca's within a single ca. | 17:18 |
alee | woodster_, that would be very useful for example, if you wanted a particular project to have its own subca | 17:19 |
alee | to restrict the scope of certificates within the project. | 17:19 |
*** rm_work has joined #openstack-barbican | 17:19 | |
*** rm_work has quit IRC | 17:19 | |
*** rm_work has joined #openstack-barbican | 17:19 | |
woodster_ | alee: is there a mechanism exposed to list out all of those available cas/subcas? One we might adopt in barbican perhaps? | 17:20 |
alee | woodster_, I'd like to design with that feature in mind -- basically, the idea that a single plugin might serve multiple ca's | 17:20 |
alee | woodster_, there will be :) | 17:20 |
*** juantwo__ has quit IRC | 17:20 | |
alee | woodster_, its in the planning phases now - but the idea is definitely to expose this to barbican | 17:21 |
*** juantwo has joined #openstack-barbican | 17:21 | |
alee | and maybe even expose through some barbican admin inteface, the ability to create/ request creation of subca's .. | 17:21 |
*** juantwo has quit IRC | 17:22 | |
alee | woodster_, I'll probably propose that as a possible design session at the K summit | 17:22 |
alee | woodster_, in any case, I think we may need a table to map ca/subca identifier to plugin | 17:23 |
alee | woodster_, and we might want to expose that data to the end-user. | 17:24 |
alee | so that the client knows which ca's are available | 17:24 |
alee | woodster_, there is also the possibility that we could define some kind of usage() function that plugins could choose to implement | 17:25 |
alee | to get the current required/optional fields .. | 17:25 |
*** rm_work has quit IRC | 17:26 | |
woodster_ | alee: that's interesting....maybe a GET from orders?certificates or GET orders?certificates=dogtag would return that info? | 17:27 |
*** rm_work has joined #openstack-barbican | 17:27 | |
alee | woodster_, yup | 17:27 |
alee | woodster_, more like GET orders?ca_id=X perhaps? | 17:28 |
alee | where ca_id will map to a plugin | 17:29 |
woodster_ | alee: sounds interesting | 17:29 |
alee | woodster_, yeah - so do you think the certificate id's should be a resource in and of themselves? | 17:31 |
*** rm_work has quit IRC | 17:32 | |
*** rm_work has joined #openstack-barbican | 17:32 | |
*** juantwo has joined #openstack-barbican | 17:32 | |
woodster_ | alee: I was hoping we could use names like 'symantec-xxxx' or 'dogtag-xxxx' that the plugins could produce maybe? | 17:33 |
alee | woodster_, incidentally we just found a need for plugin_name in get_plugin() in certificate_manager() -- and sooner than I expected :) | 17:33 |
woodster_ | alee: ha, yes. This is a little more sophisticated though...like a supports() call but with that ca_id passed in? | 17:34 |
alee | woodster_, I think that may be a little brittle - especially if eventually folks may get the ability to add subca's | 17:35 |
alee | folks for example might want to name their subca -- dev-ca for instance | 17:35 |
alee | and allowing them to do that seems much more user friendly. | 17:36 |
*** rm_work has quit IRC | 17:37 | |
*** atiwari has joined #openstack-barbican | 17:38 | |
*** rm_work has joined #openstack-barbican | 17:38 | |
*** rm_work has quit IRC | 17:38 | |
*** rm_work has joined #openstack-barbican | 17:38 | |
alee | woodster_, if we allow more generic names, then we need to keep those names in barbican-core and barbican-core should do the id->plugin lookup. | 17:39 |
alee | and we should just have get_plugin(plugin_name=dogtag) | 17:39 |
woodster_ | alee: interesting. Ok, it might be good to have a blueprint to capture that, or at least an etherpad. Heading out now for a bit, let's talk about this a bit later | 17:39 |
alee | sure | 17:39 |
alee | woodster_, I'll start an etherpad | 17:40 |
*** rm_work has quit IRC | 17:43 | |
*** rm_work has joined #openstack-barbican | 17:44 | |
*** rm_work has quit IRC | 17:44 | |
*** rm_work has joined #openstack-barbican | 17:44 | |
*** rm_work has quit IRC | 17:49 | |
*** rm_work has joined #openstack-barbican | 17:49 | |
*** rm_work has quit IRC | 17:50 | |
*** rm_work has joined #openstack-barbican | 17:50 | |
*** rm_work has quit IRC | 17:54 | |
*** akoneru_lunch is now known as akoneru | 17:59 | |
*** rm_work has joined #openstack-barbican | 18:05 | |
*** rm_work has quit IRC | 18:05 | |
*** rm_work has joined #openstack-barbican | 18:05 | |
*** rm_work has quit IRC | 18:11 | |
*** rm_work has joined #openstack-barbican | 18:12 | |
*** rm_work has quit IRC | 18:16 | |
*** rm_work has joined #openstack-barbican | 18:16 | |
*** ayoung has quit IRC | 18:26 | |
*** rm_work has quit IRC | 18:29 | |
*** rm_work has joined #openstack-barbican | 18:29 | |
*** SheenaG1 has quit IRC | 18:31 | |
*** rm_work has quit IRC | 18:33 | |
*** rm_work has joined #openstack-barbican | 18:33 | |
*** SheenaG11 has joined #openstack-barbican | 18:33 | |
*** paul_glass has joined #openstack-barbican | 18:36 | |
*** openstackgerrit has quit IRC | 18:41 | |
*** jenkins-keep has quit IRC | 18:41 | |
*** openstackgerrit has joined #openstack-barbican | 18:50 | |
openstackgerrit | Ravi Sankar Penta proposed a change to openstack/barbican: Install sqlite-devel package on fedora https://review.openstack.org/113404 | 18:53 |
redrobot | rm_work kinda... still WIP though | 18:53 |
rm_work | redrobot: like, WIP and posted? or WIP on your hard drive :P | 19:01 |
redrobot | rm_work the latter. | 19:01 |
*** jenkins-keep has joined #openstack-barbican | 19:05 | |
woodster_ | atiwari: are you there? | 19:13 |
rm_work | redrobot: k | 19:14 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: IMaking updates to ck-devguide.xml after tech review Updating dev guide and WADL after tech review and edit Incorporated review comments from John Wood into WADL and devguide https://review.openstack.org/105488 | 19:16 |
openstackgerrit | A change was merged to openstack/python-barbicanclient: Introduce cliff for cli framework https://review.openstack.org/107587 | 19:25 |
rm_work | redrobot: if you finish that BP even partially (like for Secrets or Orders individually) you should go ahead and post it as a WIP, I can get started on one of those, even if there would be minor changes | 19:26 |
rm_work | redrobot: though, I think I know what you are thinking anyway (using the Container BP to extrapolate), so I might be able to get started regardless | 19:26 |
rm_work | though it's funny to think about writing the code first and following up with a BP spec :P\ | 19:27 |
hockeynut | that way you know the code matches the spec ;-) | 19:28 |
rm_work | truth | 19:37 |
*** ayoung has joined #openstack-barbican | 20:15 | |
*** paul_glass has quit IRC | 20:20 | |
openstackgerrit | John Vrbanac proposed a change to openstack/barbican: Updating symantec plugin docstrings https://review.openstack.org/114017 | 20:35 |
*** crc32 has joined #openstack-barbican | 20:37 | |
jvrbanac | alee, reaperhulk, redrobot, codekobe_, dstufft, could one of y'all workflow this CR https://review.openstack.org/#/c/110144/ | 20:38 |
redrobot | jvrbanac -1 symantecssl should be added to requirements.txt | 20:44 |
redrobot | or maybe not? ... | 20:45 |
* redrobot still unclear about optional requierements | 20:45 | |
redrobot | which is an oxymoron... if it's optional it's not required, right? | 20:45 |
* redrobot shrugs | 20:45 | |
openstackgerrit | John Wood proposed a change to openstack/barbican: Install of a Barbican RPM fails due to missing keystonemiddleware https://review.openstack.org/114022 | 20:50 |
woodster_ | redrobot: I don't think anything outside of global reqs should show up in requirements.txt | 20:51 |
woodster_ | redrobot: so we are using Ade's Dogtag approach as a guideline, whereby only if dogtag is activated via stevedore do we try to do anything with it | 20:51 |
woodster_ | redrobot: said another way, Symantec and Dogtag are optional deployment modes for Barbican, but not out of the box for general OpenStack installs | 20:53 |
reaperhulk | yep, so they don't belong in global reqs (and indeed we should remove that pykcs11 todo in there) | 20:53 |
redrobot | right, but symantec is listed as the default plugin out of the box | 20:57 |
redrobot | https://github.com/openstack/barbican/blob/master/barbican/plugin/interface/certificate_manager.py#L36 | 20:57 |
redrobot | I think? | 20:57 |
*** rm_work has quit IRC | 20:57 | |
*** rm_work has joined #openstack-barbican | 20:57 | |
*** rm_work has quit IRC | 20:58 | |
*** rm_work has joined #openstack-barbican | 20:58 | |
*** juantwo has quit IRC | 20:58 | |
woodster_ | good point...that should be removed, in favor of an as-yet-written default cert plugin but a plugin not found 500 is appropriate for now | 20:58 |
woodster_ | atiwari: are you there? | 20:59 |
openstackgerrit | Arun Kant proposed a change to openstack/barbican: Adding keystone notification listener support https://review.openstack.org/110817 | 21:01 |
*** rm_work has quit IRC | 21:01 | |
*** rm_work has joined #openstack-barbican | 21:04 | |
woodster_ | ugh, devstack gate failed on a documentation CR...The Barbican (non-admin) API failed to respond within 20 seconds | 21:04 |
*** rm_work has quit IRC | 21:04 | |
*** rm_work has joined #openstack-barbican | 21:04 | |
woodster_ | ....https://review.openstack.org/#/c/105488/ | 21:04 |
jvrbanac | redrobot, I figured it wasn't required right now | 21:04 |
jvrbanac | redrobot, we don't depend on dogtag stuff either | 21:05 |
redrobot | jvrbanac see comment about symantec being enabled out of the box | 21:05 |
redrobot | jvrbanac unlike dogtag | 21:05 |
jvrbanac | redrobot, I was trying to avoid taking over Kevin's CR. Oh well, let me toss that in. | 21:06 |
*** rm_work has quit IRC | 21:07 | |
*** rm_work has joined #openstack-barbican | 21:07 | |
*** rm_work has quit IRC | 21:07 | |
*** rm_work has joined #openstack-barbican | 21:07 | |
redrobot | jvrbanac I think maybe disabling a default plugin would be best? Seems we want to keep symantecssl out of requirements.txt | 21:07 |
woodster_ | redrobot: yeah, better to have no default plugin rather than a non-global-reqs one | 21:09 |
jvrbanac | redrobot, woodster_ agreed. | 21:10 |
jvrbanac | I think it's better to keep the initially activated plugins to a minimum. | 21:10 |
jvrbanac | It feels like more of a deployer choice. | 21:11 |
jvrbanac | redrobot, so what do you want me to do with the symantec CR? | 21:13 |
woodster_ | jvrbanac: he just stepped away | 21:14 |
*** rm_work has quit IRC | 21:14 | |
woodster_ | jvrbanac: do you mean in regards to that default plugin being set to symantec? | 21:14 |
*** rm_work has joined #openstack-barbican | 21:18 | |
*** rm_work has quit IRC | 21:19 | |
*** rm_work has joined #openstack-barbican | 21:19 | |
jvrbanac | woodster_, yeah. I just want to know if I need to do something to resolve this CR | 21:21 |
woodster_ | jvrbanac: ...vs just accepting as is, and then quick following with a CR to tweak things? | 21:22 |
jvrbanac | woodster_, yeah. I added a follow-up CR already to address venkat's comments | 21:23 |
woodster_ | jvrbanac: that works for me, but once I see Douglas I'll see if he is ok with removing the -1 | 21:24 |
jvrbanac | woodster_, awesome thanks! | 21:24 |
SheenaG11 | Heads up, folks. chellygel just got me set up so I can start wrecking house (read: committing code). | 21:25 |
SheenaG11 | It's about to go DOWN. | 21:25 |
rm_work | oh shiiiii-- | 21:25 |
reaperhulk | I'll get my -2s ready | 21:26 |
SheenaG11 | Just the kind of love and acceptance I expected from this crew. | 21:26 |
chellygel | i was really hoping she'd -1 yalls stuff instead | 21:26 |
reaperhulk | I'll treat you the same as I treat everybody else | 21:26 |
reaperhulk | PS figured out the IOError issue. Still thinking about the best way to fix it though | 21:27 |
chellygel | the adam-connection-reset-drama error? | 21:27 |
SheenaG11 | I'm really just trying to get set up to make doc changes, so hopefully it won't require a lot of -2s | 21:27 |
openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in https://review.openstack.org/111412 | 21:27 |
reaperhulk | chellygel: this is the one we had when trying to stand up our dev env | 21:29 |
woodster_ | SheenaG11: with great power comes great responsibility! | 21:29 |
reaperhulk | unrelated to rm_work's uwsgi issue actually | 21:29 |
woodster_ | SheenaG11: are you planning to make changes after Constanze's CR merges?: https://review.openstack.org/#/c/105488/ | 21:29 |
chellygel | ah | 21:29 |
SheenaG11 | Yeah - it's not a today thing, chellygel still has much to learn me | 21:30 |
SheenaG11 | Sorry, that was for woodster_ | 21:30 |
chellygel | well im still pulling for SheenaG11 to start voting on that CR too.. so maybe thats next lesson! | 21:31 |
SheenaG11 | Noooooooooooo | 21:31 |
woodster_ | reaperhulk: is the ioerror issue C-related or stevedore/plugin-mgr related? | 21:32 |
reaperhulk | plugin manager | 21:32 |
reaperhulk | If we singleton the PluginManager instance the issue completely disappears | 21:33 |
*** rm_work has quit IRC | 21:33 | |
*** rm_work has joined #openstack-barbican | 21:33 | |
*** rm_work has quit IRC | 21:35 | |
*** rm_work has joined #openstack-barbican | 21:36 | |
redrobot | jvrbanac +2 on a failed gate. Naughty, naughty! https://review.openstack.org/#/c/114017/ | 21:38 |
jvrbanac | redrobot, lol! Nothing like a recheck no bug ll | 21:39 |
jvrbanac | ^lol | 21:39 |
woodster_ | devstack gate is borking! | 21:39 |
woodster_ | did the admin api change recently? | 21:40 |
jvrbanac | woodster_, not that I know of | 21:40 |
woodster_ | Does anyone have an issue with a singleton plugin manager? | 21:41 |
woodster_ | reaperhulk: interesting that we hadn't noticed this issue before using pkcs11 though. Hopefully only stevedore is our issue here. | 21:42 |
reaperhulk | It only happened after the plugin refactor | 21:42 |
reaperhulk | Since prior to that we didn't instantiate this way | 21:42 |
reaperhulk | My last test was prior to that code being merged :) | 21:42 |
woodster_ | we had the extension manager before...was it singleton? I didn't think so | 21:43 |
reaperhulk | I believe it was | 21:44 |
woodster_ | sorry, 'The Barbican (non-admin) API failed to respond within 20 seconds'...so the regular API is croaking in devstack it seems | 21:45 |
woodster_ | reaperhulk: So can you put up a bug and then CR to fix that? | 21:45 |
reaperhulk | Yeah I will as soon as I make up my mind how I want to fix it :) | 21:45 |
woodster_ | reaperhulk: sounds good, thanks for digging into that one... | 21:46 |
*** crc32 has quit IRC | 21:47 | |
rm_work | I can maybe look at that >_> | 21:48 |
* rm_work looks | 21:48 | |
rm_work | since all my devstack stuff is spun up to mimick the gate as closely as possible | 21:48 |
*** SheenaG11 has quit IRC | 21:49 | |
*** crc32 has joined #openstack-barbican | 21:53 | |
redrobot | looks like it's pbr taking a shit on the version? | 21:58 |
*** nkinder has quit IRC | 22:05 | |
jvrbanac | arg!! | 22:09 |
rm_work | AttributeError: 'Module_six_moves_urllib_parse' object has no attribute 'SplitResult' | 22:10 |
rm_work | is what I'm getting | 22:10 |
rm_work | which is in stevedore | 22:10 |
rm_work | old six lib it looks like | 22:10 |
rm_work | hmm or too new six lib :P | 22:10 |
redrobot | six 1.7.3 released on 6/29/14 is latest | 22:11 |
rm_work | hmm | 22:11 |
rm_work | six.moves.urllib.parse.SplitResult exists in 3.3, doesn't in 2.x | 22:14 |
rm_work | wtf | 22:14 |
rm_work | i thought the whole POINT of 'six' was to provide compatibility from 2.x and 3.x | 22:14 |
rm_work | is stevedore a new req? | 22:15 |
redrobot | no, we've been stevedoring for a while now | 22:15 |
rm_work | hmm | 22:15 |
redrobot | and yes, that is weird... six IS supposed to level the 2 vs 3 field. | 22:16 |
rm_work | the stack is from http://pastebin.com/raw.php?i=UYLyxFD3 | 22:17 |
*** akoneru has quit IRC | 22:17 | |
rm_work | err, stacktrace is in that link | 22:17 |
rm_work | barbican queue init -> oslo messaging transport -> stevedore -> six | 22:18 |
redrobot | oh wow this is oslo.messaging-> stevedore -> six | 22:18 |
redrobot | JINX! | 22:18 |
rm_work | heh | 22:18 |
rm_work | I beat you by like SIX seconds :P:P | 22:18 |
rm_work | what plugin was stevedore trying to load | 22:22 |
redrobot | who knows... I'm not familiar with oslo.messaging internals | 22:22 |
rm_work | hmmm | 22:23 |
rm_work | https://github.com/openstack/barbican/blob/master/barbican/openstack/common/network_utils.py | 22:23 |
rm_work | is the only place barbican uses SplitResult | 22:24 |
rm_work | https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/openstack/common/network_utils.py | 22:24 |
rm_work | is where they use it | 22:24 |
rm_work | and yeah theirs is from six.moves | 22:24 |
redrobot | eh... fun... that comes from oslo's "managed copy paste" | 22:25 |
redrobot | maybe we're due for a resync | 22:25 |
redrobot | because, you know, libs aren't good enough for this stuff.. | 22:25 |
redrobot | rm_work https://github.com/openstack/oslo-incubator/blob/master/openstack/common/network_utils.py | 22:26 |
redrobot | yeah, looks like there's a new version using six | 22:27 |
*** ayoung is now known as ayoung_is_a_Dad | 22:27 | |
redrobot | congratulations ayoung_is_a_Dad !!! | 22:27 |
redrobot | rm_work do you know how to resync oslo-incubator? | 22:28 |
rm_work | a) no | 22:29 |
rm_work | b) is that the problem? | 22:29 |
rm_work | i thought the problem WAS that they are using six :P | 22:29 |
rm_work | they need to NOT be using six? :P | 22:29 |
rm_work | the version we have now is the version that uses six, and it's broken | 22:30 |
redrobot | rm_work network_utils.py in barbican is outdated | 22:30 |
rm_work | ah | 22:30 |
rm_work | you mean OURS | 22:30 |
redrobot | yep | 22:30 |
rm_work | so... now ours will break too? :P i'm maybe missing the point | 22:30 |
rm_work | if we sync... then barbican will ALSO have the broken version (the one using six) | 22:31 |
rm_work | well, broken for 2.x, working for 3.x | 22:31 |
redrobot | http://i.imgur.com/xVyoSl.jpg | 22:32 |
rm_work | I think really, we need to do: | 22:33 |
rm_work | from urllib import parseif six.moves.urllib. | 22:33 |
rm_work | err | 22:33 |
*** crc32 has quit IRC | 22:33 | |
rm_work | import six | 22:36 |
rm_work | if six.PY3: | 22:36 |
rm_work | from six.moves.urllib import parse | 22:36 |
rm_work | else: | 22:36 |
rm_work | from urllib import parse | 22:36 |
rm_work | >_> | 22:36 |
rm_work | shitty | 22:36 |
redrobot | wow super shitty | 22:36 |
redrobot | where is this needed? | 22:36 |
rm_work | which is exactly what six is supposed to freaking prevent | 22:36 |
rm_work | oslo messaging, I think | 22:36 |
rm_work | well, that file you linked | 22:37 |
redrobot | network_utils? | 22:37 |
rm_work | anywhere that uses SplitResult | 22:37 |
rm_work | yeah | 22:37 |
rm_work | let me try and see what happens | 22:37 |
redrobot | right, so | 22:37 |
redrobot | I was saying | 22:37 |
redrobot | anything in barbican/openstack/common/* can't be edited by us | 22:37 |
rm_work | right | 22:37 |
redrobot | I just don't understand why this would start failing now... it's not like oslo.messaging got a new relese | 22:38 |
rm_work | hmm | 22:39 |
*** juantwo has joined #openstack-barbican | 22:40 | |
*** juantwo has quit IRC | 22:41 | |
rm_work | ah it's oslo.messaging/oslo/messaging/transport.py | 22:41 |
*** juantwo has joined #openstack-barbican | 22:41 | |
*** crc32 has joined #openstack-barbican | 22:49 | |
rm_work | ok so | 22:51 |
rm_work | import six | 22:51 |
rm_work | if six.PY3: | 22:51 |
rm_work | from six.moves.urllib import parse | 22:51 |
rm_work | else: | 22:51 |
rm_work | import urlparse as parse | 22:51 |
rm_work | in openstack/common/network_utils.py | 22:52 |
rm_work | and oslo/messaging/transport.py | 22:52 |
rm_work | and then it works >_> | 22:52 |
rm_work | really just the first one matters for us | 22:53 |
rm_work | but both are broken | 22:53 |
rm_work | it's not our code-tree though, it's the oslo import of the network_utils that's bad | 22:53 |
rm_work | and yeah, I have no idea how that works, it's just a submodule we sync in periodically? | 22:53 |
rm_work | https://github.com/openstack/oslo-incubator/blob/master/openstack/common/network_utils.py#L23 | 22:55 |
rm_work | I'm with you though on having no idea why this would pop up NOW | 22:56 |
redrobot | yeah, its supposed to be synced whenever the project feels comfortable syncing | 22:56 |
redrobot | oslo calls it "managed copy paste" or somethign to that effect | 22:57 |
redrobot | I bitched about it a lot at the Atlanta summit | 22:57 |
rm_work | hmm | 22:57 |
redrobot | because you know, whe have these things called libraries in python where you can release code instead of copy-pasting it everywhere... | 22:57 |
rm_work | trying to see if oslo.messaging recently did that | 22:57 |
rm_work | not sure how to tell | 22:57 |
rm_work | looking through https://review.openstack.org/#/q/project:openstack/oslo.messaging,n,z | 22:57 |
redrobot | rm_work https://review.openstack.org/#/q/project:openstack/oslo.messaging+status:merged,n,z works better | 22:58 |
rm_work | err, right | 22:59 |
rm_work | fuck, i have no idea | 23:03 |
redrobot | lmao | 23:03 |
redrobot | i'm right there with you bro | 23:03 |
rm_work | was this really merged in FEBRUARY!? | 23:04 |
rm_work | how the hell | 23:04 |
rm_work | so obviously we just weren't triggering it until recently | 23:04 |
redrobot | where did you grab that stacktrace from again? | 23:04 |
rm_work | my devstack box | 23:05 |
redrobot | heh | 23:06 |
redrobot | sooooooo | 23:06 |
rm_work | soooooooooooo? | 23:06 |
redrobot | the stacktrace I'm seeing | 23:06 |
redrobot | is pbr shitting itself | 23:06 |
redrobot | http://logs.openstack.org/17/114017/1/check/gate-barbican-devstack-dsvm/4ebdcee/logs/screen-barbican.txt.gz | 23:06 |
rm_work | hmmm | 23:06 |
rm_work | rebuilding my devbox | 23:09 |
rm_work | from scratch | 23:11 |
rm_work | again. | 23:11 |
*** nkinder has joined #openstack-barbican | 23:14 | |
redrobot | rm_work word... I'm going to take off. I'll try to jump back on later. | 23:26 |
rm_work | kk | 23:26 |
openstackgerrit | Douglas Mendizábal proposed a change to openstack/barbican: Revert remove version from setup.cfg https://review.openstack.org/114080 | 23:29 |
redrobot | rm_work actually, gonna stick around for just a sec | 23:29 |
rm_work | kk | 23:29 |
redrobot | i suspect this changed borked the gate https://review.openstack.org/#/c/109580/10 | 23:29 |
rm_work | the pbr version bit? | 23:29 |
redrobot | aye | 23:30 |
rm_work | how did IT pass the gate then? | 23:30 |
redrobot | ha! good question | 23:31 |
* redrobot shrugs | 23:31 | |
*** ravips has joined #openstack-barbican | 23:33 | |
redrobot | well it doesn't look like zuul wants to test my theory any time soon, so I'm defnitely taking off | 23:47 |
rm_work | hmm k | 23:48 |
rm_work | redrobot: well looks like i was chasing ghosts | 23:48 |
rm_work | though i am curious WTF | 23:48 |
rm_work | because even if it's not our error, i don't understand how that urllib parse code would work in 2.x <_< | 23:49 |
rm_work | looks like the PBR error is what I get now in a clean devstack | 23:49 |
rm_work | and yeah, can't keep a devstack instance for more than like, 5 minutes it seems <_< | 23:49 |
*** jamielennox|away is now known as jamielennox | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!