woodster_ | rm_work: redrobot that version bump script has nothing to do with de stack or the code | 00:00 |
---|---|---|
rm_work | woodster_: well | 00:03 |
rm_work | woodster_: that change is the difference between barbican not running, and running fine | 00:03 |
rm_work | in my devstack instance | 00:03 |
rm_work | which I *just* refreshed | 00:03 |
rm_work | so i'm going to go with "yeah, that version script matters" :P | 00:04 |
woodster_ | Super weird and annoying :/ | 00:04 |
rm_work | yep | 00:04 |
rm_work | anyway, waiting for Zuul to prove it | 00:04 |
rm_work | but, I definitely was able to replicate and verify the issue locally | 00:05 |
rm_work | heading home, looking forward to Zuul responding :P | 00:05 |
woodster_ | I'm not logged in to gerrit from my phone but that version should be 2014.2 for Juno at least | 00:05 |
woodster_ | Ok thanks for your help (again) | 00:06 |
rm_work | well, it should be bumped then, not removed like it was :P | 00:10 |
rm_work | but yeah, happy to help | 00:11 |
rm_work | bbl | 00:11 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: IMaking updates to ck-devguide.xml after tech review Updating dev guide and WADL after tech review and edit Incorporated review comments from John Wood into WADL and devguide Making additional updaotes to dev guide and GS guide to remove references to UTF https://review.openstack.org/105488 | 00:13 |
*** atiwari has quit IRC | 00:16 | |
*** crc32 has quit IRC | 00:23 | |
*** ravips has quit IRC | 00:24 | |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Making updates to ck-devguide.xml after tech review Updating dev guide and WADL after tech review and edit Incorporated review comments from John Wood into WADL and devguide Making additional updaotes to dev guide and GS guide to remove references to UTF- https://review.openstack.org/105488 | 00:27 |
woodster_ | rm_work: pbr synthesizes the version from git tag | 00:35 |
woodster_ | rm_work: that version block should not be needed | 00:35 |
rm_you|wtf | hmmm | 00:44 |
rm_you|wtf | well, Jenkins passed it | 00:44 |
rm_you|wtf | but for some reason jenkins can't post on the review | 00:44 |
*** rm_you|wtf is now known as rm_you | 00:44 | |
rm_you | so, couldn't tell ya | 00:44 |
*** ayoung_is_a_Dad is now known as ayoung | 01:04 | |
ayoung | redrobot, heh...I've been a dad for 8 years. I was just setting the topic to tell people that I was in Dad mode. But thanks. | 01:05 |
hockeynut | redrobot woodster I see the same failure on others now that the pbr change has been merged. for example: http://logs.openstack.org/44/110144/19/check/gate-barbican-devstack-dsvm/6398c4f/logs/screen-barbican.txt.gz | 02:12 |
hockeynut | are the git tags kosher? Seems thats where pbr gets the info: http://docs.openstack.org/developer/pbr/#version | 02:15 |
redrobot | hockeynut tags look ok to me http://git.openstack.org/cgit/openstack/barbican/tag/?id=2014.2.b2 | 02:32 |
*** ayoung has quit IRC | 03:13 | |
*** woodster__ has joined #openstack-barbican | 03:49 | |
*** erw_ has joined #openstack-barbican | 03:49 | |
*** jraim__ has joined #openstack-barbican | 03:49 | |
*** codekobe__ has joined #openstack-barbican | 03:50 | |
*** erw has quit IRC | 03:52 | |
*** jraim has quit IRC | 03:52 | |
*** lbragstad has quit IRC | 03:52 | |
*** lisaclark has quit IRC | 03:52 | |
*** jillysciarilly has quit IRC | 03:52 | |
*** woodster_ has quit IRC | 03:52 | |
*** codekobe_ has quit IRC | 03:52 | |
*** xaeth has quit IRC | 03:52 | |
*** lbragstad_ has joined #openstack-barbican | 03:52 | |
*** lbragstad_ is now known as lbragstad | 03:52 | |
*** xaeth_ has joined #openstack-barbican | 03:52 | |
*** jraim__ is now known as jraim | 03:52 | |
*** woodster__ is now known as woodster_ | 03:53 | |
*** erw_ is now known as erw | 03:53 | |
*** jillysciarilly has joined #openstack-barbican | 03:53 | |
*** uberj has quit IRC | 03:53 | |
*** lisaclark has joined #openstack-barbican | 03:53 | |
*** uberj_ has joined #openstack-barbican | 03:53 | |
*** codekobe__ is now known as codekobe_ | 03:53 | |
*** gyee has quit IRC | 03:54 | |
*** lisaclark has quit IRC | 04:07 | |
*** lisaclark has joined #openstack-barbican | 04:08 | |
*** juantwo has quit IRC | 04:40 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/barbican: Imported Translations from Transifex https://review.openstack.org/112764 | 06:10 |
*** jamielennox is now known as jamielennox|away | 06:24 | |
*** woodster_ has quit IRC | 07:25 | |
*** jaosorior has joined #openstack-barbican | 08:54 | |
*** sld has joined #openstack-barbican | 11:16 | |
*** denis_makogon has joined #openstack-barbican | 11:38 | |
denis_makogon | Hey, guys, where can i find docs how to setup Barbican with DevStack? | 11:39 |
sld | denis_makogon: https://wiki.openstack.org/wiki/BarbicanDevStack | 11:42 |
denis_makogon | sld, thanks | 11:42 |
*** alee has quit IRC | 11:54 | |
*** juantwo has joined #openstack-barbican | 12:09 | |
*** juantwo has quit IRC | 12:10 | |
*** juantwo has joined #openstack-barbican | 12:11 | |
*** nkinder has quit IRC | 13:14 | |
*** alee has joined #openstack-barbican | 13:17 | |
*** woodster_ has joined #openstack-barbican | 13:22 | |
woodster_ | all: FYI, the devstack gate is currently unhappy until we add the version property back to setup.cfg via this CR: https://review.openstack.org/#/c/114080/ We should be able to get that merged in this morning... | 13:26 |
*** woodster_ is now known as woodster | 13:29 | |
jaosorior | reviewing | 13:30 |
jaosorior | oh, well, I guess only thing missing is that change from redrobot | 13:31 |
jaosorior | woodster: Any idea on why it's not working on devstack+ | 13:31 |
jaosorior | ? | 13:31 |
jaosorior | By the way, really awesome to see this morning that the cliff CR was merged :D | 13:35 |
*** nkinder has joined #openstack-barbican | 13:59 | |
woodster | jaosorior: that is good news! When do you head off to vacation? | 14:11 |
woodster | jaosorior: no idea why dev stack is breaking | 14:11 |
jaosorior | tomorrow | 14:11 |
jaosorior | Today is my last day in Hungary, and actually my flight is in about 3 hours :P , then tomorrow I fly to Spain | 14:12 |
*** crc32 has joined #openstack-barbican | 14:14 | |
*** crc32 has quit IRC | 14:14 | |
*** crc32 has joined #openstack-barbican | 14:20 | |
*** ayoung has joined #openstack-barbican | 14:24 | |
*** SheenaG1 has joined #openstack-barbican | 14:28 | |
*** SheenaG1 has left #openstack-barbican | 14:31 | |
*** paul_glass has joined #openstack-barbican | 14:37 | |
woodster | jaosorior: that sounds awesome! When do you return from your world tour? | 14:45 |
*** SheenaG1 has joined #openstack-barbican | 14:47 | |
jvrbanac | dstufft, ping | 14:57 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide Adding new files to docs directory to ensure successful build https://review.openstack.org/105488 | 15:00 |
openstackgerrit | Douglas Mendizábal proposed a change to openstack/barbican: Revert remove version from setup.cfg https://review.openstack.org/114080 | 15:07 |
*** atiwari has joined #openstack-barbican | 15:08 | |
rm_work | redrobot: any interesting loonch plans today? | 15:13 |
rm_work | I was considering Erik's | 15:13 |
redrobot | rm_work erik's sounds good. I'm sold. | 15:13 |
rm_work | :P | 15:13 |
rm_work | i'll be heading in soon (early morning irc meeting every thursday, I like to do it from home) | 15:14 |
redrobot | rm_work now that I think of it, I'm leaving early today | 15:14 |
rm_work | ahh | 15:14 |
rm_work | :( | 15:14 |
rm_work | redrobot: so… does that somehow affect lunch plans? :P | 15:15 |
rm_work | i'm not sure I see an immediate connection :P | 15:16 |
redrobot | rm_work hehe... I'm taking a 1/2 PTO, and I got here at 10am, so i gotta work straight thru til 2pm | 15:17 |
rm_work | lol | 15:17 |
woodster | all: please review/approve this CR to fix our devstack gate: https://review.openstack.org/#/c/114080 | 15:19 |
alee | woodster, that fix fixes the gate? | 15:19 |
*** uberj_ is now known as uberj | 15:20 | |
woodster | alee: rm_work observed that this fixed it locally anyway. | 15:21 |
woodster | rm_work: is that correct? | 15:21 |
rm_work | yes | 15:21 |
rm_work | i can swap that line in and out, and it's the difference between devstack starting barbican correctly, and not | 15:21 |
alee | woodster, rm_work - ok then I'll +2/+1 it -- and see what happens :) | 15:21 |
rm_work | also, Jenkins *did* pass it last night, but never posted on the change | 15:21 |
rm_work | but i got the email from it | 15:21 |
rm_work | not sure what was up with Jenkins last night | 15:22 |
alee | rm_work, woodster - done .. | 15:22 |
hockeynut | so do we know for a fact that this is the fix and not a bandaid to the pbr issue? | 15:22 |
woodster | one of these days I'll dig into how devstack deploys barbican, such that it borks pbr's auto-version-discovery | 15:22 |
woodster | there's no harm in specifying the version, but we do have to manually bump the version across openstack release cycles | 15:23 |
rm_work | hockeynut: no? :) | 15:23 |
rm_work | woodster: i could maybe look at it today a bit, wish i hadn't spent an hour or two last night chasing ghosts because my devstack install was a day out of date >_< | 15:24 |
rm_work | i've set it up to re-image and auto-setup devstack every day now, lol | 15:24 |
hockeynut | once devstack install completes its out of date :-) | 15:24 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide Adding new files to docs directory to ensure successful build https://review.openstack.org/105488 | 15:27 |
*** paul_glass1 has joined #openstack-barbican | 15:31 | |
*** paul_glass has quit IRC | 15:40 | |
woodster | atiwari: are you there? | 15:40 |
atiwari | woodster, yes | 15:40 |
atiwari | working on your comments | 15:40 |
atiwari | whats up? | 15:41 |
openstackgerrit | A change was merged to openstack/barbican: Revert remove version from setup.cfg https://review.openstack.org/114080 | 15:42 |
openstackgerrit | John Vrbanac proposed a change to openstack/barbican: First attempt at adding the symantecssl library https://review.openstack.org/110144 | 15:43 |
woodster | atiwari: oh yes, please take a look at the comments on CR: https://review.openstack.org/#/c/87405/ | 15:46 |
woodster | atiwari: that CR is critical for the certificate work we'd like to have in place, so if possible it would be good to get that ready to go this week | 15:47 |
atiwari | woodster, sure I will try my best :) | 15:47 |
woodster | atiwari: thanks! | 15:47 |
atiwari | sorry I was out for 4 days, that is why got delayed | 15:48 |
woodster | atiwari: ha, that happens in the summer for sure. Hope you had a good time | 15:48 |
atiwari | yes | 15:50 |
openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in https://review.openstack.org/111412 | 15:55 |
atiwari | woodster, one question on https://review.openstack.org/#/c/87405/17/barbican/common/validators.py,cm | 16:02 |
atiwari | do you want to have meta in the request or not? | 16:02 |
atiwari | as per your last comment seem you don't want to have meta in the request schema | 16:03 |
atiwari | is that correct? | 16:03 |
woodster | atiwari: that's correct for the time being. That's because what gets validated in the meta depends on the type | 16:04 |
openstackgerrit | John Vrbanac proposed a change to openstack/barbican: Updating symantec plugin docstrings https://review.openstack.org/114017 | 16:05 |
woodster | atiwari: so for symmetric key generation, the meta needs to look like the secret metadata (hence why I'm suggesting using the secret validator for that type, similar to how the order 'secrets' validation happen now) | 16:05 |
atiwari | woodster, ok | 16:05 |
atiwari | let me fix this | 16:05 |
woodster | atiwari: for certificate generation, this meta will very likely be specific to each CA/plugin, so validation will need to be deferred to those plugins (which will be coming in a future CR). | 16:06 |
atiwari | I will ping you then | 16:06 |
atiwari | ok | 16:06 |
woodster | atiwari: sounds good | 16:10 |
*** ayoung is now known as ayoung_lunch | 16:15 | |
*** samuelbercovici has joined #openstack-barbican | 16:20 | |
openstackgerrit | John Vrbanac proposed a change to openstack/barbican: Removing symantec as a default plugin https://review.openstack.org/114291 | 16:25 |
jvrbanac | redrobot, I rebased https://review.openstack.org/#/c/110144 so that it's passing the gate now. I also added a couple of dependent reviews to address a few comments; including yours. | 16:26 |
*** samuelbercovici has quit IRC | 16:28 | |
jvrbanac | redrobot, i.e. ready to workflow again :D | 16:28 |
*** samuelbercovici has joined #openstack-barbican | 16:29 | |
jvrbanac | alee, I tried to address your comments. Unfortunately, since Symantec doesn't make their API doc public, we really can't link to it :/ | 16:31 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide Adding new files to docs directory to ensure successful build https://review.openstack.org/105488 | 16:33 |
alee | jvrbanac, yeah - I saw that -- makes it hard to review :/ | 16:36 |
*** samuelbercovici has quit IRC | 16:40 | |
woodster | all: the CR to remove tenant/project ID from Barbican URLs is merging in | 16:41 |
*** jaosorior has quit IRC | 16:42 | |
woodster | all: complain loudly if you aren't ready for this... :) | 16:42 |
hockeynut | ^ doing the programmer dance ^ | 16:42 |
woodster | hockeynut: is that a protest dance, with little woodster figurines sporting long needles? | 16:43 |
jvrbanac | alee, unfortunately so. | 16:43 |
hockeynut | nope. its a happy happy joy joy dance. Now I can don't need to run with the patches for that CR | 16:44 |
hockeynut | er, maybe I should rephrase that into English | 16:44 |
hockeynut | no mo matches | 16:44 |
woodster | all: ok...gonna hit the workflow +1...right........now! | 16:44 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide Adding new files to docs directory to ensure successful build https://review.openstack.org/105488 | 16:46 |
rm_work | nice woodster | 17:04 |
rm_work | redrobot: how goes work on that BP? :P | 17:05 |
rm_work | woodster: how does the tenantID removal from the URL affect the pythonclient? | 17:28 |
rm_work | woodster: i now there's a similar parallel CR on the client side to fix it, but how do you coordinate client version < -- > barbican version ? | 17:28 |
rm_work | s/now/know/ | 17:29 |
rm_work | do people just have to know "if using barbican after <commit X> then use client version >=Y, otherwise use version<Y" ? | 17:29 |
hockeynut | oh goodie - another wrench in the versioning works. That a good question. | 17:31 |
rm_work | also, review site down for everyone or just me? | 17:34 |
* rm_work checks isup.me | 17:34 | |
rm_work | hmm, guess it was just a temporary issue, back to working | 17:35 |
rm_work | yeah https://review.openstack.org/#/c/112149/ still needs to merge too | 17:35 |
rm_work | guess I should review it | 17:35 |
rm_work | uhh, why am I not seeing *any* Jenkins comments on reviews anymore?? | 17:39 |
rm_work | even ones that used to be there appear to be missing? | 17:39 |
hockeynut | they have been messing about with the layout | 17:39 |
rm_work | wtf | 17:39 |
hockeynut | 'sactly | 17:39 |
rm_work | i didn't +1 that layout change... >_> | 17:40 |
rm_work | do I need to be paying more attention to openstack/infrastructure ? | 17:40 |
hockeynut | so many things to pay attention to...so little time | 17:40 |
redrobot | rm_work no porgress on BP | 17:41 |
rm_work | redrobot: T_T | 17:41 |
redrobot | rm_work when J3 is released, we'll also release the client sans tenant_id | 17:42 |
hockeynut | looks like devstack gate is still AFU | 17:42 |
hockeynut | 2014-08-14 17:11:50.475 | Running devstack | 17:42 |
hockeynut | 2014-08-14 17:11:50.475 | ... this takes 5 - 8 minutes (logs in logs/devstacklog.txt.gz) | 17:42 |
hockeynut | 2014-08-14 17:28:33.780 | ERROR: the main setup script run by this job failed - exit code: 1 | 17:42 |
rm_work | redrobot: got it, k | 17:43 |
hockeynut | and no barbican logs :-( see http://logs.openstack.org/62/105562/11/gate/gate-barbican-devstack-dsvm/6f767cd/logs/ | 17:43 |
hockeynut | (this is for tsv remove resource ID) | 17:43 |
rm_work | hockeynut: time to check with my devstack install :P | 17:43 |
hockeynut | format c: /s | 17:43 |
hockeynut | in the immortal words of reaperhulk - "computers are terrible" | 17:44 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide https://review.openstack.org/105488 | 17:45 |
rm_work | reaperhulk ++ | 17:45 |
openstackgerrit | A change was merged to openstack/barbican: First attempt at adding the symantecssl library https://review.openstack.org/110144 | 17:45 |
rm_work | lol, commit message still same length, and just removed the second line T_T | 17:46 |
rm_work | brb | 17:46 |
rm_work | wow yeah barbican crashes | 17:47 |
rm_work | i'll refresh my devstack again just to make sure | 17:47 |
hockeynut | bunch of failures to fetch from mirror.rackspace.com - not sure if those are meaningful or expected errors | 17:51 |
hockeynut | Unable to connect to mirror.rackspace.com:http: | 17:52 |
hockeynut | network hiccup? | 17:52 |
*** arun_kant has joined #openstack-barbican | 17:56 | |
*** SheenaG1 has quit IRC | 18:03 | |
woodster | wish devstack would provide more log output | 18:07 |
hockeynut | looks like at the end there is a "worlddump" but I don't see the file anywhere in the set of output files. World dumping... see /opt/stack/new/worlddump-2014-08-14-172833.txt for details | 18:13 |
*** ayoung_lunch has quit IRC | 18:22 | |
rm_work | testing now | 18:33 |
*** SheenaG1 has joined #openstack-barbican | 18:34 | |
rm_work | yeah, don't see any failures here for that patchset | 18:34 |
rm_work | i would... recheck >_> | 18:34 |
rm_work | all functional tests pass as well | 18:40 |
woodster | rm_work: thanks for checking | 18:43 |
woodster | btw, there is a 'Toggle CI' button in the lower left that allows you see the Jenkins results inlined with patch comments/activitiy | 18:47 |
woodster | please review/approve this CR if possible, trying to get our ci/cd workflow working: https://review.openstack.org/#/c/114022/ | 19:08 |
woodster | hockeynut: jinx | 19:09 |
hockeynut | Looks like I got in a nanosecond before you! | 19:09 |
woodster | hockeynut: I guess we are doing concurrency testing for zuul | 19:10 |
hockeynut | must list that on my weekly accomplishments! | 19:10 |
hockeynut | right next to "fed the dog AND the cats" | 19:11 |
woodster | indeed! | 19:26 |
woodster | some Kite love needed: can I get a merge from somebody, anybody?: https://review.openstack.org/#/c/107421/ | 19:27 |
reaperhulk | oh the hacking bump | 19:29 |
reaperhulk | sure | 19:29 |
*** ayoung has joined #openstack-barbican | 19:35 | |
openstackgerrit | A change was merged to openstack/barbican: remove project-id from resource URIs https://review.openstack.org/105562 | 19:47 |
openstackgerrit | Kaitlin Farr proposed a change to openstack/barbican: Adds KMIPSecretStore and unit tests https://review.openstack.org/101582 | 19:50 |
openstackgerrit | A change was merged to stackforge/kite: Bump hacking to version 0.9.2 https://review.openstack.org/107421 | 19:51 |
*** atiwari has quit IRC | 19:53 | |
*** atiwari has joined #openstack-barbican | 19:59 | |
openstackgerrit | A change was merged to openstack/barbican: Refactor secret_store for consistency https://review.openstack.org/113531 | 20:00 |
*** nkinder has quit IRC | 20:04 | |
reaperhulk | woo look at all those merges | 20:05 |
rm_work | heh | 20:05 |
rm_work | so, this is how i'm testing now: | 20:05 |
rm_work | spin new ubuntu vm -> ssh in -> curl -L https://gist.github.com/rm-you/6feacb91182f5c011018/raw/177d447f0bb6b8bce0241a6449802916061fb6c6/setup.sh | bash | 20:06 |
rm_work | that sets it up to be ready to run the functional tests as well | 20:07 |
rm_work | oops, forgot to add the section to install nose and tempest reqs | 20:11 |
rm_work | also that apparently doesn't work when run through bash that way, ah well | 20:17 |
*** nkinder has joined #openstack-barbican | 20:21 | |
*** SheenaG1 has quit IRC | 20:26 | |
rm_work | err also the curl doesn't work | 20:33 |
rm_work | lol | 20:33 |
rm_work | bash <(curl https://gist.github.com/rm-you/6feacb91182f5c011018/raw/12cd6a2bcc079d58dcdee1c3f015e6e8de6b3858/setup.sh) | 20:33 |
openstackgerrit | Paul Kehrer proposed a change to openstack/barbican: change CryptoPluginManager to be instantiated in the module scope https://review.openstack.org/114341 | 20:35 |
rm_work | err, curl -L | 20:36 |
openstackgerrit | Paul Kehrer proposed a change to openstack/barbican: change CryptoPluginManager to be instantiated in the module scope https://review.openstack.org/114341 | 20:37 |
reaperhulk | I hate it so much when I push something and immediately realize I screwed up | 20:37 |
*** ayoung is now known as chicken | 20:39 | |
*** chicken is now known as ayoung | 20:39 | |
jvrbanac | reaperhulk, :D | 20:43 |
rm_work | heh | 20:44 |
*** gregsharek has joined #openstack-barbican | 20:46 | |
*** SheenaG1 has joined #openstack-barbican | 20:52 | |
*** SheenaG1 has quit IRC | 20:56 | |
*** SheenaG11 has joined #openstack-barbican | 20:56 | |
*** akoneru has joined #openstack-barbican | 21:04 | |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide https://review.openstack.org/105488 | 21:17 |
*** gregsharek has left #openstack-barbican | 21:17 | |
woodster | reaperhulk: 3 hanging indents...sound like kite surfing moves to me | 21:17 |
reaperhulk | hah, the fuck, I guess my tox envs were out of date | 21:17 |
reaperhulk | because I ran pep locall :) | 21:18 |
reaperhulk | locally even | 21:18 |
* reaperhulk updates | 21:18 | |
woodster | reaperhulk: almost time to hang 10 out there? | 21:18 |
reaperhulk | close, although the wind is so strong today I might need to consider purchasing a smaller kite | 21:19 |
woodster | another tropical storm moving through maybe? | 21:20 |
reaperhulk | nah, just trade winds are impressive here | 21:21 |
*** rm_you| has joined #openstack-barbican | 21:24 | |
openstackgerrit | Paul Kehrer proposed a change to openstack/barbican: change CryptoPluginManager to be instantiated in the module scope https://review.openstack.org/114341 | 21:24 |
*** rm_you has quit IRC | 21:26 | |
*** alee has quit IRC | 21:29 | |
rm_work | i wonder how hard it'd be to spin my own jenkins that watches barbican changes and runs the tests using my own scripts >_> | 21:34 |
rm_work | it'd give me indications about stuff way faster than the existing dsvm | 21:34 |
rm_work | the spin-up for my devstack VMs is something like ~4m | 21:34 |
*** juantwo has quit IRC | 21:34 | |
rm_work | as opposed to the ~18m the Zuul dsvms take | 21:34 |
openstackgerrit | Kaitlin Farr proposed a change to openstack/barbican: Adds KMIPSecretStore and unit tests https://review.openstack.org/101582 | 21:42 |
*** openstackgerrit has quit IRC | 21:46 | |
*** openstackgerrit has joined #openstack-barbican | 21:47 | |
*** akoneru has quit IRC | 21:49 | |
*** paul_glass1 has quit IRC | 21:56 | |
openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Add more type in order post https://review.openstack.org/87405 | 21:58 |
atiwari | woodster, are you there ? | 22:00 |
woodster | atiwari: yes. I'll take a look at the CR | 22:01 |
atiwari | ok | 22:01 |
woodster | rm_work: we've talked about trying to use something like turbo hipster to loop in our own jenkins gate checks | 22:02 |
rm_work | lol "turbo hipster" | 22:02 |
rm_work | why is "nose" not in barbican's test-requirements.txt | 22:18 |
rm_work | does it only count unit-tests and not include things that would be required to run functional-tests? | 22:18 |
rm_work | I guess that COULD make sense, because the functional tests also require tempest :P | 22:18 |
*** alee has joined #openstack-barbican | 22:21 | |
rm_work | ah yeah and BTW it was the functional-tests that required boto (because tempest requires it) | 22:23 |
rm_work | woodster / chellygel ^^ | 22:23 |
rm_work | from our discussion like, two weeks ago | 22:23 |
*** nkinder has quit IRC | 22:24 | |
woodster | rm_work: test_requirements.txt only includes what is needed to run tox tests, not devstack | 22:51 |
woodster | atiwari: I've added comments to the CR here: https://review.openstack.org/#/c/87405 | 22:51 |
rm_work | ah, yeah | 22:57 |
rm_work | but anyway, the decstack script is all working now, if anyone cares (maybe I should post it on the "devstack quick guide" wiki | 22:58 |
*** juantwo has joined #openstack-barbican | 22:58 | |
*** juantwo has quit IRC | 22:59 | |
*** juantwo has joined #openstack-barbican | 22:59 | |
woodster | rm_work: yes please do, thanks | 23:02 |
rm_work | done | 23:02 |
woodster | ugh, tox breaks with: distutils.errors.DistutilsError: Setup script exited with error: command '/usr/bin/clang' failed with exit status 1 | 23:02 |
rm_work | lol clang | 23:02 |
rm_work | is this on OSX? | 23:02 |
woodster | yep | 23:02 |
rm_work | I had a similar issue before | 23:02 |
rm_work | which version of clang is it | 23:02 |
rm_work | or is this an error you're expecting for some reason? :P | 23:03 |
woodster | definitely not expecting it | 23:03 |
rm_work | ... make a nice fresh pyenv? :P | 23:04 |
rm_work | err, virtualenv | 23:04 |
woodster | mght need to. I think this is lingering issues from my mavericks upgrade | 23:04 |
rm_work | ah you're on mav | 23:04 |
woodster | clang -version craps out | 23:05 |
rm_work | I heard the UPGRADE path was really shitty | 23:05 |
rm_work | it's two -- | 23:05 |
woodster | it wasn't too bad, but I did have trouble getting pyenv and lnking to work again | 23:05 |
rm_work | i stuck to 10.8 because it isn't broken :P | 23:06 |
*** denis_makogon has quit IRC | 23:06 | |
*** denis_makogon has joined #openstack-barbican | 23:06 | |
woodster | I had to update to use chef dk (developer kit) :\ | 23:06 |
rm_work | :/ | 23:06 |
atiwari | woodster, yt? | 23:10 |
woodster | atiwari: yes | 23:10 |
atiwari | woodster, regarding elif comment | 23:10 |
atiwari | why do we want to have it | 23:11 |
atiwari | in schema def we have defined it | 23:11 |
atiwari | line 260 | 23:11 |
atiwari | so anything other than 'key', 'asymmetric',260 | 23:11 |
atiwari | 'certificate' | 23:11 |
atiwari | is not allowed | 23:11 |
atiwari | I can add elif but IMO that is not needed | 23:12 |
woodster | so you mean the final 'else:' block? Well, if someone adds a 4th type to the schema def, but doesn't supply the implementation below, it should raise a not implemented type error. As for the elif blocks before the final else:, it is so you don't check after the if before it is true. So if order_type is 'certificate' and you handle that condition, you | 23:14 |
woodster | should not then call if order_type == 'asymmetric' | 23:14 |
woodster | if the instead have elif order_type == 'asymmetric' that would only be called if order_type wasn't 'certificate' | 23:15 |
atiwari | ok, I will add then | 23:15 |
woodster | thanks for hammering on that | 23:16 |
atiwari | np | 23:16 |
woodster | do the other comments make sense? | 23:16 |
woodster | including Ade's? | 23:17 |
atiwari | looking :) | 23:17 |
*** arun_kant has quit IRC | 23:20 | |
atiwari | woodster, is it OK to throw FeatureNotImplemented on final else? | 23:21 |
*** alee has quit IRC | 23:21 | |
*** jamielennox|away is now known as jamielennox | 23:31 | |
woodster | atiwari: I think that's fine | 23:31 |
woodster | atiwari: I'm heading out of the office now, but will check back a bit later this eve | 23:32 |
*** nkinder has joined #openstack-barbican | 23:33 | |
atiwari | woodster, ok | 23:33 |
atiwari | I will push another patch by then | 23:34 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!