Thursday, 2014-08-14

woodster_rm_work: redrobot that version bump script has nothing to do with de stack or the code00:00
rm_workwoodster_: well00:03
rm_workwoodster_: that change is the difference between barbican not running, and running fine00:03
rm_workin my devstack instance00:03
rm_workwhich I *just* refreshed00:03
rm_workso i'm going to go with "yeah, that version script matters" :P00:04
woodster_Super weird and annoying :/00:04
rm_workyep00:04
rm_workanyway, waiting for Zuul to prove it00:04
rm_workbut, I definitely was able to replicate and verify the issue locally00:05
rm_workheading home, looking forward to Zuul responding :P00:05
woodster_I'm not logged in to gerrit from my phone but that version should be 2014.2 for Juno at least00:05
woodster_Ok thanks for your help (again)00:06
rm_workwell, it should be bumped then, not removed like it was :P00:10
rm_workbut yeah, happy to help00:11
rm_workbbl00:11
openstackgerritConstanze Kratel proposed a change to openstack/barbican: IMaking updates to ck-devguide.xml after tech review Updating dev guide and WADL after tech review and edit Incorporated review comments from John Wood into WADL and devguide Making additional updaotes to dev guide and GS guide to remove references to UTF  https://review.openstack.org/10548800:13
*** atiwari has quit IRC00:16
*** crc32 has quit IRC00:23
*** ravips has quit IRC00:24
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Making updates to ck-devguide.xml after tech review Updating dev guide and WADL after tech review and edit Incorporated review comments from John Wood into WADL and devguide Making additional updaotes to dev guide and GS guide to remove references to UTF-  https://review.openstack.org/10548800:27
woodster_rm_work: pbr synthesizes the version from git tag00:35
woodster_rm_work: that version block should not be needed00:35
rm_you|wtfhmmm00:44
rm_you|wtfwell, Jenkins passed it00:44
rm_you|wtfbut for some reason jenkins can't post on the review00:44
*** rm_you|wtf is now known as rm_you00:44
rm_youso, couldn't tell ya00:44
*** ayoung_is_a_Dad is now known as ayoung01:04
ayoungredrobot, heh...I've been a dad for 8 years.  I was just setting the topic to tell people that I was in Dad mode.  But thanks.01:05
hockeynutredrobot woodster I see the same failure on others now that the pbr change has been merged.  for example: http://logs.openstack.org/44/110144/19/check/gate-barbican-devstack-dsvm/6398c4f/logs/screen-barbican.txt.gz02:12
hockeynutare the git tags kosher?  Seems thats where pbr gets the info: http://docs.openstack.org/developer/pbr/#version02:15
redrobothockeynut tags look ok to me http://git.openstack.org/cgit/openstack/barbican/tag/?id=2014.2.b202:32
*** ayoung has quit IRC03:13
*** woodster__ has joined #openstack-barbican03:49
*** erw_ has joined #openstack-barbican03:49
*** jraim__ has joined #openstack-barbican03:49
*** codekobe__ has joined #openstack-barbican03:50
*** erw has quit IRC03:52
*** jraim has quit IRC03:52
*** lbragstad has quit IRC03:52
*** lisaclark has quit IRC03:52
*** jillysciarilly has quit IRC03:52
*** woodster_ has quit IRC03:52
*** codekobe_ has quit IRC03:52
*** xaeth has quit IRC03:52
*** lbragstad_ has joined #openstack-barbican03:52
*** lbragstad_ is now known as lbragstad03:52
*** xaeth_ has joined #openstack-barbican03:52
*** jraim__ is now known as jraim03:52
*** woodster__ is now known as woodster_03:53
*** erw_ is now known as erw03:53
*** jillysciarilly has joined #openstack-barbican03:53
*** uberj has quit IRC03:53
*** lisaclark has joined #openstack-barbican03:53
*** uberj_ has joined #openstack-barbican03:53
*** codekobe__ is now known as codekobe_03:53
*** gyee has quit IRC03:54
*** lisaclark has quit IRC04:07
*** lisaclark has joined #openstack-barbican04:08
*** juantwo has quit IRC04:40
openstackgerritOpenStack Proposal Bot proposed a change to openstack/barbican: Imported Translations from Transifex  https://review.openstack.org/11276406:10
*** jamielennox is now known as jamielennox|away06:24
*** woodster_ has quit IRC07:25
*** jaosorior has joined #openstack-barbican08:54
*** sld has joined #openstack-barbican11:16
*** denis_makogon has joined #openstack-barbican11:38
denis_makogonHey, guys, where can i find docs how to setup Barbican with DevStack?11:39
slddenis_makogon: https://wiki.openstack.org/wiki/BarbicanDevStack11:42
denis_makogonsld, thanks11:42
*** alee has quit IRC11:54
*** juantwo has joined #openstack-barbican12:09
*** juantwo has quit IRC12:10
*** juantwo has joined #openstack-barbican12:11
*** nkinder has quit IRC13:14
*** alee has joined #openstack-barbican13:17
*** woodster_ has joined #openstack-barbican13:22
woodster_all: FYI, the devstack gate is currently unhappy until we add the version property back to setup.cfg via this CR: https://review.openstack.org/#/c/114080/   We should be able to get that merged in this morning...13:26
*** woodster_ is now known as woodster13:29
jaosoriorreviewing13:30
jaosorioroh, well, I guess only thing missing is that change from redrobot13:31
jaosoriorwoodster: Any idea on why it's not working on devstack+13:31
jaosorior?13:31
jaosoriorBy the way, really awesome to see this morning that the cliff CR was merged :D13:35
*** nkinder has joined #openstack-barbican13:59
woodsterjaosorior: that is good news! When do you head off to vacation?14:11
woodsterjaosorior: no idea why dev stack is breaking14:11
jaosoriortomorrow14:11
jaosoriorToday is my last day in Hungary, and actually my flight is in about 3 hours :P , then tomorrow I fly to Spain14:12
*** crc32 has joined #openstack-barbican14:14
*** crc32 has quit IRC14:14
*** crc32 has joined #openstack-barbican14:20
*** ayoung has joined #openstack-barbican14:24
*** SheenaG1 has joined #openstack-barbican14:28
*** SheenaG1 has left #openstack-barbican14:31
*** paul_glass has joined #openstack-barbican14:37
woodsterjaosorior: that sounds awesome! When do you return from your world tour?14:45
*** SheenaG1 has joined #openstack-barbican14:47
jvrbanacdstufft, ping14:57
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide Adding new files to docs directory to ensure successful build  https://review.openstack.org/10548815:00
openstackgerritDouglas Mendizábal proposed a change to openstack/barbican: Revert remove version from setup.cfg  https://review.openstack.org/11408015:07
*** atiwari has joined #openstack-barbican15:08
rm_workredrobot: any interesting loonch plans today?15:13
rm_workI was considering Erik's15:13
redrobotrm_work erik's sounds good.  I'm sold.15:13
rm_work:P15:13
rm_worki'll be heading in soon (early morning irc meeting every thursday, I like to do it from home)15:14
redrobotrm_work now that I think of it, I'm leaving early today15:14
rm_workahh15:14
rm_work:(15:14
rm_workredrobot: so… does that somehow affect lunch plans? :P15:15
rm_worki'm not sure I see an immediate connection :P15:16
redrobotrm_work hehe... I'm taking a 1/2 PTO, and I got here at 10am, so i gotta work straight thru til 2pm15:17
rm_worklol15:17
woodsterall: please review/approve this CR to fix our devstack gate: https://review.openstack.org/#/c/11408015:19
aleewoodster, that fix fixes the gate?15:19
*** uberj_ is now known as uberj15:20
woodsteralee: rm_work observed that this fixed it locally anyway.15:21
woodsterrm_work: is that correct?15:21
rm_workyes15:21
rm_worki can swap that line in and out, and it's the difference between devstack starting barbican correctly, and not15:21
aleewoodster, rm_work - ok then I'll +2/+1 it -- and see what happens :)15:21
rm_workalso, Jenkins *did* pass it last night, but never posted on the change15:21
rm_workbut i got the email from it15:21
rm_worknot sure what was up with Jenkins last night15:22
aleerm_work, woodster - done ..15:22
hockeynutso do we know for a fact that this is the fix and not a bandaid to the pbr issue?15:22
woodsterone of these days I'll dig into how devstack deploys barbican, such that it borks pbr's auto-version-discovery15:22
woodsterthere's no harm in specifying the version, but we do have to manually bump the version across openstack release cycles15:23
rm_workhockeynut: no? :)15:23
rm_workwoodster: i could maybe look at it today a bit, wish i hadn't spent an hour or two last night chasing ghosts because my devstack install was a day out of date >_<15:24
rm_worki've set it up to re-image and auto-setup devstack every day now, lol15:24
hockeynutonce devstack install completes its out of date :-)15:24
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide Adding new files to docs directory to ensure successful build  https://review.openstack.org/10548815:27
*** paul_glass1 has joined #openstack-barbican15:31
*** paul_glass has quit IRC15:40
woodsteratiwari: are you there?15:40
atiwariwoodster, yes15:40
atiwariworking on your comments15:40
atiwariwhats up?15:41
openstackgerritA change was merged to openstack/barbican: Revert remove version from setup.cfg  https://review.openstack.org/11408015:42
openstackgerritJohn Vrbanac proposed a change to openstack/barbican: First attempt at adding the symantecssl library  https://review.openstack.org/11014415:43
woodsteratiwari: oh yes, please take a look at the comments on CR: https://review.openstack.org/#/c/87405/15:46
woodsteratiwari: that CR is critical for the certificate work we'd like to have in place, so if possible it would be good to get that ready to go this week15:47
atiwariwoodster, sure I will try my best :)15:47
woodsteratiwari: thanks!15:47
atiwarisorry I was out for 4 days, that is why got delayed15:48
woodsteratiwari: ha, that happens in the summer for sure. Hope you had a good time15:48
atiwariyes15:50
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in  https://review.openstack.org/11141215:55
atiwariwoodster, one question on https://review.openstack.org/#/c/87405/17/barbican/common/validators.py,cm16:02
atiwarido you want to have meta in the request or not?16:02
atiwarias per your last comment seem you don't want to have meta in the request schema16:03
atiwariis that correct?16:03
woodsteratiwari: that's correct for the time being. That's because what gets validated in the meta depends on the type16:04
openstackgerritJohn Vrbanac proposed a change to openstack/barbican: Updating symantec plugin docstrings  https://review.openstack.org/11401716:05
woodsteratiwari: so for symmetric key generation, the meta needs to look like the secret metadata (hence why I'm suggesting using the secret validator for that type, similar to how the order 'secrets' validation happen now)16:05
atiwariwoodster, ok16:05
atiwarilet me fix this16:05
woodsteratiwari: for certificate generation, this meta will very likely be specific to each CA/plugin, so validation will need to be deferred to those plugins (which will be coming in a future CR).16:06
atiwariI will ping you then16:06
atiwariok16:06
woodsteratiwari: sounds good16:10
*** ayoung is now known as ayoung_lunch16:15
*** samuelbercovici has joined #openstack-barbican16:20
openstackgerritJohn Vrbanac proposed a change to openstack/barbican: Removing symantec as a default plugin  https://review.openstack.org/11429116:25
jvrbanacredrobot, I rebased https://review.openstack.org/#/c/110144 so that it's passing the gate now. I also added a couple of dependent reviews to address a few comments; including yours.16:26
*** samuelbercovici has quit IRC16:28
jvrbanacredrobot, i.e. ready to workflow again :D16:28
*** samuelbercovici has joined #openstack-barbican16:29
jvrbanacalee, I tried to address your comments. Unfortunately, since Symantec doesn't make their API doc public, we really can't link to it :/16:31
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide Adding new files to docs directory to ensure successful build  https://review.openstack.org/10548816:33
aleejvrbanac, yeah - I saw that -- makes it hard to review :/16:36
*** samuelbercovici has quit IRC16:40
woodsterall: the CR to remove tenant/project ID from Barbican URLs is merging in16:41
*** jaosorior has quit IRC16:42
woodsterall: complain loudly if you aren't ready for this... :)16:42
hockeynut^ doing the programmer dance ^16:42
woodsterhockeynut: is that a protest dance, with little woodster figurines sporting long needles?16:43
jvrbanacalee, unfortunately so.16:43
hockeynutnope.  its a happy happy joy joy dance.  Now I can don't need to run with the patches for that CR16:44
hockeynuter, maybe I should rephrase that into English16:44
hockeynutno mo matches16:44
woodsterall: ok...gonna hit the workflow +1...right........now!16:44
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide Adding new files to docs directory to ensure successful build  https://review.openstack.org/10548816:46
rm_worknice woodster17:04
rm_workredrobot: how goes work on that BP? :P17:05
rm_workwoodster: how does the tenantID removal from the URL affect the pythonclient?17:28
rm_workwoodster: i now there's a similar parallel CR on the client side to fix it, but how do you coordinate client version < -- > barbican version ?17:28
rm_works/now/know/17:29
rm_workdo people just have to know "if using barbican after <commit X> then use client version >=Y, otherwise use version<Y" ?17:29
hockeynutoh goodie - another wrench in the versioning works.  That a good question.17:31
rm_workalso, review site down for everyone or just me?17:34
* rm_work checks isup.me17:34
rm_workhmm, guess it was just a temporary issue, back to working17:35
rm_workyeah https://review.openstack.org/#/c/112149/ still needs to merge too17:35
rm_workguess I should review it17:35
rm_workuhh, why am I not seeing *any* Jenkins comments on reviews anymore??17:39
rm_workeven ones that used to be there appear to be missing?17:39
hockeynutthey have been messing about with the layout17:39
rm_workwtf17:39
hockeynut'sactly17:39
rm_worki didn't +1 that layout change... >_>17:40
rm_workdo I need to be paying more attention to openstack/infrastructure ?17:40
hockeynutso many things to pay attention to...so little time17:40
redrobotrm_work no porgress on BP17:41
rm_workredrobot: T_T17:41
redrobotrm_work when J3 is released, we'll also release the client sans tenant_id17:42
hockeynutlooks like devstack gate is still AFU17:42
hockeynut2014-08-14 17:11:50.475 | Running devstack17:42
hockeynut2014-08-14 17:11:50.475 | ... this takes 5 - 8 minutes (logs in logs/devstacklog.txt.gz)17:42
hockeynut2014-08-14 17:28:33.780 | ERROR: the main setup script run by this job failed - exit code: 117:42
rm_workredrobot: got it, k17:43
hockeynutand no barbican logs :-(  see http://logs.openstack.org/62/105562/11/gate/gate-barbican-devstack-dsvm/6f767cd/logs/17:43
hockeynut(this is for tsv remove resource ID)17:43
rm_workhockeynut: time to check with my devstack install :P17:43
hockeynutformat c: /s17:43
hockeynutin the immortal words of reaperhulk - "computers are terrible"17:44
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide  https://review.openstack.org/10548817:45
rm_workreaperhulk ++17:45
openstackgerritA change was merged to openstack/barbican: First attempt at adding the symantecssl library  https://review.openstack.org/11014417:45
rm_worklol, commit message still same length, and just removed the second line T_T17:46
rm_workbrb17:46
rm_workwow yeah barbican crashes17:47
rm_worki'll refresh my devstack again just to make sure17:47
hockeynutbunch of failures to fetch from mirror.rackspace.com - not sure if those are meaningful or expected errors17:51
hockeynutUnable to connect to mirror.rackspace.com:http:17:52
hockeynutnetwork hiccup?17:52
*** arun_kant has joined #openstack-barbican17:56
*** SheenaG1 has quit IRC18:03
woodsterwish devstack would provide more log output18:07
hockeynutlooks like at the end there is a "worlddump" but I don't see the file anywhere in the set of output files.  World dumping... see /opt/stack/new/worlddump-2014-08-14-172833.txt for details18:13
*** ayoung_lunch has quit IRC18:22
rm_worktesting now18:33
*** SheenaG1 has joined #openstack-barbican18:34
rm_workyeah, don't see any failures here for that patchset18:34
rm_worki would... recheck >_>18:34
rm_workall functional tests pass as well18:40
woodsterrm_work: thanks for checking18:43
woodsterbtw, there is a 'Toggle CI' button in the lower left that allows you see the Jenkins results inlined with patch comments/activitiy18:47
woodsterplease review/approve this CR if possible, trying to get our ci/cd workflow working: https://review.openstack.org/#/c/114022/19:08
woodsterhockeynut: jinx19:09
hockeynutLooks like I got in a nanosecond before you!19:09
woodsterhockeynut: I guess we are doing concurrency testing for zuul19:10
hockeynutmust list that on my weekly accomplishments!19:10
hockeynutright next to "fed the dog AND the cats"19:11
woodsterindeed!19:26
woodstersome Kite love needed: can I get a merge from somebody, anybody?: https://review.openstack.org/#/c/107421/19:27
reaperhulkoh the hacking bump19:29
reaperhulksure19:29
*** ayoung has joined #openstack-barbican19:35
openstackgerritA change was merged to openstack/barbican: remove project-id from resource URIs  https://review.openstack.org/10556219:47
openstackgerritKaitlin Farr proposed a change to openstack/barbican: Adds KMIPSecretStore and unit tests  https://review.openstack.org/10158219:50
openstackgerritA change was merged to stackforge/kite: Bump hacking to version 0.9.2  https://review.openstack.org/10742119:51
*** atiwari has quit IRC19:53
*** atiwari has joined #openstack-barbican19:59
openstackgerritA change was merged to openstack/barbican: Refactor secret_store for consistency  https://review.openstack.org/11353120:00
*** nkinder has quit IRC20:04
reaperhulkwoo look at all those merges20:05
rm_workheh20:05
rm_workso, this is how i'm testing now:20:05
rm_workspin new ubuntu vm -> ssh in -> curl -L https://gist.github.com/rm-you/6feacb91182f5c011018/raw/177d447f0bb6b8bce0241a6449802916061fb6c6/setup.sh | bash20:06
rm_workthat sets it up to be ready to run the functional tests as well20:07
rm_workoops, forgot to add the section to install nose and tempest reqs20:11
rm_workalso that apparently doesn't work when run through bash that way, ah well20:17
*** nkinder has joined #openstack-barbican20:21
*** SheenaG1 has quit IRC20:26
rm_workerr also the curl doesn't work20:33
rm_worklol20:33
rm_workbash <(curl https://gist.github.com/rm-you/6feacb91182f5c011018/raw/12cd6a2bcc079d58dcdee1c3f015e6e8de6b3858/setup.sh)20:33
openstackgerritPaul Kehrer proposed a change to openstack/barbican: change CryptoPluginManager to be instantiated in the module scope  https://review.openstack.org/11434120:35
rm_workerr, curl -L20:36
openstackgerritPaul Kehrer proposed a change to openstack/barbican: change CryptoPluginManager to be instantiated in the module scope  https://review.openstack.org/11434120:37
reaperhulkI hate it so much when I push something and immediately realize I screwed up20:37
*** ayoung is now known as chicken20:39
*** chicken is now known as ayoung20:39
jvrbanacreaperhulk, :D20:43
rm_workheh20:44
*** gregsharek has joined #openstack-barbican20:46
*** SheenaG1 has joined #openstack-barbican20:52
*** SheenaG1 has quit IRC20:56
*** SheenaG11 has joined #openstack-barbican20:56
*** akoneru has joined #openstack-barbican21:04
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide  https://review.openstack.org/10548821:17
*** gregsharek has left #openstack-barbican21:17
woodsterreaperhulk: 3 hanging indents...sound like kite surfing moves to me21:17
reaperhulkhah, the fuck, I guess my tox envs were out of date21:17
reaperhulkbecause I ran pep locall :)21:18
reaperhulklocally even21:18
* reaperhulk updates21:18
woodsterreaperhulk: almost time to hang 10 out there?21:18
reaperhulkclose, although the wind is so strong today I might need to consider purchasing a smaller kite21:19
woodsteranother tropical storm moving through maybe?21:20
reaperhulknah, just trade winds are impressive here21:21
*** rm_you| has joined #openstack-barbican21:24
openstackgerritPaul Kehrer proposed a change to openstack/barbican: change CryptoPluginManager to be instantiated in the module scope  https://review.openstack.org/11434121:24
*** rm_you has quit IRC21:26
*** alee has quit IRC21:29
rm_worki wonder how hard it'd be to spin my own jenkins that watches barbican changes and runs the tests using my own scripts >_>21:34
rm_workit'd give me indications about stuff way faster than the existing dsvm21:34
rm_workthe spin-up for my devstack VMs is something like ~4m21:34
*** juantwo has quit IRC21:34
rm_workas opposed to the ~18m the Zuul dsvms take21:34
openstackgerritKaitlin Farr proposed a change to openstack/barbican: Adds KMIPSecretStore and unit tests  https://review.openstack.org/10158221:42
*** openstackgerrit has quit IRC21:46
*** openstackgerrit has joined #openstack-barbican21:47
*** akoneru has quit IRC21:49
*** paul_glass1 has quit IRC21:56
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Add more type in order post  https://review.openstack.org/8740521:58
atiwariwoodster, are you there ?22:00
woodsteratiwari: yes. I'll take a look at the CR22:01
atiwariok22:01
woodsterrm_work: we've talked about trying to use something like turbo hipster to loop in our own jenkins gate checks22:02
rm_worklol "turbo hipster"22:02
rm_workwhy is "nose" not in barbican's test-requirements.txt22:18
rm_workdoes it only count unit-tests and not include things that would be required to run functional-tests?22:18
rm_workI guess that COULD make sense, because the functional tests also require tempest :P22:18
*** alee has joined #openstack-barbican22:21
rm_workah yeah and BTW it was the functional-tests that required boto (because tempest requires it)22:23
rm_workwoodster / chellygel ^^22:23
rm_workfrom our discussion like, two weeks ago22:23
*** nkinder has quit IRC22:24
woodsterrm_work: test_requirements.txt only includes what is needed to run tox tests, not devstack22:51
woodsteratiwari: I've added comments to the CR here: https://review.openstack.org/#/c/8740522:51
rm_workah, yeah22:57
rm_workbut anyway, the decstack script is all working now, if anyone cares (maybe I should post it on the "devstack quick guide" wiki22:58
*** juantwo has joined #openstack-barbican22:58
*** juantwo has quit IRC22:59
*** juantwo has joined #openstack-barbican22:59
woodsterrm_work: yes please do, thanks23:02
rm_workdone23:02
woodsterugh, tox breaks with: distutils.errors.DistutilsError: Setup script exited with error: command '/usr/bin/clang' failed with exit status 123:02
rm_worklol clang23:02
rm_workis this on OSX?23:02
woodsteryep23:02
rm_workI had a similar issue before23:02
rm_workwhich version of clang is it23:02
rm_workor is this an error you're expecting for some reason? :P23:03
woodsterdefinitely not expecting it23:03
rm_work... make a nice fresh pyenv? :P23:04
rm_workerr, virtualenv23:04
woodstermght need to. I think this is lingering issues from my mavericks upgrade23:04
rm_workah you're on mav23:04
woodsterclang -version   craps out23:05
rm_workI heard the UPGRADE path was really shitty23:05
rm_workit's two --23:05
woodsterit wasn't too bad, but I did have trouble getting pyenv and lnking to work again23:05
rm_worki stuck to 10.8 because it isn't broken :P23:06
*** denis_makogon has quit IRC23:06
*** denis_makogon has joined #openstack-barbican23:06
woodsterI had to update to use chef dk (developer kit) :\23:06
rm_work:/23:06
atiwariwoodster, yt?23:10
woodsteratiwari: yes23:10
atiwariwoodster, regarding elif comment23:10
atiwariwhy do we want to have it23:11
atiwariin schema def we have defined it23:11
atiwariline 26023:11
atiwariso anything other than 'key', 'asymmetric',26023:11
atiwari'certificate'23:11
atiwariis not allowed23:11
atiwariI can add elif but IMO that is not needed23:12
woodsterso you mean the final 'else:' block? Well, if someone adds a 4th type to the schema def, but doesn't supply the implementation below, it should raise a not implemented type error.  As for the elif blocks before the final else:, it is so you don't check after the if before it is true.  So if order_type is 'certificate' and you handle that condition, you23:14
woodstershould not then call if order_type == 'asymmetric'23:14
woodsterif the instead have elif order_type == 'asymmetric' that would only be called if order_type wasn't 'certificate'23:15
atiwariok, I will add then23:15
woodsterthanks for hammering on that23:16
atiwarinp23:16
woodsterdo the other comments make sense?23:16
woodsterincluding Ade's?23:17
atiwarilooking :)23:17
*** arun_kant has quit IRC23:20
atiwariwoodster, is it OK to throw FeatureNotImplemented on final else?23:21
*** alee has quit IRC23:21
*** jamielennox|away is now known as jamielennox23:31
woodsteratiwari: I think that's fine23:31
woodsteratiwari: I'm heading out of the office now, but will check back a bit later this eve23:32
*** nkinder has joined #openstack-barbican23:33
atiwariwoodster, ok23:33
atiwariI will push another patch by then23:34

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!