| atiwari | woodster, there are some test failure due to https://review.openstack.org/#/c/105562/ | 00:19 |
|---|---|---|
| atiwari | I will fix it tomorrow first thing | 00:19 |
| *** atiwari has quit IRC | 00:19 | |
| *** alee has joined #openstack-barbican | 01:14 | |
| *** crc32 has quit IRC | 01:33 | |
| *** woodster has quit IRC | 01:55 | |
| *** woodster_ has joined #openstack-barbican | 02:06 | |
| *** uberj has quit IRC | 03:14 | |
| *** uberj has joined #openstack-barbican | 03:14 | |
| openstackgerrit | Paul Kehrer proposed a change to openstack/barbican: change CryptoPluginManager to be instantiated in the module scope https://review.openstack.org/114341 | 04:36 |
| reaperhulk | circular import fun. let's see what we get out of devstack now | 04:36 |
| woodster_ | https://www.irccloud.com/pastebin/emthSQsv | 04:42 |
| woodster_ | I've been fighting C dependencies with my tox env | 04:43 |
| reaperhulk | what OS? | 04:44 |
| woodster_ | macos, mavericks | 04:45 |
| reaperhulk | do you have the dev tools installed? try looking at /usr/include/ffi/ffi.h | 04:45 |
| reaperhulk | should be present by default | 04:45 |
| rm_work | T_T still fighting that woodster_? | 04:45 |
| rm_work | sad | 04:45 |
| rm_work | what's the full trace of the failure? | 04:45 |
| reaperhulk | I tried installing uwsgi tonight and it reminded me why I hate it | 04:45 |
| reaperhulk | Claiming I don't even have a compiler | 04:45 |
| woodster_ | ha, I reinstalled xcode per a forum entry I saw | 04:46 |
| rm_work | woodster_: I was thinking about reformatting this machine with mavs | 04:46 |
| reaperhulk | why bother, wait a few months and go straight yosemite | 04:46 |
| rm_work | if i do, i will have you to tell me how to fix it I guess :P | 04:46 |
| rm_work | reaperhulk: that's an option too i guess | 04:46 |
| reaperhulk | and then keep up to date in the future because the past sucks! | 04:47 |
| reaperhulk | woodster_ if it's still being weird what happens if you CFLAGS="/usr/include" tox -r -e py27 (or CFLAGS before a pip install if you can replicate without tox's involvement) | 04:48 |
| woodster_ | https://www.irccloud.com/pastebin/wImw7cWF | 04:48 |
| woodster_ | that inline pastebin is pretty cool | 04:48 |
| reaperhulk | so cffi is failing to build because it can't find ffi.h, which is pretty stupid | 04:48 |
| woodster_ | this was all working on mavericks I thought, but might have been fooling my self | 04:48 |
| rm_you| | hmm | 04:49 |
| reaperhulk | it definitely should be. I do all dev on mavericks :) | 04:49 |
| rm_you| | yeah... wonder where it's looking | 04:49 |
| reaperhulk | so, first question, is ffi.h present where I said? | 04:49 |
| reaperhulk | next, what version of pip and setuptools are you running? | 04:49 |
| rm_you| | i may have used brew to install cffi / dev | 04:49 |
| reaperhulk | not required for libffi | 04:49 |
| rm_you| | on mine | 04:49 |
| rm_you| | hmm | 04:49 |
| *** rm_you| is now known as rm_you | 04:50 | |
| reaperhulk | and finally, what happens if you do CFLAGS="/usr/include" pip install -U cryptography | 04:50 |
| reaperhulk | libffi in brew installs in cellar only due to the pre-existence of libffi on OS X | 04:51 |
| reaperhulk | so you have to explicitly link against it (/usr/local/Cellar/libffi) | 04:51 |
| rm_you | interesting | 04:51 |
| reaperhulk | same as the openssl formula and a bunch of other things | 04:51 |
| woodster_ | should be libffi correct? 3.0.13 is the version I see there | 04:52 |
| reaperhulk | in the cellar? That's not relevant for the moment :) | 04:52 |
| reaperhulk | does /usr/include/ffi/ffi.h exist? | 04:52 |
| * reaperhulk is actually working on getting cryptography building against libressl right now | 04:53 | |
| reaperhulk | jerks changed some function signatures | 04:53 |
| reaperhulk | and cffi sucks at handling that | 04:53 |
| woodster_ | /usr/include/ffi/ffi.h does not exist. Yeah libffi is in cellar | 04:54 |
| reaperhulk | weeell interesting | 04:54 |
| reaperhulk | okay do this for me | 04:54 |
| reaperhulk | xcode-select --install | 04:54 |
| reaperhulk | should pop up a dialog, download some stuff, and install it | 04:55 |
| woodster_ | 1.4.1 of pip | 04:55 |
| woodster_ | yes, it is downloading stuff | 04:55 |
| reaperhulk | excellent | 04:56 |
| reaperhulk | once that installs check and see if /usr/include/ffi/ffi.h exists | 04:56 |
| woodster_ | ha, yep I see it now | 04:57 |
| reaperhulk | okay try to compile cryptography now :) | 04:57 |
| woodster_ | https://www.irccloud.com/pastebin/mLbLyfZk | 04:58 |
| reaperhulk | that's fine | 04:59 |
| woodster_ | 2 other 'safely ignored' errors after that one :) | 04:59 |
| reaperhulk | standard cffi BS | 04:59 |
| woodster_ | but it ran to success | 04:59 |
| reaperhulk | yep you should be fine now | 04:59 |
| woodster_ | running tox -e pep8 now... | 05:00 |
| woodster_ | thanks for the help! | 05:00 |
| reaperhulk | np | 05:00 |
| woodster_ | so too much wind brought you back? :) | 05:00 |
| reaperhulk | btw rm_you, probably doing a 0.5.4 tomorrow including crc32a's backports. | 05:00 |
| reaperhulk | I kited for about an hour or so. Feet getting torn up so I came back. Now they're covered in tape, ha | 05:01 |
| reaperhulk | http://cl.ly/X3mB | 05:01 |
| reaperhulk | warning, boring photo of feet. | 05:01 |
| rm_you | reaperhulk: ok cool | 05:01 |
| rm_you | reaperhulk: (the release, not the feet, the feet are average) :P | 05:02 |
| reaperhulk | not sure what the story is on the pyopenssl release, but there's a bug that needs to be fixed so someone is going to push at exarkun a bit | 05:02 |
| rm_you | though we need exarkun to get back so we can actually get the pyopenssl changes in | 05:02 |
| rm_you | yeah | 05:02 |
| rm_you | lol jinx | 05:02 |
| woodster_ | oh wow, so even though board is slick, the pressure with your feet is probably the issue? | 05:02 |
| reaperhulk | There are bindings you put your feet in and the waves can make it choppy so you rub against them | 05:03 |
| woodster_ | rm_you: are you becoming a late nite cryptohead too? Poor life choices are contageous! | 05:03 |
| rm_you | i'm just a standard IRC addict | 05:03 |
| rm_you | can't help myself <_< | 05:03 |
| rm_you | and since i didn't do much today other than get a decent devstack deploy script up... i am looking at the client again | 05:04 |
| rm_you | though our deadlines are now... Kilo :P | 05:04 |
| rm_you | so whatev | 05:04 |
| rm_you | neutron incubator shit happened | 05:04 |
| rm_you | so now we won't get into Juno like we hopes | 05:04 |
| rm_you | *hoped | 05:04 |
| woodster_ | oh man, really? So the pressure is off, or still trying to get your stuff done at least? | 05:06 |
| rm_you | yeah now we're still working but... no code freezes, no rush to merge | 05:07 |
| rm_you | and Kilo is the soonest we could possibly see release of the features :/ | 05:07 |
| reaperhulk | If you stop rushing it won't make it to kilo since that's how openstack works ;) | 05:09 |
| *** juantwo has quit IRC | 05:09 | |
| rm_you | heh | 05:09 |
| woodster_ | yeah, set your milestone 6 months before you expect it landed/used | 05:12 |
| woodster_ | alright folks, I'm heading off to bed. Thanks for you help Paul! | 05:16 |
| reaperhulk | no problem, goodnight | 05:17 |
| rm_you | night | 05:17 |
| reaperhulk | bah, I will look at this more tomorrow. This looks suspiciously like import order dependency, which is super terrible | 05:24 |
| reaperhulk | I hope I'm wrong | 05:24 |
| *** jamielennox is now known as jamielennox|away | 05:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/barbican: Imported Translations from Transifex https://review.openstack.org/112764 | 06:09 |
| *** woodster_ has quit IRC | 07:45 | |
| *** juantwo has joined #openstack-barbican | 12:01 | |
| denis_makogon | Hye, guys, i've did barbican setup using DevStack, and trying to examine API and that's what i get PolicyNotAuthorized: Policy doesn't allow orders:get to be performed. Could someone help? | 12:25 |
| denis_makogon | Also, i've noticed this bug https://bugs.launchpad.net/python-barbicanclient/+bug/1357353 (on fresh new install of Barbican + DevStack) | 12:43 |
| *** russellb is now known as rustlebee | 13:03 | |
| *** nkinder has quit IRC | 13:10 | |
| *** akoneru has joined #openstack-barbican | 13:14 | |
| *** akoneru has quit IRC | 13:18 | |
| *** nkinder has joined #openstack-barbican | 14:00 | |
| *** denis_makogon has quit IRC | 14:36 | |
| *** paul_glass has joined #openstack-barbican | 14:51 | |
| *** atiwari has joined #openstack-barbican | 14:54 | |
| *** atiwari has quit IRC | 15:06 | |
| *** rellerreller has joined #openstack-barbican | 15:13 | |
| *** denis_makogon has joined #openstack-barbican | 15:17 | |
| *** atiwari has joined #openstack-barbican | 15:27 | |
| openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Add more type in order post https://review.openstack.org/87405 | 15:28 |
| openstackgerrit | Tim Kelsey proposed a change to openstack/barbican-specs: blueprint for adding HP Atalla ESKM crypto plugin. https://review.openstack.org/114580 | 15:44 |
| openstackgerrit | Tim Kelsey proposed a change to openstack/barbican-specs: blueprint for adding HP Atalla ESKM crypto plugin. https://review.openstack.org/114580 | 15:46 |
| *** akoneru has joined #openstack-barbican | 16:02 | |
| rm_work | denis_makogon: hmm, i'll have to test the client on my devstack today | 16:10 |
| rm_work | when did you setup the devstack? | 16:11 |
| denis_makogon | rm_work, like few hours ago | 16:11 |
| rm_work | we just fixed something regarding API version yesterday… :/ | 16:11 |
| rm_work | but you must have that if you just did it an hour or two agop | 16:11 |
| denis_makogon | rm_work, everything was made according to https://wiki.openstack.org/wiki/BarbicanDevStack, except the number of enabled services | 16:12 |
| rm_work | k yeah | 16:12 |
| rm_work | (I wrote the script under "Easy Way", btw :P | 16:13 |
| denis_makogon | rm_work, and also, i've modified the policy.json to accept requests from all users | 16:13 |
| rm_work | (yesterday) | 16:13 |
| denis_makogon | rm_work, i saw it, as i can see, in that script was added tempest installation, right? | 16:14 |
| rm_work | yeah | 16:14 |
| rm_work | testing now | 16:14 |
| denis_makogon | rm_work, i'm up to help to fix it =) | 16:14 |
| rm_work | well, i'm also rewriting the entire client this next week anyway :P | 16:15 |
| rm_work | switching from the current method to using objects that you create, set up, and then .save() | 16:15 |
| rm_work | instead of secret_manager.creat(...) | 16:15 |
| rm_work | *create | 16:15 |
| rm_work | it'd be my_secret = Secret() | 16:16 |
| rm_work | secret.payload = ... | 16:16 |
| rm_work | err, my_secret.payload = ... | 16:16 |
| rm_work | my_secret.save() | 16:16 |
| rm_work | at least, I will be once redrobot finishes the bP | 16:16 |
| denis_makogon | rm_work, nice =) | 16:17 |
| denis_makogon | well, i've also noticed that current client doesn't follow common CLI style like other clients do | 16:17 |
| denis_makogon | rm_work, eg. "order create" should be "order-create" | 16:18 |
| denis_makogon | and so on] | 16:18 |
| *** rellerreller has quit IRC | 16:18 | |
| rm_work | yeah, not sure how much we'll be messing with the frontend, but feel free to put those comments on the BP once redrobot gets it posted | 16:19 |
| denis_makogon | rm_work, i've filed a bug-report for that, i wasn't aware about BP being in progress | 16:21 |
| rm_work | it's… not | 16:21 |
| rm_work | he still needs to post it | 16:21 |
| rm_work | which is why you wouldn't have been aware :P | 16:21 |
| denis_makogon | rm_work, hah, sounds amazing =) | 16:22 |
| denis_makogon | rm_work, another question | 16:23 |
| denis_makogon | rm_work, do you plan to add API to query existing algorithms? | 16:23 |
| denis_makogon | algorithms and its modes (like AES and its 5 modes) | 16:24 |
| rm_work | hmm | 16:24 |
| rm_work | that'd be a redrobot question | 16:24 |
| rm_work | I'm just a lackey right now on loan from LBaaS :P | 16:24 |
| redrobot | hiya! | 16:27 |
| rm_work | hmm | 16:27 |
| rm_work | I get "barbican 2.2.1" from --version | 16:27 |
| rm_work | on my devstack install | 16:28 |
| redrobot | denis_makogon we've talked about adding querying capability, but we haven't decided on anything yet | 16:28 |
| redrobot | rm_work I think I may have some time to work on the BP today | 16:28 |
| denis_makogon | rm_work, that's strange | 16:28 |
| denis_makogon | rm_work, how it could be 2.2.1 when actual version is 2.0 https://github.com/openstack/python-barbicanclient/blob/master/setup.cfg#L3 ? | 16:29 |
| rm_work | that's from the server i think? | 16:30 |
| denis_makogon | rm_work, server version is 2014.2 | 16:30 |
| rm_work | though, dunno for sure | 16:30 |
| rm_work | yeah i see that too... | 16:30 |
| redrobot | denis_makogon see tags http://git.openstack.org/cgit/openstack/python-barbicanclient/ | 16:30 |
| rm_work | ah, you do that same tag magic | 16:30 |
| redrobot | we release to PyPI via openstack infra | 16:31 |
| redrobot | by adding a new tag to the git tree | 16:31 |
| denis_makogon | redrobot, true, github releases shows the same | 16:31 |
| rm_work | does that translate through if you use barbicanclient from pypi? | 16:31 |
| rm_work | i'm using the git version | 16:31 |
| rm_work | so it makes sense that mine sees 2.2.1 | 16:31 |
| denis_makogon | sure | 16:31 |
| redrobot | yeah, I think PBR is looking at the latest tag | 16:31 |
| redrobot | not sure what the deal is with the outdated version in the setup.cfg though | 16:32 |
| rm_work | yeah, though PBR is royally meessing up on barbican main tho | 16:32 |
| rm_work | see: your setup.cfg revert :P | 16:32 |
| denis_makogon | will try to install it again | 16:33 |
| denis_makogon | here's my local.conf https://gist.github.com/denismakogon/a5e247502962ccd3201d | 16:34 |
| rm_work | bbiab | 16:35 |
| redrobot | rm_work loonch? | 16:36 |
| denis_makogon | omnomnom time, for sure =) | 16:36 |
| rm_work | redrobot: hmm | 16:36 |
| rm_work | i still am not sure on lunch plans | 16:36 |
| rm_work | saucer got cancelled on me | 16:36 |
| rm_work | need to get ready to like… got to work tho | 16:37 |
| rm_work | if you guys aren't going to lunch until 12:15 or so i'm down, but that's about the soonest i can get in (unless i meet somewhere) | 16:37 |
| denis_makogon | rm_work, trying your "easy way", lets see what it would | 16:45 |
| rm_work | k | 16:48 |
| rm_work | yeah that only gives you essentially barbican and keystone :P | 16:48 |
| rm_work | but it should work | 16:48 |
| rm_work | (when testing I went to /opt/stack/python-barbicanclient to run the barbican command) | 16:49 |
| rm_work | ah and I am going to update that script today to also add some exports to /opt/stack/.bashrc for the endpoints and auth info, forgot to do that oart yesterday | 16:49 |
| rm_work | export OS_TENANT_NAME=admin | 16:50 |
| rm_work | export OS_USERNAME=admin | 16:50 |
| rm_work | export OS_PASSWORD=password | 16:50 |
| rm_work | export OS_AUTH_URL="http://localhost:5000/v2.0/" | 16:50 |
| rm_work | export BARBICAN_ENDPOINT="http://localhost:9311/v1/" | 16:50 |
| rm_work | in the meantime, it's those | 16:50 |
| arunkant | Hi..looking for review on https://review.openstack.org/#/c/110817/ .. | 16:52 |
| rm_work | there, fixed | 16:53 |
| rm_work | redrobot: were you going to lunch? | 16:53 |
| rm_work | and if so, was your loonch going to be somewhere i could meet you? :P otherwise I have no idea | 16:53 |
| *** nkinder has quit IRC | 16:56 | |
| rm_work | redrobot: guessing you've already gone then | 16:57 |
| *** openstackgerrit has quit IRC | 17:02 | |
| *** paul_glass has quit IRC | 17:02 | |
| *** openstackgerrit has joined #openstack-barbican | 17:03 | |
| *** nkinder has joined #openstack-barbican | 17:08 | |
| * rm_work goes to Bigz | 17:08 | |
| openstackgerrit | Kaitlin Farr proposed a change to openstack/barbican: Adds KMIPSecretStore and unit tests https://review.openstack.org/101582 | 17:35 |
| *** paul_glass has joined #openstack-barbican | 17:46 | |
| openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Add more type in order post https://review.openstack.org/87405 | 17:46 |
| SheenaG11 | Hey redrobot, you around? | 19:05 |
| redrobot | SheenaG11 yep, what's up? | 19:05 |
| SheenaG11 | Just wanted to kick https://review.openstack.org/#/c/114580/ up to everyone's attention in case you guys hadn't already taken a look at it | 19:07 |
| SheenaG11 | From the HP crew | 19:07 |
| SheenaG11 | Sorry I'm late to the party | 19:07 |
| reaperhulk | lemme drop a comment on that to explain the jenkins failure I guess | 19:07 |
| SheenaG11 | Hey reaperhulk! I didn't know if you'd be around. | 19:08 |
| SheenaG11 | Are you waiting for my PR to put a -2? | 19:08 |
| reaperhulk | Lying in wait | 19:08 |
| SheenaG11 | GO KITING! | 19:09 |
| SheenaG11 | I'm waiting until you're gone. | 19:09 |
| reaperhulk | At least 2 more hours until I go | 19:10 |
| reaperhulk | Want to see the state of my feet? | 19:10 |
| reaperhulk | What am I saying, of course you do | 19:10 |
| reaperhulk | Who doesn't like to look at feet. | 19:10 |
| reaperhulk | http://cl.ly/X3mB | 19:11 |
| * redrobot knew better than to click on that link... | 19:11 | |
| * redrobot still clicked anyway | 19:11 | |
| reaperhulk | it's not disgusting (unless you dislike feet I guess) | 19:12 |
| reaperhulk | just...lots of tape. | 19:12 |
| *** denis_makogon has quit IRC | 19:12 | |
| *** dmakogon_ has joined #openstack-barbican | 19:13 | |
| redrobot | looks like your right pinky toe is about to give out | 19:13 |
| reaperhulk | haha, actually the tape above that and around the main part of my foot are the biggest issues at the moment | 19:13 |
| reaperhulk | whole top of my right foot is chafed so anything touching hurts | 19:13 |
| SheenaG11 | My legitimate reaction, without filter, was AUGH | 19:16 |
| SheenaG11 | What did you do?! | 19:16 |
| reaperhulk | the bindings on the board eventually start to chafe when you ride around in choppy water and are pushing your feet constantly and bouncing around :) | 19:25 |
| reaperhulk | plus as you get tired your form starts to slip and then things rub more. I really should take a day off but I don't wanna | 19:26 |
| SheenaG11 | You don't like having feet very much, do you? | 19:27 |
| reaperhulk | They should obey me | 19:27 |
| SheenaG11 | They aren't computers... | 19:29 |
| reaperhulk | solaris is currently fighting me tooth and nail | 19:35 |
| reaperhulk | basic things like DNS are ridiculously difficult to configure for some reason | 19:35 |
| SheenaG11 | hey hockeynut are you around? | 19:48 |
| *** nkinder has quit IRC | 20:26 | |
| *** crc32 has joined #openstack-barbican | 20:58 | |
| openstackgerrit | Ade Lee proposed a change to openstack/barbican: Add certificate_manager functionality to dogtag plugin. https://review.openstack.org/114661 | 21:04 |
| *** juantwo has quit IRC | 21:06 | |
| *** paul_glass has quit IRC | 21:11 | |
| rm_work | hey redrobot you around? | 21:16 |
| *** atiwari has quit IRC | 21:16 | |
| redrobot | rm_work yep, what up? | 21:16 |
| rm_work | redrobot: lacking a BP, i'm doing a best-shot at what I think the client should look like (basically a rewrite from scratch) | 21:16 |
| rm_work | is there a reason the barbican Client couldn't be a singleton? | 21:16 |
| redrobot | rm_work I'm workign on the blueprint as we speak | 21:16 |
| rm_work | I guess maybe people will need multiple clients from the same app... | 21:16 |
| rm_work | though it makes it a whole lot cleaner if it is a singleton :P | 21:17 |
| redrobot | cleaner how? | 21:18 |
| redrobot | I don't think any other OS clients work that way | 21:18 |
| rm_work | bleh | 21:18 |
| rm_work | well | 21:18 |
| rm_work | so let's say I want to make a new secret | 21:18 |
| rm_work | my_secret = barbican.secrets.Secret() | 21:18 |
| redrobot | yeah | 21:18 |
| rm_work | my_secret.payload = "some data" | 21:18 |
| rm_work | ... etc | 21:18 |
| redrobot | k | 21:18 |
| rm_work | my_secret.save() | 21:19 |
| rm_work | I either have to pass the Connection or Client or SecretManager or something | 21:19 |
| rm_work | to that object somehow | 21:19 |
| rm_work | if it were a singleton, the object could just... grab it :P | 21:19 |
| openstackgerrit | Sheena Gregson proposed a change to openstack/barbican: Edited docs to improve context https://review.openstack.org/114665 | 21:19 |
| rm_work | (I suppose Singleton in this case is just a less dirty way of saying "global" though <_<) | 21:20 |
| chellygel | ;oooooo | 21:20 |
| SheenaG11 | AHHHHHHHHHHHHHHHHHHHHHH | 21:20 |
| rm_work | lol | 21:20 |
| rm_work | gogo Sheena | 21:20 |
| * rm_work reviews | 21:20 | |
| SheenaG11 | Keep in mind on this one, guys: I'm not trying to fix *all* the problems in the doc | 21:20 |
| redrobot | wtf just happened? | 21:20 |
| SheenaG11 | It's an initial pass to add some sections and improve context | 21:20 |
| chellygel | shit got real! | 21:20 |
| SheenaG11 | DOUG I'M A CODER | 21:21 |
| rm_work | dat XML | 21:21 |
| *** nkinder has joined #openstack-barbican | 21:21 | |
| redrobot | Gonna -2 so fast you won't know what happened | 21:21 |
| rm_work | though yeah, -1 right now cause that won't pass gate :P | 21:22 |
| rm_work | your commit message T_T | 21:22 |
| *** alee is now known as alee_afk | 21:22 | |
| rm_work | unless Barbican's gate doesn't check length on additional lines past the title | 21:22 |
| *** crc32 has quit IRC | 21:22 | |
| *** akoneru has quit IRC | 21:23 | |
| rm_work | hmm | 21:23 |
| rm_work | guess maybe it does on docs | 21:23 |
| SheenaG11 | Lines are too long? | 21:24 |
| SheenaG11 | They're under 80 char per line | 21:24 |
| rm_work | hmm | 21:24 |
| SheenaG11 | Pretty sure. | 21:24 |
| rm_work | I just ran one through wc and got 81 :P | 21:24 |
| SheenaG11 | Looks like I left whitespace everywhere though | 21:24 |
| SheenaG11 | Boooooo | 21:24 |
| SheenaG11 | Okay maybe I can't count | 21:24 |
| rm_work | in the commit message, though like i said apparently Barbican doesn't care | 21:24 |
| rm_work | cause tox is passing it locally O_o | 21:24 |
| rm_work | i got my shit kicked back in neutron for that T_T | 21:25 |
| SheenaG11 | :-( | 21:25 |
| SheenaG11 | I ran my tox tests! | 21:25 |
| rm_work | yep, barbican appears to be more forgiving | 21:25 |
| rm_work | and vim says 80 O_o | 21:26 |
| rm_work | wtf | 21:26 |
| redrobot | rm_work sooooo.... what could we do instead of a global client... ? | 21:27 |
| rm_work | pass the client in :P | 21:27 |
| redrobot | rm_work Maybe instatiation of objects still needs to be done via client? | 21:27 |
| *** crc32 has joined #openstack-barbican | 21:27 | |
| rm_work | maybe | 21:27 |
| rm_work | my_secret = my_conn.secrets.Secret() | 21:27 |
| rm_work | ah and then get is | 21:28 |
| rm_work | my_secret = my_conn.secrets.Secret(secret_ref="blag") | 21:28 |
| redrobot | my_new_secret = barbicanclient.Client(...).secrets.Secret() | 21:28 |
| redrobot | bah... not as pretty | 21:28 |
| rm_work | yep | 21:28 |
| rm_work | you see my dilemma :P | 21:28 |
| rm_work | could also pass it to the save() >_> | 21:28 |
| rm_work | my_secret.save(conn) | 21:29 |
| rm_work | not unheard of | 21:29 |
| chellygel | how do we get around the long lines in xml? | 21:29 |
| rm_work | I've seen things handled that way before | 21:29 |
| rm_work | chellygel: i mean, i think the actual XML is fine :P | 21:29 |
| redrobot | rm_work yeah, I think I prefer that. | 21:29 |
| rm_work | my comment was just about the commit message | 21:29 |
| rm_work | which in neutron they care way too much about, rofl | 21:30 |
| rm_work | i think I like that barbican isn't as snooty | 21:30 |
| rm_work | redrobot: kk | 21:30 |
| redrobot | rm_work how about my_secret = Secret(client=conn) ? | 21:30 |
| rm_work | that also works | 21:30 |
| rm_work | but require it? | 21:31 |
| rm_work | or let them make a secret without a conn | 21:31 |
| redrobot | is there any use in a Secret that can't be saved? | 21:31 |
| rm_work | errr | 21:31 |
| rm_work | funsies? :P | 21:31 |
| * redrobot shrugs | 21:32 | |
| rm_work | unit testing? :) | 21:32 |
| openstackgerrit | Sheena Gregson proposed a change to openstack/barbican: Edited docs to improve context https://review.openstack.org/114665 | 21:32 |
| SheenaG11 | Sorry - re-push to fix the white space | 21:32 |
| SheenaG11 | rm_work: you want me to shorten the commit msg or should I try to see if it'll fly? | 21:32 |
| rm_work | it'll fly | 21:32 |
| redrobot | SheenaG11 nice! I didn't even have to downvote it | 21:33 |
| rm_work | man, i got like 10 lines into this review and remembered how much I hate XML | 21:33 |
| SheenaG11 | I got like 10 lines into writing this shit and remembered how much I hate XML | 21:34 |
| * rm_work does not envy SheenaG11 | 21:34 | |
| reaperhulk | -2 so hard | 21:35 |
| SheenaG11 | NOOOOOO PAULLLLLL | 21:35 |
| rm_work | redrobot: so you think you'll have a draft (of at least one of the object types) by EOD? | 21:35 |
| SheenaG11 | I thought you were gone | 21:35 |
| reaperhulk | I am always lurking in the bushes ready to crush dreams | 21:35 |
| redrobot | rm_work yep... you're welcome to come hover and give input | 21:35 |
| reaperhulk | It's actually my job description | 21:35 |
| rm_work | redrobot: heh I'll just wait for you to pastebin me a draft or something | 21:35 |
| rm_work | I want to get this fleshed out and then see if I already coded what you put in the BP :) | 21:36 |
| redrobot | rm_work well, I was making some good progress until you brought up that client ref :-\ | 21:36 |
| rm_work | lol | 21:36 |
| rm_work | sorry, pesky real life details | 21:36 |
| redrobot | why can't shit just magically work!?! | 21:36 |
| rm_work | this is why I don't think BPs will ever actually look like the final code | 21:36 |
| rm_work | you get halfway into coding it and realize whoever wrote the BP was living in fairy-land | 21:37 |
| reaperhulk | XML diffs are the worst | 21:37 |
| rm_work | s/diffs are/is/ | 21:37 |
| redrobot | the more I think about it, the more I like client.secrets.Secret(...) for both new and get | 21:37 |
| redrobot | despite the ugly | 21:37 |
| rm_work | rofl | 21:38 |
| rm_work | fine | 21:38 |
| rm_work | IDC | 21:38 |
| reaperhulk | SheenaG11, for future reference I'd suggest submitting many smaller separate CRs. (This one is fine for now, but a 1200 line diff is very difficult to review) | 21:38 |
| redrobot | that way you can pass the unsaved Secret around without passing the conn reference around as well | 21:38 |
| rm_work | it's technically only 600 lines of changes or so | 21:38 |
| rm_work | just XML diffs are shitty | 21:38 |
| SheenaG11 | reaperhulk: it's mostly just stuff that got moved down - I didn't actually write that much | 21:39 |
| SheenaG11 | Oh and I deleted A WHOLE BUNCH OF STUFF | 21:39 |
| rm_work | redrobot: yeah, well you can do that with Secret(client=conn) too | 21:39 |
| reaperhulk | SheenaG11: yeah I know, but gerrit's diff tools aren't smart enough to identify moves so there's a lot of noise due to the moves | 21:39 |
| redrobot | rm_work yeah, but then instantiation would be different than getting existing objects | 21:40 |
| rm_work | well | 21:40 |
| redrobot | rm_work unless we want to do Secret(client=conn, ref="http://blah") | 21:40 |
| rm_work | Secret(client=conn) vs Secret(client=conn, secret_ref="blah") | 21:40 |
| rm_work | jinx | 21:40 |
| redrobot | need a tie breaker here | 21:40 |
| SheenaG11 | reaperhulk: fair enough | 21:41 |
| rm_work | like I said, i honestly don't care either way | 21:41 |
| SheenaG11 | reaperhulk: sorry for the gigantor CR :-( | 21:41 |
| reaperhulk | SheenaG11: not really a big issue this time around, just something to note for the future | 21:41 |
| redrobot | I suppose client.secrets.Secret() is more in-line with other OS clients? | 21:41 |
| * reaperhulk -2s it | 21:41 | |
| reaperhulk | just kidding | 21:41 |
| rm_work | SheenaG11: no, you have to redo the whole thing. REDO IT. | 21:41 |
| redrobot | though not quite | 21:41 |
| SheenaG11 | Noooooooooooooooooooo | 21:41 |
| rm_work | moar XML pain for sheena | 21:41 |
| rm_work | redrobot: could be, need to look | 21:42 |
| rm_work | we model after keystone right now, right? | 21:42 |
| redrobot | rm_work yep | 21:42 |
| SheenaG11 | rm_work: I didn't even get any cake! | 21:42 |
| rm_work | T_T | 21:42 |
| chellygel | +1 no cake, wtf | 21:42 |
| rm_work | yeah sad | 21:42 |
| chellygel | :P | 21:42 |
| rm_work | you and chellygel were OoO | 21:42 |
| rm_work | very sad | 21:42 |
| chellygel | ha | 21:43 |
| redrobot | don't worry SheenaG11 and chellygel. I ate y'alls pieces for you. | 21:43 |
| redrobot | you're welcome | 21:43 |
| rm_work | chellygel still has a lunch IOU tho | 21:43 |
| * chellygel dances | 21:43 | |
| redrobot | I hear chellygel is a huge fan of Erick's | 21:43 |
| rm_work | hah | 21:43 |
| rm_work | yeah I need to do that next week | 21:43 |
| chellygel | gerrit sucks -- its showing whitespace on her stuff when she has none there | 21:43 |
| chellygel | wtf wtf wtf | 21:43 |
| rm_work | it has been way too long, keep missing people going | 21:44 |
| rm_work | need one of those things... that I can never remember the name of... the torta with the red sauce | 21:44 |
| chellygel | lets go to erick's next week, we'll drag 2-pieces-of-cake- redrobot | 21:44 |
| chellygel | 3* :P | 21:44 |
| reaperhulk | if he ate both of your pieces he ate 3 pieces | 21:44 |
| reaperhulk | haha | 21:44 |
| chellygel | um you need to /nick bigredrobot | 21:45 |
| chellygel | ;) | 21:45 |
| reaperhulk | yeah man can't put on all that weight until AFTER the wedding | 21:45 |
| chellygel | oh, yeah /nick bigengagedredrobot | 21:45 |
| rm_work | bleh keystone doesn't really HAVE objects | 21:46 |
| rm_work | so | 21:46 |
| rm_work | not sure this is really a useful model | 21:46 |
| redrobot | PAMBAZOOOOOO! | 21:47 |
| rm_work | ah yeah that | 21:47 |
| rm_work | keystone API does what current barbicanclient does | 21:47 |
| rm_work | err, keystoneclient | 21:47 |
| rm_work | so we would need to look at something else as an example | 21:48 |
| redrobot | yep... I wonder what the openstacksdk folks are doing? | 21:48 |
| * redrobot is Shreddin' for the Weddin' | 21:50 | |
| redrobot | or should be anyway... that was the plan | 21:50 |
| SheenaG11 | redrobot: you going to start working out with codekobe_ and jraim? | 21:55 |
| redrobot | SheenaG11 They did extend me an invite... the gym is way out of my way, and they meet at obscenely early in the day though... I dunnno, still debating. | 21:56 |
| SheenaG11 | It sounds like a party! jraim is swimming in his tee shirts now | 22:03 |
| openstackgerrit | Douglas Mendizábal proposed a change to openstack/barbican-specs: Refactor Client Entity Models https://review.openstack.org/114677 | 22:09 |
| redrobot | rm_work ^^ have at it | 22:09 |
| *** akoneru has joined #openstack-barbican | 22:10 | |
| SheenaG11 | redrobot: you can come yoga with me | 22:13 |
| SheenaG11 | I took chellygel today | 22:13 |
| SheenaG11 | It was HARDCORE | 22:13 |
| redrobot | SheenaG11 at the REC? | 22:13 |
| SheenaG11 | Ha, no - I don't drive down for that | 22:13 |
| SheenaG11 | She's up in AUS today | 22:13 |
| chellygel | dude, chellygel was dying in yoga | 22:14 |
| *** nkinder has quit IRC | 22:14 | |
| chellygel | chellygel couldn't hold her own weight | 22:14 |
| chellygel | lol | 22:14 |
| *** nkinder has joined #openstack-barbican | 22:14 | |
| redrobot | chellygel but you weigh like nothing... o_O | 22:15 |
| rm_work | redrobot: lol that is way more bare-bones than I thought | 22:15 |
| chellygel | thats how week i am | 22:15 |
| chellygel | weak** | 22:15 |
| chellygel | also stupid | 22:15 |
| rm_work | T_T | 22:15 |
| * rm_work can do like ... one pull-up / push-up | 22:16 | |
| rm_work | wtf, our client is throwing an exception that enters into site-packages/keystoneclient/openstack/common/apiclient/exceptions.py | 22:17 |
| rm_work | and it's totally broken | 22:18 |
| rm_work | we don't handle our own exception code? >_> | 22:18 |
| rm_work | ah it's because we wrap our session with a keystone session | 22:18 |
| rm_work | so their exception handling kicks in <_< | 22:19 |
| rm_work | and is broken for our app, obviously, since we don't format our JSON responses the same as they do | 22:19 |
| rm_work | not sure how to deal with this | 22:19 |
| rm_work | our POST looks like: resp = self._session.post(url, data=json.dumps(data), headers=headers) | 22:20 |
| rm_work | _session is a keystone session | 22:20 |
| rm_work | so when the post fails with like, a JSON schema error... | 22:20 |
| rm_work | for instance, expiration date in the past | 22:20 |
| rm_work | the exception gets caught and handled by keystone's exception handlers, which expect a very different response structure, so THAT breaks and the resulting error message is totally unhelpful and meaningles | 22:21 |
| rm_work | *s | 22:21 |
| redrobot | rm_work so we want to remove our auth layer entirely | 22:21 |
| redrobot | rm_work and while we're refactoring the whole thing, we shoudl fix this. :D | 22:21 |
| rm_work | T_T_T_T_T | 22:21 |
| rm_work | redrobot: you know what scope creep is, right? | 22:21 |
| rm_work | because my scope was "use containers" | 22:22 |
| rm_work | and now it is "rewrite python-barbicanclient" | 22:22 |
| redrobot | it's what happens to the guy who's on loan :D | 22:22 |
| rm_work | lol | 22:22 |
| redrobot | I'd love to do it myself... but SheenaG11 won't give me the jira points :-P | 22:22 |
| rm_work | heh | 22:22 |
| rm_work | well I started with a 5-point this week | 22:23 |
| rm_work | err, this Sprint | 22:23 |
| rm_work | I've adjusted it to 20 T_T | 22:23 |
| rm_work | our sprint burn-down is more like a burn-up | 22:23 |
| rm_work | well, it was 13 until just now | 22:23 |
| rm_work | NOW it's 20 | 22:24 |
| rm_work | I'm going to... | 22:24 |
| rm_work | leave this alone for now | 22:24 |
| rm_work | and not pass invalid expiration dates :P | 22:24 |
| SheenaG11 | That SheenaG11 is a taskmaster | 22:31 |
| SheenaG11 | I tell you what | 22:31 |
| rm_work | redrobot: is there a better pattern than this: | 22:38 |
| rm_work | @name.setter | 22:39 |
| rm_work | def name(self, value): | 22:39 |
| rm_work | self._check_mutable() | 22:39 |
| rm_work | self._name = value | 22:39 |
| rm_work | @property | 22:39 |
| rm_work | def name(self): | 22:39 |
| rm_work | return self._name | 22:39 |
| rm_work | that's what my first pass looks like... | 22:39 |
| rm_work | for like, every attribute | 22:39 |
| redrobot | looks legit to me... | 22:39 |
| rm_work | k... | 22:39 |
| redrobot | rm_work look at that BP | 22:39 |
| rm_work | was wondering if maybe there was some cleaner magic to do that | 22:40 |
| redrobot | rm_work DO IT! | 22:40 |
| rm_work | redrobot: CLEANROOM | 22:40 |
| rm_work | CLEANROOOOOOOOM | 22:40 |
| rm_work | but yeah, i looked at it | 22:40 |
| rm_work | looks bare-bones, and exactly like what I was doing | 22:40 |
| rm_work | you didn't really dip into specifics much :P | 22:40 |
| redrobot | rm_work http://chimera.labs.oreilly.com/books/1230000000393/ch08.html#_problem_128 | 22:43 |
| redrobot | rm_work can't remember if that'll work on 2.x though | 22:43 |
| rm_work | I will try it out | 22:43 |
| rm_work | I mean, properties are ostensibly FOR this | 22:43 |
| rm_work | like, this exact scenario | 22:44 |
| rm_work | it's just very verbose | 22:44 |
| rm_work | i'll pastebin you the secrets class in a sec and see what you think | 22:45 |
| redrobot | better make it quick, because my GTFO ETO is 15 min | 22:45 |
| rm_work | lol k | 22:45 |
| rm_work | very close | 22:45 |
| chellygel | eto? lol | 22:46 |
| rm_work | ETA :P | 22:47 |
| redrobot | whatever.... the GTFO part is what matters :-P | 22:48 |
| chellygel | go vote on reviews for 15 min or something | 22:48 |
| chellygel | -1's all the way down | 22:48 |
| rm_work | redrobot: how long do I have? | 22:57 |
| rm_work | was trying to finish my get() impl | 22:57 |
| redrobot | 2 min | 22:58 |
| rm_work | lolk | 22:58 |
| *** juantwo has joined #openstack-barbican | 23:01 | |
| redrobot | too late holmes | 23:02 |
| rm_work | lololol | 23:02 |
| rm_work | here | 23:02 |
| rm_work | I can give you this as is | 23:02 |
| redrobot | Just upload as WIP and I'll review it when I get a chance | 23:02 |
| rm_work | https://gist.github.com/rm-you/5974777f0b49c9239c45 | 23:03 |
| rm_work | redrobot: ^^^^^ | 23:03 |
| redrobot | #NOPE | 23:03 |
| rm_work | ffffffuuuuuuuuuuuuuu | 23:03 |
| *** ayoung has quit IRC | 23:06 | |
| *** juantwo has quit IRC | 23:27 | |
| *** juantwo has joined #openstack-barbican | 23:28 | |
| openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: :Incorporated review comments from John Wood into WADL and devguide https://review.openstack.org/105488 | 23:29 |
| rm_work | woo, -1'd redrobot's BP :P | 23:49 |
| * rm_work doesn't actually -1 that often | 23:49 | |
| *** akoneru has quit IRC | 23:50 | |
| openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Incorporated review comments from John Wood into WADL and devguide https://review.openstack.org/105488 | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!