Thursday, 2014-08-21

« Wednesday, 2014-08-20 Index Friday, 2014-08-22 »
openstackgerritArun Kant proposed a change to openstack/barbican: Adding keystone notification listener support  https://review.openstack.org/11081700:14
openstackgerritArun Kant proposed a change to openstack/barbican: Adding keystone notification listener support  https://review.openstack.org/11081700:17
*** gyee_ has quit IRC00:21
*** bdpayne has quit IRC00:50
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Removed references to  tenant id/project id from docs and samples  https://review.openstack.org/10548801:14
rm_workGAH01:18
rm_workffff01:18
rm_workwoodster_: T_T01:18
rm_workhttps://review.openstack.org/#/c/87405/ broke Orders01:19
rm_workbarbican/barbican/plugin/store_crypto.py01:20
rm_workhttps://github.com/openstack/barbican/blob/cabe936ce189c4f85fc2432673660ba3d4c70b76/barbican/plugin/store_crypto.py#L17001:21
rm_workbetter view: https://github.com/openstack/barbican/blame/master/barbican/plugin/store_crypto.py#L17001:21
rm_workNo such method in KeyAlgorithm: https://github.com/openstack/barbican/blob/master/barbican/plugin/interface/secret_store.py#L17001:22
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Removed references to  tenant id/project id from docs and samples  https://review.openstack.org/10548801:22
rm_workfiled a bug: https://bugs.launchpad.net/barbican/+bug/135948101:24
rm_workNot 100% sure how to fix this one yet, as I'm not sure what is happening01:24
rm_workugh, I will let atiwari fix it >_<01:27
rm_workgoing home for now01:27
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient  https://review.openstack.org/11508001:37
*** woodster_ has quit IRC01:55
*** bdpayne has joined #openstack-barbican02:01
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient  https://review.openstack.org/11339302:09
rm_workok I lied02:09
rm_workNOW i'm going home <_<02:10
reaperhulkrm_work: You are correct, I removed my -102:27
reaperhulkclearly I should learn to read02:28
*** rm_you| is now known as rm_you02:41
rm_youheh02:41
rm_youi guess i need to learn how to search too, since my latest bug report was a dupe02:41
rm_youthough in my defense, i do not understand how i would be expected to find the original, given the very non-descriptive title >_>02:42
rm_youarunkant: >_>02:42
rm_youmy bug title: "Orders broken, KeyAlgorithm has no `supports()` method"02:42
rm_youoriginal bug title: "Orders broken, KeyAlgorithm has no `supports()` method"02:42
rm_youerr02:43
rm_youoriginal bug title: "Recent merge has function missing or referred incorrectly"02:43
rm_youalso there IS a bug on that change in the delete() section, but it's that since headers = {}, the prepare_auth does nothing02:52
rm_youI changed it in my recent patch02:52
rm_youhttps://review.openstack.org/#/c/113393/3/barbicanclient/client.py   Line 16002:53
rm_youstill makes sure it's not a None02:53
*** kebray has joined #openstack-barbican03:59
*** juantwo has quit IRC04:36
rm_workugh sprint planning tomorrow, going to lose a bunch of perfectly good coding time05:16
*** bdpayne has quit IRC05:18
*** kebray has quit IRC05:20
*** bdpayne has joined #openstack-barbican05:25
*** kebray has joined #openstack-barbican05:27
*** akoneru has quit IRC06:07
*** bdpayne has quit IRC06:20
*** samuelbercovici has quit IRC08:28
*** mikedillion has joined #openstack-barbican11:18
*** mikedillion has quit IRC11:35
*** alee has quit IRC11:47
*** juantwo has joined #openstack-barbican12:06
*** SheenaG1 has joined #openstack-barbican12:19
*** SheenaG11 has joined #openstack-barbican12:23
*** SheenaG1 has quit IRC12:23
*** woodster_ has joined #openstack-barbican12:28
*** xianghuihui has joined #openstack-barbican13:06
*** xianghui has quit IRC13:09
*** xianghuihui has quit IRC13:13
*** alee has joined #openstack-barbican13:14
*** nkinder has quit IRC13:20
*** openstackgerrit has quit IRC13:21
*** akoneru has joined #openstack-barbican13:39
*** jamielennox is now known as jamielennox|away13:48
*** paul_glass has joined #openstack-barbican13:55
*** paul_glass1 has joined #openstack-barbican13:56
*** rm_mobile has joined #openstack-barbican13:59
*** openstackgerrit has joined #openstack-barbican13:59
*** paul_glass has quit IRC14:00
*** samuelbercovici has joined #openstack-barbican14:00
*** nkinder has joined #openstack-barbican14:05
*** crc32 has joined #openstack-barbican14:08
*** akoneru has quit IRC14:09
*** crc32 has quit IRC14:19
*** akoneru has joined #openstack-barbican14:22
rm_workneed some love on https://review.openstack.org/#/c/112149/ and https://review.openstack.org/#/c/115819/14:34
jvrbanacrm_work, I'll take a look in a few14:36
*** dmakogon_ is now known as denis_makogon14:40
*** samuelbercovici has quit IRC14:41
rm_workthanks jvrbanac14:42
*** rm_mobile has quit IRC14:42
*** samuelbercovici has joined #openstack-barbican14:42
*** ayoung has quit IRC14:55
*** rm_mobile has joined #openstack-barbican15:02
*** ayoung has joined #openstack-barbican15:03
*** mikedillion has joined #openstack-barbican15:05
rm_mobileredrobot,  woodster_: ^^15:10
woodster_rm_mobile: already done :)15:11
*** samuelbercovici has quit IRC15:12
*** paul_glass has joined #openstack-barbican15:16
*** paul_glass1 has quit IRC15:19
*** bdpayne has joined #openstack-barbican15:21
*** akoneru has quit IRC15:25
rm_mobileSweet15:29
rm_mobileStuck in sprint planning T_T15:29
rm_mobileThis one? https://review.openstack.org/#/c/115713/15:30
rm_mobileredrobot,  woodster_: ^^15:31
rm_mobileMerge plz :P15:32
woodster_rm_mobile: the two CRs you last mentioned above15:32
rm_mobileGuess I forgot that one15:32
*** akoneru has joined #openstack-barbican15:38
*** bdpayne has quit IRC15:38
*** arun_kant has joined #openstack-barbican15:48
*** denis_makogon has quit IRC15:50
rm_mobileSo, Orders are broken until we merge https://review.openstack.org/#/c/115713/15:54
* rm_mobile will probably just mention that every ten minutes or so until it merges15:54
*** mikedillion has quit IRC15:58
*** gyee_ has joined #openstack-barbican15:59
*** kebray has joined #openstack-barbican15:59
*** mikedillion has joined #openstack-barbican16:00
*** bdpayne has joined #openstack-barbican16:04
aleewoodster_, jvrbanac  - had a chance to look at https://review.openstack.org/#/c/114661/ ?16:11
aleewoodster_, jvrbanac - would like to get that one in soon as it will form the basis of another patch to add asym key generation to dogtag plugin, and also for updating supports16:13
woodster_alee: will do16:13
aleewoodster_, thanks -- I'm working right now with your initial cert/orders patch16:14
woodster_alee: thanks!16:14
aleewoodster_, do you have any updates on that or should I continue as is?16:14
aleewoodster_, are you working on crs to add the plugin/metadata associations? or is that something I should do?16:15
woodster_all: btw, today is the spec freeze for Juno blueprints16:15
woodster_alee: I meant to ask about that...we can do that work today if that helps you out16:16
aleewoodster_, sure - that will help.  You guys will probably be able to whip that out pretty quickly.16:17
woodster_alee: I think so16:17
*** kebray has quit IRC16:17
aleewoodster_,  I'm out tomorrow unfortunately -- daycare decided that they needed a teacher workday16:18
aleewoodster_, we should try to get arvinds patch in soon too.16:19
aleewoodster_, https://review.openstack.org/#/c/111412/1116:19
woodster_rm_mobile, alee: my CR here scrubs the revised orders flow as well, for both the legacy and new type/meta order types: https://review.openstack.org/#/c/115715/16:22
aleewoodster_,  thanks for +2 for https://review.openstack.org/11466116:27
aleeany more +2's out there?16:27
rm_mobilewoodster_: so does that invalidate https://review.openstack.org/#/c/115713/16:34
rm_mobile?16:34
*** kebray has joined #openstack-barbican16:46
woodster_alee, atiwari: (in case you are bouncing), I've added a comment to the asymmetric CR to that should help fix the broken tests out there: https://review.openstack.org/#/c/11141216:46
woodster_rm_mobile: I don't think so...I would like to rebase my CR to yours once it lands16:46
aleewoodster_, atiwari - I still dont see the dto object I'm suggesting16:46
aleein arvind's patch.16:47
openstackgerritA change was merged to openstack/barbican-specs: Refactor Client Entity Models  https://review.openstack.org/11467716:47
woodster_redrobot, jvrbanac: Please approve/merge this CR: https://review.openstack.org/#/c/115713/16:47
aleewoodster_, did you see the comments I made about returning a dto object , rather than a tuple of dicts?16:47
woodster_alee: oh, instead of the tuple of dicts in the response now, correct?16:48
aleewoodster_, yes16:48
aleewoodster_, see my comment on patch set 816:49
redrobotwoodster_ can this change be tested via unit test?16:50
*** kebray has quit IRC16:50
aleewoodster_, I think rm_mobile question has to do with the fact that both your latest cr and https://review.openstack.org/#/c/115713/ change the same code in store_crypto.py in different ways.16:50
* redrobot should probably read more code for context >_>16:50
*** kebray has joined #openstack-barbican16:51
*** tkelsey has joined #openstack-barbican16:51
*** tkelsey has quit IRC16:51
woodster_alee, rm_mobile: My CR went in before that get_secret_type() method on KeyAlgorithm, so rm_mobile's CR is better to use. I just reverted the code back to the old way just to get tests/server flows to work again.16:52
aleewoodster_, yup - thats what I figured.16:53
rm_mobilehttps://review.openstack.org/#/c/115713/ isn't mine actually16:53
woodster_alee, rm_mobile, atiwari: ha, sorry, I didn't realize that CR was Arvind's!16:53
rm_mobileIt's atiwari's16:53
rm_mobileYeah I just happen to be pushing it lol16:53
woodster_I was wondering how/why you +1-ed your own CR :)16:53
rm_mobileTwo of the CRs I'm pushing now aren't mine16:54
woodster_rm_mobile: I need to hire you to promote my CRs!16:54
aleeme too ..16:54
*** alee is now known as alee_lunch16:58
rm_mobileHeh16:59
rm_mobileI can be... Persistent16:59
openstackgerritA change was merged to openstack/python-barbicanclient: remove tenant-id from uri  https://review.openstack.org/11214916:59
rm_mobileWoot16:59
*** paul_glass has quit IRC17:05
rm_mobilehttps://review.openstack.org/#/c/115713/ just missing workflow :)17:09
*** atiwari has joined #openstack-barbican17:10
atiwariwoodster_, yt?17:11
woodster_atiwari: yes17:11
atiwariregarding https://review.openstack.org/#/c/111412/11/barbican/plugin/resources.py17:11
atiwariI think we have agreed on tuple of dics17:11
atiwariand Ade is also sync on that17:12
woodster_this was regarding Ade's comment on patch 8, about adding a DTO to hold these dicts for a bit of future proofing17:12
woodster_alee: are you there?17:12
woodster_I see alee_lunch up there, so might have to wait a little bit. Is patch 8 comments are advocating for a DTO though I thought17:13
atiwariI am ok with dto17:14
woodster_atiwari: sorry, patch 6 comments17:14
atiwariwoodster_, np, I had a chat with him and he likes the tuple17:14
atiwaribut let me fix it DTO way, which I like too17:14
atiwariwhat do you say?17:14
woodster_atiwari: Oh I got it. Why did he change his mind though?17:15
atiwariI was returning dict of dicts and then he want it tuple way17:15
woodster_atiwari: did the testing comments I made make sense? The code change from under the CR, but I think that should fix things.17:16
woodster_atiwari: Did you talk to Ade today about the DTO vs tuple return?17:16
atiwariI will see , did not looked at it17:16
atiwarino, some time back17:16
atiwariwoodster_, I think I did not see his comment on https://review.openstack.org/#/c/111412/6/barbican/plugin/interface/secret_store.py17:18
atiwariabout DTO17:18
woodster_atiwari: well, I guess no harm in returning a DTO with those 3 dicts inside of it. Please let me know if that testing error still is biting you. The patching thing was tricky for me anyways....17:18
atiwarinp,17:19
atiwarilet me make the changes17:19
woodster_atiwari: I see his comments on line 32217:19
atiwarisorry for confusion17:19
woodster_atiwari: ...of https://review.openstack.org/#/c/111412/6/barbican/plugin/interface/secret_store.py,cm17:19
atiwariyes, but latest on is in favor of DTO :)17:20
woodster_atiwari: are those comments showing up on your view?17:20
atiwarithat means I have sale information :)17:20
atiwariyes17:20
woodster_atiwari: yep, so a change for the DTOs should be good17:20
atiwariagreed17:20
atiwariI will make changes17:20
atiwariwoodster_, question on certificate stuff17:21
woodster_atiwari: sure17:21
atiwariwho is implementing REST side of it?17:21
woodster_chellygel and I were going to take a look at that17:22
atiwariI am asking because Stan is thinking of that https://review.openstack.org/#/c/108429/17:22
woodster_that BP is trying to refine the name/values passed into the orders request at POST time. Discussions we've had lately have talked about refining this for Kilo during the design summit. So essentially trying to tease out non-vendor-specific CSR type data from vendor specific stuff. For Juno, we are just going to pass up data specific to the plugin assuming17:29
woodster_only one plugin is enabled for a deployment. So for Juno, we are testing the waters with the impl. For Kilo it will be refined.17:29
woodster_atiwari: does that make sense?17:29
atiwariwoodster_, sure . that means https://review.openstack.org/#/c/108429/ can be a K candidate ?17:31
atiwaris/can/will17:31
woodster_atiwarI: That's what I'm thinking, but Stanislaw hasn't weighed in on comments out there.17:32
atiwariI will let him know, he is in UK17:32
woodster_thanks!17:32
*** kebray has quit IRC18:03
*** mikedillion has quit IRC18:05
openstackgerritArun Kant proposed a change to openstack/barbican: Adding keystone notification listener support  https://review.openstack.org/11081718:06
*** SheenaG11 has quit IRC18:07
*** kebray has joined #openstack-barbican18:08
*** paul_glass has joined #openstack-barbican18:12
*** alee_lunch is now known as alee18:18
aleeatiwari, woodster_ glad we cleared up the confusion on the dto.18:19
aleeatiwari, woodster_ and yeah - I think we definitely want a common cert api - but we should be careful to group options in something like a set of profiles.18:20
aleedefinitely a good K discussion18:20
atiwarialee good18:25
*** kebray has quit IRC18:26
*** mikedillion has joined #openstack-barbican18:28
*** alee is now known as alee_afk18:31
*** mikedill_ has joined #openstack-barbican18:32
*** mikedillion has quit IRC18:33
*** mikedill_ has quit IRC18:34
*** mikedillion has joined #openstack-barbican18:36
*** gyee_ has quit IRC18:36
*** alee_afk has quit IRC18:36
*** kebray has joined #openstack-barbican18:39
*** kebray has quit IRC18:55
*** mikedillion has quit IRC19:05
*** mikedillion has joined #openstack-barbican19:08
*** rm_mobile has quit IRC19:13
rm_workredrobot / jvrbanac / reaperhulk / hockeynut / others: https://review.openstack.org/#/c/115819/19:18
rm_workalso: https://review.openstack.org/#/c/115713/19:19
rm_work(not sure if it matters which one goes first)19:19
*** alee has joined #openstack-barbican19:23
reaperhulkit doesn't matter because I -1'd both :)19:26
reaperhulkunit test plz19:26
rm_workT_T19:31
rm_workatiwari: are you there?19:32
atiwariyes, in a meeting19:32
rm_workatiwari: can you write a unit test for your bugfix https://review.openstack.org/#/c/115713/ today?19:32
rm_workatiwari: I am anxious to get that in19:32
rm_workI will write a test for my CR now19:32
atiwariI can try19:33
rm_workreaperhulk: there is no containers testing at all19:33
rm_workreaperhulk: you are seriously going to make me do the whole thing to fix this bug aren't you? >_>19:34
reaperhulkwhich is terrible, but the way you get better testing is adding it when you fix bugs :)19:34
*** kebray has joined #openstack-barbican19:34
reaperhulkno, I will only make you write one test for this19:34
reaperhulkBut if you need to add infra to do it, yeah, I will19:34
rm_worklol19:34
* rm_work starts coding19:34
rm_workthis is actually a functional test thing, i think19:34
rm_worknot Unit19:34
rm_workwell, maybe19:35
openstackgerritJohn Wood proposed a change to openstack/barbican: Add order plugin metadata entity and logic  https://review.openstack.org/11607819:37
*** kebray has quit IRC19:38
*** alee_ has joined #openstack-barbican19:39
*** alee has quit IRC19:39
woodster_alee: Please take a look ^^^^19:40
rm_workreaperhulk: fortunately I basically already wrote the container tests as part of the consumer tests :P19:40
*** kebray has joined #openstack-barbican19:42
alee_woodster_, what am I looking at?19:43
alee_woodster_, just got back online19:43
*** kebray has quit IRC19:44
woodster_alee: that last CR has the plugin metadata stuff added to it.19:44
alee_woodster_, oh super19:44
*** kebray has joined #openstack-barbican19:44
alee_reaperhulk, while you're in the reviewing mood -- https://review.openstack.org/#/c/114661/ is looking for some +2's19:46
alee_(and it has lots of unit tests)19:46
*** rm_work is now known as rm_work|away19:46
*** SheenaG1 has joined #openstack-barbican19:58
*** SheenaG11 has joined #openstack-barbican20:04
*** SheenaG1 has quit IRC20:05
*** atiwari has quit IRC20:06
*** kebray has quit IRC20:07
*** kebray has joined #openstack-barbican20:12
woodster_arun_kant, alee: I added comments on the cert event CR: https://review.openstack.org/#/c/11530120:15
woodster_all: just an FYI that this CR fixes orders related flows when running the barbican server (which I had to do to test the cert processing stuff): https://review.openstack.org/#/c/115715/20:17
openstackgerritArvind Tiwari proposed a change to openstack/barbican: fix for bug #1359197  https://review.openstack.org/11571320:18
woodster_Regarding this CR ^^^^, should the algorithm type for a secret be case sensitive....so must be 'aes' instead of 'AES'?20:23
woodster_reaperhulk: Please see above question20:24
*** paul_glass has quit IRC20:25
*** ravips has joined #openstack-barbican20:26
*** juantwo has quit IRC20:27
*** paul_glass has joined #openstack-barbican20:30
ravips2 of my pull requests are blocked on https://review.openstack.org/#/c/115122/  it's a 1 line change, appreciate code reviews..thanks20:31
woodster_ravips: I'm curious why that flag is needed on the client install, but not the barbican server install?20:34
*** atiwari has joined #openstack-barbican20:34
ravipswoodster_: I don't know, let me look at the devstack stack.sh script20:36
*** rm_work|away is now known as rm_work20:38
*** kebray has quit IRC20:38
*** kebray has joined #openstack-barbican20:45
*** SheenaG11 has quit IRC20:49
*** chellygelly has joined #openstack-barbican20:54
*** chellygelly has quit IRC20:58
*** alee_ is now known as alee_afk21:12
reaperhulk:o alee_afk that is an impressive diff21:13
*** nkinder has quit IRC21:15
reaperhulkwoodster_: I have no real opinion there. If we want to accept case insensitive input I'm fine with that, as long as we're consistent21:19
*** akoneru is now known as akoneru_afk21:22
*** akoneru_afk has quit IRC21:22
reaperhulksimilarly case sensitivity is fine as well if we've been documenting it (I have absolutely no idea if we have been)21:24
openstackgerritAdam Harwell proposed a change to openstack/barbican: Fix Container list to properly format secret_refs  https://review.openstack.org/11581921:31
rm_workreaperhulk: WTB +2 (though I suppose we can wait for jenkins to pass it)21:31
rm_workah crap i forgot to tox it, hope i didn't make any pep8 errors21:32
rm_workfff yeah i did21:32
reaperhulkthose are quite a few tests (awesome!)... which one tests the actual change? :)21:33
rm_workthe last obne21:33
rm_work*the last one21:33
openstackgerritAdam Harwell proposed a change to openstack/barbican: Fix Container list to properly format secret_refs  https://review.openstack.org/11581921:33
rm_workfixed pep821:34
rm_worktest_containers_secret_refs_correctly_formatted is confirmed failing on barbican master21:34
rm_workneed to see what happens when it runs with the patch :P21:34
rm_workit should pass21:34
* rm_work is not worried21:34
jvrbanacFamous last words21:34
* jvrbanac is think about recheck no bug...21:35
jvrbanac^thinging21:35
jvrbanac^thinking21:35
jvrbanac!@#E@#21:35
openstackjvrbanac: Error: "@#E@#" is not a valid command.21:35
jvrbanac... typing is hard...21:36
reaperhulkgive up21:39
rm_workcome on zuul... less queue, more testing my change21:39
rm_workthough looks like woodster_ / redrobot are gone for the day?21:40
rm_workso i'm stuck anyway21:40
rm_workat least, i don't see them at their desks21:40
openstackgerritA change was merged to openstack/barbican-specs: Add key wrapping spec  https://review.openstack.org/10578121:42
reaperhulkboth of them tend to get online later at night too21:43
reaperhulkI'm headed out now but will be back later. I'll +2 this once I see it pass the tests21:43
hockeynutmahalo then!21:43
rm_workheh21:43
rm_workaloha reaperhulk21:43
reaperhulktaking the gopro this time. We shall see what useless footage transpires (or how quickly I lose it)21:44
hockeynutjealousy++ here21:44
jvrbanacreaperhulk, like your keys ;)21:44
reaperhulkand sunglasses21:45
rm_workyeah I really would love to do what reaperhulk is doing right now, in the sense of working from somewhere awesome during the day and then essentially vacationing in the evening :P21:45
rm_worklol hockeynut working on the comments21:47
rm_workyeah copy/paste T_T21:47
hockeynutits a wicked mistress21:47
rm_workthough what was your other comment about exactly?21:49
hockeynutthe first one?21:50
hockeynutfirst one was for test - after we delete the container the secrets should still exist21:50
rm_workoh21:50
rm_worklol well, ok21:50
woodster_rm_work: back at my house, had to pick up kid21:50
rm_workI guess we can test that?21:50
rm_workI suppose it'd be a pretty ridiculous bug where containers DELETE their secrets21:51
rm_worknot sure it's strictly necessary21:51
rm_workgranted, I suppose anything could happen :P21:51
hockeynutthat's easy to test - assertAnything()21:51
rm_workheh21:53
rm_workwoodster_: what was the acronym you used for proper full URIs? HATEOS?21:53
woodster_rm_work: yep21:54
rm_workgoogling that is NOT helpful21:54
hockeynutHATEOAS21:54
rm_workthdx21:56
rm_work*thx21:56
rm_worktyping *is* hard21:56
hockeynutI know one of the chief developers over at Nuance (Dragon voice recog) - I'll get you a discount ;-)21:58
openstackgerritAdam Harwell proposed a change to openstack/barbican: Fix Container list to properly format secret_refs  https://review.openstack.org/11581922:04
rm_workhockeynut: there, hope you're happy :P22:04
*** paul_glass1 has joined #openstack-barbican22:04
hockeynutwe shall see grasshopper...we shall see22:05
rm_workI have like 1600 lines of CRs in flight >_>22:05
hockeynutholy cr@p22:05
*** paul_glass1 has quit IRC22:05
rm_workjust for Barbican22:05
rm_workand another few hundred for neutron22:06
rm_worktrying to get more of these in so I can stop tracking so much shit :P22:06
*** nkinder has joined #openstack-barbican22:07
rm_workhockeynut: can you also review https://review.openstack.org/#/c/115713/ now that he added a unit test?22:07
rm_workwoodster_: you too22:07
rm_work... if I generate code fast enough, you guys won't have time to do anything but review <_<22:07
*** paul_glass has quit IRC22:07
hockeynutwe will just write some bots to do it22:08
*** jamielennox|away is now known as jamielennox22:10
hockeynutlooking at atiwari review https://review.openstack.org/#/c/115713/4/barbican/tests/plugin/test_store_crypto.py22:11
hockeynutI thought algorithm names were going to be case INsensitive22:11
atiwarihockeynut, that will be handled in my next cr22:12
atiwarihockeynut, https://review.openstack.org/#/c/111412/22:12
rm_workso, err22:13
rm_workOrders will *work* again though, after the first one goes in, right?22:13
rm_work:P22:13
rm_workwoodster_: https://review.openstack.org/#/c/115819/ https://review.openstack.org/#/c/115713/22:14
rm_work... though still waiting on Zuul22:14
rm_workFFFFF are you kidding me... pep8 again22:14
rm_workwhy do I keep forgetting to run tox when I do simple comment changes22:14
rm_workbecause even my comments violate pep8 >_<22:15
hockeynutthe test for https://review.openstack.org/#/c/115713/4/barbican/tests/plugin/test_store_crypto.py will fail when we change to case INsensitive, right?22:15
openstackgerritAdam Harwell proposed a change to openstack/barbican: Fix Container list to properly format secret_refs  https://review.openstack.org/11581922:15
hockeynutand there are no dependencies set between https://review.openstack.org/#/c/115713 and https://review.openstack.org/#/c/111412/22:15
woodster_rm_work: does devstack swallow exceptions, vs assert fails? I see where you are doing returned_data['secret_ref'] instead of returned_data.get('secret_ref') for example...the latter form wouldn't throw a KeyError. If exceptions do get logged in devstack, then is isn't a big deal. Just curious what you've observed....22:22
rm_workyou get logs, including the barbican-screen logs22:24
woodster_that's cool then22:24
woodster_rm_work...still looking at that long test module :)  good work....22:24
hockeynut^ +1 ^22:25
rm_workso, err22:25
woodster_rm_work: the secret name is optional,correct22:25
rm_workwould anyone mind if the __str__() methods for Secrets/Orders/Containers in the python-barbicanclient changed from the current format to... a json representation of the class? :P22:25
rm_workwoodster_: well, it's certainly not what i'm testing :P22:26
rm_workI was not going through and validating each and every value -- just that the basic CRUD doesn't error out, and the one specific test for my change22:27
rm_workwhich I bet will confuse people in the future, because "why the hell is there a test for that"22:27
rm_workjvrbanac: yeah, really hope Jenkins doesn't make me sad22:28
rm_worknot sure why the queue is this long, the graph looks like it's not very busy22:28
rm_worki guess it JUST spiked? >_>22:29
hockeynutgentlemen - just want to be sure I'm operating under a valid assumption...the algorithms we pass around (and probably modes as well) are supposed to be case INsensitive, or case sensitive?  I see code changed to make them case SENSITIVE and that confuses me greatly.22:29
woodster_hockeynut, reaperhulk: Paul weighed in on that earlier. He said: I have no real opinion there. If we want to accept case insensitive input I'm fine with that, as long as we're consistent. similarly case sensitivity is fine as well if we've been documenting it (I have absolutely no idea if we have been)22:38
woodster_...so we could go all case insensitive if we wanted to (I thought we were at one time)22:39
rm_workfor what it's worth, I'd prefer case INsensitive22:39
hockeynutI would prefer that if it makes sense (but I'm not a crypto expert)22:39
hockeynutif there are places where case sensitivity matters (file names/paths for example) then that's cool but we shouldn't introduce a limitation where none is required22:40
*** ayoung is now known as ayoung-afk22:45
openstackgerritArvind Tiwari proposed a change to openstack/barbican: fix for bug #1359197  https://review.openstack.org/11571322:49
atiwarihockeynut, ^22:50
hockeynutyou put a smile on my face tonight!22:50
hockeynutnow I can eat dinner - ttfn y'all22:51
atiwarihockeynut, :)22:52
woodster_atiwari: can you change: if alg.lower() in self.SYMMETRIC_ALGORITHMS    to: if alg and str(alg).lower() in self.SYMMETRIC_ALGORITHMS ?22:52
rm_workgs22:53
rm_workerr22:53
rm_workthis is not a terminal22:53
atiwarisure, but I think that has to be srt22:53
atiwariwhat is the point of casting22:53
atiwari?22:53
atiwaris/srt/str22:54
atiwariI think it will fail at validator only22:54
atiwarithoughts?22:55
rm_workit's "safer" >_>22:55
rm_workI just did the same thing in the func i just wrote:22:55
rm_workdef indent_object_string(string, spaces=8):22:55
rm_work    return '\n'.join(22:55
rm_work        ['{0}{1}'.format(' ' * spaces, line)22:55
rm_work         for line in str(string).split('\n') if line]22:55
rm_work    )22:55
atiwarilet me do that22:55
atiwari1 sec22:55
rm_workBTW, is that readable? :P22:56
openstackgerritArvind Tiwari proposed a change to openstack/barbican: fix for bug #1359197  https://review.openstack.org/11571322:57
atiwarihere we go22:57
atiwariwhat happened to https://review.openstack.org/#/c/115345/?22:58
rm_workprobably a recheck23:00
rm_workERROR: the main setup script run by this job failed - exit code: 123:00
rm_workmight be happening a lot? maybe that's why zuul is acting weird right now23:00
rm_workso, I thought pypy was specifically supposed to be faster -- but the pypy tox tests always take WAAAAAY longer23:03
rm_workat least on my system23:03
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient  https://review.openstack.org/11339323:05
rm_workthis is sick, I am almost starting to LIKE the way gerrit handles dependency chains >_>23:05
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient  https://review.openstack.org/11508023:05
*** atiwari has quit IRC23:11
*** juantwo has joined #openstack-barbican23:14
*** juantwo has quit IRC23:17
*** juantwo has joined #openstack-barbican23:17
*** bdpayne has quit IRC23:30
*** arun_kant has quit IRC23:32
*** kebray has quit IRC23:58
« Wednesday, 2014-08-20 Index Friday, 2014-08-22 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!