| *** ayoung-afk has quit IRC | 00:18 | |
| *** ravips has quit IRC | 00:26 | |
| *** mikedillion has quit IRC | 00:33 | |
| *** ayoung has joined #openstack-barbican | 00:45 | |
| *** woodster_ has quit IRC | 01:45 | |
| *** kebray has joined #openstack-barbican | 02:21 | |
| reaperhulk | +2'd a few CRs | 02:23 |
|---|---|---|
| rm_you | reaperhulk: hmmm | 02:54 |
| rm_you | yay some of them were mine :P | 02:54 |
| rm_you | woo arvind's thing for workflow'd | 02:55 |
| rm_you | awesome, Orders will work now | 02:55 |
| rm_you | s/for/got/ | 02:55 |
| *** ayoung has quit IRC | 03:10 | |
| *** ayoung has joined #openstack-barbican | 03:11 | |
| *** ayoung has quit IRC | 03:18 | |
| *** gyee has quit IRC | 03:24 | |
| *** juantwo has quit IRC | 05:01 | |
| *** kebray has quit IRC | 06:15 | |
| *** jamielennox is now known as jamielennox|away | 08:29 | |
| *** SheenaG1 has joined #openstack-barbican | 11:30 | |
| *** SheenaG1 has quit IRC | 11:34 | |
| *** SheenaG1 has joined #openstack-barbican | 11:35 | |
| *** alee_afk is now known as alee_out | 11:56 | |
| *** SheenaG1 has quit IRC | 11:57 | |
| *** woodster_ has joined #openstack-barbican | 12:18 | |
| *** juantwo has joined #openstack-barbican | 12:27 | |
| *** nkinder has quit IRC | 13:19 | |
| *** toabctl has joined #openstack-barbican | 13:36 | |
| toabctl | si something broken with gate-pecan-tox-barbican-tip? see i.e. http://logs.openstack.org/70/116170/3/check/gate-pecan-tox-barbican-tip/7504fea/console.html | 13:37 |
| ryanpetrello | yep | 13:37 |
| ryanpetrello | pecan just calls the barbican tests itself, though | 13:37 |
| ryanpetrello | are barbican tip tests broken? | 13:37 |
| ryanpetrello | http://www.mail-archive.com/openstack-dev@lists.openstack.org/msg32978.html | 13:38 |
| ryanpetrello | looks like a bug in testtools | 13:38 |
| toabctl | ryanpetrello: btw. I added you as reviewer for https://review.openstack.org/#/c/116198/ | 13:40 |
| ryanpetrello | yep | 13:40 |
| ryanpetrello | thanks for taking the time to clean this up! | 13:40 |
| toabctl | is there already a patch for babican to solve the gate problem? proferable to don't call setUp twice? | 13:43 |
| hockeynut | right now I see our test-requirements,txt looks for testtools>=0.9.34 | 13:44 |
| hockeynut | do we need to pin it down so we don't pick up 0.9.36? | 13:44 |
| toabctl | hockeynut: that's the temporary solution proposed in the mail ryanpetrello mentioned. but for the future setUp shouldn't be called twice. | 13:45 |
| *** SheenaG1 has joined #openstack-barbican | 13:51 | |
| *** SheenaG11 has joined #openstack-barbican | 13:53 | |
| *** russellb is now known as rustlebee | 13:54 | |
| *** SheenaG1 has quit IRC | 13:55 | |
| openstackgerrit | Thomas Bechtold proposed a change to openstack/barbican: Remove second setUp() call in tests https://review.openstack.org/116287 | 14:01 |
| toabctl | ryanpetrello: hockeynut : here's a patch for the problem: https://review.openstack.org/#/c/116287/ | 14:02 |
| hockeynut | why did we call it twice to begin with? | 14:03 |
| *** akoneru has joined #openstack-barbican | 14:07 | |
| *** nkinder has joined #openstack-barbican | 14:07 | |
| ryanpetrello | this commit: https://github.com/openstack/barbican/commit/8a15a923d6dafbdd40ff61c5658c3ad70dd7c0e8 | 14:08 |
| hockeynut | woodster_ can you peek at https://review.openstack.org/#/c/116287/ ? | 14:38 |
| woodster_ | hockeynut: looking now.... | 14:40 |
| hockeynut | gracias sir! | 14:40 |
| *** ayoung has joined #openstack-barbican | 14:43 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/barbican-specs: Update doc theme for barbican-specs https://review.openstack.org/111899 | 14:50 |
| *** paul_glass has joined #openstack-barbican | 14:53 | |
| *** paul_glass has quit IRC | 15:00 | |
| jvrbanac | alee_out, I went ahead and approved the CR. My comment was mostly my personal opinion, I would like to revisit the structure of those methods at some point, but I think it's fine for now. | 15:24 |
| openstackgerrit | John Wood proposed a change to openstack/barbican: Add initial files for certificate event handling https://review.openstack.org/115301 | 15:28 |
| *** samuelbercovici has joined #openstack-barbican | 15:30 | |
| *** samuelbercovici has quit IRC | 15:31 | |
| *** kebray has joined #openstack-barbican | 15:41 | |
| *** kebray has quit IRC | 15:44 | |
| *** kebray has joined #openstack-barbican | 15:44 | |
| openstackgerrit | John Wood proposed a change to openstack/barbican: Add order plugin metadata entity and logic https://review.openstack.org/116078 | 15:56 |
| openstackgerrit | A change was merged to openstack/barbican: Remove second setUp() call in tests https://review.openstack.org/116287 | 16:01 |
| *** ayoung is now known as ayoung-lunch | 16:04 | |
| *** kebray has quit IRC | 16:10 | |
| *** kebray has joined #openstack-barbican | 16:17 | |
| arunkant | Can someone please review https://review.openstack.org/#/c/110817/..have gone through couple of reviews. Will appreciate if folks can provide input on https://review.openstack.org/#/c/115435/ as well. | 16:30 |
| *** kebray has quit IRC | 16:33 | |
| *** kebray has joined #openstack-barbican | 16:33 | |
| *** openstackgerrit has quit IRC | 16:34 | |
| jvrbanac | arunkant, I'll take a look | 16:40 |
| rm_work | alright, I'm making that change to .get() | 16:48 |
| rm_work | will poke at you guys to +2 again when it passes checks | 16:48 |
| rm_work | trying to retrain myself to always use .get() | 16:49 |
| rm_work | honestly not sure when it would ever be preferable to use dict[key] format | 16:49 |
| *** bdpayne has joined #openstack-barbican | 16:55 | |
| jvrbanac | rm_work, you'll want to default your get to [] | 16:58 |
| jvrbanac | otherwise if it can't get it it'll revert to a None which is not iterable | 16:58 |
| *** akoneru is now known as akoneru_lunch | 16:59 | |
| jvrbanac | arunkant, you around? | 17:10 |
| arunkant | yes | 17:10 |
| arunkant | jvrbanac, yes John | 17:11 |
| rm_work | jvrbanac: kk yeah for some reason I was thinking python would figure it out | 17:12 |
| rm_work | fixed | 17:12 |
| jvrbanac | arunkant, I was just going through your CR. In the NotificationTask class, you mentioned that there is no significance between the different events. How do we know if something was called as an error vs info | 17:12 |
| jvrbanac | rm_work, awesome thanks! | 17:13 |
| arunkant | These are just priority based handler names..so far in oslo messaging..notifications are sent ONLY at 'info' priority level. | 17:14 |
| rm_work | jvrbanac: although get() doesn't do kargs | 17:14 |
| rm_work | jvrbanac: it's just d.get(name, default) | 17:14 |
| *** atiwari has joined #openstack-barbican | 17:15 | |
| rm_work | bbl | 17:15 |
| jvrbanac | rm_work, woops yeah | 17:15 |
| jvrbanac | arunkant, the reason I'm asking is because it doesn't appear there is any difference bettwen info, warn, and error. If there isn't a difference, why have them? | 17:16 |
| arunkant | jvrbanac, there is no difference in event processing at barbican side..as it does not matter what priority the notification is sent at. If you prefer, I can log the priority level as well..but its always going to be 'info'. | 17:16 |
| jvrbanac | arunkant, are you talking about logging within the info, warn, and error methods? | 17:19 |
| arunkant | jvrbanac, these are just different apis to send messages/ notifications based on priority. http://docs.openstack.org/developer/oslo.messaging/notifier.html#oslo.messaging.Notifier.info | 17:19 |
| *** gyee has joined #openstack-barbican | 17:20 | |
| arunkant | jvrbanac, at barbican side, similarly there are corresponding handler to process those different priority messages...in case of barbican..priority does not matter as such..as its interested in processing project delete event only | 17:21 |
| arunkant | The other methods are just provided here in case keystone decide to sent notification at different level (as its supported in notification listener side and I think can be changed via config). | 17:23 |
| arunkant | jvrbanac, does this clarify your question ? | 17:25 |
| jvrbanac | arunkant, maybe my brain just isn't working today. Are you just replicating the Notifier interface? | 17:27 |
| arunkant | jvrbanac, No. I added link for notifier to show how priority based notification is sent from keystone. At barbican side, its notification listener (consumer side of message) calls are used. | 17:30 |
| *** openstackgerrit has joined #openstack-barbican | 17:30 | |
| jvrbanac | arunkant, ahh ok. | 17:31 |
| woodster_ | rm_work: I think you mentioned something like the other day?: https://bugs.launchpad.net/python-barbicanclient/+bug/1357356 | 17:32 |
| arunkant | jvrbanac, was trying to make it somewhat flexible if level is changed. Looks like, it is causing confusion. I can change it to process 'info' level message only. Hopefully keystone would not change the notification level. | 17:32 |
| arunkant | javbanac, let me know if you prefer that way. | 17:34 |
| jvrbanac | arunkant, no that's fine. The thing that tripped me up is that it doesn't look like there is any difference between the methods which started me asking question about why they were there. | 17:34 |
| jvrbanac | ^the question | 17:35 |
| arunkant | jvrbanac, okay. I will revisit this if any other reviewer(s) raised the question around same topic. | 17:35 |
| jvrbanac | arunkant, perhaps you could add docstring comments in those other functions that states these shouldn't be used, but are there to match the contract. | 17:36 |
| jvrbanac | arunkant, that way, a couple months from now, when someone looks as this, they don't ask the same questions | 17:37 |
| arunkant | jvrbanac, okay..makes sense..will clarify further in next patch. | 17:37 |
| jvrbanac | arunkant, awesome thanks! I re-read your class docstring and it makes more sense now that you explained what's going on. I think clarifying the docstrings to help keep people from getting tripped up like I did. Thanks for your patience on this. :) | 17:42 |
| *** akoneru_lunch is now known as akoneru | 17:43 | |
| openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in https://review.openstack.org/111412 | 17:57 |
| *** paul_glass has joined #openstack-barbican | 18:37 | |
| *** paul_glass1 has joined #openstack-barbican | 18:44 | |
| *** paul_glass has quit IRC | 18:48 | |
| rm_work | woodster_: yeah, it's a little weird | 18:48 |
| rm_work | compared to nova/keystone/neutron/etc | 18:48 |
| *** paul_glass has joined #openstack-barbican | 18:49 | |
| rm_work | what is going on with Zuul >_> | 18:50 |
| rm_work | holy crap 1h40m queues | 18:50 |
| *** paul_glass1 has quit IRC | 18:51 | |
| rm_work | 113393 | 18:53 |
| rm_work | err whoops >_> | 18:53 |
| *** nkinder has quit IRC | 19:01 | |
| *** paul_glass has quit IRC | 19:02 | |
| *** paul_glass has joined #openstack-barbican | 19:03 | |
| *** paul_glass1 has joined #openstack-barbican | 19:04 | |
| *** paul_glass has quit IRC | 19:08 | |
| *** paul_glass has joined #openstack-barbican | 19:30 | |
| *** paul_glass1 has quit IRC | 19:33 | |
| *** paul_glass has quit IRC | 19:50 | |
| *** ayoung-lunch is now known as ayoung | 19:56 | |
| openstackgerrit | Ravi Sankar Penta proposed a change to openstack/barbican: Allow devstack to do git clone of barbican https://review.openstack.org/115122 | 20:04 |
| alee_out | jvrbanac, thanks for the +1. I'm certainly open to refactoring to make clearer later. | 20:23 |
| alee_out | whats clear to me may not be to others and visa versa | 20:23 |
| alee_out | woodster_, jvrbanac I noticed that jenkins failed my cr when trying to merge. | 20:23 |
| *** paul_glass has joined #openstack-barbican | 20:24 | |
| alee_out | woodster_, jvrbanac - but looking at the logs, I dont think this has anything to do with the code I added | 20:24 |
| alee_out | woodster_, jvrbanac https://review.openstack.org/#/c/114661/ | 20:24 |
| jvrbanac | alee_out, try rebasing. There was an issue with testr that was merged earlier: https://review.openstack.org/#/c/116287/ | 20:25 |
| openstackgerrit | Ade Lee proposed a change to openstack/barbican: Add certificate_manager functionality to dogtag plugin https://review.openstack.org/114661 | 20:26 |
| alee_out | jvrbanac, ok can you +1 workflow again? | 20:26 |
| rm_work | https://review.openstack.org/#/c/115819/ finished jenkins, should be good | 20:27 |
| rm_work | woodster_ / reaperhulk / redrobot | 20:27 |
| jvrbanac | alee_out, done | 20:27 |
| alee_out | jvrbanac, thanks! | 20:28 |
| rm_work | reaperhulk: i had to wipe your +2 to change my dict access to use .get() >_> | 20:28 |
| alee_out | ok - going back to being out .. | 20:28 |
| jvrbanac | alee_out, :) | 20:28 |
| *** gyee has quit IRC | 20:28 | |
| *** paul_glass1 has joined #openstack-barbican | 20:31 | |
| *** paul_glass1 has quit IRC | 20:33 | |
| *** gyee has joined #openstack-barbican | 20:35 | |
| *** paul_glass has quit IRC | 20:35 | |
| openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in https://review.openstack.org/111412 | 20:41 |
| *** juantwo has quit IRC | 21:05 | |
| *** nkinder has joined #openstack-barbican | 21:11 | |
| rm_work | just workflow now! https://review.openstack.org/#/c/115819/3 | 21:14 |
| openstackgerrit | John Wood proposed a change to openstack/barbican: Remove config parameter from secret_store.py interface https://review.openstack.org/116387 | 21:19 |
| woodster_ | alee_out: That CR is my first stab at removing that pesky context arg from the secret_store.py interface | 21:25 |
| openstackgerrit | John Wood proposed a change to openstack/barbican: Add initial files for certificate event handling https://review.openstack.org/115301 | 21:36 |
| openstackgerrit | A change was merged to openstack/barbican: Add certificate_manager functionality to dogtag plugin https://review.openstack.org/114661 | 21:36 |
| woodster_ | Just rebasing ^^^ to fix that two-setup() issue... | 21:37 |
| *** akoneru has quit IRC | 21:38 | |
| openstackgerrit | John Wood proposed a change to openstack/barbican: Add order plugin metadata entity and logic https://review.openstack.org/116078 | 21:38 |
| openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: fix all the log statments to use %s fomatting https://review.openstack.org/115345 | 21:38 |
| openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: fix for bug #1359197 https://review.openstack.org/115713 | 21:39 |
| *** bdpayne_ has joined #openstack-barbican | 22:00 | |
| *** bdpayne has quit IRC | 22:00 | |
| woodster_ | atiwari: why did you -1 workflow https://review.openstack.org/#/c/111412? | 22:01 |
| atiwari | woodster_, sorry I wanted to make sure it is passing the gates | 22:02 |
| atiwari | seems it is good now | 22:02 |
| atiwari | thanks | 22:02 |
| woodster_ | yeah, that double setup.py zapped two of my CRs.... | 22:02 |
| atiwari | yes | 22:03 |
| atiwari | woodster_, thanks for the help on mock patching stuff :) | 22:03 |
| woodster_ | atiwari: no problem, glad it worked | 22:04 |
| atiwari | I am still learning python. | 22:04 |
| *** bdpayne_ has quit IRC | 22:37 | |
| *** bdpayne_ has joined #openstack-barbican | 22:39 | |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient https://review.openstack.org/113393 | 23:16 |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient https://review.openstack.org/115080 | 23:16 |
| *** kebray has quit IRC | 23:20 | |
| *** juantwo has joined #openstack-barbican | 23:32 | |
| *** juantwo has quit IRC | 23:33 | |
| *** juantwo has joined #openstack-barbican | 23:34 | |
| openstackgerrit | Adam Harwell proposed a change to openstack/barbican: Fix Container list to properly format secret_refs https://review.openstack.org/115819 | 23:40 |
| rm_work | hockeynut: I went a little nuts on the DRY comment. hopefully you're happy now. :) | 23:41 |
| rm_work | https://review.openstack.org/#/c/115819/8/functionaltests/api/v1/test_containers.py | 23:41 |
| rm_work | ah crap except I forgot to run tox again... let' | 23:41 |
| rm_work | let's see how much pep8 I broke | 23:42 |
| hockeynut | looking textbook to me! | 23:42 |
| hockeynut | but pep8 always throws a wrench into things :-) | 23:42 |
| openstackgerrit | Adam Harwell proposed a change to openstack/barbican: Fix Container list to properly format secret_refs https://review.openstack.org/115819 | 23:43 |
| rm_work | fixed pep8 | 23:43 |
| rm_work | just one, and it might have been a warning anyway | 23:43 |
| hockeynut | its so readable now, pure joy! | 23:44 |
| rm_work | cut off 31 lines by pulling those out | 23:44 |
| rm_work | err though I am not sure how it is passing | 23:45 |
| rm_work | oh wait nm | 23:45 |
| rm_work | lol | 23:45 |
| rm_work | I was like "but this depends on my fix to the barbican container return formatting" ... had forgotten that's what this CR was *for*, was thinking this was just a test update >_> | 23:46 |
| hockeynut | TDD? :-) | 23:46 |
| rm_work | anywho, maybe that'll get in by EOD monday | 23:47 |
| hockeynut | need the big guns to check in over the weekend - which they normally do | 23:47 |
| rm_work | and maybe https://review.openstack.org/#/c/115080/ will go somewhere (though I may refactor depending on comments) | 23:47 |
| rm_work | so that I can follow up with https://review.openstack.org/#/c/113393/ | 23:48 |
| rm_work | 1400 lines of code in flight via 3 CRs right now T_T | 23:49 |
| rm_work | I'm going home, maybe pop on during the weekend | 23:49 |
| rm_work | toodles | 23:49 |
| rm_work | and thanks for the reviews :P | 23:49 |
| hockeynut | bon weekend! | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!