Friday, 2014-08-22

*** ayoung-afk has quit IRC00:18
*** ravips has quit IRC00:26
*** mikedillion has quit IRC00:33
*** ayoung has joined #openstack-barbican00:45
*** woodster_ has quit IRC01:45
*** kebray has joined #openstack-barbican02:21
reaperhulk+2'd a few CRs02:23
rm_youreaperhulk: hmmm02:54
rm_youyay some of them were mine :P02:54
rm_youwoo arvind's thing for workflow'd02:55
rm_youawesome, Orders will work now02:55
rm_yous/for/got/02:55
*** ayoung has quit IRC03:10
*** ayoung has joined #openstack-barbican03:11
*** ayoung has quit IRC03:18
*** gyee has quit IRC03:24
*** juantwo has quit IRC05:01
*** kebray has quit IRC06:15
*** jamielennox is now known as jamielennox|away08:29
*** SheenaG1 has joined #openstack-barbican11:30
*** SheenaG1 has quit IRC11:34
*** SheenaG1 has joined #openstack-barbican11:35
*** alee_afk is now known as alee_out11:56
*** SheenaG1 has quit IRC11:57
*** woodster_ has joined #openstack-barbican12:18
*** juantwo has joined #openstack-barbican12:27
*** nkinder has quit IRC13:19
*** toabctl has joined #openstack-barbican13:36
toabctlsi something broken with gate-pecan-tox-barbican-tip? see i.e. http://logs.openstack.org/70/116170/3/check/gate-pecan-tox-barbican-tip/7504fea/console.html13:37
ryanpetrelloyep13:37
ryanpetrellopecan just calls the barbican tests itself, though13:37
ryanpetrelloare barbican tip tests broken?13:37
ryanpetrellohttp://www.mail-archive.com/openstack-dev@lists.openstack.org/msg32978.html13:38
ryanpetrellolooks like a bug in testtools13:38
toabctlryanpetrello: btw. I added you as reviewer for https://review.openstack.org/#/c/116198/13:40
ryanpetrelloyep13:40
ryanpetrellothanks for taking the time to clean this up!13:40
toabctlis there already a patch for babican to solve the gate problem? proferable to don't call setUp twice?13:43
hockeynutright now I see our test-requirements,txt looks for testtools>=0.9.3413:44
hockeynutdo we need to pin it down so we don't pick up 0.9.36?13:44
toabctlhockeynut: that's the temporary solution proposed in the mail ryanpetrello mentioned. but for the future setUp shouldn't be called twice.13:45
*** SheenaG1 has joined #openstack-barbican13:51
*** SheenaG11 has joined #openstack-barbican13:53
*** russellb is now known as rustlebee13:54
*** SheenaG1 has quit IRC13:55
openstackgerritThomas Bechtold proposed a change to openstack/barbican: Remove second setUp() call in tests  https://review.openstack.org/11628714:01
toabctlryanpetrello: hockeynut : here's a patch for the problem: https://review.openstack.org/#/c/116287/14:02
hockeynutwhy did we call it twice to begin with?14:03
*** akoneru has joined #openstack-barbican14:07
*** nkinder has joined #openstack-barbican14:07
ryanpetrellothis commit: https://github.com/openstack/barbican/commit/8a15a923d6dafbdd40ff61c5658c3ad70dd7c0e814:08
hockeynutwoodster_ can you peek at https://review.openstack.org/#/c/116287/ ?14:38
woodster_hockeynut: looking now....14:40
hockeynutgracias sir!14:40
*** ayoung has joined #openstack-barbican14:43
openstackgerritSteve Martinelli proposed a change to openstack/barbican-specs: Update doc theme for barbican-specs  https://review.openstack.org/11189914:50
*** paul_glass has joined #openstack-barbican14:53
*** paul_glass has quit IRC15:00
jvrbanacalee_out, I went ahead and approved the CR. My comment was mostly my personal opinion, I would like to revisit the structure of those methods at some point, but I think it's fine for now.15:24
openstackgerritJohn Wood proposed a change to openstack/barbican: Add initial files for certificate event handling  https://review.openstack.org/11530115:28
*** samuelbercovici has joined #openstack-barbican15:30
*** samuelbercovici has quit IRC15:31
*** kebray has joined #openstack-barbican15:41
*** kebray has quit IRC15:44
*** kebray has joined #openstack-barbican15:44
openstackgerritJohn Wood proposed a change to openstack/barbican: Add order plugin metadata entity and logic  https://review.openstack.org/11607815:56
openstackgerritA change was merged to openstack/barbican: Remove second setUp() call in tests  https://review.openstack.org/11628716:01
*** ayoung is now known as ayoung-lunch16:04
*** kebray has quit IRC16:10
*** kebray has joined #openstack-barbican16:17
arunkantCan someone please review https://review.openstack.org/#/c/110817/..have gone through couple of reviews. Will appreciate if folks can provide input on https://review.openstack.org/#/c/115435/  as well.16:30
*** kebray has quit IRC16:33
*** kebray has joined #openstack-barbican16:33
*** openstackgerrit has quit IRC16:34
jvrbanacarunkant, I'll take a look16:40
rm_workalright, I'm making that change to .get()16:48
rm_workwill poke at you guys to +2 again when it passes checks16:48
rm_worktrying to retrain myself to always use .get()16:49
rm_workhonestly not sure when it would ever be preferable to use dict[key] format16:49
*** bdpayne has joined #openstack-barbican16:55
jvrbanacrm_work, you'll want to default your get to []16:58
jvrbanacotherwise if it can't get it it'll revert to a None which is not iterable16:58
*** akoneru is now known as akoneru_lunch16:59
jvrbanacarunkant, you around?17:10
arunkantyes17:10
arunkantjvrbanac, yes John17:11
rm_workjvrbanac: kk yeah for some reason I was thinking python would figure it out17:12
rm_workfixed17:12
jvrbanacarunkant, I was just going through your CR. In the NotificationTask class, you mentioned that there is no significance between the different events. How do we know if something was called as an error vs info17:12
jvrbanacrm_work, awesome thanks!17:13
arunkantThese are just priority based handler names..so far in oslo messaging..notifications are sent ONLY at 'info' priority level.17:14
rm_workjvrbanac: although get() doesn't do kargs17:14
rm_workjvrbanac: it's just d.get(name, default)17:14
*** atiwari has joined #openstack-barbican17:15
rm_workbbl17:15
jvrbanacrm_work, woops yeah17:15
jvrbanacarunkant, the reason I'm asking is because it doesn't appear there is any difference bettwen info, warn, and error. If there isn't a difference, why have them?17:16
arunkantjvrbanac, there is no difference in event processing at barbican side..as it does not matter what priority the notification is sent at. If you prefer, I can log the priority level as well..but its always going to be 'info'.17:16
jvrbanacarunkant, are you talking about logging within the info, warn, and error methods?17:19
arunkantjvrbanac, these are just different apis to send messages/ notifications based on priority. http://docs.openstack.org/developer/oslo.messaging/notifier.html#oslo.messaging.Notifier.info17:19
*** gyee has joined #openstack-barbican17:20
arunkantjvrbanac, at barbican side, similarly there are corresponding handler to process those different priority messages...in case of barbican..priority does not matter as such..as its interested in processing project delete event only17:21
arunkantThe other methods are just provided here in case keystone decide to sent notification at different level (as its supported in notification listener side and I think can be changed via config).17:23
arunkantjvrbanac, does this clarify your question ?17:25
jvrbanacarunkant, maybe my brain just isn't working today. Are you just replicating the Notifier interface?17:27
arunkantjvrbanac, No. I added link for notifier to show how priority based notification is sent from keystone. At barbican side, its notification listener (consumer side of message) calls are used.17:30
*** openstackgerrit has joined #openstack-barbican17:30
jvrbanacarunkant, ahh ok.17:31
woodster_rm_work: I think you mentioned something like the other day?: https://bugs.launchpad.net/python-barbicanclient/+bug/135735617:32
arunkantjvrbanac, was trying to make it somewhat flexible if level is changed. Looks like, it is causing confusion. I can change it to process 'info' level message only. Hopefully keystone would not change the notification level.17:32
arunkantjavbanac, let me know if you prefer that way.17:34
jvrbanacarunkant, no that's fine. The thing that tripped me up is that it doesn't look like there is any difference between the methods which started me asking question about why they were there.17:34
jvrbanac^the question17:35
arunkantjvrbanac, okay.  I will revisit this if any other reviewer(s) raised the question around same topic.17:35
jvrbanacarunkant, perhaps you could add docstring comments in those other functions that states these shouldn't be used, but are there to match the contract.17:36
jvrbanacarunkant, that way, a couple months from now, when someone looks as this, they don't ask the same questions17:37
arunkantjvrbanac, okay..makes sense..will clarify further in next patch.17:37
jvrbanacarunkant, awesome thanks! I re-read your class docstring and it makes more sense now that you explained what's going on. I think clarifying the docstrings to help keep people from getting tripped up like I did. Thanks for your patience on this. :)17:42
*** akoneru_lunch is now known as akoneru17:43
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in  https://review.openstack.org/11141217:57
*** paul_glass has joined #openstack-barbican18:37
*** paul_glass1 has joined #openstack-barbican18:44
*** paul_glass has quit IRC18:48
rm_workwoodster_: yeah, it's a little weird18:48
rm_workcompared to nova/keystone/neutron/etc18:48
*** paul_glass has joined #openstack-barbican18:49
rm_workwhat is going on with Zuul >_>18:50
rm_workholy crap 1h40m queues18:50
*** paul_glass1 has quit IRC18:51
rm_work11339318:53
rm_workerr whoops >_>18:53
*** nkinder has quit IRC19:01
*** paul_glass has quit IRC19:02
*** paul_glass has joined #openstack-barbican19:03
*** paul_glass1 has joined #openstack-barbican19:04
*** paul_glass has quit IRC19:08
*** paul_glass has joined #openstack-barbican19:30
*** paul_glass1 has quit IRC19:33
*** paul_glass has quit IRC19:50
*** ayoung-lunch is now known as ayoung19:56
openstackgerritRavi Sankar Penta proposed a change to openstack/barbican: Allow devstack to do git clone of barbican  https://review.openstack.org/11512220:04
alee_outjvrbanac, thanks for the +1.  I'm certainly open to refactoring to make clearer later.20:23
alee_outwhats clear to me may not be to others and visa versa20:23
alee_outwoodster_, jvrbanac I noticed that jenkins failed my cr when trying to merge.20:23
*** paul_glass has joined #openstack-barbican20:24
alee_outwoodster_, jvrbanac - but looking at the logs, I dont think this has anything to do with the code I added20:24
alee_outwoodster_, jvrbanac https://review.openstack.org/#/c/114661/20:24
jvrbanacalee_out, try rebasing. There was an issue with testr that was merged earlier: https://review.openstack.org/#/c/116287/20:25
openstackgerritAde Lee proposed a change to openstack/barbican: Add certificate_manager functionality to dogtag plugin  https://review.openstack.org/11466120:26
alee_outjvrbanac, ok can you +1 workflow again?20:26
rm_workhttps://review.openstack.org/#/c/115819/ finished jenkins, should be good20:27
rm_workwoodster_ / reaperhulk / redrobot20:27
jvrbanacalee_out, done20:27
alee_outjvrbanac, thanks!20:28
rm_workreaperhulk: i had to wipe your +2 to change my dict access to use .get() >_>20:28
alee_outok - going back to being out ..20:28
jvrbanacalee_out, :)20:28
*** gyee has quit IRC20:28
*** paul_glass1 has joined #openstack-barbican20:31
*** paul_glass1 has quit IRC20:33
*** gyee has joined #openstack-barbican20:35
*** paul_glass has quit IRC20:35
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in  https://review.openstack.org/11141220:41
*** juantwo has quit IRC21:05
*** nkinder has joined #openstack-barbican21:11
rm_workjust workflow now! https://review.openstack.org/#/c/115819/321:14
openstackgerritJohn Wood proposed a change to openstack/barbican: Remove config parameter from secret_store.py interface  https://review.openstack.org/11638721:19
woodster_alee_out: That CR is my first stab at removing that pesky context arg from the secret_store.py interface21:25
openstackgerritJohn Wood proposed a change to openstack/barbican: Add initial files for certificate event handling  https://review.openstack.org/11530121:36
openstackgerritA change was merged to openstack/barbican: Add certificate_manager functionality to dogtag plugin  https://review.openstack.org/11466121:36
woodster_Just rebasing ^^^ to fix that two-setup() issue...21:37
*** akoneru has quit IRC21:38
openstackgerritJohn Wood proposed a change to openstack/barbican: Add order plugin metadata entity and logic  https://review.openstack.org/11607821:38
openstackgerritArvind Tiwari proposed a change to openstack/barbican: fix all the log statments to use %s fomatting  https://review.openstack.org/11534521:38
openstackgerritArvind Tiwari proposed a change to openstack/barbican: fix for bug #1359197  https://review.openstack.org/11571321:39
*** bdpayne_ has joined #openstack-barbican22:00
*** bdpayne has quit IRC22:00
woodster_atiwari: why did you -1 workflow https://review.openstack.org/#/c/111412?22:01
atiwariwoodster_, sorry I wanted to make sure it is passing the gates22:02
atiwariseems it is good now22:02
atiwarithanks22:02
woodster_yeah, that double setup.py zapped two of my CRs....22:02
atiwariyes22:03
atiwariwoodster_, thanks for the help on mock patching stuff :)22:03
woodster_atiwari: no problem, glad it worked22:04
atiwariI am still learning python.22:04
*** bdpayne_ has quit IRC22:37
*** bdpayne_ has joined #openstack-barbican22:39
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient  https://review.openstack.org/11339323:16
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient  https://review.openstack.org/11508023:16
*** kebray has quit IRC23:20
*** juantwo has joined #openstack-barbican23:32
*** juantwo has quit IRC23:33
*** juantwo has joined #openstack-barbican23:34
openstackgerritAdam Harwell proposed a change to openstack/barbican: Fix Container list to properly format secret_refs  https://review.openstack.org/11581923:40
rm_workhockeynut: I went a little nuts on the DRY comment. hopefully you're happy now. :)23:41
rm_workhttps://review.openstack.org/#/c/115819/8/functionaltests/api/v1/test_containers.py23:41
rm_workah crap except I forgot to run tox again... let'23:41
rm_worklet's see how much pep8 I broke23:42
hockeynutlooking textbook to me!23:42
hockeynutbut pep8 always throws a wrench into things :-)23:42
openstackgerritAdam Harwell proposed a change to openstack/barbican: Fix Container list to properly format secret_refs  https://review.openstack.org/11581923:43
rm_workfixed pep823:43
rm_workjust one, and it might have been a warning anyway23:43
hockeynutits so readable now, pure joy!23:44
rm_workcut off 31 lines by pulling those out23:44
rm_workerr though I am not sure how it is passing23:45
rm_workoh wait nm23:45
rm_worklol23:45
rm_workI was like "but this depends on my fix to the barbican container return formatting" ... had forgotten that's what this CR was *for*, was thinking this was just a test update >_>23:46
hockeynutTDD? :-)23:46
rm_workanywho, maybe that'll get in by EOD monday23:47
hockeynutneed the big guns to check in over the weekend - which they normally do23:47
rm_workand maybe https://review.openstack.org/#/c/115080/ will go somewhere (though I may refactor depending on comments)23:47
rm_workso that I can follow up with https://review.openstack.org/#/c/113393/23:48
rm_work1400 lines of code in flight via 3 CRs right now T_T23:49
rm_workI'm going home, maybe pop on during the weekend23:49
rm_worktoodles23:49
rm_workand thanks for the reviews :P23:49
hockeynutbon weekend!23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!