| rm_work | come on gerrit... ANNOUNCE! | 00:03 |
|---|---|---|
| rm_work | oh, is the bot down? >_> lame | 00:03 |
| rm_work | well anyway, this is now finally including tests and ready for review! :P https://review.openstack.org/#/c/113393/ | 00:04 |
| rm_work | thanks in advance for the positive feedback :) | 00:04 |
| * rm_work heads home, will be around later | 00:04 | |
| *** bdpayne has quit IRC | 01:05 | |
| *** SheenaG1 has joined #openstack-barbican | 01:17 | |
| *** woodster_ has quit IRC | 01:55 | |
| rm_you | hmm zuul/jenkins is being wonky again | 02:12 |
| *** jamielennox|away has quit IRC | 02:37 | |
| *** jamielennox|away has joined #openstack-barbican | 02:37 | |
| *** jamielennox|away has quit IRC | 02:42 | |
| *** jamielennox|away has joined #openstack-barbican | 02:42 | |
| *** bdpayne has joined #openstack-barbican | 02:54 | |
| *** jamielennox|away has quit IRC | 02:59 | |
| *** jamielennox|away has joined #openstack-barbican | 03:00 | |
| *** bdpayne has quit IRC | 03:01 | |
| *** gyee has quit IRC | 03:17 | |
| *** jamielennox|away has quit IRC | 03:38 | |
| *** jamielennox|away has joined #openstack-barbican | 03:39 | |
| *** kebray has joined #openstack-barbican | 03:52 | |
| *** kebray has quit IRC | 03:52 | |
| *** kebray has joined #openstack-barbican | 03:53 | |
| *** bdpayne has joined #openstack-barbican | 04:03 | |
| *** juantwo has quit IRC | 05:07 | |
| *** kebray has quit IRC | 05:19 | |
| *** bdpayne has quit IRC | 05:36 | |
| *** bdpayne has joined #openstack-barbican | 05:48 | |
| *** jamielennox|away has quit IRC | 06:10 | |
| *** jamielennox|away has joined #openstack-barbican | 06:11 | |
| *** bdpayne has quit IRC | 06:18 | |
| *** rm_you| has joined #openstack-barbican | 07:38 | |
| *** jamielennox|away has quit IRC | 07:38 | |
| *** jamielennox|away has joined #openstack-barbican | 07:39 | |
| *** rm_you has quit IRC | 07:40 | |
| *** electrichead has joined #openstack-barbican | 08:02 | |
| *** dmakogon_ has joined #openstack-barbican | 08:06 | |
| *** redrobot has quit IRC | 08:10 | |
| *** denis_makogon has quit IRC | 08:10 | |
| *** tkelsey has joined #openstack-barbican | 08:25 | |
| *** alee has quit IRC | 08:55 | |
| *** alee has joined #openstack-barbican | 08:55 | |
| *** rm_you has joined #openstack-barbican | 09:12 | |
| *** rm_you has joined #openstack-barbican | 09:12 | |
| *** rm_you| has quit IRC | 09:12 | |
| *** rm_you| has joined #openstack-barbican | 09:21 | |
| *** rm_you has quit IRC | 09:24 | |
| *** alee has quit IRC | 09:26 | |
| *** rm_you|wtf has joined #openstack-barbican | 09:28 | |
| *** alee has joined #openstack-barbican | 09:29 | |
| *** rm_you| has quit IRC | 09:30 | |
| *** jamielenz has joined #openstack-barbican | 09:33 | |
| *** jaosorior has joined #openstack-barbican | 09:35 | |
| *** alee has quit IRC | 09:35 | |
| *** rm_you|wtf has quit IRC | 09:35 | |
| *** jamielennox|away has quit IRC | 09:36 | |
| *** xianghuihui has joined #openstack-barbican | 10:01 | |
| *** jamielennox|away has joined #openstack-barbican | 10:07 | |
| *** jamielenz has quit IRC | 10:09 | |
| *** alee has joined #openstack-barbican | 10:59 | |
| *** tkelsey has quit IRC | 11:00 | |
| *** dmakogon_ is now known as denis_makogon | 11:05 | |
| *** tkelsey has joined #openstack-barbican | 11:18 | |
| *** denis_makogon has left #openstack-barbican | 11:36 | |
| *** juantwo has joined #openstack-barbican | 12:08 | |
| *** juantwo has quit IRC | 12:10 | |
| *** juantwo has joined #openstack-barbican | 12:10 | |
| *** woodster_ has joined #openstack-barbican | 12:37 | |
| *** SheenaG11 has joined #openstack-barbican | 12:44 | |
| *** SheenaG1 has quit IRC | 12:45 | |
| *** rellerreller has joined #openstack-barbican | 12:58 | |
| *** nkinder has quit IRC | 13:03 | |
| *** lisaclark1 has joined #openstack-barbican | 13:22 | |
| *** alee is now known as alee_dentist | 13:32 | |
| *** paul_glass has joined #openstack-barbican | 13:44 | |
| *** lisaclark1 has quit IRC | 13:44 | |
| *** lisaclark1 has joined #openstack-barbican | 13:47 | |
| *** tkelsey has quit IRC | 13:50 | |
| *** akoneru has joined #openstack-barbican | 13:51 | |
| *** nkinder has joined #openstack-barbican | 13:53 | |
| *** lisaclark2 has joined #openstack-barbican | 14:10 | |
| *** lisaclark1 has quit IRC | 14:13 | |
| *** SheenaG11 has quit IRC | 14:23 | |
| *** tkelsey has joined #openstack-barbican | 14:26 | |
| *** tkelsey has quit IRC | 14:30 | |
| *** lisaclark2 has quit IRC | 14:37 | |
| *** lisaclark1 has joined #openstack-barbican | 14:39 | |
| *** juantwo has quit IRC | 14:40 | |
| *** juantwo has joined #openstack-barbican | 14:40 | |
| *** juantwo has quit IRC | 14:43 | |
| *** juantwo has joined #openstack-barbican | 14:43 | |
| *** SheenaG1 has joined #openstack-barbican | 14:52 | |
| *** jaosorior has quit IRC | 14:52 | |
| *** lisaclark1 has quit IRC | 14:53 | |
| *** openstackgerrit has joined #openstack-barbican | 14:55 | |
| *** kebray has joined #openstack-barbican | 14:55 | |
| *** xianghuihui has quit IRC | 14:55 | |
| *** alee_dentist is now known as alee | 14:58 | |
| *** lisaclark1 has joined #openstack-barbican | 15:01 | |
| *** kebray_ has joined #openstack-barbican | 15:03 | |
| *** kebray has quit IRC | 15:03 | |
| *** tkelsey has joined #openstack-barbican | 15:05 | |
| *** lisaclark1 has quit IRC | 15:18 | |
| *** paul_glass1 has joined #openstack-barbican | 15:18 | |
| *** paul_glass has quit IRC | 15:18 | |
| *** lisaclark1 has joined #openstack-barbican | 15:22 | |
| *** nkinder has quit IRC | 15:22 | |
| *** nkinder has joined #openstack-barbican | 15:22 | |
| *** electrichead is now known as redrobot | 15:26 | |
| *** rellerreller has quit IRC | 15:27 | |
| *** atiwari has joined #openstack-barbican | 15:28 | |
| *** openstack has joined #openstack-barbican | 16:18 | |
| alee | woodster_, that would free the caller -- be it something in tasks/resources or the future retry thread - from having to manage the return values | 16:19 |
| *** bdpayne has joined #openstack-barbican | 16:21 | |
| alee | woodster_, ? | 16:22 |
| *** lisaclark2 has quit IRC | 16:32 | |
| *** nkinder has quit IRC | 16:37 | |
| *** rellerreller has joined #openstack-barbican | 16:39 | |
| *** nkinder has joined #openstack-barbican | 16:39 | |
| *** bdpayne has quit IRC | 16:46 | |
| woodster_ | alee: I was trying to combine that SUCCESS/PENDING response in there now with the sub-status response...I like doing that because it keeps actual values and business logic related to what to do for a sub-status response in the realm of implementing classes, while at the same time formalizing the contract in BaseTask. So if implementors just want to return | 16:46 |
| woodster_ | None for those things, and have handle_success() just set the entity to ACTIVE, they can do so. | 16:46 |
| woodster_ | alee: so BaseTask would just take the sub_status returned from handle_processing() and give it to the handle_success() method...it wouldn't care what the value is, but it would allow sub-classes to define what that should be for their needs. | 16:47 |
| alee | woodster_, maybe I'm not being clear. it seems like the way that I just suggested allows the same thing. | 16:49 |
| woodster_ | alee: so handle_success is a bit of a misnomer for certificate workflows, as it is possible an error occurred (CA is unavailable) but the handle_success() method would still be called. It's only if exceptions are raised that this method is not called. | 16:49 |
| alee | that is -- calls like issue_certificate_request() would just return the container_id as it does now and no substatus. | 16:50 |
| alee | it would also set the status accordingly though | 16:51 |
| alee | substsatus that is in the order record | 16:51 |
| alee | then handle_success would be called | 16:51 |
| alee | and handle_success would look at the substatus/substatus_message | 16:52 |
| alee | agreed that handle_success() would be called only if an exception is not thrown | 16:52 |
| woodster_ | alee: I think that would be fine for this CR, but since we will have formal sub-status and sub-status-message attributes on the Order entity (and probably any asynchronous entity that does workflows), I was looking to make that a more formal contract in barbican core as well. We can discuss that for K thouigh | 16:53 |
| alee | woodster_, ok - that might go in line with the restructuring of the tasks you outlined | 16:54 |
| woodster_ | so each order-related implementation will need to handle sub-status as part of their handle_processing() calls which is not as concise as a method contract, but again that could be fleshed out for consideration in K I think | 16:55 |
| woodster_ | alee: yeah, that'd be fine | 16:55 |
| alee | ok great - it has the advantage of not making orders that dont need to handle substatus -- ie. like symmetirc key orders for example, not have to worry about it. | 16:58 |
| alee | but I can see the advantage of making the contract more explicit too | 16:58 |
| alee | woodster_, anyways - will implement with no returns for this CR | 16:59 |
| *** gyee has joined #openstack-barbican | 17:00 | |
| *** rellerreller has quit IRC | 17:02 | |
| *** bdpayne has joined #openstack-barbican | 17:11 | |
| woodster_ | alee: I still think you need to do the returns though, to not call handle_success() if the order is still pending, otherwise it will be marked as ACTIVE/done. | 17:12 |
| woodster_ | alee: it can be just like you have it for now though | 17:13 |
| alee | woodster_, the idea would be to modify handle_success() to look at the substatus | 17:14 |
| alee | woodster_, and only mark the order as ACTIVE/done if the substatus is CERT_GENERATED | 17:15 |
| alee | woodster_, make sense? | 17:17 |
| *** tkelsey has joined #openstack-barbican | 17:35 | |
| jvrbanac | woodster_, regarding https://review.openstack.org/#/c/115715 | 17:35 |
| jvrbanac | My main comment, is that the logical order is just odd when you're reading through the WhenTestingTypeOrderValidator class | 17:37 |
| openstackgerrit | John Wood proposed a change to openstack/barbican: Initial connect orders resource to certificate processing https://review.openstack.org/115715 | 17:39 |
| woodster_ | jvrbanac: ok, just put up a change that addresses your concern I think.... | 17:39 |
| jvrbanac | woodster_, ok... | 17:40 |
| jvrbanac | woodster_, well, that's one way to address it lol | 17:40 |
| woodster_ | jvrbanac: yeah, that makes them all consistent :) | 17:41 |
| woodster_ | jvrbanac: feel free to +2 it if you are so inclined good sir | 17:41 |
| jvrbanac | woodster_, I did | 17:41 |
| woodster_ | ha, thanks! | 17:41 |
| jvrbanac | woodster_, I don't mean to nitpick on layout and style so much lately, but we tend to be really inconsistent through our code base and I would like to make slow progress to correct that. | 17:42 |
| woodster_ | alee: what do you think of the approach in this CR for removing config from secret_store.py?: https://review.openstack.org/#/c/116387/ | 17:43 |
| woodster_ | jvrbanac: no argument here, I think that is definitely a good thing and a hopeful sign of maturity in the code base | 17:43 |
| alee | woodster_, you mean removing context? | 17:45 |
| woodster_ | alee, arunkant: do you think this CR is looking better now?: https://review.openstack.org/#/c/115301/ | 17:45 |
| woodster_ | alee: yes, just trying to clean that up per previous promises | 17:45 |
| alee | woodster_, I have a meeting shortly but Ill take a closer look this afternoon | 17:46 |
| alee | woodster_, definitely looking forward to getting that in | 17:46 |
| woodster_ | sounds good, thanks. Yeah, starting to sweat a little with M3 approaching.... | 17:46 |
| arunkant | woodster_: will take a look today. | 17:46 |
| woodster_ | arunkant: thanks! | 17:46 |
| alee | woodster_, yeah - still lots to do. | 17:47 |
| arunkant | can this be reviewed https://review.openstack.org/#/c/110817/ . Have addressed previous review comments. | 17:48 |
| *** rellerreller has joined #openstack-barbican | 17:51 | |
| *** hockeynut has joined #openstack-barbican | 17:58 | |
| rm_work | can anyone else comment on https://review.openstack.org/#/c/113393/ ? | 18:20 |
| *** lisaclark1 has joined #openstack-barbican | 18:21 | |
| chellygel | alee, i posted a general comment on your CR, let me know if you have questions. If we need to walk through the process... woodster_ and I can jump on a call with you to discuss other angles we might be missing | 18:22 |
| *** lisaclark1 has quit IRC | 18:29 | |
| *** lisaclark1 has joined #openstack-barbican | 18:32 | |
| *** tkelsey has quit IRC | 18:33 | |
| *** rellerreller has quit IRC | 18:33 | |
| *** paul_glass1 has quit IRC | 18:35 | |
| rm_work | gah, lame, py26 doesn't support dict-comprehensions? >_< | 18:45 |
| rm_work | and apparently py33 doesn't support tuple-comprehensions (generators?) | 18:45 |
| rm_work | ah, figured out the workaround | 18:51 |
| *** atiwari has quit IRC | 18:59 | |
| *** lisaclark1 has quit IRC | 19:00 | |
| *** tkelsey has joined #openstack-barbican | 19:02 | |
| *** lisaclark1 has joined #openstack-barbican | 19:03 | |
| *** lisaclark1 has quit IRC | 19:03 | |
| *** tkelsey has quit IRC | 19:06 | |
| *** paul_glass has joined #openstack-barbican | 19:09 | |
| rm_work | hey, so, anyone against having a method named "_get_secrets_and_store_them_if_necessary()"? :P | 19:11 |
| redrobot | rm_work lol | 19:12 |
| rm_work | :P:P | 19:12 |
| rm_work | people seem to like when things are explicitly named... | 19:12 |
| rm_work | maybe I am going a bit overboard, but that's what i'm calling this function unless someone objects | 19:12 |
| *** SheenaG1 has quit IRC | 19:15 | |
| redrobot | clear | 19:16 |
| redrobot | derp... wrong cli | 19:17 |
| *** SheenaG1 has joined #openstack-barbican | 19:18 | |
| openstackgerrit | John Vrbanac proposed a change to openstack/barbican: Making a few modules hacking 0.9.2 compliant https://review.openstack.org/117334 | 19:31 |
| *** lisaclark1 has joined #openstack-barbican | 19:33 | |
| jvrbanac | redrobot, woodster_ sooo,, I'm guessing y'all haven't tried the newer hacking that is specified by global reqs | 19:33 |
| jvrbanac | there are a crap load of new violations | 19:33 |
| alee | chellygel, woodster_ back from meeting -lloking | 19:35 |
| alee | chellygel, which cr did you comment on? | 19:36 |
| alee | chellygel, ah - nm, I thought you had commented on specific code -- reading yur general comment | 19:39 |
| *** rellerreller has joined #openstack-barbican | 19:47 | |
| *** lisaclark1 has quit IRC | 20:06 | |
| *** samuelbercovici has joined #openstack-barbican | 20:17 | |
| *** nkinder has quit IRC | 20:28 | |
| *** paul_glass has quit IRC | 20:29 | |
| *** nkinder has joined #openstack-barbican | 20:45 | |
| *** lisaclark1 has joined #openstack-barbican | 20:48 | |
| *** akoneru is now known as akoneru_brb | 20:52 | |
| *** lisaclark1 has quit IRC | 20:54 | |
| *** juantwo has quit IRC | 20:55 | |
| chellygel | alee, sorry ive been swamped! but i saw you responded! i'll read it shortly! | 20:56 |
| *** akoneru_brb has quit IRC | 20:57 | |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient https://review.openstack.org/115080 | 20:58 |
| *** samuelbercovici has quit IRC | 21:01 | |
| openstackgerrit | Sheena Gregson proposed a change to openstack/barbican: Updated Get Secrets request and response https://review.openstack.org/117352 | 21:02 |
| *** rm_work is now known as rm_work|away | 21:03 | |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient https://review.openstack.org/113393 | 21:04 |
| *** SheenaG11 has joined #openstack-barbican | 21:06 | |
| *** SheenaG1 has quit IRC | 21:07 | |
| jvrbanac | redrobot, alee, rellerreller, reaperhulk, would someone like to workflow https://review.openstack.org/#/c/116736/ ? | 21:14 |
| alee | jvrbanac, done | 21:15 |
| jvrbanac | alee, thx | 21:15 |
| alee | np | 21:15 |
| SheenaG11 | jvrbanac: thanks for pimping my change | 21:17 |
| SheenaG11 | alee: thanks for the +1 | 21:17 |
| SheenaG11 | I'm learning! | 21:17 |
| *** akoneru has joined #openstack-barbican | 21:18 | |
| *** rellerreller has quit IRC | 21:22 | |
| woodster_ | arunkant: some detail comments/questions in your CR | 21:30 |
| jvrbanac | SheenaG11, np | 21:30 |
| *** nkinder has quit IRC | 21:39 | |
| *** paul_glass has joined #openstack-barbican | 21:42 | |
| openstackgerrit | A change was merged to openstack/barbican: Updated Get Orders request and response https://review.openstack.org/116736 | 21:43 |
| SheenaG11 | woodster_: ping | 21:50 |
| *** paul_glass has quit IRC | 21:52 | |
| *** SheenaG11 has quit IRC | 21:56 | |
| *** rm_work|away is now known as rm_work | 21:57 | |
| *** lisaclark1 has joined #openstack-barbican | 21:58 | |
| rm_work | oh, whoops. forgot to do the extra tests jaos wanted | 22:04 |
| *** lisaclark1 has quit IRC | 22:05 | |
| *** lisaclark1 has joined #openstack-barbican | 22:08 | |
| *** lisaclark1 has quit IRC | 22:09 | |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient https://review.openstack.org/115080 | 22:09 |
| rm_work | whew, hacked up the rest of those tests while waiting to board my plane | 22:41 |
| rm_work | I THINK i got them all | 22:41 |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient https://review.openstack.org/113393 | 22:42 |
| rm_work | I'm sure he'll let me know if I didn't :P | 22:42 |
| rm_work | oops, one more set of tests | 22:45 |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient https://review.openstack.org/113393 | 22:46 |
| rm_work | alright | 22:46 |
| rm_work | hopefully Juan gets on and re-reviews :) | 22:47 |
| rm_work | redrobot: you could always review... :P | 22:47 |
| rm_work | woodster_: you too :) | 22:53 |
| rm_work | meanwhile, I'm boarding, will be back from the air in a bit | 22:53 |
| rm_work | until they turn on the in-flight wireless :P | 22:54 |
| openstackgerrit | Arun Kant proposed a change to openstack/barbican: Adding keystone notification listener support https://review.openstack.org/110817 | 22:58 |
| *** SheenaG1 has joined #openstack-barbican | 23:01 | |
| *** SheenaG11 has joined #openstack-barbican | 23:05 | |
| *** SheenaG1 has quit IRC | 23:07 | |
| *** kebray has quit IRC | 23:08 | |
| *** rm_work is now known as rm_work|away | 23:08 | |
| *** jamielennox|away is now known as jamielennox | 23:10 | |
| openstackgerrit | Sheena Gregson proposed a change to openstack/barbican: Updated Create Secret request and response https://review.openstack.org/117379 | 23:42 |
| *** juantwo has joined #openstack-barbican | 23:45 | |
| openstackgerrit | Sheena Gregson proposed a change to openstack/barbican: Updated Create Secret request and response https://review.openstack.org/117379 | 23:51 |
| openstackgerrit | Sheena Gregson proposed a change to openstack/barbican: Updated Create Secret request and response https://review.openstack.org/117379 | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!