Wednesday, 2014-08-27

rm_workcome on gerrit... ANNOUNCE!00:03
rm_workoh, is the bot down? >_> lame00:03
rm_workwell anyway, this is now finally including tests and ready for review! :P https://review.openstack.org/#/c/113393/00:04
rm_workthanks in advance for the positive feedback :)00:04
* rm_work heads home, will be around later00:04
*** bdpayne has quit IRC01:05
*** SheenaG1 has joined #openstack-barbican01:17
*** woodster_ has quit IRC01:55
rm_youhmm zuul/jenkins is being wonky again02:12
*** jamielennox|away has quit IRC02:37
*** jamielennox|away has joined #openstack-barbican02:37
*** jamielennox|away has quit IRC02:42
*** jamielennox|away has joined #openstack-barbican02:42
*** bdpayne has joined #openstack-barbican02:54
*** jamielennox|away has quit IRC02:59
*** jamielennox|away has joined #openstack-barbican03:00
*** bdpayne has quit IRC03:01
*** gyee has quit IRC03:17
*** jamielennox|away has quit IRC03:38
*** jamielennox|away has joined #openstack-barbican03:39
*** kebray has joined #openstack-barbican03:52
*** kebray has quit IRC03:52
*** kebray has joined #openstack-barbican03:53
*** bdpayne has joined #openstack-barbican04:03
*** juantwo has quit IRC05:07
*** kebray has quit IRC05:19
*** bdpayne has quit IRC05:36
*** bdpayne has joined #openstack-barbican05:48
*** jamielennox|away has quit IRC06:10
*** jamielennox|away has joined #openstack-barbican06:11
*** bdpayne has quit IRC06:18
*** rm_you| has joined #openstack-barbican07:38
*** jamielennox|away has quit IRC07:38
*** jamielennox|away has joined #openstack-barbican07:39
*** rm_you has quit IRC07:40
*** electrichead has joined #openstack-barbican08:02
*** dmakogon_ has joined #openstack-barbican08:06
*** redrobot has quit IRC08:10
*** denis_makogon has quit IRC08:10
*** tkelsey has joined #openstack-barbican08:25
*** alee has quit IRC08:55
*** alee has joined #openstack-barbican08:55
*** rm_you has joined #openstack-barbican09:12
*** rm_you has joined #openstack-barbican09:12
*** rm_you| has quit IRC09:12
*** rm_you| has joined #openstack-barbican09:21
*** rm_you has quit IRC09:24
*** alee has quit IRC09:26
*** rm_you|wtf has joined #openstack-barbican09:28
*** alee has joined #openstack-barbican09:29
*** rm_you| has quit IRC09:30
*** jamielenz has joined #openstack-barbican09:33
*** jaosorior has joined #openstack-barbican09:35
*** alee has quit IRC09:35
*** rm_you|wtf has quit IRC09:35
*** jamielennox|away has quit IRC09:36
*** xianghuihui has joined #openstack-barbican10:01
*** jamielennox|away has joined #openstack-barbican10:07
*** jamielenz has quit IRC10:09
*** alee has joined #openstack-barbican10:59
*** tkelsey has quit IRC11:00
*** dmakogon_ is now known as denis_makogon11:05
*** tkelsey has joined #openstack-barbican11:18
*** denis_makogon has left #openstack-barbican11:36
*** juantwo has joined #openstack-barbican12:08
*** juantwo has quit IRC12:10
*** juantwo has joined #openstack-barbican12:10
*** woodster_ has joined #openstack-barbican12:37
*** SheenaG11 has joined #openstack-barbican12:44
*** SheenaG1 has quit IRC12:45
*** rellerreller has joined #openstack-barbican12:58
*** nkinder has quit IRC13:03
*** lisaclark1 has joined #openstack-barbican13:22
*** alee is now known as alee_dentist13:32
*** paul_glass has joined #openstack-barbican13:44
*** lisaclark1 has quit IRC13:44
*** lisaclark1 has joined #openstack-barbican13:47
*** tkelsey has quit IRC13:50
*** akoneru has joined #openstack-barbican13:51
*** nkinder has joined #openstack-barbican13:53
*** lisaclark2 has joined #openstack-barbican14:10
*** lisaclark1 has quit IRC14:13
*** SheenaG11 has quit IRC14:23
*** tkelsey has joined #openstack-barbican14:26
*** tkelsey has quit IRC14:30
*** lisaclark2 has quit IRC14:37
*** lisaclark1 has joined #openstack-barbican14:39
*** juantwo has quit IRC14:40
*** juantwo has joined #openstack-barbican14:40
*** juantwo has quit IRC14:43
*** juantwo has joined #openstack-barbican14:43
*** SheenaG1 has joined #openstack-barbican14:52
*** jaosorior has quit IRC14:52
*** lisaclark1 has quit IRC14:53
*** openstackgerrit has joined #openstack-barbican14:55
*** kebray has joined #openstack-barbican14:55
*** xianghuihui has quit IRC14:55
*** alee_dentist is now known as alee14:58
*** lisaclark1 has joined #openstack-barbican15:01
*** kebray_ has joined #openstack-barbican15:03
*** kebray has quit IRC15:03
*** tkelsey has joined #openstack-barbican15:05
*** lisaclark1 has quit IRC15:18
*** paul_glass1 has joined #openstack-barbican15:18
*** paul_glass has quit IRC15:18
*** lisaclark1 has joined #openstack-barbican15:22
*** nkinder has quit IRC15:22
*** nkinder has joined #openstack-barbican15:22
*** electrichead is now known as redrobot15:26
*** rellerreller has quit IRC15:27
*** atiwari has joined #openstack-barbican15:28
*** openstack has joined #openstack-barbican16:18
aleewoodster_,  that would free the caller -- be it something in tasks/resources or the future retry thread - from having to manage the return values16:19
*** bdpayne has joined #openstack-barbican16:21
aleewoodster_, ?16:22
*** lisaclark2 has quit IRC16:32
*** nkinder has quit IRC16:37
*** rellerreller has joined #openstack-barbican16:39
*** nkinder has joined #openstack-barbican16:39
*** bdpayne has quit IRC16:46
woodster_alee: I was trying to combine that SUCCESS/PENDING response in there now with the sub-status response...I like doing that because it keeps actual values and business logic related to what to do for a sub-status response in the realm of implementing classes, while at the same time formalizing the contract in BaseTask.  So if implementors just want to return16:46
woodster_None for those things, and have handle_success() just set the entity to ACTIVE, they can do so.16:46
woodster_alee: so BaseTask would just take the sub_status returned from handle_processing() and give it to the handle_success() method...it wouldn't care what the value is, but it would allow sub-classes to define what that should be for their needs.16:47
aleewoodster_, maybe I'm not being clear. it seems like the way that I just suggested allows the same thing.16:49
woodster_alee: so handle_success is a bit of a misnomer for certificate workflows, as it is possible an error occurred (CA is unavailable) but the handle_success() method would still be called. It's only if exceptions are raised that this method is not called.16:49
aleethat is -- calls like issue_certificate_request() would just return the container_id as it does now and no substatus.16:50
aleeit would also set the status accordingly though16:51
aleesubstsatus that is in the order record16:51
aleethen handle_success would be called16:51
aleeand handle_success would look at the substatus/substatus_message16:52
aleeagreed that handle_success() would be called only if an exception is not thrown16:52
woodster_alee: I think that would be fine for this CR, but since we will have formal sub-status and sub-status-message attributes on the Order entity (and probably any asynchronous entity that does workflows), I was looking to make that a more formal contract in barbican core as well. We can discuss that for K thouigh16:53
aleewoodster_, ok - that might go in line with the restructuring of the tasks you outlined16:54
woodster_so each order-related implementation will need to handle sub-status as part of their handle_processing() calls which is not as concise as a method contract, but again that could be fleshed out for consideration in K I think16:55
woodster_alee: yeah, that'd be fine16:55
aleeok great - it has the advantage of not making orders that dont need to handle substatus -- ie. like symmetirc key orders for example, not have to worry about it.16:58
aleebut I can see the advantage of making the contract more explicit too16:58
aleewoodster_, anyways - will implement with no returns for this CR16:59
*** gyee has joined #openstack-barbican17:00
*** rellerreller has quit IRC17:02
*** bdpayne has joined #openstack-barbican17:11
woodster_alee: I still think you need to do the returns though, to not call handle_success() if the order is still pending, otherwise it will be marked as ACTIVE/done.17:12
woodster_alee: it can be just like you have it for now though17:13
aleewoodster_, the idea would be to modify handle_success() to look at the substatus17:14
aleewoodster_, and only mark the order as ACTIVE/done if the substatus is CERT_GENERATED17:15
aleewoodster_, make sense?17:17
*** tkelsey has joined #openstack-barbican17:35
jvrbanacwoodster_, regarding https://review.openstack.org/#/c/11571517:35
jvrbanacMy main comment, is that the logical order is just odd when you're reading through the WhenTestingTypeOrderValidator class17:37
openstackgerritJohn Wood proposed a change to openstack/barbican: Initial connect orders resource to certificate processing  https://review.openstack.org/11571517:39
woodster_jvrbanac: ok, just put up a change that addresses your concern I think....17:39
jvrbanacwoodster_, ok...17:40
jvrbanacwoodster_, well, that's one way to address it lol17:40
woodster_jvrbanac: yeah, that makes them all consistent :)17:41
woodster_jvrbanac: feel free to +2 it if you are so inclined good sir17:41
jvrbanacwoodster_, I did17:41
woodster_ha, thanks!17:41
jvrbanacwoodster_, I don't mean to nitpick on layout and style so much lately, but we tend to be really inconsistent through our code base and I would like to make slow progress to correct that.17:42
woodster_alee: what do you think of the approach in this CR for removing config from secret_store.py?: https://review.openstack.org/#/c/116387/17:43
woodster_jvrbanac: no argument here, I think that is definitely a good thing and a hopeful sign of maturity in the code base17:43
aleewoodster_, you mean removing context?17:45
woodster_alee, arunkant: do you think this CR is looking better now?: https://review.openstack.org/#/c/115301/17:45
woodster_alee: yes, just trying to clean that up per previous promises17:45
aleewoodster_, I have a meeting shortly but Ill take a closer look this afternoon17:46
aleewoodster_, definitely looking forward to getting that in17:46
woodster_sounds good, thanks.  Yeah, starting to sweat a little with M3 approaching....17:46
arunkantwoodster_: will take a look today.17:46
woodster_arunkant: thanks!17:46
aleewoodster_, yeah - still lots to do.17:47
arunkantcan this be reviewed https://review.openstack.org/#/c/110817/ . Have addressed previous review comments.17:48
*** rellerreller has joined #openstack-barbican17:51
*** hockeynut has joined #openstack-barbican17:58
rm_workcan anyone else comment on https://review.openstack.org/#/c/113393/ ?18:20
*** lisaclark1 has joined #openstack-barbican18:21
chellygelalee, i posted a general comment on your CR, let me know if you have questions. If we need to walk through the process... woodster_ and I can jump on a call with you to discuss other angles we might be missing18:22
*** lisaclark1 has quit IRC18:29
*** lisaclark1 has joined #openstack-barbican18:32
*** tkelsey has quit IRC18:33
*** rellerreller has quit IRC18:33
*** paul_glass1 has quit IRC18:35
rm_workgah, lame, py26 doesn't support dict-comprehensions? >_<18:45
rm_workand apparently py33 doesn't support tuple-comprehensions (generators?)18:45
rm_workah, figured out the workaround18:51
*** atiwari has quit IRC18:59
*** lisaclark1 has quit IRC19:00
*** tkelsey has joined #openstack-barbican19:02
*** lisaclark1 has joined #openstack-barbican19:03
*** lisaclark1 has quit IRC19:03
*** tkelsey has quit IRC19:06
*** paul_glass has joined #openstack-barbican19:09
rm_workhey, so, anyone against having a method named "_get_secrets_and_store_them_if_necessary()"? :P19:11
redrobotrm_work lol19:12
rm_work:P:P19:12
rm_workpeople seem to like when things are explicitly named...19:12
rm_workmaybe I am going a bit overboard, but that's what i'm calling this function unless someone objects19:12
*** SheenaG1 has quit IRC19:15
redrobotclear19:16
redrobotderp... wrong cli19:17
*** SheenaG1 has joined #openstack-barbican19:18
openstackgerritJohn Vrbanac proposed a change to openstack/barbican: Making a few modules hacking 0.9.2 compliant  https://review.openstack.org/11733419:31
*** lisaclark1 has joined #openstack-barbican19:33
jvrbanacredrobot, woodster_ sooo,, I'm guessing y'all haven't tried the newer hacking that is specified by global reqs19:33
jvrbanacthere are a crap load of new violations19:33
aleechellygel, woodster_ back from meeting -lloking19:35
aleechellygel, which cr did you comment on?19:36
aleechellygel, ah - nm, I thought you had commented on specific code -- reading yur general comment19:39
*** rellerreller has joined #openstack-barbican19:47
*** lisaclark1 has quit IRC20:06
*** samuelbercovici has joined #openstack-barbican20:17
*** nkinder has quit IRC20:28
*** paul_glass has quit IRC20:29
*** nkinder has joined #openstack-barbican20:45
*** lisaclark1 has joined #openstack-barbican20:48
*** akoneru is now known as akoneru_brb20:52
*** lisaclark1 has quit IRC20:54
*** juantwo has quit IRC20:55
chellygelalee, sorry ive been swamped! but i saw you responded! i'll read it shortly!20:56
*** akoneru_brb has quit IRC20:57
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient  https://review.openstack.org/11508020:58
*** samuelbercovici has quit IRC21:01
openstackgerritSheena Gregson proposed a change to openstack/barbican: Updated Get Secrets request and response  https://review.openstack.org/11735221:02
*** rm_work is now known as rm_work|away21:03
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient  https://review.openstack.org/11339321:04
*** SheenaG11 has joined #openstack-barbican21:06
*** SheenaG1 has quit IRC21:07
jvrbanacredrobot, alee, rellerreller, reaperhulk, would someone like to workflow https://review.openstack.org/#/c/116736/ ?21:14
aleejvrbanac, done21:15
jvrbanacalee, thx21:15
aleenp21:15
SheenaG11jvrbanac: thanks for pimping my change21:17
SheenaG11alee: thanks for the +121:17
SheenaG11I'm learning!21:17
*** akoneru has joined #openstack-barbican21:18
*** rellerreller has quit IRC21:22
woodster_arunkant: some detail comments/questions in your CR21:30
jvrbanacSheenaG11, np21:30
*** nkinder has quit IRC21:39
*** paul_glass has joined #openstack-barbican21:42
openstackgerritA change was merged to openstack/barbican: Updated Get Orders request and response  https://review.openstack.org/11673621:43
SheenaG11woodster_: ping21:50
*** paul_glass has quit IRC21:52
*** SheenaG11 has quit IRC21:56
*** rm_work|away is now known as rm_work21:57
*** lisaclark1 has joined #openstack-barbican21:58
rm_workoh, whoops. forgot to do the extra tests jaos wanted22:04
*** lisaclark1 has quit IRC22:05
*** lisaclark1 has joined #openstack-barbican22:08
*** lisaclark1 has quit IRC22:09
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient  https://review.openstack.org/11508022:09
rm_workwhew, hacked up the rest of those tests while waiting to board my plane22:41
rm_workI THINK i got them all22:41
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient  https://review.openstack.org/11339322:42
rm_workI'm sure he'll let me know if I didn't :P22:42
rm_workoops, one more set of tests22:45
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient  https://review.openstack.org/11339322:46
rm_workalright22:46
rm_workhopefully Juan gets on and re-reviews :)22:47
rm_workredrobot: you could always review... :P22:47
rm_workwoodster_: you too :)22:53
rm_workmeanwhile, I'm boarding, will be back from the air in a bit22:53
rm_workuntil they turn on the in-flight wireless :P22:54
openstackgerritArun Kant proposed a change to openstack/barbican: Adding keystone notification listener support  https://review.openstack.org/11081722:58
*** SheenaG1 has joined #openstack-barbican23:01
*** SheenaG11 has joined #openstack-barbican23:05
*** SheenaG1 has quit IRC23:07
*** kebray has quit IRC23:08
*** rm_work is now known as rm_work|away23:08
*** jamielennox|away is now known as jamielennox23:10
openstackgerritSheena Gregson proposed a change to openstack/barbican: Updated Create Secret request and response  https://review.openstack.org/11737923:42
*** juantwo has joined #openstack-barbican23:45
openstackgerritSheena Gregson proposed a change to openstack/barbican: Updated Create Secret request and response  https://review.openstack.org/11737923:51
openstackgerritSheena Gregson proposed a change to openstack/barbican: Updated Create Secret request and response  https://review.openstack.org/11737923:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!