| openstackgerrit | Chelsea Winfree proposed a change to openstack/barbican: Adding initial update logic for orders https://review.openstack.org/117386 | 00:07 |
|---|---|---|
| *** rm_work|away is now known as rm_work | 00:08 | |
| rm_work | alright, took forever but finally in the air <_< | 00:08 |
| rm_work | chellygel: agh, is there going to be Order PUT functionality before I even get my client changes through? :P | 00:08 |
| chellygel | rm_work, tread lightly -- i almost punched my computer through the wall to get that commit up there | 00:09 |
| chellygel | lol | 00:09 |
| rm_work | heh | 00:09 |
| rm_work | I feel ya | 00:09 |
| rm_work | I am stuck on an airplane with nothing to do, so I guess I'll take a peek :P | 00:11 |
| rm_work | BTW what exactly is order meta? I may not be loading / treating it correctly in the client right now because i didn't see much about what it is for | 00:12 |
| rm_work | chellygel: ^^ | 00:12 |
| chellygel | in my case, it is going to hold data for certificate requests rm_work | 00:12 |
| rm_work | ok, so it's kind of... general purpose | 00:13 |
| rm_work | figured as much... not sure whether it is important to display when someone does "barbican order get" using the CLI | 00:13 |
| rm_work | or how to parse it, I assume it's just random json? | 00:14 |
| chellygel | im not familiar enough to answer that question | 00:14 |
| chellygel | uhh, its going to be validated in the future -- but for now we arent concerned with whats in it | 00:14 |
| rm_work | ok | 00:14 |
| chellygel | just cause its initial crs and stuff | 00:14 |
| rm_work | then I am probably fine not displaying it | 00:15 |
| rm_work | (for now) | 00:15 |
| rm_work | so all that can be updated with a PUT is that meta? | 00:15 |
| chellygel | for certificates its going to have like... csr, email addy, order related info? | 00:15 |
| chellygel | maybe an id? | 00:15 |
| chellygel | yep. | 00:15 |
| rm_work | ok | 00:16 |
| chellygel | where you off to rm_work ? | 00:16 |
| rm_work | Seattle | 00:16 |
| rm_work | heading up to visit friends, and go to PAX Prime :P | 00:16 |
| chellygel | ugh i love it | 00:16 |
| chellygel | im going to PAX south | 00:16 |
| rm_work | heh | 00:17 |
| rm_work | uhh, if you can book a flight within the next day or so, I have an extra set of Prime passes, lol | 00:17 |
| rm_work | someone I bought passes for bailed :P | 00:17 |
| chellygel | i would, but i have so much shit at work at this point | 00:17 |
| chellygel | my dad lives up there though | 00:17 |
| chellygel | very tempting | 00:17 |
| rm_work | heh | 00:17 |
| rm_work | notice I'm working from the plane >_> | 00:18 |
| rm_work | probably will be working in any spare moment too, lol | 00:18 |
| rm_work | trying to get these reviews through | 00:18 |
| rm_work | but yeah, also doing PAX South | 00:18 |
| rm_work | and hosting a bunch of out-of-towners on my extra floorspace :P | 00:19 |
| openstackgerrit | Sheena Gregson proposed a change to openstack/barbican: Updated Create Secret request and response https://review.openstack.org/117379 | 00:21 |
| rm_work | uh-oh | 00:21 |
| rm_work | turbulence warning | 00:21 |
| rm_work | I have not had enough alcohol for this to be ok >_> | 00:21 |
| * rm_work is fine with flying as long as it's smooth | 00:21 | |
| rm_work | chellygel: looks good to me so far, granted that there's a couple of pretty decent TODOs in there :P | 00:23 |
| chellygel | pax south should be fun. and you are nice to help them | 00:23 |
| chellygel | also, there are going to be like 012934810293 CRs from this one | 00:24 |
| rm_work | heh | 00:24 |
| chellygel | those todos wont even be done when this CR gets put through, is my guess | 00:24 |
| rm_work | I always shoot for < 30 | 00:24 |
| chellygel | Certificates is going to be quite fun to implement | 00:24 |
| rm_work | so far so good on the two I have in flight currently... | 00:24 |
| chellygel | i need to go write those unit tests but im pretty burnt out for the night | 00:26 |
| rm_work | heh yeah | 00:26 |
| rm_work | though usually test-writing is pretty brainless | 00:26 |
| rm_work | really it's "which tests do i need to add" that's the tough part | 00:27 |
| rm_work | filling them in is pretty rote <_< | 00:27 |
| *** akoneru has quit IRC | 00:28 | |
| woodster_ | rm_work: the new order format has type/meta, and that is visible to clients. There is also plugin meta associated with orders that is private to plugins, not visible to clients | 00:32 |
| rm_work | woodster_: ok, but I don't have to worry about that for my current CR right? | 00:33 |
| woodster_ | I don't think so, let a follow on cr(s) deal with that | 00:34 |
| rm_work | kk :) | 00:35 |
| rm_work | huge fan of "BUT, not an issue for *this* CR" :P | 00:35 |
| woodster_ | rm_work: the longer these CRs linger out there the harder it is to resist trying to keep up with changes | 00:37 |
| woodster_ | rm_work: but then they'd just get fatter and fatter | 00:37 |
| rm_work | yeah, then we'd have to start making "your CR is so fat..." jokes | 00:39 |
| rm_work | woodster_: you should review 115080 again -- just check out what changed since patch 9 (when you reviewed last), shouldn't be much | 00:44 |
| *** nkinder has joined #openstack-barbican | 00:46 | |
| rm_work | general plug for reviews for https://review.openstack.org/#/c/115080/ (anyone who happens to be around) | 00:48 |
| rm_work | I guess it is getting late | 00:49 |
| *** bdpayne has quit IRC | 00:51 | |
| rm_work | wish Juan would get on so I could discuss some of his comments T_T | 00:54 |
| chellygel | he usually gets on i wanna say like 11 CDT | 00:54 |
| rm_work | yeah I think I see that he is in Finland? | 00:57 |
| rm_work | so, bit of a time differential | 00:57 |
| rm_work | chellygel: ack, are you still at work? I looked up flights for you but they have gotten quite expensive T_T | 00:58 |
| chellygel | you talking about seattle??>? | 00:58 |
| chellygel | lol | 00:58 |
| rm_work | yes :P | 00:58 |
| chellygel | hahaha, im still at work... sadly | 00:59 |
| rm_work | $700-800 roundtrip now :( | 00:59 |
| chellygel | but its a personal choice | 00:59 |
| chellygel | NBD, couldnt take the time off anyway | 00:59 |
| rm_work | yeah I am usually at work until 7:30-8 recently too <_< | 00:59 |
| rm_work | but I feel like I may get in later than you do | 00:59 |
| chellygel | hahha | 01:00 |
| rm_work | tried to explain to someone why I was planning to stay at work until 8pm last friday, and they were like "make some excuse and go home", and i couldn't seem to get them to understand that I COULD leave any time, but I didn't want to :) | 01:00 |
| chellygel | this week ive been getting in around 8;30 or 9 | 01:00 |
| rm_work | yeah, much earlier >_< | 01:00 |
| rm_work | turns out working on Barbican stuff is actually interesting :P | 01:00 |
| chellygel | hahaha | 01:01 |
| chellygel | good! | 01:01 |
| chellygel | okay, i am leaving now -- 8 is good enough | 01:01 |
| rm_work | have a good ... night then :P | 01:01 |
| rm_work | bit late to still be evening <_< | 01:01 |
| chellygel | v_v | 01:01 |
| * chellygel cries | 01:01 | |
| *** igueths has joined #openstack-barbican | 01:03 | |
| igueths | Hey woodster_, you wouldn't happen to be hanging around by any chance? | 01:04 |
| rm_work | igueths: if he is, I want him too :) | 01:05 |
| igueths | rm_work: Ha ha | 01:05 |
| jvrbanac | rm_work, I +2'ed your CR | 01:05 |
| woodster_ | No I'm mobile :( | 01:05 |
| rm_work | jvrbanac: cool, thanks :) | 01:05 |
| rm_work | jvrbanac: any chance of some love for the dependent one too? :P | 01:06 |
| rm_work | also, wtf is up with Jenkins/Zuul recently | 01:06 |
| rm_work | I'm in a THREE HOUR queue | 01:06 |
| jvrbanac | rm_work, 987 lines?!?! | 01:06 |
| jvrbanac | geez! | 01:06 |
| rm_work | jvrbanac: a lot of that is tests! :P | 01:07 |
| igueths | woodster_: Ah | 01:07 |
| rm_work | jvrbanac: but yes, I've been busy <_< | 01:07 |
| jvrbanac | rm_work, we really need to work on splitting up our work into smaller chunks. | 01:09 |
| rm_work | jvrbanac: this is one pretty basic chunk | 01:09 |
| rm_work | not sure how it could be split | 01:09 |
| rm_work | I already DID split it into two | 01:09 |
| rm_work | this COULD have been part of the last one | 01:09 |
| rm_work | jvrbanac: going from "no containers.py" to "have containers.py" and "have tests for containers.py" | 01:10 |
| rm_work | everything else is a few lines here and there, but all directly related <_< | 01:11 |
| *** lisaclark1 has joined #openstack-barbican | 01:11 | |
| jvrbanac | rm_work, yeah | 01:11 |
| rm_work | I mean, I could have cut out almost 400 lines of that if i didn't do the tests in this CR :) | 01:11 |
| rm_work | jvrbanac: would love to actually be working on something that's simple enough to do in 100 lines or less for once :) | 01:13 |
| *** lisaclark1 has left #openstack-barbican | 01:14 | |
| jvrbanac | rm_work, well, there are always hacking violations ;) | 01:14 |
| rm_work | I mean, I am totally down for fixing those! | 01:14 |
| jvrbanac | rm_work, I'm slowly trying to bring our code into compliance with hacking 0.9.2 | 01:14 |
| jvrbanac | as can be seen here: https://review.openstack.org/#/c/117334 | 01:15 |
| rm_work | but like... even my last 5 line change had ~200 lines of tests tacked on <_< | 01:15 |
| jvrbanac | lo! | 01:15 |
| jvrbanac | lol! | 01:15 |
| alee | woodster_, ? | 01:16 |
| jvrbanac | alee, woodster_ is out/mobile at the moment | 01:16 |
| rm_work | jvrbanac: well, I could like... tack onto that, I guess? | 01:16 |
| rm_work | if you want some assistance | 01:17 |
| alee | jvrbanac, thanks -- just checking on the off chance he was around | 01:17 |
| rm_work | and don't mind someone pushing patchsets onto your CR | 01:17 |
| alee | rm_work, thanks | 01:17 |
| * rm_work is sitting on a plane trying to find code to edit | 01:17 | |
| jvrbanac | rm_work, you can create a dependent CR ;) | 01:17 |
| rm_work | jvrbanac: well sure, but then if I fix stuff it'll still show up as broken when you run pep8 against your CR | 01:18 |
| alee | about to put up a new version of my cr for review. Feel free to take a look when you get a chance. | 01:18 |
| rm_work | because it'll be fixed in the next CR, not in yours :/ and then it'd just be confusing | 01:18 |
| jvrbanac | rm_work, it's not broken at the moment because we pin to an earlier version of hacking. To do the changes I just pop in the global req version of hacking and then remove it before submitting. | 01:19 |
| jvrbanac | alee, k | 01:19 |
| rm_work | right | 01:20 |
| rm_work | jvrbanac: actually, wouldn't it make sense just to update the hacking version *in that CR*? | 01:20 |
| rm_work | and by broken, I meant that I'm assuming you decide what to fix based on running the pep8 checks :P | 01:20 |
| rm_work | so stuff would come up in the report that was actually already fixed in the dependent CR | 01:20 |
| rm_work | which would make deciding what to work on a bit confusing | 01:21 |
| jvrbanac | rm_work, the reason I didn't change the requirements is because there are hundreds more of the violations, so the gates would never pass | 01:21 |
| rm_work | also rebasing constantly would be a PITA since it's random files all over the place we'd be changing, so good chances of accidentally overlapping | 01:21 |
| rm_work | jvrbanac: right, but... don't you want to get them ALL? :P | 01:22 |
| jvrbanac | rm_work, eventually yes, but small chunks remember? ;) | 01:22 |
| rm_work | heh | 01:22 |
| rm_work | ok, so are you DONE with that CR then? | 01:22 |
| jvrbanac | yeah | 01:22 |
| rm_work | if that's the case, then yeah, I could just do a dependent CR | 01:22 |
| rm_work | I thought you were still going to be updating it | 01:22 |
| jvrbanac | rm_work, no I'll just make dependent CR's for future work as well. | 01:23 |
| rm_work | kk | 01:23 |
| rm_work | it's funny, I noticed a lot of these issues just LOOKING | 01:23 |
| jvrbanac | I don't want to make these go more than 200 lines a pop | 01:23 |
| rm_work | and was like "hey, isn't that a hacking violation?" | 01:23 |
| rm_work | but didn't question it since they passed gate :P | 01:23 |
| rm_work | alright, I'll see if I can knock out ~200 lines before I land | 01:24 |
| jvrbanac | rm_work, nice! Thanks! | 01:24 |
| rm_work | might be optimistic :P | 01:24 |
| rm_work | hacking==0.9.2 ?? | 01:26 |
| igueths | Afk. | 01:27 |
| *** igueths has left #openstack-barbican | 01:27 | |
| rm_work | I feel like I should expense this $13 in-flight wifi :P | 01:28 |
| rm_work | well, at this rate tox won't have finished installing hacking/pep8 before I land >_> | 01:31 |
| *** gyee has quit IRC | 01:32 | |
| jvrbanac | rm_work, lol yeah | 01:33 |
| rm_work | it's a race, which will happen first -- I land, tox finishes setting up its environment, or Zuul actually finishes running the tests on my CR patchsets from 3.5 hours ago | 01:34 |
| rm_work | I think probably 2,1,3 | 01:34 |
| jvrbanac | rm_work, the official global req is: hacking>=0.9.2,<0.10 however, the latest is 0.9.2 at the moment | 01:35 |
| rm_work | k | 01:35 |
| rm_work | there we go | 01:38 |
| openstackgerrit | Ade Lee proposed a change to openstack/barbican: Additional work on certificate processing https://review.openstack.org/116956 | 01:45 |
| alee | jvrbanac, its up .. | 01:45 |
| alee | jvrbanac, depends on woodster_ cr which we both +2'd | 01:46 |
| jvrbanac | alee, awesome k | 01:46 |
| rm_work | man, this multi-line-comment-blank-line thing is super annoying | 01:46 |
| jvrbanac | rm_work, I know right! | 01:46 |
| rm_work | someone should give a good smack to whoever decided on that one | 01:47 |
| rm_work | couldn't we just like.... IGNORE H405 in our tox.ini? :P | 01:47 |
| rm_work | we already ignore some others | 01:47 |
| rm_work | this one is dumb >_< | 01:47 |
| jvrbanac | rm_work, I get the idea behind the rule, but yeah. Unfortunately, ignoring rules should only be seldom used. :/ | 01:51 |
| rm_work | yes, but I *already* HATE this one | 01:51 |
| rm_work | ah well, fixed a few of them already | 01:51 |
| jvrbanac | rm_work, it does kind of point out that we need better docstrings in places lol | 01:52 |
| rm_work | I guess <_< | 01:52 |
| rm_work | fixing these requires some creativity (lots of rewording) | 01:55 |
| jvrbanac | :D | 01:55 |
| *** openstackgerrit has quit IRC | 02:02 | |
| *** openstackgerrit has joined #openstack-barbican | 02:03 | |
| rm_work | jvrbanac: any easy way to check how many lines I've changed? | 02:04 |
| jvrbanac | git diff --stat | 02:04 |
| rm_work | ah, right | 02:04 |
| rm_work | only + counts, right? :P | 02:04 |
| jvrbanac | lol just try to keep it sensible. | 02:05 |
| jvrbanac | Large CR's tend to go to the bottom of my review pile | 02:06 |
| rm_work | LOLWUT does this even mean | 02:06 |
| rm_work | Iterator that prints the contents of a wrapper string iterator when iterated. | 02:06 |
| jvrbanac | what number? | 02:07 |
| rm_work | I think I am just going to remove the "when iterated." | 02:07 |
| rm_work | oh, that's the comment | 02:07 |
| rm_work | it's a multi-line docstrint | 02:07 |
| jvrbanac | oh lol! | 02:07 |
| rm_work | *docstring | 02:07 |
| rm_work | I am going to assume SOMEONE knows what that means | 02:07 |
| rm_work | is ./barbican/model/migration/alembic_migrations/env.py generated / exempt from hacking? | 02:10 |
| jvrbanac | For now yeah | 02:10 |
| rm_work | wow, some of these line continuation fixes are tough | 02:37 |
| rm_work | wow, some of these line continuation fixes are tough | 02:38 |
| rm_work | err | 02:38 |
| rm_work | oops | 02:38 |
| jvrbanac | rm_work, I'm glad they are forcing people to not use backslashes anymore they are a plague. | 02:39 |
| rm_work | yeah | 02:39 |
| rm_work | agree, but like | 02:39 |
| rm_work | running into a lot of "visual indentation cannot be distinguished from the following line" when trying to fix multi-clause `if` statements | 02:40 |
| rm_work | they can be really tricky to do (and honestly probably MORE ugly once "fixed") | 02:40 |
| jvrbanac | rm_work, depends. I end up reworking the layout a bit, perhaps handling some processing outside. | 02:42 |
| rm_work | heh | 02:42 |
| rm_work | so you actually were doing more than just rearranging in those cases | 02:42 |
| jvrbanac | rm_work, it really depends on the case. If you need a suggestion, send me the file and line number you're looking at | 02:43 |
| jvrbanac | phew! 2 hours later I finally finished that review rm_work | 02:46 |
| rm_work | heh | 02:47 |
| rm_work | well, I am about to submit a thing | 02:47 |
| rm_work | hopefully this is what you had in mind | 02:47 |
| rm_work | landing soon, so submitting this :( | 02:50 |
| rm_work | err, :) | 02:50 |
| jvrbanac | lol | 02:50 |
| rm_work | went through pretty literally just fixing the issues | 02:51 |
| openstackgerrit | Adam Harwell proposed a change to openstack/barbican: Making a few MORE modules hacking 0.9.2 compliant https://review.openstack.org/117404 | 02:51 |
| rm_work | didn't do much real refactoring, like I guess maybe you did in some cases | 02:51 |
| jvrbanac | rm_work, sweet | 02:52 |
| rm_work | same EXACT number of lines as yours, rofl | 02:52 |
| jvrbanac | haha! | 02:52 |
| rm_work | didn't even realize till i just looked | 02:52 |
| rm_work | ono, I got a -1 | 02:53 |
| jvrbanac | :( | 02:53 |
| rm_work | so, on the __str__ method crazy | 02:56 |
| rm_work | I agree, it's a little nuts | 02:56 |
| rm_work | I guess I could do something like that | 02:57 |
| jvrbanac | rm_work, lol I had to reread that 4 times to make sure I understood what was going on there | 02:57 |
| rm_work | heh | 03:00 |
| rm_work | I mean, the thing that's happening is not un-complicated | 03:00 |
| rm_work | I think jaosorior (spelling?) is correct in saying the entirety of all of the __str__ for the client classes need work | 03:01 |
| jvrbanac | they do | 03:01 |
| rm_work | maybe by letting cliff handle it | 03:01 |
| rm_work | the format functions for cliff would work great I think, assuming those can just be easily plugged in | 03:01 |
| rm_work | and that we'd be ok with using the cliff style formatting | 03:02 |
| jvrbanac | If cliff has them, that would be awesome | 03:02 |
| jvrbanac | I don't know what the formatting style is | 03:02 |
| jvrbanac | I haven't seen it | 03:02 |
| rm_work | ah | 03:02 |
| rm_work | it's like pretty-table kinda | 03:02 |
| jvrbanac | ewww | 03:02 |
| rm_work | lots of __ |||| | 03:02 |
| rm_work | boxes and shit | 03:02 |
| rm_work | designed for CLI output | 03:02 |
| rm_work | but so is __str__, really | 03:03 |
| jvrbanac | something about variable length secrets tends to not fit in tables very well ;) | 03:04 |
| rm_work | using *args in that wrapper simplifies the ones in the other classes too actually :P | 03:04 |
| rm_work | alright, think i got all of your comments addressed except the __str__ one | 03:06 |
| rm_work | oh, and the thing about RSAContainer could return CertificateContainer :P | 03:07 |
| rm_work | Technically yes, but I don't think that's necessarily a bad "feature". I could MAYBE see some confusion from a user who tries this and ends up with a different object type (I would definitely WTF myself), but the alternative is passing the type through and raising a TypeException or something in Container() if the fetched data isn't of the passed type. Do you think that's a better approach? | 03:08 |
| rm_work | jvrbanac: ^^ was my response | 03:08 |
| jvrbanac | rm_work, ahh... Personally, I'm really not a fan of multiple return types especially when you're asking for a specific object type. There's probably a couple of different ways to deal with this. | 03:10 |
| jvrbanac | Part of it is around making sure the factory gives you what you are asking for | 03:11 |
| rm_work | well, I have the way I mentioned already "done" | 03:11 |
| rm_work | if we want to do that | 03:11 |
| rm_work | it'll raise a TypeError if the response type and expected type don't match | 03:11 |
| rm_work | is that something you agree with? | 03:12 |
| jvrbanac | rm_work, I think that would work for now. I would like to get a couple other opinions on this. I would hate to start a pattern that then turns into an ugly beast 6 months down the road. | 03:13 |
| rm_work | yeah | 03:13 |
| rm_work | alright landing | 03:15 |
| jvrbanac | geez it's 10pm. I'm gonna head out. catch you later rm_work. btw I +2'ed your other CR | 03:15 |
| rm_work | will submit that fix in a bit | 03:15 |
| rm_work | cool | 03:15 |
| rm_work | well | 03:15 |
| jvrbanac | the one you just put up | 03:15 |
| rm_work | ah cool | 03:15 |
| rm_work | I have to do another patchset on the first one you +2'd | 03:15 |
| rm_work | to do the wrapper fix with *args | 03:15 |
| rm_work | since both of those classes use that too | 03:15 |
| jvrbanac | ahh ok | 03:16 |
| *** juantwo has quit IRC | 03:16 | |
| jvrbanac | well, just let me know when they're up and I'll take a look again | 03:16 |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient https://review.openstack.org/113393 | 03:16 |
| rm_work | this one is now | 03:16 |
| rm_work | lol | 03:16 |
| jvrbanac | lol ok, well I will look at it first thing in the morning | 03:17 |
| rm_work | and the other will be in about 10s :P | 03:17 |
| rm_work | yeah | 03:17 |
| rm_work | that is fine | 03:17 |
| rm_work | ah shoulda done this one first | 03:17 |
| rm_work | now I have to rebase the other one immediately >_> | 03:17 |
| rm_work | anywho, night! | 03:17 |
| *** juantwo has joined #openstack-barbican | 03:18 | |
| jvrbanac | lol night | 03:18 |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient https://review.openstack.org/115080 | 03:18 |
| openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient https://review.openstack.org/113393 | 03:19 |
| *** rm_work is now known as rm_work|away | 03:20 | |
| *** juantwo_ has joined #openstack-barbican | 04:04 | |
| *** juantwo has quit IRC | 04:08 | |
| *** juantwo_ has quit IRC | 04:11 | |
| *** rm_mobile has joined #openstack-barbican | 04:15 | |
| *** rm_mobile has quit IRC | 04:37 | |
| *** rm_mobile has joined #openstack-barbican | 04:37 | |
| *** rm_mobile has quit IRC | 04:49 | |
| *** rm_mobile has joined #openstack-barbican | 04:52 | |
| openstackgerrit | A change was merged to openstack/barbican-specs: Remove docutils pin https://review.openstack.org/117176 | 04:57 |
| *** rm_mobile has quit IRC | 04:59 | |
| *** woodster_ has quit IRC | 06:05 | |
| *** tkelsey has joined #openstack-barbican | 06:38 | |
| *** jaosorior has joined #openstack-barbican | 07:11 | |
| jaosorior | I know it's late for you guys, but rm_work, are you around? | 07:14 |
| redrobot | jaosorior it's actually only midnight for rm_work right now... but I think he may be done for the night. | 07:19 |
| jaosorior | yeah, just had to give it a shot, you never know | 07:19 |
| jaosorior | so what's up, redrobot, how's it going dude? | 07:22 |
| redrobot | jaosorior not too shabby... up way past my bed time. | 07:22 |
| redrobot | jaosorior got engaged a couple of weeks ago, so there's that | 07:23 |
| redrobot | soon there'll be a mrs. redrobot | 07:23 |
| jaosorior | aaaah crap! congrats dude! :D | 07:24 |
| redrobot | thanks! | 07:26 |
| *** jamielennox is now known as jamielennox|away | 08:36 | |
| *** tkelsey has quit IRC | 11:06 | |
| *** juantwo has joined #openstack-barbican | 12:14 | |
| *** juantwo has quit IRC | 12:17 | |
| *** juantwo has joined #openstack-barbican | 12:18 | |
| *** alee has quit IRC | 12:22 | |
| *** nkinder has quit IRC | 13:09 | |
| *** alee has joined #openstack-barbican | 13:32 | |
| *** woodster_ has joined #openstack-barbican | 13:44 | |
| *** paul_glass has joined #openstack-barbican | 13:45 | |
| *** SheenaG11 has quit IRC | 13:45 | |
| *** nkinder has joined #openstack-barbican | 14:04 | |
| *** samuelbercovici has joined #openstack-barbican | 14:14 | |
| chellygel | Good Morning everyone! | 14:16 |
| *** SheenaG1 has joined #openstack-barbican | 14:20 | |
| jaosorior | hey, chellygel, good morning :) | 14:22 |
| chellygel | hey jaosorior! good afternoon | 14:22 |
| jaosorior | how's it going? | 14:23 |
| chellygel | its thursday before a 3 day weekend. Soooooo | 14:23 |
| chellygel | hahah | 14:24 |
| chellygel | but, i can't complain -- its pretty good | 14:24 |
| chellygel | you? | 14:24 |
| jaosorior | 3 day weekend? niiiice | 14:24 |
| jaosorior | how come? | 14:24 |
| chellygel | we have labor day on monday | 14:25 |
| chellygel | i dont know much of the history behind it | 14:25 |
| chellygel | but basically, national free day off | 14:25 |
| jaosorior | hahaha hey, fair enough | 14:25 |
| chellygel | i take what i can get man | 14:26 |
| jaosorior | hahaha I feel you :P | 14:26 |
| jaosorior | any plans? | 14:26 |
| chellygel | nothing solid yet. still debating. May go visit friends, may just take a lazy weekend! | 14:27 |
| chellygel | labor day is known for terrible traffic -- and i think i'm allergic to it ;) | 14:27 |
| jaosorior | go the evening before it? | 14:28 |
| chellygel | its true, i could! | 14:28 |
| chellygel | you have any plans for the weekend? | 14:29 |
| chellygel | boulders to conquer? | 14:29 |
| jaosorior | some friends are gonna visit me from another city, and we'll party hard :P | 14:30 |
| chellygel | haha, yeah?? | 14:31 |
| jaosorior | haha yup | 14:32 |
| jaosorior | lets see how it goes | 14:32 |
| *** atiwari has joined #openstack-barbican | 14:45 | |
| alee | jaosorior, thanks for review. responded to your comments | 14:53 |
| alee | woodster_, ping - had a chance to take a look yet? | 14:54 |
| woodster_ | alee: I'm looking at it now | 14:54 |
| alee | woodster_, great | 14:59 |
| jvrbanac | woodster_, tossed a quick question for you on https://review.openstack.org/#/c/115301/ | 15:10 |
| jaosorior | alee: certificate_manager instead of cm or cert_mgr would be better IMO | 15:10 |
| woodster_ | jvrbanac: I'll take a look shortly.... | 15:10 |
| chellygel | jaosorior, for the sake of being explicit? | 15:12 |
| chellygel | certificate_manager, that 20 characters of my 80! not including the 4 for tabs! lol | 15:12 |
| jaosorior | I don't see that as an argument :P | 15:13 |
| chellygel | im just curious as to why that is your preference | 15:13 |
| jaosorior | but if there REALLY is a need to keep it short, the shortest I would think would be acceptable would be cert_mgr | 15:13 |
| woodster_ | alee: Just added comments now....the retry stuff we really need to flesh out. I'll start a etherpad for it.... | 15:13 |
| jaosorior | for the sake of being explicit and completely unambiguous | 15:14 |
| jaosorior | I think it's generally a good practice to have variable names that are actually pronounceable. if the code needs more than those 80 characters, then might as well revise the algorithm. Simplicity FTW ;) | 15:15 |
| openstackgerrit | A change was merged to openstack/barbican: Updated Get Secrets request and response https://review.openstack.org/117352 | 15:15 |
| chellygel | so, would cert_manager work? | 15:15 |
| jraim__ | reaperhulk: you there? | 15:16 |
| jraim__ | redrobot: you there? | 15:16 |
| jaosorior | I would be OK with cert_manager, though I would still prefer the full word :P | 15:16 |
| openstackgerrit | A change was merged to openstack/barbican: Updated Create Secret request and response https://review.openstack.org/117379 | 15:16 |
| chellygel | i'll add the comment! thanks -- still learning the whole python thing :) | 15:17 |
| jraim__ | woodster_: you there? | 15:17 |
| woodster_ | jaim: yes | 15:17 |
| jraim__ | question about the 'Add support to order new and modify existing SSL certs.' | 15:18 |
| jraim__ | spec | 15:18 |
| jraim__ | launchpad says started | 15:18 |
| jraim__ | is that code going to land for j3? | 15:18 |
| jaosorior | chellygel: what comment? | 15:18 |
| chellygel | i added the "cert_manager" comment to alee's change, so others can weigh in | 15:19 |
| jaosorior | uok | 15:19 |
| *** paul_glass has quit IRC | 15:19 | |
| jraim__ | woodster_: ^^ | 15:20 |
| woodster_ | jraim: let me take a look at the specs CR for it...I think that was merge in, and if so, yes landing for Juno M3 | 15:21 |
| jraim__ | okay, we need to clean up the BP listing for J3 so I'm trying to figure out what's done and what is going to be pushed | 15:21 |
| woodster_ | jraim: oh got you. I think Douglas has been trying to clean things up out there as well, I'll give him a heads up when I see him | 15:22 |
| woodster_ | jraim: when do you need this Juno-cut info by? Can we flesh that out this afternoon? | 15:23 |
| jraim__ | that's fine. I have a meeting with ttx in a few minutes and I want to make sure we have an idea. | 15:24 |
| jraim__ | of where we are | 15:24 |
| woodster_ | jraim: regarding SSL plans specifically, this blueprint covers the SSL certificate work we planned on doing (see the Work Items section): https://github.com/openstack/barbican-specs/blob/master/specs/juno/add-ssl-ca-support.rst | 15:24 |
| woodster_ | jraim: got it | 15:25 |
| jraim__ | BPs / specs are fine. We just need ot make sure that everything that got landed that had a spec, the BP that corresponds to that spec is linked to the J release it was in | 15:25 |
| jraim__ | before we cut j3 next week | 15:25 |
| woodster_ | jraim: yes, we have been having regular conversations about that, but the blueprints in LP probably need to be polished to reflect that. The big changes are for: 1) the new orders resource format (backwards compatible to the old one though), 2) to allow for PUTs to the orders resource, 3) removing the tenant-id from the URI, 4) adding an optional consumers | 15:31 |
| woodster_ | registration for containers, 5) adding transport-key wrapping support. | 15:31 |
| jraim__ | cool. We'll also have to talk about what we do with approved specs that didn't make it into Juno. Nova is actually requiring that the submitter resubmit the spec for Kilo rather than port them over | 15:32 |
| jraim__ | I kind of like that idae | 15:32 |
| *** samuelbercovici has quit IRC | 15:33 | |
| *** paul_glass has joined #openstack-barbican | 15:33 | |
| redrobot | jraim__ there's a couple of BPs in j-3 with a ton of CRs, so it'll take me a min to sort those out | 15:33 |
| woodster_ | alee: Please weigh in on this CR when you can: https://review.openstack.org/#/c/116387/ | 15:34 |
| jaosorior | woodster_: I actually made a comment about that CR | 15:35 |
| jraim__ | redrobot: no hurry, just wanted to be able to tell ttx that we are on it | 15:35 |
| redrobot | jraim__ the only one I'm not sure about status is reaperhulk's refactor of PKCS11 | 15:35 |
| redrobot | I think it's in-progress now? | 15:36 |
| woodster_ | jaosorior: I just noticed that now...I'll take a look at those, thanks | 15:36 |
| woodster_ | redrobot: yes, he is looking at that now | 15:36 |
| openstackgerrit | Kaitlin Farr proposed a change to openstack/barbican: Add PyKMIP to requirements https://review.openstack.org/117539 | 15:37 |
| woodster_ | redrobot: might require data model mods, which wouldn't be affected by J3 deadline I'd think as long as have migration scripts. Might also require tweaks to the HSM plugin interface though...I still need to talk to Paul about that. | 15:37 |
| redrobot | Is Kaitlin around? | 15:38 |
| jraim__ | redrobot: I pinged him this morning, but it's still early for him :) | 15:39 |
| reaperhulk | it is totally early | 15:39 |
| reaperhulk | and i am fighting swig. | 15:39 |
| reaperhulk | so...who knows. | 15:39 |
| jraim__ | you haz a sad | 15:39 |
| woodster_ | reaperhulk: See my last comments to redrobot above ^^^^ | 15:39 |
| redrobot | so maybe "slow progress" instead of "good progress" would be a better status :) | 15:39 |
| reaperhulk | woodster_ cool | 15:39 |
| jraim__ | it's not biggie if it doesn't land for j3, we just need to retarget it for k1 and land it in a branch until Juno stable is out | 15:39 |
| woodster_ | well, it would be good to using the revised HSM approach sooner than Kilo I think :) | 15:41 |
| redrobot | does that mean Juno won't support PKCS11 HSMs? | 15:42 |
| woodster_ | well, this is the MEK approach vs the current per-tenant approach I believe | 15:42 |
| alee | woodster_, lets leave the fleshing out of exactly what needs to happen to schedule a retry task to a subsequent CR. | 15:43 |
| jraim__ | woodster_: then it needs to be in for j3. After that, we shouldn;t be landing big features. | 15:43 |
| jraim__ | We can land the work, it'll just wont be in the Juno release | 15:43 |
| jraim__ | It'll be in a K1 branch that we can merge to master once we cut the j-stable | 15:43 |
| alee | woodster_, we can keep what I have so far, but realize that its subject to change later. and if we change it, everything we need will be there. | 15:44 |
| alee | woodster_, agreed? | 15:45 |
| woodster_ | alee: I think so, but I still would prefer the private functions to be pushed lower than the public ones in certificate_manager.py | 15:46 |
| alee | woodster_, ok agreed -- I'm making all those changes now | 15:46 |
| woodster_ | alee: nice, thanks | 15:46 |
| *** gyee has joined #openstack-barbican | 15:47 | |
| alee | woodster_, are we ready to push https://review.openstack.org/#/c/115715/6 ? | 15:47 |
| woodster_ | alee: I've been ready. :) | 15:49 |
| alee | woodster_, :) maybe we can recruit some of the troops ? | 15:50 |
| woodster_ | alee: ha! for sure | 15:51 |
| alee | reaperhulk, can we get a woop woop -- https://review.openstack.org/#/c/115715 ? | 15:51 |
| alee | woodster_, I'm thinking that perhaps we get my CR in after yours -- and then you rebase and get your events one and 116387 | 15:52 |
| alee | (116287 will need to be adjusted most likely) | 15:53 |
| woodster_ | alee: yeah, that's been my hope, getting all the puzzle pieces in there. | 15:53 |
| alee | woodster_, we should also get a cr in adding order substatus and message | 15:53 |
| alee | woodster_, you could probably whip that up in a heartbeat .. | 15:54 |
| reaperhulk | approved | 15:54 |
| woodster_ | alee: ha! Yes, that *should* be a simple one | 15:56 |
| alee | reaperhulk, fantastic -- I'll be pinging you for mine shortly (I hope)! | 15:57 |
| *** jraim__ has quit IRC | 16:06 | |
| *** jraim_ has joined #openstack-barbican | 16:06 | |
| *** rm_mobile has joined #openstack-barbican | 16:06 | |
| openstackgerrit | A change was merged to openstack/barbican: Add a py3pep8 tox job. This will verify py3 compliant syntax https://review.openstack.org/116725 | 16:08 |
| openstackgerrit | A change was merged to openstack/barbican: Initial connect orders resource to certificate processing https://review.openstack.org/115715 | 16:15 |
| rm_mobile | Hey jaosorior , I'm awake now :) | 16:17 |
| rm_mobile | Went -2 timezones, it's early | 16:17 |
| *** arunkant_work has joined #openstack-barbican | 16:18 | |
| arunkant_work | juantwo, Can you look into my reply of https://review.openstack.org/#/c/110817/13/barbican/model/repositories.py,cm and let me know if you still want me to add TODO and submit new patch | 16:19 |
| *** rm_work|away is now known as rm_work | 16:19 | |
| redrobot | arunkant_work Juan Antonio Osorio Robles is jaosorior | 16:20 |
| juantwo | ^ | 16:21 |
| jaosorior | ouh, sorry rm_mobile, leaving actually :/ | 16:21 |
| jaosorior | or rm_work | 16:22 |
| rm_work | lol k | 16:22 |
| rm_work | I need to check for reviews | 16:22 |
| rm_work | it's early here and i'm in ETO, but whatev :P | 16:22 |
| rm_work | gotta get my CRs in :P | 16:22 |
| jaosorior | arunkant_work: I'll leave a 0 score to see if woodster_ or someone else weighs in, if by tomorrow nobody has, then I'll +1 it | 16:23 |
| arunkant_work | redrobot, thanks. | 16:25 |
| *** akoneru has joined #openstack-barbican | 16:27 | |
| woodster_ | jvrbanac: John, can you take a look at the comments at the top of this CR: https://review.openstack.org/#/c/110817/13/barbican/queue/keystone_listener.py,cm | 16:38 |
| akoneru | reaperhulk, ping | 16:39 |
| woodster_ | dos Juans | 16:39 |
| alee | woodster_, did we decide retry_time could be zero? | 16:46 |
| alee | woodster_, and if so - what does that mean? | 16:46 |
| woodster_ | alee: I think a retry of <= 0 could mean no retry at all | 16:47 |
| alee | ok | 16:47 |
| rm_work | jaosorior: i guess you are probably gone/ | 16:48 |
| akoneru | ping. Hi. I am trying to run the unit tests for barbican. I followed the Quick start guide and setup a virtual environment. I also setup the oslo-incubator project. | 16:50 |
| redrobot | hi akoneru | 16:50 |
| * rm_work waves at akoneru | 16:50 | |
| redrobot | akoneru unit tests are run via tox | 16:50 |
| akoneru | When i run bin/barbican.sh, i see this in the log - http://fpaste.org/129376/40924392/ | 16:50 |
| redrobot | ugh... yeah... barbican.sh sucks... | 16:50 |
| * akoneru Namasthe! | 16:51 | |
| redrobot | we really need to either fix barbican.sh or get rid of it | 16:51 |
| akoneru | but the test runs fine when run in PyCharm | 16:51 |
| redrobot | akoneru to run unit tests, first pip install tox | 16:51 |
| *** gyee has quit IRC | 16:51 | |
| redrobot | akoneru then run "tox" for the full suite | 16:51 |
| akoneru | redrobot, hmm. ok. will try that. | 16:52 |
| redrobot | akoneru or tox -e py27 for python 2.7 only, tox -e pep8 for pep8 only, etc | 16:52 |
| redrobot | akoneru tox is what the Gerrit gates use, not barbican.sh | 16:52 |
| akoneru | redrobot, hmm. ok. so the output i shared is from the nosetests call? Any idea as to why i get it when i am able to run the test fine in PyCharm? | 16:53 |
| akoneru | redrobot, just wanted to confirm that there is nothing wrong with my setup | 16:54 |
| redrobot | akoneru not familiar with PyCharm. But yes, that is a bug with barbican.sh | 16:54 |
| redrobot | akoneru barbican.sh uses nose, which was removed from the project in favor of testtools | 16:55 |
| akoneru | redrobot, oh. ok. thanks! i will try tox. | 16:56 |
| redrobot | akoneru filed a bug for the barbican.sh error https://bugs.launchpad.net/barbican/+bug/1362714 | 16:58 |
| *** rellerreller has joined #openstack-barbican | 16:58 | |
| akoneru | redrobot, thanks! | 17:00 |
| reaperhulk | akoneru did redrobot cover everything? :) | 17:00 |
| akoneru | reaperhulk, yes | 17:00 |
| reaperhulk | great | 17:00 |
| openstackgerrit | Adam Harwell proposed a change to openstack/barbican: Making a few MORE modules hacking 0.9.2 compliant https://review.openstack.org/117404 | 17:02 |
| rm_work | jvrbanac: you need to rebase https://review.openstack.org/#/c/117334/1 | 17:03 |
| rm_work | i was able to submit my changes with "git review -R" but you have rebase issues in your commit that gerrit was complaining about :P | 17:03 |
| *** paul_glass has quit IRC | 17:07 | |
| openstackgerrit | Ade Lee proposed a change to openstack/barbican: Additional work on certificate processing https://review.openstack.org/116956 | 17:09 |
| rm_work | gah wtf, I'm on ETO, what am I doing working all morning >_< | 17:10 |
| alee | woodster_, jvrbanac , hockeynut, jaosorior - new CR uploaded | 17:11 |
| alee | reaperhulk, ^^ | 17:11 |
| alee | chellygel, ^^ | 17:12 |
| *** kebray has joined #openstack-barbican | 17:14 | |
| *** juantwo has quit IRC | 17:19 | |
| *** alee is now known as alee_lunch | 17:21 | |
| *** rellerreller has quit IRC | 17:30 | |
| chellygel | thanks alee_lunch | 17:32 |
| *** bdpayne has joined #openstack-barbican | 17:34 | |
| *** paul_glass has joined #openstack-barbican | 17:39 | |
| woodster_ | akoneru: barbican.sh was intended to be a quick and dirty local installer tool...that test step should definitely be removed | 18:08 |
| *** paul_glass has quit IRC | 18:14 | |
| *** gyee has joined #openstack-barbican | 18:21 | |
| woodster_ | speakers for openstack: https://openstacksummitnovember2014paris.sched.org/directory/speakers/4#attendee-list | 18:24 |
| *** paul_glass has joined #openstack-barbican | 18:26 | |
| rm_work | woodster_: turns out I am going, so maybe I'll be able to do the thing i wanted to do as a brown-bag talk, since the talk I was a part of didn't make it | 18:26 |
| *** rm_work is now known as rm_work|away | 18:37 | |
| *** rm_mobile has quit IRC | 18:40 | |
| woodster_ | alee: Checkout https://openstacksummitnovember2014paris.sched.org/event/b33df98d88388ec57ce958d0a0c47c66#.U_9334BdUjA | 18:42 |
| *** jaosorior has quit IRC | 18:42 | |
| *** juantwo has joined #openstack-barbican | 18:46 | |
| woodster_ | alee: have to figure out how to add rellerreller to that talk as well | 18:51 |
| woodster_ | alee_lunch: See above comments please ^^^^ | 18:51 |
| openstackgerrit | John Vrbanac proposed a change to openstack/barbican: Making a few modules hacking 0.9.2 compliant https://review.openstack.org/117334 | 18:56 |
| *** alee_lunch is now known as alee | 18:56 | |
| alee | woodster_, hey looks good - and yes , we should | 18:57 |
| alee | (figure out a way to add rellerreller | 18:58 |
| alee | assuming he's going .. | 18:58 |
| alee | woodster_, had a chance to review CR? | 18:58 |
| *** SheenaG1 has quit IRC | 19:02 | |
| *** ametts has joined #openstack-barbican | 19:04 | |
| reaperhulk | So, I see rellerreller is trying to get pykmip into global reqs...anybody know why? Seems like it has no need to be present in global requirements just like pykcs11 and the dogtag pki lib don't need to be there | 19:11 |
| openstackgerrit | Kaitlin Farr proposed a change to openstack/barbican: Add PyKMIP to requirements https://review.openstack.org/117539 | 19:13 |
| *** rm_mobile has joined #openstack-barbican | 19:23 | |
| *** openstackgerrit has quit IRC | 19:31 | |
| *** openstackgerrit has joined #openstack-barbican | 19:33 | |
| *** kebray has joined #openstack-barbican | 19:38 | |
| *** kebray has quit IRC | 19:39 | |
| jraim_ | ha, perfect timimg | 19:44 |
| alee | woodster_, ping | 19:47 |
| woodster_ | alee: hello | 19:47 |
| alee | woodster_, when do we plan to normalize all secrets to base 64 before storing? | 19:47 |
| woodster_ | alee: I thought that was already going on? | 19:48 |
| alee | I still see a TODO in there .. | 19:48 |
| alee | plugin/resources.py line 101 | 19:49 |
| woodster_ | ah yes, good find | 19:51 |
| alee | woodster_, looks to me like we're passing in a byte array and the content type to the plugins .. | 19:52 |
| alee | am i reading that correctly? | 19:52 |
| woodster_ | alee: yep, per tr.normalize_before_encryption() logic | 19:53 |
| alee | woodster_, so is this going to change in juno? | 19:53 |
| woodster_ | alee: so I think tr.normalize_before_encryption() should do the base64 conversion and return that as unencrypted | 19:54 |
| alee | sure -- just wanted to know when we wanted to land that change | 19:54 |
| alee | so I can adjust the dogtag plugin accordingly | 19:54 |
| woodster_ | alee: I think it needs to, if I recall rellerreller right...I think he was expecting this for their KMIP work. | 19:54 |
| alee | ok - another one on the list then :/ | 19:55 |
| *** SheenaG1 has joined #openstack-barbican | 19:59 | |
| alee | woodster_, so had a chance to look at my cr? | 20:05 |
| *** rm_mobile has quit IRC | 20:19 | |
| *** rm_mobile has joined #openstack-barbican | 20:19 | |
| woodster_ | alee: just +2ed it...zuul is still pending it looks like | 20:22 |
| alee | woodster_, cool - yeah zuul on its coffee break | 20:22 |
| woodster_ | Regarding Juan's comment in my remove config parameter CR: https://review.openstack.org/#/c/116387/3/barbican/model/repositories.py,cm | 20:27 |
| *** paul_glass has quit IRC | 20:27 | |
| woodster_ | ....does anyone have a preference of his dict of repositories approach vs the CR's separate getter functions approach? | 20:27 |
| woodster_ | alee: ^^^^ | 20:28 |
| alee | jvrbanac, reaperhulk , chellygel , hockeynut -- my CR needs some love please :) | 20:29 |
| alee | woodster_, let me look .. give me a few mins -- in the middle of some dogtag reviews .. | 20:29 |
| woodster_ | jvrbanac: I added a response to your comment in the cert event CR here: https://review.openstack.org/#/c/115301/7/barbican/plugin/interface/certificate_manager.py,cm | 20:30 |
| woodster_ | alee: no problem, thanks | 20:30 |
| chellygel | alee, sure, reading now | 20:30 |
| alee | thanks | 20:31 |
| *** woodster_ is now known as woodster | 20:32 | |
| chellygel | hey alee, | 20:40 |
| chellygel | on your plugin/dogtag.py -- you have cm as the import still instead of cert_manager, i know its existing code -- would it be better to keep that consistent ? | 20:41 |
| chellygel | it can be a separate CR, just curious. | 20:41 |
| alee | chellygel, yeah - I'll do that in a separate CR | 20:42 |
| alee | chellygel, doing it in this one would just obscure the changes | 20:43 |
| chellygel | yeah, makes sense to me! | 20:43 |
| chellygel | i'll add the comment on my vote | 20:43 |
| chellygel | w/ "separate cr" of course :) | 20:43 |
| alee | thanks | 20:43 |
| *** AndChat|40521 has joined #openstack-barbican | 20:50 | |
| *** rm_mobile has quit IRC | 20:50 | |
| alee | reaperhulk, https://review.openstack.org/#/c/116956/ needs a woop woop please :) | 20:52 |
| *** rm_work|away is now known as rm_work | 20:52 | |
| *** AndChat|40521 has quit IRC | 20:53 | |
| reaperhulk | alee: curious about the CA_PLUGIN_TYPE_DOGTAG and CA_PLUGIN_TYPE_SYMANTEC constants. Are those used anywhere/will they be used in an upcoming CR? | 20:53 |
| openstackgerrit | Adam Harwell proposed a change to openstack/barbican: Making a few MORE modules hacking 0.9.2 compliant https://review.openstack.org/117404 | 20:57 |
| rm_work | alright, rebased now | 20:58 |
| rm_work | thanks jvrbanac | 20:58 |
| alee | reaperhulk, I think they are used -- or at least the dogtag one is used in this CR | 21:08 |
| reaperhulk | ah yeah I see it | 21:09 |
| alee | reaperhulk, but yes - the idea is that a client could send in the preferred vendor | 21:09 |
| alee | and the plugin supports method will need to say it supports that type | 21:09 |
| reaperhulk | I'm less familiar with the certificate implementation than I probably should be but this lgtm | 21:10 |
| alee | reaperhulk, awesome -- woop woop? | 21:10 |
| reaperhulk | approved | 21:10 |
| alee | cool beans | 21:10 |
| alee | woodster, we're on a roll .. | 21:11 |
| rm_work | I forget, is thursday a merge/sprint meeting for you guys usually? | 21:11 |
| woodster | rm_work: you mean us? Ours is on alternate Tuesdays | 21:12 |
| rm_work | ah Tuesday | 21:12 |
| rm_work | woodster: but while I have you responding... https://review.openstack.org/#/c/113393/ :P | 21:13 |
| *** kebray has joined #openstack-barbican | 21:14 | |
| alee | woodster, I have to think about whether I prefer Juan's approach or the get_xxx_repository() one. | 21:18 |
| alee | woodster, overall I'm more inclined to the get_xxx_repository() | 21:19 |
| alee | woodster, makes things more explicit | 21:19 |
| woodster | alee: yeah, I like not having multiple get functions, but not liking having to provide a string to the one finder function | 21:19 |
| woodster | alee: yeah, explicit seems better to me as well | 21:19 |
| woodster | alee: you want to add a comment along those lines? | 21:20 |
| *** SheenaG1 has quit IRC | 21:20 | |
| alee | woodster, overall , I think the approach in the cr is good. I'm not too keen about having StoreCryptoPlugin not inherit from SecretStoreBase though | 21:20 |
| alee | why can't you define a helper function _get_context() that gets the context you need in the functions in StoreCryptoPlugin ? | 21:22 |
| alee | woodster, need to think on this some more, but there must be a way to do it .. | 21:24 |
| woodster | alee: yeah, but I don't think it really could without attaching the information out of band to the call, which would make this a stateful operation...no bueno! Also, this is a one-off plugin...a barbican core adapter to a different set of plugins. I think it's fair to treat it in a one-off way. | 21:24 |
| alee | ok - If I can't think of anything else thats clever - I'll approve it. | 21:26 |
| woodster | alee: ha! that's cool, thanks | 21:26 |
| alee | woodster, I thought though that we were going to try to get rid of all the repos being passed around .. | 21:26 |
| woodster | alee: I wanted this CR to get landed first (which converts some of the repos to module singletons), then follow up with a CR that removes them all using that same pattern (whichever pattern gets accepted in this CR). | 21:27 |
| alee | ok | 21:28 |
| *** nkinder has quit IRC | 21:39 | |
| *** akoneru has quit IRC | 21:59 | |
| *** alee has quit IRC | 22:04 | |
| atiwari | woodster, yt? | 22:39 |
| *** akoneru has joined #openstack-barbican | 22:49 | |
| openstackgerrit | A change was merged to openstack/barbican: Additional work on certificate processing https://review.openstack.org/116956 | 23:02 |
| *** nkinder has joined #openstack-barbican | 23:05 | |
| *** alee has joined #openstack-barbican | 23:08 | |
| *** atiwari has quit IRC | 23:09 | |
| *** arunkant_work has quit IRC | 23:18 | |
| *** akoneru has quit IRC | 23:26 | |
| rm_work | anyone around? jvrbanac ? | 23:30 |
| rm_work | woodster? | 23:30 |
| *** SheenaG1 has joined #openstack-barbican | 23:40 | |
| *** SheenaG11 has joined #openstack-barbican | 23:43 | |
| *** SheenaG1 has quit IRC | 23:45 | |
| *** openstackgerrit has quit IRC | 23:46 | |
| *** jamielennox|away is now known as jamielennox | 23:47 | |
| *** openstackgerrit has joined #openstack-barbican | 23:47 | |
| rm_work | so, I have a draft of an alternate __str__ format for the client objects, going to submit it as a possible thing, could always roll it back. | 23:54 |
| rm_work | or, maybe I'll wait for Juan to be on at the same time as me so we can talk about it :P | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!