| openstackgerrit | Douglas Mendizábal proposed openstack/python-barbicanclient: Add secret_type to Secret constructor https://review.openstack.org/160561 | 00:02 |
|---|---|---|
| *** zz_dimtruck is now known as dimtruck | 00:02 | |
| *** kfox1111 has joined #openstack-barbican | 00:05 | |
| kfox1111 | So, what can I do to get more reviewers looking at the spec and such? | 00:09 |
| kfox1111 | Still would kind of like to get it into kilo if possible. | 00:09 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/barbican: Updated from global requirements https://review.openstack.org/160564 | 00:13 |
| *** chlong has quit IRC | 00:15 | |
| *** igueths has quit IRC | 00:17 | |
| *** jkf has quit IRC | 00:41 | |
| *** kfox1111 has quit IRC | 01:12 | |
| *** dimtruck is now known as zz_dimtruck | 01:38 | |
| *** bdpayne has quit IRC | 01:45 | |
| *** lisaclark1 has joined #openstack-barbican | 01:52 | |
| *** crc32 has joined #openstack-barbican | 02:49 | |
| *** lisaclark1 has quit IRC | 02:50 | |
| *** bdpayne has joined #openstack-barbican | 03:07 | |
| openstackgerrit | Steve Heyman proposed openstack/python-barbicanclient: Updated test to use both identity v2 and v3 https://review.openstack.org/160619 | 03:16 |
| *** bdpayne has quit IRC | 03:21 | |
| *** zz_dimtruck is now known as dimtruck | 03:30 | |
| *** crc32 has quit IRC | 04:22 | |
| *** dimtruck is now known as zz_dimtruck | 04:29 | |
| *** david-lyle_afk has joined #openstack-barbican | 05:06 | |
| *** rm_you has joined #openstack-barbican | 05:19 | |
| *** rm_you has quit IRC | 05:19 | |
| *** rm_you has joined #openstack-barbican | 05:19 | |
| *** dave-mccowan has quit IRC | 05:38 | |
| *** david-lyle_afk has quit IRC | 05:44 | |
| *** rm_you| has joined #openstack-barbican | 06:17 | |
| *** rm_you has quit IRC | 06:19 | |
| *** redrobot has quit IRC | 06:21 | |
| *** gyee has quit IRC | 06:22 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Fix functional tests to use new auth provider interface https://review.openstack.org/160455 | 06:24 |
| *** redrobot has joined #openstack-barbican | 06:25 | |
| *** redrobot is now known as Guest32544 | 06:25 | |
| *** jaosorior has joined #openstack-barbican | 06:30 | |
| *** russell_h has quit IRC | 06:38 | |
| *** david-lyle_afk has joined #openstack-barbican | 06:44 | |
| *** jroll has quit IRC | 06:49 | |
| *** jroll has joined #openstack-barbican | 06:59 | |
| *** xaeth_afk has quit IRC | 07:04 | |
| *** dstufft has joined #openstack-barbican | 07:14 | |
| *** xaeth_afk has joined #openstack-barbican | 07:16 | |
| *** AnxiousGarlic has joined #openstack-barbican | 07:20 | |
| *** woodster_ has quit IRC | 07:20 | |
| *** AnxiousGarlic has left #openstack-barbican | 07:20 | |
| *** openstackgerrit has quit IRC | 07:22 | |
| *** openstackgerrit has joined #openstack-barbican | 07:22 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Use urljoin instead of os.path.join https://review.openstack.org/160250 | 07:33 |
| *** dstufft has left #openstack-barbican | 07:56 | |
| *** eglute has quit IRC | 08:26 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Use urljoin instead of os.path.join https://review.openstack.org/160250 | 08:30 |
| *** eglute has joined #openstack-barbican | 08:31 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Get rid of Repositories class https://review.openstack.org/160329 | 08:44 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Add default max payload to functional test conf registry https://review.openstack.org/160718 | 10:00 |
| *** darrenmoffat has quit IRC | 10:09 | |
| *** darrenmoffat has joined #openstack-barbican | 10:11 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Use oslo_log in db-manage script https://review.openstack.org/160735 | 10:58 |
| *** nickrmc83 has quit IRC | 11:33 | |
| *** nickrmc83 has joined #openstack-barbican | 11:39 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Do not filter empty strings https://review.openstack.org/160772 | 12:32 |
| *** dave-mccowan has joined #openstack-barbican | 12:48 | |
| *** jroll has quit IRC | 13:07 | |
| *** jroll has joined #openstack-barbican | 13:07 | |
| *** woodster_ has joined #openstack-barbican | 13:37 | |
| *** alee has quit IRC | 13:42 | |
| *** rellerreller has joined #openstack-barbican | 13:47 | |
| *** nkinder has quit IRC | 14:24 | |
| *** chlong has joined #openstack-barbican | 14:27 | |
| jaosorior | woodster_, jvrbanac, hockeynut: so yesterday I had a fox for the gate issues but I had messed up the import order, but here's the fixed CR https://review.openstack.org/#/c/160455/ | 14:29 |
| openstackgerrit | Steve Heyman proposed openstack/python-barbicanclient: Updated functional tests to use both identity v2 and v3 https://review.openstack.org/160619 | 14:35 |
| hockeynut | jaosorior sounds good. always a good idea to have a fox at the gate :-) | 14:39 |
| hockeynut | jaosorior also thx for catching the "V2" in my CR...updated version is up | 14:39 |
| jaosorior | Lol fix | 14:50 |
| *** kgriffs|afk is now known as kgriffs | 14:51 | |
| *** alee has joined #openstack-barbican | 14:54 | |
| *** zz_dimtruck is now known as dimtruck | 14:58 | |
| woodster_ | arunkant, I added a question to the audit spec please | 15:06 |
| *** nkinder has joined #openstack-barbican | 15:08 | |
| *** ametts has quit IRC | 15:10 | |
| *** xaeth_afk is now known as xaeth | 15:11 | |
| *** igueths has joined #openstack-barbican | 15:13 | |
| woodster_ | all: please review this one, to finally get rid of the passed-around repos!: https://review.openstack.org/#/c/160329 | 15:14 |
| jaosorior | yay :D | 15:17 |
| jaosorior | and sorry for the big commit | 15:17 |
| woodster_ | I didn't realize how invasive that repo stuff really was! | 15:18 |
| jaosorior | hockeynut: can you elaborate on your comment here? https://review.openstack.org/#/c/160250/4/functionaltests/common/client.py | 15:18 |
| hockeynut | jaosorior sure. we've merged https://review.openstack.org/#/c/127865/ so the /v1 is no more in the URL | 15:19 |
| hockeynut | just suggesting we remove that from the comment | 15:19 |
| jaosorior | hockeynut: while v1 is no longer in the url, it will still be used to access the API, as far as I can tell. It is even reflected by this change: https://review.openstack.org/#/c/158132/ | 15:21 |
| jaosorior | so the change you are referring to is a change to the keystone endpoints, but the version will still be used when accessing the server | 15:22 |
| jaosorior | or... did I get it wrong? | 15:22 |
| hockeynut | I think that means that its host/secrets and not host/v1/secrets | 15:22 |
| jaosorior | hockeynut: it will still be host/v1/secrets | 15:23 |
| jaosorior | only thing is that the keystone endpoint is now registered to host, and not host/v1 | 15:23 |
| hockeynut | jaosorior so we will add the v1 ourselves rather than depending on it coming out of service catalog from keystone | 15:23 |
| jaosorior | at least that's the way it's implemented in the client at the moment | 15:23 |
| jaosorior | I guess getting that out of the keystone catalog should be done in another way? | 15:24 |
| jaosorior | at the moment doing host/secrets returns 404 | 15:24 |
| *** paul_glass has joined #openstack-barbican | 15:24 | |
| hockeynut | hmm...checking on my side too | 15:24 |
| jaosorior | which is what used to happen accidentally before I appended the slash there | 15:24 |
| jaosorior | actually, yeah, keystone should be returning the version. At least readon from the tempest code. But still, the version is going to be in the url | 15:30 |
| jaosorior | or, well, it's needed in the url | 15:31 |
| jaosorior | but actually, the intent of the comment wasn't related to the version, but actually, to the fact that URLs without the slash in the end would not be joined correctly with the urlparse.join | 15:31 |
| jaosorior | * urlparse.urljoin | 15:31 |
| jaosorior | me adding the localhost/v1 was actually just an example | 15:32 |
| *** lisaclark1 has joined #openstack-barbican | 15:36 | |
| *** SheenaG1 has joined #openstack-barbican | 15:40 | |
| jaosorior | hockeynut: do you happen to know why the tests are ran inside the post_test_hook.sh in the functionaltests folder? | 15:41 |
| hockeynut | jaosorior good question - I will guess that it is to ensure that we run AFTER everything else. Might want to check with jvrbanac since I believe he added this initially | 15:44 |
| *** kfarr has joined #openstack-barbican | 15:44 | |
| hockeynut | jaosorior ok, my confusion is coming to an end :-) I see that we DO have v1 in our URL...just not in the service catalog | 15:48 |
| hockeynut | so I retract my comment in your CR | 15:48 |
| *** kfarr has quit IRC | 16:04 | |
| *** rellerreller has quit IRC | 16:04 | |
| *** atiwari has joined #openstack-barbican | 16:14 | |
| *** dave-mccowan has quit IRC | 16:15 | |
| *** kfox1111 has joined #openstack-barbican | 16:23 | |
| kfox1111 | morning. | 16:23 |
| *** lisaclark1 has quit IRC | 16:28 | |
| *** lisaclark1 has joined #openstack-barbican | 16:28 | |
| jaosorior | kfox1111: evening. | 16:29 |
| *** dimtruck is now known as zz_dimtruck | 16:29 | |
| *** lisaclark2 has joined #openstack-barbican | 16:32 | |
| *** lisaclark1 has quit IRC | 16:32 | |
| kfox1111 | :) | 16:34 |
| kfox1111 | so I noticed the Sahara spec. | 16:34 |
| jaosorior | Well, it's evening here :P . Uhm... haven't checked that. Got a link? | 16:35 |
| kfox1111 | Reading through it, it mentions a draback being it still has to handle the secrets. I think that would be unnessisary with the vm integration spec. | 16:35 |
| kfox1111 | just a sec... | 16:35 |
| *** david-lyle_afk has quit IRC | 16:37 | |
| kfox1111 | https://review.openstack.org/#/c/157432/5/specs/kilo/improved-secret-storage.rst | 16:37 |
| jaosorior | Shit, it's merged | 16:41 |
| jaosorior | Was gonna comment on it | 16:41 |
| *** SheenaG11 has joined #openstack-barbican | 16:41 | |
| kfox1111 | :/ | 16:41 |
| kfox1111 | Maybe put a comment on the vm-integration spec then too? | 16:42 |
| jaosorior | Yup, gotta give it a read | 16:42 |
| *** SheenaG1 has quit IRC | 16:42 | |
| jaosorior | Will do after climbing | 16:42 |
| kfox1111 | ok. thx. | 16:43 |
| *** zz_dimtruck is now known as dimtruck | 16:43 | |
| hockeynut | reaperhulk https://review.openstack.org/#/c/160055/1 just needs werkflow | 16:43 |
| jaosorior | First time I read it I was gonna comment that I wanted a bit more description on the use-case. But I got distracted and I didn't comment. Not sure now how the spec is at the moment since you have updated it already | 16:44 |
| kfox1111 | look at the comments in version 3. I've been fleshing out the use case in there, | 16:44 |
| kfox1111 | and when its clear, I'll post it in the spec. | 16:44 |
| reaperhulk | hockeynut: k | 16:45 |
| jaosorior | hockeynut, reaperhulk: actually I didn't feel entirely good about that NewRelic CR either, but I didn't come up with an alternative. That's why I didn't comment on it | 16:46 |
| hockeynut | jaosorior please express your concerns | 16:47 |
| reaperhulk | Probably the same ones I have | 16:47 |
| reaperhulk | It's highly specific to new relic | 16:47 |
| reaperhulk | It'd be nice for it to be agnostic, but I don't know how to accomplish that without violating hacking and causing other annoyances | 16:47 |
| reaperhulk | So basically until I see someone else say "I want <not new relic>" we can ignore it. When that person appears we will have them refactor it in a more generic manner | 16:48 |
| reaperhulk | whatever that manner may be :D | 16:48 |
| hockeynut | some kind of monitoring plugin perhaps? then we can provide newrelic as one type? | 16:48 |
| Guest32544 | all we need is moar plugin | 16:48 |
| reaperhulk | That might work, but would like to stay as lightweight as possible | 16:48 |
| reaperhulk | (aka plz no plugins) | 16:49 |
| hockeynut | I use plugin in a generic way here. extension, configuration, add-on pick your favorite | 16:49 |
| jaosorior | reaperhulk: actually yeah. It felt too specific to that implementation | 16:50 |
| *** Guest32544 is now known as redrobot | 16:51 | |
| *** gyee has joined #openstack-barbican | 16:58 | |
| openstackgerrit | Merged openstack/barbican: Fix functional tests to use new auth provider interface https://review.openstack.org/160455 | 17:06 |
| openstackgerrit | Douglas Mendizábal proposed openstack/barbican-specs: Spec for secret pre-encryption https://review.openstack.org/128401 | 17:09 |
| *** russell_h has joined #openstack-barbican | 17:14 | |
| *** russell_h has quit IRC | 17:14 | |
| *** russell_h has joined #openstack-barbican | 17:14 | |
| *** chlong has quit IRC | 17:17 | |
| *** lisaclark2 has quit IRC | 17:17 | |
| openstackgerrit | Merged openstack/barbican: Adding NewRelic monitoring to worker tasks https://review.openstack.org/160055 | 17:25 |
| openstackgerrit | Merged openstack/python-barbicanclient: Add secret_type to Secret constructor https://review.openstack.org/160561 | 17:31 |
| *** kfox1111 has quit IRC | 17:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/barbican: Updated from global requirements https://review.openstack.org/160564 | 17:38 |
| *** dimtruck is now known as zz_dimtruck | 17:48 | |
| *** zz_dimtruck is now known as dimtruck | 17:51 | |
| *** lisaclark1 has joined #openstack-barbican | 17:58 | |
| *** bdpayne has joined #openstack-barbican | 18:00 | |
| *** alee is now known as alee_lunch | 18:11 | |
| *** dave-mccowan has joined #openstack-barbican | 18:12 | |
| *** crc32 has joined #openstack-barbican | 18:20 | |
| jaosorior | reaperhulk: 12-pack related code -> https://review.openstack.org/#/c/160329/ | 18:32 |
| *** kgriffs is now known as kgriffs|afk | 18:40 | |
| *** rellerreller has joined #openstack-barbican | 18:41 | |
| jaosorior | kfox1111: are you around? | 18:46 |
| openstackgerrit | Merged openstack/python-barbicanclient: Updated functional tests to use both identity v2 and v3 https://review.openstack.org/160619 | 18:47 |
| *** lisaclark1 has quit IRC | 18:58 | |
| igueths | jaosorior: Seems he dropped... | 18:59 |
| jaosorior | yeah, I saw | 19:00 |
| *** alee_lunch is now known as alee | 19:15 | |
| *** lisaclark1 has joined #openstack-barbican | 19:22 | |
| *** lisaclark2 has joined #openstack-barbican | 19:26 | |
| *** lisaclark1 has quit IRC | 19:28 | |
| elmiko | hey barbicaneers, i'm trying to get a working barbicanclient with keystone middleware authenticating against my devstack. | 19:35 |
| elmiko | so, far i've got barbican running on my dev machine. i'm able to make http calls from my devstack machine to the barb instance. | 19:36 |
| elmiko | and i've added key-manager service to my catalog | 19:36 |
| elmiko | but i keep getting 404's from the barbicanclient when attempting to store a secret, any advice? | 19:37 |
| redrobot | elmiko does the service catalog entry include "v1" in the URL? | 19:37 |
| elmiko | no | 19:37 |
| elmiko | i tried to copy the config from contrib/devstack/lib/barbican | 19:37 |
| *** lisaclark2 has quit IRC | 19:38 | |
| elmiko | the main difference is that i don't have a barbican service user created, i am using the default admin user for access from barbican-api-paste.ini | 19:38 |
| *** lisaclark1 has joined #openstack-barbican | 19:39 | |
| *** lisaclark1 has quit IRC | 19:39 | |
| elmiko | i should probably just try and integrate it into my devstack, but i wanted to walk through the steps to be sure i understand how it fits into the stack | 19:39 |
| *** lisaclark1 has joined #openstack-barbican | 19:39 | |
| redrobot | elmiko hmm... I would try to set up a break point and examine the url that gives you the 404. | 19:40 |
| elmiko | redrobot good idea, i'll dig a little further. thanks =) | 19:41 |
| lisaclark1 | barbicaneers: i've got CRs that I'd love to get eyes on! any takers? | 19:43 |
| lisaclark1 | https://review.openstack.org/#/c/157920/ | 19:43 |
| jaosorior | reading | 19:43 |
| reaperhulk | holy shit jaosorior, that is a monster CR | 19:45 |
| jaosorior | reaperhulk: Yeaaaah... I'm not keen of it being so big myself. But I started trying to make it by parts, and it didn't work out | 19:45 |
| jaosorior | reaperhulk: I'm happy, though, that it's more negative lines than positive :P | 19:46 |
| *** kfox1111 has joined #openstack-barbican | 19:46 | |
| jaosorior | * more deletions than additions | 19:46 |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Adds positive orders functional tests https://review.openstack.org/158454 | 19:46 |
| reaperhulk | Yeah I looked and it is one of those situations where it's super hard to split it up... | 19:46 |
| woodster_ | But that cr removes soooo much cruft! :) | 19:48 |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Adds positive orders functional tests https://review.openstack.org/158454 | 19:49 |
| jaosorior | having written all that, now I'm not that sure how keen I am of the singleton factories from a maintenance point of view. Since there is a lot of witchery going on by patching those factory methods... buuuut it does look better than the Repositories class | 19:50 |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Moved DD test from smoke to functional https://review.openstack.org/160490 | 19:54 |
| elmiko | redrobot: ok, for reasons that aren't exactly clear to me yet the calls to store the secret is filling in my keystone endpoint for the _barbican_endpoint in the Client | 19:56 |
| *** jorge_munoz_ has joined #openstack-barbican | 19:57 | |
| reaperhulk | jaosorior: Yeah the lazy module global really frustrates me | 19:58 |
| reaperhulk | I've got some vague ideas on how to resolve that, but we'll see | 19:58 |
| redrobot | elmiko so, if you're using the catalog, make sure that you're not giving an endpoint to the Client object, and that the catalog entry for 'key-manager' is the barbican url | 19:58 |
| openstackgerrit | Nathan Reller proposed openstack/barbican: Fixed Binary Encoding to Secret Stores https://review.openstack.org/157410 | 19:58 |
| jaosorior | rellerreller: you added your tags accidentally to that CR | 19:59 |
| reaperhulk | (mostly around whether we can call parse_args almost immediately and therefore not have to lazy init things after import) | 20:00 |
| elmiko | redrobot: i'm creating the client with an Session taken from a keystoneclient.v3.Client object that i created. should that possible? | 20:00 |
| elmiko | *that be* | 20:00 |
| rellerreller | jaosorior Aargh!!! | 20:00 |
| redrobot | elmiko like this? http://docs.openstack.org/developer/python-barbicanclient/authentication.html | 20:00 |
| elmiko | redrobot: not exactly, sec. i'll paste | 20:00 |
| *** jorge_munoz_ has quit IRC | 20:01 | |
| elmiko | redrobot: http://paste.openstack.org/show/186760/ | 20:01 |
| reaperhulk | jaosorior: merged, god help us ;) | 20:02 |
| openstackgerrit | Nathan Reller proposed openstack/barbican: Fixed Binary Encoding to Secret Stores https://review.openstack.org/157410 | 20:02 |
| rellerreller | jaosorior Pushed another version without tags. Thanks for catching that. I should put that in .gitignore. | 20:03 |
| elmiko | redrobot: just for reference, http://paste.openstack.org/show/186761/ (service catalog) | 20:04 |
| jaosorior | reaperhulk: shit's gonna get real | 20:04 |
| rellerreller | reaperhulk redrobot Can you review CR 157410, https://review.openstack.org/#/c/157410/ woodster_ gave me +1 but wanted you guys to comment on it before +2. | 20:04 |
| jaosorior | elmiko: looks alright | 20:05 |
| rellerreller | I need this to get the content type work done. | 20:05 |
| redrobot | rellerreller will look at it today after meetings | 20:06 |
| elmiko | jaosorior: i keep getting 404s when i try to store a secret from the client in the first paste. it's pulling the keystone endpoint and trying to post http://{KEYSTONE_ENDPOINT}/v1/secrets | 20:06 |
| rellerreller | redrobot thanks! | 20:06 |
| jaosorior | Ooook | 20:07 |
| redrobot | elmiko very strange... code looks correct. :-\ | 20:08 |
| jaosorior | you're sure that that endpoint works, right? | 20:08 |
| jaosorior | elmiko | 20:08 |
| jaosorior | I mean, you have tried doing manually a request, using curl or something of the sort | 20:08 |
| elmiko | jaosorior: yup, i've tried httpie commands from the node that keystone is on, and from the node that i'm running the script on | 20:09 |
| redrobot | elmiko I would pdb into the keystone session stuff, b/c get_endpoint looks good in our code http://docs.openstack.org/developer/python-barbicanclient/authentication.html | 20:09 |
| redrobot | elmiko I mean https://github.com/openstack/python-barbicanclient/blob/master/barbicanclient/client.py#L111 | 20:09 |
| elmiko | redrobot: thanks, back to the mines! | 20:09 |
| jamielennox | elmiko: you shouldn't need to do that | 20:18 |
| elmiko | jamielennox: to do what? | 20:19 |
| jamielennox | elmiko: if you are doing user pass use keystoneclient.auth.identity.v3.Password(auth_url=..., username=..., password-...) | 20:19 |
| jamielennox | then just keystoneclient.session.Session(auth=plugin) | 20:19 |
| jamielennox | don't steal it from ksc | 20:19 |
| elmiko | jamielennox: part of this is that i'm trying to do hacking to understand how we'll fit this into sahara. we have some utility functions to create keystone Client objects, maybe i'll just need to extend that and allow getting Session objects as well. | 20:20 |
| jamielennox | elmiko: the intent with a lot of this session work is to seperate the CRUD aspects of the client from the auth aspects | 20:21 |
| jamielennox | elmiko: if you find yourself having to create a client with auth parameters then stop | 20:21 |
| jamielennox | i don't know how sahara works though | 20:21 |
| redrobot | jamielennox just curious. the barbicanclient supports sessions. are you saying the session should not be shared? only the auth object? | 20:22 |
| elmiko | jamielennox: i can certainly add utility functions to get a Session instead, i would like to understand the differences better though. | 20:22 |
| jamielennox | redrobot: you can share sessions, just there is a circular dependency that was put in place as a hack for keystoneclient, if you create keystoneclient the old way it creates a session, but the auth is weird | 20:23 |
| elmiko | jamielennox: is there a good place in the keystone docs that illuminated the differences between Clients and Sessions? | 20:23 |
| elmiko | *illuminates | 20:23 |
| redrobot | elmiko http://docs.openstack.org/developer/python-keystoneclient/using-sessions.html | 20:23 |
| jamielennox | i had a blog a while ago | 20:23 |
| jamielennox | umm | 20:23 |
| elmiko | redrobot: thanks | 20:23 |
| jamielennox | http://www.jamielennox.net/blog/2014/09/15/how-to-use-keystoneclient-sessions/ | 20:24 |
| elmiko | jamielennox: awesome, thanks | 20:24 |
| jamielennox | older: http://www.jamielennox.net/blog/2014/02/24/client-session-objects/ | 20:24 |
| reaperhulk | at some point soon we should have some code merging... | 20:24 |
| elmiko | cool, i've got some nice light afternoon reading now =) | 20:25 |
| jaosorior | jamielennox: as feedback I must say that I've found your blog really useful | 20:26 |
| jamielennox | jaosorior: excellent! i'm never sure if people read it | 20:26 |
| jaosorior | jamielennox: if you've found views from Finland (or Sweden) in the statistics. That was provably me | 20:27 |
| *** gyee has quit IRC | 20:28 | |
| jamielennox | i haven't looked at the stats in ages | 20:28 |
| openstackgerrit | Merged openstack/barbican: Get rid of Repositories class https://review.openstack.org/160329 | 20:28 |
| reaperhulk | and now I owe jaosorior beers | 20:29 |
| jamielennox | some of the posts take a fair bit of time, and then you look at the stats and like 90% of my traffic was from a 2 paragraph 'why am i getting this error message in auth_token middleware' | 20:29 |
| jaosorior | reaperhulk: hehehe | 20:29 |
| *** kebray has joined #openstack-barbican | 20:29 | |
| *** lisaclark1 has quit IRC | 20:31 | |
| openstackgerrit | Kevin Fox proposed openstack/barbican-specs: Spec for vm-integration https://review.openstack.org/159571 | 20:33 |
| *** lisaclark1 has joined #openstack-barbican | 20:34 | |
| elmiko | just to followup, it does work if i use the method from the docs | 20:34 |
| *** kebray has quit IRC | 20:41 | |
| *** lisaclark1 has quit IRC | 20:44 | |
| *** rellerreller has quit IRC | 20:46 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Enable secret decrypt through 'payload' resource https://review.openstack.org/157068 | 20:46 |
| jaosorior | woodster_: just had to rebase for that CR ^^ | 20:47 |
| jaosorior | redrobot: this CR originated from a recommendation of yours :D https://review.openstack.org/#/c/160250/ got some minutes to check it out? | 20:54 |
| jaosorior | woodster_: ping | 20:55 |
| *** lisaclark1 has joined #openstack-barbican | 20:56 | |
| redrobot | jaosorior shouldn't you be sleeping? | 20:57 |
| redrobot | jaosorior LGTM | 20:58 |
| jaosorior | redrobot: got no meetings tomorrow, so I'll work from home (a bar...) | 20:59 |
| *** dimtruck is now known as zz_dimtruck | 20:59 | |
| jaosorior | so no need to wake up early | 20:59 |
| jaosorior | redrobot: ...and and my current state is: Drinking craft beer, eating manchego cheese and reviewing code. I'm quite entertained at the moment | 20:59 |
| *** kebray has joined #openstack-barbican | 21:00 | |
| elmiko | jaosorior: ++ | 21:01 |
| *** paul_glass has quit IRC | 21:02 | |
| *** paul_glass has joined #openstack-barbican | 21:04 | |
| *** lisaclark1 has quit IRC | 21:07 | |
| *** zz_dimtruck is now known as dimtruck | 21:07 | |
| igueths | jaosorior: += insert_metal_band_name_here | 21:08 |
| jaosorior | the band is Capharnaum, at the moment :P | 21:10 |
| igueths | Ah ha! | 21:10 |
| *** jkf has joined #openstack-barbican | 21:11 | |
| *** kebray has quit IRC | 21:20 | |
| *** rellerreller has joined #openstack-barbican | 21:29 | |
| *** kgriffs|afk is now known as kgriffs | 21:50 | |
| woodster_ | jaosorior: hello | 21:54 |
| jaosorior | woodster_: Have you had any news regarding the DigiCert dude? Haven't heard from that :/ | 21:58 |
| openstackgerrit | Merged openstack/barbican: Use urljoin instead of os.path.join https://review.openstack.org/160250 | 22:03 |
| *** dave-mccowan has quit IRC | 22:11 | |
| hockeynut | jaosorior ping? | 22:20 |
| jaosorior | hockeynut: pong | 22:22 |
| hockeynut | having a problem with tempest auth_provider fix. I think you have a newer tempest than I | 22:22 |
| hockeynut | can you check pip freeze | grep tempest ? | 22:22 |
| jaosorior | probably, can you paste the error? | 22:23 |
| jaosorior | ...and, are you using the stable version of tempest? | 22:23 |
| jaosorior | cause the fix was for the latest | 22:23 |
| jaosorior | basically this commit: https://github.com/openstack/tempest/commit/90012355b4ea24a7321f66b329b543f306d2cefe | 22:24 |
| hockeynut | tempest==3.dev73.g816131c | 22:24 |
| hockeynut | mine fails because tempest_manger is a module | 22:24 |
| hockeynut | basically I had to take the old code and change tempest_client to tempest_manager to convince to work with my version of tempest | 22:24 |
| hockeynut | wondering if my version works with BOTH... | 22:25 |
| jaosorior | now that would be cool | 22:26 |
| openstackgerrit | Merged openstack/barbican: Validate character set used for payload when encoding is base64 https://review.openstack.org/160172 | 22:26 |
| *** lisaclark1 has joined #openstack-barbican | 22:27 | |
| *** lisaclark1 has quit IRC | 22:27 | |
| *** rellerreller has quit IRC | 22:30 | |
| *** gyee has joined #openstack-barbican | 22:33 | |
| jaosorior | redrobot: ping | 22:34 |
| jaosorior | hockeynut: To be honest I just tested against the latest tempest (meaning I got it from github...since from what I understood, that's what the gate tests with), and I didn't check if it was compatible from what you get from pip. Which was a mistake. So I'm guessing code to make it backwards compatible will be needed. And just now that you told me I realized. | 22:36 |
| jaosorior | Want me to code that? or do you wanna do it? | 22:36 |
| hockeynut | I made a small change - worked with my older tempest, now I've updated to 4.stuff and trying that now | 22:37 |
| hockeynut | ...and it worked. | 22:37 |
| hockeynut | I'll slam it up - take a look | 22:37 |
| openstackgerrit | Merged openstack/barbican: Update devstack to run tests both sequentially and in parallel https://review.openstack.org/160016 | 22:38 |
| openstackgerrit | Merged openstack/barbican: Updated from global requirements https://review.openstack.org/160564 | 22:39 |
| openstackgerrit | Steve Heyman proposed openstack/barbican: Let functional tests run with tempest 3.dev* https://review.openstack.org/161014 | 22:41 |
| hockeynut | jaosorior take a peek: https://review.openstack.org/#/c/161014/ | 22:42 |
| openstackgerrit | Merged openstack/barbican: Use oslo_log in db-manage script https://review.openstack.org/160735 | 22:42 |
| *** SheenaG11 has quit IRC | 22:43 | |
| openstackgerrit | Merged openstack/barbican: Fix bug in tests assuming order is active https://review.openstack.org/157920 | 22:44 |
| jaosorior | hockeynut: that's how the code used to look, right? | 22:44 |
| hockeynut | yes, but uses tempest.manager rather than tempest.client | 22:44 |
| jaosorior | lets see | 22:45 |
| jaosorior | because as far as I could see from the tempest commit I showed you, the manager shouldn't have that call anymore | 22:45 |
| jaosorior | so probably there will need to be a try: ... except: to use one way or another | 22:46 |
| hockeynut | I mean tempest_manager and tempest_clients | 22:46 |
| jaosorior | lets see when the CI shows the result | 22:46 |
| hockeynut | that works | 22:47 |
| hockeynut | (meaning that's ok with me!) | 22:47 |
| igueths | How long should it /normally/ take for a full Tox run to complete? | 22:47 |
| hockeynut | igueths with a clean env it takes a while to download/install all of the reqs | 22:47 |
| hockeynut | igueths otherwise only a few mins | 22:48 |
| igueths | hockeynut: Yeah I already have an environment that I'm working out of, so in theory it shouldn't take too long...Looking back I can actually see that it's running things. Part of it too was that when I first tried it I was on a shit network with upwards of 3000 plus MS of latency. | 22:50 |
| *** openstackgerrit has quit IRC | 22:51 | |
| *** openstackgerrit has joined #openstack-barbican | 22:52 | |
| hockeynut | jaosorior the error I got before my fix: AttributeError: 'module' object has no attribute 'get_auth_provider' | 22:52 |
| jaosorior | hockeynut: yeah, that's because the function was moved from the class to being a function in the module in the commit I pointed out | 22:54 |
| jaosorior | so, I propose it ends like this (update to your CR incoming) | 22:54 |
| jaosorior | or.. | 22:54 |
| jaosorior | well, lets wait for the CI first, not sure how long it will take | 22:54 |
| jaosorior | hockeynut: damn...it's gonna take a while | 22:55 |
| hockeynut | jaosorior I still see get_auth_provider(credentials) in tempest/manager.py (line 62) | 22:55 |
| hockeynut | jaosorior devstack.run(speed='slowest') | 22:56 |
| jaosorior | hockeynut: well, the CI hasn't even started yet running the tests | 22:56 |
| hockeynut | ouch | 22:56 |
| jaosorior | yup | 22:56 |
| hockeynut | I have to run for daughter violin lesson - I'll check when I get back | 22:57 |
| jaosorior | sure | 22:57 |
| jaosorior | might not be here though | 22:57 |
| jaosorior | but just in case | 22:57 |
| jaosorior | if the tests fail, a try ... except AttributeError: ... would be needed | 22:57 |
| jaosorior | but get_auth_provider in line 62 is no longer in the class, but it's a function in the module | 22:59 |
| jaosorior | the indentation went to the beginning of the line | 22:59 |
| jaosorior | anyway, see ya | 22:59 |
| *** jkf has quit IRC | 23:04 | |
| *** nkinder has quit IRC | 23:04 | |
| *** igueths has quit IRC | 23:06 | |
| *** xaeth is now known as xaeth_afk | 23:10 | |
| *** paul_glass has quit IRC | 23:15 | |
| *** dimtruck is now known as zz_dimtruck | 23:16 | |
| *** alee has quit IRC | 23:19 | |
| openstackgerrit | Merged openstack/python-barbicanclient: Convert CRUD tests to requests-mock https://review.openstack.org/148447 | 23:23 |
| openstackgerrit | Merged openstack/python-barbicanclient: Remove cyclical dependency https://review.openstack.org/148448 | 23:26 |
| *** chlong has joined #openstack-barbican | 23:32 | |
| kfox1111 | seems like today has become the ghost of meeting day. :/ | 23:43 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!