| *** ametts has quit IRC | 00:03 | |
| *** dave-mccowan has quit IRC | 00:03 | |
| *** bdpayne has quit IRC | 00:11 | |
| *** jorge_munoz has quit IRC | 00:15 | |
| *** kgriffs is now known as kgriffs|afk | 00:41 | |
| *** crc32 has quit IRC | 00:41 | |
| *** igueths has left #openstack-barbican | 00:46 | |
| *** igueths has joined #openstack-barbican | 00:46 | |
| woodster_ | reaperhulk, i shouild be able to workflow before tests pass...will that effectively just do one gate check then (to merge)? | 00:47 |
|---|---|---|
| reaperhulk | It will do the gate check for the merge yes | 00:48 |
| reaperhulk | but you can wait until it passes :) | 00:48 |
| woodster_ | reaperhulk, so the PK should be indexed by default correct? | 00:49 |
| woodster_ | reaperhulk, I'll also ask the dbas about UUID PKs...I've read that could be a perf impact | 00:49 |
| *** kfarr has quit IRC | 00:50 | |
| reaperhulk | the ids are set as primary key in our schemas right now | 00:55 |
| *** igueths has quit IRC | 01:03 | |
| *** kfox1111 has quit IRC | 01:09 | |
| *** jorge_munoz has joined #openstack-barbican | 01:27 | |
| *** jorge_munoz has quit IRC | 01:28 | |
| *** gyee has quit IRC | 01:36 | |
| *** SheenaG1 has joined #openstack-barbican | 01:39 | |
| *** jamielennox is now known as jamielennox|lunc | 01:51 | |
| *** jaosorior has quit IRC | 01:52 | |
| *** jkf has quit IRC | 02:00 | |
| *** nkinder has quit IRC | 02:21 | |
| *** nkinder has joined #openstack-barbican | 02:26 | |
| *** jamielennox|lunc is now known as jamielennox | 02:47 | |
| *** rm_work is now known as rm_work|away | 03:02 | |
| *** jamielennox is now known as jamielennox|away | 03:45 | |
| *** dave-mccowan has joined #openstack-barbican | 03:58 | |
| *** dave-mcc_ has joined #openstack-barbican | 04:03 | |
| *** dave-mccowan has quit IRC | 04:03 | |
| *** dave-mcc_ has quit IRC | 04:27 | |
| *** zz_dimtruck has quit IRC | 04:29 | |
| *** xaeth_afk is now known as xaeth | 04:29 | |
| *** xaeth is now known as xaeth_afk | 04:29 | |
| *** woodster_ has quit IRC | 04:40 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/barbican: Updated from global requirements https://review.openstack.org/161570 | 04:48 |
| openstackgerrit | Merged openstack/python-barbicanclient: Adds positive orders functional tests https://review.openstack.org/158454 | 05:08 |
| *** woodster_ has joined #openstack-barbican | 05:34 | |
| openstackgerrit | Arun Kant proposed openstack/barbican: Adding per secret ACL support https://review.openstack.org/161620 | 06:45 |
| *** arunkant has quit IRC | 07:03 | |
| *** chellygel has quit IRC | 07:24 | |
| *** lisaclark has quit IRC | 07:24 | |
| *** jvrbanac has quit IRC | 07:24 | |
| *** openstackgerrit has quit IRC | 07:36 | |
| *** openstackgerrit has joined #openstack-barbican | 07:36 | |
| *** woodster_ has quit IRC | 07:40 | |
| *** insequent has quit IRC | 08:33 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Enable usage of 'payload' path to fetch decrypted secrets https://review.openstack.org/161643 | 08:46 |
| *** jaosorior has joined #openstack-barbican | 08:46 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Enable usage of 'payload' path to fetch decrypted secrets https://review.openstack.org/161643 | 09:02 |
| *** elmiko has quit IRC | 09:20 | |
| *** elmiko has joined #openstack-barbican | 09:20 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Add default max payload to functional test conf registry https://review.openstack.org/160718 | 09:28 |
| *** darrenmoffat has quit IRC | 10:12 | |
| *** darrenmoffat has joined #openstack-barbican | 10:13 | |
| *** dave-mccowan has joined #openstack-barbican | 13:11 | |
| *** woodster_ has joined #openstack-barbican | 13:22 | |
| *** SheenaG1 has quit IRC | 13:44 | |
| *** SheenaG1 has joined #openstack-barbican | 14:00 | |
| *** alee has joined #openstack-barbican | 14:08 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Ported API documentation to the repo https://review.openstack.org/161729 | 14:19 |
| *** rellerreller has joined #openstack-barbican | 14:31 | |
| *** lisaclark has joined #openstack-barbican | 14:36 | |
| *** igueths has joined #openstack-barbican | 14:43 | |
| *** igueths has quit IRC | 14:52 | |
| *** lisaclark has quit IRC | 15:10 | |
| *** lisaclark has joined #openstack-barbican | 15:12 | |
| *** chellygelz has joined #openstack-barbican | 15:18 | |
| *** seagray has joined #openstack-barbican | 15:21 | |
| *** insequent has joined #openstack-barbican | 15:21 | |
| *** kebray has joined #openstack-barbican | 15:21 | |
| *** kebray has quit IRC | 15:23 | |
| *** kebray has joined #openstack-barbican | 15:23 | |
| *** zz_dimtruck has joined #openstack-barbican | 15:25 | |
| *** zz_dimtruck is now known as dimtruck | 15:25 | |
| *** kgriffs|afk is now known as kgriffs | 15:28 | |
| *** hockeynut has quit IRC | 15:31 | |
| *** tdink has quit IRC | 15:31 | |
| *** jorge_munoz has joined #openstack-barbican | 15:32 | |
| *** hockeynut has joined #openstack-barbican | 15:32 | |
| *** tdink has joined #openstack-barbican | 15:33 | |
| *** insequent has quit IRC | 15:40 | |
| *** insequent has joined #openstack-barbican | 15:43 | |
| *** insequent has quit IRC | 15:46 | |
| *** lisaclark has quit IRC | 15:48 | |
| *** jorge_munoz has quit IRC | 15:53 | |
| *** lisaclark has joined #openstack-barbican | 15:53 | |
| openstackgerrit | Brianna Poulos proposed openstack/castellan: Copy cinder.keymgr to castellan https://review.openstack.org/148742 | 15:55 |
| woodster_ | hockeynut, tdink, are you there? | 15:58 |
| hockeynut | yep - suffering through a gorgeous sunny day | 15:59 |
| reaperhulk | redrobot: where we at with that gate :) | 15:59 |
| openstackgerrit | Brianna Poulos proposed openstack/castellan: Copy cinder.keymgr to castellan https://review.openstack.org/148742 | 16:00 |
| woodster_ | hockeynut aren't you guys covered with ice? | 16:01 |
| hockeynut | iced tea? | 16:01 |
| hockeynut | its sunny and cold | 16:01 |
| hockeynut | dallas got blasted with 7" but we got nothing | 16:01 |
| woodster_ | hockeynut, yeah snowmageddon didn't happen here either | 16:02 |
| hockeynut | schools out down there | 16:02 |
| woodster_ | hockeynut, jvrbanac, tdink so I was curious if we have tests that verify we can't spoof the x-project-id header. I thought we did in the cafe days, but not sure. | 16:03 |
| hockeynut | not project ID. we do have one for location header | 16:03 |
| *** alee has quit IRC | 16:04 | |
| *** lisaclark has quit IRC | 16:05 | |
| jaosorior | woodster_: what would then be a more appropriate place for the API doc? | 16:06 |
| woodster_ | jaosorior, API docs *were* supposed to go into the docbook stuff that is in our repo, but until we were out of incubation, they couldn't be published anywhere. Well the raw XML docbook format is not too pleasant to look at, so we held off on pulling all API info over to it. | 16:08 |
| woodster_ | jaosorior, so the next best thing was the good ol' cloudkeep org's wiki | 16:08 |
| jaosorior | Oh | 16:09 |
| woodster_ | jaosorior, I should say the *easiest* thing was to keep it there. Your CR is really the next best thing | 16:09 |
| jaosorior | Well, fuck haha. That took a quote | 16:09 |
| jaosorior | * while, not quote | 16:09 |
| jaosorior | Should have asked first | 16:09 |
| *** lisaclark has joined #openstack-barbican | 16:14 | |
| woodster_ | jaosorior, no no we had actually wanted to do that but didn't have the time. | 16:15 |
| woodster_ | jaosorior, I've also heard there is possible movement away from docbook to .rst, so the docs might easily move to the 'proper' home once that is figured out. The best part is when folks mod the API, we can insist on changes to the docs too. | 16:16 |
| woodster_ | hockeynut yeah it turns out we weren't stripping that out of the request properly so it could be spoofed! This is probably a test to add to the new security suite of tests, or to the functional suite? | 16:17 |
| *** alee has joined #openstack-barbican | 16:18 | |
| hockeynut | woodster_ yep - definitely should add to the new stuff (securitytests make sense I believe) | 16:19 |
| openstackgerrit | Merged openstack/barbican: Updated from global requirements https://review.openstack.org/161570 | 16:24 |
| openstackgerrit | Merged openstack/barbican: Creating indexes for foreign keys https://review.openstack.org/161481 | 16:25 |
| *** dave-mcc_ has joined #openstack-barbican | 16:28 | |
| openstackgerrit | Merged openstack/barbican: Fixing race-condition for order processing in workers https://review.openstack.org/161431 | 16:29 |
| *** dave-mccowan has quit IRC | 16:30 | |
| *** dave-mccowan has joined #openstack-barbican | 16:31 | |
| *** rellerreller has quit IRC | 16:32 | |
| *** kfox1111 has joined #openstack-barbican | 16:33 | |
| *** dave-mcc_ has quit IRC | 16:34 | |
| kfox1111 | morning | 16:34 |
| *** xaeth_afk is now known as xaeth | 16:35 | |
| *** rellerreller has joined #openstack-barbican | 16:38 | |
| kfox1111 | any other comments on the vm integration spec? | 16:39 |
| kfox1111 | It would be nice if we could provisionally approve it for kilo, since there is code ready too. | 16:39 |
| *** alee has quit IRC | 16:39 | |
| *** igueths has joined #openstack-barbican | 16:44 | |
| *** tkelsey has joined #openstack-barbican | 16:46 | |
| *** insequent has joined #openstack-barbican | 16:50 | |
| *** alee has joined #openstack-barbican | 16:51 | |
| *** seagray has quit IRC | 17:03 | |
| *** jorge_munoz_ has joined #openstack-barbican | 17:04 | |
| *** bdpayne has joined #openstack-barbican | 17:04 | |
| *** jvrbanac has joined #openstack-barbican | 17:05 | |
| *** lisaclark_ has joined #openstack-barbican | 17:06 | |
| *** insequent has quit IRC | 17:11 | |
| kfox1111 | any other comments on the vm integration spec? | 17:11 |
| kfox1111 | It would be nice if we could provisionally approve it for kilo, since there is code ready too. | 17:11 |
| *** insequent has joined #openstack-barbican | 17:11 | |
| kfox1111 | we can alwasy not commit the code for kilo if objections pop up. | 17:12 |
| redrobot | kfox1111 we agreed during the last weekly meeting to punt on your spec until L cycle | 17:13 |
| redrobot | kfox1111 I think it's a big enough change to warrant discussion during the Design Summit in Vancouver | 17:13 |
| kfox1111 | ok. | 17:14 |
| redrobot | kfox1111 do you know if you'll be able to attend the Sumimt? | 17:15 |
| redrobot | kfox1111 it would be great to be able to discuss this in person | 17:15 |
| kfox1111 | yeah, it would. not sure. :/ I guess it wouldn't hurt to ask management... | 17:17 |
| *** jkf has joined #openstack-barbican | 17:23 | |
| *** kebray has quit IRC | 17:28 | |
| *** kebray has joined #openstack-barbican | 17:31 | |
| rellerreller | ping woodster_ | 17:34 |
| rellerreller | Actually does anyone know where the secrets are encoded to the requested type on a get secret call? | 17:35 |
| rellerreller | So if I store a secret I want to make two get calls. One to retrieve in binary format and the other in base64. | 17:36 |
| woodster_ | rellerreller, look at line #154 in barbican.plugin.resources.py | 17:36 |
| rellerreller | woodster_ the denormalize_after_decryption call? | 17:37 |
| rellerreller | My line numbers are a little off in my branch | 17:38 |
| openstackgerrit | Merged openstack/barbican: Ported API documentation to the repo https://review.openstack.org/161729 | 17:38 |
| woodster_ | it's that call at the end of the get_secret() fumctipon | 17:38 |
| woodster_ | wow, function that is | 17:38 |
| rellerreller | woodster_ So that call does not convert to base64 format or anything for binary types. | 17:39 |
| rellerreller | If the content type is set to binary then just passes the data through. Unless I am missing something. | 17:39 |
| rellerreller | For plaintext, yes, it converts to UTF-8 and returns the bytes. | 17:40 |
| woodster_ | rellerreller, that's correct, we wern't trying to take on conversion at the time this code was written. We were also getting true binary back I think as well (not base64 encoded) | 17:41 |
| rellerreller | woodster_ That might be an issue for callers. We are ignoring there requested encoding for retrieval. | 17:43 |
| *** jorge_munoz_ has quit IRC | 17:43 | |
| rellerreller | Sorry, crying baby now. Need to get that. | 17:43 |
| woodster_ | rellerreller, well for backwards compat, could you just do that for the opaque type | 17:43 |
| woodster_ | ? | 17:43 |
| woodster_ | rellerreller, jeez, first kid...she'll be fine. Just kidding! :) | 17:44 |
| rellerreller | woodster_ I think we need a new CR for this issue. | 17:52 |
| openstackgerrit | Merged openstack/python-barbicanclient: Add default max payload to functional test conf registry https://review.openstack.org/160718 | 17:53 |
| *** kebray has quit IRC | 18:25 | |
| *** seagray has joined #openstack-barbican | 18:28 | |
| rellerreller | woodster_ OK, I'm going to blame this one on sleep deprivation. I just saw that the API says it will only return secrets in binary format. I thought you could request in base64 or binary. No bug. My mistake. | 18:44 |
| *** crc32 has joined #openstack-barbican | 18:50 | |
| *** xaeth is now known as xaeth_afk | 18:51 | |
| *** DCWilliams_VA has joined #openstack-barbican | 18:53 | |
| openstackgerrit | Merged openstack/python-barbicanclient: Additional requests-mock testing https://review.openstack.org/148449 | 18:55 |
| woodster_ | rellerreller, no problem. We'll just have to give your CRs extra scrutiny. ;) | 19:00 |
| *** gyee has joined #openstack-barbican | 19:01 | |
| *** kebray has joined #openstack-barbican | 19:05 | |
| *** crc32 has quit IRC | 19:13 | |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Second set of negative functional tests for secrets https://review.openstack.org/161846 | 19:19 |
| *** mjg59 has quit IRC | 19:24 | |
| *** DCWilliams_VA has quit IRC | 19:25 | |
| *** DCWilliams_VA has joined #openstack-barbican | 19:26 | |
| *** DCWilliams_VA has quit IRC | 19:26 | |
| *** DCWilliams_VA has joined #openstack-barbican | 19:26 | |
| *** lisaclark has quit IRC | 19:28 | |
| *** lisaclark has joined #openstack-barbican | 19:32 | |
| *** lisaclark1 has joined #openstack-barbican | 19:33 | |
| *** lisaclark1 has quit IRC | 19:34 | |
| *** rm_work|away is now known as rm_work | 19:34 | |
| *** lisaclark1 has joined #openstack-barbican | 19:34 | |
| *** lisaclark has quit IRC | 19:36 | |
| *** DCWilliams_VA has quit IRC | 19:52 | |
| *** bdpayne has quit IRC | 19:56 | |
| *** xaeth_afk is now known as xaeth | 20:16 | |
| woodster_ | jaosorior, I just -1-ed your project-id CR, please take a look at my comments there | 20:22 |
| *** chellygelz has quit IRC | 20:24 | |
| *** openstackgerrit has quit IRC | 20:25 | |
| jaosorior | woodster_: checking it out | 20:25 |
| *** openstackgerrit has joined #openstack-barbican | 20:26 | |
| *** lisaclark1 has quit IRC | 20:27 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Enforce X-Project-Id coming from the request headers https://review.openstack.org/161377 | 20:27 |
| *** lisaclark has joined #openstack-barbican | 20:32 | |
| *** lisaclark has quit IRC | 20:36 | |
| redrobot | hockeynut ping | 20:37 |
| hockeynut | redrobot ack | 20:38 |
| redrobot | hockeynut hey, I'm trying to figure out what CWD is in this context https://github.com/openstack/python-barbicanclient/blob/master/functionaltests/__init__.py#L25 | 20:38 |
| redrobot | hockeynut it seems that CWD resolves to different things if we're running tox vs the new functional gate | 20:38 |
| hockeynut | its barbican root dir | 20:39 |
| hockeynut | so same place as tox.ini | 20:39 |
| redrobot | hockeynut even when running inside the tox directory? | 20:39 |
| hockeynut | when we run tox -e functional its from the barbican root dir | 20:39 |
| woodster_ | jaosorior, ha! Yeah we'll see what the gate does there. I see that the keystonemiddleware appears to populate both X-Tenant-Id and X-Project-Id: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L647 | 20:42 |
| jaosorior | woodster_: Oh... So yeah.. should I revert back then? | 20:42 |
| woodster_ | jaosorior, so techincally we could listen on both of them. | 20:43 |
| jaosorior | redrobot: wasn't the CWD the functionaltests directory? | 20:43 |
| woodster_ | jaosorior, well if it is deprecated and then goes away, then we are screwed if we are listening to both of them | 20:43 |
| *** lisaclark has joined #openstack-barbican | 20:43 | |
| jaosorior | but a lot of people are still using v2.0... | 20:43 |
| jaosorior | :( | 20:43 |
| redrobot | jaosorior well, that's what I'm trying to sort out... I had CWD as functionaltests but then hockeynut changed the relative path because tox -e functionaltest uses root as CWD :-\ | 20:44 |
| woodster_ | jaosorior, well it is more if folks are using older keystonemiddleware for their deployment of Barbican, which I don't think would be the case | 20:44 |
| *** david-lyle_afk has joined #openstack-barbican | 20:45 | |
| hockeynut | rax identity is 2.0-based so we need that | 20:45 |
| jaosorior | But the gate, IIRC goes to the functionaltests folder :/ | 20:46 |
| hockeynut | gate uses the run_tests.sh I believe | 20:46 |
| hockeynut | running outside of gate we use tox from barbican root | 20:46 |
| *** david-lyle_afk has quit IRC | 20:47 | |
| redrobot | jaosorior yup, relative paths suck, which is why I'm trying to do the cfg discovery programatically. | 20:47 |
| *** david-lyle_afk has joined #openstack-barbican | 20:47 | |
| redrobot | hockeynut the problem is the relative path I linked to earlier only works for one context. we need it to work for both. | 20:47 |
| *** bdpayne has joined #openstack-barbican | 20:47 | |
| hockeynut | redrobot yessir | 20:47 |
| jaosorior | woodster_: I'll revert the commit back to how it was | 20:49 |
| woodster_ | jaosorior, I'm thining the x-project-id is the way to go though | 20:49 |
| woodster_ | jaosorior, that middle ware should handle v2 vs v3 | 20:49 |
| openstackgerrit | Douglas Mendizábal proposed openstack/python-barbicanclient: WIP: Fix devstack gate https://review.openstack.org/161466 | 20:49 |
| jaosorior | Uh... ok, so, do I leave it like it is then? | 20:50 |
| *** igueths has quit IRC | 20:50 | |
| jaosorior | I mean, for me X-Project-Id is just fine, I try to enforce v3. Just didn't wanna break someone's deployment | 20:52 |
| jaosorior | By the way, I'll go on vacations tomorrow, and I still have some unmerged CRs. Would someone be able follow up on them over if they need further work? | 20:56 |
| *** lisaclark has quit IRC | 20:57 | |
| *** tkelsey has quit IRC | 20:58 | |
| *** david-lyle_afk is now known as david-lyle | 21:03 | |
| *** lisaclark has joined #openstack-barbican | 21:03 | |
| *** crc32 has joined #openstack-barbican | 21:05 | |
| *** mjg59 has joined #openstack-barbican | 21:10 | |
| jaosorior | aw :( | 21:10 |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: First set of negative secrets tests. https://review.openstack.org/161442 | 21:23 |
| redrobot | I got your back jaosorior | 21:47 |
| jaosorior | redrobot: yay :D | 21:48 |
| redrobot | jaosorior you got a few minutes to look at this Castellan CR? https://review.openstack.org/#/c/148742/ | 21:49 |
| *** seagray has quit IRC | 21:52 | |
| *** seagray has joined #openstack-barbican | 21:54 | |
| *** seagray has quit IRC | 21:56 | |
| *** jamielennox|away is now known as jamielennox | 21:56 | |
| jaosorior | redrobot: reading | 21:58 |
| *** lisaclark has quit IRC | 22:01 | |
| jaosorior | redrobot: reviewed | 22:03 |
| jaosorior | nothing major though | 22:04 |
| *** igueths has joined #openstack-barbican | 22:08 | |
| *** rellerreller has quit IRC | 22:12 | |
| openstackgerrit | Igor Gueths proposed openstack/barbican: Ensure that external secret refs cannot be added to containers https://review.openstack.org/161417 | 22:14 |
| redrobot | jaosorior thanks! | 22:15 |
| redrobot | jaosorior I'm trying to get some traction on Castellan so I can add it to global-req | 22:15 |
| jaosorior | redrobot: Indeed...I have forgotten to take a look at the commits there | 22:15 |
| jaosorior | I should really get more active there though | 22:16 |
| redrobot | jaosorior yeah, I had to add it to my "watched" list | 22:16 |
| jaosorior | Anyway guys, I'm off. Have a good day, talk to you in a week :D | 22:25 |
| jvrbanac | jaosorior, have fun! | 22:26 |
| *** lisaclark has joined #openstack-barbican | 22:27 | |
| *** paul_glass has joined #openstack-barbican | 22:35 | |
| *** paul_glass has quit IRC | 22:37 | |
| woodster_ | jaosorior, thanks for the code! | 22:39 |
| jvrbanac | woodster_, soo I've been trying to refactor these tests... | 22:39 |
| woodster_ | jvrbanac, not small shirt size sort of stuff? | 22:40 |
| jvrbanac | woodster_, This is pretty much me right now: http://www.reactiongifs.com/r/CaogEdw.gif | 22:41 |
| jvrbanac | woodster_, anddd no it's not small at all | 22:41 |
| woodster_ | jvrbanac, well we had talked about starting small, with an example module/test perhaps | 22:42 |
| jvrbanac | woodster_, yeahhhh... soooo simple was testing the version controller. That works great lol! | 22:43 |
| woodster_ | jvrbanac, well there you go then. Miller time! | 22:44 |
| jvrbanac | woodster_, so I've created a barbican/tests/api/controllers/test_version.py, etc | 22:44 |
| jvrbanac | woodster_, I figured the best way to go about this was to split out test_resources while I was at it | 22:44 |
| woodster_ | jvrbanac, another option is to create a new module entirely that just test one aspect of a controller, mainly to introduce and demo concepts/collaborating classes...could just be in its own package to start with | 22:45 |
| woodster_ | jvrbanac, I don't think the module reached 10k lines just yet though...my IDE could still open that file up after all :\ | 22:46 |
| jvrbanac | woodster_, I can always move stuff around later; however, these tests have so much bundled around them it's not funny. | 22:47 |
| openstackgerrit | Douglas Mendizábal proposed openstack/barbican: Refactor dogtag gate scripts https://review.openstack.org/161935 | 22:48 |
| jvrbanac | woodster_, my goal is to use a little mocking and patching as possible. So far I've been doing pretty good. I'm just trying to figure out transport keys | 22:49 |
| jvrbanac | woodster_, I don't see anything about them in our docs | 22:49 |
| woodster_ | jvrbanac, I think we lost track of that feature, probably because it doesn't have python client support. Now that Oz has put api docs into sphinx, maybe it would easier to add such docs. | 22:51 |
| jvrbanac | woodster_, yeah | 22:51 |
| woodster_ | alee, have you thought about documenting your nifty transport keys feature? ^^^ | 22:51 |
| alee | woodster_, eventually yes | 22:53 |
| alee | woodster_, sorry I've been drawn into messy old dogtag code this week | 22:53 |
| woodster_ | jvrbanac, is your general strategy to build up python test classes that mimic the real thing? | 22:53 |
| alee | pointer arithmetic anyone ? | 22:53 |
| woodster_ | alee, I thought you were on vacation...oh wow, the opposite of vacation...is that C code? | 22:54 |
| alee | C and C++ | 22:54 |
| alee | not vacation I assure you | 22:54 |
| woodster_ | alee C++ is nice, unless it is used by a C coder | 22:54 |
| jvrbanac | woodster_, I'm not mimic-ing anything. I'm using a webtest for the test app, but I'm hitting in memory db and a "standalone" variant of our wsgi app with controllers. | 22:55 |
| alee | which this code is a prime example of .. | 22:55 |
| jvrbanac | woodster_, I'm having to setup for specific tests, but so far I haven't used a single mock or patch | 22:55 |
| woodster_ | jvrbanac, sounds nice to me. I'd suggest getting something bite sized up for folks to take a look once that makes sense | 22:57 |
| jvrbanac | woodster_, yeah... I'll toss up something after I figure out a few more of these tests. I keep getting a SecretStorePluginNotFound when I'm trying to use the transport key stuff. I might have to patch that sucker for the moment | 23:01 |
| redrobot | jvrbanac you can take the Dev out of QE, but you can't take the QE out of the Dev ;) | 23:06 |
| *** kgriffs is now known as kgriffs|afk | 23:08 | |
| jvrbanac | redrobot, lol more like I'm tired of working on something, go to write the unit test to cover it and have my eyes glaze over due to not understanding wtf is going on. | 23:08 |
| redrobot | alee if you've got a sec, I can't tell why the KRA is failing http://logs.openstack.org/35/161935/1/experimental/gate-barbican-dogtag-devstack-dsvm-f21/d0e5e86/console.html | 23:09 |
| *** xaeth is now known as xaeth_afk | 23:09 | |
| alee | redrobot, sorry - can't look right now | 23:11 |
| alee | redrobot, I'm on a deadline to get a build out this week. | 23:11 |
| redrobot | alee no prob... I'll add you to the reviewers in my CR for when you get a chance | 23:12 |
| alee | redrobot, will get back to you tommorow if I can | 23:12 |
| alee | ok | 23:12 |
| woodster_ | jvrbanac, well the transport key stuff is a bit tricky. It is a two step process I recall, once to get the transport key id (from a specific plugin), and then one to make the call with the transport key specified (which maps to the plugin that generated the transport key). | 23:13 |
| jvrbanac | woodster_, yeah... I've spent nearly two hours trying to solve this without a patch... I think I'm just gonna patch it and move on. Figure it out later | 23:14 |
| woodster_ | jvrbanac, so it sounds like you are doing more integration style tests which just require more of these API-ish things to be filled in before hand. | 23:14 |
| woodster_ | jvrbanac, yeah that sounds fair. I think your other non-patch stuff will inspire us to remove that patch in a later CR | 23:14 |
| jvrbanac | woodster_, kinda yeah. This tests are for the controllers, so it makes sense | 23:15 |
| jvrbanac | woodster_, if we're hitting app.post* might as well have it follow as much of the real code paths as possible | 23:16 |
| woodster_ | jvrbanac, I'd agree with that. If there is a lot of biz logic complexity in the controller (so lots of branch combinations to test), those controllers probably need to be refactored anyway to break out that logic into bite sized testable chunks | 23:17 |
| *** igueths has quit IRC | 23:20 | |
| *** lisaclark has quit IRC | 23:28 | |
| *** openstack has joined #openstack-barbican | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
