*** stanzi has joined #openstack-barbican | 00:03 | |
redrobot | alee_afk can you review https://review.openstack.org/#/c/172819/ as well? | 00:03 |
---|---|---|
dave-mccowan | redrobot, signing off for a couple hours. i'll be back to rebase and finish up. i'm in california this week, so i have several hours left in the day still. :-) | 00:16 |
*** dave-mccowan has quit IRC | 00:16 | |
*** stanzi has quit IRC | 00:16 | |
*** stanzi has joined #openstack-barbican | 00:17 | |
openstackgerrit | Merged openstack/barbican: Fix expectations of order certificate test cases https://review.openstack.org/173163 | 00:17 |
openstackgerrit | Michael McCune proposed openstack/barbican: [WIP] Adding MySQL fixes to migrations https://review.openstack.org/173617 | 00:18 |
openstackgerrit | Merged openstack/barbican: Fix generating a CSR with an encrypted private key https://review.openstack.org/173457 | 00:18 |
*** stanzi has quit IRC | 00:21 | |
*** SheenaG has quit IRC | 00:27 | |
*** dimtruck is now known as zz_dimtruck | 01:00 | |
*** SheenaG has joined #openstack-barbican | 01:27 | |
*** woodster_ has quit IRC | 01:40 | |
*** SheenaG has quit IRC | 01:59 | |
*** gyee has quit IRC | 02:02 | |
*** SheenaG has joined #openstack-barbican | 02:09 | |
*** kebray has joined #openstack-barbican | 02:13 | |
*** kebray has quit IRC | 02:14 | |
*** kebray has joined #openstack-barbican | 02:17 | |
*** woodster_ has joined #openstack-barbican | 02:19 | |
*** SheenaG has quit IRC | 02:29 | |
*** tkelsey has joined #openstack-barbican | 02:36 | |
*** tkelsey has quit IRC | 02:42 | |
*** kebray has quit IRC | 02:48 | |
*** kebray has joined #openstack-barbican | 02:48 | |
*** SheenaG has joined #openstack-barbican | 02:54 | |
*** alee_afk has quit IRC | 04:07 | |
*** SheenaG has quit IRC | 04:07 | |
*** alee has quit IRC | 04:08 | |
*** alee has joined #openstack-barbican | 04:08 | |
*** alee_afk has joined #openstack-barbican | 04:09 | |
*** crc32 has joined #openstack-barbican | 04:28 | |
*** SheenaG has joined #openstack-barbican | 04:34 | |
*** dave-mccowan has joined #openstack-barbican | 04:39 | |
*** alee has quit IRC | 04:43 | |
*** SheenaG has quit IRC | 04:44 | |
openstackgerrit | Dave McCowan proposed openstack/barbican: Fix functional test test_rsa_order_certificate_from_csr https://review.openstack.org/173452 | 05:12 |
*** kebray has quit IRC | 05:34 | |
*** crc32 has quit IRC | 06:15 | |
*** tkelsey has joined #openstack-barbican | 06:39 | |
*** tkelsey has quit IRC | 06:44 | |
*** woodster_ has quit IRC | 06:50 | |
*** chlong has quit IRC | 07:35 | |
*** jaosorior has joined #openstack-barbican | 07:49 | |
openstackgerrit | Dave McCowan proposed openstack/barbican: Fix base64 decoding of payloads in one-step POST https://review.openstack.org/173396 | 07:58 |
*** dave-mccowan has quit IRC | 08:09 | |
*** tkelsey has joined #openstack-barbican | 08:13 | |
*** jamielennox is now known as jamielennox|away | 09:52 | |
*** rellerreller has joined #openstack-barbican | 12:48 | |
*** woodster_ has joined #openstack-barbican | 12:50 | |
*** elmiko has quit IRC | 13:01 | |
*** elmiko has joined #openstack-barbican | 13:01 | |
*** gitorres has quit IRC | 13:19 | |
*** david-lyle has quit IRC | 13:24 | |
*** joesavak has joined #openstack-barbican | 13:28 | |
*** gitorres has joined #openstack-barbican | 13:30 | |
*** xaeth_afk is now known as xaeth | 13:59 | |
*** paul_glass has joined #openstack-barbican | 14:02 | |
*** alee_afk is now known as alee | 14:02 | |
*** SheenaG has joined #openstack-barbican | 14:18 | |
*** rellerreller has quit IRC | 14:19 | |
*** rellerreller has joined #openstack-barbican | 14:23 | |
*** zz_dimtruck is now known as dimtruck | 14:33 | |
hockeynut | jaosorior good morning/afternoon - see my update to https://review.openstack.org/#/c/172604/5 | 14:39 |
*** SheenaG has quit IRC | 14:40 | |
redrobot | top 'o the mornin' barbicaneers | 14:51 |
*** joesavak has quit IRC | 14:53 | |
redrobot | rellerreller or kfarr around? | 14:56 |
rellerreller | redrobot give me a few minutes | 14:56 |
rellerreller | redrobot I'm available now | 15:02 |
redrobot | rellerreller heya! just looking over your comments on the KMIP plugin changes | 15:02 |
redrobot | rellerreller I tried looking for pykmip docs but didn't find any, so I just went with my best guess >_< | 15:03 |
redrobot | rellerreller sounds like we need to keep the PEM -> DER and DER -> PEM code in the util class | 15:03 |
redrobot | rellerreller and handle the conversion inside the KMIP plugin? | 15:03 |
rellerreller | redrobot Yes, we will need that code for KMIP plugin | 15:04 |
redrobot | rellerreller k, I'll make those changes. Hopefully Dave is done poking at our shared CR | 15:04 |
rellerreller | The KMIP plugin uses DER encoding, so we will need them. | 15:05 |
redrobot | rellerreller cool. any good resources for me to spin up on pykmip? | 15:06 |
rellerreller | redrobot me :) | 15:07 |
rellerreller | redrobot Let me ask Peter if he put up any docs on pypi. If not then you will need to ask us. | 15:08 |
rellerreller | redrobot Documentation is a big item for us in the near future. We just have not gotten around to much of that yet. | 15:08 |
redrobot | rellerreller hehe, alrighty. KMIP is definitely something I want to learn more about. How far along is the Server side of pykmip? | 15:09 |
alee | redrobot, I'll try it out once the next version is out there -- hopefully it will be a little more stable. I expect there will be dogtag changes required too. | 15:09 |
*** kebray has joined #openstack-barbican | 15:10 | |
rellerreller | redrobot The server side still has a ways to go. Right now most of the development is on the client side. | 15:10 |
*** kebray has quit IRC | 15:10 | |
redrobot | rellerreller I see. I was thinking that once the server is in good working order we could add a Devstack gate to barbican to test the KMIP plugin(s) against it. | 15:11 |
*** kebray has joined #openstack-barbican | 15:11 | |
rellerreller | redrobot Our strategy is to start with the client side, so we have an open source library to talk to a device. Then we will focus on server side more. | 15:11 |
rellerreller | redrobot I would like to add a gate soon. I know that there was talk of adding hardware to support this. | 15:11 |
rellerreller | redrobot tkelsey may know more | 15:12 |
redrobot | rellerreller yep, I was planning on checking up on the status with tkelsey in Vancouver. | 15:13 |
*** darrenmoffat has quit IRC | 15:13 | |
*** darrenmoffat has joined #openstack-barbican | 15:14 | |
rellerreller | redrobot I would like to see that happen. I think that will help us out a lot | 15:17 |
*** igueths has joined #openstack-barbican | 15:28 | |
igueths | jvrbanac: Ping. | 15:29 |
woodster_ | redrobot, alee, rellerreller, elmiko please review this small CR...that migration file needs to be pulled in before Kilo releases please | 15:33 |
redrobot | woodster_ I looked at it earlier, but I'm not sure what the answer to his question is. | 15:33 |
redrobot | woodster_: lisaclark said we may be able to ping our DBAs for an answer. | 15:33 |
woodster_ | redrobot, this CR is just add missing fields to the retry table...ha, sorry this is the link: https://review.openstack.org/#/c/169946/ | 15:34 |
redrobot | woodster_ oh, I thought you were talking about elmiko 's migration CR | 15:35 |
elmiko | woodster_, redrobot, yea not sure about that question | 15:35 |
elmiko | woodster_, redrobot, the weird part is that if you examine the schema (for either mysql or postgresql) before the migration i had a question about, the constraint key listed in the migration doesn't exist | 15:43 |
elmiko | and looking at the code in models.py i couldn't see the uniquie constraint on the foreignkey for project_id | 15:44 |
woodster_ | elmiko, I'll have more time to take a look at things today...I'd like to understand things a bit more as well | 15:45 |
elmiko | woodster_: cool, thanks | 15:46 |
*** joesavak has joined #openstack-barbican | 15:47 | |
*** rellerreller has quit IRC | 15:49 | |
openstackgerrit | Steve Heyman proposed openstack/python-barbicanclient: Initial setup for command line tests https://review.openstack.org/172604 | 15:53 |
*** SheenaG has joined #openstack-barbican | 15:59 | |
*** peter-hamilton has joined #openstack-barbican | 16:00 | |
*** kebray has quit IRC | 16:02 | |
*** rm_you| is now known as rm_you | 16:03 | |
rm_work | grats jraim :P | 16:14 |
*** dave-mccowan has joined #openstack-barbican | 16:20 | |
*** kebray has joined #openstack-barbican | 16:22 | |
dave-mccowan | redrobot, good morning | 16:25 |
*** dave-mccowan has quit IRC | 16:25 | |
*** dave-mccowan has joined #openstack-barbican | 16:25 | |
redrobot | good morning dave-mccowan ! I'm fixing the functional tests in our shared CR | 16:27 |
redrobot | dave-mccowan there's only one failing test, but it appears you checked in your local config file, so the gate failed for all tests since it was unable to reach the keystone service | 16:28 |
redrobot | dave-mccowan I think I can finish the CR on my own. | 16:28 |
jraim | rm_work: thanks :) | 16:30 |
jvrbanac | igueths, whats up? | 16:32 |
*** dave-mccowan has quit IRC | 16:32 | |
*** dave-mccowan has joined #openstack-barbican | 16:33 | |
igueths | jvrbanac: Not much, just wanted to make you aware of the fact that the seemingly random changes in test_validators.py were as a result of my running autopep8 against the file, not anything I did manually (assuming you weren't already that is). So what I'm going to try next is reverting those other lines to what they were previously and only focus on the new stuff I put in, although I'm not sure if | 16:36 |
igueths | this is going to cause an overall Pep8 failure in the gate as a result. | 16:36 |
redrobot | igueths I don't think it will cause a pep8 failure. My guess is that the autopep8 tool has a lower threshold for splitting a line than is needed | 16:42 |
redrobot | igueths so it auto split those lines, even though they pass pep8 without the modification. | 16:42 |
igueths | redrobot: I suppose this is possible. | 16:44 |
*** jaosorior has quit IRC | 16:52 | |
*** rellerreller has joined #openstack-barbican | 16:53 | |
peter-hamilton | rellerreller: i'm here | 16:54 |
rellerreller | redrobot peter-hamilton is our lead for pykmip | 16:55 |
rellerreller | redrobot feel free to ask him any questions you might have about the library | 16:55 |
rellerreller | Does anyone have the link to the Liberty design session proposal etherpad? I went to https://etherpad.openstack.org/p/barbican-L-design-sessions, but I received a page loading error. | 16:57 |
elmiko | rellerreller: works for me | 16:58 |
rellerreller | elmiko Thanks. That is strange. I tried a different browser and it worked. | 16:59 |
rellerreller | Thanks for giving me some insight :) | 17:00 |
*** ccneill has joined #openstack-barbican | 17:00 | |
elmiko | weird | 17:00 |
ccneill | hi guys, anyone else having issues with oslo_policy this morning? | 17:01 |
ccneill | 11:55:21 •ccneill ∞ from Barbican: 2015-04-15 11:51:08.698 49835 WARNING oslo_config.cfg [-] Option "policy_default_rule" from group "DEFAULT" is deprecated. Use option "policy_default_rule" │ | 17:01 |
ccneill | ∞ from group "oslo_policy". │ | 17:01 |
ccneill | 11:55:21 •ccneill ∞ 2015-04-15 11:51:08.698 49835 WARNING oslo_config.cfg [-] Option "policy_file" from group "DEFAULT" is deprecated. Use option "policy_file" from group "oslo_policy". │ | 17:01 |
ccneill | 11:55:53 •ccneill ∞ from nosetests: ImportError: No module named oslo_policy, in barbican/barbican/api/__init__.py │ | 17:01 |
ccneill | 11:56:51 •ccneill ∞ tried setting this in etc/barbican/barbican-api.conf: [oslo_policy] │ | 17:01 |
ccneill | 11:56:51 •ccneill ∞ policy_default_rule = default │ | 17:01 |
ccneill | 11:56:51 •ccneill ∞ policy_file=/etc/barbican/policy.json │ | 17:01 |
ccneill | 11:56:55 •ccneill ∞ no luck │ | 17:01 |
ccneill | 11:59:34 •ccneill ∞ fresh install, fresh db, up-to-date with master... I'm at a loss :/ | 17:01 |
ccneill | sorry for the spam | 17:02 |
hockeynut | I got the same result as ccneill - we made a change recently with oslo.policy IIRC | 17:03 |
ccneill | looks like it's in the requirements.txt | 17:03 |
ccneill | oslo.policy>=0.3.1,<0.4.0 # Apache-2.0 | 17:03 |
hockeynut | my oslo.policy is 0.3.2 | 17:03 |
ccneill | same | 17:04 |
hockeynut | trying with clean .tox env | 17:06 |
hockeynut | works now | 17:18 |
hockeynut | tox -r or I just zapped .tox/functional/ | 17:19 |
rellerreller | Is anyone having trouble with getting devstack running? My machine is acting funny. Not sure if I can blame devstack or not. | 17:22 |
*** kebray has quit IRC | 17:29 | |
ccneill | hockeynut: woot, looks like that worked | 17:31 |
rellerreller | I made someone else pull the latest from devstack, and their machine also exhibited the same behavior. | 17:32 |
*** kebray has joined #openstack-barbican | 17:46 | |
*** SheenaG has quit IRC | 17:47 | |
*** kebray has quit IRC | 17:49 | |
*** openstackstatus has quit IRC | 17:58 | |
*** openstackstatus has joined #openstack-barbican | 17:59 | |
*** ChanServ sets mode: +v openstackstatus | 17:59 | |
*** kebray has joined #openstack-barbican | 18:01 | |
-openstackstatus- NOTICE: Gerrit has stopped emitting events so Zuul is not alerted to changes. We will restart Gerrit shortly to correct the problem. | 18:01 | |
*** ChanServ changes topic to "Gerrit has stopped emitting events so Zuul is not alerted to changes. We will restart Gerrit shortly to correct the problem." | 18:01 | |
rellerreller | redrobot woodster_ Are we supposed to vote on the design talks today? I noticed that I am the only one to vote. I mean that's cool because I will get to hear what I want, but maybe others are interested in stuff. | 18:06 |
woodster_ | rellerreller: ha! Yeah we should be promoting that in the channel today | 18:11 |
*** ccneill has quit IRC | 18:12 | |
*** tkelsey has quit IRC | 18:15 | |
*** ChanServ changes topic to "Kilo RC1 due April 9 https://launchpad.net/barbican/+milestone/kilo-rc1" | 18:24 | |
-openstackstatus- NOTICE: Gerrit has been restarted. New patches, approvals, and rechecks between 17:30 and 18:20 UTC may have been missed by Zuul and will need rechecks or new approvals added. | 18:24 | |
hockeynut | its tax day and my wife is a CPA so this afternoon is her big firm party to celebrate survival - I'm disappearing around 3 to join in | 18:30 |
elmiko | nice! | 18:31 |
*** SheenaG has joined #openstack-barbican | 18:34 | |
alee | redrobot, dave-mccowan -- how are we doing on the patch -- is there a new version ready? | 19:07 |
redrobot | alee not yet, I have the devstack gate passing, but I'm still working on some KMIP changes | 19:08 |
redrobot | alee once I get KMIP working I'll upload a new patch. And i'll make dogtag changes in a follow up CR | 19:08 |
alee | redrobot, once you put it up, I can run it against dogtag and tell you what changes to make | 19:09 |
redrobot | alee sounds good | 19:09 |
alee | or put up a fllow-up cr myself. | 19:09 |
redrobot | alee I'm thinking maybe another 45 min or so. | 19:09 |
alee | redrobot, ok | 19:09 |
chellygel | redrobot could i get a link to the cli documentation you mentioned earlier? i am here: http://docs.openstack.org/developer/python-barbicanclient/index.html | 19:15 |
redrobot | chellygel that's the correct docs | 19:16 |
chellygel | so creating a new section for cli in this? | 19:16 |
redrobot | chellygel add a new "CLI Authentication" sub-section to the existing authentication section for the clientrc docs. | 19:17 |
chellygel | cool beans will doo, thanks redrobot :D | 19:17 |
redrobot | chellygel np :) | 19:17 |
openstackgerrit | John Vrbanac proposed openstack/python-barbicanclient: Raising errors from the client instead of ksclient https://review.openstack.org/171839 | 19:21 |
*** david-lyle has joined #openstack-barbican | 19:30 | |
*** crc32 has joined #openstack-barbican | 19:38 | |
*** ccneill has joined #openstack-barbican | 19:41 | |
*** igueths has quit IRC | 19:43 | |
*** igueths has joined #openstack-barbican | 19:46 | |
*** crc32 has quit IRC | 20:05 | |
*** crc32 has joined #openstack-barbican | 20:09 | |
*** xaeth is now known as xaeth_afk | 20:09 | |
*** ccneill_ has joined #openstack-barbican | 20:10 | |
redrobot | rellerreller I think this CR is getting too big. I'm going to make the KMIP changes in a follow-up CR. | 20:11 |
openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Fix the clientrc file to match defaults and add docs https://review.openstack.org/174076 | 20:11 |
*** ccneill has quit IRC | 20:11 | |
*** dave-mccowan has quit IRC | 20:12 | |
rellerreller | redrobot So what will the scope be? Will it be for just store_crypto or include dogtag as well? | 20:13 |
redrobot | rellerreller just store_crypto | 20:13 |
*** dave-mccowan has joined #openstack-barbican | 20:13 | |
openstackgerrit | Douglas Mendizábal proposed openstack/barbican: Fix base64 decoding of payloads in one-step POST https://review.openstack.org/173396 | 20:13 |
rellerreller | redrobot So you will have two follow-up CRs for dogtag and kmip? And they will both be included in the release this week? | 20:14 |
redrobot | rellerreller yeah... we shouldn't release until this is all fixed/tested for KMIP and DogTag | 20:14 |
redrobot | rellerreller there's no point in releasing an RC1 if we know it's broken | 20:14 |
rellerreller | redrobot That is good to hear. | 20:15 |
redrobot | rellerreller I'd rather have a late RC1 than have to turn around and release an RC2 right away. | 20:15 |
rellerreller | redrobot I am ok with that. | 20:15 |
rellerreller | redrobot Is the OpenStack powers that be ok with a possibly late RC1? | 20:15 |
redrobot | rellerreller yeah... it's already late :) | 20:16 |
rellerreller | redrobot OK, c'est la vie. | 20:16 |
dave-mccowan | redrobot, other than review and test, is there anything left for this CR? | 20:16 |
redrobot | dave-mccowan nope, I want to be done with this CR, and add changes in separate CRs | 20:17 |
redrobot | dave-mccowan I'm going to fix the KMIP secret_store now. | 20:17 |
redrobot | dave-mccowan I noticed you skipped a test in the rsa smoke tests | 20:17 |
redrobot | dave-mccowan would you mind looking into fixing it in a separate CR? | 20:18 |
dave-mccowan | redrobot, sounds good. i'll do that. | 20:18 |
*** tkelsey has joined #openstack-barbican | 20:20 | |
rellerreller | redrobot Let me know when you have something for KMIP. I can run some tests here to verify things. | 20:20 |
*** tkelsey has quit IRC | 20:24 | |
openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Adding payload flag to get secret https://review.openstack.org/174094 | 20:41 |
*** gyee has joined #openstack-barbican | 20:44 | |
*** gyee has quit IRC | 20:44 | |
*** rellerreller has quit IRC | 21:00 | |
*** gyee has joined #openstack-barbican | 21:00 | |
woodster_ | redrobot, should folks still be trying to vote on design sessions by EOD today? | 21:02 |
redrobot | woodster_ meh... I'd rather people spend the time reviewing stuff for RC1 | 21:02 |
woodster_ | redrobot, cool just checking | 21:03 |
*** ccneill_ has quit IRC | 21:06 | |
*** joesavak has quit IRC | 21:11 | |
*** ccneill_ has joined #openstack-barbican | 21:12 | |
alee | redrobot, ping | 21:22 |
redrobot | alee pong | 21:22 |
alee | redrobot, hey - where were your instructions on setting up the docker containers for the functional tests? | 21:23 |
alee | redrobot, I recall I used them to set up a keystone container and postgres container | 21:23 |
redrobot | alee https://gist.github.com/dmend/e6c5b3f0bc6913d766f6 maybe? | 21:23 |
alee | yeah - thats it .. thanks | 21:24 |
*** dave-mcc_ has joined #openstack-barbican | 21:28 | |
*** dave-mccowan has quit IRC | 21:30 | |
*** kebray has quit IRC | 21:32 | |
*** kebray has joined #openstack-barbican | 21:37 | |
alee | redrobot, hey - when I try to run the functional tests with tox -e functional, I get "ImportError: No module named oslo_policy" -- any idea? | 21:39 |
alee | redrobot, trying tox -r -e fnctional .. | 21:40 |
*** paul_glass has quit IRC | 21:43 | |
*** ccneill_ is now known as ccneill | 21:45 | |
*** jamielennox|away is now known as jamielennox | 21:46 | |
dave-mcc_ | alee, i've been getting that too. my workaround has been nosetests functionaltests, but i'd love to fix it right. my tox -e cover is also broken with the oslo_policy error | 21:48 |
alee | dave-mcc_, worked for me to do tox -r -e functional | 21:48 |
alee | redrobot, ping | 21:57 |
redrobot | alee pong | 21:57 |
alee | redrobot, need some help with my config .. | 21:57 |
alee | so I have my old containers up and it looks like keystone is running | 21:58 |
redrobot | alee can you curl localhost:5000? | 21:58 |
alee | ie. I can go to localhost:5000 and get a respionse | 21:58 |
redrobot | cool | 21:58 |
alee | redrobot, but all my functional tests are failing with 401 | 21:58 |
redrobot | alee the keystone_data.sh command adds these users: https://github.com/rackerlabs/dockerstack/blob/master/barbican/scripts/keystone_data.sh | 21:59 |
redrobot | you should be able to use teh admin_user credentials to run the functional tests | 21:59 |
redrobot | and also the barbican service credentials in the API to validate tokesn | 21:59 |
*** ccneill has quit IRC | 22:00 | |
alee | redrobot, so yeah -- I think these users should be there - as I just started the containers I had before | 22:00 |
alee | redrobot, how can I validate the usrs are there? | 22:00 |
alee | incidentally I have the following in barbican-functional.conf | 22:01 |
alee | uri=http://localhost:5000/v3 | 22:01 |
alee | version=v3 | 22:01 |
alee | username=barbican | 22:01 |
alee | project_name=service | 22:01 |
alee | password=orange | 22:01 |
alee | domain_name=Default | 22:01 |
*** xaeth_afk is now known as xaeth | 22:02 | |
redrobot | try running the keystone_data script again. If the users are there it'll give you errors about duplicate names and such | 22:02 |
alee | redrobot, is the OS_SERVICE_ENDPOINT http://localhost:5000/v2.0 ? | 22:06 |
redrobot | alee yep | 22:07 |
redrobot | alee nope, sorry | 22:07 |
redrobot | alee it's http://localhost:35357/v2.0 | 22:07 |
alee | ok - no errors - so those must not have been there | 22:09 |
*** xaeth is now known as xaeth_afk | 22:12 | |
alee | redrobot, ok - now a different error .. | 22:13 |
alee | File "/home/alee/barbican/barbican/functionaltests/common/client.py", line 141, in get_base_url | 22:13 |
alee | base_url = endpoint['key-manager'][0].get('url') | 22:13 |
alee | KeyError: 'key-manager | 22:13 |
alee | redrobot, must be missing service catalog entries? | 22:14 |
redrobot | alee yeah, I think so. | 22:14 |
redrobot | alee https://github.com/openstack/barbican/blob/master/bin/keystone_data.sh#L66-L75 | 22:14 |
alee | redrobot, cool - functional tests running -- I will check out what dogtag changes need to be made | 22:24 |
*** igueths has quit IRC | 22:39 | |
dave-mcc_ | redrobot, do you want to merge https://review.openstack.org/172819 before or after the "big one"? it still needs another +2 | 22:40 |
redrobot | dave-mcc_ I don't have a preference... the gate seems to be backed up for like 6+ hours :-\ | 22:42 |
dave-mcc_ | redbot, i guess there is a way for me to rebase on the big-one before it merges, and get it in line behind? | 22:45 |
redrobot | dave-mcc_ yeah, if you do a "git review -d 173396" to pull down our joint CR, then | 22:46 |
redrobot | dave-mcc_ "git cherry-pick SHA_FOR_NEXT_CR_IN_LINE" | 22:46 |
redrobot | then git review | 22:47 |
redrobot | it'll ask if you want to make a dependency when you submit it | 22:47 |
*** stanzi has joined #openstack-barbican | 22:48 | |
*** stanzi has quit IRC | 22:53 | |
*** stanzi has joined #openstack-barbican | 22:54 | |
*** stanzi has quit IRC | 22:54 | |
dave-mcc_ | redrobot, do you need convert_pem_to_der() functions for kmip? i have some with unit tests that i can push if you want. | 22:54 |
*** stanzi has joined #openstack-barbican | 22:54 | |
redrobot | dave-mcc_ I just wrote a bunch too, >_< | 22:55 |
redrobot | dave-mcc_ pem_to_der is easy | 22:55 |
redrobot | dave-mcc_ der to pem is a apin | 22:55 |
dave-mcc_ | redrobot, yea, i found that out. both pyopenssl and pycrypto seem to only know pkcs#1 | 22:56 |
dave-mcc_ | redrobot, i've got literals for public_der and private_der to put into keys.py for testing. have you already done that too? | 22:58 |
redrobot | dave-mcc_ not yet. let me push a WIP so you can see what I've got | 22:58 |
*** stanzi has quit IRC | 22:58 | |
*** stanzi has joined #openstack-barbican | 22:59 | |
openstackgerrit | Douglas Mendizábal proposed openstack/barbican: Fix KMIP Secret Store input/output https://review.openstack.org/174144 | 22:59 |
*** dimtruck is now known as zz_dimtruck | 22:59 | |
redrobot | dave-mcc_ https://review.openstack.org/#/c/174144/1/barbican/plugin/util/translations.py,cm | 23:00 |
dave-mcc_ | redrobot, here's what i did. http://ur1.ca/k6mne they work and only use crypto libraries. the only problem is the to_pem for private key is PKCS#1, instead of PKCS#8. | 23:03 |
*** stanzi has quit IRC | 23:03 | |
redrobot | dave-mcc_ heh... well, we need to figure out how to return a PKCS#8 :-\ | 23:04 |
dave-mcc_ | redrobot, apparently, depending on which version of pyOpenSSL you're using you can get one or the other :-/ | 23:05 |
redrobot | dave-mcc_ super lame... | 23:05 |
redrobot | dave-mcc_ what are you using for the private one? M2Crypto? | 23:06 |
dave-mcc_ | redrobot, just from Crypto.PublicKey import RSA | 23:07 |
dave-mcc_ | from OpenSSL import crypto | 23:07 |
dave-mcc_ | redrobot, i tried both for the private_key to PEM and got PKCS#1 for both of them | 23:08 |
dave-mcc_ | redrobot, "-----BEGIN RSA PRIVATE KEY-----" is the header for PKCS#1 | 23:11 |
*** chlong has joined #openstack-barbican | 23:11 | |
*** alee has quit IRC | 23:11 | |
dave-mcc_ | redrobot, so your code is representing PKCS#1 in the private key conversion | 23:12 |
*** alee has joined #openstack-barbican | 23:12 | |
reaperhulk | PEM_write_BIO_PrivateKey is what you want to call :D | 23:27 |
reaperhulk | but don't do that, that's C | 23:27 |
dave-mcc_ | redrobot, i compared the results of your conversion with what i get from the openssl command line for the keys in keys.py. http://www.fpaste.org/211476/40372142/ | 23:27 |
elmiko | woodster_: i ran into an error with the migration you have up for review | 23:29 |
dave-mcc_ | redrobot, the public key cases work in both directions. | 23:29 |
woodster_ | elmiko, ugh | 23:31 |
*** nickrmc84 has joined #openstack-barbican | 23:32 | |
*** crc32 has quit IRC | 23:32 | |
woodster_ | elmiko, yeah clearly alembic/sqlalchemy is not giving us good dialect selection :\ | 23:33 |
elmiko | woodster_: sadly no =( | 23:34 |
elmiko | woodster_: i'm not sure what the offending line wants though, i tried with a bool but that didn't do it | 23:34 |
*** arunkant has quit IRC | 23:38 | |
*** nickrmc83 has quit IRC | 23:39 | |
*** arunkant has joined #openstack-barbican | 23:39 | |
elmiko | woodster_: ok, so question. does that Column need server_default or just default? | 23:45 |
elmiko | i only ask because default='False' works for me | 23:45 |
*** stanzi has joined #openstack-barbican | 23:46 | |
woodster_ | elmiko: I believe that won't work on records already in the table | 23:47 |
elmiko | woodster_: well that's no fun | 23:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!